[Qemu-devel] Block live migration's use of type hint

2010-06-28 Thread Markus Armbruster
Block live migration appears to migrate only block devices with type hint BDRV_TYPE_HD. Others are silently skipped: static void init_blk_migration_it(void *opaque, BlockDriverState *bs) { Monitor *mon = opaque; BlkMigDevState *bmds; int64_t sectors; if (bs-type == BDRV_TYPE_HD)

[Qemu-devel] [PATCH] Another fix to VMware depth computation

2010-06-28 Thread Tian, Kevin
(patch made upon 0.12.4 release; tested on 0.12 branch; build test on master) console.h | 13 - hw/vmware_vga.c | 10 ++ qemu-common.h |1 - vl.c|8 4 files changed, 2 insertions(+), 30 deletions(-) = Another fix to VMware

Re: [Qemu-devel] [PATCH 4/7] provide opaque CPUState to files that are compiled once

2010-06-28 Thread Paolo Bonzini
On 06/27/2010 09:17 PM, Blue Swirl wrote: I'm not comfortable with this part. Accidental use of the global register variable can cause subtle bugs. I'd rather rename 'env' to something more obvious and less likely to collide, like 'global_reg_env' and always poison that. Then we could replace

[Qemu-devel] Re: Block live migration's use of type hint

2010-06-28 Thread Liran Schour
Markus Armbruster arm...@redhat.com wrote on 28/06/2010 10:26:47: From: Markus Armbruster arm...@redhat.com To: qemu-devel@nongnu.org Cc: Liran Schour/Haifa/i...@ibmil Date: 28/06/2010 10:26 Subject: Block live migration's use of type hint Block live migration appears to migrate only

Re: [Qemu-devel] VxWorks kernel for qemu emulating PowerPC?

2010-06-28 Thread hadi motamedi
It is possible to boot a VxWorks image using the x86 system emulation. You would have to create a floppy image and pass that in for Thank you very much for your reply. Can you please let me know how can I obtain more details on the implementation scenario of your proposed procedure?

[Qemu-devel] Re: qemu-kvm guest network stalls

2010-06-28 Thread William King
Is this the wrong list to get help tracking down why the network stalls under heavy load? I have been on irc talking with multiple people, some believe the problem is located in xming so it's 100% linux-bridge/ebtables, but I have no way to confirm this. I have been able to reproduce the network

Re: [Qemu-devel] [PATCH 0/7] poison TARGET_xxx for compile once object and header file cleanups

2010-06-28 Thread Paolo Bonzini
On 06/27/2010 09:32 PM, Blue Swirl wrote: From just clean up or type safety point of view, this is good stuff. But from architectural point of view, we should make it more difficult to use CPUState in device code, not easier. This may still be fine as a temporary measure, before all CPUState

Re: [Qemu-devel] Re: qemu-kvm guest network stalls

2010-06-28 Thread Stefan Hajnoczi
On Mon, Jun 28, 2010 at 9:08 AM, William King quentus...@gmail.com wrote: Is this the wrong list to get help tracking down why the network stalls under heavy load? This list is the right one. There is at least one known network stall bug:

Re: [Qemu-devel] Re: qemu-kvm guest network stalls

2010-06-28 Thread William King
Thanks for the reply Stefan. That looks to be exactly the same bug I'm dealing with here. The one difference is that I can reproduce it easily on test hardware. So I have two separate boxes that can go down(and run test code) without interfering with anything in production. My test setup has a

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/25/10 19:34, Frank Arnold wrote: We are doing KVM testing, so it is Linux. What I did is putting lines like this somewhere into vl.c and os-posix.c: fprintf(stderr, os: QEMU_OPTION_daemonize: %i, QEMU_OPTION_daemonize); fprintf(stderr, vl: QEMU_OPTION_daemonize: %i,

[Qemu-devel] Re: [PATCH 04/12] blockdev: New drive_of_blockdev()

2010-06-28 Thread Paolo Bonzini
On 06/26/2010 04:46 PM, Markus Armbruster wrote: drive_get_by_blockdev()? blockdev_to_drive()? I like drive_find_by_blockdev or drive_get_by_blockdev, in any case I'll make sure my own cpu_get_by_id is named in the same style that you choose. Paolo

[Qemu-devel] console on stdio?

2010-06-28 Thread Pascal J. Bourguignon
What option should I give to get the guest host on the host stdio? I want to launch qemu from a terminal and have access to the console there. I tried -serial stdio and -monitor stdio but this gives: chardev: opening backend stdio failed qemu: could not open serial device 'stdio': Invalid

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-28 Thread Christoph Hellwig
On Mon, Jun 28, 2010 at 10:24:49AM +0200, Kevin Wolf wrote: How would breaking compatibility help us? For the user a USB MSD is only one device, so requiring two -device parameters sounds wrong. But it is separate devices. At least the standards compliant usb storage devices just are a bride

Re: [Qemu-devel] Re: [PATCH 08/12] block: Catch attempt to attach multiple devices to a blockdev

2010-06-28 Thread Kevin Wolf
Am 28.06.2010 12:16, schrieb Christoph Hellwig: On Mon, Jun 28, 2010 at 10:24:49AM +0200, Kevin Wolf wrote: How would breaking compatibility help us? For the user a USB MSD is only one device, so requiring two -device parameters sounds wrong. But it is separate devices. At least the

Re: [Qemu-devel] Re: block: format vs. protocol, and how they stack

2010-06-28 Thread Christoph Hellwig
On Mon, Jun 21, 2010 at 06:21:09PM +0200, Markus Armbruster wrote: You describe the special case where format and protocol make some sense: you have a block driver that can transport bits in arbitrary formats, and a block driver that interprets bits without caring for transport. In the

[Qemu-devel] Re: Block live migration's use of type hint

2010-06-28 Thread Markus Armbruster
Liran Schour lir...@il.ibm.com writes: Markus Armbruster arm...@redhat.com wrote on 28/06/2010 10:26:47: From: Markus Armbruster arm...@redhat.com To: qemu-devel@nongnu.org Cc: Liran Schour/Haifa/i...@ibmil Date: 28/06/2010 10:26 Subject: Block live migration's use of type hint Block

Re: [Qemu-devel] Guest OS hangs on usb_add

2010-06-28 Thread Gianni Tedesco
On Fri, 2010-06-25 at 18:23 +0100, TJ wrote: On 06/25/10 12:32, Gianni Tedesco wrote: A device MAY provide extended descriptors in 2 ways mentioned in the spec, but ISTR finding at least one device in the wild with standard descriptors extended which were not so much used by the host but by

[Qemu-devel] [PATCH][Tracing] Fix for make parallelization.

2010-06-28 Thread Prerna Saxena
[PATCH] Restore parallel building This is based on : http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com --- Makefile |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/Makefile b/Makefile index

[Qemu-devel] Re: [PATCH][Tracing] Fix for make parallelization.

2010-06-28 Thread Stefan Hajnoczi
On Mon, Jun 28, 2010 at 06:02:37PM +0530, Prerna Saxena wrote: [PATCH] Restore parallel building This is based on : http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing Signed-off-by: Prerna Saxena pre...@linux.vnet.ibm.com Dependencies are not quite right yet: $ make

[Qemu-devel] Re: [PATCH 0/8] Fix various IO-thread breakages

2010-06-28 Thread Marcelo Tosatti
On Fri, Jun 25, 2010 at 04:56:48PM +0200, Jan Kiszka wrote: This series unbreaks -smp 1 and guest debugging in CONFIG_IOTHREAD mode. I still find the SMP scheduling in cpu_exec_all suboptimal, but at least it works now. Dependencies are:

Re: [Qemu-devel] [PATCH][RESEND] qdev-properties: Fix (u)intXX parsers

2010-06-28 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: scanf calls must not use PRI constants, they have probably the wrong size and corrupt memory. We could replace them by SCN ones, but strtol is simpler than scanf here anyway. While at it, also fix the parsers to reject garbage after the number (4096xyz was

Re: [Qemu-devel] Re: [PATCH][Tracing] Fix for make parallelization.

2010-06-28 Thread Stefan Hajnoczi
On Mon, Jun 28, 2010 at 2:46 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Mon, Jun 28, 2010 at 06:02:37PM +0530, Prerna Saxena wrote: [PATCH] Restore parallel building This is based on : http://repo.or.cz/w/qemu/stefanha.git/shortlog/refs/heads/tracing Signed-off-by: Prerna

Re: [Qemu-devel] [PATCH 4/7] provide opaque CPUState to files that are compiled once

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 8:04 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 06/27/2010 09:17 PM, Blue Swirl wrote: I'm not comfortable with this part. Accidental use of the global register variable can cause subtle bugs. I'd rather rename 'env' to something more obvious and less likely to

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-28 Thread Luiz Capitulino
On Wed, 23 Jun 2010 12:28:27 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This enables command line completion inside option strings. A list of expected key names and their

Re: [Qemu-devel] Guest OS hangs on usb_add

2010-06-28 Thread TJ
On 06/28/10 08:32, Gianni Tedesco wrote: FWIW, I am signing off on your approach :) Gianni Tedesco Thank you Gianni :) I am gonna add simple vend/prod id check to my 0x18 hack and resubmit final version. -TJ

[Qemu-devel] [PATCH] Don't reset bs-is_temporary in bdrv_open_common

2010-06-28 Thread Ryan Harper
To fix https://bugs.launchpad.net/qemu/+bug/597402 where qemu fails to call unlink() on temporary snapshots due to bs-is_temporary getting clobbered in bdrv_open_common() after being set in bdrv_open() which calls the former. We don't need to initialize bs-is_temporary in bdrv_open_common().

[Qemu-devel] [PATCH] Include sys/mman.h before qemu-options.h

2010-06-28 Thread Jes . Sorensen
From: Jes Sorensen jes.soren...@redhat.com The result of parsing qemu-options.def depends on whehter or not MAP_POPULATE is defined, so make sure to include sys/mman.h before including qemu-options.h. Reported by Frank Arnold. Signed-off-by: Jes Sorensen jes.soren...@redhat.com --- os-posix.c

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-28 Thread Jan Kiszka
Luiz Capitulino wrote: On Wed, 23 Jun 2010 12:28:27 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com This enables command line completion inside option strings. A list of expected key

[Qemu-devel] [PATCH v2] Guest OS hangs on usb_add

2010-06-28 Thread TJ
This is a small patch to sligtly intelligentify usb device and config descriptor parsing and to handle bug with certain usb device (URC MX-950) reporting device desriptor length as 0x18 instead of 18 with added vendor_id/product_id check --- hw/usb.h|5 + usb-linux.c | 37

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/25/10 19:34, Frank Arnold wrote: We are doing KVM testing, so it is Linux. What I did is putting lines like this somewhere into vl.c and os-posix.c: fprintf(stderr, os: QEMU_OPTION_daemonize: %i, QEMU_OPTION_daemonize); fprintf(stderr, vl: QEMU_OPTION_daemonize: %i,

Re: [Qemu-devel] [PATCH 0/7] poison TARGET_xxx for compile once object and header file cleanups

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 8:20 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 06/27/2010 09:32 PM, Blue Swirl wrote:  From just clean up or type safety point of view, this is good stuff. But from architectural point of view, we should make it more difficult to use CPUState in device code, not

[Qemu-devel] [PATCH] rename qemu_socket.h to qemu-socket.h for consistency

2010-06-28 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao cmc...@gmail.com --- aio.c|2 +- gdbstub.c|2 +- hw/lance.c |2 +- hw/pcnet.c |2 +- hw/virtio-9p.c |2 +- migration-exec.c |2 +- migration-fd.c |4 +- migration-tcp.c |2 +- migration-unix.c |

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 06/25/10 19:34, Frank Arnold wrote: We are doing KVM testing, so it is Linux. What I did is putting lines like this somewhere into vl.c and os-posix.c: fprintf(stderr, os: QEMU_OPTION_daemonize: %i,

[Qemu-devel] [PATCH 1/3] target-arm: fix addsub/subadd implementation

2010-06-28 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao cmc...@gmail.com --- target-arm/op_addsub.h |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target-arm/op_addsub.h b/target-arm/op_addsub.h index 29f77ba..c02c92a 100644 --- a/target-arm/op_addsub.h +++ b/target-arm/op_addsub.h @@

[Qemu-devel] [PATCH 0/0] fix ARM parallel instructions implementation bug

2010-06-28 Thread Chih-Min Chao
The three patches focuse on Bugs 595906 Bug 591320. The first is related to Bug 595906 and the other solve Bug 591320. The series are also attached in the threads, listed below https://bugs.launchpad.net/qemu/+bug/595906 https://bugs.launchpad.net/qemu/+bug/591320 [PATCH 1/3] target-arm:

[Qemu-devel] [PATCH 3/3] target-arm : fix parallel saturated subtraction implementation

2010-06-28 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao cmc...@gmail.com --- target-arm/helper.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/helper.c b/target-arm/helper.c index 63e5dc7..2dd64d9 100644 --- a/target-arm/helper.c +++ b/target-arm/helper.c @@ -2047,7 +2047,7 @@

[Qemu-devel] [PATCH 2/3] target-arm : fix thumb2 parallel add/sub opcode decoding ref : DDI0406B_arm_architecture_reference_manual_errata_markup_4_0.pdf section A6.3.1[34]

2010-06-28 Thread Chih-Min Chao
Signed-off-by: Chih-Min Chao cmc...@gmail.com --- target-arm/translate.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index a28e2ff..6fcdd7e 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -561,7

[Qemu-devel] [PATCH 7/7] kvm: Fix cpu_is_bsp() compilation warning

2010-06-28 Thread Marcelo Tosatti
From: Sheng Yang sh...@linux.intel.com Signed-off-by: Sheng Yang sh...@linux.intel.com Signed-off-by: Avi Kivity a...@redhat.com --- target-i386/kvm.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 576d3b5..a33d2fa 100644 ---

[Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2010-06-28 Thread Marcelo Tosatti
The following changes since commit 4972d592113c627d4b6ea1be5c94a85b56099afd: Stefan Weil (1): win32: Add missing function ffs are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master Andre Przywara (1): fix CPUID vendor override Jan

[Qemu-devel] [PATCH 4/7] Enable XSAVE related CPUID

2010-06-28 Thread Marcelo Tosatti
From: Sheng Yang sh...@linux.intel.com We can support it in KVM now. The 0xd leaf is queried from KVM. Signed-off-by: Sheng Yang sh...@linux.intel.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- target-i386/cpuid.c | 21 + 1 files changed, 21 insertions(+), 0

[Qemu-devel] [PATCH 3/7] kvm: Extend kvm_arch_get_supported_cpuid() to support index

2010-06-28 Thread Marcelo Tosatti
From: Sheng Yang sh...@linux.intel.com Would use it later for XSAVE related CPUID. Signed-off-by: Sheng Yang sh...@linux.intel.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm.h |2 +- target-i386/kvm.c | 19 +++ 2 files changed, 12 insertions(+),

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen jes.soren...@redhat.com wrote: On 06/28/10 17:42, Blue Swirl wrote: On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensen jes.soren...@redhat.com wrote: I figured out what was causing it. qemu-options.def has an #ifdef MAP_POPULATE in it, which isn't

[Qemu-devel] [PATCH 2/7] fix CPUID vendor override

2010-06-28 Thread Marcelo Tosatti
From: Andre Przywara andre.przyw...@amd.com the meaning of vendor_override is actually the opposite of how it is currently used :-( Fix it to allow KVM to export the non-native CPUID vendor if explicitly requested by the user. The intended behavior is: With TCG: - always inject the configured

Re: [Qemu-devel] [PATCH v4 11/23] monitor: Add completion support for option lists

2010-06-28 Thread Luiz Capitulino
On Mon, 28 Jun 2010 16:40:58 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Wed, 23 Jun 2010 12:28:27 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka jan.kis...@siemens.com

[Qemu-devel] [PATCH] monitor: Allow to exclude commands from QMP

2010-06-28 Thread Jan Kiszka
Luiz Capitulino wrote: On Mon, 28 Jun 2010 16:40:58 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Luiz Capitulino wrote: On Wed, 23 Jun 2010 12:28:27 +0200 Jan Kiszka jan.kis...@siemens.com wrote: Markus Armbruster wrote: Jan Kiszka jan.kis...@web.de writes: From: Jan Kiszka

[Qemu-devel] [PATCH 6/7] kvm: init mp_state

2010-06-28 Thread Marcelo Tosatti
Signed-off-by: Marcelo Tosatti mtosa...@redhat.com Signed-off-by: Avi Kivity a...@redhat.com --- target-i386/kvm.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 436c0c4..576d3b5 100644 --- a/target-i386/kvm.c +++

[Qemu-devel] [PATCH 1/7] kvm: Switch kvm_update_guest_debug to run_on_cpu

2010-06-28 Thread Marcelo Tosatti
From: Jan Kiszka jan.kis...@siemens.com Guest debugging under KVM is currently broken once io-threads are enabled. Easily fixable by switching the fake on_vcpu to the real run_on_cpu implementation. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Avi Kivity a...@redhat.com ---

[Qemu-devel] [PATCH 5/7] kvm: Enable XSAVE live migration support

2010-06-28 Thread Marcelo Tosatti
From: Sheng Yang sh...@linux.intel.com Signed-off-by: Sheng Yang sh...@linux.intel.com Signed-off-by: Marcelo Tosatti mtosa...@redhat.com --- kvm-all.c | 21 +++ kvm.h |2 + target-i386/cpu.h |7 ++- target-i386/kvm.c | 139

[Qemu-devel] Re: [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Paolo Bonzini
On 06/28/2010 06:03 PM, Jes Sorensen wrote: On 06/28/10 17:42, Blue Swirl wrote: On Mon, Jun 28, 2010 at 2:50 PM, Jes Sorensenjes.soren...@redhat.com wrote: I figured out what was causing it. qemu-options.def has an #ifdef MAP_POPULATE in it, which isn't being set without sys/mmap.h being

Re: [Qemu-devel] [PATCH 0/7] poison TARGET_xxx for compile once object and header file cleanups

2010-06-28 Thread Paolo Bonzini
I don't see it at all as a temporary measure. In theory, only devices compiled per-target would need access to CPUState, that's true. There is no need for any device to have access to CPUState fields. That's why this patch defines CPUState as opaque (i.e. incomplete). Granted, an opaque

Re: [Qemu-devel] [PATCH 14/17] Move daemonize handling to OS specific files

2010-06-28 Thread Jes Sorensen
On 06/28/10 18:20, Blue Swirl wrote: On Mon, Jun 28, 2010 at 4:03 PM, Jes Sorensen jes.soren...@redhat.com wrote: Yeah, the problem with tying it to CONFIG_LINUX is that older version of Linux may not support it. Looking through the list, MAP_POPULATE is really an oddball in there though, so

[Qemu-devel] [PATCH 0/4] introduce NEED_GLOBAL_ENV

2010-06-28 Thread Paolo Bonzini
Let's start the cleanups from the feature required by Blue Swirl. I also include here a baby step towards removing eminently TCG-related stuff from cpu.h. After this series, only a bunch of files will include exec-all.h, instead of getting it indirectly from cpu.h. Note that (as sworn in the

[Qemu-devel] [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable

2010-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- cpu-exec.c|2 ++ exec-all.h|4 target-alpha/exec.h |2 -- target-alpha/op_helper.c |1 + target-arm/exec.h |2 -- target-arm/op_helper.c|1 +

[Qemu-devel] [PATCH 2/4] move cpu_pc_from_tb to target-*/exec.h

2010-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-alpha/cpu.h |5 - target-alpha/exec.h |5 + target-arm/cpu.h |5 - target-arm/exec.h|6 ++ target-cris/cpu.h|5 - target-cris/exec.h |6 ++

[Qemu-devel] [PATCH 3/4] remove exec-all.h inclusion from cpu.h

2010-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- gdbstub.c |1 + hw/xen_domainbuild.c|1 + kvm-stub.c |1 + monitor.c |1 + target-alpha/cpu.h |1 - target-arm/cpu.h|1 - target-cris/cpu.h |1 -

[Qemu-devel] [PATCH 1/4] remove unused stuff from */exec.h

2010-06-28 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-alpha/exec.h |2 -- target-cris/exec.h |3 --- target-i386/exec.h |9 - target-i386/op_helper.c |2 +- target-microblaze/exec.h |2 -- target-mips/exec.h |8

[Qemu-devel] Re: [PATCH 1/4] remove unused stuff from */exec.h

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 5:17 PM, Paolo Bonzini pbonz...@redhat.com wrote: Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---  target-alpha/exec.h      |    2 --  target-cris/exec.h       |    3 ---  target-i386/exec.h       |    9 -  target-i386/op_helper.c  |    2 +-  

[Qemu-devel] Re: [PATCH 0/4] introduce NEED_GLOBAL_ENV

2010-06-28 Thread Blue Swirl
On Mon, Jun 28, 2010 at 5:17 PM, Paolo Bonzini pbonz...@redhat.com wrote: Let's start the cleanups from the feature required by Blue Swirl. I also include here a baby step towards removing eminently TCG-related stuff from cpu.h. After this series, only a bunch of files will include

[Qemu-devel] KVM Call agenda for June 29

2010-06-28 Thread Juan Quintela
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. After last week debacle, I will wait until 10 mins before call to cancel it. thanks, Juan.

[Qemu-devel] Re: [PATCH v5 2/6] MIPS: Initial support of vt82686b south bridge used by fulong mini pc

2010-06-28 Thread Juan Quintela
Huacai Chen zltjiang...@gmail.com wrote: Signed-off-by: Huacai Chen zltjiang...@gmail.com +static void superio_ioport_writeb(void *opaque, uint32_t addr, uint32_t data) +{ +int can_write; +SuperIOConfig *superio_conf = (SuperIOConfig *)opaque; Useless cast from void *. +static

[Qemu-devel] Re: [PATCH v5 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-06-28 Thread Juan Quintela
Huacai Chen zltjiang...@gmail.com wrote: Signed-off-by: Huacai Chen zltjiang...@gmail.com --- hw/usb-uhci.c | 29 + hw/usb-uhci.h |1 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..accfe2e

Re: [Qemu-devel] [PATCH 0/7] [PULL] qemu-kvm.git uq/master queue

2010-06-28 Thread Anthony Liguori
On 06/28/2010 11:14 AM, Marcelo Tosatti wrote: The following changes since commit 4972d592113c627d4b6ea1be5c94a85b56099afd: Stefan Weil (1): win32: Add missing function ffs are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master

Re: [Qemu-devel] [PATCH 4/4] require #define NEED_GLOBAL_ENV for files that need the global register variable

2010-06-28 Thread Paul Brook
diff --git a/exec-all.h b/exec-all.h index a775582..ebe88ad 100644 --- a/exec-all.h +++ b/exec-all.h @@ -353,4 +353,8 @@ extern int singlestep; /* cpu-exec.c */ extern volatile sig_atomic_t exit_request; +#ifdef NEED_GLOBAL_ENV +register CPUState *env asm(AREG0); +#endif Wouldn't it

[Qemu-devel] Re: Unusual physical address when using 64-bit BAR

2010-06-28 Thread Cam Macdonell
On Sun, Jun 27, 2010 at 2:39 AM, Avi Kivity a...@redhat.com wrote: On 06/25/2010 12:51 AM, Cam Macdonell wrote: On Tue, Jun 15, 2010 at 5:04 AM, Avi Kivitya...@redhat.com  wrote: On 06/11/2010 08:31 PM, Cam Macdonell wrote: On Mon, Apr 19, 2010 at 10:41 AM, Cam

[Qemu-devel] [PATCH 07/20] virtio-9p: Do not reset atime

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Current code resets file's atime to 0 when there is a change in mtime. This results in resetting the atime to 1970-01-01 05:30:00. For example, truncate -s 0 filename results in changing the mtime to the truncate time, but resets the atime to

[Qemu-devel] [PATCH 04/20] [V4] virtio-9p: readdir implementation for 9p2000.L

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com This patch implements the server part of readdir() implementation for 9p2000.L SYNOPSIS size[4] Treaddir tag[2] fid[4] offset[8] count[4] size[4] Rreaddir tag[2] count[4] data[count] DESCRIPTION The readdir request asks the server

[Qemu-devel] [PATCH 02/20] qemu: virtio-9p: Implement statfs support in server

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Implement statfs support in qemu server based on Sripathi's initial statfs patch. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH 18/20] virtio-9p: Implement TXATTRWALK

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com TXATTRWALK: Descend a ATTR namespace size[4] TXATTRWALK tag[2] fid[4] newfid[4] name[s] size[4] RXATTRWALK tag[2] size[8] txattrwalk gets a fid pointing to xattr. This fid can later be used to get read the xattr value. If name is NULL the

[Qemu-devel] [PATCH 05/20] virtio-9p: Compute iounit based on host filesystem block size

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Compute iounit based on the host filesystem block size and pass it to client with open/create response. Also return iounit as statfs's f_bsize for optimal block size transfers. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Reviewd-by: Sripathi Kodi

[Qemu-devel] [PATCH 09/20] virtio-9p: Implement server side of setattr for 9P2000.L protocol.

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com SYNOPSIS size[4] Tsetattr tag[2] attr[n] size[4] Rsetattr tag[2] DESCRIPTION The setattr command changes some of the file status information. attr resembles the iattr structure used in Linux kernel. It specifies which

[Qemu-devel] [PATCH 16/20] qemu: virtio-9p: Implement LOPEN

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Implement 9p2000.L version of open(LOPEN) interface in qemu 9p server. For LOPEN, no need to convert the flags to and from 9p mode to VFS mode. Synopsis: size[4] Tlopen tag[2] fid[4] mode[4] size[4] Rlopen tag[2] qid[13] iounit[4] Current qemu 9p

[Qemu-devel] [PATCH 06/20] virtio-9p: getattr server implementation for 9P2000.L protocol.

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com SYNOPSIS size[4] Tgetattr tag[2] fid[4] size[4] Rgetattr tag[2] lstat[n] DESCRIPTION The getattr transaction inquires about the file identified by fid. The reply will contain a machine-independent directory entry, laid

[Qemu-devel] [PATCH 12/20] [virtio-9p] This patch implements TLCREATE for 9p2000.L protocol.

2010-06-28 Thread Venkateswararao Jujjuri (JV)
SYNOPSIS size[4] Tlcreate tag[2] fid[4] name[s] flags[4] mode[4] gid[4] size[4] Rlcreate tag[2] qid[13] iounit[4] DESCRIPTION The Tlreate request asks the file server to create a new regular file with the name supplied, in the directory (dir) represented by fid. The mode argument

[Qemu-devel] [PATCH 13/20] qemu: virtio-9p: Implement TMKNOD

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Implement TMKNOD as part of 2000.L Work Synopsis size[4] Tmknod tag[2] fid[4] name[s] mode[4] major[4] minor[4] gid[4] size[4] Rmknod tag[2] qid[13] Description mknod asks the file server to create a device node with given device type,

[Qemu-devel] [PATCH 01/20] qemu: virtio-9p: Recognize 9P2000.L protocol

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Make 9P server recognize 9P2000.L protocol version Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p.c |6 +- hw/virtio-9p.h |6 ++ 2 files changed, 11

[Qemu-devel] [PATCH 19/20] virtio-9p: Implement TXATTRCREATE

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com TXATTRCREATE: Prepare a fid for setting xattr value on a file system object. size[4] TXATTRCREATE tag[2] fid[4] name[s] attr_size[8] flags[4] size[4] RXATTRWALK tag[2] txattrcreate gets a fid pointing to xattr. This fid can later be used

[Qemu-devel] [PATCH 08/20] [virtio-9p] Make v9fs_do_utimensat accept timespec structures instead of v9stat.

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com Currently v9fs_do_utimensat takes a V9fsStat argument and builds timespec structures. It sets tv_nsec values to 0 by default. Instead of this it should take struct timespec[2] and pass it down to the system directly. This will make it more generic and

[Qemu-devel] [PATCH 10/20] [virtio-9p] Implement TLINK for 9P2000.L

2010-06-28 Thread Venkateswararao Jujjuri (JV)
Create a Hardlink. SYNOPSIS size[4] Tlink tag[2] dfid[4] oldfid[4] newpath[s] size[4] Rlink tag[2] DESCRIPTION Create a link 'newpath' in directory pointed by dfid linking to oldfid path. Signed-off-by: Venkateswararao Jujjuri jv...@linux.vnet.ibm.com --- hw/virtio-9p-debug.c |9

[Qemu-devel] [PATCH 11/20] [virtio-9p] Define and implement TSYMLINK for 9P2000.L

2010-06-28 Thread Venkateswararao Jujjuri (JV)
This patch implements creating a symlink for TSYMLINK request and responds with RSYMLINK. In the case of error, we return RERROR. SYNOPSIS size[4] Tsymlink tag[2] fid[4] name[s] symtgt[s] gid[4] size[4] Rsymlink tag[2] qid[13] DESCRIPTION Create a symbolic link named 'name'

[Qemu-devel] [PATCH 14/20] qemu: virtio-9p: Implement TMKDIR

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com Synopsis size[4] Tmkdir tag[2] fid[4] name[s] mode[4] gid[4] size[4] Rmkdir tag[2] qid[13] Description mkdir asks the file server to create a directory with given name, mode and gid. The qid for the new directory is returned with the

[Qemu-devel] [PATCH 17/20] virtio-9p: Add fidtype so that we can do type specific operation

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com We want to add type specific operation during read/write Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- hw/virtio-9p.c | 110 ++-- hw/virtio-9p.h | 24 +++-

[Qemu-devel] [PATCH 20/20] virtio-9p: Hide user.virtfs xattr in case of mapped security.

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com With mapped security mode we use user.virtfs namespace is used to store the virtFs related attributes. So hide it from user. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: Venkateswararao Jujjuri

[Qemu-devel] Re: [PATCH 3/7] net: Introduce VLANClientState-info_dict

2010-06-28 Thread Luiz Capitulino
On Wed, 23 Jun 2010 12:39:59 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: There is no standard format when formatting VLANClientState.info_str, so it is difficult to extract information and transmit it over QMP. This patch adds info_dict, a QDict to better handle this

[Qemu-devel] Re: [PATCH 7/7] monitor/net: introduce 'info netdev' with QMP support

2010-06-28 Thread Luiz Capitulino
On Wed, 23 Jun 2010 12:40:03 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: Signed-off-by: Miguel Di Ciurcio Filho miguel.fi...@gmail.com --- monitor.c |8 +++ net.c | 70 + net.h |2 + 3 files

[Qemu-devel] [PATCH 03/20] virtio-9p: Return correct error from v9fs_remove

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: Sripathi Kodi sripat...@in.ibm.com Signed-off-by: Sripathi Kodi sripat...@in.ibm.com In v9fs_remove_post_remove() we currently ignore the error returned by the previous call to remove() and return an error only if freeing the fid fails. However, the client expects to see the error from

[Qemu-devel] Re: [PATCH 0/7] QMP: Introduce query-netdev

2010-06-28 Thread Luiz Capitulino
On Wed, 23 Jun 2010 12:39:56 -0300 Miguel Di Ciurcio Filho miguel.fi...@gmail.com wrote: This series implement the previously discussed QMP command query-netdev. There is small change in the specification from the last version: when type is tap, the attribute sndbuf have been removed.

[Qemu-devel] [PATCH 15/20] rename - change name of file or directory

2010-06-28 Thread Venkateswararao Jujjuri (JV)
From: M. Mohan Kumar mo...@in.ibm.com size[4] Trename tag[2] fid[4] newdirfid[4] name[s] size[4] Rrename tag[2] Implement the 2000.L rename operation. A new function v9fs_complete_rename is introduced that acts as a common entry point for 2000.L rename operation and 2000.U rename opearation (via

[Qemu-devel] [PATCH v6 0/7] MIPS: Initial support for fulong (Loongson-2E based) mini pc

2010-06-28 Thread chen huacai
Changes from V5: Clean up old style save/restore code

[Qemu-devel] [PATCH v6 2/6] Initial support of vt82686b south bridge used by fulong mini pc

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |2 +- hw/pci_ids.h|8 + hw/vt82c686.c | 597 +++ hw/vt82c686.h | 11 + 4 files changed, 617 insertions(+), 1 deletions(-) create mode 100644 hw/vt82c686.c

[Qemu-devel] [PATCH v6 4/6] MIPS: Initial support of VIA USB controller used by fulong mini pc

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- hw/usb-uhci.c | 28 hw/usb-uhci.h |1 + 2 files changed, 29 insertions(+), 0 deletions(-) diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c index 624d55b..3eb9832 100644 --- a/hw/usb-uhci.c +++ b/hw/usb-uhci.c @@

[Qemu-devel] [PATCH v6 5/6] MIPS: Initial support of fulong mini pc (CPU definition)

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- target-mips/mips-defs.h |4 target-mips/translate_init.c | 35 +++ 2 files changed, 39 insertions(+), 0 deletions(-) diff --git a/target-mips/mips-defs.h b/target-mips/mips-defs.h index

[Qemu-devel] [PATCH v6 1/6] MIPS: Initial support of bonito north bridge used by fulong mini pc

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target |1 + default-configs/mips64el-softmmu.mak |1 + hw/bonito.c | 809 ++ hw/mips.h|3 + 4 files changed, 814

[Qemu-devel] [PATCH v6 6/6] MIPS: Initial support of fulong mini pc (machine construction)

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.target|2 +- hw/mips_fulong2e.c | 416 2 files changed, 417 insertions(+), 1 deletions(-) create mode 100644 hw/mips_fulong2e.c diff --git a/Makefile.target

[Qemu-devel] [PATCH v6 3/6] MIPS: Initial support of VIA IDE controller used by fulong mini pc

2010-06-28 Thread Huacai Chen
Signed-off-by: Huacai Chen zltjiang...@gmail.com --- Makefile.objs|1 + default-configs/mips64el-softmmu.mak |1 + hw/ide.h |1 + hw/ide/via.c | 191 ++ 4 files changed, 194

[Qemu-devel] [Bug 599617] [NEW] qemu fail to parse command -net none

2010-06-28 Thread xudong
Public bug reported: Host OS:ia32e Guest OS :32e and pae kvm.git Commit:a63e16c655f9e68d49d6fae4275ffda16b1888b2 qemu-kvm Commit:97011c7fce92f8c0928c9e94e9896f0dca1bdeb9 Host Kernel Version:2.6.35-rc3 Bug detailed description: -- when use command qemu-system_x86 -smp 2

[Qemu-devel] [Bug 599617] Re: qemu fail to parse command -net none

2010-06-28 Thread xudong
qemu upstream has fix patch: Signed-off-by: Amit Shah amit.s...@redhat.com --- net.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/net.c b/net.c index 4cb93ed..b681233 100644 --- a/net.c +++ b/net.c @@ -1119,7 +1119,7 @@ int net_client_init(Monitor *mon, QemuOpts

[Qemu-devel] KVM call agenda for June 29

2010-06-28 Thread Chris Wright
Please send in any agenda items you are interested in covering. If we have a lack of agenda items I'll cancel the week's call. thanks, -chris

[Qemu-devel] Re: [PATCH] device-assignment: Rework name of assigned pci device

2010-06-28 Thread Markus Armbruster
Hidetoshi Seto seto.hideto...@jp.fujitsu.com writes: Hao, Xudong xudong@intel.com writes: When assign one PCI device, qemu fail to parse the command line: qemu-system_x86 -smp 2 -m 1024 -hda /path/to/img -pcidevice host=00:19.0 Error: qemu-system-x86_64: Parameter 'id' expects an