[Qemu-devel] [Bug 670776] [NEW] Build errors on TEGRA2(ubuntu), testandset()

2010-11-04 Thread hotdigi
Public bug reported: Build errors on TEGRA2(ubuntu) /tmp/ccqt9Y5t.s: Assembler messages: /tmp/ccqt9Y5t.s:1899: Error: selected processor does not support Thumb mode 'swp r4, r4, [r2]' /tmp/ccqt9Y5t.s:1974: Error: selected processor does not support Thumb mode 'swp r5, r5, [ip]' make[1]: ***

[Qemu-devel] [Bug 670776] Re: testandset

2010-11-04 Thread hotdigi
Build errors on TEGRA2(ubuntu) /tmp/ccqt9Y5t.s: Assembler messages: /tmp/ccqt9Y5t.s:1899: Error: selected processor does not support Thumb mode 'swp r4, r4, [r2]' /tmp/ccqt9Y5t.s:1974: Error: selected processor does not support Thumb mode 'swp r5, r5, [ip]' make[1]: *** [exec.o Error 1 **

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Wed, Nov 03, 2010 at 06:22:11PM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Wed, Nov 03, 2010 at 04:18:18PM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Wed, Nov 03, 2010 at 02:39:52PM

Re: [Qemu-devel] Re: [PATCH] Implement a virtio GPU transport

2010-11-04 Thread Alon Levy
On Wed, Nov 03, 2010 at 06:03:50PM +, Ian Molton wrote: On 01/11/10 13:28, Anthony Liguori wrote: On 11/01/2010 06:53 AM, Alon Levy wrote: While we (speaking as part of the SPICE developers) want to have the same support in our virtual GPU for 3d as we have for 2d, we just don't at this

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-04 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: Add deriver_name to DeviceInfo to use in device path building. In Typo deriver. Same in subject. contrast to name driver_name should refer to functionality device provides instead of particular device model like name does. Why is that useful in a device

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: But why order of device creation is important? It shouldn't be if we want to move HW description into config file. We even may allow creating piix3-ide with only second IDE bus, but not first. That's not how buses work in

Re: [Qemu-devel] Re: [PATCHv2 0/8 RFC] boot order specification

2010-11-04 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Sun, Oct 31, 2010 at 06:25:53PM -0400, Kevin O'Connor wrote: On Sun, Oct 31, 2010 at 01:40:01PM +0200, Gleb Natapov wrote: This is current sate of the patch series for people to comment on. I tried to use open firmware naming scheme to specify device

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 10:20:18AM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Add deriver_name to DeviceInfo to use in device path building. In Typo deriver. Same in subject. Heh. contrast to name driver_name should refer to functionality device provides

[Qemu-devel] [PULL 00/10] Block patches

2010-11-04 Thread Kevin Wolf
The following changes since commit 5fc9cfedfa09199e10b5f9b67dcd286bfeae4f7a: Fold send_all() wrapper unix_write() into one function (2010-11-03 12:48:09 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Blue Swirl (1): block: avoid a warning

[Qemu-devel] [PATCH 09/10] virtio-blk: Handle immediate flush failure properly

2010-11-04 Thread Kevin Wolf
Fix virtio-blk to use the usual completion path that involves werror handling instead of directly completing the request in cases where bdrv_aio_flush returns NULL. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/virtio-blk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

[Qemu-devel] [PATCH 10/10] scsi-disk: Fix immediate failure of bdrv_aio_*

2010-11-04 Thread Kevin Wolf
Fix scsi-disk to use the usual completion paths that involve rerror/werror handling instead of directly completing the requests in cases where bdrv_aio_readv/writev returns NULL. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c | 11 ++- 1 files changed, 6 insertions(+), 5

[Qemu-devel] [PATCH 03/10] scsi-disk: Complete failed requests in scsi_disk_emulate_command

2010-11-04 Thread Kevin Wolf
This pulls the request completion for error cases from the caller to scsi_disk_emulate_command. This should not change semantics, but allows to reuse scsi_handle_write_error() for flushes in the next patch. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 02/10] block: Allow bdrv_flush to return errors

2010-11-04 Thread Kevin Wolf
This changes bdrv_flush to return 0 on success and -errno in case of failure. It's a requirement for implementing proper error handle in users of bdrv_flush. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 21

[Qemu-devel] [PATCH 05/10] vpc: Implement bdrv_flush

2010-11-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vpc.c | 21 + 1 files changed, 13 insertions(+), 8 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index e50509e..416f489 100644 --- a/block/vpc.c +++ b/block/vpc.c @@ -439,6 +439,10 @@ static int

[Qemu-devel] Re: [PULL 00/10] Block patches

2010-11-04 Thread Anthony Liguori
On 11/04/2010 08:15 AM, Kevin Wolf wrote: The following changes since commit 5fc9cfedfa09199e10b5f9b67dcd286bfeae4f7a: Fold send_all() wrapper unix_write() into one function (2010-11-03 12:48:09 -0500) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony

[Qemu-devel] [PATCH 04/10] scsi-disk: Implement werror for flushes

2010-11-04 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/scsi-disk.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c index 96acfe3..6815239 100644 --- a/hw/scsi-disk.c +++

[Qemu-devel] [PATCH 08/10] ide: Handle immediate bdrv_aio_flush failure

2010-11-04 Thread Kevin Wolf
If bdrv_aio_flush returns NULL, this should be treated as an error. Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/ide/core.c | 12 +--- 1 files changed, 9 insertions(+), 3 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index bc3e916..484e0ca 100644 --- a/hw/ide/core.c +++

[Qemu-devel] [PATCH 07/10] block: avoid a warning on 64 bit hosts with long as int64_t

2010-11-04 Thread Kevin Wolf
From: Blue Swirl blauwir...@gmail.com When building on a 64 bit host which uses 'long' for int64_t, GCC emits a warning: CCblock/blkverify.o /src/qemu/block/blkverify.c: In function `blkverify_verify_readv': /src/qemu/block/blkverify.c:304: warning: long long int format, long unsigned int

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Kevin Wolf
Am 04.11.2010 14:14, schrieb Anthony Liguori: On 11/04/2010 07:54 AM, Kevin Wolf wrote: Am 27.10.2010 20:19, schrieb Anthony Liguori: Signed-off-by: Anthony Liguorialigu...@us.ibm.com diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10

Re: [Qemu-devel] [PATCH] block: fix the use of protocols in backing files

2010-11-04 Thread Anthony Liguori
On 11/04/2010 07:54 AM, Kevin Wolf wrote: Am 27.10.2010 20:19, schrieb Anthony Liguori: Signed-off-by: Anthony Liguorialigu...@us.ibm.com diff --git a/block.c b/block.c index 1a965b2..00b6f21 100644 --- a/block.c +++ b/block.c @@ -603,10 +603,16 @@ int bdrv_open(BlockDriverState *bs, const

[Qemu-devel] Re: [RFC][RESEND][PATCH v1 02/15] virtproxy: qemu-vp, standalone daemon skeleton

2010-11-04 Thread Michael Roth
On 11/03/2010 05:47 PM, Adam Litke wrote: On Wed, 2010-11-03 at 10:27 -0500, Michael Roth wrote: +/* mirror qemu I/O-related code for standalone daemon */ +typedef struct IOHandlerRecord { +int fd; +IOCanReadHandler *fd_read_poll; +IOHandler *fd_read; +IOHandler *fd_write; +

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: But why order of device creation is important? It shouldn't be if we want to move HW description into config file. We even may allow creating piix3-ide with only second IDE bus, but not

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-04 Thread Markus Armbruster
Gleb Natapov g...@redhat.com writes: On Thu, Nov 04, 2010 at 10:20:18AM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Add deriver_name to DeviceInfo to use in device path building. In Typo deriver. Same in subject. Heh. contrast to name driver_name should

Re: [Qemu-devel] [PATCHv2 4/8] Store IDE bus id in IDEBus structure for easy access.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 03:22:50PM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Thu, Nov 04, 2010 at 09:46:57AM +0100, Markus Armbruster wrote: But why order of device creation is important? It shouldn't be if we want to move HW description into config file.

Re: [Qemu-devel] [PATCHv2 1/8] Introduce deriver_name field to DeviceInfo structure.

2010-11-04 Thread Gleb Natapov
On Thu, Nov 04, 2010 at 03:58:03PM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: On Thu, Nov 04, 2010 at 10:20:18AM +0100, Markus Armbruster wrote: Gleb Natapov g...@redhat.com writes: Add deriver_name to DeviceInfo to use in device path building. In Typo

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-04 Thread Ryan Harper
* Michael S. Tsirkin m...@redhat.com [2010-11-03 16:46]: On Wed, Nov 03, 2010 at 03:59:29PM -0500, Ryan Harper wrote: * Michael S. Tsirkin m...@redhat.com [2010-11-03 13:03]: On Wed, Nov 03, 2010 at 12:29:10PM -0500, Ryan Harper wrote: * Markus Armbruster arm...@redhat.com [2010-11-03

Re: [Qemu-devel] [PATCH 0/3] v4 Decouple block device removal from device removal

2010-11-04 Thread Michael S. Tsirkin
On Thu, Nov 04, 2010 at 11:45:51AM -0500, Ryan Harper wrote: OK. With netdev_del and drive_unplug commands (not sure if we care to change the names to be similar, maybe blockdev_del) in qemu, we can then implement the following in libvirt: 1) detach-device invocation 2) issue device_del to

[Qemu-devel] [PATCH] arm: fix ldrexd/strexd

2010-11-04 Thread Peter Maydell
Correct ldrexd and strexd code to always read and write the high word of the 64-bit value from addr+4. Also make ldrexd and strexd agree that for a 64 bit value the address in env-exclusive_addr is that of the low word. This fixes the issues reported in https://bugs.launchpad.net/qemu/+bug/670883

Re: [Qemu-devel] [PATCH 1/2] monitor: add sub_args_type for second level parameters

2010-11-04 Thread Luiz Capitulino
On Thu, 21 Oct 2010 08:37:19 +0200 Alon Levy al...@redhat.com wrote: --- hmp-commands.hx |1 + monitor.c | 13 - 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/hmp-commands.hx b/hmp-commands.hx index 3014b17..289fbcb 100644 --- a/hmp-commands.hx

[Qemu-devel] [PATCHv2 1/2] char: separate device and system fd handlers

2010-11-04 Thread Michael S. Tsirkin
Create separate lists for system and device fd handlers. Device handlers will not run while vm is stopped. By default all fds are assumed system so they will keep running as before. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- qemu-char.h |6 +++- qemu-kvm.c |2 +- qemu-tool.c

[Qemu-devel] [PATCHv2 2/2] tap: mark fd handler as device

2010-11-04 Thread Michael S. Tsirkin
There's no reason for tap to run when VM is stopped. If we let it, it confuses the bridge on TX and corrupts DMA memory on RX. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/vhost_net.c |2 +- net/tap.c |3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] Re: [RFC][RESEND][PATCH v1 09/15] virtproxy: add handler for data packets

2010-11-04 Thread Michael Roth
On 11/03/2010 07:46 PM, Adam Litke wrote: On Wed, 2010-11-03 at 10:28 -0500, Michael Roth wrote: Process VPPackets coming in from channel and send them to the appropriate server/client connections. Signed-off-by: Michael Rothmdr...@linux.vnet.ibm.com --- virtproxy.c | 42

[Qemu-devel] Re: [RFC][RESEND][PATCH v1 13/15] virtproxy: add read handler for proxied connections

2010-11-04 Thread Michael Roth
On 11/03/2010 08:21 PM, Adam Litke wrote: On Wed, 2010-11-03 at 10:28 -0500, Michael Roth wrote: reads data from client/server connections as they become readable, then sends the data over the channel Signed-off-by: Michael Rothmdr...@linux.vnet.ibm.com --- virtproxy.c | 80

[Qemu-devel] Re: [RFC][RESEND][PATCH v1 00/15] virtproxy: host/guest communication layer

2010-11-04 Thread Michael Roth
On 11/03/2010 06:44 PM, Adam Litke wrote: You've got a lot of objects interacting with one another in virtproxy. I think it would help other reviewers if you could describe the relationships between the entities such as: VPDriver, VPConn, VPChannel, VPIForward, VPOForward, etc. This patch

[Qemu-devel] [patch] performance counters from inside of Qemu

2010-11-04 Thread Vince Weaver
Hello The following patch enables simulated perf event support inside of Qemu for x86_64 systems. It enables support for the AMD performance MSRs enough to return values for the retired_instructions (both user and kernel) and cpu_clk_unhalted events. This is mostly a proof of concept, I'm

Re: [Qemu-devel] [PATCH 0/7] scsi and megasas update

2010-11-04 Thread Alexander Graf
On 15.06.2010, at 11:15, Hannes Reinecke wrote: Hi all, I've run an I/O exerciser against the megasas emulation and found quite some issues, both with the HBA and the SCSI emulation. - SG_IO returns -EDOM if the internal queue is exhausted; we should be mapping this to QUEUE_FULL. -

[Qemu-devel] [PATCH] multiboot: Prevent loading of x86_64 images

2010-11-04 Thread Adam Lackorzynski
A via -kernel supplied x86_64 ELF image is being started in 32bit mode. Detect and exit if a 64bit image has been supplied. Signed-off-by: Adam Lackorzynski a...@os.inf.tu-dresden.de Acked-by: Alexander Graf ag...@suse.de --- hw/multiboot.c |6 ++ 1 files changed, 6 insertions(+), 0

[Qemu-devel] [PATCH v2 3/6] backdoor: declare host-side backdoor helpers

2010-11-04 Thread Lluís
These helpers must be implemented by the user on libbackdoor.a. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- backdoor/helper.h | 21 + 1 files changed, 21 insertions(+), 0 deletions(-) create mode 100644 backdoor/helper.h diff --git a/backdoor/helper.h

[Qemu-devel] [PATCH v2 1/6] [arm m68k] move helpers.h to helper.h

2010-11-04 Thread Lluís
This provides a consistent naming scheme across all targets. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- target-arm/helper.c|2 target-arm/helper.h| 450 target-arm/helpers.h | 450

[Qemu-devel] [PATCH v2 5/6] backdoor: [i386] provide and implement intruction-based backdoor interface

2010-11-04 Thread Lluís
Take the unused CPUID 0x40001xxx range as the backdoor instruction. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- backdoor/guest.h| 21 + target-i386/cpuid.c | 27 +++ target-i386/helper.h|4 target-i386/translate.c

[Qemu-devel] [RFC][PATCH v2 0/4] trace-gen: support for trace points in code-generation routines

2010-11-04 Thread Lluís
XXX: Must be applied on top of the 'trace-instrument' patch series Adds a new optional keyword (gen) to the syntax in trace-events. When specified, this event property will generate an extra set of functions that provide the ability to inject trace points into TCG-generated code. Note that the

[Qemu-devel] [PATCH v2 2/6] backdoor: handle config-time activation

2010-11-04 Thread Lluís
Add a '--with-backdoor' configuration option pointing to user-provided backdoor callback implementation. Make is invoked on the user-provided directory, which must build a static library containing, at least, the implementation of the backdoor helpers. Signed-off-by: Lluís Vilanova

[Qemu-devel] [RFC][PATCH v2 0/6] backdoor: instruction-based guest-to-QEMU backdoor communication channel

2010-11-04 Thread Lluís
Provides the ability for the guest to communicate with user-provided code inside QEMU itself. This backdoor communication channel is based on using instructions, as opposed to methods based on MMIO/PIO or virtproxy/virtagent. Then, these instructions are redirected to a set of user-provided

[Qemu-devel] [PATCH v2 2/3] trace-instrument: let the user override events generated by 'tracetool'

2010-11-04 Thread Lluís
Add a new event keyword (instrument) that lets the user provide her own implementation of tracing events. Still, tracetool's original implementation is accessible through function '_trace_##name' instead of 'trace_##name' (in case the user only wants to wrap around the event). Additionally, a

[Qemu-devel] [PATCH v2 1/4] trace-gen: gracefully handle TCG types in trace-events

2010-11-04 Thread Lluís
Some trace events with the gen property will need to use TCG arguments. As such, modify 'tracetool' to gracefully handle these types and let the backend code transliterate these types into their native counterpart. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- tracetool | 137

[Qemu-devel] [PATCH v2 3/4] trace-gen: [all] include trace-helper.h on all helper.h files

2010-11-04 Thread Lluís
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- target-alpha/helper.h |2 ++ target-arm/helper.h|2 ++ target-cris/helper.h |2 ++ target-i386/helper.h |2 ++ target-m68k/helper.h |2 ++ target-microblaze/helper.h |2 ++

[Qemu-devel] [PATCH v2 6/6] backdoor: add a simple example

2010-11-04 Thread Lluís
Provides a guest application that exercices the instruction-based backdoor communication, as well as a backdoor callback implementation that prints the guest requests. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- .gitignore |1 +

[Qemu-devel] [PATCH v2 4/6] backdoor: declare guest-side interface macros

2010-11-04 Thread Lluís
Header for the user to include when compiling guest applications that want to communicate with QEMU through backdoor instructions. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- backdoor/guest.h | 33 + 1 files changed, 33 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH v2 3/3] trace-instrument: handle config-time activation

2010-11-04 Thread Lluís
Add a '--with-instrument' configuration option pointing to user-provided instrumentation callbacks. Make is invoked on the user-provided directory, which must build a static library that might contain extra code needed by the user-provided instrumentation. Signed-off-by: Lluís Vilanova

[Qemu-devel] [PATCH v2 2/4] trace-gen: auto-generate TCG helper routines for tracing

2010-11-04 Thread Lluís
Auto-generates file trace-helper.h to provide TCG helpers and trace-helper.c to proxy these helpers onto trace event routines. Only trace events with the 'gen' property are affected. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- .gitignore |2 + Makefile| 15 +++

[Qemu-devel] [PATCH v2 4/4] trace-gen: auto-generate wrappers to call TCG trace helpers

2010-11-04 Thread Lluís
Auto-generates file trace-gen.h with instrumentable wrappers to generate calls to TCG trace helpers. Such wrappers are named 'trace_gen_##name', also reachable as 'trace_gen_##name##_backend' when instrumented. Events with the gen property are also able to use TCG types on the trace event

[Qemu-devel] [RFC][PATCH v2 0/3] trace-instrument: let the user wrap/override code generated from trace-events

2010-11-04 Thread Lluís
XXX: 'tracetool' could be simplified by never generating real tracing code for events with the disable property (not even with the 'simple' backend). XXX: Must be applied on top of the 'backdoor' patch series Adds a new optional keyword (instrument) to the syntax in trace-events. When

[Qemu-devel] [PATCH] [Seabios] Over 4GB address ranges for 64bit PCI BARs

2010-11-04 Thread Alexey Korolev
Hi, We have seen some issues with 64bit PCI address and large BAR region support in seabios. On attempting to register a 64bit BAR of 1GB size we had some strange failures in qemu. After some debugging we find out that source of the issue was in seabios PCI enumeration code. The issue takes

[Qemu-devel] Re: [PATCH] [Seabios] Over 4GB address ranges for 64bit PCI BARs

2010-11-04 Thread Isaku Yamahata
Hi. The current BAR allocation doesn't check overflow and some patches are floating around which aren't merged yet. There are several issues. - overflow check This should be fixed. Some patches are proposed. None hasn't been merged yet. Your patch also addresses this issue.