[Qemu-devel] KVM call agenda for Nov 16

2010-11-15 Thread Chris Wright
Please send in any agenda items you are interested in covering. thanks, -chris

Re: [Qemu-devel] virtio-blk broken after system reset

2010-11-15 Thread Anthony Liguori
On 11/13/2010 04:09 AM, Jan Kiszka wrote: There is also real hw out there that goes into an error state if it's misprogrammed. I think we have to remove all those premature exits. They also prevent handing the device inside the guest to an untrusted driver (relevant once we have IOMMU

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Stefan Weil
Am 15.11.2010 22:07, schrieb Anthony Liguori: On 11/15/2010 01:52 PM, Mike Ryan wrote: I'll clarify/elaborate a bit: When using a multicast socket, the OS chooses a default physical interface to send packets. The patch I've supplied allows the user to select the interface. Suppose you have a

Re: [Qemu-devel] [PATCH] add a command line option to specify the interface to send multicast packets on

2010-11-15 Thread Mike Ryan
On Mon, Nov 15, 2010 at 03:07:51PM -0600, Anthony Liguori wrote: snip Thanks. Second question is how portable is SIOCGIFADDR? I suspect that's very Linux-centric.. It ostensibly exists in FreeBSD, but I can't get master to compile under 7.3-RELEASE or 8.1-STABLE. Given that it is

[Qemu-devel] [PATCH] slirp: Remove unused code for bad sprintf

2010-11-15 Thread Stefan Weil
Neither DECLARE_SPRINTF nor BAD_SPRINTF are needed for QEMU. QEMU won't support systems with missing or bad declarations for sprintf. The unused code was detected while looking for functions with missing format checking. Instead of adding GCC_FMT_ATTR, the unused code was removed. Cc: Blue Swirl

Re: [Qemu-devel] Re: [Try2][PATCH] Initial implementation of a mpeg1 layer2 streaming audio driver.

2010-11-15 Thread François Revol
Le 15 nov. 2010 à 20:30, Anthony Liguori a écrit : I'll see if I can buffer a bit more in the twolame code and if it helps, then I'll try to merge with the failed attempts I have around at using external progs. Okay, but my thinking was that we'd do something like: audio_capture

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Michael S. Tsirkin
On Mon, Nov 15, 2010 at 03:05:39PM -0600, Anthony Liguori wrote: On 11/15/2010 02:53 PM, Stefan Hajnoczi wrote: vhost has a solution for this: register a VMChangeStateHandler function that stops ioeventfd while vm_stop(0) is in effect. Then poll to see if there is work pending. I will

[Qemu-devel] Re: [PATCH] device-assignment: register a reset function

2010-11-15 Thread Jan Kiszka
[Wrong list, it's not upstream yet. I'm migrating the thread to kvm.] Am 15.11.2010 12:33, Bernhard Kohl wrote: This is necessary because during reboot of a VM the assigned devices continue DMA transfers which causes memory corruption. Signed-off-by: Thomas Ostler thomas.ost...@nsn.com

Re: [Qemu-devel] Re: [PATCHv2 2/2] tap: mark fd handler as device

2010-11-15 Thread Anthony Liguori
On 11/15/2010 04:44 PM, Michael S. Tsirkin wrote: So I'm not sure I understand what is proposed here. Care posting a patch? I *think* just adding: if (vm_running == 0) { return qemu_net_queue_append(queue, sender, flags, data, size, NULL); } To qemu_net_queue_send() along with a

[Qemu-devel] [PATCH 1/4] virtio-blk: Convert fprintf() to error_report()

2010-11-15 Thread Stefan Hajnoczi
Errors should be logged using error_report() so they go to the appropriate monitor. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-blk.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-blk.c b/hw/virtio-blk.c index 49528a9..e5f9b27

[Qemu-devel] [RFC][PATCH v3 00/21] virtproxy: host/guest communication layer

2010-11-15 Thread Michael Roth
OVERVIEW: Virtproxy proxies and multiplexes network/unix socket streams over a data channel between a host and a guest (currently network connections, emulated serial, or virtio-serial channels are supported). This allows for services such as guest data collection agents, host/guest file

[Qemu-devel] [RFC][PATCH v3 04/21] virtproxy: list look-up functions conns/oforwards/iforwards

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 44 1 files changed, 44 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 3686c77..2cfd905 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -151,3 +151,47

[Qemu-devel] [RFC][PATCH v3 09/21] virtproxy: interfaces to set/remove/handle VPOForwards

2010-11-15 Thread Michael Roth
Functions to add listener FDs (oforwards) which set up proxied connections to associated service, and the corresponding handler function to process to new connections to said FDs and initialize new client connections to the associated remote server over the channel Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH v3 03/21] virtproxy: add debug functions for virtproxy core

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 8f18d83..3686c77 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -13,6 +13,23 @@ #include virtproxy.h

[Qemu-devel] [RFC][PATCH v3 01/21] virtproxy: base data structures and constants

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 136 +++ virtproxy.h | 34 +++ 2 files changed, 170 insertions(+), 0 deletions(-) create mode 100644 virtproxy.c create mode 100644 virtproxy.h diff

[Qemu-devel] [RFC][PATCH v3 10/21] virtproxy: add handler for data packets

2010-11-15 Thread Michael Roth
Process VPPackets coming in from channel and send them to the appropriate server/client connections. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 42 ++ 1 files changed, 42 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [RFC][PATCH v3 02/21] virtproxy: qemu-vp, standalone daemon skeleton

2010-11-15 Thread Michael Roth
Daemon to be run in guest, or on host in standalone mode. (re-)implements some qemu utility functions used by core virtproxy.c code via wrapper functions. For built-in virtproxy code we will define these wrapper functions in terms of qemu's built-in implementations. Main logic will come in a

[Qemu-devel] [RFC][PATCH v3 13/21] virtproxy: interfaces to set/remove VPIForwards

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 59 +++ virtproxy.h |2 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 01a36c2..b683ee6 100644 ---

[Qemu-devel] [RFC][PATCH v3 06/21] virtproxy: add accept handler for communication channel

2010-11-15 Thread Michael Roth
This accept()'s connections to the socket we told virtproxy to listen for the channel connection on and sets the appropriate read handler for the resulting FD. This is only used only for network-based channels and will most likely be dropped with the introduction of the virtproxy chardev.

[Qemu-devel] [RFC][PATCH v3 12/21] virtproxy: add vp_handle_packet()

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 23 +++ 1 files changed, 23 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 0cc8950..01a36c2 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -464,6 +464,29 @@ static int

[Qemu-devel] [RFC][PATCH v3 14/21] virtproxy: use new option list in virtproxy.c

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index b683ee6..9e1745f 100644 --- a/virtproxy.c +++ b/virtproxy.c @@ -764,7 +764,7 @@ int vp_set_iforward(VPDriver *drv, const

[Qemu-devel] [RFC][PATCH v3 07/21] virtproxy: add read handler for communication channel

2010-11-15 Thread Michael Roth
Handle data coming in over the channel as VPPackets: Process control messages and forward data from remote client/server connections to the appropriate server/client FD on our end. We also provide here a helper function to process a stream of packets from the channel. Signed-off-by: Michael Roth

[Qemu-devel] [RFC][PATCH v3 19/21] virtproxy: qemu integration, add virtproxy to Makefile.targets

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile.target |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Makefile.target b/Makefile.target index 91e6e74..f08c435 100644 --- a/Makefile.target +++ b/Makefile.target @@ -164,7 +164,7 @@ endif

[Qemu-devel] [RFC][PATCH v3 11/21] virtproxy: add handler for control packet

2010-11-15 Thread Michael Roth
Process control packets coming in over the channel. This entails setting up/tearing down connections to local services initiated from the other end of the channel. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 154

[Qemu-devel] [RFC][PATCH v3 16/21] virtproxy: add option parser helper vp_parse()

2010-11-15 Thread Michael Roth
This routine will parse iforward/oforward options for both qemu-vp and the virtproxy chardev Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 77 +++ virtproxy.h |1 + 2 files changed, 78 insertions(+), 0

[Qemu-devel] [RFC][PATCH v3 20/21] virtproxy: qemu-vp, main logic

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- qemu-vp.c | 368 ++- virtproxy.c | 24 2 files changed, 367 insertions(+), 25 deletions(-) diff --git a/qemu-vp.c b/qemu-vp.c index 5075cdc..cfd2a69 100644 --- a/qemu-vp.c

[Qemu-devel] [RFC][PATCH v3 17/21] virtproxy: add virtproxy-builtin.c for compat defs

2010-11-15 Thread Michael Roth
Virtproxy relies on routines defined within qemu-vp which mirror various i/o related operations in qemu to provide similar functionality for the guest daemon. When building virtproxy as part of qemu rather than qemu-vp we need these definitions to provide those functions in terms of the original

[Qemu-devel] [RFC][PATCH v3 18/21] virtproxy: qemu integration, add virtproxy chardev

2010-11-15 Thread Michael Roth
This allows us to create a virtproxy instance via a chardev. It can now be created with something like: qemu -chardev virtproxy,id=vp1 \ -device virtio-serial \ -device virtserialport,chardev=vp1 In the future the ability to add oforwards/iforwards in the command-line invocation and

[Qemu-devel] [RFC][PATCH v3 05/21] virtproxy, add vp_channel_send_all

2010-11-15 Thread Michael Roth
This handles sending of data to channel fd (qemu-vp in guest) or the device associated with the virtproxy chardev for the host depending on the context. vp_chr_read() wraps qemu_chr_read(), it'll be defined later in virtproxy-builtin.c, and noop'd in the guest agent via qemu-vp.c. Signed-off-by:

[Qemu-devel] [RFC][PATCH v3 08/21] virtproxy: add vp_new() VPDriver constructor

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 40 virtproxy.h |6 ++ 2 files changed, 46 insertions(+), 0 deletions(-) diff --git a/virtproxy.c b/virtproxy.c index 091a223..401d51c 100644 --- a/virtproxy.c +++

[Qemu-devel] [RFC][PATCH v3 15/21] virtproxy: add read handler for proxied connections

2010-11-15 Thread Michael Roth
reads data from client/server connections as they become readable, then sends the data over the channel Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- virtproxy.c | 114 +++ virtproxy.h |1 + 2 files changed, 115

Re: [Qemu-devel] How to detect a stopped guest os?

2010-11-15 Thread Mulyadi Santosa
On Tue, Nov 16, 2010 at 02:54, Wilhelm wilhelm.me...@fh-kl.de wrote: Hello, I know, this is not the right place to ask, but I wasn't abled to find a users mailing list. The question: is there any qemu (monitor) command to detect if the guest os has stopped / poweroff? have you checked info

[Qemu-devel] [RFC][PATCH v3 21/21] virtproxy: Makefile/configure changes to build qemu-vp

2010-11-15 Thread Michael Roth
Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- .gitignore |1 + Makefile |4 +++- configure |1 + 3 files changed, 5 insertions(+), 1 deletions(-) diff --git a/.gitignore b/.gitignore index a43e4d1..da307d2 100644 --- a/.gitignore +++ b/.gitignore @@ -31,6 +31,7 @@

[Qemu-devel] [PATCH 4/4] virtio-pci: Convert fprintf() to error_report()

2010-11-15 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-pci.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c index 729917d..b9d0349 100644 --- a/hw/virtio-pci.c +++ b/hw/virtio-pci.c @@ -254,8 +254,8 @@ static void

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Kevin O'Connor
On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM -0500, Kevin O'Connor wrote: Why not just return a newline

[Qemu-devel] [PATCH 3/4] virtio-net: Convert fprintf() to error_report()

2010-11-15 Thread Stefan Hajnoczi
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- hw/virtio-net.c | 41 - 1 files changed, 20 insertions(+), 21 deletions(-) diff --git a/hw/virtio-net.c b/hw/virtio-net.c index 7e1688c..1d61f19 100644 --- a/hw/virtio-net.c +++

[Qemu-devel] Re: [PATCHv4 15/15] Pass boot device list to firmware.

2010-11-15 Thread Gleb Natapov
On Mon, Nov 15, 2010 at 09:52:19PM -0500, Kevin O'Connor wrote: On Mon, Nov 15, 2010 at 03:36:25PM +0200, Gleb Natapov wrote: On Mon, Nov 15, 2010 at 08:26:35AM -0500, Kevin O'Connor wrote: On Mon, Nov 15, 2010 at 09:40:08AM +0200, Gleb Natapov wrote: On Sun, Nov 14, 2010 at 10:40:33PM

<    1   2