[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-09 Thread Adam Litke
On Wed, 2010-12-08 at 20:19 +0100, Jes Sorensen wrote: On 12/07/10 17:00, Adam Litke wrote: Hi Jes, you raise some good points and pitfalls with the current getfile approach. I've been thinking about an alternative and am wondering what you (and others) think... First off, I think we

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Alexander Graf
Stefan Hajnoczi wrote: On Wed, Dec 8, 2010 at 12:13 PM, Alexander Graf ag...@suse.de wrote: +struct AHCIDevice { +IDEBus port; +int port_no; +uint32_t port_state; +uint32_t finished; +AHCIPortRegs port_regs; +struct AHCIState *hba; +uint8_t *lst; +

[Qemu-devel] Using the mailing list for asking questions about the source code

2010-12-09 Thread Stefano Bonifazi
Hi All! I am new in QEMU developing and I am not sure if I can use this mailing list for asking general questions about QEMU source code as I could not find any guidelines about it. I noticed that, usually, questions about the source code in the QEMU forum never receive answers. Surely the

[Qemu-devel] Re: [PATCH 09/13] ahci: add ahci emulation

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 16:48, schrieb Alexander Graf: +static void ncq_cb(void *opaque, int ret) +{ +NCQTransferState *ncq_tfs = (NCQTransferState *)opaque; +IDEState *ide_state; + +if (ret 0) { +/* XXX error */ +} Missing error handling. Yes, that's what the

[Qemu-devel] [PATCH 24/24] usb storage: fix status reporting

2010-12-09 Thread Gerd Hoffmann
Change usb_msd_send_status() to take a pointer to the status packet instead of writing the status to s-usb_buf which might not point to the correct location. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-msd.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-)

[Qemu-devel] Re: [RFC][PATCH v5 07/21] virtagent: add va.getfile RPC

2010-12-09 Thread Michael Roth
On 12/09/2010 08:40 AM, Adam Litke wrote: On Wed, 2010-12-08 at 20:19 +0100, Jes Sorensen wrote: On 12/07/10 17:00, Adam Litke wrote: Hi Jes, you raise some good points and pitfalls with the current getfile approach. I've been thinking about an alternative and am wondering what you (and

[Qemu-devel] [PATCH 1/6] qemu, kvm: Enable NMI support for user space irqchip

2010-12-09 Thread Lai Jiangshan
Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space APIC emulation or some other source raised them. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/target-i386/kvm.c b/target-i386/kvm.c index 7dfc357..c4ebe28 100644 --- a/target-i386/kvm.c +++

[Qemu-devel] [Bug 688085] [NEW] Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Коренберг Марк
Public bug reported: Binary package hint: qemu Guest kernel hang during boot when KVM is active on i386 host See the patch. http://www.spinics.net/lists/kvm/msg40800.html How to reproduce: 1. install Maversick x86 (not amd64) 2. ensure you have kvm support in processor 3. kvm -kernel

Re: [Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-09 Thread Anthony Liguori
On 12/09/2010 02:45 PM, Michael Roth wrote: On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote: On Fri, Dec 3, 2010 at 6:03 PM, Michael Rothmdr...@linux.vnet.ibm.com wrote: These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 Why XML-RPC and

[Qemu-devel] [Bug 688085] Re: Guest kernel hang during boot when KVM is active on i386 host

2010-12-09 Thread Коренберг Марк
When booting another kernel (like RHEL 6.0) in guest, kernel hang on the line: Probing EDD (edd=off to disable)... ok Really, it hang in set_64bit inside function native_set_pmd() -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-09 Thread Michael Roth
On 12/07/2010 08:26 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: Utilize the getfile RPC to provide a means to view text files in the guest. Getfile can handle binary files as well but we don't advertise that here due to the special handling requiring to store it and provide

Re: [Qemu-devel] State of EHCI emulation for QEMU

2010-12-09 Thread David S. Ahern
On 12/09/10 06:05, Gerd Hoffmann wrote: Hi, New features developed for the kernel are done in a separate git trees. When a feature is ready for inclusion into the main kernel tree, a pull request is sent. That workflow maintains a complete change history for the feature. Take

[Qemu-devel] [PATCH 3/6] qumu,qmp: QError: New QERR_INVALID_KEY

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/qerror.c b/qerror.c index ac2cdaf..a7ef758 100644 --- a/qerror.c +++ b/qerror.c @@ -117,6 +117,10 @@ static const QErrorStringTable qerror_table[] = { .desc = Invalid block format '%(name)', }, { +

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Alex Williamson
On Thu, 2010-12-09 at 22:49 +0100, Juan Quintela wrote: Alex Williamson alex.william...@redhat.com wrote: The cpu_register_io_memory() value is unique to the VM instance and should not be restored after migration/save. Doing so means we could be pointing at arbitrary device's io regions

Re: [Qemu-devel] [RFC][PATCH v5 00/21] virtagent: host/guest RPC communication agent

2010-12-09 Thread Michael Roth
On 12/08/2010 04:10 AM, Stefan Hajnoczi wrote: On Fri, Dec 3, 2010 at 6:03 PM, Michael Rothmdr...@linux.vnet.ibm.com wrote: These patches apply to master, and can also be obtained from: git://repo.or.cz/qemu/mdroth.git virtagent_v5 Why XML-RPC and not QMP? When I skim through the patch

Re: [Qemu-devel] Re: IRC channel movement - FreeNode to OFTC

2010-12-09 Thread Brian Jackson
On Thursday, December 09, 2010 08:06:10 am François Revol wrote: Hi, I'd like to move IRC channels from FreeNode to OFTC, so please join #qemu on OFTC starting now. - what's wrong with freenode ? everyone is there. I can't speak for Anthony or the other devs, but freenode has some

[Qemu-devel] Re: [PATCH 6/6] qemu, qmp: Convert do_sendkey() to QObject, QError

2010-12-09 Thread Luiz Capitulino
On Thu, 09 Dec 2010 14:59:40 +0800 Lai Jiangshan la...@cn.fujitsu.com wrote: Convert do_sendkey() to QObject,QError, we need to use it.(via libvirt) It is a trivial conversion, carefully converted the error reports. Trivial conversion doesn't seem to lead to a good interface for qmp,

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-09 Thread Michael Roth
On 12/08/2010 01:22 PM, Jes Sorensen wrote: On 12/07/10 18:32, Michael Roth wrote: On 12/07/2010 08:37 AM, Jes Sorensen wrote: On 12/03/10 19:03, Michael Roth wrote: +static xmlrpc_value *va_getdmesg(xmlrpc_env *env, + xmlrpc_value *param, +

Re: [Qemu-devel] [PATCH 2/6] [RFC] Emulation of GRLIB IRQMP as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Mon, Dec 06, 2010 at 10:26:03AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteau chout...@adacore.com --- hw/grlib_irqmp.c | 416 ++ 1 files changed, 416 insertions(+), 0 deletions(-) diff --git a/hw/grlib_irqmp.c

[Qemu-devel] Re: [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Juan Quintela
Alex Williamson alex.william...@redhat.com wrote: The cpu_register_io_memory() value is unique to the VM instance and should not be restored after migration/save. Doing so means we could be pointing at arbitrary device's io regions after migration/restore. In this case, if we start a VM with

[Qemu-devel] [PATCH] rtl8139: IO memory is not part of vmstate

2010-12-09 Thread Alex Williamson
The cpu_register_io_memory() value is unique to the VM instance and should not be restored after migration/save. Doing so means we could be pointing at arbitrary device's io regions after migration/restore. In this case, if we start a VM with a single rtl8139, hot add a 2nd, migrate the VM, then

[Qemu-devel] [PATCH 14/24] usb: create USBPortOps, move attach there.

2010-12-09 Thread Gerd Hoffmann
Create USBPortOps struct, move the attach function to that struct. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bus.c |4 ++-- hw/usb-hub.c |6 +- hw/usb-musb.c |6 +- hw/usb-ohci.c |6 +- hw/usb-uhci.c |6 +- hw/usb.c |2 +- hw/usb.h

[Qemu-devel] [PATCH] noaudio: fix return value for read()

2010-12-09 Thread Michael Walle
Read should return bytes instead of samples. Signed-off-by: Michael Walle mich...@walle.cc --- audio/noaudio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/audio/noaudio.c b/audio/noaudio.c index 4925234..8015858 100644 --- a/audio/noaudio.c +++ b/audio/noaudio.c @@

[Qemu-devel] [PATCH 10/24] usb network: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb network driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-net.c | 453 +++--- 1 files changed, 209 insertions(+), 244 deletions(-) diff --git a/hw/usb-net.c

[Qemu-devel] Re: [PATCH 1/2] Introduce strtosz_suffix()

2010-12-09 Thread Stefan Hajnoczi
On Thu, Dec 09, 2010 at 01:13:33PM +0100, jes.soren...@redhat.com wrote: @@ -371,3 +377,8 @@ fail: return retval; } + +ssize_t strtosz(const char *nptr, char **end) +{ +return strtosz_suffix(nptr, end, 0); This obscures what the default is, please use STRTOSZ_DEFSUFFIX_MB. 0

[Qemu-devel] QEMU Uncompressing Linux.... stalls

2010-12-09 Thread Prasad Joshi
Hello All, I built an arm-linux kernel and trying to boot it using QEMU. But it stalls after showing 'Uncompressing Linux...' $ qemu-system-arm -M realview-pbx-a9 -kernel clfskernel-2.6.36 -initrd rootfs.gz -append console=ttyAMA0 root=/dev/sda1 rw ramdisk_size=32678 -m 256 -nographic

Re: [Qemu-devel] [PATCH 1/6] [RFC] Emulation of GRLIB GPTimer as defined in GRLIB IP Core User's Manual.

2010-12-09 Thread Edgar E. Iglesias
On Thu, Dec 09, 2010 at 11:04:58AM +0100, Fabien Chouteau wrote: On 12/08/2010 11:51 PM, Edgar E. Iglesias wrote: On Mon, Dec 06, 2010 at 10:26:02AM +0100, Fabien Chouteau wrote: Signed-off-by: Fabien Chouteauchout...@adacore.com --- hw/grlib_gptimer.c | 448

[Qemu-devel] [PATCH 16/24] usb: add usb_wakeup() + wakeup callback to port ops

2010-12-09 Thread Gerd Hoffmann
Add wakeup callback to port ops for remote wakeup handling. Also add a usb_wakeup() function for devices which want trigger a remote wakeup. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb.c |7 +++ hw/usb.h |2 ++ 2 files changed, 9 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 06/24] usb bluetooth: use new descriptor infrastructure.

2010-12-09 Thread Gerd Hoffmann
Switch the usb bluetooth driver over to the new descriptor infrastructure. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-bt.c | 473 +-- 1 files changed, 202 insertions(+), 271 deletions(-) diff --git a/hw/usb-bt.c

[Qemu-devel] [PATCH] audio: reset timer when enabling capture mode

2010-12-09 Thread Michael Walle
The audio timer also has to be reset when a capture device is enabled. This will ensure the timer to be started even if just capture devices are active. Signed-off-by: Michael Walle mich...@walle.cc --- audio/audio.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH v2] block: Introduce path_has_protocol() function

2010-12-09 Thread Stefan Hajnoczi
The bdrv_find_protocol() function returns NULL if an unknown protocol name is given. It returns the file protocol when the filename contains no protocol at all. This makes it difficult to distinguish between paths which contain a protocol and those which do not. Factor out a helper function

[Qemu-devel] Re: [PATCH] kvm: x86: Save/restore error_code

2010-12-09 Thread Jason Wang
Juan Quintela writes: Jason Wang jasow...@redhat.com wrote: The saving and restoring of error_code seems lost and convert the error_code to uint32_t. Signed-off-by: Jason Wang jasow...@redhat.com --- target-i386/cpu.h |4 ++-- target-i386/machine.c |2 ++ 2

[Qemu-devel] [Bug 595117] Re: qemu-nbd slow and missing writeback cache option

2010-12-09 Thread Launchpad Bug Tracker
[Expired for qemu-kvm (Ubuntu) because there has been no activity for 60 days.] ** Changed in: qemu-kvm (Ubuntu) Status: Incomplete = Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [PATCH 22/24] usb: add device qualifier support

2010-12-09 Thread Gerd Hoffmann
Add support for device_qualifier and other_speed_config descriptors. These are used to query the other speed configuration of usb 2.0 devices, i.e. in high-speed mode they return the full-speed configuration and visa versa. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb-desc.c | 46

[Qemu-devel] Re: [PATCH v3 1/1] qemu-img.c: Clean up handling of image size in img_create()

2010-12-09 Thread Kevin Wolf
Am 09.12.2010 10:45, schrieb jes.soren...@redhat.com: From: Jes Sorensen jes.soren...@redhat.com This cleans up the handling of image size in img_create() by parsing the value early, and then only setting it once if a value has been added as the last argument to the command line.

[Qemu-devel] [PATCH v2 2/2] qemu, qmp: convert do_inject_nmi() to QObject, QError

2010-12-09 Thread Lai Jiangshan
Convert do_inject_nmi() to QObject, QError, we need to use it(via libvirt). changed from v1 Add document. Add error handling when the cpu index is invalid. Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/hmp-commands.hx b/hmp-commands.hx index 23024ba..f86d9fe 100644 ---

[Qemu-devel] [PATCH v2 1/2] QError: new QERR_INVALID_CPU_INDEX

2010-12-09 Thread Lai Jiangshan
Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/qerror.c b/qerror.c index ac2cdaf..f59fb58 100644 --- a/qerror.c +++ b/qerror.c @@ -117,6 +117,10 @@ static const QErrorStringTable qerror_table[] = { .desc = Invalid block format '%(name)', }, { +

[Qemu-devel] Re: [RFC][PATCH v5 08/21] virtagent: add agent_viewfile qmp/hmp command

2010-12-09 Thread Jes Sorensen
On 12/09/10 22:12, Michael Roth wrote: On 12/07/2010 08:26 AM, Jes Sorensen wrote: I believe this suffers from the same architectural problem I mentioned in my comment to 07/21 - you don't restrict the file size, so it could blow up the QEMU process on the host trying to view the wrong file.

Re: [Qemu-devel] Re: [RFC][PATCH v5 09/21] virtagent: add va.getdmesg RPC

2010-12-09 Thread Jes Sorensen
On 12/09/10 22:15, Michael Roth wrote: On 12/08/2010 01:22 PM, Jes Sorensen wrote: This param is kind of quirky though, size doesn't seem to have an affect for anything below 4KB, but if we stick with VA_DMESG_LEN= 4KB this should cover us, unless it's a distro-specific. But it should blow

[Qemu-devel] [PATCH V2] qemu, kvm: Enable user space NMI injection for kvm guest

2010-12-09 Thread Lai Jiangshan
Make use of the new KVM_NMI IOCTL to send NMIs into the KVM guest if the user space raised them. (example: qemu monitor's nmi command) Signed-off-by: Lai Jiangshan la...@cn.fujitsu.com --- diff --git a/configure b/configure index 2917874..f6f9362 100755 --- a/configure +++ b/configure @@ -1646,6

<    1   2