Re: [Qemu-devel] [PATCH] target-sh4: fix index of address read error exception

2011-01-25 Thread Aurelien Jarno
On Tue, Jan 25, 2011 at 01:51:16PM +0900, Alexandre Courbot wrote: Exception index of address read error should be 0x0e0. --- target-sh4/helper.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/target-sh4/helper.c b/target-sh4/helper.c index 45449ea..2d76f22

Re: [Qemu-devel] [PATCH] target-sh4: update PTEH upon MMU exception

2011-01-25 Thread Aurelien Jarno
On Tue, Jan 25, 2011 at 01:51:17PM +0900, Alexandre Courbot wrote: Update the PTEH register to contain the VPN at which an MMU exception occured as specified by the SH4 reference. --- target-sh4/helper.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2] virtio-net: fix cross-endianness support

2011-01-25 Thread Aurelien Jarno
On Sat, Jan 15, 2011 at 08:27:43PM +0100, Aurelien Jarno wrote: virtio-net used to work on cross-endianness configurations, but doesn't anymore with recent guest kernels, as the new features don't handle endianness correctly. This patch fixes wrong conversion, and add missing ones to make

Re: [Qemu-devel] [PATCH] target-sh4: fix TLB invalidation code

2011-01-25 Thread Aurelien Jarno
On Tue, Jan 25, 2011 at 03:32:01PM +0900, Alexandre Courbot wrote: In cpu_sh4_invalidate_tlb, the UTLB was invalidated twice and the ITLB left unchaged, probably because of some unfortunate copy/paste. Signed-off-by: Alexandre Courbot gnu...@gmail.com --- target-sh4/helper.c |4 ++--

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: fix cross-endianness targets

2011-01-25 Thread Aurelien Jarno
On Sat, Jan 15, 2011 at 08:27:44PM +0100, Aurelien Jarno wrote: virtio-blk doesn't work on cross-endian configuration, as endianness is not handled correctly. This patch adds missing endianness conversions to make virtio-blk working. Tested on the following configurations: - i386 guest on

Re: [Qemu-devel] [PATCH] monitor: use after free in do_wav_capture()

2011-01-25 Thread Aurelien Jarno
On Fri, Jan 21, 2011 at 07:53:55PM +0900, Isaku Yamahata wrote: use after free in do_wav_capture() on the error path. Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- monitor.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) Thanks, applied. diff --git a/monitor.c

Re: [Qemu-devel] [PATCH] mips_fulong: remove bogus HAS_AUDIO

2011-01-25 Thread Aurelien Jarno
On Fri, Jan 21, 2011 at 07:53:51PM +0900, Isaku Yamahata wrote: remove bogus HAS_AUDIO according to 738012bec4c67e697e766edadab3f522c552a04d. Cc: Blue Swirl blauwir...@gmail.com Cc: Huacai Chen zltjiang...@gmail.com Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Isaku Yamahata

Re: [Qemu-devel] [PATCH] audio: consolidate audio_init()

2011-01-25 Thread Aurelien Jarno
On Fri, Jan 21, 2011 at 07:53:45PM +0900, Isaku Yamahata wrote: consolidate audio_init() and remove references to shoundhw. Cc: Blue Swirl blauwir...@gmail.com Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp --- arch_init.c | 35 ++- arch_init.h

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 01:06 AM, Mike Frysinger wrote: On Mon, Jan 24, 2011 at 11:29, Mulyadi Santosa wrote: I wrote an article about understanding ELF years ago, here is the URL: http://www.linuxforums.org/articles/understanding-elf-using-readelf-and-objdump_125.html i also highly recommend Linkers

[Qemu-devel] [PATCH 0/2] vnc: the lost parts

2011-01-25 Thread Corentin Chary
Hi Anthony, If you want to enable vnc threaded server by default, you should really merge these two lost patchs :). Thanks, Corentin Chary (1): vnc: qemu can die if the client is disconnected while updating screen Yoshiaki Tamura (1): vl.c: set NULL upon deleting handlers in

[Qemu-devel] [PATCH 2/2] vnc: qemu can die if the client is disconnected while updating screen

2011-01-25 Thread Corentin Chary
From: Corentin Chary corenti...@iksaif.net agraf reported that qemu_mutex_destroy(vs-output_mutex) was failing in vnc_disconnect_finish() when the vnc client was disconnected while updating the screen. It's because vnc_worker_thread_loop() tries to unlock the mutex while not locked.

[Qemu-devel] [PATCH 1/2] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2011-01-25 Thread Corentin Chary
From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Currently qemu_set_fd_handler2() is only setting ioh-deleted upon deleting. This may cause a crash when a read handler calls qemu_set_fd_handler2() to delete handlers, but a write handler is still invoked from main_loop_wait(). Because

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 12:32 AM, Mike Frysinger wrote: On Mon, Jan 24, 2011 at 16:44, Stefano Bonifazi wrote: http://lists.gnu.org/archive/html/qemu-devel/2010-07/msg01626.html A noob question, how can I get your sources? Is there a simpler solution than copypaste all the code from your messages

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 02:36 AM, Richard Henderson wrote: On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: Wow wonderful! So you fixed the code for PIC (ET_DYN) support? Yes. how can I get your sources? I was mistaken -- a later version of the patch set was in fact merged. I simply forgot to delete

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 01:18 AM, Mike Frysinger wrote: On Mon, Jan 24, 2011 at 19:06, Mike Frysinger wrote: On Mon, Jan 24, 2011 at 11:29, Mulyadi Santosa wrote: I wrote an article about understanding ELF years ago, here is the URL:

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-25 Thread Stefano Bonifazi
That said, QEMU's currently working fairly well on this front too, so studying either should work pretty well... Mr Richard Henderson's patch on elfload.c says I was right.. at least the version I am working on (qemu-0.13.0) had some bugs and weaknesses though it worked smoothly for most

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Mike Frysinger
On Tue, Jan 25, 2011 at 03:47, Stefano Bonifazi wrote: On 01/25/2011 02:36 AM, Richard Henderson wrote: On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: Wow wonderful! So you fixed the code for PIC (ET_DYN) support? Yes. how can I get your sources? I was mistaken -- a later version of the

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-25 Thread Stefano Bonifazi
Again wow!! Is that really possible? Some sort of callback triggered at every instruction execution? Yes, this mechanism works. I have written a code to count different kinds of instructions. Great! that opens a lot of possibilities!. It exists in file qemu/target-i386/translate.c Ops right!

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Jes Sorensen
On 01/24/11 18:47, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: qemu_toupper() - whats the problem? If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case will not match any input. Right, so one has to be careful when adding new suffix constants.

Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups

2011-01-25 Thread Jes Sorensen
On 01/24/11 18:28, Stefan Weil wrote: There was some discussion regarding this patch set. I agree with Markus that part of the first patch should be removed: don't change char to unsigned char. The unsigned char should definitely go in, leaving it as a signed char doesn't serve any purpose.

Re: [Qemu-devel] Re: [RFC][PATCH v6 08/23] virtagent: add va.getfile RPC

2011-01-25 Thread Richard W.M. Jones
On Mon, Jan 24, 2011 at 05:40:05PM -0600, Anthony Liguori wrote: BTW, how dependent is guestfsd on the guest that libguestfs uses? I wasn't even aware that it could be used outside of that context. The daemon is compiled separately -- separate ./configure, make, etc. You can run it on its own.

Re: [Qemu-devel] [RESEND PATCH 2/3] pulseaudio: setup buffer attrs

2011-01-25 Thread Alon Levy
On Mon, Jan 24, 2011 at 10:07:45PM +0100, Gerd Hoffmann wrote: Request reasonable buffer sizes from pulseaudio. Without this pa_simple_write() can block quite long and lead to dropouts, especially with guests which use small audio ring buffers. Signed-off-by: Gerd Hoffmann kra...@redhat.com

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 10:05 AM, Edgar E. Iglesias wrote: On Tue, Jan 25, 2011 at 10:04:39AM +0100, Stefano Bonifazi wrote: Again wow!! Is that really possible? Some sort of callback triggered at every instruction execution? Yes, this mechanism works. I have written a code to count different kinds of

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-01-25 Thread Edgar E. Iglesias
On Mon, Jan 24, 2011 at 04:28:48PM -0600, Anthony Liguori wrote: On 01/24/2011 03:00 PM, Anthony Liguori wrote: Leave the disable options for now to help with testing but these will be removed once we're confident in the thread implementations. Disabled code bit rots. These have been

Re: [Qemu-devel] TCG flow vs dyngen

2011-01-25 Thread Edgar E. Iglesias
On Tue, Jan 25, 2011 at 10:04:39AM +0100, Stefano Bonifazi wrote: Again wow!! Is that really possible? Some sort of callback triggered at every instruction execution? Yes, this mechanism works. I have written a code to count different kinds of instructions. Great! that opens a lot of

[Qemu-devel] [PATCH v4] linux-user: add ppoll syscall support

2011-01-25 Thread Mike Frysinger
Some architectures (like Blackfin) only implement ppoll (and skip poll). So add support for it using existing poll code. Signed-off-by: Mike Frysinger vap...@gentoo.org --- v4 - handle null signal set ... this wasn't failing as Blackfin ELFs default to VMA of 0 and thus

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 7:12 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 24, 2011 at 8:05 PM, Kevin Wolf kw...@redhat.com wrote: Am 24.01.2011 20:47, schrieb Michael S. Tsirkin: On Mon, Jan 24, 2011 at 08:48:05PM +0100, Kevin Wolf wrote: Am 24.01.2011 20:36, schrieb Michael S.

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 9:49 AM, Stefan Hajnoczi stefa...@gmail.com wrote: If any other vcpu interruption makes virtio-ioeventfd chug along then why are you seeing 100% CPU livelock?  My theory is that dynticks has a race condition which causes timers to stop working in QEMU. I forgot to

Re: [Qemu-devel] [PATCH 2/2] virtio-blk: fix cross-endianness targets

2011-01-25 Thread Stefan Hajnoczi
On Sat, Jan 15, 2011 at 7:27 PM, Aurelien Jarno aurel...@aurel32.net wrote: virtio-blk doesn't work on cross-endian configuration, as endianness is not handled correctly. This patch adds missing endianness conversions to make virtio-blk working. Tested on the following configurations: - i386

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
Sorry.. merged with qemu? What version? I have qemu.0.13.0 and there are no your fixes.. How can I get the fixed qemu sources? you probably want to use the latest git tree http://git.qemu.org/qemu.git/ -mike Wow man! I got your work through the git! Very good job! Now everything is much

Re: [Qemu-devel] [PATCH 1/2] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary corentin.ch...@gmail.com wrote: From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Currently qemu_set_fd_handler2() is only setting ioh-deleted upon deleting.  This may cause a crash when a read handler calls qemu_set_fd_handler2() to delete

Re: [Qemu-devel] [PATCH 1/2] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2011-01-25 Thread Corentin Chary
On Tue, Jan 25, 2011 at 10:03 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary corentin.ch...@gmail.com wrote: From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp Currently qemu_set_fd_handler2() is only setting ioh-deleted upon deleting.  This

Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups

2011-01-25 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 01/24/11 18:28, Stefan Weil wrote: There was some discussion regarding this patch set. I agree with Markus that part of the first patch should be removed: don't change char to unsigned char. The unsigned char should definitely go in, leaving

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 01/24/11 18:47, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: qemu_toupper() - whats the problem? If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case will not match any input. Right, so one has to be

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Stefan Hajnoczi
On Mon, Jan 24, 2011 at 9:00 PM, Anthony Liguori aligu...@us.ibm.com wrote: This series introduces a hard dependency on glib.  The initial use is portable threads but I see this as just the beginning.  Glib/Gobject offer many nice things including:  - portable threads  - rich data structure

Re: [Qemu-devel] [PATCH 1/2] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 10:13 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Tue, Jan 25, 2011 at 10:03 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary corentin.ch...@gmail.com wrote: From: Yoshiaki Tamura tamura.yoshi...@lab.ntt.co.jp

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Avi Kivity
On 01/18/2011 04:28 PM, Jan Kiszka wrote: So we can either infect the whole device tree with kvm (or maybe a more generic accelerator structure that also deals with Xen) or we need to pull the reference inside the device's init function from some global service (kvm_get_state). Note

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Avi Kivity
On 01/18/2011 05:50 PM, Anthony Liguori wrote: This design is in conflict with the requirement to attach KVM-assisted devices also to their home bus, e.g. an assigned PCI device to the PCI bus. We don't support multi-homed qdev devices. The bus topology reflects how I/O flows in and out of a

[Qemu-devel] Re: [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Paolo Bonzini
On 01/24/2011 11:01 PM, Anthony Liguori wrote: - JSON parser I think our JSON parser is much better than JsonGlib (which isn't anyway a part of GLib proper). Not sure how much either of these matter, but we should at least drop QObject and convert our JSON parser to use GValues such that we

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 09:53 AM, Mike Frysinger wrote: On Tue, Jan 25, 2011 at 03:47, Stefano Bonifazi wrote: On 01/25/2011 02:36 AM, Richard Henderson wrote: On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: Wow wonderful! So you fixed the code for PIC (ET_DYN) support? Yes. how can I get your

[Qemu-devel] [PATCH 2/2] mc146818rtc: update registers after a format change

2011-01-25 Thread Aurelien Jarno
For some unknown reason, the MIPS kernel briefly changes the RTC to binary mode during boot, switch back to BCD mode and read the time. As the registers are updated only every second, they may still be in the old format when they are read. This patch forces a register update immediately after a

Re: [Qemu-devel] [RESEND PATCH 2/3] pulseaudio: setup buffer attrs

2011-01-25 Thread Gerd Hoffmann
Hi, What's the default buffer size? Don't know the exact number, but pulse's default buffer size is quite big by design. Which is fine for most apps (such as mp3 players) where loading more sound data into the buffer every second or so is ok. It doesn't work very well for sound card

Re: [Qemu-devel] qemu-user: relocating target code weakness

2011-01-25 Thread Stefano Bonifazi
On 01/25/2011 09:53 AM, Mike Frysinger wrote: On Tue, Jan 25, 2011 at 03:47, Stefano Bonifazi wrote: On 01/25/2011 02:36 AM, Richard Henderson wrote: On 01/24/2011 01:44 PM, Stefano Bonifazi wrote: Wow wonderful! So you fixed the code for PIC (ET_DYN) support? Yes. how can I get your

[Qemu-devel] [PATCH 1/2] mc146818rtc: constantify

2011-01-25 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- hw/mc146818rtc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 6466aff..ec7c4ec 100644 --- a/hw/mc146818rtc.c +++ b/hw/mc146818rtc.c @@ -72,6 +72,7 @@ #define REG_B_UIE

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Avi Kivity
On 01/20/2011 11:22 PM, Jan Kiszka wrote: On 2011-01-20 20:27, Blue Swirl wrote: On Thu, Jan 20, 2011 at 9:33 AM, Jan Kiszkajan.kis...@siemens.com wrote: On 2011-01-19 20:32, Blue Swirl wrote: On Wed, Jan 19, 2011 at 4:57 PM, Anthony Liguori aligu...@linux.vnet.ibm.com wrote: On

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Avi Kivity
On 01/19/2011 06:57 PM, Anthony Liguori wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emulated PCI bus. Could you elaborate on the fundamental difference between the two interactions that makes you choose the

Re: [Qemu-devel] Re: [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Daniel P. Berrange
On Tue, Jan 25, 2011 at 11:41:23AM +0100, Paolo Bonzini wrote: On 01/24/2011 11:01 PM, Anthony Liguori wrote: - JSON parser I think our JSON parser is much better than JsonGlib (which isn't anyway a part of GLib proper). Not sure how much either of these matter, but we should at least

[Qemu-devel] Re: git rm Changelog?

2011-01-25 Thread Paolo Bonzini
On 01/25/2011 10:57 AM, Kevin Wolf wrote: Am 25.01.2011 00:06, schrieb Paolo Bonzini: ... or at least git mv Changelog Changelog.old? It only goes back to 0.12.0 so that there is hardly a place in the git repo to look for new features in 0.13 and 0.14. Or maybe update it? I find it rather

Re: [Qemu-devel] Re: [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Paolo Bonzini
On 01/25/2011 12:14 PM, Daniel P. Berrange wrote: It might be worth considering (the fairly newly introduced) GVariant, rather than GValue. The GVariant code was designed and is used for (de)serializing DBus messages in GLib. As such I'd imagine it would be fairly well suited to handling

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2011 at 09:49:04AM +, Stefan Hajnoczi wrote: On Tue, Jan 25, 2011 at 7:12 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 24, 2011 at 8:05 PM, Kevin Wolf kw...@redhat.com wrote: Am 24.01.2011 20:47, schrieb Michael S. Tsirkin: On Mon, Jan 24, 2011 at 08:48:05PM

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Gerd Hoffmann
On 01/24/11 22:00, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more code from existing projects instead of reinventing everything

Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups

2011-01-25 Thread Jes Sorensen
On 01/25/11 11:14, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 01/24/11 18:28, Stefan Weil wrote: There was some discussion regarding this patch set. I agree with Markus that part of the first patch should be removed: don't change char to unsigned char. The

Re: [Qemu-devel] [PATCH 4/4] strtosz(): Use suffix macros in switch() statement

2011-01-25 Thread Jes Sorensen
On 01/25/11 11:17, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 01/24/11 18:47, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: qemu_toupper() - whats the problem? If a STRTOSZ_DEFSUFFIX_T? expands to a lower case character, its case will

Re: [Qemu-devel] [PATCH 1/3] block: add block_resize monitor command

2011-01-25 Thread Kevin Wolf
Am 24.01.2011 18:44, schrieb Marcelo Tosatti: On Mon, Jan 24, 2011 at 01:32:33PM +0100, Christoph Hellwig wrote: Add a monitor command that allows resizing of block devices while qemu is running. It uses the existing bdrv_truncate method already used by qemu-img to do it's work. Compared to

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Daniel P. Berrange
On Tue, Jan 25, 2011 at 12:51:42PM +0100, Gerd Hoffmann wrote: On 01/24/11 22:00, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more

Re: [Qemu-devel] [PATCH 1/2] vl.c: set NULL upon deleting handlers in qemu_set_fd_handler2()

2011-01-25 Thread Yoshiaki Tamura
2011/1/25 Stefan Hajnoczi stefa...@gmail.com: On Tue, Jan 25, 2011 at 10:13 AM, Corentin Chary corentin.ch...@gmail.com wrote: On Tue, Jan 25, 2011 at 10:03 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Jan 25, 2011 at 8:33 AM, Corentin Chary corentin.ch...@gmail.com wrote: From:

[Qemu-devel] [RESEND PATCH V3 2/2] machine, Add default_machine_opts to QEMUMachine.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com With this new field, we can specified which accelerator use to run the machine, if the accelerator is not already specified by either a configuration file or the command line options. Currently, the only use will be made in the xenfv machine.

[Qemu-devel] [RESEND PATCH V3 0/2] Introduce machine QemuOpts

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com The first patch adds -machine accel=accels to Qemu options. And the second one adds a new field in QEMUMachine to be able to specify a set of machine options. With the second patch, we will be able to run a Xen specific machine without saying to use

[Qemu-devel] [RESEND PATCH V3 1/2] Introduce -machine command option.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This option gives the ability to switch one accelerator like kvm, xen or the default one tcg. We can specify more than one accelerator by separate them by a colon. QEMU will try each one and use the first whose works. So, ./qemu -machine

Re: [Qemu-devel] [PATCH 5/7] tcg-i386: Implement deposit operation.

2011-01-25 Thread Edgar E. Iglesias
On Mon, Jan 10, 2011 at 07:23:46PM -0800, Richard Henderson wrote: Special case deposits that are implementable with byte and word stores. Otherwise implement with double-word shift plus rotates. Expose tcg_scratch_alloc to the backend for allocation of scratch registers. Signed-off-by:

Re: [Qemu-devel] Re: [PATCH v4 0/4] strtosz() cleanups

2011-01-25 Thread Markus Armbruster
Jes Sorensen jes.soren...@redhat.com writes: On 01/25/11 11:14, Markus Armbruster wrote: Jes Sorensen jes.soren...@redhat.com writes: On 01/24/11 18:28, Stefan Weil wrote: There was some discussion regarding this patch set. I agree with Markus that part of the first patch should be

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 11:27 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jan 25, 2011 at 09:49:04AM +, Stefan Hajnoczi wrote: On Tue, Jan 25, 2011 at 7:12 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Jan 24, 2011 at 8:05 PM, Kevin Wolf kw...@redhat.com wrote: Am

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Luiz Capitulino
On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block layer - glib everywhere - Let's start planning our next release in

[Qemu-devel] [PATCH] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-25 Thread Stefan Hajnoczi
It is not possible to use virtio-ioeventfd when building without an I/O thread. We rely on a signal to kick us out of vcpu execution. Timers and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd does not support O_ASYNC (SIGIO) so eventfd cannot be used in a signal driven manner.

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Anthony Liguori
On 01/25/2011 04:27 AM, Avi Kivity wrote: It boils down to how we reasonably pass a kvm_state reference from machine init code to a sysbus device. I'm probably biased, but I don't see any way that does not work against the idea of confining access to kvm_state or breaks device instantiation from

Re: [Qemu-devel] Re: [PATCH 2/7] Enable I/O thread and VNC threads by default

2011-01-25 Thread Marcelo Tosatti
On Tue, Jan 25, 2011 at 10:17:41AM +0100, Edgar E. Iglesias wrote: On Mon, Jan 24, 2011 at 04:28:48PM -0600, Anthony Liguori wrote: On 01/24/2011 03:00 PM, Anthony Liguori wrote: Leave the disable options for now to help with testing but these will be removed once we're confident in

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Luiz Capitulino
On Tue, 25 Jan 2011 11:57:27 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. -

Re: [Qemu-devel] [PATCH v5 2/4] virtio-pci: Use ioeventfd for virtqueue notify

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 1:20 PM, Stefan Hajnoczi stefa...@gmail.com wrote: eventfd does not seem to support O_ASYNC. linux-2.6/fs/eventfd.c does not implement file_operations::fasync() so I'm convinced SIGIO is not possible here. I have sent a patch to disable virtio-ioeventfd when

Re: [Qemu-devel] [PATCH 1/7] usb-ccid: add CCID bus

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:38 AM, Alon Levy wrote: A CCID device is a smart card reader. It is a USB device, defined at [1]. This patch introduces the usb-ccid device that is a ccid bus. Next patches will introduce two card types to use it, a passthru card and an emulated card. [1]

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Aurelien Jarno
Luiz Capitulino a écrit : On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block layer - glib everywhere - Let's start

[Qemu-devel] Re: [PATCH] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2011 at 01:58:08PM +, Stefan Hajnoczi wrote: It is not possible to use virtio-ioeventfd when building without an I/O thread. We rely on a signal to kick us out of vcpu execution. Timers and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd does not support

Re: [Qemu-devel] [PATCH 2/7] ccid: add passthru card device

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:42 AM, Alon Levy wrote: diff --git a/libcacard/vscard_common.h b/libcacard/vscard_common.h new file mode 100644 index 000..9ff1295 --- /dev/null +++ b/libcacard/vscard_common.h This file (and the .c file) need a coding style pass to fixup comments and the use of _ as

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 2:02 PM, Luiz Capitulino lcapitul...@redhat.com wrote:  - Google summer of code 2011 is on, are we interested? (note: I just saw the   news, I don't have any information yet) http://www.google-melange.com/document/show/gsoc_program/google/gsoc2011/timeline I'd like to

Re: [Qemu-devel] [PATCH 3/7] libcacard: initial commit after coding style fixes

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:42 AM, Alon Levy wrote: From: Robert Relyearrel...@redhat.com libcacard emulates a Common Access Card (CAC) which is a standard for smartcards. It is used by the emulated ccid card introduced in a following patch. Docs are available in docs/libcacard.txt Signed-off-by: Alon

Re: [Qemu-devel] Re: [PATCH] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 2:13 PM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Jan 25, 2011 at 01:58:08PM +, Stefan Hajnoczi wrote: It is not possible to use virtio-ioeventfd when building without an I/O thread.  We rely on a signal to kick us out of vcpu execution.  Timers and AIO use

Re: [Qemu-devel] [RFC 0/7] Introduce hard dependency on glib

2011-01-25 Thread Aurelien Jarno
On Mon, Jan 24, 2011 at 03:00:38PM -0600, Anthony Liguori wrote: Both the recent I/O loop and threadlet series have me concerned that we're digging ourselves deeper into the NIH hole. I think it's time we look at something radical to let us borrow more code from existing projects instead of

Re: [Qemu-devel] [PATCH 4/7] ccid: add ccid-card-emulated device (v2)

2011-01-25 Thread Anthony Liguori
On 01/11/2011 02:42 AM, Alon Levy wrote: This devices uses libcacard (internal) to emulate a smartcard conforming to the CAC standard. It attaches to the usb-ccid bus. Usage instructions (example command lines) are in the following patch in docs/ccid.txt. It uses libcacard which uses nss, so it

Re: [Qemu-devel] [PATCH 3/7] Add support for glib based threading and convert qemu thread to use it

2011-01-25 Thread Aurelien Jarno
On Mon, Jan 24, 2011 at 03:00:41PM -0600, Anthony Liguori wrote: GLib is an extremely common library that has a portable thread implementation along with tons of other goodies. GLib and GObject have a fantastic amount of infrastructure we can leverage in QEMU including an object oriented

[Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Avi Kivity
On 01/25/2011 12:06 AM, Anthony Liguori wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block layer I have a perpetually in progress branch for this, and would very much like to see this done. --

[Qemu-devel] [PATCH V9 09/16] xen: add a 8259 Interrupt Controller

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Introduce a 8259 Interrupt Controller for target-xen; every set_irq call makes a Xen hypercall. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com --- hw/xen_common.h |

Re: [Qemu-devel] [PATCH 28/35] kvm: x86: Introduce kvmclock device to save/restore its state

2011-01-25 Thread Anthony Liguori
On 01/25/2011 05:06 AM, Avi Kivity wrote: On 01/19/2011 06:57 PM, Anthony Liguori wrote: On 01/19/2011 07:15 AM, Markus Armbruster wrote: So they interact with KVM (need kvm_state), and they interact with the emulated PCI bus. Could you elaborate on the fundamental difference between the two

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Anthony Liguori
On 01/25/2011 08:11 AM, Aurelien Jarno wrote: Luiz Capitulino a écrit : On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguorianth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. -

[Qemu-devel] [PATCH V9 05/16] xen: Add xen_machine_fv

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Add the Xen FV (Fully Virtualized) machine to Qemu; this is groundwork to add Xen device model support in Qemu. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com ---

[Qemu-devel] [PATCH V9 02/16] xen: Make xen build only on x86 target.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.objs |4 Makefile.target |4 +++- configure |5 + 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Makefile.objs b/Makefile.objs index

[Qemu-devel] [PATCH V9 06/16] xen: Add initialisation of Xen

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.target |3 +++ hw/xen.h| 13 + vl.c|2 ++ xen-all.c | 29 + xen-stub.c | 17 +

[Qemu-devel] [PATCH V9 15/16] xen: Set running state in xenstore.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This tells to the xen management tool that the machine can begin run. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- xen-all.c | 27 +++ 1 files changed, 27 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH V9 08/16] piix_pci: Introduces Xen specific call for irq.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This patch introduces Xen specific call in piix_pci. The specific part for Xen is in write_config, set_irq and get_pirq. Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com ---

[Qemu-devel] [PATCH V9 01/16] xen: Replace some tab-indents with spaces (clean-up).

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen_backend.c | 308 +- hw/xen_disk.c| 394 +++--- hw/xen_nic.c | 222

[Qemu-devel] [PATCH V9 11/16] configure: Always use 64bits target physical addresses with xen enabled.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com With MapCache, we can handle a 64b target, even with a 32b host/qemu. So, we need to have target_phys_addr_t to 64bits. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- configure |1 + 1 files changed, 1 insertions(+), 0 deletions(-)

[Qemu-devel] [PATCH V9 03/16] xen: Add a generic layer for xc calls

2011-01-25 Thread anthony . perard
From: Alexander Graf ag...@suse.de This patch adds a generic layer for xc calls, allowing us to choose between the xenner and xen implementations at runtime. Signed-off-by: Alexander Graf ag...@suse.de Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/xen_interfaces.c | 100

[Qemu-devel] [PATCH V9 07/16] xen: Add the Xen platform pci device

2011-01-25 Thread anthony . perard
From: Steven Smith ssm...@xensource.com Introduce a new emulated PCI device, specific to fully virtualized Xen guests. The device is necessary for PV on HVM drivers to work. Signed-off-by: Steven Smith ssm...@xensource.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by:

[Qemu-devel] [PATCH V9 12/16] Introduce qemu_ram_ptr_unlock.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com This function allows to unlock a ram_ptr give by qemu_get_ram_ptr. After a call to qemu_ram_ptr_unlock, the pointer may be unmap from QEMU when used with Xen. Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- cpu-common.h |1 +

Re: [Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Kevin Wolf
Am 25.01.2011 15:11, schrieb Aurelien Jarno: Luiz Capitulino a écrit : On Mon, 24 Jan 2011 16:06:34 -0600 Anthony Liguori anth...@codemonkey.ws wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block

[Qemu-devel] [PATCH] hw/qxl: another missing unlock

2011-01-25 Thread Alon Levy
We need to unlock the mutex before waiting on read via the worker call since the worker will try to lock and hang otherwise. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/qxl.c b/hw/qxl.c index 117f7c8..00c31c7

[Qemu-devel] [PATCH V9 14/16] xen: Initialize event channels and io rings

2011-01-25 Thread anthony . perard
From: Arun Sharma arun.sha...@intel.com Open and bind event channels; map ioreq and buffered ioreq rings. Signed-off-by: Arun Sharma arun.sha...@intel.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Stefano Stabellini stefano.stabell...@eu.citrix.com ---

[Qemu-devel] [PATCH V9 04/16] xen: Support new libxc calls from xen unstable.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Update the libxenctrl calls in Qemu to use the new interface, otherwise Qemu wouldn't be able to build against new versions of the library. We also check libxenctrl version in configure, from Xen 3.3.0 to Xen unstable. Signed-off-by: Anthony PERARD

[Qemu-devel] [PATCH V9 16/16] acpi-piix4: Add Xen hypercall for sleep state.

2011-01-25 Thread anthony . perard
From: Anthony PERARD anthony.per...@citrix.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/acpi_piix4.c |4 hw/xen.h|2 ++ xen-all.c |7 +++ xen-stub.c |4 4 files changed, 17 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCH V9 10/16] xen: Introduce the Xen mapcache

2011-01-25 Thread anthony . perard
From: Jun Nakajima jun.nakaj...@intel.com On IA32 host or IA32 PAE host, at present, generally, we can't create an HVM guest with more than 2G memory, because generally it's almost impossible for Qemu to find a large enough and consecutive virtual address space to map an HVM guest's whole

[Qemu-devel] Re: [PATCH v2] virtio-pci: Disable virtio-ioeventfd when !CONFIG_IOTHREAD

2011-01-25 Thread Michael S. Tsirkin
On Tue, Jan 25, 2011 at 02:53:31PM +, Stefan Hajnoczi wrote: It is not possible to use virtio-ioeventfd when building without an I/O thread. We rely on a signal to kick us out of vcpu execution. Timers and AIO use SIGALRM and SIGUSR2 respectively. Unfortunately eventfd does not support

[Qemu-devel] Re: KVM call agenda for Jan 25

2011-01-25 Thread Stefan Hajnoczi
On Tue, Jan 25, 2011 at 2:26 PM, Avi Kivity a...@redhat.com wrote: On 01/25/2011 12:06 AM, Anthony Liguori wrote: On 01/24/2011 07:25 AM, Chris Wright wrote: Please send in any agenda items you are interested in covering. - coroutines for the block layer I have a perpetually in progress

  1   2   >