Luiz Capitulino lcapitul...@redhat.com writes:
A simple migration reproduces it:
1. Start the source VM with:
# qemu [...] -S
2. Start the destination VM with:
# qemu source VM cmd-line -incoming tcp:0:
3. In the source VM:
(qemu) migrate -d tcp:0:
4. The source VM
Please thread together your patches so that the parts appear as replies
to the cover letter. git-send-email should do that by default.
Why? Disconnected parts can easily get separated in the list. When
that happens, your reviewers need to hunt for parts. They may choose to
review something
Pavel Borzenkov pavel.borzen...@gmail.com writes:
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com
---
Note, that almost all code in the file violates CODING STYLE. The changed
lines
are written wrt CODING STYLE (like commits 7d7d975c and c32d766a).
---
cmd.c | 11 +++
Alexander Graf ag...@suse.de writes:
On 30.10.2011, at 13:07, Stefan Weil wrote:
Valgrind is a tool which can automatically detect many kinds of bugs.
Running QEMU on Valgrind with x86_64 hosts was not possible because
Valgrind aborts when memalign is called with an alignment larger than
A while back, Eduard - Gabriel Munteanu send a series of patches
implementing support for emulating the AMD IOMMU in conjunction with
qemu emulated PCI devices. A revised patch series added support for
the Intel IOMMU, and I also send a revised version of this series
which added support for the
Alexander Graf ag...@suse.de writes:
On 30.10.2011, at 15:30, Stefan Weil wrote:
Am 30.10.2011 14:41, schrieb Alexander Graf:
On 30.10.2011, at 13:07, Stefan Weil wrote:
Valgrind is a tool which can automatically detect many kinds of bugs.
Running QEMU on Valgrind with x86_64 hosts was
This updates the PCI IDE device emulation to use the explicit PCI DMA
wrapper to initialize its scatter/gathjer structure. This means this
driver should not need further changes when the sglist interface is
extended to support IOMMUs.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
---
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the es1370 device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
This updates the intel-hda device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
hw/intel-hda.c | 14 +++---
1
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the e1000 device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
This patch uses the newly created dma_addr_t type throughout the
scatter/gather handling code in dma-helpers.c whenever we need to
represent a dma bus address. This makes a better distinction as to
what is a bus address and what is a cpu physical address. Since we
don't support IOMMUs yet, they
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the rtl8139 device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the lsi53c895a device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the eepro100 device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the pcnet-pci device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David
On Mon, Oct 31, 2011 at 10:27 AM, Markus Armbruster arm...@redhat.com wrote:
Pavel Borzenkov pavel.borzen...@gmail.com writes:
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com
---
Note, that almost all code in the file violates CODING STYLE. The changed
lines
are written wrt CODING
This updates the usb-ehci device emulation to use the explicit PCI DMA
wrapper to initialize its scatter/gathjer structure. This means this
driver should not need further changes when the sglist interface is
extended to support IOMMUs.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
---
This updates the usb-uhci device emulation to use the explicit PCI DMA
wrapper to initialize its scatter/gathjer structure. This means this
driver should not need further changes when the sglist interface is
extended to support IOMMUs.
Signed-off-by: David Gibson da...@gibson.dropbear.id.au
---
From: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
This updates the ac97 device emulation to use the explicit PCI DMA
functions, instead of directly calling physical memory access functions.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
Signed-off-by: David Gibson
This patch adds functions to pci.[ch] to perform PCI DMA operations.
At present, these are just stubs which perform directly cpu physical
memory accesses. Stubs are included which are analogous to
cpu_physical_memory_{read,write}(), the stX_phys() and ldX_phys()
functions and
As a preliminary to adding more extensive DMA and IOMMU infrastructure
support into qemu, this patch defines a dma_addr_t for storing DMA bus
addresses and a DMADirection enum which describes whether a DMA is
from an external device to main memory or from main memory to an
external device.
For
On Sat, Oct 22, 2011 at 00:26, Paolo Bonzini pbonz...@redhat.com wrote:
Reviewed-by: Anthony Liguori aligu...@us.ibm.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
qemu-timer.c | 129
--
1 files changed, 53 insertions(+),
Thanks, Max and Chih-Min. It's much clear to me now.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
On Tue, 25 Oct 2011 15:02:44 +0530, Aneesh Kumar K.V
aneesh.ku...@linux.vnet.ibm.com wrote:
Hi,
This include all the pending patches for 1.0
The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b:
Merge remote-tracking branch
(2011/10/28 21:48), Jun Koi wrote:
2011/10/28 Kenji Kaneshigekaneshige.ke...@jp.fujitsu.com:
Avi, Jan,
Could you comment on these patches?
Inject-NMI doesn't work on Windows guest without these patches.
sorry but i am really curious here: why Windows still works well even
if it desnt see
Am 29.10.2011 05:40, schrieb ronnie sahlberg:
Hi Kevin,
I agree that maybe we should have a link from the TOC down to the
Device URL Syntax.
I can create a patch to do so.
For moving the existing Device URL Syntax information into 3.6 Disk
Images, I am not sure.
I think both have their
Am 31.10.2011 04:01, schrieb Zhi Yong Wu:
It is better to use qiov.size in qed-table.c to get nb_sectors than
iov.iov_len.
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
The commit message should probably say why it's better. Not saying
otherwise, but I can't see the different at the
On Mon, Oct 31, 2011 at 4:10 PM, Kevin Wolf kw...@redhat.com wrote:
Am 31.10.2011 04:01, schrieb Zhi Yong Wu:
It is better to use qiov.size in qed-table.c to get nb_sectors than
iov.iov_len.
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
The commit message should probably say why it's
Hello all,
i want to use a virtual router which is connected to a cable box
via an usb ethernet controller. The device itself runs properly
at normal usage. But inside the virtual machine i get only about 7MBit.
I configured the the usb device with the following xml syntax of
libvirt:
controller
On 10/30/2011 07:04 PM, Saggi Mizrahi wrote:
I wonder also what thread API should be used, qemu_thread versions
used internally or standard ones. It would be logical to use
qemu_thread versions but then the external user should use those too.
I would prefer not to use qemu's threading as it'll
On 10/30/2011 05:51 PM, Saggi Mizrahi wrote:
Some distributions use lib64 directories for 64 bit libraries. Currently
configure would always generate libdir as $PREFIX/lib. By checking if
the current distro has a /lib64 directory we can assume it is using this
convention.
This doesn't work if
On 10/31/2011 08:23 AM, TeLeMan wrote:
static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t)
{
-if (!alarm_has_dynticks(t))
+int64_t nearest_delta_ns;
+assert(alarm_has_dynticks(t));
mmtimer and win32 alarms have no rearm. Should we remove these two alarms?
[Seems they didn't make it to the list yesterday]
Hello,
Here's two Cocoa patches I'd like to see pulled into 1.0.
First, documenting the de facto maintainer.
Second, fixing the build.
Since qemu-system-* crashes after selecting an image file,
I can only say that Juan's sheet patch compiles and
Degrade cocoa.m from Maintained to Odd Fixes.
Signed-off-by: Andreas Färber andreas.faer...@web.de
Cc: Anthony Liguori aligu...@us.ibm.com
---
MAINTAINERS |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2b4c5d7..c08951c 100644
---
In file included from ./bswap.h:7,
from ./qemu-common.h:106,
from ./qemu-aio.h:17,
from ./Block.h:4,
from
/System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:28,
On 10/31/2011 02:36 AM, David Gibson wrote:
There is no direct use of signed arithmetic in the API (just in the
implementation). Aliases can cause a region to move in either the
positive or negative direction, and this requires either signed
arithmetic or special casing the two
Callers of create_iovec() didn't check for failure and continued with
uninitialised data in error cases. This patch adds checks to each call.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-io.c | 28
1 files changed, 24 insertions(+), 4 deletions(-)
diff
Without this fix, some qiovs can be leaked if an error occurs. Also a semicolon
at the end of the command line would make the code walk beyond the end of argv.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-io.c |9 ++---
1 files changed, 6 insertions(+), 3 deletions(-)
diff --git
On Fri, Oct 28, 2011 at 04:15:41PM -0700, Sumit Naiksatam (snaiksat) wrote:
Hi,
In its current implementation Libvirt makes sure that the network
interfaces that it passes/provision to a VM (for example to qemu[-kvm])
are already connected to its backend (interfaces/networks) by the time
This is because kvm is not enabled by default even if I add KVM support when
configuring qemu.
Now it got fixed by the following commit.
author Marcelo Tosatti mtosa...@redhat.com
Thu, 27 Oct 2011 20:34:42 +0800 (10:34 -0200)
committer Marcelo Tosatti mtosa...@redhat.com
Thu, 27
It works now.
** Changed in: qemu
Status: New = Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/882358
Title:
device assignment doesn't work: error: requires KVM support
Status
On Mon, 31 Oct 2011 00:01:07 -0200
Lucas Meneghel Rodrigues l...@redhat.com wrote:
Hi folks, sending this to QEMU devel to inform the current problems we
are able to reproduce on the current master branch.
So, qemu.git is presenting problems as of latest master. None of the
problems
On Sat, Oct 29, 2011 at 04:00:34PM +0200, Alexander Graf wrote:
During the GSoC mentor summit there was a pretty interesting session on how
to get students to stick with your project even after GSoC has ended. So far
we haven't really been exactly successful in that respect :). I'll just post
Markus Armbruster arm...@redhat.com sent fixes for va_list vararg
issues in v9fs_string_alloc_printf(). It turns out the function
duplicates g_vasprintf() and can therefore be eliminated entirely.
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
hw/9pfs/virtio-9p.c | 103
On Fri, Oct 28, 2011 at 9:52 AM, Markus Armbruster arm...@redhat.com wrote:
C99 7.15.1: Each invocation of the va_start and va_copy macros shall
be matched by a corresponding invocation of the va_end macro in the
same function.
Spotted by Coverity. Harmless on the (common) systems where
On Fri, Oct 28, 2011 at 10:52:25AM +0200, Markus Armbruster wrote:
C99 7.15.1: Each invocation of the va_start and va_copy macros shall
be matched by a corresponding invocation of the va_end macro in the
same function.
Spotted by Coverity. Harmless on the (common) systems where va_end()
On Fri, Oct 28, 2011 at 03:58:26PM +0100, Stefan Hajnoczi wrote:
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
---
docs/qapi-code-gen.txt |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Applied to the trivial patches -next tree:
On Fri, Oct 28, 2011 at 05:07:02PM +0200, Markus Armbruster wrote:
Reproducer:
$ MALLOC_PERTURB_=234 qemu-system-x86_64 -vnc :0,acl,sasl [...]
QEMU 0.15.50 monitor - type 'help' for more information
(qemu) acl_add vnc.username fred allow
acl: added rule at position 1
Am 28.10.2011 21:38, schrieb John Baboval:
These are some xen related patches that have been sitting around in are
queue waiting for us to re-base onto a modern qemu. Now that we're
up-to-date, they're ready to share with the list.
They are all things that enable successfully running
Please CC xen-devel on patches which impact the Xen support in qemu.
On Fri, 2011-10-28 at 15:38 -0400, John Baboval wrote:
When in xen mode, handle the view of pm ioport appropriately.
I'm not entirely comfortable with this patch, since it relies on values
that are hard coded into the DSDT
Hi,
On 10/31/2011 10:27 AM, Til Obes wrote:
Hello all,
i want to use a virtual router which is connected to a cable box
via an usb ethernet controller. The device itself runs properly
at normal usage. But inside the virtual machine i get only about 7MBit.
I configured the the usb device with
Stefan Hajnoczi stefa...@linux.vnet.ibm.com writes:
Markus Armbruster arm...@redhat.com sent fixes for va_list vararg
issues in v9fs_string_alloc_printf(). It turns out the function
duplicates g_vasprintf() and can therefore be eliminated entirely.
Signed-off-by: Stefan Hajnoczi
On 29 October 2011 14:52, Alexander Graf ag...@suse.de wrote:
We should also show people unmaintained areas. The conclusion was a wiki
page with subsystems and status so people know what to expect. Maybe we
could generate this from the MAINTAINERS file?
Sounds like a good idea, although I
On Mon, Oct 31, 2011 at 12:41, Ian Campbell ian.campb...@citrix.com wrote:
Please CC xen-devel on patches which impact the Xen support in qemu.
On Fri, 2011-10-28 at 15:38 -0400, John Baboval wrote:
When in xen mode, handle the view of pm ioport appropriately.
I'm not entirely comfortable
The following changes since commit b5a12aa204f842c8010ac9d2e4b115114dbf09f0:
Merge branch 'rth/vis2' of git://repo.or.cz/qemu/rth (2011-10-27 20:27:07
+)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git for-anthony
Dong Xu Wang (1):
block: fix
From: Ronnie Sahlberg ronniesahlb...@gmail.com
Add new section for device URL syntax for special files and describe the iSCSI
URL with examples
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com
Reviewed-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Signed-off-by: Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
---
hw/ide/core.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 280a117..29305d3 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -2039,7
From: Paolo Bonzini pbonz...@redhat.com
The field is only in scsi-disk for now. Moving it up to SCSIDevice makes
it easier to reuse the scsi-generic reqops elsewhere.
At the same time, make scsi-generic get max_lba from snooped READ CAPACITY
commands as well.
Signed-off-by: Paolo Bonzini
Hi,
Here are the logistics for the upcoming 1.0 hard freeze. All dates are
reflected in the wiki[1].
If you're a contributor and you've sent a series before the soft freeze
deadline, you've already done everything you need to do so sit back and enjoy
gorge yourself on Halloween candy.
If
From: Paolo Bonzini pbonz...@redhat.com
This also requires little more than adding the new argument to
scsi_device_find, and the qdev property. All devices by default
end up on channel 0.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/esp.c
On Fri, Oct 28, 2011 at 11:02 AM, Zhi Yong Wu wu...@linux.vnet.ibm.com wrote:
+static void bdrv_io_limits_skip_set(void *opaque,
+ BlockAPIType co_type,
+ bool cb_skip,
+ bool limit_skip) {
Hi.
Am 31.10.2011 13:46, schrieb Hans de Goede:
If you're using libvirt to start qemu, then it will also pass
-usb to qemu, so you will have both a usb-1 (uhci) and a usb-2
(ehci) controller inside your vm, since your hostdev xml code does
not specify a bus the hostdev will likely get connected
From: Paolo Bonzini pbonz...@redhat.com
Otherwise, if cancellation is faked by the AIO layer and goes
through qemu_aio_flush, the whole request is completed synchronously
during scsi_req_cancel.
Using the enqueued flag would work here, but not in the next patches,
so I'm introducing a new
An early ping since I have no idea who counts as the submaintainer
for this patchset and it definitely needs to go in for 1.0...
thanks
-- PMM
On 28 October 2011 10:52, Peter Maydell peter.mayd...@linaro.org wrote:
These patches add enough of the TLS abstraction layer to allow us
to make
From: Paolo Bonzini pbonz...@redhat.com
The first two bytes (after the 8-byte ATAPI header) are the mode page
number and the number of bytes after the length field itself. Make
this clear in the code.
The AUDIO_CTL page was filled with wrong values. It is not anymore in
MMC, but at least keep
From: Paolo Bonzini pbonz...@redhat.com
As a complement to the previous patch, move definitions for GET EVENT
STATUS NOTIFICATION from the two functions to scsi-defs.h.
The NCR_* constants are just bit values corresponding to the ENC_*
values, with no offsets even, so keep just one copy.
From: Paolo Bonzini pbonz...@redhat.com
This adds support for media change notification via the GET EVENT STATUS
NOTIFICATION command, used by Linux versions 2.6.38 and newer.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 57
From: Paolo Bonzini pbonz...@redhat.com
Building on the previous patch, this one adds a media change callback
to scsi-disk.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-bus.c |5 +
hw/scsi-disk.c | 29
From: Paolo Bonzini pbonz...@redhat.com
This field is redundant, and having it makes it more complicated
to share reqops between the upcoming scsi-block and scsi-generic.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 35
From: Ronnie Sahlberg ronniesahlb...@gmail.com
This provides built-in support for iSCSI to QEMU.
This has the advantage that the iSCSI devices need not be made visible to the
host, which is useful if you have very many virtual machines and very many
iscsi devices.
It also has the benefit that
On Mon, Oct 31, 2011 at 11:29:04AM +0800, Mark Wu wrote:
A basic wildcard matching is supported in both the monitor command
trace-event and the events list file. That means you can enable/disable
the events having a common prefix in a batch. For example, virtio-blk trace
events could be
Daniel P. Berrange berra...@redhat.com writes:
On Fri, Oct 28, 2011 at 04:15:41PM -0700, Sumit Naiksatam (snaiksat) wrote:
Hi,
In its current implementation Libvirt makes sure that the network
interfaces that it passes/provision to a VM (for example to qemu[-kvm])
are already connected to
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 6909578..9c62569 100644
---
On Mon, Oct 31, 2011 at 8:25 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote:
On Mon, Oct 31, 2011 at 4:10 PM, Kevin Wolf kw...@redhat.com wrote:
Am 31.10.2011 04:01, schrieb Zhi Yong Wu:
It is better to use qiov.size in qed-table.c to get nb_sectors than
iov.iov_len.
Signed-off-by: Zhi Yong Wu
tmp_filename was used outside the block it was defined in, i.e. after it went
out of scope. Move its declaration to the top level.
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/block.c b/block.c
index
From: Paolo Bonzini pbonz...@redhat.com
Pass down the host status so that failing transport can be detected
by the guest. Similar treatment of host status could be done in
virtio-blk, too.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
From: Paolo Bonzini pbonz...@redhat.com
Also delete a stale occurrence of SCSIReqOps inside SCSIDeviceInfo.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-bus.c | 10 +-
hw/scsi-disk.c|2 +-
hw/scsi-generic.c |2
From: Paolo Bonzini pbonz...@redhat.com
Change the devs array into a linked list, and add a scsi_device_find
function to navigate the children list instead. This lets the SCSI
bus use more complex addressing, and HBAs can talk to the correct device
when there are multiple LUNs per target.
From: Paolo Bonzini pbonz...@redhat.com
Tested by the Windows Logo Kit SCSI Compliance test. From SBC-3, paragraph
5.25: The LOGICAL BLOCK ADDRESS field shall be set to zero if the PMI
bit is set to zero. If the PMI bit is set to zero and the LOGICAL BLOCK
ADDRESS field is not set to zero, then
On Mon, Oct 31, 2011 at 1:28 PM, Anthony Liguori aligu...@us.ibm.com wrote:
To make the Test Day more successful, please sign up to test a specific area
on the Test[3] wiki page.
[...]
[3] http://wiki.qemu.org/Planning/1.0/Testing
I just signed up for several block and tracing tests and
From: Paolo Bonzini pbonz...@redhat.com
Same as before, but for scsi-generic.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-generic.c | 18 ++
1 files changed, 18 insertions(+), 0 deletions(-)
diff --git
From: Paolo Bonzini pbonz...@redhat.com
This patch adds to scsi-disk the missing mode page 0x01 for both disk
and CD-ROM drives, and mode page 0x0e for CD drives only.
A few offsets were wrong in atapi.c. Also change the 2Ah mode page to
expose DVD media read capabilities in the IDE cdrom.
From: Eric Sunshine sunsh...@sunshineco.com
An entry in the VDI block map will hold an offset to the actual block if
the block is allocated, or one of two specially-interpreted values if
not allocated. Using VirtualBox terminology, value VDI_IMAGE_BLOCK_FREE
(0x) represents a
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-generic.c |2 +-
hw/scsi.h |3 +++
2 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 50 ++
1 files changed, 42 insertions(+), 8 deletions(-)
diff --git a/hw/scsi-disk.c
From: Ronnie Sahlberg ronniesahlb...@gmail.com
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
qemu-options.hx | 27 +++
1 files changed, 27 insertions(+), 0 deletions(-)
diff --git a/qemu-options.hx
From: Ronnie Sahlberg ronniesahlb...@gmail.com
This patch adds a short description of how to specify a NBD device
to QEMU.
Syntax for both TCP and Unix Domain Sockets are provided as well
as examples.
Signed-off-by: Ronnie Sahlberg ronniesahlb...@gmail.com
Signed-off-by: Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com
The request restart mechanism is generic and could be reused for
scsi-generic. In the meanwhile, pushing it to SCSIDevice avoids
that scsi_dma_restart_bh looks at SCSIGenericReqs when working on
a scsi-block device.
The code is the same that is already in
From: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 102 +++-
1 files changed, 101 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c
From: Paolo Bonzini pbonz...@redhat.com
This patch adds a few stub implementations for MMC commands to
scsi-disk, to be filled in later in the series. It also adds to
scsi-defs.h constants for commands implemented by ide/atapi.c,
when missing.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Am 28.10.2011 18:35, schrieb Paolo Bonzini:
On 10/28/2011 04:18 PM, Kevin Wolf wrote:
With the conversion of the block layer to coroutines, bdrv_read/write
have changed to run a nested event loop that calls qemu_bh_poll.
Consequently a scheduled BH can be called while a DMA transfer handler
From: Paolo Bonzini pbonz...@redhat.com
Same as for scsi-generic, avoid duplication even if it causes longer
lines.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
hw/scsi-disk.c | 92 +++
1
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Using bdrv_close() is not enough to free a BlockDriverState. Since we
explicitly create it with bdrv_new(), use bdrv_delete() to close and
delete it.
Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com
Signed-off-by: Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/block.c b/block.c
index 70aab63..f86984f 100644
--- a/block.c
+++ b/block.c
@@ -2028,11 +2028,7 @@ const char *bdrv_get_encrypted_filename(BlockDriverState
*bs)
From: Paolo Bonzini pbonz...@redhat.com
Instead of guessing the block size when there is no medium in the
drive, wait for the guest to send a READ CAPACITY command and snoop
it from there.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
From: Dong Xu Wang wdon...@linux.vnet.ibm.com
If qcow2_cache_flush failed, s-lock will not be unlock.
Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
block/qcow2.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git
Spotted via code review, we initialize offset to 0 to avoid a
compiler warning, but in the unlikely case that offset is
never set to something else, we should abort instead of return
a value that will almost certainly cause problems.
Signed-off-by: Alex Williamson alex.william...@redhat.com
---
From: Paolo Bonzini pbonz...@redhat.com
SCSI buses will need to read the children list first-to-last. This
requires using a QTAILQ, because hell breaks loose if you just try
inserting at the tail (thus reversing the order of all existing
visits from last-to-first to first-to-tail).
From: Paolo Bonzini pbonz...@redhat.com
The definitions in ide/internal.h are duplicates, since ATAPI commands
actually come from SCSI. Use the ones in scsi-defs.h and move the
missing ones there. Two exceptions:
- MODE_PAGE_WRITE_PARMS conflicts with the flexible disk geometry
page in
From: Zhi Yong Wu wu...@linux.vnet.ibm.com
Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com
Signed-off-by: Kevin Wolf kw...@redhat.com
---
docs/specs/qcow2.txt |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt
index
1 - 100 of 235 matches
Mail list logo
