[Qemu-devel] [PATCH 38/55] scsi-disk: fix retrying a flush

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Flush does not go anymore through scsi_disk_emulate_command. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH 10/55] vmdk: Improve error handling

2011-10-31 Thread Kevin Wolf
Return the right error values in some more places. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 6cdbfb7..fa0e8bd 100644 --- a/block/vmdk.c +++

[Qemu-devel] [PATCH 15/55] block: set bs-read_only before .bdrv_open()

2011-10-31 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Several block drivers set bs-read_only in .bdrv_open() but block.c:bdrv_open_common() clobbers its value. Additionally, QED uses bdrv_is_read_only() in .bdrv_open() to decide whether to perform consistency checks. The correct ordering is to

[Qemu-devel] [PATCH 07/55] qcow: Fix bdrv_write_compressed error handling

2011-10-31 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- block/qcow.c | 30 +++--- 1 files changed, 19 insertions(+), 11 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index ab36b29..35e21eb 100644 --- a/block/qcow.c +++

[Qemu-devel] [PATCH 26/55] scsi-disk: store valid mode pages in a table

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com A small refactoring of the MODE SENSE implementation in scsi-disk. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c | 25 + 1 files changed, 13 insertions(+), 12

[Qemu-devel] [PATCH 39/55] scsi-generic: drop SCSIGenericState

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com It is not needed, because s-bs is already stored in SCSIDevice, and can be reached from the conf.bs member. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-generic.c | 90

[Qemu-devel] [PATCH 11/55] vmdk: Fix possible segfaults

2011-10-31 Thread Kevin Wolf
Data we read from the disk isn't necessarily null terminated and may not contain the string we're looking for. The code needs to be a bit more careful here. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git

[Qemu-devel] [PATCH 24/55] scsi-disk: fix coding style issues (braces)

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-disk.c | 71 --- 1 files changed, 46 insertions(+), 25 deletions(-) diff --git a/hw/scsi-disk.c

[Qemu-devel] [PATCH 46/55] scsi-disk: small clean up to INQUIRY

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Set s-removable, s-qdev.blocksize and s-qdev.type in the callers of scsi_initfn. With this in place, s-qdev.type is allowed, and we can just reuse it as the first byte in VPD data (just like we do in standard INQUIRY data). Also set s-removable is set

[Qemu-devel] [PATCH 50/55] scsi: pass cdb to alloc_req

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This will let scsi-block choose between passthrough and emulation. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-bus.c |2 +- hw/scsi-disk.c|4 ++-- hw/scsi-generic.c |2 +-

[Qemu-devel] [PATCH 31/55] scsi: move tcq/ndev to SCSIBusOps (now SCSIBusInfo)

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/esp.c |7 +-- hw/lsi53c895a.c |9 ++--- hw/scsi-bus.c| 27 --- hw/scsi-disk.c |2 +- hw/scsi.h

Re: [Qemu-devel] 1.0 Hard Freeze Logistics

2011-10-31 Thread Anthony Liguori
On 10/31/2011 08:28 AM, Anthony Liguori wrote: Hi, Here are the logistics for the upcoming 1.0 hard freeze. All dates are reflected in the wiki[1]. If you're a contributor and you've sent a series before the soft freeze deadline, you've already done everything you need to do so sit back and

[Qemu-devel] [PATCH 34/55] scsi: implement REPORT LUNS for arbitrary LUNs

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-bus.c | 49 +++-- 1 files changed, 39 insertions(+), 10 deletions(-) diff --git a/hw/scsi-bus.c

[Qemu-devel] [PATCH 55/55] scsi-disk: add scsi-block for device passthrough

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com scsi-block is a new device that supports device passthrough of Linux block devices (i.e. /dev/sda, not /dev/sg0). It uses SG_IO for commands other than I/O commands, and regular AIO read/writes for I/O commands. Besides being simpler to configure (no

[Qemu-devel] [PATCH 41/55] scsi-generic: check ioctl statuses when SG_IO succeeds

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com A succeeding ioctl does not imply that the SCSI command succeeded. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- hw/scsi-generic.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff

[Qemu-devel] [PATCH 40/55] scsi-generic: remove scsi_req_fixup

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This is not needed anymore, since asynchronous ioctls were introduced by commit 221f715 (new scsi-generic abstraction, use SG_IO, 2009-03-28). Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com ---

[Qemu-devel] [PATCH 22/55] scsi: notify the device when unit attention is reported

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com Reporting media change events via unit attention sense codes requires a small state machine: first report NO MEDIUM, then report MEDIUM MAY HAVE CHANGED. Unfortunately there is no good hooking point for the device to notice that its pending unit attention

[Qemu-devel] [PATCH 52/55] scsi-disk: bump SCSIRequest reference count until aio completion runs

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com In some cases a request may be canceled before the completion callback runs. Keep a reference to the request between starting an AIO operation and the corresponding scsi_req_cancel or scsi_*_complete. When a request has to be retried, the request can be

[Qemu-devel] [PATCH 35/55] scsi: allow arbitrary LUNs

2011-10-31 Thread Kevin Wolf
From: Paolo Bonzini pbonz...@redhat.com This only requires changes in two places: in SCSIBus, we need to look for a free LUN if somebody creates a device with a pre-existing scsi-id but the default LUN (-1, meaning search for a free spot); in vSCSI, we need to actually parse the LUN according to

[Qemu-devel] [PATCH 09/55] vmdk: Fix use of uninitialised value

2011-10-31 Thread Kevin Wolf
In error cases, cid is never set. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 6be592f..6cdbfb7 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -208,7 +208,7 @@ static void

[Qemu-devel] [PATCH 16/55] block: reinitialize across bdrv_close()/bdrv_open()

2011-10-31 Thread Kevin Wolf
From: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Several BlockDriverState fields are not being reinitialized across bdrv_close()/bdrv_open(). Make sure they are reset to their default values. Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com Signed-off-by: Kevin Wolf kw...@redhat.com

Re: [Qemu-devel] Performance of USB2.0

2011-10-31 Thread Hans de Goede
Hi, On 10/31/2011 02:37 PM, Til Obes wrote: Hi. Am 31.10.2011 13:46, schrieb Hans de Goede: If you're using libvirt to start qemu, then it will also pass -usb to qemu, so you will have both a usb-1 (uhci) and a usb-2 (ehci) controller inside your vm, since your hostdev xml code does not

Re: [Qemu-devel] Patch for ui/cocoa.m

2011-10-31 Thread Juan Pineda
Hi Andreas, Thanks for your reply. You can verify that my cocoa.m patch works 100% under 0.15.1. That's where I was testing it. The fix is completely independent of the other problems in the OSX build (uint16, GThread, etc.) that have cropped up since 0.15.1, so there should be no problem

Re: [Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers

2011-10-31 Thread Paolo Bonzini
On 10/31/2011 03:46 PM, Kevin Wolf wrote: Hmm, I think you should set rearm = 1 to ensure the BH is run when ultimately you leave the sync read. Sorry for not spotting this before. I was about to agree, but in fact adding a rearm = 1; line leads to crashes, whereas in the version I posted

Re: [Qemu-devel] [PATCH] Error check find_ram_offset

2011-10-31 Thread Markus Armbruster
Alex Williamson alex.william...@redhat.com writes: Spotted via code review, we initialize offset to 0 to avoid a compiler warning, but in the unlikely case that offset is never set to something else, we should abort instead of return a value that will almost certainly cause problems.

Re: [Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers

2011-10-31 Thread Kevin Wolf
Am 31.10.2011 16:34, schrieb Paolo Bonzini: On 10/31/2011 03:46 PM, Kevin Wolf wrote: Hmm, I think you should set rearm = 1 to ensure the BH is run when ultimately you leave the sync read. Sorry for not spotting this before. I was about to agree, but in fact adding a rearm = 1; line leads

Re: [Qemu-devel] [PULL 0/3] 128-bit support for the memory API

2011-10-31 Thread Anthony Liguori
On 10/30/2011 09:02 AM, Avi Kivity wrote: This somewhat controversial patchset converts internal arithmetic in the memory API to 128 bits. Given the level of controversy, what do you think about deferring this to 1.1? Regards, Anthony Liguori It has been argued that with careful coding we

[Qemu-devel] [PATCH 0/2] net: socket backend uses uninitialized variables

2011-10-31 Thread Markus Armbruster
Compile-tested only, buyer beware. Markus Armbruster (2): net: socket backend passes junk size to getsockname(), fix net: socket backend shows junk in info network, fix net/socket.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) -- 1.7.6.4

[Qemu-devel] [PATCH 2/2] net: socket backend shows junk in info network, fix

2011-10-31 Thread Markus Armbruster
net_socket_fd_init_dgram() prints uninitialized saddr into nc-info_str. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- net/socket.c | 13 + 1 files changed, 9 insertions(+), 4 deletions(-) diff --git a/net/socket.c b/net/socket.c index

[Qemu-devel] [PATCH 1/2] net: socket backend passes junk size to getsockname(), fix

2011-10-31 Thread Markus Armbruster
net_socket_fd_init_dgram() passes an uninitialized address length to getsockname(). I guess this happens to work as long as the junk value is at least sizeof(sockaddr_in). Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- net/socket.c |1 + 1 files changed, 1

[Qemu-devel] Problem under OSX Lion: GThread-ERROR **: GThread system may only be initialized once

2011-10-31 Thread Juan Pineda
The current Qemu master branch crashes under OSX with a GThread error. Commenting out vlc.c line 2188 (call to g_thread_init) allows it to run successfully. I am running OSX Lion. Two caveats: 1) You need to apply Andreas' patch to softfloat.h to fix compile error for uint16 2) You need to

Re: [Qemu-devel] Problem under OSX Lion: GThread-ERROR **: GThread system may only be initialized once

2011-10-31 Thread Daniel P. Berrange
On Mon, Oct 31, 2011 at 09:25:26AM -0700, Juan Pineda wrote: The current Qemu master branch crashes under OSX with a GThread error. Commenting out vlc.c line 2188 (call to g_thread_init) allows it to run successfully. As a general rule all calls to 'g_thread_init(NULL)' should be protected by

Re: [Qemu-devel] [PATCH 05/14] eepro100: Use PCI DMA stub functions

2011-10-31 Thread Stefan Weil
Am 31.10.2011 07:06, schrieb David Gibson: From: Eduard - Gabriel Munteanueduard.munte...@linux360.ro This updates the eepro100 device emulation to use the explicit PCI DMA functions, instead of directly calling physical memory access functions. Signed-off-by: Eduard - Gabriel

Re: [Qemu-devel] [PATCH 0/2] Cocoa patches for 1.0

2011-10-31 Thread Juan Pineda
Hi Andreas, I just verified my cocoa.m patch under the master branch. Three things I needed to get the master branch to work under OSX: 1) Need to apply your softfpu.h patch 2) Need to configure using non LLVM gcc and disable broken user builds under OSX: --disable-user --cc=gcc-4.2

Re: [Qemu-devel] [PULL] libcacard patches

2011-10-31 Thread Anthony Liguori
On 10/25/2011 08:48 AM, Alon Levy wrote: The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at:

Re: [Qemu-devel] [PULL 00/55] Block patches

2011-10-31 Thread Anthony Liguori
On 10/31/2011 08:29 AM, Kevin Wolf wrote: The following changes since commit b5a12aa204f842c8010ac9d2e4b115114dbf09f0: Merge branch 'rth/vis2' of git://repo.or.cz/qemu/rth (2011-10-27 20:27:07 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony

Re: [Qemu-devel] [PULL 00/10] Trivial patches for October 15 to 26 2011

2011-10-31 Thread Anthony Liguori
On 10/26/2011 09:22 AM, Stefan Hajnoczi wrote: The following changes since commit d300854b1ccd036e0d7c58d789f4ab8d372263e6: target-sparc: Fix use of g_new0 / g_free (2011-10-25 19:30:33 +) are available in the git repository at: ssh://repo.or.cz/srv/git/qemu/stefanha.git

Re: [Qemu-devel] [PULL] VirtFS update 7

2011-10-31 Thread Anthony Liguori
On 10/25/2011 04:32 AM, Aneesh Kumar K.V wrote: Hi, This include all the pending patches for 1.0 The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are

Re: [Qemu-devel] [PULL 00/19]: QMP queue

2011-10-31 Thread Anthony Liguori
On 10/27/2011 02:01 PM, Luiz Capitulino wrote: Anthony, This pull request contains only my QAPI conversions round 2 series (which got no review comments... last chance!). The changes (since 9f60639b848944200c3d33a89233d808de0b5a43) are available in the following repository:

Re: [Qemu-devel] [PULL] spice patch queue

2011-10-31 Thread Anthony Liguori
On 10/25/2011 07:25 AM, Gerd Hoffmann wrote: Hi, Here comes a bunch of spice/qxl fixes and cleanups. No major changes. Pulled. Thanks. Regards, Anthony Liguori please pull, Gerd The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge

Re: [Qemu-devel] [PATCH 0/6] [PULL] qemu-kvm.git uq/master queue

2011-10-31 Thread Anthony Liguori
On 10/27/2011 07:10 AM, Marcelo Tosatti wrote: The following changes since commit 952e849c150b4f1b89f8728cba00f925c1d6e75b: Merge remote-tracking branch 'bonzini/split-main-loop-for-anthony' into staging (2011-10-24 10:51:12 -0500) are available in the git repository at:

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Stefan Weil
Am 31.10.2011 07:38, schrieb Markus Armbruster: Alexander Graf ag...@suse.de writes: On 30.10.2011, at 13:07, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when

Re: [Qemu-devel] [PATCH v3 03/13] qemu-timer: move common code to qemu_rearm_alarm_timer

2011-10-31 Thread Stefan Weil
Am 31.10.2011 11:05, schrieb Paolo Bonzini: On 10/31/2011 08:23 AM, TeLeMan wrote: static void qemu_rearm_alarm_timer(struct qemu_alarm_timer *t) { -if (!alarm_has_dynticks(t)) +int64_t nearest_delta_ns; +assert(alarm_has_dynticks(t)); mmtimer and win32 alarms have no

Re: [Qemu-devel] [PATCH v3 0/3] TLS abstraction layer for thread-local cpu_single_env on Linux

2011-10-31 Thread Jan Kiszka
On 2011-10-31 14:40, Peter Maydell wrote: An early ping since I have no idea who counts as the submaintainer for this patchset and it definitely needs to go in for 1.0... I think it's rather a central system this touches. So it's likely a super-maintainer thing. Anyway, you have my ack on

Re: [Qemu-devel] Problem under OSX Lion: GThread-ERROR **: GThread system may only be initialized once

2011-10-31 Thread Andreas Färber
Am 31.10.2011 17:36, schrieb Daniel P. Berrange: On Mon, Oct 31, 2011 at 09:25:26AM -0700, Juan Pineda wrote: The current Qemu master branch crashes under OSX with a GThread error. Commenting out vlc.c line 2188 (call to g_thread_init) allows it to run successfully. As a general rule all

Re: [Qemu-devel] [PATCH] dma: Avoid reentrancy in DMA transfer handlers

2011-10-31 Thread Kevin Wolf
Am 31.10.2011 17:00, schrieb Kevin Wolf: Am 31.10.2011 16:34, schrieb Paolo Bonzini: On 10/31/2011 03:46 PM, Kevin Wolf wrote: Hmm, I think you should set rearm = 1 to ensure the BH is run when ultimately you leave the sync read. Sorry for not spotting this before. I was about to agree,

[Qemu-devel] [PATCH v2] dma: Avoid reentrancy in DMA transfer handlers

2011-10-31 Thread Kevin Wolf
With the conversion of the block layer to coroutines, bdrv_read/write have changed to run a nested event loop that calls qemu_bh_poll. Consequently a scheduled BH can be called while a DMA transfer handler runs and this means that DMA_run becomes reentrant. Devices haven't been designed to cope

Re: [Qemu-devel] [PATCH] hw/9pfs: use g_vasprintf() instead of rolling our own

2011-10-31 Thread Aneesh Kumar K.V
On Mon, 31 Oct 2011 11:49:33 +, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: Markus Armbruster arm...@redhat.com sent fixes for va_list vararg issues in v9fs_string_alloc_printf(). It turns out the function duplicates g_vasprintf() and can therefore be eliminated entirely.

Re: [Qemu-devel] [PATCH v3 0/3] TLS abstraction layer for thread-local cpu_single_env on Linux

2011-10-31 Thread Anthony Liguori
On 10/31/2011 08:40 AM, Peter Maydell wrote: An early ping since I have no idea who counts as the submaintainer for this patchset and it definitely needs to go in for 1.0... I'm in the process of testing them and will apply provided nothing breaks. Regards, Anthony Liguori thanks -- PMM

Re: [Qemu-devel] [PATCH v3 01/13] remove unused function

2011-10-31 Thread Anthony Liguori
Are you planning on spinning a v4 with TeLeMan's suggestions by tomorrow? Regards, Anthony Liguori On 10/21/2011 11:26 AM, Paolo Bonzini wrote: Reviewed-by: Anthony Liguorialigu...@us.ibm.com Signed-off-by: Paolo Bonzinipbonz...@redhat.com --- hw/mac_dbdma.c |5 - hw/mac_dbdma.h |

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Anthony Liguori
On 10/30/2011 07:07 AM, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when memalign is called with an alignment larger than 1 MiB. QEMU normally uses 2 MiB on Linux

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Daniel P. Berrange
On Sun, Oct 30, 2011 at 01:07:26PM +0100, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when memalign is called with an alignment larger than 1 MiB. QEMU normally

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Markus Armbruster
Stefan Weil s...@weilnetz.de writes: Am 31.10.2011 07:38, schrieb Markus Armbruster: Alexander Graf ag...@suse.de writes: On 30.10.2011, at 13:07, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not

[Qemu-devel] [PATCH v3 2/4] Add access control support to qemu bridge helper

2011-10-31 Thread Corey Bryant
We go to great lengths to restrict ourselves to just cap_net_admin as an OS enforced security mechanism. However, we further restrict what we allow users to do to simply adding a tap device to a bridge interface by virtue of the fact that this is the only functionality we expose. This is not

[Qemu-devel] [PATCH v3 4/4] Add support for net bridge

2011-10-31 Thread Corey Bryant
The most common use of -net tap is to connect a tap device to a bridge. This requires the use of a script and running qemu as root in order to allocate a tap device to pass to the script. This model is great for portability and flexibility but it's incredibly difficult to eliminate the need to

[Qemu-devel] [PATCH v3 0/4] -net bridge: rootless bridge support for qemu

2011-10-31 Thread Corey Bryant
With qemu it is possible to run a guest from an unprivileged user but if we wanted to communicate with the outside world we had to switch to root. We address this problem by introducing a new network backend and a new network option for -net tap. This is less flexible when compared to existing

[Qemu-devel] [PATCH v3 1/4] Add basic version of bridge helper

2011-10-31 Thread Corey Bryant
This patch adds a helper that can be used to create a tap device attached to a bridge device. Since this helper is minimal in what it does, it can be given CAP_NET_ADMIN which allows qemu to avoid running as root while still satisfying the majority of what users tend to want to do with tap

[Qemu-devel] [PATCH v3 3/4] Add cap reduction support to enable use as SUID

2011-10-31 Thread Corey Bryant
The ideal way to use qemu-bridge-helper is to give it an fscap of using: setcap cap_net_admin=ep qemu-bridge-helper Unfortunately, most distros still do not have a mechanism to package files with fscaps applied. This means they'll have to SUID the qemu-bridge-helper binary. To improve

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Stefan Weil
Am 31.10.2011 19:22, schrieb Daniel P. Berrange: On Sun, Oct 30, 2011 at 01:07:26PM +0100, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when memalign is called with

[Qemu-devel] [PATCH v2 0/3] Misc small fixes in cmd.c

2011-10-31 Thread Pavel Borzenkov
The first patch fixes coding style of the functions affected by next two patches. Second patch fixes potential NULL pointer dereference (return value of realloc is not checked). Third patch fixes potential memory leak (for the case when realloc returns NULL). Pavel Borzenkov (3): cmd: Fix

[Qemu-devel] [PATCH v2 2/3] cmd: Fix potential NULL pointer dereference

2011-10-31 Thread Pavel Borzenkov
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com --- cmd.c | 11 +++ 1 files changed, 3 insertions(+), 8 deletions(-) diff --git a/cmd.c b/cmd.c index a6e3ef4..75415d8 100644 --- a/cmd.c +++ b/cmd.c @@ -47,7 +47,7 @@ compare(const void *a, const void *b) void

[Qemu-devel] [PATCH v2 3/3] cmd: Fix potential memory leak

2011-10-31 Thread Pavel Borzenkov
Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com --- cmd.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/cmd.c b/cmd.c index 75415d8..0806e18 100644 --- a/cmd.c +++ b/cmd.c @@ -329,16 +329,21 @@ char **breakline(char *input, int *count) int c = 0;

[Qemu-devel] [PATCH v2 1/3] cmd: Fix coding style in cmd.c

2011-10-31 Thread Pavel Borzenkov
Before the next patches, fix coding style of the affected functions. Signed-off-by: Pavel Borzenkov pavel.borzen...@gmail.com --- cmd.c | 168 - 1 files changed, 82 insertions(+), 86 deletions(-) diff --git a/cmd.c b/cmd.c index

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Stefan Weil
Am 31.10.2011 19:30, schrieb Markus Armbruster: Copies are evil because we need to pick the one version that's right for all our users. Repeatedly. That's okay (sort of) when there's a tight coupling, and there's really only one admissible version. Or it may be a lesser evil when the thing

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Stefan Weil
Am 31.10.2011 19:13, schrieb Anthony Liguori: On 10/30/2011 07:07 AM, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when memalign is called with an alignment larger

[Qemu-devel] KVM call agenda for November 1st

2011-10-31 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan. PD. Tomorrow is a Spanish holiday, so I would not attend the call.

[Qemu-devel] KVM call agenda for November 1st

2011-10-31 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH] linux-user: add binfmt wrapper for argv[0] handling

2011-10-31 Thread Riku Voipio
On Sat, Oct 29, 2011 at 08:08:39PM +0200, Alexander Graf wrote: When using qemu's linux-user binaries through binfmt, argv[0] gets lost along the execution because qemu only gets passed in the full file name to the executable while argv[0] can be something completely different. This

[Qemu-devel] [PATCH v2 0/4] Cocoa patches for 1.0

2011-10-31 Thread Andreas Färber
Hello, Here's an updated series, including a runtime abort fix and a GUI bugfix. Note: Patch 3/4 touches generic code. Regards, Andreas Andreas Färber (4): MAINTAINERS: Add Cocoa maintainer softfloat: Avoid uint16 type conflict on Darwin vl.c: Guard against GThread double-initialization

[Qemu-devel] [PATCH v2 1/4] MAINTAINERS: Add Cocoa maintainer

2011-10-31 Thread Andreas Färber
Degrade cocoa.m from Maintained to Odd Fixes. Signed-off-by: Andreas Färber andreas.faer...@web.de Cc: Anthony Liguori aligu...@us.ibm.com --- MAINTAINERS |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 2b4c5d7..c08951c 100644 ---

[Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-10-31 Thread Andreas Färber
In file included from ./bswap.h:7, from ./qemu-common.h:106, from ./qemu-aio.h:17, from ./Block.h:4, from /System/Library/Frameworks/CoreServices.framework/Frameworks/CarbonCore.framework/Headers/FSEvents.h:28,

Re: [Qemu-devel] [PATCH] Support running QEMU on Valgrind

2011-10-31 Thread Anthony Liguori
On 10/31/2011 02:03 PM, Stefan Weil wrote: Am 31.10.2011 19:13, schrieb Anthony Liguori: On 10/30/2011 07:07 AM, Stefan Weil wrote: Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when

[Qemu-devel] [PATCH v2 3/4] vl.c: Guard against GThread double-initialization

2011-10-31 Thread Andreas Färber
GThread-ERROR **: GThread system may only be initialized once. aborting... Making the g_thread_init() call in vl.c conditional resolves an abort on Mac OS X, where coroutine-gthread.c seems to call it before vl.c. Reported-by: Juan Pineda j...@logician.com Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH v2 4/4] cocoa: Close sheet after image file selection

2011-10-31 Thread Andreas Färber
If no disk image is specified, the Cocoa frontend displays a modal sheet to let the user select an image file to boot from. This sheet is never closed and it permanently obscures the emulator window. Close it after obtaining the file name in case the user did select a file. Otherwise we exit

[Qemu-devel] [PULL] [PATCH 00/10] Linux-user patches for 1.0

2011-10-31 Thread Riku Voipio
Fixes related linux-user qemu targetting 1.0 are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream Alexander Graf (2): linux-user: fix openat linux-user: implement reboot syscall Matthias Braun (3): linux-user: fix

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-10-31 Thread Peter Maydell
On 31 October 2011 19:18, Andreas Färber andreas.faer...@web.de wrote: --- a/fpu/softfloat.h +++ b/fpu/softfloat.h @@ -54,6 +54,9 @@ these four paragraphs for those parts of this code that are retained.  | to the same as `int'.  

Re: [Qemu-devel] [PATCH 13/25] vmstate: port ppc cpu

2011-10-31 Thread Juan Quintela
Alexander Graf ag...@suse.de wrote: On 25.10.2011, at 16:00, Juan Quintela wrote: Added sdr1_vmstate because storing the value requires calling ppc_store_sdr1(). The position when the function is called also changes (I think it is save). Thanks for converting this. I'm fairly sure that

[Qemu-devel] [Bug 884401] [NEW] PCI Passthrough for Digium TCE400P Codec Card Not working

2011-10-31 Thread Ray Seals
Public bug reported: trying to use a Digium TCE400P Codec card on a Virtual instance using the following information: lspci enter 02:08.0 Ethernet controller: Digium, Inc. Wildcard TCE400P transcoder base card (rev 11) lspci -n enter 02:08.0 0200: d161:8004 (rev 11) virsh nodedev-list | grep

Re: [Qemu-devel] [PATCH v2 2/4] softfloat: Avoid uint16 type conflict on Darwin

2011-10-31 Thread Andreas Färber
Am 31.10.2011 20:42, schrieb Peter Maydell: On 31 October 2011 19:18, Andreas Färber andreas.faer...@web.de wrote: --- a/fpu/softfloat.h +++ b/fpu/softfloat.h @@ -54,6 +54,9 @@ these four paragraphs for those parts of this code that are retained. | to the same as `int'.

[Qemu-devel] [PATCH v2] Support running QEMU on Valgrind

2011-10-31 Thread Stefan Weil
Valgrind is a tool which can automatically detect many kinds of bugs. Running QEMU on Valgrind with x86_64 hosts was not possible because Valgrind aborts when memalign is called with an alignment larger than 1 MiB. QEMU normally uses 2 MiB on Linux x86_64. Now the alignment is reduced to the

Re: [Qemu-devel] [PULL] [PATCH 00/10] Linux-user patches for 1.0

2011-10-31 Thread Anthony Liguori
On 10/31/2011 02:27 PM, Riku Voipio wrote: Fixes related linux-user qemu targetting 1.0 are available in the git repository at: git://git.linaro.org/people/rikuvoipio/qemu.git linux-user-for-upstream Pulled. Thanks. Regards, Anthony Liguori Alexander Graf (2): linux-user: fix

[Qemu-devel] [PATCH 01/13] hw/9pfs: Move opt validation to FsDriver callback

2011-10-31 Thread M. Mohan Kumar
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This remove all conditional code from common code path and make opt validation a FSDriver callback. Signed-off-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- fsdev/file-op-9p.h

[Qemu-devel] [PATCH 04/13] hw/9pfs: File system helper process for qemu 9p proxy FS

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Provide root privilege access to QEMU 9p proxy filesystem using socket communication. Proxy helper is started by root user as: ~ # virtfs-proxy-helper {{-s|--socket socketname -u|--uid -g|--gid}|{-f|--fd socket descriptor}} -p path-to-share [-r runasuid

[Qemu-devel] [PATCH 05/13] hw/9pfs: Add support to use named socket for proxy FS

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add option to use named socket for communicating between proxy helper and qemu proxy FS. Access to socket can be given by using command line options -u and -g. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/virtfs-proxy-helper.c | 89

[Qemu-devel] [PATCH 07/13] hw/9pfs: Create other filesystem objects

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add interfaces to create filesystem objects like directory, device nodes, symbolic links, links for proxy filesytem driver Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/proxy.h |4 ++ hw/9pfs/virtfs-proxy-helper.c | 63

[Qemu-devel] [PATCH 09/13] hw/9pfs: File ownership and others

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add file ownership interfaces like chmod/chown, utime update, rename, remove and truncating files for proxy FS Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/proxy.h |6 ++ hw/9pfs/virtfs-proxy-helper.c | 61

[Qemu-devel] [PATCH 13/13] hw/9pfs: man page for proxy helper

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- Makefile | 12 ++- hw/9pfs/virtfs-proxy-helper.texi | 63 ++ 2 files changed, 74 insertions(+), 1 deletions(-) create mode 100644

[Qemu-devel] [PATCH 12/13] hw/9pfs: Documentation changes related to proxy fs

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- qemu-options.hx | 30 ++ 1 files changed, 22 insertions(+), 8 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 8df6165..eef98c5 100644 --- a/qemu-options.hx

[Qemu-devel] [PATCH 08/13] hw/9pfs: Add stat/readlink/statfs for proxy FS

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/proxy.h |3 ++ hw/9pfs/virtfs-proxy-helper.c | 81 - hw/9pfs/virtio-9p-proxy.c | 67 +++--- 3 files

[Qemu-devel] [PATCH 03/13] hw/9pfs: Add new proxy filesystem driver

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add new proxy filesystem driver to add root privilege to qemu process. It needs a helper process to be started by root user. Following command line can be used to utilize proxy filesystem driver -virtfs proxy,id=id,mount_tag=tag,sock_fd=socket-fd

[Qemu-devel] [PATCH 02/13] hw/9pfs: Move pdu_marshal/unmarshal code to a seperate file

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Move p9 marshaling/unmarshaling code to a separate file so that proxy filesytem driver can use these calls. Also made marshaling code generic to accept struct iovec instead of V9fsPDU. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com Signed-off-by: Aneesh

Re: [Qemu-devel] [libvirt] RFC decoupling VM NIC provisioning from VM NIC connection to backend networks

2011-10-31 Thread Christian Benvenuti (benve)
-Original Message- From: qemu-devel-bounces+benve=cisco@nongnu.org [mailto:qemu-devel- bounces+benve=cisco@nongnu.org] On Behalf Of Daniel P. Berrange Sent: Monday, October 31, 2011 3:49 AM To: Sumit Naiksatam (snaiksat) Cc: libvir-l...@redhat.com; David Wang (dwang2); Ram

Re: [Qemu-devel] [PATCH v3 5/6] target-mips: Adding support for Cavium specific instructions

2011-10-31 Thread Andreas Färber
Am 28.10.2011 06:42, schrieb Khansa Butt: On Sat, Oct 22, 2011 at 4:36 PM, Andreas Färber andreas.faer...@web.de mailto:andreas.faer...@web.de wrote: Am 22.10.2011 12:11, schrieb kha...@kics.edu.pk mailto:kha...@kics.edu.pk: HTML again :( From: Khansa Butt

Re: [Qemu-devel] [libvirt] RFC decoupling VM NIC provisioning fromVM NIC connection to backend networks

2011-10-31 Thread Christian Benvenuti (benve)
-Original Message- From: qemu-devel-bounces+benve=cisco@nongnu.org [mailto:qemu-devel- bounces+benve=cisco@nongnu.org] On Behalf Of Markus Armbruster Sent: Monday, October 31, 2011 7:05 AM To: Daniel P. Berrange Cc: libvir-l...@redhat.com; David Wang (dwang2); Ram Durairaj

[Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode

2011-10-31 Thread Stefan Weil
Hi, this is a 3rd version of the patch series which adds support for QEMU on any host by using a TCG interpreter (TCI). Version 2 was sent to the list and is available here: http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg02504.html The new version removed the TRACE macros which I used

Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode

2011-10-31 Thread Anthony Liguori
On 10/31/2011 04:31 PM, Stefan Weil wrote: Hi, this is a 3rd version of the patch series which adds support for QEMU on any host by using a TCG interpreter (TCI). Version 2 was sent to the list and is available here: http://lists.gnu.org/archive/html/qemu-devel/2011-10/msg02504.html The new

[Qemu-devel] [PATCH 00/13] Proxy FS driver for VirtFS

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Pass-through security model in QEMU 9p server needs root privilege to do few file operations (like chown, chmod to any mode/uid:gid). There are two issues in pass-through security model 1) TOCTTOU vulnerability: Following symbolic links in the server could

[Qemu-devel] [PATCH 10/13] hw/9pfs: xattr interfaces in proxy filesystem driver

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add xattr support for proxy FS Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- hw/9pfs/proxy.h |4 ++ hw/9pfs/virtfs-proxy-helper.c | 60 hw/9pfs/virtio-9p-proxy.c | 121

[Qemu-devel] [PATCH 06/13] hw/9pfs: Open and create files

2011-10-31 Thread M. Mohan Kumar
From: M. Mohan Kumar mo...@in.ibm.com Add interfaces to open and create files for proxy file system driver. Signed-off-by: M. Mohan Kumar mo...@in.ibm.com --- Makefile |2 + configure |1 + hw/9pfs/proxy.h |6 ++

Re: [Qemu-devel] [PULL] tcg/interpreter: Add TCG + interpreter for bytecode

2011-10-31 Thread Stefan Weil
Am 31.10.2011 22:38, schrieb Anthony Liguori: On 10/31/2011 04:31 PM, Stefan Weil wrote: Hi, this is a 3rd version of the patch series which adds support for QEMU on any host by using a TCG interpreter (TCI). Version 2 was sent to the list and is available here:

<    1   2   3   >