Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 08:50 AM, Avi Kivity wrote: On 11/07/2011 04:44 PM, Anthony Liguori wrote: This a guest ABI change. Do we want -M support for it? Given that the old subsystem id isn't valid I'd say no unless someone comes up with a good reason. Do we know that Windows won't complain about it?

[Qemu-devel] KVM call agenda for November 8th

2011-11-07 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Thanks, Juan.

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 04:53 PM, Anthony Liguori wrote: >> I think so, but that's unrelated. The worry is that some DRM code >> checksums your hardware and complains if it changed too much. Nothing >> to do with the test suite. >> >> The sense of Gerd's comment is reversed. We should preserve the ABI >>

Re: [Qemu-devel] backing_file Path

2011-11-07 Thread Markus Armbruster
Zhi Hui Li writes: > when I trace the code of qemu-img.c, I found in the image file, the > backing_file use the relative path, I think Maybe it has some > problems. > > for example: > > 1: qemu-img create -o backing_file=../ aa.img 5G > > 2: qemu-system-x86_64 aa.img > > if you change aa.im

Re: [Qemu-devel] [Xen-devel] [PATCH V3 02/10] Introduce HostPCIDevice to access a pci device on the host.

2011-11-07 Thread Anthony PERARD
On Fri, Nov 4, 2011 at 17:49, Konrad Rzeszutek Wilk wrote: >> +static unsigned long get_value(HostPCIDevice *d, const char *name) >> +{ >> +    char path[PATH_MAX]; >> +    FILE *f; >> +    unsigned long value; >> + >> +    path_to(d, name, path, sizeof (path)); >> +    f = fopen(path, "r"); >> +

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
Hi, > This is more of an edge case however, since we know that hardware tools > rely on PCI IDs. The ID is invalid, you can't do anything useful with it ... > For example our hypothetical ABI signature tool will > certainly include lspci like functionality and detect this as a change. ... exc

[Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
I wrote this quickly to aid in testing. It's similar to qmp-shell with a few important differences: 1) It is not interactive. That makes it useful for scripting. 2) qmp-shell: (QEMU) set_password protocol=vnc password=foo 3) qmp: $ qmp set_password --protocol=vnc --password=foo 4) Extensibl

Re: [Qemu-devel] [PATCH v12 3/5] block: add I/O throttling algorithm

2011-11-07 Thread Kevin Wolf
Am 03.11.2011 09:57, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > Signed-off-by: Stefan Hajnoczi > --- > block.c | 220 > +++ > block.h |1 + > block_int.h |1 + > 3 files changed, 222 insertions(+), 0 deletions(-)

Re: [Qemu-devel] [PATCH 1.0] ac97: don't override the pci subsystem id

2011-11-07 Thread Avi Kivity
On 11/07/2011 05:10 PM, Gerd Hoffmann wrote: > Hi, > > > This is more of an edge case however, since we know that hardware tools > > rely on PCI IDs. > > The ID is invalid, you can't do anything useful with it ... > > > For example our hypothetical ABI signature tool will > > certainly include ls

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server 2003 whenever it tries to reboot. The QEMU monitor is available and working. I'm using a qcow2 image over IDE, but this may not be qcow2/block related. This is a regression and doe

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 7, 2011 at 3:21 PM, Paolo Bonzini wrote: > On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: >> >> For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server >> 2003 whenever it tries to reboot.  The QEMU monitor is available and >> working.  I'm using a qcow2 image over IDE, but

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:21 AM, Paolo Bonzini wrote: On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server 2003 whenever it tries to reboot. The QEMU monitor is available and working. I'm using a qcow2 image over IDE, but this may not be qcow2/

Re: [Qemu-devel] [PATCH v12 4/5] hmp/qmp: add block_set_io_throttle

2011-11-07 Thread Kevin Wolf
Am 03.11.2011 09:57, schrieb Zhi Yong Wu: > Signed-off-by: Zhi Yong Wu > Signed-off-by: Stefan Hajnoczi > --- > block.c | 15 + > blockdev.c | 59 > ++ > blockdev.h |2 + > hmp-commands.hx | 15 +

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:22 AM, Stefan Hajnoczi wrote: On Mon, Nov 7, 2011 at 3:21 PM, Paolo Bonzini wrote: On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server 2003 whenever it tries to reboot. The QEMU monitor is available and working.

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Markus Armbruster
Paolo Bonzini writes: > On 11/07/2011 02:21 PM, Markus Armbruster wrote: >> The commit message should explain why we need this callback. The cover >> letter says "support for eject requests is required by udev 173." >> Please elaborate on that. > > Well, first and foremost eject requests are in

Re: [Qemu-devel] [PATCH v12 5/5] block: perf testing report based on block I/O throttling

2011-11-07 Thread Kevin Wolf
Am 03.11.2011 09:57, schrieb Zhi Yong Wu: > The file 1mbps.dat is based on bps=1024*1024 I/O throttling; and the file > 10mbps.dat is based on bps=10*1024*1024 I/O throttling. > > Signed-off-by: Zhi Yong Wu > --- > 10mbps.dat | 310 ++ > 1mbp

[Qemu-devel] [PATCH 1/2] pc: add 1.0 machine type

2011-11-07 Thread Gerd Hoffmann
This patch adds a pc-1.0 machine type. Signed-off-by: Gerd Hoffmann --- hw/pc_piix.c | 14 +++--- 1 files changed, 11 insertions(+), 3 deletions(-) diff --git a/hw/pc_piix.c b/hw/pc_piix.c index 8c7f2b7..93e40d0 100644 --- a/hw/pc_piix.c +++ b/hw/pc_piix.c @@ -297,8 +297,8 @@ static v

[Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:1100) instead. [ v2: old & broken id is mainta

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Alon Levy
On Mon, Nov 07, 2011 at 09:22:46AM -0600, Anthony Liguori wrote: > On 11/07/2011 09:21 AM, Paolo Bonzini wrote: > >On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: > >>For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server > >>2003 whenever it tries to reboot. The QEMU monitor is availabl

Re: [Qemu-devel] Guest hangs on reboot with Windows Server 2003

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:49 AM, Alon Levy wrote: On Mon, Nov 07, 2011 at 09:22:46AM -0600, Anthony Liguori wrote: On 11/07/2011 09:21 AM, Paolo Bonzini wrote: On 11/07/2011 02:52 PM, Stefan Hajnoczi wrote: For QEMU 1.0 Test Day I'm hitting a guest hang with Windows Server 2003 whenever it tries to reb

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:

[Qemu-devel] [Bug 885213] Re: Latest GIT version fails to compile on Linux cris-softmmu/pci-stub.c

2011-11-07 Thread Nigel Horne
Thanks for the fix. I've done as you suggested, and the latest version now compiles. Please close. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bu

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: > I wrote this quickly to aid in testing. It's similar to qmp-shell with a few > important differences: > > 1) It is not interactive. That makes it useful for scripting. > > 2) qmp-shell: > > (QEMU) set_password protocol=vnc password=

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
On 11/07/2011 10:08 AM, Luiz Capitulino wrote: On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: I wrote this quickly to aid in testing. It's similar to qmp-shell with a few important differences: 1) It is not interactive. That makes it useful for scripting. 2) qmp-shell: (QEMU) s

Re: [Qemu-devel] [PATCH 6/8] block: add eject request callback

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 04:23 PM, Markus Armbruster wrote: 1. eject without -f is as you mentioned. Would implementing the missing part help with the problem at hand? It would help for non-buggy guests. Buggy means even "echo -1 > /sys/block/sr0/events_poll_msecs". However, a full solution would re

Re: [Qemu-devel] [Qemu-trivial] [PATCH] qemu-tech.texi: Remove libqemu from QEMU generic features

2011-11-07 Thread Stefan Hajnoczi
On Mon, Nov 07, 2011 at 05:47:05PM +0800, 陳韋任 wrote: > On Mon, Nov 07, 2011 at 08:18:01AM +, Stefan Hajnoczi wrote: > > On Sat, Nov 05, 2011 at 09:06:54AM +0800, 陳韋任 wrote: > > > According to [1], libqemu is not available anymore. Remove libqemu > > > from QEMU generic features. > > > > > >

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 07 Nov 2011 10:09:55 -0600 Anthony Liguori wrote: > On 11/07/2011 10:08 AM, Luiz Capitulino wrote: > > On Mon, 7 Nov 2011 09:11:15 -0600 > > Anthony Liguori wrote: > > > >> I wrote this quickly to aid in testing. It's similar to qmp-shell with a > >> few > >> important differences: >

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Anthony Liguori
On 11/07/2011 10:30 AM, Luiz Capitulino wrote: On Mon, 07 Nov 2011 10:09:55 -0600 Anthony Liguori wrote: On 11/07/2011 10:08 AM, Luiz Capitulino wrote: On Mon, 7 Nov 2011 09:11:15 -0600 Anthony Liguori wrote: I wrote this quickly to aid in testing. It's similar to qmp-shell with a few i

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Luiz Capitulino
On Mon, 07 Nov 2011 10:35:51 -0600 Anthony Liguori wrote: > On 11/07/2011 10:30 AM, Luiz Capitulino wrote: > > On Mon, 07 Nov 2011 10:09:55 -0600 > > Anthony Liguori wrote: > > > >> On 11/07/2011 10:08 AM, Luiz Capitulino wrote: > >>> On Mon, 7 Nov 2011 09:11:15 -0600 > >>> Anthony Liguori wr

Re: [Qemu-devel] [PATCH 1/3] Support guest reboots when in Xen HVM mode

2011-11-07 Thread Stefano Stabellini
On Fri, 28 Oct 2011, John Baboval wrote: > Call xc_domain_shutdown with the reboot flag when the guest requests a > reboot. Thanks for the patch! Sorry for the delay in replaying but away for XenSummit Asia. > Signed-off-by: John V. Baboval > Signed-off-by: Tom Goetz > --- > xen-all.c | 22

Re: [Qemu-devel] [PATCH 2/3] Xen conditionals

2011-11-07 Thread Stefano Stabellini
On Fri, 28 Oct 2011, John Baboval wrote: > Don't perform RTC or APIC setup when running in xen mode. Both are actually emulated in Xen so registering the two devices in Qemu is harmless because they are never going to receive any events from the hypervisor. Thus I would rather keep the difference

Re: [Qemu-devel] [PATCH 1/3] Support guest reboots when in Xen HVM mode

2011-11-07 Thread John Baboval
On 11/07/2011 11:43 AM, Stefano Stabellini wrote: On Fri, 28 Oct 2011, John Baboval wrote: Call xc_domain_shutdown with the reboot flag when the guest requests a reboot. Thanks for the patch! Sorry for the delay in replaying but away for XenSummit Asia. Signed-off-by: John V. Baboval Signed

[Qemu-devel] [PATCH 6/8 v2] block: add eject request callback

2011-11-07 Thread Paolo Bonzini
Recent versions of udev always keep the tray locked so that the kernel can observe "eject request" events (aka tray button presses) even on discs that aren't mounted. Add support for these events in the ATAPI and SCSI cd drive device models. To let management cope with the behavior of udev, an ev

[Qemu-devel] [PATCH 00/11] Block patches for 1.0

2011-11-07 Thread Kevin Wolf
The following changes since commit 932eacc158c064935c7bab920c88a93a629e1ca4: Merge branch 'xtensa' of git://jcmvbkbc.spb.ru/dumb/qemu-xtensa (2011-11-02 20:52:23 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Dong Xu Wang (2): block/cloop:

[Qemu-devel] [PATCH 03/11] dma: Avoid reentrancy in DMA transfer handlers

2011-11-07 Thread Kevin Wolf
With the conversion of the block layer to coroutines, bdrv_read/write have changed to run a nested event loop that calls qemu_bh_poll. Consequently a scheduled BH can be called while a DMA transfer handler runs and this means that DMA_run becomes reentrant. Devices haven't been designed to cope wi

[Qemu-devel] [PATCH 01/11] qemu-io: Handle create_iovec errors

2011-11-07 Thread Kevin Wolf
Callers of create_iovec() didn't check for failure and continued with uninitialised data in error cases. This patch adds checks to each call. Signed-off-by: Kevin Wolf --- qemu-io.c | 28 1 files changed, 24 insertions(+), 4 deletions(-) diff --git a/qemu-io.c b/q

[Qemu-devel] [PATCH 08/11] vvfat: need to use first_sectors_number to distinguish fdd/hdd

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini This is consistent with what "real" floppies have, so file(1) now actually recognizes the VVFAT image as a 1.44 MB floppy. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vvfat.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/b

[Qemu-devel] [PATCH 10/11] vvfat: do not hardcode sector counts in error message

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vvfat.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 3e7b407..faf2947 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -916,11 +916,8 @@ s

[Qemu-devel] [PATCH 06/11] vvfat: fix out of bounds array_get usage

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini When reading the address of the first free entry, you cannot use array_get without first marking all entries as occupied. This is visible if you change the sectors per cluster on a floppy from 2 to 1. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vvfat.

[Qemu-devel] [PULL 00/11] Block patches for 1.0

2011-11-07 Thread Kevin Wolf
Am 07.11.2011 17:55, schrieb Kevin Wolf: > The following changes since commit 932eacc158c064935c7bab920c88a93a629e1ca4: > > Merge branch 'xtensa' of git://jcmvbkbc.spb.ru/dumb/qemu-xtensa (2011-11-02 > 20:52:23 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/kev

Re: [Qemu-devel] Summary of CD, DVD passthrough tests with -drive if=scsi

2011-11-07 Thread Thomas Schmitt
Hi, Paolo Bonzini wrote: > Yes, docs/qdev-device-use.txt helps. "qemu -device virtio-blk,?" too. I read it and ran '-device ?'. But both left me clueless. The text i understood mainly as refering to "old ways" and "new way" of defining devices. I stalled when i found no flesh for "HOST-OPTS" and

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Vince Weaver
On Mon, 7 Nov 2011, Pekka Enberg wrote: > I've never heard ABI incompatibility used as an argument for perf. Ingo? Never overtly. They're too clever for that. In any case, as a primary developer of a library (PAPI) that uses the perf_events ABI I have to say that having perf in the kernel has

[Qemu-devel] [PATCH 04/11] block/cloop: Fix coding style

2011-11-07 Thread Kevin Wolf
From: Dong Xu Wang Fix coding style in block/cloop.c. Reviewed-by: Andreas Färber Reviewed_by: Ray Wang Signed-off-by: Dong Xu Wang Signed-off-by: Kevin Wolf --- block/cloop.c | 115 +++-- 1 files changed, 63 insertions(+), 52 deletions(-

[Qemu-devel] [PATCH 02/11] qemu-io: Fix multiwrite_f error handling

2011-11-07 Thread Kevin Wolf
Without this fix, some qiovs can be leaked if an error occurs. Also a semicolon at the end of the command line would make the code walk beyond the end of argv. Signed-off-by: Kevin Wolf --- qemu-io.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/qemu-io.c b/qem

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 "Upstream qemu-kvm.git sanity 11-01-2011 00:04:02" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Marcelo Tosatti
On Mon, Nov 07, 2011 at 09:00:26AM -0300, Cleber Rosa wrote: > On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: > >On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: > >>On 11/01/2011 12:17 PM, kvm-autotest wrote: > >>>Job ID: 2011 > >>>Job name: Upstream qemu-kvm.git sanity 11

[Qemu-devel] [PATCH 07/11] vvfat: do not fail if the disk has spare sectors

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini If the number of "faked sectors" + the number of sectors that are part of a cluster does not sum up to the total number of sectors, qemu-img convert fails. Read these spare sectors as all zeros. Signed-off-by: Paolo Bonzini Signed-off-by: Kevin Wolf --- block/vvfat.c |

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-07 Thread Alon Levy
On Mon, Nov 07, 2011 at 02:39:29PM -0200, Luiz Capitulino wrote: > On Mon, 07 Nov 2011 10:35:51 -0600 > Anthony Liguori wrote: > > > On 11/07/2011 10:30 AM, Luiz Capitulino wrote: > > > On Mon, 07 Nov 2011 10:09:55 -0600 > > > Anthony Liguori wrote: > > > > > >> On 11/07/2011 10:08 AM, Luiz Capi

Re: [Qemu-devel] Summary of CD, DVD passthrough tests with -drive if=scsi

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 06:02 PM, Thomas Schmitt wrote: But how would i come from there to your proposal ? -device virtio-blk,drive=scsicd,logical_block_size=2048,physical_block_size=2048 First of all, virtio-blk is an alias for virtio-blk-pci. I should not have used it as it's likely confusing, b

[Qemu-devel] [PATCH 09/11] vvfat: unify and correct computation of sector count

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini The sector count is stored in the partition and hence must not include the sectors before its start. At the same time, remove the useless special casing for 1.44 MB floppies. This fixes fsck on VVFAT hard disks, which otherwise tries to seek past the end of the disk. Signed

[Qemu-devel] [PATCH 11/11] vvfat: reorganize computation of disk geometry

2011-11-07 Thread Kevin Wolf
From: Paolo Bonzini First determine FAT12/16/32, then compute geometry from that for both FDD and HDD. For 1.44MB floppies, and 2.88MB floppies using FAT16, change to 1 sector/cluster. The default remains 2.88MB with FAT12 and 2 sectors/cluster. Both DOS and mkdosfs by default format a 2.88MB

Re: [Qemu-devel] [qemu-kvm unittest regression] Re: Autotest | Job ID: 2011 "Upstream qemu-kvm.git sanity 11-01-2011 00:04:02" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Cleber Rosa
On 11/07/2011 02:22 PM, Marcelo Tosatti wrote: On Mon, Nov 07, 2011 at 09:00:26AM -0300, Cleber Rosa wrote: On 11/07/2011 07:21 AM, Marcelo Tosatti wrote: On Tue, Nov 01, 2011 at 02:08:54PM -0200, Lucas Meneghel Rodrigues wrote: On 11/01/2011 12:17 PM, kvm-autotest wrote: Job ID: 2011 Job nam

[Qemu-devel] [PATCH 05/11] block/cloop: Use g_free instead of free

2011-11-07 Thread Kevin Wolf
From: Dong Xu Wang Fix mismatching allocation and deallocation: g_free should be used to pair with g_malloc. Reviewed-by: Andreas Färber Reviewed_by: Ray Wang Signed-off-by: Dong Xu Wang Signed-off-by: Kevin Wolf --- block/cloop.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions

Re: [Qemu-devel] Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/06/2011 02:40 PM, Sasha Levin wrote: Hi all, I'm planning on doing a small fork of the KVM tool to turn it into a 'Secure KVM' enabled hypervisor. Now you probably ask yourself, Huh? The idea was discussed briefly couple of months ago, but never got off the ground - which is a shame IMO.

[Qemu-devel] How to build QEMU from git

2011-11-07 Thread Michael Eager
Hi -- I ran into a problem running the qemu-0.15 and I was told that the problem was fixed in the 1.0 release candidate. I don't find a package with the RC on http://wiki.qemu.org/Download, so I cloned the git repo and tried to build qemu. I didn't find any instructions on how to build qemu on t

[Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Juan Quintela
Hi This patch adds copyrights to all the machine description files for all architectures supported. (this is done on top of my vmstate-cpus series patches) The problem? - What should we put as "copyirght" owners. Althought I modified almost every line of the files, mostly of the changes are a co

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Paolo Bonzini
On 11/07/2011 06:38 PM, Juan Quintela wrote: + * This work is licensed under the terms of the GNU GPL, version 2. See + * the COPYING file in the top-level directory. ... or later please. Paolo

Re: [Qemu-devel] Secure KVM

2011-11-07 Thread Sasha Levin
Hi Anthony, Thank you for your comments! On Mon, 2011-11-07 at 11:37 -0600, Anthony Liguori wrote: > On 11/06/2011 02:40 PM, Sasha Levin wrote: > > Hi all, > > > > I'm planning on doing a small fork of the KVM tool to turn it into a > > 'Secure KVM' enabled hypervisor. Now you probably ask yourse

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ingo Molnar
* Vince Weaver wrote: > On Mon, 7 Nov 2011, Pekka Enberg wrote: > > > I've never heard ABI incompatibility used as an argument for > > perf. Ingo? Correct, the ABI has been designed in a way to make it really hard to break the ABI via either directed backports or other mess-ups. The ABI is

Re: [Qemu-devel] Secure KVM

2011-11-07 Thread Anthony Liguori
On 11/07/2011 11:52 AM, Sasha Levin wrote: Hi Anthony, Thank you for your comments! On Mon, 2011-11-07 at 11:37 -0600, Anthony Liguori wrote: On 11/06/2011 02:40 PM, Sasha Levin wrote: Hi all, I'm planning on doing a small fork of the KVM tool to turn it into a 'Secure KVM' enabled hyperviso

[Qemu-devel] Summary of CD, DVD, BD passthrough tests with -drive if=virtio : Full success

2011-11-07 Thread Thomas Schmitt
Hi, here are test results from the USB attached BD recorder. It is a SATA drive 'Optiarc' 'BD RW BD-5300S' rev '1.04' at a 'JMicron' 'JM20336 SATA, USB Combo' controller. -- qemu start command is the same as with the interna

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Edgar E. Iglesias
On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote: > Hi > > This patch adds copyrights to all the machine description files for > all architectures supported. (this is done on top of my vmstate-cpus > series patches) The problem? > > - What should we put as "copyirght" owners. > > Al

Re: [Qemu-devel] [PATCH] qemu_timedate_diff() shouldn't modify its argument.

2011-11-07 Thread Rik van Riel
On 11/06/2011 11:00 AM, Gleb Natapov wrote: The caller of qemu_timedate_diff() does not expect that tm it passes to the function will be modified, but mktime() is destructive and modifies its argument. Pass a copy of tm to it and set tm_isdst so that mktime() will not rely on it since its value m

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Anthony Liguori
On 11/07/2011 12:39 PM, Edgar E. Iglesias wrote: On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote: static bool feature_vfp_needed(void *opaque) diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-cpu.c index 0f732d3..bbccb8b 100644 --- a/target-cris/vmstate-cpu.c +++ b/ta

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Juan Quintela
Paolo Bonzini wrote: > On 11/07/2011 06:38 PM, Juan Quintela wrote: >> + * This work is licensed under the terms of the GNU GPL, version 2. See >> + * the COPYING file in the top-level directory. > > ... or later please. I thougth I had forgot something to ask O:-) Later, Juan.

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Richard Henderson
On 11/07/2011 09:38 AM, Juan Quintela wrote: > alpha: > CC: Richard Henderson Acked-by: Richard Henderson r~

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Michael Walle
Am Montag 07 November 2011, 18:38:49 schrieb Juan Quintela: > diff --git a/target-lm32/vmstate-cpu.c b/target-lm32/vmstate-cpu.c > index 60b4b29..99ce957 100644 > --- a/target-lm32/vmstate-cpu.c > +++ b/target-lm32/vmstate-cpu.c > @@ -1,3 +1,18 @@ > +/* > + * Migration support for lm32 cpus > + * >

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Pekka Enberg wrote: >> I've never heard ABI incompatibility used as an argument for perf. Ingo? On Mon, Nov 7, 2011 at 7:03 PM, Vince Weaver wrote: > Never overtly.  They're too clever for that. If you want me to take you seriously, spare me from the conspiracy theories, OK?

[Qemu-devel] [PATCH] docs: Add writing-qmp-commands.txt

2011-11-07 Thread Luiz Capitulino
Explains how to write QMP commands using the QAPI. Signed-off-by: Luiz Capitulino --- PS: This addresses all comments against the RFC version, plus some additional changes and the "Returning Lists" chapter PPS: Anthony, I think this could be merged for 1.0 as it's only documentation docs/w

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Frank Ch. Eigler
Ingo Molnar writes: > [...] >> It's problem enough that there's no way to know what version of the >> perf_event abi you are running against and we have to guess based >> on kernel version. This gets "fun" because all of the vendors have >> backported seemingly random chunks of perf_event cod

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
On Mon, 7 Nov 2011, Frank Ch. Eigler wrote: The ABI design allows for that kind of flexible extensibility, and it's one of its major advantages. What we *cannot* protect against is you relying on obscure details of the ABI [...] Is there some documentation that clearly spells out which parts o

Re: [Qemu-devel] [PATCH] qemu_timedate_diff() shouldn't modify its argument.

2011-11-07 Thread Ronen Hod
On 11/06/2011 06:00 PM, Gleb Natapov wrote: The caller of qemu_timedate_diff() does not expect that tm it passes to the function will be modified, but mktime() is destructive and modifies its argument. Pass a copy of tm to it and set tm_isdst so that mktime() will not rely on it since its value m

Re: [Qemu-devel] [RFC] vmstate: Add copyrights for all cpus

2011-11-07 Thread Edgar E. Iglesias
On Mon, Nov 07, 2011 at 01:29:35PM -0600, Anthony Liguori wrote: > On 11/07/2011 12:39 PM, Edgar E. Iglesias wrote: > >On Mon, Nov 07, 2011 at 06:38:49PM +0100, Juan Quintela wrote: > >> static bool feature_vfp_needed(void *opaque) > >>diff --git a/target-cris/vmstate-cpu.c b/target-cris/vmstate-c

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 09:53:28PM +0200, Pekka Enberg wrote: > > I'm sure perf developers break the ABI sometimes - that happens > elsewhere in the kernel as well. However, Ted claimed that perf > developers use tools/perf as an excuse to break the ABI _on purpose_ > which is something I have har

Re: [Qemu-devel] Autotest | Job ID: 2072 "[unittest emulator + kernel git] Upstream qemu-kvm.git sanity 11-07-2011 13:16:33" | Status: 1 Completed | Success Rate: 94.74 %

2011-11-07 Thread Cleber Rosa
4:35:06 INFO | unittest:0052| Running emulator 11/07 14:35:06 DEBUG|virt_env_p:0062| Preprocessing VM 'None' 11/07 14:35:06 INFO |kvm_vm:0790| Running qemu command: /usr/local/autotest/tests/kvm/qemu -name 'None' -nodefaults -vga std -monitor unix:'/tmp/monitor-humanmon

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Ted Ts'o
On Mon, Nov 07, 2011 at 10:09:34PM +0200, Pekka Enberg wrote: > > I guess for perf ABI, "perf test" is the closest thing to a > specification so if your application is using something that's not > covered by it, you might be in trouble. I don't believe there's ever been any guarantee that "perf t

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Pekka Enberg
Hi Ted, On Mon, Nov 7, 2011 at 10:32 PM, Ted Ts'o wrote: > Personally, I consider code that runs in userspace as a pretty bright > line, as being "not kernel code", and while perhaps things like > initramfs and the crazy ideas people have had in the past of moving > stuff out of kernel/init.c int

[Qemu-devel] [ANNOUNCE] QEMU 1.0-rc1

2011-11-07 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0, release candidate 1. This is the first release candidate for the 1.0 release. This is not intended for production use but rather for testing. To participate in the testing effort, please read the Testing Wiki[

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Anthony Liguori
On 11/07/2011 03:36 PM, Pekka Enberg wrote: Hi Ted, On Mon, Nov 7, 2011 at 10:32 PM, Ted Ts'o wrote: Personally, I consider code that runs in userspace as a pretty bright line, as being "not kernel code", and while perhaps things like initramfs and the crazy ideas people have had in the past o

Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations

2011-11-07 Thread Avi Kivity
On 11/06/2011 07:25 PM, Paolo Bonzini wrote: > > Perhaps the failure is only reproduced 80-90% of the time and this > screws up the bisection. Correct, bad bisect. It actually reproduces reliably, when the bisecter is reliable. The new candidate (disclaimer: unreliable bisecter) is: commit a5c5

[Qemu-devel] clk_setup decl missing in virtex_init

2011-11-07 Thread Michael Eager
The declaration of clk_setup is missing in qemu/hw/virtex_ml507.c: static void virtex_init(ram_addr_t ram_size, const char *boot_device, const char *kernel_filename, const char *kernel_cmdline, const c

Re: [Qemu-devel] [PATCH v7 2/2] pc: Support system flash memory with pflash

2011-11-07 Thread Jordan Justen
On Wed, Nov 2, 2011 at 21:19, Jordan Justen wrote: > If a pflash image is found, then it is used for the system > firmware image. > > If a pflash image is not initially found, then a read-only > pflash device is created using the -bios filename. > > KVM cannot execute from a pflash region currentl

Re: [Qemu-devel] clk_setup decl missing in virtex_init

2011-11-07 Thread Edgar E. Iglesias
On Mon, Nov 07, 2011 at 02:46:47PM -0800, Michael Eager wrote: > The declaration of clk_setup is missing in > qemu/hw/virtex_ml507.c: > > static void virtex_init(ram_addr_t ram_size, > const char *boot_device, > const char *kernel_filename, >

Re: [Qemu-devel] [PATCH v2 4/7] block: take lock around bdrv_read implementations

2011-11-07 Thread Avi Kivity
On 11/08/2011 12:26 AM, Avi Kivity wrote: > On 11/06/2011 07:25 PM, Paolo Bonzini wrote: > > > > Perhaps the failure is only reproduced 80-90% of the time and this > > screws up the bisection. > > Correct, bad bisect. It actually reproduces reliably, when the bisecter > is reliable. > > The new ca

Re: [Qemu-devel] clk_setup decl missing in virtex_init

2011-11-07 Thread Michael Eager
Works for me. On 11/07/2011 03:05 PM, Edgar E. Iglesias wrote: On Mon, Nov 07, 2011 at 02:46:47PM -0800, Michael Eager wrote: The declaration of clk_setup is missing in qemu/hw/virtex_ml507.c: static void virtex_init(ram_addr_t ram_size, const char *boot_device,

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Theodore Tso
On Nov 7, 2011, at 5:19 PM, Anthony Liguori wrote: > > The kernel ecosystem does not have to be limited to linux.git. There could > be a process to be a "kernel.org project" for projects that fit a certain set > of criteria. These projects could all share the Linux kernel release cadence >

[Qemu-devel] Patch: fix typo: runnning -> running

2011-11-07 Thread Vagrant Cascadian
One n too many for running, need we say more. Signed-Off-By: Vagrant Cascadian Index: qemu/target-i386/kvm.c === --- qemu.orig/target-i386/kvm.c 2011-07-02 21:25:10.0 -0700 +++ qemu/target-i386/kvm.c 2011-07-02 21:25:20

Re: [Qemu-devel] [PATCH V3] Introduce a new bus "ICC" to connect APIC

2011-11-07 Thread liu ping fan
On Sun, Nov 06, 2011 at 07:06:29PM +0100, Jan Kiszka wrote: > On 2011-11-03 10:30, pingf...@linux.vnet.ibm.com wrote: > > From: Liu Ping Fan > > > > Introduce a new structure CPUS as the controller of ICC (INTERRUPT > > CONTROLLER COMMUNICATIONS), and new bus "ICC" to hold APIC,instead > > of sys

Re: [Qemu-devel] Patch: fix typo: runnning -> running

2011-11-07 Thread 陳韋任
Better cc to qemu-triv...@nongnu.org On Mon, Nov 07, 2011 at 03:58:23PM -0800, Vagrant Cascadian wrote: > One n too many for running, need we say more. > > Signed-Off-By: Vagrant Cascadian > > Index: qemu/target-i386/kvm.c > ===

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-07 Thread Peter Maydell
2011/10/26 Peter Maydell : > On 25 October 2011 12:09, Benoît Canet wrote: >> +static const VMStateDescription vmstate_integratorcm = { >> +    .name = "integratorcm", >> +    .version_id = 1, >> +    .minimum_version_id = 1, >> +    .minimum_version_id_old = 1, >> +    .fields = (VMStateField[])

Re: [Qemu-devel] [PATCH v12 5/5] block: perf testing report based on block I/O throttling

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 11:27 PM, Kevin Wolf wrote: > Am 03.11.2011 09:57, schrieb Zhi Yong Wu: >> The file 1mbps.dat is based on bps=1024*1024 I/O throttling; and the file >> 10mbps.dat is based on bps=10*1024*1024 I/O throttling. >> >> Signed-off-by: Zhi Yong Wu >> --- >>  10mbps.dat |  310 +++

Re: [Qemu-devel] [PATCH v12 4/5] hmp/qmp: add block_set_io_throttle

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 11:26 PM, Kevin Wolf wrote: > Am 03.11.2011 09:57, schrieb Zhi Yong Wu: >> Signed-off-by: Zhi Yong Wu >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c          |   15 + >>  blockdev.c       |   59 >> ++ >

Re: [Qemu-devel] How to build QEMU from git

2011-11-07 Thread 陳韋任
> I ran into a problem running the qemu-0.15 and I was told > that the problem was fixed in the 1.0 release candidate. > I don't find a package with the RC on http://wiki.qemu.org/Download, There is a qemu-1.0-rc1 on the page now. :) Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab,

Re: [Qemu-devel] How to build QEMU from git

2011-11-07 Thread Dong Xu Wang
2011/11/8 Michael Eager : > Hi -- > > I ran into a problem running the qemu-0.15 and I was told > that the problem was fixed in the 1.0 release candidate. > I don't find a package with the RC on http://wiki.qemu.org/Download, > so I cloned the git repo and tried to build qemu. > > I didn't find any

Re: [Qemu-devel] [PATCH v12 3/5] block: add I/O throttling algorithm

2011-11-07 Thread Zhi Yong Wu
On Mon, Nov 7, 2011 at 11:18 PM, Kevin Wolf wrote: > Am 03.11.2011 09:57, schrieb Zhi Yong Wu: >> Signed-off-by: Zhi Yong Wu >> Signed-off-by: Stefan Hajnoczi >> --- >>  block.c     |  220 >> +++ >>  block.h     |    1 + >>  block_int.h |

[Qemu-devel] [PATCH v12 3/5] block: add I/O throttling algorithm

2011-11-07 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- block.c | 234 +++ block.h |1 + block_int.h |1 + 3 files changed, 236 insertions(+), 0 deletions(-) diff --git a/block.c b/block.c index 79e7f09..3d0ec23 1006

[Qemu-devel] [PATCH v12 4/5] hmp/qmp: add block_set_io_throttle

2011-11-07 Thread Zhi Yong Wu
Signed-off-by: Zhi Yong Wu Signed-off-by: Stefan Hajnoczi --- block.c | 15 + blockdev.c | 59 ++ blockdev.h |2 + hmp-commands.hx | 15 + hmp.c| 10 + qapi-schema.js

Re: [Qemu-devel] Accessing a linux guest's data structures

2011-11-07 Thread 陳韋任
> > Hi > > I am a beginner qemu developer. > > I am running a linux guest inside qemu and I need to determine what process, > > thread is currently running in the guest. > > How should I do this? Any suggestions? Or can anyone point me to the > > relevant areas in qemu's source. ^^^

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-07 Thread Vince Weaver
On Mon, 7 Nov 2011, Ingo Molnar wrote: > I think we needed to do only one revert along the way in the past two > years, to fix an unintended ABI breakage in PowerTop. Considering the > total complexity of the perf ABI our compatibility track record is > *very* good. There have been more breakag

[Qemu-devel] [PATCH] pseries: Correct RAM size check for SLOF

2011-11-07 Thread David Gibson
The SLOF firmware used on the pseries machine needs a reasonable amount of (guest) RAM in order to run, so we have a check in the machine init function to check that this is available. However, SLOF runs in real mode (MMU off) which means it can only actually access the RMA (Real Mode Area), not a

[Qemu-devel] [PATCH] 9pfs: Stat response from server offset by 2 bytes

2011-11-07 Thread David Gibson
From: Timothy Rule The 9P spec states that for the stat message the "stat[n]" structure shall be encoded at offset 7 in the 9P message (see §13.9 message Rstat). The existing code is encoding a 2 byte value (hard coded 0 value) at offset 7 of the 9P message, and then follows with the "stat[n]" s

<    1   2   3   >