Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Gerd Hoffmann
On 11/07/11 17:00, Anthony Liguori wrote: On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Mark Wu
When I run this tool, I got two python exceptions. It turned out that both of them were caused by wrong usage. Do you think we need add validation for input to handle these cases? Thanks. 1. Not using '=' for path: $ ./QMP/qmp --path monitor-address Traceback (most recent call last): File

Re: [Qemu-devel] [PATCH v12 3/5] block: add I/O throttling algorithm

2011-11-08 Thread Kevin Wolf
Am 08.11.2011 05:34, schrieb Zhi Yong Wu: On Mon, Nov 7, 2011 at 11:18 PM, Kevin Wolf kw...@redhat.com wrote: Am 03.11.2011 09:57, schrieb Zhi Yong Wu: Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 220

Re: [Qemu-devel] [PATCH v12 3/5] block: add I/O throttling algorithm

2011-11-08 Thread Zhi Yong Wu
On Tue, Nov 8, 2011 at 4:41 PM, Kevin Wolf kw...@redhat.com wrote: Am 08.11.2011 05:34, schrieb Zhi Yong Wu: On Mon, Nov 7, 2011 at 11:18 PM, Kevin Wolf kw...@redhat.com wrote: Am 03.11.2011 09:57, schrieb Zhi Yong Wu: Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan

Re: [Qemu-devel] [PATCH v2 0/2] nand/onenand: reject read-only drives

2011-11-08 Thread Markus Armbruster
[Adding a few cc's, hope it helps] juha.riihim...@nokia.com writes: From: Juha Riihimäki juha.riihim...@nokia.com Make NAND and OneNAND device models reject read-only drives. Test for example by running $ qemu-system-arm -drive if=none,file=/dev/zero,readonly,id=foo -device

[Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Ingo Molnar
* Theodore Tso ty...@mit.edu wrote: On Nov 7, 2011, at 5:19 PM, Anthony Liguori wrote: The kernel ecosystem does not have to be limited to linux.git. There could be a process to be a kernel.org project for projects that fit a certain set of criteria. These projects could all

Re: [Qemu-devel] [PATCH v3] block: Use bdrv functions to replace file operation in cow.c

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 08, 2011 at 02:21:13PM +0800, Li Zhi Hui wrote: Since common file operation functions lack of error detection, so change them to bdrv series functions. v3: correct some errors v2: Only contains the function modified. v1: Fix coding style and convert file operation functions to

Re: [Qemu-devel] [RFC 4/6] block: request overlap detection

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 08, 2011 at 02:34:22PM +0800, Zhi Yong Wu wrote: On Mon, Nov 7, 2011 at 10:37 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Nov 7, 2011 at 11:49 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote: On Mon, Oct 17, 2011 at 11:47 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com

Re: [Qemu-devel] Accessing a linux guest's data structures

2011-11-08 Thread Andreas Färber
Am 08.11.2011 06:27, schrieb 陳韋任: I am running a linux guest inside qemu and I need to determine what process, thread is currently running in the guest. How should I do this? Any suggestions? Or can anyone point me to the relevant areas in qemu's source. ^^^

Re: [Qemu-devel] Accessing a linux guest's data structures

2011-11-08 Thread Vasiliy Tolstov
2011/11/8 Andreas Färber afaer...@suse.de: Am 08.11.2011 06:27, schrieb 陳韋任: I am running a linux guest inside qemu and I need to determine what process, thread is currently running in the guest. How should I do this? Any suggestions? Or can anyone point me to the relevant areas in qemu's

Re: [Qemu-devel] [RFC 4/6] block: request overlap detection

2011-11-08 Thread Zhi Yong Wu
On Tue, Nov 8, 2011 at 4:16 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Tue, Nov 08, 2011 at 02:34:22PM +0800, Zhi Yong Wu wrote: On Mon, Nov 7, 2011 at 10:37 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Nov 7, 2011 at 11:49 AM, Zhi Yong Wu zwu.ker...@gmail.com wrote:

[Qemu-devel] [PATCH] vvfat: Fix read-write mode

2011-11-08 Thread Kevin Wolf
vvfat used to directly call into the qcow2 block driver instead of using the block.c wrappers. With the coroutine conversion, this stopped working. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/vvfat.c | 44 +++- 1 files changed, 23 insertions(+),

[Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c

Re: [Qemu-devel] [PATCH v3] block: Use bdrv functions to replace file operation in cow.c

2011-11-08 Thread Kevin Wolf
Am 08.11.2011 07:21, schrieb Li Zhi Hui: Since common file operation functions lack of error detection, so change them to bdrv series functions. v3: correct some errors v2: Only contains the function modified. v1: Fix coding style and convert file operation functions to bdrv functions.

[Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c

[Qemu-devel] [PATCH] Clean up assertion in get_boot_devices_list()

2011-11-08 Thread Markus Armbruster
g_strdup() can't fail, remove assertion. Assert its argument can't be null, because that's not obvious (add_boot_device_path() ensures it). Signed-off-by: Markus Armbruster arm...@redhat.com --- vl.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/vl.c b/vl.c index

Re: [Qemu-devel] [PATCH] vvfat: Fix read-write mode

2011-11-08 Thread Paolo Bonzini
On 11/08/2011 10:55 AM, Kevin Wolf wrote: vvfat used to directly call into the qcow2 block driver instead of using the block.c wrappers. With the coroutine conversion, this stopped working. Signed-off-by: Kevin Wolfkw...@redhat.com --- block/vvfat.c | 44

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Butterfingers, apologies please ignore.

[Qemu-devel] [PATCH] qdev: Fix crash on -device '?=x'

2011-11-08 Thread Markus Armbruster
Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 50976dd..106407f 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -186,7 +186,7 @@ int qdev_device_help(QemuOpts

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Avi Kivity
On 11/08/2011 10:08 AM, Gerd Hoffmann wrote: On 11/07/11 17:00, Anthony Liguori wrote: On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't

[Qemu-devel] [TestDay] s390x build broken

2011-11-08 Thread Andreas Färber
Hi everyone, Got this with v1.0-rc1 tarball: CCi386-softmmu/tcg/tcg.o In file included from /suse/afaerber/QEMU/qemu-1.0rc1/tcg/tcg.c:176: /suse/afaerber/QEMU/qemu-1.0rc1/tcg/s390/tcg-target.c:677: error: conflicting types for ‘tcg_out_mov’ /suse/afaerber/QEMU/qemu-1.0rc1/tcg/tcg.c:76:

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Daniel P. Berrange
On Tue, Nov 08, 2011 at 10:55:52AM +0100, Markus Armbruster wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c | 10 +- 1 files changed, 5

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Benoît Canet
flash_mapped reflect the bit 2 of a control register. Peter, does this patch look better ? commit 2fa7b11ee2b2532d00056d6bbc928c5162925e1d Author: Benoît Canet benoit.ca...@gmail.com Date: Mon Oct 24 14:39:26 2011 +0200 integratorcp: convert integratorcm to VMState Signed-off-by:

Re: [Qemu-devel] [PATCH v12 4/5] hmp/qmp: add block_set_io_throttle

2011-11-08 Thread Kevin Wolf
Am 08.11.2011 06:00, schrieb Zhi Yong Wu: Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- block.c | 15 + blockdev.c | 59 ++ blockdev.h

Re: [Qemu-devel] [Qemu-ppc] [PATCH] pseries: Correct RAM size check for SLOF

2011-11-08 Thread Thomas Huth
Am Tue, 8 Nov 2011 16:52:16 +1100 schrieb David Gibson da...@gibson.dropbear.id.au: The SLOF firmware used on the pseries machine needs a reasonable amount of (guest) RAM in order to run, so we have a check in the machine init function to check that this is available. However, SLOF runs in

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Gerd Hoffmann
Hi, Wouldn't it be better to have the subsystem vendor and device id be configurable, set the default to the qemu subsystem ids, and then set it to 8086: for 1.0? I don't want this being fully configurable just for the snake of backward compatibility with old qemu versions. I

Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Theodore Tso
On Nov 8, 2011, at 4:32 AM, Ingo Molnar wrote: No ifs and when about it, these are the plain facts: - Better features, better ABIs: perf maintainers can enforce clean, functional and usable tooling support *before* committing to an ABI on the kernel side. We don't have to be

Re: [Qemu-devel] Accessing a linux guest's data structures

2011-11-08 Thread Ankur Dahiya
Thanks for the suggestions, guys! I will take a look at libvmi. As an aside, can someone tell me where in the qemu source can I inspect each guest instruction? I want all guest instructions to first go through my code. Ankur Dahiya On Tue, Nov 8, 2011 at 3:18 PM, Vasiliy Tolstov

[Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Ingo Molnar
* Ted Ts'o ty...@mit.edu wrote: I don't believe there's ever been any guarantee that perf test from version N of the kernel will always work on a version N+M of the kernel. Perhaps I am wrong, though. If that is a guarantee that the perf developers are willing to stand behind, or have

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Peter Zijlstra
On Tue, 2011-11-08 at 11:22 +0100, Ingo Molnar wrote: We do even more than that, the perf ABI is fully backwards *and* forwards compatible: you can run older perf on newer ABIs and newer perf on older ABIs. The ABI yes, the tool no, the tool very much relies on some newer ABI parts.

[Qemu-devel] pseries segfault

2011-11-08 Thread Gerd Hoffmann
Hi, qemu-system-ppc64 segfaults with todays git master: $ qemu-img create -f qcow2 empty.img 1G Formatting 'empty.img', fmt=qcow2 size=1073741824 encryption=off cluster_size=65536 $ /home/kraxel/projects/qemu/build-default/ppc64-softmmu/qemu-system-ppc64 -M pseries -m 1024 -nodefaults -serial

[Qemu-devel] [TestDay] ppc64 pseries segfault

2011-11-08 Thread Andreas Färber
Hello, On openSUSE 12.1 RC2 x86_64 host $ ppc64-softmmu/qemu-system-ppc64 -M pseries -L .../pc-bios segfaults. Backtrace: Program received signal SIGSEGV, Segmentation fault. 0x00578a7e in spapr_create_phb (spapr=0x1247f80, busname= 0x77f1b2 pci, buid=optimized out,

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Theodore Tso
On Nov 8, 2011, at 5:22 AM, Ingo Molnar wrote: We do even more than that, the perf ABI is fully backwards *and* forwards compatible: you can run older perf on newer ABIs and newer perf on older ABIs. It's great to hear that! But in that case, there's an experiment we can't really run,

Re: [Qemu-devel] [PATCH 1/3] sonic: fix typo

2011-11-08 Thread Stefan Hajnoczi
On Sun, Nov 06, 2011 at 10:48:50PM +0100, Hervé Poussineau wrote: Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/dp8393x.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: Fix CP15 FSR (C5) domain setting

2011-11-08 Thread Stefan Hajnoczi
On Fri, Nov 04, 2011 at 09:50:25PM +0100, Jean-Christophe DUBOIS wrote: During Xvisor development, it was noted that qemu did not return the correct domain value in the Cp15 [Data] FSR register (C5). This patch is a proposal to fix it. Signed-off-by: Jean-Christophe DUBOIS

Re: [Qemu-devel] [Qemu-trivial][PATCH] linux-user/main.c: Add option to user-mode emulation so that user can specify log file name

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 08, 2011 at 05:46:44PM +0800, 陳韋任 wrote: QEMU linux user-mode's default log file name is /tmp/qemu.log. In order to change the log file name, user need to modify the source code then recompile QEMU. This patch allow user use -D logfile option to specify the log file name.

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Daniel P. Berrange berra...@redhat.com writes: On Tue, Nov 08, 2011 at 10:55:52AM +0100, Markus Armbruster wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c |

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 08, 2011 at 10:55:52AM +0100, Markus Armbruster wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c | 10 +- 1 files changed, 5

Re: [Qemu-devel] [PATCH] qdev: Fix crash on -device '?=x'

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 08, 2011 at 11:00:38AM +0100, Markus Armbruster wrote: Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/qdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree:

Re: [Qemu-devel] [PATCH] Support for UDP unicast network backend

2011-11-08 Thread Jan Kiszka
On 2011-11-07 23:03, Benjamin wrote: On 11/07/11 12:23, Jan Kiszka wrote: On 2011-11-07 15:01, Benjamin wrote: Here is the updated patch, using only localaddr. mcast expects it to be addr whereas udp expects addr:port. It's documented in the help output. I also corrected the error message

Re: [Qemu-devel] [PATCH V3] Introduce a new bus ICC to connect APIC

2011-11-08 Thread Jan Kiszka
On 2011-11-08 02:44, liu ping fan wrote: On Sun, Nov 06, 2011 at 07:06:29PM +0100, Jan Kiszka wrote: On 2011-11-03 10:30, pingf...@linux.vnet.ibm.com wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Introduce a new structure CPUS as the controller of ICC (INTERRUPT CONTROLLER

Re: [Qemu-devel] Accessing a linux guest's data structures

2011-11-08 Thread 陳韋任
Thanks for the suggestions, guys! I will take a look at libvmi. As an aside, can someone tell me where in the qemu source can I inspect each guest instruction? I want all guest instructions to first go through my code. For i386 guest, see disas_insn (target-i386/translate.c). It

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Pekka Enberg
On Tue, 8 Nov 2011, Theodore Tso wrote: It's great to hear that! But in that case, there's an experiment we can't really run, which is if perf had been developed in a separate tree, would it have been just as successful? Experiment, eh? We have the staging tree because it's a widely

[Qemu-devel] [Bug 887516] [NEW] VFP support reported for the PXA270

2011-11-08 Thread Mircea Gherzan
Public bug reported: The HWCAPS seems to be broken on PXA, because sigsetjmp of eglibc-2.14 chooses a VFP code path after the hwcaps test [1][2] which causes a SIGILL on a VSTM instruction. How to reproduce: 1. build an arm-linux-gnueabi toolchain with eglibc-2.14 2. compile a trivial main() 3.

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Theodore Tso
On Nov 8, 2011, at 6:20 AM, Pekka Enberg wrote: We have the staging tree because it's a widely acknowledged belief that kernel code in the tree tends to improve over time compared to code that's sitting out of the tree. Are you disputing that belief? Kernel code in the kernel source tree

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Pekka Enberg
On Tue, 8 Nov 2011, Theodore Tso wrote: We have the staging tree because it's a widely acknowledged belief that kernel code in the tree tends to improve over time compared to code that's sitting out of the tree. Are you disputing that belief? Kernel code in the kernel source tree improves;

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Frank Ch. Eigler
Hi - On Tue, Nov 08, 2011 at 11:22:35AM +0100, Ingo Molnar wrote: [...] These examples show *PICTURE PERFECT* forwards ABI compatibility, using the ancient perf tool on a bleeding edge kernel. [...] Almost: they demonstrate that those parts of the ABI that these particular perf commands

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Ingo Molnar
* Peter Zijlstra a.p.zijls...@chello.nl wrote: The ABI yes, the tool no, the tool very much relies on some newer ABI parts. Supporting fallbacks isn't always possible/wanted. Yeah, sure - and an older tool cannot possibly support newer features either. Thanks, Ingo

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Pekka Enberg
On Tue, 8 Nov 2011, Frank Ch. Eigler wrote: Almost: they demonstrate that those parts of the ABI that these particular perf commands rely on have been impressively compatible. Do you have any sort of ABI coverage measurement, to see what parts of the ABI these perf commands do not use? It's

[Qemu-devel] multiprocessor on kvm

2011-11-08 Thread Xin Tong
I am wondering that when one uses qemu with kvm. How many cores are exposed and available to the guest os ( assuming the host has 4 cores ). is this configurable ? Thanks Xin

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Luiz Capitulino
On Tue, 08 Nov 2011 16:36:55 +0800 Mark Wu wu...@linux.vnet.ibm.com wrote: When I run this tool, I got two python exceptions. It turned out that both of them were caused by wrong usage. Do you think we need add validation for input to handle these cases? Yes. Thanks. 1. Not using

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread 陳韋任
I am wondering that when one uses qemu with kvm. How many cores are exposed and available to the guest os ( assuming the host has 4 cores ). is this configurable ? QEMU provides -smp option, but those virtual cpus are scheduled in round-robin fashion. In other words, it's not real

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-08 Thread Ingo Molnar
* Vince Weaver vi...@deater.net wrote: On Mon, 7 Nov 2011, Ingo Molnar wrote: I think we needed to do only one revert along the way in the past two years, to fix an unintended ABI breakage in PowerTop. Considering the total complexity of the perf ABI our compatibility track record

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread 陳韋任
On Tue, Nov 08, 2011 at 08:04:44PM +0800, 陳韋任 wrote: I am wondering that when one uses qemu with kvm. How many cores are exposed and available to the guest os ( assuming the host has 4 cores ). is this configurable ? QEMU provides -smp option, but those virtual cpus are scheduled in

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Peter Maydell
On 8 November 2011 06:33, Avi Kivity a...@redhat.com wrote: On 11/08/2011 04:07 AM, Peter Maydell wrote: 2011/10/26 Peter Maydell peter.mayd...@linaro.org: On 25 October 2011 12:09, Benoît Canet benoit.ca...@gmail.com wrote: +static const VMStateDescription vmstate_integratorcm = { +    

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Peter Maydell
2011/11/8 Benoît Canet benoit.ca...@gmail.com: flash_mapped reflect the bit 2 of a control register. Peter, does this patch look better ? See my reply to Avi; I'd rather we fixed the MemoryRegion API rather than working around it in devices with postload hooks. thanks -- PMM

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Ingo Molnar
* Pekka Enberg penb...@cs.helsinki.fi wrote: [...] There's an easy fix for this too: improve perf test to cover the cases you're intested in. While ABI spec would be a nice addition, it's not going to make compatibility problems magically go away. Yes, exactly - 'perf test' has been

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm: Fix CP15 FSR (C5) domain setting

2011-11-08 Thread Peter Maydell
On 8 November 2011 10:44, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Nov 04, 2011 at 09:50:25PM +0100, Jean-Christophe DUBOIS wrote: During Xvisor development, it was noted that qemu did not return the correct domain value in the Cp15 [Data] FSR register (C5). This patch is a proposal

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Peter Zijlstra
On Tue, 2011-11-08 at 13:15 +0100, Ingo Molnar wrote: The one notable thing that isnt being tested in a natural way is the 'group of events' abstraction - which, ironically, has been added on the perfmon guys' insistence. No app beyond the PAPI self-test makes actual use of it though,

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Avi Kivity
On 11/08/2011 02:15 PM, Peter Maydell wrote: Avi, ping? I'm still interested in the answer to this question. Sorry, missed this. Yes, you need to ensure the memory region mapping reflects flash_mapped. This needs to be in the MemoryRegion core implementation, please. Right; see the

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 8, 2011 at 12:10 PM, 陳韋任 che...@iis.sinica.edu.tw wrote: On Tue, Nov 08, 2011 at 08:04:44PM +0800, 陳韋任 wrote: I am wondering that when one uses qemu with kvm. How many cores are exposed and available to the guest os ( assuming the host has 4 cores ). is this configurable ?

Re: [Qemu-devel] [PATCH] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 8, 2011 at 10:49 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Nov 08, 2011 at 10:55:52AM +0100, Markus Armbruster wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails.  Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Peter Maydell
On 8 November 2011 12:21, Avi Kivity a...@redhat.com wrote: On 11/08/2011 02:15 PM, Peter Maydell wrote: This needs to be in the MemoryRegion core implementation, please. Right; see the memory/mutators branch.  I plan to push this as soon as everything is converted. OK, then this

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread Xin Tong
so qemu exposes multiple processors to the guest os by having multiple vCPUs. and it realizes the multiple vCPUs by either using RR on a single host cpu (qemu ) or using multiple host cpus (kvm). Thanks Xin 2011/11/8 Stefan Hajnoczi stefa...@gmail.com: On Tue, Nov 8, 2011 at 12:10 PM, 陳韋任

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Avi Kivity
On 11/08/2011 02:30 PM, Peter Maydell wrote: On 8 November 2011 12:21, Avi Kivity a...@redhat.com wrote: On 11/08/2011 02:15 PM, Peter Maydell wrote: This needs to be in the MemoryRegion core implementation, please. Right; see the memory/mutators branch. I plan to push this as soon as

[Qemu-devel] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. --- ui/vnc-auth-sasl.c | 19 +-- 1 files changed, 5 insertions(+), 14 deletions(-) diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c index 23b1bf5..e2045fc 100644 ---

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Peter Maydell
On 8 November 2011 12:38, Avi Kivity a...@redhat.com wrote: On 11/08/2011 02:30 PM, Peter Maydell wrote: On 8 November 2011 12:21, Avi Kivity a...@redhat.com wrote: On 11/08/2011 02:15 PM, Peter Maydell wrote: This needs to be in the MemoryRegion core implementation, please. Right; see

Re: [Qemu-devel] [PATCH V3 07/10] Introduce Xen PCI Passthrough, qdevice (1/3)

2011-11-08 Thread Stefano Stabellini
On Fri, 28 Oct 2011, Anthony PERARD wrote: From: Allen Kay allen.m@intel.com Signed-off-by: Allen Kay allen.m@intel.com Signed-off-by: Guy Zana g...@neocleus.com Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- Makefile.target |2 +

Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 05:21:50AM -0500, Theodore Tso escreveu: On Nov 8, 2011, at 4:32 AM, Ingo Molnar wrote: No ifs and when about it, these are the plain facts: - Better features, better ABIs: perf maintainers can enforce clean, functional and usable tooling support *before*

Re: [Qemu-devel] [PATCH V3 09/10] Introduce apic-msidef.h

2011-11-08 Thread Stefano Stabellini
On Fri, 28 Oct 2011, Anthony PERARD wrote: This patch move the msi definition from apic.c to apic-msidef.h. So it can be used also by other .c files. you should CC Michael on this one Signed-off-by: Anthony PERARD anthony.per...@citrix.com --- hw/apic-msidef.h | 28

Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Ingo Molnar
* Theodore Tso ty...@mit.edu wrote: On Nov 8, 2011, at 4:32 AM, Ingo Molnar wrote: No ifs and when about it, these are the plain facts: - Better features, better ABIs: perf maintainers can enforce clean, functional and usable tooling support *before* committing to an ABI

[Qemu-devel] [PATCH 0/6] Remove libqemu related stuff from QEMU source tree

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw According to [1], libqemu is not available anymore. Remove libqemu related stuff from QEMU source tree. [1] http://www.mail-archive.com/qemu-devel@nongnu.org/msg49809.html Chen Wen-Ren (6): tests/qruncom.c: Remove libqemu.a example

Re: [Qemu-devel] [F.A.Q.] perf ABI backwards and forwards compatibility

2011-11-08 Thread Ingo Molnar
* Peter Zijlstra a.p.zijls...@chello.nl wrote: On Tue, 2011-11-08 at 13:15 +0100, Ingo Molnar wrote: The one notable thing that isnt being tested in a natural way is the 'group of events' abstraction - which, ironically, has been added on the perfmon guys' insistence. No app beyond

[Qemu-devel] [PATCH 1/6] tests/qruncom.c: Remove libqemu.a example

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw Remove libqemu example since libqemu.a is not available anymore. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- tests/qruncom.c | 284 --- 1 files changed, 0 insertions(+), 284

[Qemu-devel] [PATCH 2/6] tests/Makefile: Remove qruncom target

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw Remove qruncom target from the Makefile file since we have removed libqemu example (qruncom.c). Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- tests/Makefile |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git

[Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Jason Wessel
The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd %xmm1,%xmm0 When xmm1 = 24 and xmm0 = -100 This was found running the glib2

[Qemu-devel] [PATCH 3/6] qemu-tech.texi: Remove libqemu related stuff from the document

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw Remove libqemu related stuff from the document since libqemu.a is not supported anymore. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- qemu-tech.texi |9 - 1 files changed, 0 insertions(+), 9 deletions(-) diff --git

[Qemu-devel] [PATCH 4/6] Makefile.target: Remove libqemu target

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw Remove libqemu target from Makefile.target. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- Makefile.target |8 1 files changed, 0 insertions(+), 8 deletions(-) diff --git a/Makefile.target b/Makefile.target index

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread 陳韋任
so qemu exposes multiple processors to the guest os by having multiple vCPUs. and it realizes the multiple vCPUs by either using RR on a single host cpu (qemu ) or using multiple host cpus (kvm). yes. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-08 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 08, 2011 at 01:07:55PM +0100, Ingo Molnar escreveu: * Vince Weaver vi...@deater.net wrote: as mentioned before I have my own perf_event test suite with 20+ tests. http://web.eecs.utk.edu/~vweaver1/projects/perf-events/validation.html That should probably be moved into perf

[Qemu-devel] [PATCH 5/6] Makefile.objs: Remove libqemu_common.a target

2011-11-08 Thread 陳韋任
From: Chen Wen-Ren che...@iis.sinica.edu.tw Remove libqemu_common.a target from Makefile.objs. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- Makefile.objs | 104 - 1 files changed, 0 insertions(+), 104 deletions(-) diff

[Qemu-devel] [PATCH 6/6] LICENSE: There is no libqemu.a anymore

2011-11-08 Thread 陳韋任
From: Chen Wei-Ren che...@iis.sinica.edu.tw Remove statement about libqemu.a from LICENSE. Signed-off-by: Chen Wei-Ren che...@iis.sinica.edu.tw --- LICENSE |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/LICENSE b/LICENSE index cbd92c0..acae9a3 100644 --- a/LICENSE

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Stefan Hajnoczi
On Tue, Nov 8, 2011 at 12:45 PM, Markus Armbruster arm...@redhat.com wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails.  Spotted by Coverity. ---  ui/vnc-auth-sasl.c |   19 +--  1 files changed, 5 insertions(+), 14 deletions(-) Looks good,

Re: [Qemu-devel] [PATCH 6/8 v2] block: add eject request callback

2011-11-08 Thread Kevin Wolf
Am 07.11.2011 17:50, schrieb Paolo Bonzini: Recent versions of udev always keep the tray locked so that the kernel can observe eject request events (aka tray button presses) even on discs that aren't mounted. Add support for these events in the ATAPI and SCSI cd drive device models. To let

Re: [Qemu-devel] [PATCH] KVM: Add wrapper script around QEMU to test kernels

2011-11-08 Thread Karel Zak
On Mon, Nov 07, 2011 at 03:12:28PM +0200, Pekka Enberg wrote: On Mon, Nov 7, 2011 at 2:47 PM, Ted Ts'o ty...@mit.edu wrote: I don't think perf should be used as a precendent that now argues that any new kernel utility should be moved into the kernel sources.  Does it make sense to move all

Re: [Qemu-devel] [F.A.Q.] the advantages of a shared tool/kernel Git repository, tools/perf/ and tools/kvm/

2011-11-08 Thread Gerd Hoffmann
Hi, Indeed, documentation is lacking, I think coming from a kernel standpoint I relied too much in the documentation is source code mantra of old days. Sorry for the shameless plug, but as you are speaking of lacking documentation: Where the heck is the perf config file documented, other

Re: [Qemu-devel] [PATCH] 9pfs: Stat response from server offset by 2 bytes

2011-11-08 Thread Aneesh Kumar K.V
On Tue, 8 Nov 2011 16:55:17 +1100, David Gibson da...@gibson.dropbear.id.au wrote: From: Timothy Rule tr...@linux.vnet.ibm.com The 9P spec states that for the stat message the stat[n] structure shall be encoded at offset 7 in the 9P message (see §13.9 message Rstat). The existing code is

[Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled

2011-11-08 Thread Max Filippov
Hi. I'm trying to run stock Debian 6.0 x86_64 kernel using qemu git head. With the following command line it's ok (getting to rootfs mounting and panics): qemu-system-x86_64 -serial stdio -monitor null -nographic -kernel /boot/vmlinuz-2.6.38-bpo.2-amd64 -append 'console=ttyS0 panic=1' But once

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Laurent Desnogues
On Tue, Nov 8, 2011 at 2:00 PM, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers.  This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd  

Re: [Qemu-devel] [PATCH 4/5] integratorcp: convert integratorcm to VMState

2011-11-08 Thread Anthony Liguori
On 11/08/2011 06:38 AM, Avi Kivity wrote: On 11/08/2011 02:30 PM, Peter Maydell wrote: On 8 November 2011 12:21, Avi Kivitya...@redhat.com wrote: On 11/08/2011 02:15 PM, Peter Maydell wrote: This needs to be in the MemoryRegion core implementation, please. Right; see the memory/mutators

Re: [Qemu-devel] [PATCH] qmp: add test tool for QMP

2011-11-08 Thread Anthony Liguori
On 11/08/2011 02:36 AM, Mark Wu wrote: When I run this tool, I got two python exceptions. It turned out that both of them were caused by wrong usage. Do you think we need add validation for input to handle these cases? Definitely. Could you just send out a version of the patch with your

Re: [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled

2011-11-08 Thread Max Filippov
b/o the following infinite recursion: (gdb) bt #0  0x081b9564 in clz32 (val=0) at /home/jcmvbkbc/ws/xtensa/qemu-xtensa/host-utils.h:53 #1  0x081b97c2 in fls_bit (value=65536) at /home/jcmvbkbc/ws/xtensa/qemu-xtensa/hw/apic.c:121 #2  0x081ba16d in get_highest_priority_int (tab=0x89cec54) at

Re: [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled

2011-11-08 Thread Paolo Bonzini
On 11/08/2011 02:45 PM, Max Filippov wrote: Hi. I'm trying to run stock Debian 6.0 x86_64 kernel using qemu git head. With the following command line it's ok (getting to rootfs mounting and panics): qemu-system-x86_64 -serial stdio -monitor null -nographic -kernel

Re: [Qemu-devel] multiprocessor on kvm

2011-11-08 Thread Xin Tong
now question is if one of the cpu vmexits the guest due to trapping instruction ( i.e. PIO), the host linux will have only one physical cpu to run on as the other cpus are still running the guest os ? Am I right ? Thanks Xin 2011/11/8 Xin Tong xerox.time.t...@gmail.com: so qemu exposes

Re: [Qemu-devel] x86_64 linux kernel doesn't boot with -icount enabled

2011-11-08 Thread Max Filippov
But once I add -icount option (have tried -icount 1, 2, 16, 256, auto, the result is the same) qemu loops infinitely in the qemu_run_timers: Is this a regression, either from 0.15 w/o iothread, or from something recent?  Most backends are buggy with icount (with the embedded ones more likely

Re: [Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction

2011-11-08 Thread Jason Wessel
On 11/08/2011 07:48 AM, Laurent Desnogues wrote: On Tue, Nov 8, 2011 at 2:00 PM, Jason Wessel jason.wes...@windriver.com wrote: The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386:

[Qemu-devel] [PATCH 1.0] configure: fix detection for xattr.h on modern distributions

2011-11-08 Thread Avi Kivity
Modern distributions place xattr.h in /usr/include/sys, and fold libattr.so into libc. They also don't have an ENOATTR. Make configure detect this, and add a qemu-xattr.h file that directs the #include to the right place. Signed-off-by: Avi Kivity a...@redhat.com --- configure

[Qemu-devel] [PATCH] target-i386: Fix regression with maxsd SSE2 instruction v2

2011-11-08 Thread Jason Wessel
The maxsd instruction needs to take into account the sign of the numbers 64 bit numbers. This is a regression that was introduced in 347ac8e356 (target-i386: switch to softfloat). The case that fails is: maxsd %xmm1,%xmm0 When xmm1 = 24 and xmm0 = -100 This was found running the glib2

Re: [Qemu-devel] [Qemu-trivial] [PATCH v2] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Stefan Hajnoczi stefa...@gmail.com writes: On Tue, Nov 8, 2011 at 12:45 PM, Markus Armbruster arm...@redhat.com wrote: Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails.  Spotted by Coverity. ---  ui/vnc-auth-sasl.c |   19 +--  1 files changed, 5

[Qemu-devel] [PATCH v3] ui/vnc: Convert sasl.mechlist to g_malloc() friends

2011-11-08 Thread Markus Armbruster
Fixes protocol_client_auth_sasl_mechname() not to crash when malloc() fails. Spotted by Coverity. Signed-off-by: Markus Armbruster arm...@redhat.com --- ui/vnc-auth-sasl.c | 19 +-- 1 files changed, 5 insertions(+), 14 deletions(-) diff --git a/ui/vnc-auth-sasl.c

  1   2   3   >