At 11/18/2011 08:46 PM, Jan Kiszka Write:
On 2011-11-16 14:29, Dave Anderson wrote:
- Original Message -
Hi, all
'virsh dump' can not work when host pci device is used by guest. We have
discussed this issue here:
Small requirements on new features have percolated to virtio-9p-local.c.
In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD
and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the arguments
so that virtio-9p-local.c will not use AT_* constants.
At the same
On 11/20/2011 07:34 PM, Blue Swirl wrote:
On Sun, Nov 20, 2011 at 09:11, Avi Kivity a...@redhat.com wrote:
On 11/15/2011 08:12 PM, Avi Kivity wrote:
Change the default on x86 Linux hosts to building PIE (position
independent executables); instead of restricting the option to
user-only
Hi,
Recently,I am testing windows guest driver on Win7 and WinXP(32bit)
with the latest windows guest driver development source.
Download from
http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/src/
virtio-blk:
It seems OK both on Win7 and WinXP,the r/w performance is
On 21 November 2011 02:05, Alexander Graf ag...@suse.de wrote:
In an adventure to find out why yast2-core fails in its testsuite during
build on ARM for us, I dove into the code for a bit and debugged it down to
our old friend: multi-threaded TB invalidation.
The add_del/running_cpu code and env-halted are tracking stopped cpus.
Sleeping cpus (idle and enabled for interrupts) are waiting inside the
kernel.
No interrupt besides the restart can move a cpu from stopped to
operational. This is already handled over there. So lets just remove
the bogus wakup
On 21.11.2011, at 09:54, Peter Maydell wrote:
On 21 November 2011 02:05, Alexander Graf ag...@suse.de wrote:
In an adventure to find out why yast2-core fails in its testsuite during
build on ARM for us, I dove into the code for a bit and debugged it down to
our old friend: multi-threaded
On 21 November 2011 09:55, Alexander Graf ag...@suse.de wrote:
On 21.11.2011, at 09:54, Peter Maydell wrote:
I think I sent you my work-in-progress patch, didn't I?
I know that we talked about it. But I can't find it. That doesn't
mean that you didn't send it, but either way I'd really like
On 21.11.2011, at 10:59, Peter Maydell wrote:
On 21 November 2011 09:55, Alexander Graf ag...@suse.de wrote:
On 21.11.2011, at 09:54, Peter Maydell wrote:
I think I sent you my work-in-progress patch, didn't I?
I know that we talked about it. But I can't find it. That doesn't
mean that
On 21 November 2011 10:07, Alexander Graf ag...@suse.de wrote:
On 21.11.2011, at 10:59, Peter Maydell wrote:
You can hit this bug even single-threaded or in system mode:
it's just that aggressively multi-threaded user apps are the
easiest way to trigger it. So I don't think we can ever use
On Mon, Nov 21, 2011 at 12:54 AM, Max Filippov jcmvb...@gmail.com wrote:
Add check for the EFD_NONBLOCK and EFD_CLOEXEC flags to the
CONFIG_EVENTFD test.
This fixes the following build failure on Fedora 9:
CC event_notifier.o
event_notifier.c: In function `event_notifier_init':
On 11/21/2011 10:39 AM, Cao,Bing Bu wrote:
Hi,
Recently,I am testing windows guest driver on Win7 and
WinXP(32bit) with the latest windows guest driver development source.
Download from
http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/src/
virtio-blk:
It seems OK
Am 18.11.2011 15:34, schrieb Stefan Hajnoczi:
On Fri, Nov 18, 2011 at 11:10 AM, Paolo Bonzini pbonz...@redhat.com wrote:
On 11/18/2011 11:59 AM, Stefan Hajnoczi wrote:
+tmp = g_malloc0(sizeof(uint64_t)*l1_size);
+ret = bdrv_pwrite(qcow_bs, header_size, tmp,
While debugging some issues with QEMU_STRACE I stumbled over segmentation
faults that were pretty reproducible. Turns out we tried to treat a
normal return value as errno, resulting in an access over array boundaries
for the resolution.
Fix this by allowing failure to resolve invalid errnos into
On 21 November 2011 10:40, Alexander Graf ag...@suse.de wrote:
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 90027a1..e30b005 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1515,14 +1515,19 @@ void
print_syscall_ret(int num, abi_long ret)
{
int i;
+
On Mon, Nov 21, 2011 at 3:48 AM, Kamil Rytarowski n...@gmx.com wrote:
As a user (not a developer) of GNS3 I ask you to include the patch for UDP.
VirtualBox has included it, so it's time for QEMU now.
There was discussion about it (p.ex
On 21.11.2011, at 11:47, Peter Maydell wrote:
On 21 November 2011 10:40, Alexander Graf ag...@suse.de wrote:
diff --git a/linux-user/strace.c b/linux-user/strace.c
index 90027a1..e30b005 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -1515,14 +1515,19 @@ void
On Mon, Nov 21, 2011 at 10:44 AM, Kevin Wolf kw...@redhat.com wrote:
Am 18.11.2011 15:34, schrieb Stefan Hajnoczi:
On Fri, Nov 18, 2011 at 11:10 AM, Paolo Bonzini pbonz...@redhat.com wrote:
On 11/18/2011 11:59 AM, Stefan Hajnoczi wrote:
+ tmp = g_malloc0(sizeof(uint64_t)*l1_size);
+
On Fri, 18 Nov 2011, Anthony Liguori wrote:
On 11/18/2011 05:46 AM, Stefano Stabellini wrote:
On Tue, 15 Nov 2011, Stefano Stabellini wrote:
On Tue, 15 Nov 2011, Anthony Liguori wrote:
On 11/15/2011 08:51 AM, stefano.stabell...@eu.citrix.com wrote:
From: Stefano
Am 21.11.2011 11:53, schrieb Stefan Hajnoczi:
On Mon, Nov 21, 2011 at 10:44 AM, Kevin Wolf kw...@redhat.com wrote:
Am 18.11.2011 15:34, schrieb Stefan Hajnoczi:
On Fri, Nov 18, 2011 at 11:10 AM, Paolo Bonzini pbonz...@redhat.com wrote:
On 11/18/2011 11:59 AM, Stefan Hajnoczi wrote:
+tmp
While debugging some issues with QEMU_STRACE I stumbled over segmentation
faults that were pretty reproducible. Turns out we tried to treat a
normal return value as errno, resulting in an access over array boundaries
for the resolution.
Fix this by allowing failure to resolve invalid errnos into
On 21 November 2011 10:52, Alexander Graf ag...@suse.de wrote:
On 21.11.2011, at 11:47, Peter Maydell wrote:
Should this really be printing -1 all the time when ret isn't -1 ?
In linux-user, the syscall emulation functions return -errno which later
gets translated to -1 with errno=-errno.
Public bug reported:
The keys { and [ did not work inside the virtualized enviorment (widnows
7). The problems happens ussing aqemu as a front end as well as
invoking qemu-kvm from command line:
qemu-kvm -m 8096 eclipse.img -smp cores=4,threads=2 -hdb ander.img -k es
We have also notices this
From: Hongyong Zang zanghongy...@huawei.com
Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the
guest.
As for pci_register_bar(), parameter MemoryRegion should be s-bar instead of
s-ivshmem.
Signed-off-by: Hongyong Zang zanghongy...@huawei.com
---
hw/ivshmem.c |2 +-
On 21 November 2011 11:04, Alexander Graf ag...@suse.de wrote:
static void
print_syscall_ret_addr(const struct syscallname *name, abi_long ret)
{
-if( ret == -1 ) {
- gemu_log( = -1 errno=%d (%s)\n, errno, target_strerror(errno));
+ char *errstr = NULL;
+
+ if (ret == -1) {
On 11/21/2011 12:56 PM, zanghongy...@huawei.com wrote:
From: Hongyong Zang zanghongy...@huawei.com
Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the
guest.
As for pci_register_bar(), parameter MemoryRegion should be s-bar instead of
s-ivshmem.
Signed-off-by:
Correct the printing of errnos for syscalls which are handled
via print_syscall_ret_addr (mmap, mmap2, brk, shmat): errnos
are returned as negative returned values at this level, not
via the host 'errno' variable.
Signed-off-by: Peter Maydell peter.mayd...@linaro.org
---
This applies on top of
Cao,Bing Bu m...@linux.vnet.ibm.com writes:
I have tested the issue use -vga none -nographic option.
QEMU segment faults.
But i think there is no any text and graphic console created in this case.
The console[0] is NULL.
The vga_hw_screen_dump() should return before console_select().
What
On 11/21/2011 02:01 PM, Richard Laager wrote:
I'm not an expert on the architecture of KVM, so perhaps this is a QEMU
question. If so, please let me know and I'll ask on a different list.
It is a qemu question, yes (though fork()ing a guest also relates to kvm).
Background:
Assuming the
Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
@@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in
qerror_report(QERR_DATA_SYNC_FAILED, bs-device_name);
return ret;
}
-open_flags = bs-open_flags;
-
On 11/21/2011 12:08 PM, Kevin Wolf wrote:
I didn't say this.:-)
At least in theory, block devices may not be the only protocols with
!has_zero_init. We have only covered raw-posix with this discussion. I
would prefer an explicit write of the table to avoid breaking other
protocols (though I
Stefan Hajnoczi wrote:
On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
+if ((hostcache =
Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
+static int raw_reopen_prepare(BlockDriverState *bs, BDRVReopenState **prs,
+ int flags)
+{
+BDRVRawReopenState *raw_rs =
On 11/18/2011 03:54 PM, Anthony Liguori wrote:
The Right Solution would be to modify the RTC emulation such that it did
a qemu_get_clock() during read of the CMOS registers in order to ensure
the time was up to date (instead of using 1 second timers).
True, but you also have to handle UIP and
Am 19.11.2011 20:18, schrieb Stefan Weil:
This was spotted by cppcheck.
Signed-off-by: Stefan Weil s...@weilnetz.de
---
darwin-user/signal.c |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/darwin-user/signal.c b/darwin-user/signal.c
index c530227..317ef92
From: M. Mohan Kumar mo...@in.ibm.com
Add proxy getversion to get generation number
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 77 +++
hw/9pfs/virtio-9p-proxy.c | 34 +++
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to create filesystem objects like directory,
device nodes, symbolic links, links for proxy filesytem driver
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 120 ++--
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 089c23c..6f32a0e 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -59,7 +59,6 @@ typedef struct {
char *serial;
Hi,
This pull fixes SYNCRONIZE_CACHE handling in both scsi and usb code.
The SYNCRONIZE_CACHE scsi command is different from all other ones:
It doesn't transfer any data, but still doesn't complete instantly.
Both scsi-disk and usb-storage failed to handle this case correctly,
resulting in all
Coverity thinks q could be NULL there and warns.
I believe it can't be NULL there.
Add assert to prove it.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-ehci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c
index
Am 20.11.2011 07:43, schrieb Ankur Dahiya:
I am trying to set a breakpoint in qemu. That is, a function of mine
should run when guest eip becomes equal
to some specified address.
I set the bp using : cpu_breakpoint_insert(first_cpu, 0xc103364f,
BP_GDB, NULL) exec.c
Then I do
On 21 November 2011 13:32, Andreas Färber andreas.faer...@web.de wrote:
Is the debug output really useful without the information? Maybe rather
append %p %x %x? What does linux-user do?
linux-user doesn't print any debug output at this point.
Incidentally, I'm increasingly of the opinion that
This bug is got fixed in qemu-kvm upstream. I verified it. The following
is the commit info for the fix in qemu-kvm.
commit c4cd183600aa6319b4a4a0b48cb41d63198e08c3
Author: Alex Williamson alex.william...@redhat.com
Date: Wed Nov 16 13:45:32 2011 -0700
pci-assign: Fix device removal
On 11/21/2011 02:39 PM, Gerd Hoffmann wrote:
In case the guest sends a SYNCHRONIZE_CACHE command scsi_req_complete()
is called twice: Once because there is no data to transfer and
scsi-disk thinks it is done with the command, and once when the flush is
actually finished ...
Signed-off-by:
On Mon, Nov 21, 2011 at 12:28 PM, supriya kannery supri...@in.ibm.com wrote:
Stefan Hajnoczi wrote:
On Thu, Nov 17, 2011 at 5:18 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
On 11/17/2011 01:36 AM, Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
On 11/21/2011 02:40 PM, Gerd Hoffmann wrote:
Until recently all scsi commands sent to scsi-disk did either transfer
data or finished instantly. The correct implementation of
SYNCRONIZE_CACHE changed the picture though, and usb-storage needs
a fix to handle that case correctly.
---
Am 18.11.2011 16:31, schrieb Paolo Bonzini:
See individual patches, all for 1.0.
Paolo Bonzini (4):
virtio-blk: fix cross-endian config space
usb-msd: do not register twice in the boot order
scsi: fix fw path
scsi-generic: add as boot device
hw/pci-hotplug.c |3 ++-
Until recently all scsi commands sent to scsi-disk did either transfer
data or finished instantly. The correct implementation of
SYNCRONIZE_CACHE changed the picture though, and usb-storage needs
a fix to handle that case correctly.
---
hw/usb-msd.c | 16 ++--
1 files changed, 10
From: M. Mohan Kumar mo...@in.ibm.com
Add validatio check to {un}marshal code.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtio-9p-marshal.c | 97 ---
fsdev/virtio-9p-marshal.h |8 +-
hw/9pfs/virtio-9p.c | 231
On 2011-11-21 20:31, Avi Kivity wrote:
On 11/21/2011 02:01 PM, Richard Laager wrote:
I'm not an expert on the architecture of KVM, so perhaps this is a QEMU
question. If so, please let me know and I'll ask on a different list.
It is a qemu question, yes (though fork()ing a guest also relates
usb_msd_send_status can be called from different code paths, move the
debug message into the function to make sure it is printed
unconditionally.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Hi,
I'm seeing some virtual machines network interfaces are hanging, and need
down/up or reboot.
I'm opening raw socket inside the machine.
Is it possible that this cause this hanging of all the network interfaces
inside the machine (3 ifaces).
Regards,
Kfir
On Mon, Nov 21, 2011 at 12:13 PM, supriya kannery supri...@in.ibm.com wrote:
Stefan Hajnoczi wrote:
On Fri, Nov 11, 2011 at 6:48 AM, Supriya Kannery
supri...@linux.vnet.ibm.com wrote:
@@ -708,17 +731,31 @@ int bdrv_reopen(BlockDriverState *bs, in
qerror_report(QERR_DATA_SYNC_FAILED,
On Mon, 21 Nov 2011 19:06:07 +0530, M. Mohan Kumar mo...@in.ibm.com wrote:
From: M. Mohan Kumar mo...@in.ibm.com
Add validatio check to {un}marshal code.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtio-9p-marshal.c | 97 ---
fsdev/virtio-9p-marshal.h |
From: M. Mohan Kumar mo...@in.ibm.com
Add option to use named socket for communicating between proxy helper
and qemu proxy FS. Access to socket can be given by using command line
options -u and -g. We can achive the same using a shell script over
qemu and virtfs-proxy-helper using exec
Put status word into device state, fill it in command_complete, have
usb_msd_send_status just send it out.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c | 38 +-
1 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/hw/usb-msd.c
From: M. Mohan Kumar mo...@in.ibm.com
Add interfaces to open and create files for proxy file system driver.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 133 ++-
hw/9pfs/virtio-9p-proxy.c | 187
From: M. Mohan Kumar mo...@in.ibm.com
Add file ownership interfaces like chmod/chown, utime update, rename,
remove and truncating files for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile|2 +-
fsdev/virtfs-proxy-helper.c | 88
From: M. Mohan Kumar mo...@in.ibm.com
Provide root privilege access to QEMU 9p proxy filesystem using socket
communication.
Proxy helper is started by root user as:
~ # virtfs-proxy-helper -f|--fd socket descriptor -p|--path path-to-share
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 182 +
hw/9pfs/virtio-9p-proxy.c | 189 +--
hw/9pfs/virtio-9p-proxy.h | 34
3
From: M. Mohan Kumar mo...@in.ibm.com
Add xattr support for proxy FS
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
fsdev/virtfs-proxy-helper.c | 93 ++-
hw/9pfs/virtio-9p-proxy.c | 130 +++---
hw/9pfs/virtio-9p-proxy.h
From: M. Mohan Kumar mo...@in.ibm.com
Move p9 marshaling/unmarshaling code to a separate file so that
proxy filesytem driver can use these calls. Also made marshaling
code generic to accept struct iovec instead of V9fsPDU.
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile.objs
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
Makefile | 12 +++-
fsdev/virtfs-proxy-helper.texi | 59
2 files changed, 70 insertions(+), 1 deletions(-)
create mode 100644
From: M. Mohan Kumar mo...@in.ibm.com
Pass-through security model in QEMU 9p server needs root privilege to do
few file operations (like chown, chmod to any mode/uid:gid). There are two
issues in pass-through security model
1) TOCTTOU vulnerability: Following symbolic links in the server could
From: M. Mohan Kumar mo...@in.ibm.com
Add new proxy filesystem driver to add root privilege to qemu process.
It needs a helper process to be started by root user.
Following command line can be used to utilize proxy filesystem driver
-virtfs proxy,id=id,mount_tag=tag,socket_fd=socket-fd
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Gerd Hoffmann
From: M. Mohan Kumar mo...@in.ibm.com
Signed-off-by: M. Mohan Kumar mo...@in.ibm.com
---
qemu-options.hx | 25 -
1 files changed, 16 insertions(+), 9 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 681eaf1..cde17ed 100644
--- a/qemu-options.hx
+++
On Tue, Nov 08, 2011 at 09:33:04AM -0800, Chris Wright wrote:
* Alexander Graf (ag...@suse.de) wrote:
On 29.10.2011, at 20:45, Bharata B Rao wrote:
As guests become NUMA aware, it becomes important for the guests to
have correct NUMA policies when they run on NUMA aware hosts.
scsi keeps track of the tag in SCSIRequest,
no need to store a separate copy.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 5dc4afc..089c23c 100644
---
In case the guest sends a SYNCHRONIZE_CACHE command scsi_req_complete()
is called twice: Once because there is no data to transfer and
scsi-disk thinks it is done with the command, and once when the flush is
actually finished ...
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/scsi-disk.c
On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote:
I looked at Peter's recent work in this area.
(https://lkml.org/lkml/2011/11/17/204)
It introduces two interfaces:
1. ms_tbind() to bind a thread to a memsched(*) group
2. ms_mbind() to bind a memory region to memsched group
I
On Mon, Nov 21, 2011 at 04:25:26PM +0100, Peter Zijlstra wrote:
On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote:
I looked at Peter's recent work in this area.
(https://lkml.org/lkml/2011/11/17/204)
It introduces two interfaces:
1. ms_tbind() to bind a thread to a
Hi
Please send in any agenda items you are interested in covering.
Later, Juan.
Coverity thinks q could be NULL there and warns.
I believe it can't be NULL there.
Add assert to prove it.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-ehci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/usb-ehci.c b/hw/usb-ehci.c
index
Until recently all scsi commands sent to scsi-disk did either transfer
data or finished instantly. The correct implementation of
SYNCRONIZE_CACHE changed the picture though, and usb-storage needs
a fix to handle that case correctly.
---
hw/usb-msd.c | 16 ++--
1 files changed, 10
Put status word into device state, fill it in command_complete, have
usb_msd_send_status just send it out.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c | 38 +-
1 files changed, 21 insertions(+), 17 deletions(-)
diff --git a/hw/usb-msd.c
scsi keeps track of the tag in SCSIRequest,
no need to store a separate copy.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c | 13 ++---
1 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 5dc4afc..089c23c 100644
---
On Fri, Nov 18, 2011 at 6:29 PM, Kevin Wolf kw...@redhat.com wrote:
+ /*
+ * Increase the refcounts of all clusters and make sure everything is
+ * stable on disk before updating the snapshot table to contain a pointer
+ * to the new L1 table.
+ */
+ ret =
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster arm...@redhat.com
Signed-off-by: Gerd Hoffmann
This fixes bugs dealing with msi-x mask bits pointed out by Jan Kiszka.
Jan Kiszka (1):
msix: Prevent bogus mask updates on MMIO accesses
Michael S. Tsirkin (2):
msix: track function masked in pci device state
msix: avoid mask updates if mask is unchanged
hw/msix.c | 48
Only go over the table when function is masked.
This is not really important for qemu.git but helps
fix a bug in qemu-kvm.git.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/msix.c | 21 ++---
hw/pci.h |2 ++
2 files changed, 16 insertions(+), 7 deletions(-)
From: Jan Kiszka jan.kis...@siemens.com
Only accesses to the MSI-X table must trigger a call to
msix_handle_mask_update, otherwise the vector
value might be out of range.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/msix.c |6
Check pending bit only if vector mask status changed.
This is not really important for qemu.git but helps
fix a bug in qemu-kvm.git.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
---
hw/msix.c | 29 -
1 files changed, 20 insertions(+), 9 deletions(-)
diff --git
On Fri, Nov 18, 2011 at 6:28 PM, Kevin Wolf kw...@redhat.com wrote:
Kevin Wolf (9):
qcow2: Return real error code in qcow2_read_snapshots
qcow2: Return real error code in qcow2_write_snapshots
qcow2: Update snapshot table information at once
qcow2: Cleanups and memleak fix in
On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote:
In the original post of this mail thread, I proposed a way to export
guest RAM ranges (Guest Physical Address-GPA) and their corresponding host
host virtual mappings (Host Virtual Address-HVA) from QEMU (via QEMU monitor).
The idea was
It has been superseded by the two previous commits, which introduced
the test-qmp-output-visitor and test-qmp-input-visitor tests.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |5 +-
test-visitor.c | 338
2
usb_msd_send_status can be called from different code paths, move the
debug message into the function to make sure it is printed
unconditionally.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git
Contains unit-tests for the QMP input visitor implementation.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |4 +
configure|2 +-
test-qmp-input-visitor.c | 270 ++
3 files changed, 275
This series introduces two new test programs: test-qmp-output-visitor and
test-qmp-input-visitor.
As their names suggest, they contain unit-tests to check QMP's Visitor
implementation. They supersede the test-visitor program (which is dropped
by this series).
Besides adding new unit-tests, I've
Gerd Hoffmann kra...@redhat.com writes:
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster
Gerd Hoffmann kra...@redhat.com writes:
Commit 0c402e5abb8c2755390eee864b43a98280fc2453 is incomplete
and misses one of the two function pointer calls in
usb_host_scan_dev(). Add the additional port handling logic
to the other call too.
Spotted by Coverity.
Cc: Markus Armbruster
Hi,
This pull fixes SYNCRONIZE_CACHE handling in usb-storage code.
The SYNCRONIZE_CACHE scsi command is different from all other ones:
It doesn't transfer any data, but still doesn't complete instantly.
usb-storage failes to handle this case correctly, resulting in all sorts
of funky assert
Contains unit-tests for the QMP output visitor implementation.
Signed-off-by: Luiz Capitulino lcapitul...@redhat.com
---
Makefile |4 +
configure |2 +-
qapi-schema-test.json |6 +
test-qmp-output-visitor.c | 423
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb-msd.c |4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/hw/usb-msd.c b/hw/usb-msd.c
index 089c23c..6f32a0e 100644
--- a/hw/usb-msd.c
+++ b/hw/usb-msd.c
@@ -59,7 +59,6 @@ typedef struct {
char *serial;
On Tue, Nov 15, 2011 at 11:47:58AM +0100, ext Juan Quintela wrote:
Takuya Yoshikawa yoshikawa.tak...@oss.ntt.co.jp wrote:
Adding qemu-devel ML to CC.
Your question should have been sent to qemu-devel ML because the logic
is implemented in QEMU, not KVM.
(2011/11/11 1:35), Oliver
test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is passed).
Tests using the glib test framework are
Here are a bunch of fixes for the rtc that I found while reading
the code. Might be for 1.0 or 1.1, at your choice.
I also have a fix for at least one relatively important bug: when writing
register B unmasks a pending interrupt, the IRQ line should be raised.
However, the fix is a bit invasive
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/mc146818rtc.c | 19 ++-
1 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index 14c8cb9..a5c533b 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -427,16 +427,17 @@
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/mc146818rtc.c |4 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c
index a5c533b..b942ce2 100644
--- a/hw/mc146818rtc.c
+++ b/hw/mc146818rtc.c
@@ -179,8 +179,9 @@ static void
Am 21.11.2011 18:09, schrieb Luiz Capitulino:
test-coroutine is listed as a libcheck test in the 'checks' variable. This
is not right because 'make check' won't run test-coroutine if libcheck
tests are not enabled (either because libcheck isn't detected or because
--disable-check-utests is
1 - 100 of 162 matches
Mail list logo
