[Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode

2011-11-21 Thread Paolo Bonzini
Hours in 12-hour mode are in the 1-12 range, not 0-11. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/mc146818rtc.c | 11 +++ 1 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/mc146818rtc.c b/hw/mc146818rtc.c index 2aaca2f..14c8cb9 100644 --- a/hw/mc146818rtc.c

[Qemu-devel] [PATCH 4/4] rtc: clear non-PF bits when reinjecting on ack

2011-11-21 Thread Paolo Bonzini
When an rtc interrupt is reinjected immediately after being acked, other interrupts should not be reinjected, so do clear their bits. Also, if the periodic interrupts have been disabled before acking, do not reinject, as the guest might get very confused! Signed-off-by: Paolo Bonzini

Re: [Qemu-devel] [TestDays] s390x emulation error

2011-11-21 Thread Andreas Färber
Am 18.11.2011 16:33, schrieb Alexander Graf: On 10.11.2011, at 10:32, Andreas Färber wrote: Am 09.11.2011 23:53, schrieb Andreas Färber: I get the following error: $ s390x-softmmu/qemu-system-s390x qemu-system-s390x: Guest moved used index from 0 to 47802 Now with -kernel and -drive

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Avi Kivity
On 11/21/2011 05:25 PM, Peter Zijlstra wrote: On Mon, 2011-11-21 at 20:48 +0530, Bharata B Rao wrote: I looked at Peter's recent work in this area. (https://lkml.org/lkml/2011/11/17/204) It introduces two interfaces: 1. ms_tbind() to bind a thread to a memsched(*) group 2.

Re: [Qemu-devel] [PATCH 1/4] configure: Don't mix glib and libcheck tests

2011-11-21 Thread Paolo Bonzini
On 11/21/2011 06:09 PM, Luiz Capitulino wrote: test-coroutine is listed as a libcheck test in the 'checks' variable. This is not right because 'make check' won't run test-coroutine if libcheck tests are not enabled (either because libcheck isn't detected or because --disable-check-utests is

[Qemu-devel] [PATCH] pseries: Fix possible out-of-bounds error

2011-11-21 Thread Stefan Weil
PCI_NUM_REGIONS is 7, ARRAY_SIZE(bars) is 6. Either bars must be extended by a 7th array element, or the loop which reads bars[i] must terminate before it tries to read bars[6]. For dev-io_regions[6].size == 0, the old code also works, but it is not obvious whether this is always true. This bug

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Peter Zijlstra
On Mon, 2011-11-21 at 20:03 +0200, Avi Kivity wrote: Does ms_mbind() require that its vmas in its area be completely contained in the region, or does it split vmas on demand? I suggest the latter to avoid exposing implementation details. as implemented (which is still rather incomplete) it

[Qemu-devel] [PATCH] bsd_user: Fix potential null pointer dereference

2011-11-21 Thread Stefan Weil
This bug was spotted by cppcheck. Using g_try_malloc0 (as does the linux-user code) fixes this. Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/elfload.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/bsd-user/elfload.c b/bsd-user/elfload.c index

Re: [Qemu-devel] [PATCH] bsd_user: Fix potential null pointer dereference

2011-11-21 Thread Peter Maydell
On 21 November 2011 19:41, Stefan Weil s...@weilnetz.de wrote: This bug was spotted by cppcheck. Using g_try_malloc0 (as does the linux-user code) fixes this. Signed-off-by: Stefan Weil s...@weilnetz.de Oh look, another bug in bsd-user it wouldn't have if it shared code with linux-user :-)

[Qemu-devel] [PATCH v2] bsd_user: Fix potential null pointer dereference

2011-11-21 Thread Stefan Weil
This bug was spotted by cppcheck. Using g_try_malloc0 (as does the linux-user code) fixes this. v2: Use g_free in bsdload.c, too. Thanks to Peter Maydell for this hint. Signed-off-by: Stefan Weil s...@weilnetz.de --- bsd-user/bsdload.c |2 +- bsd-user/elfload.c |5 ++--- 2 files

Re: [Qemu-devel] [PATCH] bsd_user: Fix potential null pointer dereference

2011-11-21 Thread Stefan Weil
Am 21.11.2011 20:49, schrieb Peter Maydell: On 21 November 2011 19:41, Stefan Weils...@weilnetz.de wrote: This bug was spotted by cppcheck. Using g_try_malloc0 (as does the linux-user code) fixes this. Signed-off-by: Stefan Weils...@weilnetz.de Oh look, another bug in bsd-user it wouldn't

Re: [Qemu-devel] KVM call agenda for Novemeber 22

2011-11-21 Thread Anthony Liguori
On 11/21/2011 10:00 AM, Juan Quintela wrote: Hi Please send in any agenda items you are interested in covering. I'm technical on holiday this week so I won't be attending. But as an FYI, I ran across seccomp-nurse[1] this weekend. It more or less let's you write a python program to

Re: [Qemu-devel] [PATCH 1/4] xen: introduce mc146818rtcxen

2011-11-21 Thread Anthony Liguori
On 11/20/2011 08:53 AM, Avi Kivity wrote: On 11/18/2011 04:54 PM, Anthony Liguori wrote: Thinking more about it, I think this entire line of thinking is wrong (including mine) :-) The problem you're trying to solve is that the RTC fires two 1 second timers regardless of whether the guest is

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-21 Thread Anthony Liguori
On 11/21/2011 02:29 AM, Paolo Bonzini wrote: Small requirements on new features have percolated to virtio-9p-local.c. In particular, the utimensat wrapper actually only supports dirfd = AT_FDCWD and flags = AT_SYMLINK_NOFOLLOW in the fallback code. Remove the arguments so that virtio-9p-local.c

Re: [Qemu-devel] [PATCHES for 1.0] various spice usb-redir integration patches

2011-11-21 Thread Anthony Liguori
On 11/19/2011 03:22 AM, Hans de Goede wrote: Hi All, Sorry for sending these in so late, I send most of them in before a long time ago, but then they got stuck on waiting for the big chardev rewrite. Since it seems clear now that the big chardev rewrite won't happen before 1.0, I would like to

[Qemu-devel] updating seabios to current release?

2011-11-21 Thread Michael Tokarev
Current version of seabios is 1.6.3, released several weeks ago. Compared with the version currently shipped in qemu, it adds a few commits, most of which are fixes for qemu-related issues. Maybe it's not too late to update seabios to the latest released version in order to incorporate all the

[Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. The implementation was originally written by Hans Jang and Adam Clench of OK-Labs; I've updated it to the current qdev and memory region paradigms and

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Peter Chubb
Hi Peter, Here's a fixed patch for the sp804 timer. Properly implement the dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Peter Chubb peter.ch...@nicta.com.au

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Andreas Färber
Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Your patch format is a bit unusual. Please don't include personal messages in the description, keep it in a

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Chris Wright
* Peter Zijlstra (a.p.zijls...@chello.nl) wrote: On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote: In the original post of this mail thread, I proposed a way to export guest RAM ranges (Guest Physical Address-GPA) and their corresponding host host virtual mappings (Host Virtual

[Qemu-devel] [Bug 893367] [NEW] HPET supports only one IRQ

2011-11-21 Thread Julian Stecklina
Public bug reported: The emulated HPET only supports triggering IRQ 2. Since MSIs are by default disabled, this severely limits the usefulness of the HPET as only one timer block can effectively be used (otherwise they would share IRQ 2). Ideally, the HPET should support as much timer blocks as

Re: [Qemu-devel] qemu kernel :address generated are non-uniform

2011-11-21 Thread sparsh mittal
Thanks for the answer. For right now, I am OK with this, since I realized that cache access is uniform (cache sets are calculated by modulo) and my work concerns with cache. Still, I am happy to know that it is expected thing and not unexpected. Also I have one very important question and I

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Andreas Färber
Am 21.11.2011 23:05, schrieb Peter Chubb: Hi Peter, Here's a fixed patch for the sp804 timer. Properly implement the dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Andreas == Andreas Färber andreas.faer...@web.de writes: Andreas Hi Peter, Am 21.11.2011 22:58, schrieb Peter Chubb: Hi Peter, Please find appended a patch containing initial support for the FreeScale i.MX31 and the KZM Arm11 evaluation board. Andreas Your patch format is a bit unusual.

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:04, Peter Chubb peter.ch...@nicta.com.au wrote: Andreas == Andreas Färber andreas.faer...@web.de writes: ??? Save/restore.  */ Andreas What does this comment tell us? :) Dunno.  It was in the codebase I got; I think it means that save and restore aren't implemented

[Qemu-devel] [Bug 893367] Re: HPET supports only one IRQ

2011-11-21 Thread Julian Stecklina
The offending code seems to be: /* advertise availability of ioapic inti2 */ timer-config |= 0x0004ULL 32; in hw/hpet.c hpet_reset(). -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 21:58, Peter Chubb pet...@gelato.unsw.edu.au wrote: Hi Peter,   Please find appended a patch containing initial support for the   FreeScale i.MX31 and the KZM Arm11 evaluation board.   The implementation was originally written by Hans Jang and Adam   Clench of OK-Labs;

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Thanks Peter, I'll split the patches and resubmit. It'll probably be tomorrow or Thursday. Do you have a suggestion for an alternative to hw_error for guest bad behaviour? It seems to be used historically. For emulating ARM, causing qemu to stop isn't such a bad idea ... the guest does

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 21 November 2011 23:54, Peter Chubb pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  It seems to be used historically.  For emulating ARM, causing qemu to stop isn't such a bad idea ... the guest does something wrong and the

[Qemu-devel] [ANNOUNCE] QEMU 1.0-rc3

2011-11-21 Thread Anthony Liguori
Hi, On behalf of the QEMU Team, I'd like to announce the availability of QEMU 1.0, release candidate 3. This is the third release candidate for the 1.0 release. This is not intended for production use but rather for testing. To participate in the testing effort, please read the Testing

Re: [Qemu-devel] [PULL v2 1.0] usb patch queue

2011-11-21 Thread Anthony Liguori
On 11/21/2011 10:15 AM, Gerd Hoffmann wrote: Hi, This pull fixes SYNCRONIZE_CACHE handling in usb-storage code. The SYNCRONIZE_CACHE scsi command is different from all other ones: It doesn't transfer any data, but still doesn't complete instantly. usb-storage failes to handle this case

Re: [Qemu-devel] [PULL 0/9] Block patches for 1.0

2011-11-21 Thread Anthony Liguori
On 11/18/2011 08:03 AM, Kevin Wolf wrote: The following changes since commit 3f5bd4e1b874590d3d76e031530799a4610da6dc: Update version to 1.0-rc2 (2011-11-14 11:26:32 -0600) are available in the git repository at: git://repo.or.cz/qemu/kevin.git for-anthony Pulled. Thanks. Regards,

Re: [Qemu-devel] [PATCH] [ARM] fix function names in error messages in arm_timer.c

2011-11-21 Thread Peter Chubb
Fix names of functions in error messages: as suggested by Andreas Färber, use the C99 standard __func__ macro to get the correct name. This fixes one real bug (the message used to print sp804 instead of icp_pit), the other changes are cosmetic. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au

Re: [Qemu-devel] [PULL 0/5]: QMP patches for 1.0

2011-11-21 Thread Anthony Liguori
On 11/17/2011 11:18 AM, Luiz Capitulino wrote: Anthony, This pull contains a fix for the enum type handling plus Michael's Makefile fixes. Pulled. Thanks. Regards, Anthony Liguori The changes (since 3f5bd4e1b874590d3d76e031530799a4610da6dc) are available in the following repository:

Re: [Qemu-devel] [PULL 1.0 0/5] Trivial patches for 11 to 17 November 2011

2011-11-21 Thread Anthony Liguori
On 11/17/2011 07:03 AM, Stefan Hajnoczi wrote: These bug fixes and documentation fixes are suitable for 1.0. The purely internal trivial patches are being queued up for 1.1 in the trivial-patches-next tree. The following changes since commit 3f5bd4e1b874590d3d76e031530799a4610da6dc: Update

Re: [Qemu-devel] [PATCH 1/5] migrate: add migration blockers

2011-11-21 Thread Anthony Liguori
On 11/14/2011 03:09 PM, Anthony Liguori wrote: This lets different subsystems register an Error that is thrown whenever migration is attempted. This works nicely because it gracefully supports things like hotplug. Right now, if multiple errors are registered, only one of them is reported. I

Re: [Qemu-devel] [PATCH 1.0 0/2] Fix compilation of 9pfs on old systems

2011-11-21 Thread Anthony Liguori
On 11/18/2011 10:35 AM, Paolo Bonzini wrote: Old systems do not have AT_REMOVEDIR, and 9pfs fails to compile on them. Patch 2 fixes that, patch 1 actually let me test it on Linux. :) Probably the same push-down should be done also for open(2) flags, for consistency. For example, some systems

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Maydell
On 22 November 2011 00:27, Peter Chubb peter.ch...@nicta.com.au wrote: Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 21 November 2011 23:54, Peter Chubb Peter pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  

Re: [Qemu-devel] [PATCH] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Peter == Peter Maydell peter.mayd...@linaro.org writes: Peter On 21 November 2011 23:54, Peter Chubb Peter pet...@gelato.unsw.edu.au wrote: Do you have a suggestion for an alternative to hw_error for guest bad behaviour?  It seems to be used historically.  For emulating ARM, causing qemu to

Re: [Qemu-devel] [PATCH] ivshmem: fix PCI BAR2 registration during initialization

2011-11-21 Thread Anthony Liguori
On 11/21/2011 04:56 AM, zanghongy...@huawei.com wrote: From: Hongyong Zangzanghongy...@huawei.com Ivshmem cannot work, and the command lspci cannot show ivshmem BAR2 in the guest. As for pci_register_bar(), parameter MemoryRegion should be s-bar instead of s-ivshmem. Signed-off-by: Hongyong

[Qemu-devel] [FYI] Need to do a full rebuild if you are on Linux x86 host

2011-11-21 Thread Anthony Liguori
Due to this commit: commit 40d6444e91c6ab17e5e8ab01d4eece90cbc4afed Author: Avi Kivity a...@redhat.com Date: Tue Nov 15 20:12:17 2011 +0200 configure: build position independent executables on x86-Linux hosts PIE binaries cannot be linked with non-PIE binaries and make is not smart

Re: [Qemu-devel] [PATCH v8 1.0] configure: build position independent executables on x86-Linux hosts

2011-11-21 Thread Anthony Liguori
On 11/15/2011 12:12 PM, Avi Kivity wrote: Change the default on x86 Linux hosts to building PIE (position independent executables); instead of restricting the option to user-only targets, apply it to all targets. In addition, set the relocation sections to read-only (relro) when available; this

Re: [Qemu-devel] [PATCH] Include zlib.h using #include

2011-11-21 Thread Anthony Liguori
On 11/20/2011 05:34 AM, Stefan Weil wrote: zlib.h is not a local include file, therefore it should be included using instead of . Signed-off-by: Stefan Weils...@weilnetz.de Applied. Thanks. Regards, Anthony Liguori --- block/vmdk.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [Qemu-devel] [PATCH] configure: check for EFD_NONBLOCK | EFD_CLOEXEC flags

2011-11-21 Thread Anthony Liguori
On 11/20/2011 06:54 PM, Max Filippov wrote: Add check for the EFD_NONBLOCK and EFD_CLOEXEC flags to the CONFIG_EVENTFD test. This fixes the following build failure on Fedora 9: CCevent_notifier.o event_notifier.c: In function `event_notifier_init': event_notifier.c:21:

Re: [Qemu-devel] [PATCH for v1.0 0/3] msix: fixes for 1.0

2011-11-21 Thread Anthony Liguori
On 11/21/2011 10:56 AM, Michael S. Tsirkin wrote: This fixes bugs dealing with msi-x mask bits pointed out by Jan Kiszka. Applied. Thanks. Regards, Anthony Liguori Jan Kiszka (1): msix: Prevent bogus mask updates on MMIO accesses Michael S. Tsirkin (2): msix: track function masked

[Qemu-devel] [PATCH][V2] Can't screendump without a console

2011-11-21 Thread Cao,Bing Bu
When usinge -vga none -nographic option. There is no any text and graphic console created in this case. screen dump not supported without console. Signed-off-by: Cao,Bing Bu m...@linux.vnet.ibm.com --- console.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Anthony Liguori
On 11/21/2011 11:03 AM, Peter Zijlstra wrote: On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote: In the original post of this mail thread, I proposed a way to export guest RAM ranges (Guest Physical Address-GPA) and their corresponding host host virtual mappings (Host Virtual Address-HVA)

Re: [Qemu-devel] [RFC PATCH] Exporting Guest RAM information for NUMA binding

2011-11-21 Thread Anthony Liguori
On 11/21/2011 04:50 PM, Chris Wright wrote: * Peter Zijlstra (a.p.zijls...@chello.nl) wrote: On Mon, 2011-11-21 at 21:30 +0530, Bharata B Rao wrote: In the original post of this mail thread, I proposed a way to export guest RAM ranges (Guest Physical Address-GPA) and their corresponding host

Re: [Qemu-devel] updating seabios to current release?

2011-11-21 Thread Anthony Liguori
On 11/21/2011 03:22 PM, Michael Tokarev wrote: Current version of seabios is 1.6.3, released several weeks ago. Compared with the version currently shipped in qemu, it adds a few commits, most of which are fixes for qemu-related issues. Maybe it's not too late to update seabios to the latest

[Qemu-devel] [PATCH] block:avoid deadlock in sheepdog.c

2011-11-21 Thread Dong Xu Wang
From: Dong Xu Wang wdon...@linux.vnet.ibm.com s-lock should be unlocked before leaving add_aio_request. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com --- block/sheepdog.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index

Re: [Qemu-devel] [PATCH] [ARM] Fix hw_error messages from arm_timer.c

2011-11-21 Thread Peter Chubb
Two of the calls to hw_error() in arm_timer.c contain the wrong function name. As suggested by Andreas Färber, use the C99 standard __func__ macro to get the correct name, instead of putting the name directly into the code. Signed-off-by: Peter Chubb peter.ch...@nicta.com.au ---

Re: [Qemu-devel] [PATCH] [ARM] Fix sp804 dual-timer

2011-11-21 Thread Peter Chubb
Properly implement dual-timer read/write for the sp804 dual timer module. Based on ARM specs at http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.ddi0271d/index.html Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: David Mirabito david.mirab...@nicta.com.au Signed-off-by:

[Qemu-devel] [PATCH V2 0/4] imx.31 and KZM board support

2011-11-21 Thread Peter Chubb
Here follow four patches in separate emails, to implement basic i.mx31 SoC support, and the KZM evaluation board built around this chip. The patch to the Makefile to build all the files is in the last of the series, rather than changing Makefile.hw in each patch. All comments received so far

Re: [Qemu-devel] [PATCH V2 1/4] imx.31 and KZM board support: UART support

2011-11-21 Thread Peter Chubb
Implement the FreeScale i.MX UART. This uart is used in a variety of SoCs, including some by Motorola, as well as in the FreeScale i.MX series. Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au ---

Re: [Qemu-devel] [PATCH V2 2/4] imx.31 and KZM board support: Timer support

2011-11-21 Thread Peter Chubb
Implement the timers on the FreeScale i.MX31 SoC. This is not a complete implementation, but gives enough for Linux to boot and run. Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- hw/imx_timer.c |

Re: [Qemu-devel] [PATCH V2 3/4] imx.31 and KZM board support: interrupt controller

2011-11-21 Thread Peter Chubb
Implement the FreeSCALE i.MX31 advanced vectored interrupt controller, at least to the extent it is used by Linux 3.0.x Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- hw/imx_avic.c | 363

Re: [Qemu-devel] [PATCH V2 4/4] imx.31 and KZM board support: Makefile and board

2011-11-21 Thread Peter Chubb
Board support for Kyoto Micro's KZM-ARM11-01, an evaluation board built around the FreeScale i.MX31. Signed-off-by: Hans Jang hsj...@ok-labs.com Signed-off-by: Adam Clench ad...@ok-labs.com Signed-off-by: Peter Chubb peter.ch...@nicta.com.au --- Makefile.target |2 hw/kzm.c| 155

Re: [Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode

2011-11-21 Thread Mark Wu
On 11/22/2011 02:00 AM, Paolo Bonzini wrote: Hours in 12-hour mode are in the 1-12 range, not 0-11. Interesting. I would like to know how you could find this problem. It seems linux driver never changes the format and 24-hour is default in rtc emulation code. So how did it expose and how to

Re: [Qemu-devel] [PATCH 1/4] rtc: fix 12-hour mode

2011-11-21 Thread Paolo Bonzini
On 11/22/2011 07:39 AM, Mark Wu wrote: Hours in 12-hour mode are in the 1-12 range, not 0-11. Interesting. I would like to know how you could find this problem. It seems linux driver never changes the format and 24-hour is default in rtc emulation code. So how did it expose and how to test it?

Re: [Qemu-devel] [SeaBIOS PATCH] usb: fix boot paths

2011-11-21 Thread Paolo Bonzini
On 11/18/2011 04:36 PM, Paolo Bonzini wrote: On 11/18/2011 03:59 PM, Paolo Bonzini wrote: The fw paths for USB devices that SeaBIOS computes are off-by-one, because QEMU builds those paths with a numbering that starts from one (see usb_fill_port and usb_hub_initfn in QEMU). Fix that so that the

Re: [Qemu-devel] updating seabios to current release?

2011-11-21 Thread Paolo Bonzini
On 11/22/2011 02:58 AM, Anthony Liguori wrote: Current version of seabios is 1.6.3, released several weeks ago. Compared with the version currently shipped in qemu, it adds a few commits, most of which are fixes for qemu-related issues. Maybe it's not too late to update seabios to the

Re: [Qemu-devel] [PATCH 1.0] 9pfs: improve portability to older systems

2011-11-21 Thread Paolo Bonzini
On 11/21/2011 10:01 PM, Anthony Liguori wrote: -return qemu_utimensat(AT_FDCWD, rpath(s, path, buffer), buf, - AT_SYMLINK_NOFOLLOW); +return qemu_utimens(rpath(s, path, buffer), buf); Hrm, I thought the SYMLINK_NOFOLLOW was critical in enforcing security?

<    1   2