[Qemu-devel] [PATCH] net: qomify -netdev

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- cpu-common.h | 13 +- hw/qdev-monitor.c |4 ++- hw/qdev.h |2 + net.c | 62 +++- net.h |

[Qemu-devel] [RFC 8/9] net: qomify -netdev vde

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/vde.c | 34 -- net/vde.h |4 ++-- 2 files changed, 34 insertions(+), 4 deletions(-) diff --git a/net/vde.c b/net/vde.c index 8d9e1c6..c06716d 100644 ---

[Qemu-devel] [RFC 5/9] net: adjust dump init API

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/dump.c |8 ++-- net/dump.h |3 +-- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/net/dump.c b/net/dump.c index 0f191d3..16e6efc 100644 --- a/net/dump.c +++

[Qemu-devel] [RFC 3/9] net: adjust net common part for qomify -netdev

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net.c | 108 +--- net.h |1 + vl.c | 12 +++--- 3 files changed, 109 insertions(+), 12 deletions(-) diff --git a/net.c b/net.c

[Qemu-devel] [RFC 9/9] net: qomify -netdev tap -netdev bridge

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/tap.c | 64 +--- net/tap.h |8 +++--- 2 files changed, 64 insertions(+), 8 deletions(-) diff --git a/net/tap.c b/net/tap.c index

[Qemu-devel] [RFC 2/9] net: introduce one net host device class

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net.c | 35 +++ net.h | 27 +++ 2 files changed, 62 insertions(+), 0 deletions(-) diff --git a/net.c b/net.c index dd67d16..608c090

[Qemu-devel] [RFC 7/9] net: qomify -netdev socket

2012-03-26 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu wu...@linux.vnet.ibm.com --- net/socket.c | 38 ++ net/socket.h |4 ++-- 2 files changed, 36 insertions(+), 6 deletions(-) diff --git a/net/socket.c b/net/socket.c index

Re: [Qemu-devel] [PATCH 3/6] convert pci-host to QOM

2012-03-26 Thread Stefan Hajnoczi
On Mon, Mar 26, 2012 at 10:06:45AM +0800, Wanpeng Li wrote: diff --git a/hw/pci_host.c b/hw/pci_host.c index 44c6c20..44d7e55 100644 --- a/hw/pci_host.c +++ b/hw/pci_host.c @@ -162,4 +162,30 @@ const MemoryRegionOps pci_host_data_be_ops = { .endianness = DEVICE_BIG_ENDIAN, };

[Qemu-devel] [PATCH 3/6] convert pci-host to QOM

2012-03-26 Thread y
From: Wanpeng Li l...@linux.vnet.ibm.com From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Wanpeng Li l...@linux.vnet.ibm.com --- hw/pci_host.c | 26 ++ hw/pci_host.h |5 + 2 files changed, 31

[Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {execute:blockdev-snapshot-sync,arguments:{device:ide0-hd0,snapshot-file:/tmp/backing.qcow2}} {error: {class: OpenFileFailed, desc: Could not open '/tmp/backing.qcow2',

Re: [Qemu-devel] Windows Virtio Issue

2012-03-26 Thread Vadim Rozenfeld
On Sunday, March 25, 2012 07:01:54 PM Yan Vugenfirer wrote: Hi Paul, Could you try reproducing this problem on -smp 2 guest, with small memory dump option turned on, instead of kernel memory dump. Thanks, Vadim. Hello Paul, Vadim is the owner of virtio-block Windows driver. He will try to

[Qemu-devel] [PATCH 3/6] convert pci-host to QOM

2012-03-26 Thread Wanpeng Li
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Wanpeng Li l...@linux.vnet.ibm.com --- hw/pci_host.c | 26 ++ hw/pci_host.h |5 + 2 files changed, 31 insertions(+), 0 deletions(-) diff --git

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Avi Kivity
On 03/25/2012 08:11 PM, Anthony Liguori wrote: I don't think -nodefconfig (as defined) is usable, since there is no way for the user to tell what it means short of reading those files. *if the user doesn't know specifics about this QEMU version. You make the assumption that all users are

Re: [Qemu-devel] [PATCH 3/6] convert pci-host to QOM

2012-03-26 Thread Wanpeng Li
On Mon, Mar 26, 2012 at 10:06:45AM +0800, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Wanpeng Li l...@linux.vnet.ibm.com --- hw/pci_host.c | 26 ++ hw/pci_host.h |5 + 2 files

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-26 Thread Michal Privoznik
On 25.03.2012 03:19, Brad Smith wrote: On 20/03/12 9:28 AM, Brad Smith wrote: On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break

[Qemu-devel] [PATCH] pc: reduce duplication in compat machine types

2012-03-26 Thread Michael S. Tsirkin
Make it easier to add compat properties, by adding macros for properties duplicated across machine types. Note: there could be bugs in compat properties, this patch does not attempt to address them, the code is bug for bug identical to the original. Tested by: generated a preprocessed file,

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-26 Thread Daniel P. Berrange
On Sat, Mar 24, 2012 at 04:29:26PM +0100, Christoph Hellwig wrote: On Wed, Mar 14, 2012 at 01:01:35PM +0100, Kevin Wolf wrote: Paolo mentioned a use case as a fast way for guests to write zeros, but is it really faster than a normal write when we have to emulate it by a bdrv_write with a

[Qemu-devel] console class in kvm

2012-03-26 Thread Michael S. Tsirkin
kvm used to carry this commit: commit 4667e6ec0df770867095d8093562d93c94d96ca2 Author: Avi Kivity a...@redhat.com Date: Thu Feb 12 11:43:17 2009 +0200 Change virtio-console to PCI_CLASS_OTHERS As a PCI_CLASS_DISPLAY_OTHER, it reduces primary display somehow on Windows XP

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Gleb Natapov
On Mon, Mar 26, 2012 at 11:08:16AM +0200, Avi Kivity wrote: Exactly. The types are no different, so there's no reason to discriminate against types that happen to live in qemu-provided data files vs. qemu code. They aren't instantiated, so we lose nothing by creating the factories (just

[Qemu-devel] [PATCH 00/12 v11] introducing a new, dedicated guest memory dump mechanism

2012-03-26 Thread Wen Congyang
Hi, all 'virsh dump' can not work when host pci device is used by guest. We have discussed this issue here: http://lists.nongnu.org/archive/html/qemu-devel/2011-10/msg00736.html The last version is here: http://lists.nongnu.org/archive/html/qemu-devel/2012-03/msg03866.html We have determined to

Re: [Qemu-devel] [RFC PATCH 06/17] block: use bdrv_{co, aio}_discard for write_zeroes operations

2012-03-26 Thread Christoph Hellwig
On Mon, Mar 26, 2012 at 10:44:07AM +0100, Daniel P. Berrange wrote: This suggests that there be a new command line param to '-drive' to turn discard support on/off, since QEMU can't reliably know if the raw file it is given is intended to be fully pre-allocated by the mgmt app. Yes.

[Qemu-devel] [PATCH 01/12 v11] Add API to create memory mapping list

2012-03-26 Thread Wen Congyang
The memory mapping list stores virtual address and physical address mapping. The virtual address and physical address are contiguous in the mapping. The folloing patch will use this information to create PT_LOAD in the vmcore. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- Makefile.target

[Qemu-devel] [PATCH 02/12 v12] Add API to check whether a physical address is I/O address

2012-03-26 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- cpu-common.h |2 ++ exec.c |9 + 2 files changed, 11 insertions(+), 0 deletions(-) diff --git a/cpu-common.h b/cpu-common.h index dca5175..fcd50dc 100644 --- a/cpu-common.h

[Qemu-devel] [PATCH 03/12 v11] implement cpu_get_memory_mapping()

2012-03-26 Thread Wen Congyang
Walk cpu's page table and collect all virtual address and physical address mapping. Then, add these mapping into memory mapping list. If the guest does not use paging, it will do nothing. Note: the I/O memory will be skipped. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- Makefile.target

[Qemu-devel] [PATCH 04/12 v11] Add API to check whether paging mode is enabled

2012-03-26 Thread Wen Congyang
This API will be used in the following patch. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- cpu-all.h |6 ++ target-i386/arch_memory_mapping.c |7 ++- 2 files changed, 12 insertions(+), 1 deletions(-) diff --git a/cpu-all.h b/cpu-all.h index

[Qemu-devel] [PATCH 05/12 v11] Add API to get memory mapping

2012-03-26 Thread Wen Congyang
Add API to get all virtual address and physical address mapping. If the guest doesn't use paging, the virtual address is equal to the phyical address. The virtual address and physical address mapping is for gdb's user, and it does not include the memory that is not referenced by the page table. So

[Qemu-devel] [PATCH 06/12 v11] Add API to get memory mapping without do paging

2012-03-26 Thread Wen Congyang
crash does not need the virtual address and physical address mapping, and the mapping does not include the memory that is not referenced by the page table. crash does not use the virtual address, so we can create the mapping for all physical memory(virtual address is always 0). This patch provides

[Qemu-devel] [PATCH 07/12 v11] target-i386: Add API to write elf notes to core file

2012-03-26 Thread Wen Congyang
The core file contains register's value. These APIs write registers to core file, and them will be called in the following patch. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- Makefile.target |1 + configure |4 + cpu-all.h | 23 +

[Qemu-devel] [PATCH 08/12 v11] target-i386: Add API to write cpu status to core file

2012-03-26 Thread Wen Congyang
The core file has register's value. But it does not include all registers value. Store the cpu status into QEMU note, and the user can get more information from vmcore. If you change QEMUCPUState, please count up QEMUCPUSTATE_VERSION. Signed-off-by: Wen Congyang we...@cn.fujitsu.com ---

[Qemu-devel] [PATCH 09/12 v11] target-i386: add API to get dump info

2012-03-26 Thread Wen Congyang
Dump info contains: endian, class and architecture. The next patch will use these information to create vmcore. Note: on x86 box, the class is ELFCLASS64 if the memory is larger than 4G. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- cpu-all.h |7 +++ dump.h

[Qemu-devel] [PATCH 10/12 v11] make gdb_id() generally avialable and rename it to cpu_index()

2012-03-26 Thread Wen Congyang
The following patch also needs this API, so make it generally avialable. The function gdb_id() will not be used in gdbstub.c now, so its name is not suitable, and rename it to cpu_index() Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- gdbstub.c | 19 +-- gdbstub.h |9

[Qemu-devel] [PATCH 11/12 v11] QError: Introduce new error for the dump-guest-memory command

2012-03-26 Thread Wen Congyang
The new error is QERR_PIPE_OR_SOCKET_FD, which is going to be used by the QAPI dump-guest-memory command. Signed-off-by: Wen Congyang we...@cn.fujitsu.com --- qerror.c |4 qerror.h |3 +++ 2 files changed, 7 insertions(+), 0 deletions(-) diff --git a/qerror.c b/qerror.c index

Re: [Qemu-devel] buildbot failure in qemu on default_i386_debian_6_0

2012-03-26 Thread Stefan Hajnoczi
On Sun, Mar 25, 2012 at 11:04 AM, Daniel Gollub gol...@b1-systems.de wrote: I finally added make check to the default factory. Note, if the make check fails the mail will state: BUILD FAILED: failed test It's failing on yuzuki due to missing bc. Could you install bc on your buildslave?

[Qemu-devel] [PATCH 12/12 v11] introduce a new monitor command 'dump-guest-memory' to dump guest's memory

2012-03-26 Thread Wen Congyang
The command's usage: dump [-p] protocol [begin] [length] The supported protocol can be file or fd: 1. file: the protocol starts with file:, and the following string is the file's path. 2. fd: the protocol starts with fd:, and the following string is the fd's name. Note: 1. If you want

[Qemu-devel] KVM call agenda for Tuesday 27

2012-03-26 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

Re: [Qemu-devel] Thoughts around dtrace linking...

2012-03-26 Thread Stefan Hajnoczi
On Fri, Mar 23, 2012 at 2:11 PM, Lee Essen lee.es...@nowonline.co.uk wrote: On 23 Mar 2012, at 08:08, Stefan Hajnoczi wrote: On Thu, Mar 22, 2012 at 05:00:53PM +, Lee Essen wrote: On 22/03/2012 16:28, Stefan Hajnoczi wrote: On Wed, Mar 21, 2012 at 1:01 PM, Andreas Färberafaer...@suse.de  

Re: [Qemu-devel] console class in kvm

2012-03-26 Thread Avi Kivity
On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: kvm used to carry this commit: Used to? Which commit reverts this? commit 4667e6ec0df770867095d8093562d93c94d96ca2 Author: Avi Kivity a...@redhat.com Date: Thu Feb 12 11:43:17 2009 +0200 Change virtio-console to PCI_CLASS_OTHERS

Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook

2012-03-26 Thread Stefano Stabellini
On Sun, 25 Mar 2012, Avi Kivity wrote: On 03/23/2012 06:37 PM, Jan Kiszka wrote: On 2012-03-23 16:08, Julien Grall wrote: On 03/22/2012 05:44 PM, Jan Kiszka wrote: static void core_region_nop(MemoryListener *listener, diff --git a/ioport.c b/ioport.c index 78a3b89..073ed75

Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:01 PM, Stefano Stabellini wrote: On Sun, 25 Mar 2012, Avi Kivity wrote: On 03/23/2012 06:37 PM, Jan Kiszka wrote: On 2012-03-23 16:08, Julien Grall wrote: On 03/22/2012 05:44 PM, Jan Kiszka wrote: static void core_region_nop(MemoryListener *listener, diff

Re: [Qemu-devel] console class in kvm

2012-03-26 Thread Michael S. Tsirkin
On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: kvm used to carry this commit: Used to? Which commit reverts this? A merge from qemu.git I would guess. git log does not seem to show the culprit, I don't know how to find it.

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Jiri Denemark
On Sun, Mar 25, 2012 at 10:26:57 -0500, Anthony Liguori wrote: On 03/25/2012 10:16 AM, Avi Kivity wrote: On 03/25/2012 04:59 PM, Anthony Liguori wrote: So how about: 1) Load ['@SYSCONFDIR@/qemu/qemu.cfg', '@SYSCONFDIR@/qemu/target-@ARCH@.cfg', '@DATADIR@/system.cfg',

Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook

2012-03-26 Thread Julien Grall
On 03/26/2012 12:02 PM, Avi Kivity wrote: On 03/26/2012 01:01 PM, Stefano Stabellini wrote: On Sun, 25 Mar 2012, Avi Kivity wrote: On 03/23/2012 06:37 PM, Jan Kiszka wrote: On 2012-03-23 16:08, Julien Grall wrote: On 03/22/2012 05:44 PM, Jan Kiszka wrote:

Re: [Qemu-devel] [Qemu-trivial] [PATCH] trace-events: Fix broken build caused by wrong format specifier

2012-03-26 Thread Stefan Hajnoczi
On Sat, Mar 24, 2012 at 08:13:34AM +0100, Stefan Weil wrote: mem is an uint64_t value, so %lx was wrong. Signed-off-by: Stefan Weil s...@weilnetz.de --- trace-events |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Normally build fixes are sent directly to qemu.git/master

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Sun, 25 Mar 2012, Avi Kivity wrote: On 03/23/2012 01:02 PM, Stefano Stabellini wrote: Maybe the best thing to do is to have a set of machine specific options to select what devices need to be built in the machine. Most devices already can be dynamically selected: NICs, usb, acpi,

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-26 Thread Peter Maydell
On 24 March 2012 18:58, Blue Swirl blauwir...@gmail.com wrote: v2: fix patch 1, tweak patch 2 and rebase to master. URL     git://repo.or.cz/qemu/blueswirl.git        http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6):  arm: move neon_tbl to neon_helper.c  arm: move saturating

Re: [Qemu-devel] [RFC 0/9] QOM: qomify -netdev

2012-03-26 Thread Stefan Hajnoczi
On Mon, Mar 26, 2012 at 6:40 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Sending the patchset is mainly intended to get some comments and void the wrong development direction. The patchset is used to qomify -netdev, but it introduce one infrastructure for

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:45 PM, Stefano Stabellini wrote: Now the problem is: there isn't a simple way to specify the BDF where you want to create the device; pci_create_simple takes a devfn but most of the higher level functions (pc_vga_init, pci_nic_init_nofail, ...) don't export the

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig. -no-user-config solves this but I fully expect libvirt would continue to use -nodefconfig. Libvirt uses -nodefaults -nodefconfig because it wants to fully control how the

Re: [Qemu-devel] [libvirt] Modern CPU models cannot be used with libvirt

2012-03-26 Thread Gleb Natapov
On Mon, Mar 26, 2012 at 01:59:05PM +0200, Avi Kivity wrote: On 03/26/2012 01:24 PM, Jiri Denemark wrote: ... The command line becomes unstable if you use -nodefconfig. -no-user-config solves this but I fully expect libvirt would continue to use -nodefconfig. Libvirt uses

[Qemu-devel] [PATCH 1/5] vl.c: fix '-cpu ?' segfault

2012-03-26 Thread Stefan Hajnoczi
From: Eduardo Habkost ehabk...@redhat.com Fix stupid copypaste mistake at commit ecf40beae7dcbb057d4f115207f9d8276832a774: I moved code around but kept optarg on the cpu_list() call. Reported-by: Jiri Denemark jdene...@redhat.com Signed-off-by: Eduardo Habkost ehabk...@redhat.com Signed-off-by:

[Qemu-devel] [PATCH 3/5] qapi: remove print statements from test-qmp-commands

2012-03-26 Thread Stefan Hajnoczi
From: Michael Roth mdr...@linux.vnet.ibm.com This is necessary for nicer make check integration. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- test-qmp-commands.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-)

[Qemu-devel] [PATCH 2/5] test: remove qemu-ga reference

2012-03-26 Thread Stefan Hajnoczi
From: Michael Roth mdr...@linux.vnet.ibm.com This was added by mistake a while back. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- Makefile |1 + tests/Makefile |2 +- 2 files changed, 2 insertions(+), 1

[Qemu-devel] [PATCH 4/5] test: add test-qmp-commands to make check

2012-03-26 Thread Stefan Hajnoczi
From: Michael Roth mdr...@linux.vnet.ibm.com All the deps are here but the test was never added to the list of tests for make check Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- tests/Makefile |1 + 1 files changed, 1

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Mon, 26 Mar 2012, Avi Kivity wrote: You may want your own host/pci bridge that lacks the device 0 configuration space. In order not to disrupt the emulated machine in QEMU too much, I was thinking to let QEMU create the default device 0 and device 1: 00:00.0 Host bridge: Intel

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 03/15] hvm-pci: Handle PCI config space in Xen

2012-03-26 Thread Julien Grall
On 03/23/2012 08:29 AM, Jan Beulich wrote: Is there a reasonably low enforced boundary on the number of devices? Otherwise, a linear lookup would seem overly simple to me. The maximum of bdf is 2^16 = 65536. Which kind of structure do you advice ? Array ? Hash Table ? Further, with how

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Jan Kiszka
On 2012-03-26 04:06, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com This series aggressively refactors the PC machine initialization to be more modelled and less ad-hoc. The highlights of this series are: 1) Things like -m and -bios-name are now device model properties

[Qemu-devel] [PATCH v2] pcnet: Properly handle TX requests during Link Fail

2012-03-26 Thread Jan Kiszka
As long as we have no link and we aren't in internal loopback mode, no packet must be sent. Instead, LCAR needs to be set in any active TX descriptor and also CERR in CSR0. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- Change in v2: - We were lacking a reset of xmit_pos in case of a

[Qemu-devel] [PATCH 5/5] trace-events: Fix broken build caused by wrong format specifier

2012-03-26 Thread Stefan Hajnoczi
From: Stefan Weil s...@weilnetz.de mem is an uint64_t value, so %lx was wrong. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Stefan Hajnoczi stefa...@linux.vnet.ibm.com --- trace-events |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/trace-events

Re: [Qemu-devel] console class in kvm

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote: On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: kvm used to carry this commit: Used to? Which commit reverts this? A merge from qemu.git I would guess. git log does not

[Qemu-devel] [PATCH] ehci: fix ehci_child_detach

2012-03-26 Thread Gerd Hoffmann
Looks like a cut+paste bug from ehci_detach. When the device itself is detached from a ehci port (ehci_detach op) we have to clear the device pointer for the companion port too. When a device gets removed from a downstream port of a usb hub (ehci_child_detach op) the ehci port where the usb hub

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server

2012-03-26 Thread Julien Grall
On 03/23/2012 08:18 AM, Jan Beulich wrote: +#define HVMOP_register_pcidev 24 +struct xen_hvm_register_pcidev { +domid_t domid;/* IN - domain to be serviced */ +servid_t id; /* IN - handle from HVMOP_register_ioreq_server */ +uint16_t bdf; /* IN - pci */

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Avi Kivity
On 03/26/2012 02:20 PM, Stefano Stabellini wrote: On Mon, 26 Mar 2012, Avi Kivity wrote: You may want your own host/pci bridge that lacks the device 0 configuration space. In order not to disrupt the emulated machine in QEMU too much, I was thinking to let QEMU create the default

Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix broken build caused by wrong format specifier

2012-03-26 Thread Andreas Färber
Am 26.03.2012 14:07, schrieb Stefan Hajnoczi: From: Stefan Weil s...@weilnetz.de mem is an uint64_t value, so %lx was wrong. Signed-off-by: Stefan Weil s...@weilnetz.de Alon, you replied with an ACK. Should an Acked-by be inserted here? Andreas Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 5/6] merge pc_piix.c to pc.c

2012-03-26 Thread Avi Kivity
On 03/26/2012 04:06 AM, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com @@ -889,7 +900,7 @@ static DeviceState *apic_init(void *env, uint8_t apic_id) DeviceState *dev; static int apic_mapped; -if (kvm_irqchip_in_kernel()) { +if (kvm_enabled()

Re: [Qemu-devel] [PATCH] ehci: fix ehci_child_detach

2012-03-26 Thread Hans de Goede
Hi, Oh, good one: Acked-by: Hans de Goede hdego...@redhat.com Regards, Hans On 03/26/2012 02:32 PM, Gerd Hoffmann wrote: Looks like a cut+paste bug from ehci_detach. When the device itself is detached from a ehci port (ehci_detach op) we have to clear the device pointer for the companion

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf kw...@redhat.com wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {execute:blockdev-snapshot-sync,arguments:{device:ide0-hd0,snapshot-file:/tmp/backing.qcow2}}

Re: [Qemu-devel] Windows Virtio Issue

2012-03-26 Thread Paul Fisher
On 26 March 2012 09:50, Vadim Rozenfeld vroze...@redhat.com wrote: On Sunday, March 25, 2012 07:01:54 PM Yan Vugenfirer wrote: Hi Paul, Could you try reproducing this problem on -smp 2 guest, with small memory dump option turned on, instead of kernel memory dump. Thanks, Vadim. Hi

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-26 Thread Lluís Vilanova
Peter Maydell writes: On 24 March 2012 18:58, Blue Swirl blauwir...@gmail.com wrote: v2: fix patch 1, tweak patch 2 and rebase to master. URL     git://repo.or.cz/qemu/blueswirl.git        http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6):  arm: move neon_tbl to neon_helper.c  arm:

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Andreas Färber
Am 26.03.2012 04:06, schrieb Wanpeng Li: From: Anthony Liguori aligu...@us.ibm.com Resending an old cover letter is not a good idea. This looks like a v2, so please mark it as such in the subjects; it's missing a Change Log against Anthony's version. I take it, some patches were dropped? This

[Qemu-devel] [PATCH qemu+spice] expose server mouse status

2012-03-26 Thread Alon Levy
Below are the combined summaries. This lets the current mouse mode the server is using be shown to qemu users: (qemu) info spice Server: address: 0.0.0.0:10005 auth: none compiled: 0.10.2 mouse-mode: server qemu: Alon Levy (1): spice_info: add mouse_mode hmp.c

Re: [Qemu-devel] [PATCH 5/6] merge pc_piix.c to pc.c

2012-03-26 Thread Jan Kiszka
On 2012-03-26 14:42, Avi Kivity wrote: On 03/26/2012 04:06 AM, Wanpeng Li wrote: From: Anthony Liguori aligu...@us.ibm.com @@ -889,7 +900,7 @@ static DeviceState *apic_init(void *env, uint8_t apic_id) DeviceState *dev; static int apic_mapped; -if (kvm_irqchip_in_kernel()) {

[Qemu-devel] [PATCH] server: export spice_server_is_server_mouse predicate

2012-03-26 Thread Alon Levy
To be used by qemu query-spice / info spice commands. --- server/reds.c|6 ++ server/spice-server.syms |4 server/spice.h |4 +++- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/server/reds.c b/server/reds.c index 27e7ea2..bf26864 100644

[Qemu-devel] [PATCH] spice_info: add mouse_mode

2012-03-26 Thread Alon Levy
Add mouse_mode, either server or mouse, to qmp and hmp commands, based on spice_server_is_server_mouse added in spice-server 0.10.3. Signed-off-by: Alon Levy al...@redhat.com --- hmp.c|2 ++ qapi-schema.json |7 ++- ui/spice-core.c |5 + 3 files changed, 13

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-26 Thread Andreas Färber
Am 26.03.2012 14:46, schrieb Lluís Vilanova: Peter Maydell writes: On 24 March 2012 18:58, Blue Swirl blauwir...@gmail.com wrote: v2: fix patch 1, tweak patch 2 and rebase to master. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6):

Re: [Qemu-devel] [PATCH 5/5] trace-events: Fix broken build caused by wrong format specifier

2012-03-26 Thread Alon Levy
On Mon, Mar 26, 2012 at 02:41:23PM +0200, Andreas Färber wrote: Am 26.03.2012 14:07, schrieb Stefan Hajnoczi: From: Stefan Weil s...@weilnetz.de mem is an uint64_t value, so %lx was wrong. Signed-off-by: Stefan Weil s...@weilnetz.de Alon, you replied with an ACK. Should an Acked-by

Re: [Qemu-devel] [PATCH] pc: reduce duplication in compat machine types

2012-03-26 Thread Avi Kivity
On 03/26/2012 11:40 AM, Michael S. Tsirkin wrote: Make it easier to add compat properties, by adding macros for properties duplicated across machine types. Note: there could be bugs in compat properties, this patch does not attempt to address them, the code is bug for bug identical to the

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 03/15] hvm-pci: Handle PCI config space in Xen

2012-03-26 Thread Jan Beulich
On 26.03.12 at 14:20, Julien Grall julien.gr...@citrix.com wrote: On 03/23/2012 08:29 AM, Jan Beulich wrote: Is there a reasonably low enforced boundary on the number of devices? Otherwise, a linear lookup would seem overly simple to me. The maximum of bdf is 2^16 = 65536. Which kind

Re: [Qemu-devel] [Xen-devel] [XEN][RFC PATCH 01/15] hvm: Modify interface to support multiple ioreq server

2012-03-26 Thread Jan Beulich
On 26.03.12 at 14:32, Julien Grall julien.gr...@citrix.com wrote: On 03/23/2012 08:18 AM, Jan Beulich wrote: +#define HVMOP_register_pcidev 24 +struct xen_hvm_register_pcidev { +domid_t domid;/* IN - domain to be serviced */ +servid_t id; /* IN - handle from

Re: [Qemu-devel] [Spice-devel] [PATCH qemu+spice] expose server mouse status

2012-03-26 Thread Arnon Gilboa
ACK series Acked-by: Arnon Gilboa agil...@redhat.com Alon Levy wrote: Below are the combined summaries. This lets the current mouse mode the server is using be shown to qemu users: (qemu) info spice Server: address: 0.0.0.0:10005 auth: none compiled: 0.10.2 mouse-mode:

Re: [Qemu-devel] [PATCH 0/6] refactor PC machine, i440fx and piix3 to take advantage of QOM

2012-03-26 Thread Wanpeng Li
On Mon, Mar 26, 2012 at 02:47:19PM +0200, Andreas Färber wrote: Am 26.03.2012 04:06, schrieb Wanpeng Li: From: Anthony Liguori aligu...@us.ibm.com Resending an old cover letter is not a good idea. This looks like a v2, so please mark it as such in the subjects; it's missing a Change Log against

Re: [Qemu-devel] [PATCH v2 0/6] ARM: AREG0 conversion

2012-03-26 Thread Paul Brook
On 24 March 2012 18:58, Blue Swirl blauwir...@gmail.com wrote: v2: fix patch 1, tweak patch 2 and rebase to master. URL git://repo.or.cz/qemu/blueswirl.git http://repo.or.cz/r/qemu/blueswirl.git Blue Swirl (6): arm: move neon_tbl to neon_helper.c arm: move

Re: [Qemu-devel] [PATCH] spice_info: add mouse_mode

2012-03-26 Thread Gerd Hoffmann
+#if SPICE_SERVER_VERSION = 0x000a03 /* 0.10.3 */ +info-has_mouse_mode = true; +info-mouse_mode = g_strdup(spice_server_is_server_mouse(spice_server) ? +server : client); #else info-mouse_mode = unknown; #endif cheers,

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 14:46, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf kw...@redhat.com wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here:

Re: [Qemu-devel] [PATCH] pc: reduce duplication in compat machine types

2012-03-26 Thread Andreas Färber
Am 26.03.2012 11:40, schrieb Michael S. Tsirkin: Make it easier to add compat properties, by adding macros for properties duplicated across machine types. Note: there could be bugs in compat properties, this patch does not attempt to address them, the code is bug for bug identical to the

Re: [Qemu-devel] [QEMU][RFC PATCH 3/6] memory: Add xen memory hook

2012-03-26 Thread Avi Kivity
On 03/26/2012 01:24 PM, Julien Grall wrote: It looks like there are quite a few register_ioport_read/write left around, especially in the following files: hw/acpi_piix4.c hw/cirrus_vga.c hw/serial.c hw/pckbd.c hw/pc.c I guess they should all be converted to memory_region_init_io, right?

Re: [Qemu-devel] [PATCH] pc: reduce duplication in compat machine types

2012-03-26 Thread Michael S. Tsirkin
On Mon, Mar 26, 2012 at 03:12:37PM +0200, Andreas Färber wrote: Am 26.03.2012 11:40, schrieb Michael S. Tsirkin: Make it easier to add compat properties, by adding macros for properties duplicated across machine types. Note: there could be bugs in compat properties, this patch does

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Luiz Capitulino
On Mon, 26 Mar 2012 15:13:36 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.03.2012 14:46, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf kw...@redhat.com wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very

Re: [Qemu-devel] [PATCH] spice_info: add mouse_mode

2012-03-26 Thread Alon Levy
On Mon, Mar 26, 2012 at 03:06:22PM +0200, Gerd Hoffmann wrote: +#if SPICE_SERVER_VERSION = 0x000a03 /* 0.10.3 */ +info-has_mouse_mode = true; +info-mouse_mode = g_strdup(spice_server_is_server_mouse(spice_server) ? +server

Re: [Qemu-devel] [PATCH] pc: reduce duplication in compat machine types

2012-03-26 Thread Michael S. Tsirkin
On Mon, Mar 26, 2012 at 02:51:38PM +0200, Avi Kivity wrote: On 03/26/2012 11:40 AM, Michael S. Tsirkin wrote: Make it easier to add compat properties, by adding macros for properties duplicated across machine types. Note: there could be bugs in compat properties, this patch does not

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 03:39 AM, Kevin Wolf wrote: Hi, I keep getting reports of problems, with nice error descriptions that usually look very similar to what I produced here: {execute:blockdev-snapshot-sync,arguments:{device:ide0-hd0,snapshot-file:/tmp/backing.qcow2}} {error: {class: OpenFileFailed,

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Anthony Liguori
On 03/26/2012 08:28 AM, Luiz Capitulino wrote: On Mon, 26 Mar 2012 15:13:36 +0200 Kevin Wolfkw...@redhat.com wrote: Am 26.03.2012 14:46, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolfkw...@redhat.com wrote: Hi, I keep getting reports of problems, with nice error

Re: [Qemu-devel] console class in kvm

2012-03-26 Thread Avi Kivity
On 03/26/2012 03:37 PM, Michael S. Tsirkin wrote: Exactly. qemu-kvm used to set the class to CLASS_OTHER while the current code sets it to PCI_CLASS_COMMUNICATION_OTHER. Do we want support for CLASS_OTHER or is it ok to drop it? Looks like starting with qemu-kvm-0.11, qemu-kvm matches qemu.

Re: [Qemu-devel] [PATCH] spice_info: add mouse_mode

2012-03-26 Thread Gerd Hoffmann
On 03/26/12 15:30, Alon Levy wrote: On Mon, Mar 26, 2012 at 03:06:22PM +0200, Gerd Hoffmann wrote: +#if SPICE_SERVER_VERSION = 0x000a03 /* 0.10.3 */ +info-has_mouse_mode = true; +info-mouse_mode = g_strdup(spice_server_is_server_mouse(spice_server) ? +

[Qemu-devel] [PATCH RFC 3/3] qdev: Hook up DeviceClass::init to ObjectClass::realize

2012-03-26 Thread Andreas Färber
On realize, call the qdev init function. If that returns an error, raise QERR_DEVICE_INIT_FAILED. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori anth...@codemonkey.ws Cc: Paolo Bonzini pbonz...@redhat.com --- hw/qdev.c | 13 + 1 files changed, 13 insertions(+),

[Qemu-devel] [PATCH RFC 2/3] qom: Introduce object_realize()

2012-03-26 Thread Andreas Färber
Wrap setting of Object::realized property, error reporting and exit(1) into a helper function. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Anthony Liguori anth...@codemonkey.ws Cc: Paolo Bonzini pbonz...@redhat.com --- include/qemu/object.h |9 + qom/object.c | 11

Re: [Qemu-devel] [PATCH RFC 3/3] qdev: Hook up DeviceClass::init to ObjectClass::realize

2012-03-26 Thread Andreas Färber
Am 26.03.2012 15:46, schrieb Andreas Färber: On realize, call the qdev init function. If that returns an error, raise QERR_DEVICE_INIT_FAILED. Sorry, that sentence is outdated - the error is set in qom/object.c (patch 1/3) for non-zero return values. It is merely being passed through here.

Re: [Qemu-devel] [QEMU][RFC PATCH 4/6] xen-pci: Register PCI in Xen

2012-03-26 Thread Stefano Stabellini
On Mon, 26 Mar 2012, Avi Kivity wrote: What about if two BARs (from different devices) are configured for the same address ranges? I think that it should have the same chance of happening as if there was just one QEMU, because from the guest OS and firmware POV the emulated hardware

Re: [Qemu-devel] Ignoring errno makes QMP errors suck

2012-03-26 Thread Kevin Wolf
Am 26.03.2012 15:28, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 15:13:36 +0200 Kevin Wolf kw...@redhat.com wrote: Am 26.03.2012 14:46, schrieb Luiz Capitulino: On Mon, 26 Mar 2012 10:39:50 +0200 Kevin Wolf kw...@redhat.com wrote: Hi, I keep getting reports of problems, with nice error

Re: [Qemu-devel] console class in kvm

2012-03-26 Thread Michael S. Tsirkin
On Mon, Mar 26, 2012 at 02:29:58PM +0200, Avi Kivity wrote: On 03/26/2012 01:19 PM, Michael S. Tsirkin wrote: On Mon, Mar 26, 2012 at 12:18:54PM +0200, Avi Kivity wrote: On 03/26/2012 11:48 AM, Michael S. Tsirkin wrote: kvm used to carry this commit: Used to? Which commit reverts

Re: [Qemu-devel] [RFC 0/9] QOM: qomify -netdev

2012-03-26 Thread Zhi Yong Wu
On Mon, Mar 26, 2012 at 7:54 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Mar 26, 2012 at 6:40 AM,  zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Sending the patchset is mainly intended to get some comments and void the wrong development direction. The

  1   2   3   >