Re: [Qemu-devel] [PATCH] Fix for qemu crash on assertion error when adding PCI passthru device.

2012-06-18 Thread Jan Kiszka
On 2012-06-17 16:28, Anthony Liguori wrote: On 06/17/2012 03:34 AM, Michael S. Tsirkin wrote: On Sun, Jun 17, 2012 at 06:26:33AM +, Ma, Stephen B. wrote: Michael, Thanks for the review. I added the unparent to the qdev_free. --- hw/qdev.c |1 + 1 files changed, 1

[Qemu-devel] [Bug 538908] Re: qemu-system-cris crashes after a few seconds

2012-06-18 Thread Ken Sharp
Fixed in Natty+ ** Changed in: qemu (Ubuntu) Status: New = Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/538908 Title: qemu-system-cris crashes after a few seconds Status in

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Wei-Ren Chen
The idea looks nice, but instead of different TLB functions selected at configure time, the optimization should be enabled by default. Maybe a 'call' instruction could be used to jump to the slow path, that way the slow path could be shared. I don't understand what maybe a 'call'

Re: [Qemu-devel] [PATCHv2 00/13] unicore32: add softmmu support and puv3 machine

2012-06-18 Thread Wei-Ren Chen
Yes. But how to do that. I can't find the upload location or someone who receives the image. Perhaps someone can open a wiki account for you, so that you can upload an image. Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica,

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Jan Kiszka
On 2012-06-14 23:31, Michael S. Tsirkin wrote: On Thu, Jun 14, 2012 at 12:15:42PM -0600, Alex Williamson wrote: v3: - more patches, smaller diff, must be headed in the right direction - macros for all hardcoded values in msix_init_exclusive_bar - fold msix_add_config into msix_init

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Michael S. Tsirkin
On Mon, Jun 18, 2012 at 09:06:01AM +0200, Jan Kiszka wrote: On 2012-06-14 23:31, Michael S. Tsirkin wrote: On Thu, Jun 14, 2012 at 12:15:42PM -0600, Alex Williamson wrote: v3: - more patches, smaller diff, must be headed in the right direction - macros for all hardcoded values in

[Qemu-devel] [RFC] ARMCPU: Halting a CPU from Device Land

2012-06-18 Thread Peter Crosthwaite
Hi Andreas, For the Xilinx Zynq platform, we need to be able to halt a CPU from a device (the zynq_slcr). E.G, if I write a 1 to a register bit in my device, then that device effects a halt of a CPU. Looking at the QOM stuff the API for a CPU is (include/qemu/cpu.h): typedef struct CPUClass {

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Markus Armbruster
Li Zhang zhlci...@gmail.com writes: On Fri, Jun 15, 2012 at 10:34 PM, Markus Armbruster arm...@redhat.com wrote: Li Zhang zhlci...@gmail.com writes: On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster arm...@redhat.com wrote: Li Zhang zhlci...@linux.vnet.ibm.com writes: For pseries

[Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-18 Thread Wei-Ren Chen
Hi all, Say I want to print env-some_field in vl.c. I #include dyngen-exec.h in vl.c, but got compilation error immediately. /tmp/chenwj/qemu/dyngen-exec.h:64:10: error: attempt to use poisoned CPUArchState /tmp/chenwj/qemu/dyngen-exec.h:64:23: error: expected '=', ',', ';', 'asm' or

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Peter Crosthwaite
3. Can't have USB: fail if the user tries to enable it. Code sketch:    /* init USB devices */    if (!machine-has_usb) {        if (usb_enabled)            [report error; should point to the offending options]            exit(1);        }    } else {        if (machine-has_usb 0) {

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
On Mon, Jun 18, 2012 at 3:29 PM, Markus Armbruster arm...@redhat.com wrote: Li Zhang zhlci...@gmail.com writes: On Fri, Jun 15, 2012 at 10:34 PM, Markus Armbruster arm...@redhat.com wrote: Li Zhang zhlci...@gmail.com writes: On Fri, Jun 15, 2012 at 8:04 PM, Markus Armbruster

Re: [Qemu-devel] [PATCH v3 3/5] osdep: Enable qemu_open to dup pre-opened fd

2012-06-18 Thread Kevin Wolf
Am 15.06.2012 22:00, schrieb Eric Blake: On 06/15/2012 01:19 PM, Corey Bryant wrote: There are some flags that I don't think we'll be able to change. For example: O_RDONLY, O_WRONLY, O_RDWR. I assume libvirt would open all files O_RDWR. I think we need to check all of them and fail

Re: [Qemu-devel] [PATCHv2 1/1] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
On Mon, Jun 18, 2012 at 3:54 PM, Peter Crosthwaite peter.crosthwa...@petalogix.com wrote: 3. Can't have USB: fail if the user tries to enable it. Code sketch:    /* init USB devices */    if (!machine-has_usb) {        if (usb_enabled)            [report error; should point to the

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 07:06:10PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 8:30 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Jun 13, 2012 at 04:20:22PM -0300, Eduardo Otubo wrote: I added a syscall struct using priority levels as described in the libseccomp man page.

Re: [Qemu-devel] How to measure guest memory access (qemu_ld/qemu_st) time?

2012-06-18 Thread Wei-Ren Chen
The reason why we want to do the measuring is we want to use KVM (sounds crazy idea) MMU virtualization to speedup the guest - host memory address translation. I talked to some people on LinuxCon Japan, included Paolo, about this idea. The feedback I got is we can only use shadow page

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would render seccomp pretty much useless. Not necessarily. I'll agree that it does seem a bit odd to allow execve(), but there is still value in

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Fri, Jun 15, 2012 at 07:04:45PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 8:33 PM, Daniel P. Berrange berra...@redhat.com wrote: On Wed, Jun 13, 2012 at 07:56:06PM +, Blue Swirl wrote: On Wed, Jun 13, 2012 at 7:20 PM, Eduardo Otubo ot...@linux.vnet.ibm.com wrote: I added

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 09:31:03AM +0100, Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would render seccomp pretty much useless. Not necessarily. I'll agree

Re: [Qemu-devel] How to management KVM virtual machines via libvirt?

2012-06-18 Thread Daniel P. Berrange
On Sat, Jun 16, 2012 at 08:00:00PM +0800, 陳韋任 (Wei-Ren Chen) wrote: CC'ed to libvirt-users. On Sat, Jun 16, 2012 at 07:00:59PM +0800, GaoYi wrote: Hi all,      I am trying to management the VMs created by KVM commandline. However, I found the libvirt cannot connect to the VMs or

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Jan Kiszka
On 2012-06-18 02:32, Andreas Färber wrote: Am 18.06.2012 02:01, schrieb Anthony Liguori: I think I understand enough of what's going on in these rules to ensure this is right. But I could certainly use a second or third opinion... Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- v1

[Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Li Zhang
For pseries machine, it needs to enable usb to add keyboard or usb mouse. -usb option won't be used in the future, and machine options is a better way to enable usb. So this patch is to add usb option to machine options (-machine type=psereis,usb=on/off)to enable/disable usb controller. For

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Jan Kiszka
On 2012-06-18 09:19, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 09:06:01AM +0200, Jan Kiszka wrote: On 2012-06-14 23:31, Michael S. Tsirkin wrote: On Thu, Jun 14, 2012 at 12:15:42PM -0600, Alex Williamson wrote: v3: - more patches, smaller diff, must be headed in the right direction

Re: [Qemu-devel] [PATCH 1/2] Add usb option in machine options to enable/disable usb

2012-06-18 Thread Wei-Ren Chen
Hi Li Zhang, Perhaps you miss [PATCH v3 1/2] in the subject? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Academia Sinica, Taiwan (R.O.C.) Tel:886-2-2788-3799 #1667 Homepage: http://people.cs.nctu.edu.tw/~chenwj

[Qemu-devel] [PATCHv3 02/14] unicore32-softmmu: Add coprocessor 0(sysctrl) and 1(ocd) instruction support

2012-06-18 Thread Guan Xuetao
Coprocessor 0 is system control coprocessor, and we need get/set its contents. Also, all cache/tlb ops shoule be implemented here, but just ignored with no harm. Coprocessor 1 is OCD (on-chip-debugger), which is used for faked console, so we could output chars to this console without graphic

[Qemu-devel] [PATCHv3 04/14] target-unicore32: Drop UC32_CPUID macros

2012-06-18 Thread Guan Xuetao
From: Andreas Färber afaer...@suse.de Any code that depends on a particular CPU type can now go through callbacks on the QOM UniCore32CPUClass. Signed-off-by: Andreas Färber afaer...@suse.de Acked-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/cpu.h |4 1 files changed, 0

[Qemu-devel] [PATCHv3 01/14] unicore32-softmmu: Add unicore32-softmmu build support

2012-06-18 Thread Guan Xuetao
This patch adds unicore32-softmmu build support, include configure, makefile, arch_init, and all missing functions needed by softmmu. Although all missing functions are empty, unicore32-softmmu could be build successfully. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- arch_init.c

[Qemu-devel] [PATCHv3 08/14] unicore32-softmmu: Add puv3 interrupt support

2012-06-18 Thread Guan Xuetao
This patch adds puv3 interrupt support, include interrupt controler device simulation and interrupt handler in puv3 machine. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/Makefile.objs |3 + hw/puv3.c| 23 +- hw/puv3_intc.c | 135

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Peter Maydell
On 18 June 2012 10:13, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-06-18 02:32, Andreas Färber wrote: This will work technically but I still feel this is wrong semantically. The pre-Paolo and current way is picking specific files from the hw/kvm/ directory. Your change above implies that

[Qemu-devel] [PATCH 2/2] spapr: Add support for -vga option

2012-06-18 Thread Li Zhang
Also instanciate the USB keyboard and mouse when that option is used (you can still use -device to create individual devices without all the defaults) Signed-off-by: Benjamin Herrenschmidt b...@kernel.crashing.org Signed-off-by: Li Zhang zhlci...@linux.vnet.ibm.com --- hw/spapr.c | 43

[Qemu-devel] [PATCHv3 00/14] unicore32: add softmmu support and puv3 machine

2012-06-18 Thread Guan Xuetao
These patches implement softmmu support on unicore32 architecture. Based on master branch of qemu, the patches can be fetched from: git://github.com/gxt/QEMU.git unicore32 UniCore32 CPU is embedded in PKUnity-3 SoC, so we add necessary puv3 devices simulation codes together. Only minimal

[Qemu-devel] [PATCH 2/2] fdc: Move floppy geometry guessing back from block.c

2012-06-18 Thread Markus Armbruster
Commit 5bbdbb46 moved it to block.c because other geometry guessing functions already reside in block.c. Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing is still in block.c. To be moved out in a later patch series. Bonus:

Re: [Qemu-devel] [PATCH] qemu-config: Use QEMU instead of Qemu

2012-06-18 Thread Stefan Hajnoczi
On Sat, Jun 16, 2012 at 09:29:10AM +0200, Stefan Weil wrote: This new 'Qemu' was recently added. Replace it by the official all upper case 'QEMU'. Signed-off-by: Stefan Weil s...@weilnetz.de --- qemu-config.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, applied to the

[Qemu-devel] [PATCHv3 07/14] unicore32-softmmu: Add puv3 soc/board support

2012-06-18 Thread Guan Xuetao
This patch only add puv3 soc/board support, which introduces puv3 machine description, and specifies console type. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c | 93 +

Re: [Qemu-devel] [Qemu-trivial] [PATCH] checkpatch: Add QEMU specific rule

2012-06-18 Thread Stefan Hajnoczi
On Sun, Jun 17, 2012 at 06:57:41AM +0200, Stefan Weil wrote: The new rule detects two wrong variants of QEMU. It was tested with commit b5a8fe5e. Signed-off-by: Stefan Weil s...@weilnetz.de --- scripts/checkpatch.pl |5 + 1 files changed, 5 insertions(+), 0 deletions(-) Thanks,

[Qemu-devel] [PATCH 1/2] fdc: Drop broken code for user-defined floppy geometry

2012-06-18 Thread Markus Armbruster
bdrv_get_floppy_geometry_hint() fails to store through its parameter drive when bs has a geometry hint. Makes fd_revalidate() assign random crap to drv-drive. Has been broken that way for ages. Harmless, because: * The only way to set a geometry hint is -drive if=none,cyls=... Since commit

Re: [Qemu-devel] [Qemu-trivial] [PATCH] arm_gic: Send dbg msgs to stderr not stdout

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 11:00:18AM +1000, Peter A. G. Crosthwaite wrote: Signed-off-by: Peter A. G. Crosthwaite peter.crosthwa...@petalogix.com --- hw/arm_gic.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Thanks, applied to the trivial patches tree:

[Qemu-devel] [PATCH 0/2] Floppy geometry cleanup

2012-06-18 Thread Markus Armbruster
Markus Armbruster (2): fdc: Drop broken code for user-defined floppy geometry fdc: Move floppy geometry guessing back from block.c block.c | 107 - block.h | 18 - hw/fdc.c | 125

[Qemu-devel] [PATCHv3 09/14] unicore32-softmmu: Add puv3 ostimer support

2012-06-18 Thread Guan Xuetao
This patch adds puv3 ostimer support, include os timer device simulation and ptimer support in puv3 machine. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- default-configs/unicore32-softmmu.mak |1 + hw/Makefile.objs |1 + hw/puv3.c |

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Michael S. Tsirkin
On Mon, Jun 18, 2012 at 11:23:41AM +0200, Jan Kiszka wrote: On 2012-06-18 09:19, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 09:06:01AM +0200, Jan Kiszka wrote: On 2012-06-14 23:31, Michael S. Tsirkin wrote: On Thu, Jun 14, 2012 at 12:15:42PM -0600, Alex Williamson wrote: v3: -

[Qemu-devel] [PATCHv3 12/14] unicore32-softmmu: Add puv3 dma support

2012-06-18 Thread Guan Xuetao
This patch adds puv3 dma (Direct Memory Access) support, include dma device simulation for kernel booting. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/Makefile.objs |1 + hw/puv3.c|1 + hw/puv3_dma.c| 109 ++ 3

Re: [Qemu-devel] Any better way to access CPUArchState in vl.c?

2012-06-18 Thread Andreas Färber
Hi Wei-Ren, Am 18.06.2012 09:47, schrieb 陳韋任 (Wei-Ren Chen): Say I want to print env-some_field in vl.c. I #include dyngen-exec.h in vl.c, but got compilation error immediately. /tmp/chenwj/qemu/dyngen-exec.h:64:10: error: attempt to use poisoned CPUArchState

[Qemu-devel] [PATCHv3 03/14] unicore32-softmmu: Make UniCore32 cpuid exceptions correct and runable

2012-06-18 Thread Guan Xuetao
This patch initializes the cpuid to exactly correct value because linux kernel will check it. In addition, the exception types are specified in proper situations. Then it could make exceptions generated correctly and timely. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- cpu-exec.c

[Qemu-devel] [PATCHv3 06/14] unicore32-softmmu: Make sure that kernel can access user space

2012-06-18 Thread Guan Xuetao
As a matter of course, we need to access user space in kernel code, so we need to correct load/store decoders to indicate correct memory region. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/translate.c | 36 ++-- 1 files changed, 26

Re: [Qemu-devel] [RFC] ARMCPU: Halting a CPU from Device Land

2012-06-18 Thread Andreas Färber
Hi Peter, Am 18.06.2012 09:22, schrieb Peter Crosthwaite: Hi Andreas, For the Xilinx Zynq platform, we need to be able to halt a CPU from a device (the zynq_slcr). E.G, if I write a 1 to a register bit in my device, then that device effects a halt of a CPU. Looking at the QOM stuff the API

[Qemu-devel] [PATCHv3 05/14] unicore32-softmmu: Implement softmmu specific functions

2012-06-18 Thread Guan Xuetao
This patch implements softmmu specific functions, include tlb_fill, switch_mode, do_interrupt and uc32_cpu_handle_mmu_fault. So the full exception handlers and page table walking could work now. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- target-unicore32/op_helper.c | 22 -

[Qemu-devel] [PATCHv3 14/14] unicore32-softmmu: Add maintainer information for UniCore32 machine

2012-06-18 Thread Guan Xuetao
Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- MAINTAINERS |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b45f075..eb5d93a 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -394,6 +394,13 @@ M: Alexander Graf ag...@suse.de S:

[Qemu-devel] [PATCHv3 13/14] unicore32-softmmu: Add ps2 support

2012-06-18 Thread Guan Xuetao
This patch adds ps2/keyboard support, and enables CONFIG_PCKBD. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- default-configs/unicore32-softmmu.mak |1 + hw/puv3.c |5 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git

[Qemu-devel] [PATCHv3 10/14] unicore32-softmmu: Add puv3 gpio support

2012-06-18 Thread Guan Xuetao
This patch adds puv3 gpio (General Purpose Input/Output) support, include gpio device simulation and its interrupt support. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/Makefile.objs |1 + hw/puv3.c|6 ++ hw/puv3_gpio.c | 141

[Qemu-devel] [PATCHv3 11/14] unicore32-softmmu: Add puv3 pm support

2012-06-18 Thread Guan Xuetao
This patch adds puv3 pm (power management) support, include pm device simulation for kernel booting. Signed-off-by: Guan Xuetao g...@mprc.pku.edu.cn --- hw/Makefile.objs |1 + hw/puv3.c|1 + hw/puv3_pm.c | 148 ++ 3 files

Re: [Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-18 Thread Stefan Hajnoczi
On Sun, Jun 17, 2012 at 12:30:32AM +0800, zwu.ker...@gmail.com wrote: +static int print_vlan(DeviceState *dev, Property *prop, char *dest, size_t len) +{ +NetClientState **ptr = qdev_get_prop_ptr(dev, prop); + +if (*ptr) { +unsigned int id; +if

Re: [Qemu-devel] [PATCH v3 0/8] msix: Support specifying offsets, BARs, and capability location

2012-06-18 Thread Jan Kiszka
On 2012-06-18 11:57, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 11:23:41AM +0200, Jan Kiszka wrote: On 2012-06-18 09:19, Michael S. Tsirkin wrote: On Mon, Jun 18, 2012 at 09:06:01AM +0200, Jan Kiszka wrote: On 2012-06-14 23:31, Michael S. Tsirkin wrote: On Thu, Jun 14, 2012 at

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Andreas Färber
Am 18.06.2012 11:31, schrieb Peter Maydell: On 18 June 2012 10:13, Jan Kiszka jan.kis...@siemens.com wrote: On 2012-06-18 02:32, Andreas Färber wrote: This will work technically but I still feel this is wrong semantically. The pre-Paolo and current way is picking specific files from the

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Peter Maydell
On 18 June 2012 11:42, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:31, schrieb Peter Maydell: (Does architecture-specific separation make much sense in general? Not all devices are architecture-specific. I'd have thought that a functional split eg timer/serial/usb like the linux

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Andreas Färber
Am 18.06.2012 12:56, schrieb Peter Maydell: On 18 June 2012 11:42, Andreas Färber afaer...@suse.de wrote: Am 18.06.2012 11:31, schrieb Peter Maydell: (Does architecture-specific separation make much sense in general? Not all devices are architecture-specific. I'd have thought that a

Re: [Qemu-devel] [RFC] ARMCPU: Halting a CPU from Device Land

2012-06-18 Thread Peter Crosthwaite
On Mon, Jun 18, 2012 at 8:07 PM, Andreas Färber afaer...@suse.de wrote: Hi Peter, Am 18.06.2012 09:22, schrieb Peter Crosthwaite: Hi Andreas, For the Xilinx Zynq platform, we need to be able to halt a CPU from a device (the zynq_slcr). E.G, if I write a 1 to a register bit in my device,

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Peter Maydell
On 18 June 2012 12:35, Andreas Färber afaer...@suse.de wrote: But the point is that hw/foo/ is required for the new Makefile system, so we have the empty folders anyway, whereas putting target-specific stuff into, e.g., hw/apic/ will not solve the dependency issue that I tracked down here.

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-06-18 Thread Michael S. Tsirkin
On Tue, Mar 20, 2012 at 10:22:42AM +1030, Rusty Russell wrote: On Mon, 19 Mar 2012 17:13:06 -0500, Anthony Liguori anth...@codemonkey.ws wrote: Maybe just make this a hidden option like x-miio? x-violate-the-virtio-spec-to-trick-old-linux-drivers-into-working-on-power? To configure

Re: [Qemu-devel] [PATCH 0/8] s390: SCLP console and misc

2012-06-18 Thread Christian Borntraeger
Alex, are you going to pull the non-controversial patches? We would then send a reworked sclp patch set later on (when ready) - and everything that you also want us to rework. The alternative is to resend the considered good patches in a separate patch set. Christian

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Anthony Liguori
On 06/18/2012 04:13 AM, Jan Kiszka wrote: On 2012-06-18 02:32, Andreas Färber wrote: Am 18.06.2012 02:01, schrieb Anthony Liguori: This will work technically but I still feel this is wrong semantically. The pre-Paolo and current way is picking specific files from the hw/kvm/ directory. Your

Re: [Qemu-devel] [PATCH] net: roll back qdev_prop_vlan

2012-06-18 Thread Zhi Yong Wu
Good catch, thanks, please next version. On Mon, Jun 18, 2012 at 6:22 PM, Stefan Hajnoczi stefa...@linux.vnet.ibm.com wrote: On Sun, Jun 17, 2012 at 12:30:32AM +0800, zwu.ker...@gmail.com wrote: +static int print_vlan(DeviceState *dev, Property *prop, char *dest, size_t len) +{ +    

[Qemu-devel] [PATCH v2] net: roll back qdev_prop_vlan

2012-06-18 Thread zwu . kernel
From: Zhi Yong Wu wu...@linux.vnet.ibm.com We're trying to preserve backward compatibility. This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the qdev_prop_vlan completely the hw/qdev-properties.c code needs to call

[Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails

2012-06-18 Thread Stefan Hajnoczi
When qcow2_alloc_clusters() error handling code was introduced in commit 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset was clobbered in the error case. This patch keeps free_byte_offset at 0 so we will try to allocate clusters again next time this function is called.

Re: [Qemu-devel] [PATCH v2] net: roll back qdev_prop_vlan

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 1:57 PM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com We're trying to preserve backward compatibility.  This command-line break: x86_64-softmmu/qemu-system-x86_64 -net user,vlan=1 -device virtio-net-pci,vlan=1 Instead of dropping the

Re: [Qemu-devel] [PATCH] make: automatically include dependencies in recursive subdir rules (v2)

2012-06-18 Thread Jan Kiszka
On 2012-06-18 14:47, Anthony Liguori wrote: On 06/18/2012 04:13 AM, Jan Kiszka wrote: On 2012-06-18 02:32, Andreas Färber wrote: Am 18.06.2012 02:01, schrieb Anthony Liguori: This will work technically but I still feel this is wrong semantically. The pre-Paolo and current way is picking

Re: [Qemu-devel] [PATCH] qcow2: fix #ifdef'd qcow2_check_refcounts() callers

2012-06-18 Thread Kevin Wolf
Am 15.06.2012 17:41, schrieb Stefan Hajnoczi: The DEBUG_ALLOC qcow2.h macro enables additional consistency checks throughout the code. This makes it easier to spot corruptions that are introduced during development. Since consistency check is an expensive operation the DEBUG_ALLOC macro is

Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails

2012-06-18 Thread Kevin Wolf
Am 18.06.2012 15:00, schrieb Stefan Hajnoczi: When qcow2_alloc_clusters() error handling code was introduced in commit 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset was clobbered in the error case. This patch keeps free_byte_offset at 0 so we will try to allocate

Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails

2012-06-18 Thread Stefan Hajnoczi
On Mon, Jun 18, 2012 at 2:11 PM, Kevin Wolf kw...@redhat.com wrote: Am 18.06.2012 15:00, schrieb Stefan Hajnoczi: When qcow2_alloc_clusters() error handling code was introduced in commit 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of free_byte_offset was clobbered in the error case.  

Re: [Qemu-devel] [PATCH 3/3] qom: add unit test for Interfaces

2012-06-18 Thread Anthony Liguori
On 06/16/2012 05:31 AM, Peter Crosthwaite wrote: On Thu, Jun 14, 2012 at 6:55 AM, Anthony Liguorialigu...@us.ibm.com wrote: Signed-off-by: Anthony Liguorialigu...@us.ibm.com Reviewed-by: Peter A.G. Crosthwaitepeter.crosthwa...@petalogix.com --- tests/Makefile |5 +-

Re: [Qemu-devel] [PATCH] qcow2: preserve free_byte_offset when qcow2_alloc_bytes() fails

2012-06-18 Thread Kevin Wolf
Am 18.06.2012 15:16, schrieb Stefan Hajnoczi: On Mon, Jun 18, 2012 at 2:11 PM, Kevin Wolf kw...@redhat.com wrote: Am 18.06.2012 15:00, schrieb Stefan Hajnoczi: When qcow2_alloc_clusters() error handling code was introduced in commit 5d757b563d59142ca81e1073a8e8396750a0ad1a, the value of

Re: [Qemu-devel] [PATCH 0/8] s390: SCLP console and misc

2012-06-18 Thread Alexander Graf
On 18.06.2012, at 14:35, Christian Borntraeger wrote: Alex, are you going to pull the non-controversial patches? We would then send a reworked sclp patch set later on (when ready) - and everything that you also want us to rework. Yes, sorry. My patch queue currently has the following

[Qemu-devel] [PULL 0/4] s390 patch queue 2012-06-18

2012-06-18 Thread Alexander Graf
Hi Blue / Aurelien, This is my current patch queue for s390. Please pull. Alex The following changes since commit eb2aeacf983a2a88a2b31e8fee067c38bd10abd3: malc (1): audio/winwave: Fix typo are available in the git repository at: git://repo.or.cz/qemu/agraf.git s390-for-upstream

[Qemu-devel] [PATCH 4/4] s390: stop target cpu on sigp initial reset

2012-06-18 Thread Alexander Graf
From: Christian Borntraeger borntrae...@de.ibm.com We must not run the target cpu after an initial reset. This makes system_reset more reliable for smp guests. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Signed-off-by: Alexander Graf ag...@suse.de --- target-s390x/kvm.c |1 +

Re: [Qemu-devel] [PATCH 0/8] s390: SCLP console and misc

2012-06-18 Thread Christian Borntraeger
On 18/06/12 15:33, Alexander Graf wrote: On 18.06.2012, at 14:35, Christian Borntraeger wrote: Alex, are you going to pull the non-controversial patches? We would then send a reworked sclp patch set later on (when ready) - and everything that you also want us to rework. Yes, sorry.

Re: [Qemu-devel] [PATCH v3] s390: autodetect map private

2012-06-18 Thread Alexander Graf
On 15.06.2012, at 17:10, Christian Borntraeger wrote: By default qemu will use MAP_PRIVATE for guest pages. This will write protect pages and thus break on s390 systems that dont support this feature. Therefore qemu has a hack to always use MAP_SHARED for s390. But MAP_SHARED has other

Re: [Qemu-devel] [PATCH 3/3] qom: add unit test for Interfaces

2012-06-18 Thread Peter Crosthwaite
+#define HERBIVORE(obj) \ +    INTERFACE_CHECK(Herbivore, (obj), TYPE_HERBIVORE) + +typedef struct Herbivore +{ +    Object obj; +} Herbivore; All this is doing is saying Herbivores are Objects right? A user cant add anything to this struct given that interfaces are stateless so could

Re: [Qemu-devel] [PATCH 8/8] s390: Fix the storage increment size calculation

2012-06-18 Thread Alexander Graf
On 12.06.2012, at 16:57, Jeng-fang Wang wrote: Yes, you can refer to AR10040-03-POK, Service-Call Logical Processor Architecture for S/390 and z/Architecture, Figure 2-6 Minimum storage increment and subincrement size. :) Is that one publicly available anywhere? Alex

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/15/2012 02:04 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios trees. On

Re: [Qemu-devel] [PATCH 0/8] s390: SCLP console and misc

2012-06-18 Thread Alexander Graf
On 18.06.2012, at 15:41, Christian Borntraeger wrote: On 18/06/12 15:33, Alexander Graf wrote: On 18.06.2012, at 14:35, Christian Borntraeger wrote: Alex, are you going to pull the non-controversial patches? We would then send a reworked sclp patch set later on (when ready) - and

Re: [Qemu-devel] [PATCH 3/3] qom: add unit test for Interfaces

2012-06-18 Thread Andreas Färber
Am 18.06.2012 15:46, schrieb Peter Crosthwaite: +#define HERBIVORE(obj) \ +INTERFACE_CHECK(Herbivore, (obj), TYPE_HERBIVORE) + +typedef struct Herbivore +{ +Object obj; +} Herbivore; All this is doing is saying Herbivores are Objects right? A user cant add anything to this

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: On 06/15/2012 12:57 PM, Jason Baron wrote: On Thu, Jun 14, 2012 at 03:16:03PM -0500, Anthony Liguori wrote: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to work on the latest qemu and seabios

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Paul Moore
On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would render seccomp pretty much useless. Not necessarily. I'll agree that it

[Qemu-devel] [PATCH 2/4] kvm: Update kernel headers

2012-06-18 Thread Alexander Graf
Corresponding kvm.git hash: 4e3c8a1b1c Signed-off-by: Alexander Graf ag...@suse.de --- linux-headers/asm-s390/kvm.h |5 + linux-headers/linux/kvm.h|1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Daniel P. Berrange
On Mon, Jun 18, 2012 at 09:52:44AM -0400, Paul Moore wrote: On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue Swirl wrote: I think allowing execve() would render seccomp

[Qemu-devel] [PATCH 13/22] qdev: Clean up global properties

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com Now that global properties do not depend on buses anymore, set them directly in the device instance_init function. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/qdev-monitor.c |1 - hw/qdev.c

[Qemu-devel] [PATCH 19/22] qbus: Make child devices links

2012-06-18 Thread Andreas Färber
From: Anthony Liguori aligu...@us.ibm.com Make qbus children show up as link properties. There is no stable addressing for qbus children so we use an unstable naming convention. This is okay in QOM though because the composition name is expected to be what's stable. Signed-off-by: Anthony

[Qemu-devel] [PATCH 3/4] s390: make kvm_stat work on s390

2012-06-18 Thread Alexander Graf
From: Jens Freimann jf...@linux.vnet.ibm.com Add s390_exit_reasons so kvm_stat doesn't crash when called on s390. Look for 'vendor_id' in /proc/cpuinfo as well, instead of just for 'flags', so we can determine if we run on S390. Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com

[Qemu-devel] [PATCH 14/22] qdev: Remove qdev_prop_set_defaults

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com Instead, qdev_property_add_static can set the default. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de --- hw/qdev-properties.c | 22 --

[Qemu-devel] [PATCH 17/22] qdev: Convert busses to QEMU Object Model

2012-06-18 Thread Andreas Färber
From: Anthony Liguori aligu...@us.ibm.com This is far less interesting than it sounds. We simply add an Object to each BusState and then register the types appropriately. Most of the interesting refactoring will follow in the next patches. Since we're changing fundamental type names (BusInfo -

Re: [Qemu-devel] [RFC] [PATCHv2 2/2] Adding basic calls to libseccomp in vl.c

2012-06-18 Thread Paul Moore
On Monday, June 18, 2012 02:55:35 PM Daniel P. Berrange wrote: On Mon, Jun 18, 2012 at 09:52:44AM -0400, Paul Moore wrote: On Monday, June 18, 2012 09:31:03 AM Daniel P. Berrange wrote: On Fri, Jun 15, 2012 at 05:02:19PM -0400, Paul Moore wrote: On Friday, June 15, 2012 07:06:10 PM Blue

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/18/2012 08:51 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 06/15/2012 02:04 AM, Markus Armbruster wrote: Anthony Liguorianth...@codemonkey.ws writes: On 06/14/2012 02:54 PM, Jason Baron wrote: Hi, I recently updated Isaku Yamahata's q35 patches to

[Qemu-devel] [PATCH 06/22] qom: Drop type_register_static_alias() macro

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com It's unused. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Andreas Färber afaer...@suse.de --- include/qemu/object.h |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/include/qemu/object.h b/include/qemu/object.h

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/17/2012 03:25 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: The Q35 is much more sophisticated. The PCI-e complex itself can present interesting topologies and the legacy PCI bus sits within the PCI-e complex. Ah, so we can mix in PCI as

[Qemu-devel] [PATCH 1/4] s390x: fix s390 virtio aliases

2012-06-18 Thread Alexander Graf
Some of the virtio devices have the same frontend name, but actually implement different devices behind the scenes through aliases. The indicator which device type to use is the architecture. On s390, we want s390 virtio devices. On everything else, we want PCI devices. Reflect this in the alias

[Qemu-devel] Status of query-netdev QMP command

2012-06-18 Thread Roger Pau Monne
Hello, I've read from the GSoC/2010 that some work was being done creating a query-netdev QMP command: http://wiki.qemu.org/Google_Summer_of_Code_2010/QMP#query-netdev The status says that mentor has merged it into his tree, but I cannot see this command anywhere upstream, and it will come

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Michael S. Tsirkin
On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: So we need to fix our topological representation of platform devices before we start adding more complex chipsets. Otherwise, we're going to end up in a bad situation in the near future. OTOH more in-tree examples especially for

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Anthony Liguori
On 06/18/2012 09:20 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: So we need to fix our topological representation of platform devices before we start adding more complex chipsets. Otherwise, we're going to end up in a bad situation in the near

[Qemu-devel] The latest qemu.git/master build break

2012-06-18 Thread Zhi Yong Wu
HI, When i want to rebase my hub-based network patchset to latest qemu.git/master, i found the build break. lt LINK libcacard.la ar: libcacard/cac.o: No such file or directory make[1]: *** [libcacard.la] Error 1 make: *** [subdir-libcacard] Error 2 -- Regards, Zhi Yong Wu

Re: [Qemu-devel] q35 chipset support

2012-06-18 Thread Michael S. Tsirkin
On Mon, Jun 18, 2012 at 09:16:24AM -0500, Anthony Liguori wrote: On 06/17/2012 03:25 AM, Michael S. Tsirkin wrote: On Fri, Jun 15, 2012 at 12:58:33PM -0500, Anthony Liguori wrote: The Q35 is much more sophisticated. The PCI-e complex itself can present interesting topologies and the legacy

[Qemu-devel] [PATCH 03/22] qom: Add object_child_foreach()

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com A utility function that will be used to implement hierarchical realization. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Anthony Liguori aligu...@us.ibm.com [AF: Drop unrelated whitespace change, add Returns: in documentation] [AF: Use new

[Qemu-devel] [PATCH 08/22] m48t59: Rename type property to model

2012-06-18 Thread Andreas Färber
From: Paolo Bonzini pbonz...@redhat.com This resolves a name conflict with the qdev type property that is about to move into Object. Signed-off-by: Paolo Bonzini pbonz...@redhat.com [AF: Add braces missing in original code.] Signed-off-by: Andreas Färber afaer...@suse.de --- hw/m48t59.c | 40

  1   2   3   >