[Qemu-devel] [PATCH 26/32] qtest: Cover qdev property for BIOS CHS translation

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/hd-geo-test.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index a47b945..5d9d2e4 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -321,15 +321,16 @@ static v

Re: [Qemu-devel] [PATCH 02/14] scsi: add a qdev property for the disk's WWN

2012-07-06 Thread Paolo Bonzini
Il 05/07/2012 20:03, Blue Swirl ha scritto: > > > > +if (s->wwn) { > > > > +outbuf[buflen++] = 0x1; // Binary > > > > +outbuf[buflen++] = 0x3; // NAA > > > > +outbuf[buflen++] = 0; // reserved > > > > > > C99 comments. > > > > Just follo

[Qemu-devel] [PATCH 22/32] qtest: Cover qdev properties for disk geometry

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/hd-geo-test.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index cc447a2..a47b945 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -321,13 +321,15 @@ static void tes

[Qemu-devel] [PATCH 15/32] ide pc: Cut out the block layer geometry middleman

2012-07-06 Thread Markus Armbruster
PC BIOS setup needs IDE geometry information. Get it directly from the device model rather than through the block layer. In preparation of purging geometry from the block layer, which will happen later in this series. Signed-off-by: Markus Armbruster --- hw/ide.h |4 +++- hw/ide/c

Re: [Qemu-devel] [PATCH 4/6] device_tree: Add support for reading device tree properties

2012-07-06 Thread Peter Maydell
On 6 July 2012 02:56, Peter Crosthwaite wrote: > On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell > wrote: >> +uint32_t qemu_devtree_getprop_cell(void *fdt, const char *node_path, >> + const char *property) > > Hi Peter, > > Can we generalise and get functionality

Re: [Qemu-devel] [PATCH 2/6] hw/arm_boot.c: Consistently use ram_size from arm_boot_info struct

2012-07-06 Thread Peter Maydell
On 6 July 2012 03:00, Peter Crosthwaite wrote: > On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell > wrote: >> @@ -371,7 +371,8 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info >> *info) >> initrd_size = load_image_targphys(info->initrd_filename, >>

[Qemu-devel] [PATCH 05/32] qtest: Tidy up temporary files properly

2012-07-06 Thread Markus Armbruster
Each test litters /tmp with several files: a pid file and two sockets. Tidy up. Signed-off-by: Markus Armbruster --- tests/libqtest.c | 29 - 1 files changed, 16 insertions(+), 13 deletions(-) diff --git a/tests/libqtest.c b/tests/libqtest.c index 071b6be..02d0392

Re: [Qemu-devel] [PATCH 3/6] hw/arm_boot.c: Check for RAM sizes exceeding ATAGS capacity

2012-07-06 Thread Peter Maydell
On 6 July 2012 03:05, Peter Crosthwaite wrote: > On Fri, Jul 6, 2012 at 3:00 AM, Peter Maydell > wrote: >> +if (info->ram_size >= (1ULL << 32)) { >> +fprintf(stderr, "qemu: RAM size must be less than 4GB to >> boot" >> +" Linux kernel without

Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

2012-07-06 Thread Markus Armbruster
Michael Tokarev writes: > On 06.07.2012 06:42, Amos Kong wrote: >> On 30/06/12 10:02, ak...@redhat.com wrote: >>> From: Amos Kong >>> >>> Currently qemu outputs some low-level error in qemu-sockets.c >>> when failed to start vnc server. >>> eg. 'getaddrinfo(127.0.0.1,5902): Name or service not kn

[Qemu-devel] [PATCH 20/32] virtio-blk: qdev properties for disk geometry

2012-07-06 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Bonus: info qtree now shows the geometry. Signed-off-by: Markus Armbruster --- hw/s390-virtio-

[Qemu-devel] [PATCH 21/32] ide: qdev properties for disk geometry

2012-07-06 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Do this only for ide-hd. ide-drive is legacy. ide-cd doesn't have a geometry. Bonus: info qtre

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-06 Thread liu ping fan
On Thu, Jul 5, 2012 at 7:58 PM, Jan Kiszka wrote: > On 2012-07-05 13:02, liu ping fan wrote: >> On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka wrote: >>> On 2012-07-05 12:10, liu ping fan wrote: On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka wrote: > On 2012-07-05 04:18, Liu Ping Fan wrote: >>>

[Qemu-devel] [PATCH 27/32] block: Geometry and translation hints are now useless, purge them

2012-07-06 Thread Markus Armbruster
There are two producers of these hints: drive_init() on behalf of -drive, and hd_geometry_guess(). The only consumer of the hint is hd_geometry_guess(). The callers of hd_geometry_guess() call it only when drive_init() didn't set the hints. Therefore, drive_init()'s hints are never used. Thus,

[Qemu-devel] [PATCH 07/32] block: Factor bdrv_read_unthrottled() out of guess_disk_lchs()

2012-07-06 Thread Markus Armbruster
To prepare move of guess_disk_lchs() into hw/, where it poking BlockDriverState member io_limits_enabled directly would be unclean. Signed-off-by: Markus Armbruster --- block.c | 24 +--- block.h |2 ++ 2 files changed, 19 insertions(+), 7 deletions(-) diff --git a/blo

[Qemu-devel] [PATCH 23/32] qdev: Collect private helpers in one place

2012-07-06 Thread Markus Armbruster
Just code motion, with one long line wrapped to keep checkpatch.pl happy. Signed-off-by: Markus Armbruster --- hw/qdev-properties.c | 144 +- 1 files changed, 72 insertions(+), 72 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-propertie

[Qemu-devel] [PATCH 04/32] vvfat: Do not clobber the user's geometry

2012-07-06 Thread Markus Armbruster
vvfat creates a virtual VFAT filesystem with a certain logical geometry that depends on its options. It sets the "geometry hint" to this geometry. It is the only block driver to do this. The geometry hint is about about *physical* geometry, and used only by certain hard disk device models. vvfa

Re: [Qemu-devel] [PATCH] add text about how to use qemu-nbd with qemu

2012-07-06 Thread Wayne Xia
于 2012-7-5 16:34, Paolo Bonzini 写道: Il 05/07/2012 10:13, Michael Tokarev ha scritto: Hi Paolo, should I make a patch to make persistent the default for qemu-nbd? Yes, why not. However, as mentioned above client mode should still be non-persistent. I don't think this makes sense or is good: n

[Qemu-devel] [PATCH 17/32] qdev: Introduce block geometry properties

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- block.h |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/block.h b/block.h index 052d0ce..e0121d5 100644 --- a/block.h +++ b/block.h @@ -427,6 +427,8 @@ typedef struct BlockConf { uint32_t opt_io_size; int32_t bootinde

Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

2012-07-06 Thread Amos Kong
- Original Message - > Michael Tokarev writes: > > > On 06.07.2012 06:42, Amos Kong wrote: > >> On 30/06/12 10:02, ak...@redhat.com wrote: > >>> From: Amos Kong > >>> > >>> Currently qemu outputs some low-level error in qemu-sockets.c > >>> when failed to start vnc server. > >>> eg. 'get

[Qemu-devel] [PATCH 09/32] hd-geometry: Add tracepoints

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/hd-geometry.c |7 +++ trace-events |4 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index c45eafd..f0dd021 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@ -32,6 +32,7 @@

Re: [Qemu-devel] [PATCH 00/32] Disk geometry cleanup

2012-07-06 Thread Markus Armbruster
I screwed up Subject: lacks "v2". Sorry!

Re: [Qemu-devel] [PATCH v2] vnc: add a more descriptive error message

2012-07-06 Thread Michael Tokarev
On 06.07.2012 12:09, Amos Kong wrote: > - Original Message - >> Michael Tokarev writes: >>> Gyus, please, pretty PLEASE stop doing things like this. >>> >>> Amos, your patch does TWO things. One is to clarify error >>> message as correctly stated in your description, and second >>> is to

Re: [Qemu-devel] [PATCH] cpu: smp_wmb before lauching cpus.

2012-07-06 Thread Jan Kiszka
On 2012-07-06 09:46, liu ping fan wrote: > On Thu, Jul 5, 2012 at 7:58 PM, Jan Kiszka wrote: >> On 2012-07-05 13:02, liu ping fan wrote: >>> On Thu, Jul 5, 2012 at 6:16 PM, Jan Kiszka wrote: On 2012-07-05 12:10, liu ping fan wrote: > On Thu, Jul 5, 2012 at 2:46 PM, Jan Kiszka wrote: >>>

[Qemu-devel] [PATCH 12/32] hd-geometry: Clean up gratuitous goto in hd_geometry_guess()

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/hd-geometry.c | 22 -- 1 files changed, 8 insertions(+), 14 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index 1a58894..fb849a3 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@ -119,8 +119,7 @@ static void gue

[Qemu-devel] [PATCH 28/32] ide pc: Put hard disk info into CMOS only for hard disks

2012-07-06 Thread Markus Armbruster
In particular, don't set disk type and geometry when a CD-ROM on bus ide.0 has media during CMOS initialization. Signed-off-by: Markus Armbruster --- hw/ide/qdev.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/ide/qdev.c b/hw/ide/qdev.c index f191dd3..84097fd 10064

[Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-06 Thread Markus Armbruster
New limits straight from ATA4 6.2 Register delivered data transfer command sector addressing. I figure the old sector limit 63 was blindly copied from the BIOS int 13 limit. Doesn't apply to the hardware. No idea where the old cylinder limit comes from. Signed-off-by: Markus Armbruster --- hw

[Qemu-devel] [PATCH 29/32] qtest: Test we don't put hard disk info into CMOS for a CD-ROM

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- tests/hd-geo-test.c | 22 ++ 1 files changed, 22 insertions(+), 0 deletions(-) diff --git a/tests/hd-geo-test.c b/tests/hd-geo-test.c index 5d9d2e4..9a31e85 100644 --- a/tests/hd-geo-test.c +++ b/tests/hd-geo-test.c @@ -369,6 +369,27 @@

[Qemu-devel] [PATCH 10/32] hd-geometry: Unnest conditional in hd_geometry_guess()

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/hd-geometry.c | 84 +++--- 1 files changed, 42 insertions(+), 42 deletions(-) diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c index f0dd021..db47846 100644 --- a/hw/hd-geometry.c +++ b/hw/hd-geometry.c @@

[Qemu-devel] [PATCH 06/32] qtest: Add hard disk geometry test

2012-07-06 Thread Markus Armbruster
So far covers only IDE and tests only CMOS contents. Signed-off-by: Markus Armbruster --- tests/Makefile |2 + tests/hd-geo-test.c | 403 +++ 2 files changed, 405 insertions(+), 0 deletions(-) create mode 100644 tests/hd-geo-test.c diff

[Qemu-devel] [PATCH 02/32] fdc: Move floppy geometry guessing back from block.c

2012-07-06 Thread Markus Armbruster
Commit 5bbdbb46 moved it to block.c because "other geometry guessing functions already reside in block.c". Device-specific functionality should be kept in device code, not the block layer. Move it back. Disk geometry guessing is still in block.c. To be moved out in a later patch series. Bonus:

[Qemu-devel] [PATCH 18/32] hd-geometry: Switch to uint32_t to match BlockConf

2012-07-06 Thread Markus Armbruster
Best to use the same type, to avoid unwanted truncation or sign extension. BlockConf can't use plain int for cyls, heads and secs, because integer properties require an exact width. Signed-off-by: Markus Armbruster --- hw/block-common.h |2 +- hw/hd-geometry.c |4 ++-- hw/ide/core.c

[Qemu-devel] [PATCH 19/32] scsi-hd: qdev properties for disk geometry

2012-07-06 Thread Markus Armbruster
Geometry needs to be qdev properties, because it belongs to the disk's guest part. Maintain backward compatibility exactly like for serial: fall back to DriveInfo's geometry, set with -drive cyls=... Do this only for scsi-hd. scsi-disk is legacy. scsi-cd doesn't have a geometry. scsi-block sho

[Qemu-devel] [PATCH 14/32] hd-geometry: Cut out block layer translation middleman

2012-07-06 Thread Markus Armbruster
hd_geometry_guess() picks geometry and translation. Callers can get the geometry directly, via parameters, but for translation they need to go through the block layer. Add a parameter for translation, so it can optionally be gotten just like geometry. In preparation of purging translation from t

[Qemu-devel] [PATCH 16/32] blockdev: Save geometry in DriveInfo

2012-07-06 Thread Markus Armbruster
In preparation of purging it from the block layer, which will happen later in this series. Signed-off-by: Markus Armbruster --- blockdev.c |4 blockdev.h |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/blockdev.c b/blockdev.c index 9e0a72a..4d3b707 100644 --- a/

[Qemu-devel] [PATCH 01/32] fdc: Drop broken code for user-defined floppy geometry

2012-07-06 Thread Markus Armbruster
bdrv_get_floppy_geometry_hint() fails to store through its parameter drive when bs has a geometry hint. Makes fd_revalidate() assign random crap to drv->drive. Has been broken that way for ages. Harmless, because: * The only way to set a geometry hint is -drive if=none,cyls=... Since commit c

[Qemu-devel] [PATCH 25/32] ide: qdev property for BIOS CHS translation

2012-07-06 Thread Markus Armbruster
This isn't quite orthodox. CHS translation is firmware configuration, communicated via the RTC's CMOS RAM, not a property of the disk. But it's best to treat it just like geometry anyway. Maintain backward compatibility exactly like for geometry: fall back to DriveInfo's translation, set with -d

[Qemu-devel] [PATCH 30/32] hd-geometry: Compute BIOS CHS translation in one place

2012-07-06 Thread Markus Armbruster
Currently, it is split between hd_geometry_guess() and pc_cmos_init_late(). Confusing. info qtree shows the result of the former. Also confusing. Fold the part done in pc_cmos_init_late() into hd_geometry_guess(). Signed-off-by: Markus Armbruster --- hw/block-common.h |1 + hw/hd-geometr

[Qemu-devel] [PATCH 24/32] qdev: New property type chs-translation

2012-07-06 Thread Markus Armbruster
Signed-off-by: Markus Armbruster --- hw/qdev-properties.c | 15 +++ hw/qdev.h|3 +++ 2 files changed, 18 insertions(+), 0 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 002c7f9..0b18f8c 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-pr

[Qemu-devel] [PATCH 00/32] Disk geometry cleanup

2012-07-06 Thread Markus Armbruster
32 patches may look discouraging, but most patches are small, and the ones that aren't just move code around. Goals of this series: 1. One more step towards a clean separation block device host and guest part. 2. Purge CHS geometry from the block layer Part I[PATCH 01-02/32]: Floppy geom

[Qemu-devel] [PATCH 13/32] hd-geometry: Clean up confusing use of prior translation hint

2012-07-06 Thread Markus Armbruster
When hd_geometry_guess() picks a geometry, it also picks the appropriate translation, but only when the prior translation hint is BIOS_ATA_TRANSLATION_AUTO. Looks wrong, because such a prior translation would be passed to the BIOS whether it's suitable for the geometry or not. Fortunately, that c

[Qemu-devel] Anyone using Bulldozer CPUs?

2012-07-06 Thread Michael Tokarev
I've got a (longish) bugreport about qemu-kvm not working on an AMD bulldozer CPU. In particular, winXP guests which worked fine before, after upgrade of the host CPU stopped working with a BSOD, and no new winXP install can be completed due to installer freezing somewhere in process. I don't hav

[Qemu-devel] [PATCH 08/32] hd-geometry: Move disk geometry guessing back from block.c

2012-07-06 Thread Markus Armbruster
Commit f3d54fc4 factored it out of hw/ide.c for reuse. Sensible, except it was put into block.c. Device-specific functionality should be kept in device code, not the block layer. Move it to hw/hd-geometry.c, and make stylistic changes required to keep checkpatch.pl happy. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH 00/13] ARM: Add LPAE support

2012-07-06 Thread Peter Maydell
On 28 June 2012 15:35, Peter Maydell wrote: > This patch series adds support for the ARM Large Physical Address > Extensions, which allow 40 bit physical addressing by means of > a new translation table format. Advance notice: I intend to put these patches into a pullreq at the end of next week,

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Peter Maydell
On 28 June 2012 13:55, Peter Maydell wrote: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. NB: I'm planning to put this v3 into a target-arm pullreq at the end of next wee

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-06 Thread Kevin Wolf
Am 05.07.2012 18:37, schrieb Corey Bryant: > There is one case I'm aware of where we need to be careful: Before > opening an image, qemu may probe the format. In this case, the image > gets opened twice, and the first close comes before the second open. > I'm > not entirely sure

Re: [Qemu-devel] [PATCH 32/32] Relax IDE CHS limits from 16383, 16, 63 to 65535, 16, 255

2012-07-06 Thread Kevin Wolf
Am 05.07.2012 18:39, schrieb Markus Armbruster: > Markus Armbruster writes: > >> Kevin Wolf writes: >> >>> Am 29.06.2012 17:34, schrieb Markus Armbruster: New limits straight from ATA4 6.2 Register delivered data transfer command sector addressing. I figure the old sector lim

Re: [Qemu-devel] [PATCH v4 0/7] file descriptor passing using pass-fd

2012-07-06 Thread Kevin Wolf
Am 05.07.2012 19:00, schrieb Eric Blake: > On 07/05/2012 10:35 AM, Corey Bryant wrote: >> 1. client calls 'add-fd', qemu is now tracking fd=4 in fdset1 with >> refcount of 0; fd=4's in-use flag is turned on >> 2. client calls 'device-add' with /dev/fdset/1 as the backing filename, >> so qemu_open()

Re: [Qemu-devel] [PATCH 1/6] qemu-log: move logging to qemu-log.c

2012-07-06 Thread Kevin Wolf
Am 05.07.2012 20:07, schrieb Blue Swirl: > On Wed, Jul 4, 2012 at 8:34 AM, Kevin Wolf wrote: >> Am 03.07.2012 21:19, schrieb Blue Swirl: >>> On Tue, Jul 3, 2012 at 10:07 AM, Kevin Wolf wrote: Am 09.06.2012 14:12, schrieb Blue Swirl: > Move logging functions from exec.c to qemu-log.c, >>>

[Qemu-devel] [Bug 1021649] [NEW] qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Public bug reported: qemu 1.1.0 waits for a keypress at boot. Please don't ever do this. Try the attached test script. When run it will initially print nothing, until you hit a key on the keyboard. Removing -nographic fixes the problem. Using virtio-scsi instead of virtio-blk fixes the proble

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Also affects upstream qemu from git. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot Status in QEMU: New Bug description: qemu 1.1.0 waits

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
** Attachment added: "test-qemu.sh" https://bugs.launchpad.net/bugs/1021649/+attachment/3214808/+files/test-qemu.sh -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits

[Qemu-devel] [PATCH v6] kvm: notify host when the guest is panicked

2012-07-06 Thread Wen Congyang
We can know the guest is panicked when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the guest is panicked. If management app does not do auto dump, the guest's user can do dump by hand

[Qemu-devel] [PATCH 1/7 v6] start vm after reseting it

2012-07-06 Thread Wen Congyang
The guest should run after reseting it, but it does not run if its old state is RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED. We don't set runstate to RUN_STATE_PAUSED when reseting the guest, so the runstate will be changed from RUN_STATE_INTERNAL_ERROR or RUN_STATE_PAUSED to RUN_STATE_RUNNING(no

[Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Wen Congyang
Signed-off-by: Wen Congyang --- linux-headers/asm-x86/kvm_para.h |2 ++ linux-headers/linux/kvm_para.h |6 ++ 2 files changed, 8 insertions(+), 0 deletions(-) diff --git a/linux-headers/asm-x86/kvm_para.h b/linux-headers/asm-x86/kvm_para.h index f2ac46a..f9d858f 100644 --- a/linux-

[Qemu-devel] [PATCH 3/7 v6] add a new runstate: RUN_STATE_GUEST_PANICKED

2012-07-06 Thread Wen Congyang
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang --- qapi-schema.json |6 +- qmp.c|3 ++- vl.c |7 ++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/qapi-schema.json b/qapi-schema.json index 3b6e346..00

[Qemu-devel] [Bug 1021649] Re: qemu 1.1.0 waits for a keypress at boot

2012-07-06 Thread Richard W.M. Jones
Using -device sga fixes the problem, but also means I cannot see what it's trying to wait for. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1021649 Title: qemu 1.1.0 waits for a keypress at boot

[Qemu-devel] [PATCH 4/7 v6] add a new qevent: QEVENT_GUEST_PANICKED

2012-07-06 Thread Wen Congyang
This event will be emited when the guest is panicked. Signed-off-by: Wen Congyang --- monitor.c |1 + monitor.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/monitor.c b/monitor.c index f6107ba..28f7482 100644 --- a/monitor.c +++ b/monitor.c @@ -458,6 +458,7 @@ sta

[Qemu-devel] [RFC V3 0/5] Multiqueue support for tap and virtio-net/vhost

2012-07-06 Thread Jason Wang
Hello all: This seires is an update of last version of multiqueue support to add multiqueue capability to both tap and virtio-net. Some kinds of tap backends has (macvatp in linux) or would (tap) support multiqueue. In such kind of tap backend, each file descriptor of a tap is a qeueu and ioctls

[Qemu-devel] [RFC V3 1/5] option: introduce qemu_get_opt_all()

2012-07-06 Thread Jason Wang
Sometimes, we need to pass option like -netdev tap,fd=100,fd=101,fd=102 which can not be properly parsed by qemu_find_opt() because it only returns the first matched option. So qemu_get_opt_all() were introduced to return an array of pointers which contains all matched option. Signed-off-by: Jason

[Qemu-devel] [RFC V3 5/5] virtio-net: add multiqueue support

2012-07-06 Thread Jason Wang
Based on the multiqueue support for taps and NICState, this patch add the capability of multiqueue for virtio-net. For userspace virtio-net emulation, each pair of VLANClientState peers were abstracted as a tx/rx queue. For vhost, the vhost net devices were created per virtio-net tx/rx queue pairs,

[Qemu-devel] [RFC V3 2/5] tap: multiqueue support

2012-07-06 Thread Jason Wang
Some operating system ( such as Linux ) supports multiqueue tap, this is done through attaching multiple sockets to the net device and expose multiple file descriptors. This patch let qemu utilizes this kind of backend, and introduces helpter for: - creating a multiple capable tap device - increa

[Qemu-devel] [PATCH 7/7 v6] deal with panicked event accoring to '-machine panic_action=action'

2012-07-06 Thread Wen Congyang
The action is the same as -onpanic parameter. Signed-off-by: Wen Congyang --- qemu-config.c |4 qemu-options.hx |4 +++- vl.c|7 +++ 3 files changed, 14 insertions(+), 1 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 5c3296b..805e7c4 100644 ---

[Qemu-devel] [PATCH 6/7 v6] deal with guest panicked event accoring to -onpanic parameter

2012-07-06 Thread Wen Congyang
The onpanic parameter can have the following value: 1. none 2. pause 3. poweroff 4. reset The action for each value when the guest is panicked: 1. none: emit QEVENT_GUEST_PANICKED only 2. pause: emit QEVENT_GUEST_PANICKED and pause the guest 3. poweroff: emit QEVENT_GUEST_PANICKED and poweroff the

[Qemu-devel] [PATCH 5/7 v6] introduce a new qom device to deal with panicked event

2012-07-06 Thread Wen Congyang
If the target is x86/x86_64, the guest's kernel will write 0x01 to the port KVM_PV_PORT when it is panciked. This patch introduces a new qom device kvm_pv_ioport to listen this I/O port, and deal with panicked event according to panicked_action's value. The possible actions are: 1. emit QEVENT_GUES

[Qemu-devel] USB: 2 bug-fixes, for master *and* for stable-1.1

2012-07-06 Thread Hans de Goede
Here are USB 2 bug-fixes, please also cherry-pick these into the stable-1.1 branch, esp. the second one as that fixes an easily triggerable assert. Note these patches are against 1.1.0, not against master, but they are relevant for, and should apply to, master too. Regards, Hans

[Qemu-devel] [PATCH 1/2] usb-redir: Correctly handle the usb_redir_babble usbredir status

2012-07-06 Thread Hans de Goede
Signed-off-by: Hans de Goede --- hw/usb/redirect.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index 5f55d78..c6358c0 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -1058,6 +1058,8 @@ static int usbredir_handle_status(USBRedirDevice *d

[Qemu-devel] [PATCH 2/2] usb-ehci: Fix an assert whenever isoc transfers are used

2012-07-06 Thread Hans de Goede
hcd-ehci.c is missing an usb_packet_init() call for the ipacket UsbPacket it uses for isoc transfers, triggering an assert (taking the entire vm down) in usb_packet_setup as soon as any isoc transfers are done by a high speed USB device. Signed-off-by: Hans de Goede --- hw/usb/hcd-ehci.c |1

[Qemu-devel] [RFC V3 4/5] vhost: multiqueue support

2012-07-06 Thread Jason Wang
This patch converts the vhost to support multiqueue queues. It implement a 1:1 mapping of vhost devs and tap fds. That it to say, the patch creates and uses N vhost devs as the backend of the N queues virtio-net deivce. The main work is to convert the virtqueue index into vhost queue index, this i

[Qemu-devel] [RFC V3 3/5] net: multiqueue support

2012-07-06 Thread Jason Wang
This patch adds the multiqueues support for emulated nics. Each VLANClientState pairs are now abstract as a queue instead of a nic, and multiple VLANClientState pointers were stored in the NICState. A queue_index were also introduced to let the emulated nics know which queue the packet were came fr

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:38, Wen Congyang wrote: > Signed-off-by: Wen Congyang Which kvm.git hash is this referring? Please state this to avoid that we are merging support for kernel features that are still under review. Jan > --- > linux-headers/asm-x86/kvm_para.h |2 ++ > linux-headers/linux/kvm

Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-06 Thread Yeongkyoon Lee
Add declarations and templates of extended MMU helpers which can take return address argument to what helper functions return. These extended helper functions are called only by generated code. It's not entirely clear from this description what the return address argument actually is. My commit

Re: [Qemu-devel] [RFC][PATCH v2 1/4] tcg: add declarations and templates of extended MMU helpers

2012-07-06 Thread Wei-Ren Chen
> > Also, please line wrap your commit messages. > I didn't know the line wrap rule of commit message. Is the rule included > in checkpatch.pl? Let me check it. I guess it's 80 char length rule? Regards, chenwj -- Wei-Ren Chen (陳韋任) Computer Systems Lab, Institute of Information Science, Aca

[Qemu-devel] [PATCH 0/3] Introduce virtqueue_get_avail_bytes()

2012-07-06 Thread Amit Shah
The current virtqueue_avail_bytes() is a weird API: it's oddly-named: doesn't tell us what the API is going to do, and also suits just one use-case (that in virtio-net.c). Introduce virtqueue_get_avail_bytes(), which returns the number of bytes in the vq available for input as well as output. virt

[Qemu-devel] [PATCH 3/3] virtio-serial-bus: let chardev know the exact number of bytes requested

2012-07-06 Thread Amit Shah
Using the virtqueue_avail_bytes() function had an unnecessarily crippling effect on the number of bytes needed by the guest as reported to the chardev layer in the can_read() callback. Using the new virtqueue_get_avail_bytes() function will let us advertise the exact number of bytes we can send to

[Qemu-devel] [PATCH 1/3] virtio: use unsigned int for counting bytes in vq

2012-07-06 Thread Amit Shah
The virtqueue_avail_bytes() function counts bytes in an int. Use an unsigned int instead. Signed-off-by: Amit Shah --- hw/virtio.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/virtio.c b/hw/virtio.c index 168abe4..b21dcac 100644 --- a/hw/virtio.c +++ b/hw/virtio.

[Qemu-devel] [PATCH 2/3] virtio: Introduce virtqueue_get_avail_bytes()

2012-07-06 Thread Amit Shah
The current virtqueue_avail_bytes() is oddly named, and checks if a particular number of bytes are available in a vq. A better API is to fetch the number of bytes available in the vq, and let the caller do what's interesting with the numbers. Introduce virtqueue_get_avail_bytes(), which returns t

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Wen Congyang
At 07/06/2012 06:25 PM, Jan Kiszka Wrote: > On 2012-07-06 11:38, Wen Congyang wrote: >> Signed-off-by: Wen Congyang > > Which kvm.git hash is this referring? Please state this to avoid that we > are merging support for kernel features that are still under review. The following kvm.git: http://gi

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Wei-Ren Chen
> > Which kvm.git hash is this referring? Please state this to avoid that we > > are merging support for kernel features that are still under review. > > The following kvm.git: > http://git.kernel.org/?p=virt/kvm/kvm.git;a=summary What Jia ask for is git hash, should be something like, 8ac

Re: [Qemu-devel] [PATCH 5/7 v6] introduce a new qom device to deal with panicked event

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > If the target is x86/x86_64, the guest's kernel will write 0x01 to the > port KVM_PV_PORT when it is panciked. This patch introduces a new qom > device kvm_pv_ioport to listen this I/O port, and deal with panicked > event according to panicked_action's val

Re: [Qemu-devel] [PATCH 7/7 v6] deal with panicked event accoring to '-machine panic_action=action'

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > The action is the same as -onpanic parameter. As explained in patch 5, now that we have a related device, this no longer needs to be a machine property. Would could be a machine property is enabling/disabling this device. That's probably useful as it use

Re: [Qemu-devel] [PATCH 6/7 v6] deal with guest panicked event accoring to -onpanic parameter

2012-07-06 Thread Jan Kiszka
On 2012-07-06 11:41, Wen Congyang wrote: > The onpanic parameter can have the following value: > 1. none > 2. pause > 3. poweroff > 4. reset > > The action for each value when the guest is panicked: > 1. none: emit QEVENT_GUEST_PANICKED only > 2. pause: emit QEVENT_GUEST_PANICKED and pause the gue

Re: [Qemu-devel] [PATCH 2/7 v6] update linux headers

2012-07-06 Thread Jan Kiszka
On 2012-07-06 12:50, Wen Congyang wrote: > At 07/06/2012 06:25 PM, Jan Kiszka Wrote: >> On 2012-07-06 11:38, Wen Congyang wrote: >>> Signed-off-by: Wen Congyang >> >> Which kvm.git hash is this referring? Please state this to avoid that we >> are merging support for kernel features that are still

Re: [Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-06 Thread Yeongkyoon Lee
Is it really worth having this as a CONFIG_ switch? If we think it's better to do this out of line we should just switch to always generating the out of line code, I think. There's not much point in retaining the old code path if it's disabled -- it will just bitrot. I agree. However, it is just

Re: [Qemu-devel] [RFC][PATCH v2 3/4] tcg: add optimized TCG qemu_ld/st generation

2012-07-06 Thread Peter Maydell
On 6 July 2012 12:20, Yeongkyoon Lee wrote: > >>> +#ifdef CONFIG_QEMU_LDST_OPTIMIZATION >>> +/* jne slow_path */ >>> +tcg_out_opc(s, OPC_JCC_long + JCC_JNE, 0, 0, 0); >>> +if (!label_ptr) { >>> +tcg_abort(); >>> +} >> >> There's no point in this check and abort -- label_ptr

Re: [Qemu-devel] [RFC][PATCH v2 4/4] configure: add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization

2012-07-06 Thread Yeongkyoon Lee
On 2012년 07월 05일 23:06, Peter Maydell wrote: On 5 July 2012 14:23, Yeongkyoon Lee wrote: Add an option "--enable-ldst-optimization" to enable CONFIG_QEMU_LDST_OPTIMIZATION macro for TCG qemu_ld/st optimization. It only works with CONFIG_SOFTMMU and doesn't work with CONFIG_TCG_PASS_AREG0. Th

Re: [Qemu-devel] [PATCH 4/4] virtio-rng: hardware random number generator device

2012-07-06 Thread Amit Shah
On (Tue) 26 Jun 2012 [08:01:20], Anthony Liguori wrote: > On 06/26/2012 05:48 AM, Amit Shah wrote: > >On (Mon) 25 Jun 2012 [17:59:28], Anthony Liguori wrote: > >>On 06/25/2012 05:46 PM, Anthony Liguori wrote: > >>>From: Amit Shah > > > >>>diff --git a/hw/virtio-pci.c b/hw/virtio-pci.c > > > >>>+sta

Re: [Qemu-devel] [RFC][PATCH v2 2/4] tcg: add extended MMU helpers to softmmu targets

2012-07-06 Thread Yeongkyoon Lee
On 2012년 07월 06일 03:49, Blue Swirl wrote: On Thu, Jul 5, 2012 at 1:43 PM, Peter Maydell wrote: On 5 July 2012 14:23, Yeongkyoon Lee wrote: Add extended MMU helpers to softmmu targets, where the targets are alpha, arm, cris, i386, lm32, m68k, microblaze, mips, ppc, s390x, sh4, sparc and xtens

Re: [Qemu-devel] USB: 2 bug-fixes, for master *and* for stable-1.1

2012-07-06 Thread Gerd Hoffmann
On 07/06/12 12:09, Hans de Goede wrote: > Here are USB 2 bug-fixes, please also cherry-pick these into the > stable-1.1 branch, esp. the second one as that fixes an easily triggerable > assert. > > Note these patches are against 1.1.0, not against master, but they are > relevant > for, and should

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Andreas Färber
Am 28.06.2012 14:55, schrieb Peter Maydell: > Add functions deposit32(), deposit64(), extract32() and extract64() > to extract and deposit bitfields in 32 and 64 bit words. Based on > ideas by Jia Liu and Avi Kivity. > > Suggested-by: Jia Liu > Suggested-by: Avi Kivity > Signed-off-by: Peter May

Re: [Qemu-devel] [Qemu-ppc][PATCH v5 1/4] Add usb option in machine options

2012-07-06 Thread Alexander Graf
On 02.07.2012, at 07:25, zhlci...@gmail.com wrote: > From: Li Zhang > > pSeries machine needs to enable USB to add a USB > keyboard or USB mouse. -usb option won't be used in > the future, and machine options are a better way to > enable USB. > > So this patch is to add USB option to machine o

Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-06 Thread Andreas Färber
Am 05.07.2012 19:00, schrieb Peter Maydell: > Make the RAM size in arm_boot_info a target_phys_addr_t so > it can express RAM sizes up to the limit imposed by the > physical address size. > > Signed-off-by: Peter Maydell > --- > hw/arm-misc.h |2 +- > 1 files changed, 1 insertions(+), 1 dele

Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option

2012-07-06 Thread Alexander Graf
On 02.07.2012, at 07:25, zhlci...@gmail.com wrote: > From: Li Zhang > > Also instanciate the USB keyboard and mouse when that option is used > (you can still use -device to create individual devices without all > the defaults) > > Signed-off-by: Benjamin Herrenschmidt > Signed-off-by: Li Zhan

Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-06 Thread Alexander Graf
On 06.07.2012, at 15:48, Andreas Färber wrote: > Am 05.07.2012 19:00, schrieb Peter Maydell: >> Make the RAM size in arm_boot_info a target_phys_addr_t so >> it can express RAM sizes up to the limit imposed by the >> physical address size. >> >> Signed-off-by: Peter Maydell >> --- >> hw/arm-mis

Re: [Qemu-devel] [Qemu-ppc][PATCH v5 4/4] spapr: Add support for -vga option

2012-07-06 Thread Andreas Färber
Am 06.07.2012 15:50, schrieb Alexander Graf: > > On 02.07.2012, at 07:25, zhlci...@gmail.com wrote: > >> @@ -712,6 +730,11 @@ static void ppc_spapr_init(ram_addr_t ram_size, >> spapr_vscsi_create(spapr->vio_bus); >> } >> >> +/* Graphics */ >> +if (spapr_vga_init(QLIST_FIRST(&s

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Peter Maydell
On 6 July 2012 14:41, Andreas Färber wrote: > Small improvement would be to replace "Returns the" with "Returns: The" > in line with how you annotated the arguments, and the function summary > should go into its own paragraph between @foo: and Returns:. > > http://developer.gnome.org/gtk-doc-manua

Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-06 Thread Andreas Färber
Am 06.07.2012 15:54, schrieb Alexander Graf: > > On 06.07.2012, at 15:48, Andreas Färber wrote: > >> Am 05.07.2012 19:00, schrieb Peter Maydell: >>> Make the RAM size in arm_boot_info a target_phys_addr_t so >>> it can express RAM sizes up to the limit imposed by the >>> physical address size. >>

Re: [Qemu-devel] [PATCH 1/6] hw/arm_boot.c: Make ram_size a target_phys_addr_t

2012-07-06 Thread Peter Maydell
On 6 July 2012 14:48, Andreas Färber wrote: > Am 05.07.2012 19:00, schrieb Peter Maydell: >> Make the RAM size in arm_boot_info a target_phys_addr_t so >> it can express RAM sizes up to the limit imposed by the >> physical address size. > Didn't we conclude in lengthy and emotional discussions th

Re: [Qemu-devel] [PATCH v3] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Andreas Färber
Am 06.07.2012 16:01, schrieb Peter Maydell: > On 6 July 2012 14:41, Andreas Färber wrote: >> Small improvement would be to replace "Returns the" with "Returns: The" >> in line with how you annotated the arguments, and the function summary >> should go into its own paragraph between @foo: and Retur

Re: [Qemu-devel] [PATCH 29/37] ehci: kick async schedule on wakeup

2012-07-06 Thread Hans de Goede
Hi, On 06/07/2012 11:31 AM, Gerd Hoffmann wrote: Kick async schedule when we get a wakeup notification from a usb device. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ehci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index

[Qemu-devel] [PATCH v4] bitops.h: Add functions to extract and deposit bitfields

2012-07-06 Thread Peter Maydell
Add functions deposit32(), deposit64(), extract32() and extract64() to extract and deposit bitfields in 32 and 64 bit words. Based on ideas by Jia Liu and Avi Kivity. Suggested-by: Jia Liu Suggested-by: Avi Kivity Signed-off-by: Peter Maydell Reviewed-by: Eric Blake Reviewed-by: Andreas Färber

  1   2   >