Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-17 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 11:44:41AM +0800, Jia Liu wrote: Hi Aurelien, +#ifdef TARGET_MIPS64 +case OPC_ABSQ_S_QH_DSP: +switch (op2) { +case OPC_REPL_OB: +check_dsp(ctx); +{ +target_long temp; + +imm =

Re: [Qemu-devel] [PATCH v11 06/14] target-mips: Add ASE DSP arithmetic instructions

2012-10-17 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 12:54:45PM +0800, Jia Liu wrote: +if (ret == 0) { +/* Treat as NOP. */ +MIPS_DEBUG(NOP); +return; +} + +if (v1 == 0) { +tcg_gen_movi_tl(v1_t, 0); +} else { +gen_load_gpr(v1_t, v1); +} + +

Re: [Qemu-devel] [PATCH 1/2] hmp: fix info cpus for sparc targets

2012-10-17 Thread Aurelien Jarno
On Tue, Oct 16, 2012 at 11:01:45PM -0300, Luiz Capitulino wrote: On Wed, 17 Oct 2012 01:28:34 +0200 Aurelien Jarno aurel...@aurel32.net wrote: On sparc targets, info cpus returns this kind of output: | info cpus | * CPU #0:

Re: [Qemu-devel] [PATCH v2 0/5] target-mips: Preparations for CPUState part 4b series

2012-10-17 Thread Aurelien Jarno
On Fri, Oct 12, 2012 at 12:56:32AM +0200, Andreas Färber wrote: Hello Aurélien, This series picks up some preparatory patches for QOM CPUState refactoring, originally posted in May. They still applied cleanly, but I optimized them a bit and expanded the explanations. In short it is about

Re: [Qemu-devel] [PATCH v11 09/14] target-mips: Add ASE DSP bit/manipulation instructions

2012-10-17 Thread Jia Liu
Hi Aurelien, On Wed, Oct 17, 2012 at 2:05 PM, Aurelien Jarno aurel...@aurel32.net wrote: On Wed, Oct 17, 2012 at 11:44:41AM +0800, Jia Liu wrote: Hi Aurelien, +#ifdef TARGET_MIPS64 +case OPC_ABSQ_S_QH_DSP: +switch (op2) { +case OPC_REPL_OB: +

[Qemu-devel] [PATCH 4/7] serial: add 2x + 4x pci variant

2012-10-17 Thread Gerd Hoffmann
Add multiport serial card implementation, with two variants, one featuring two and one featuring four ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/serial-pci.c | 149 +++ 1 files changed, 149 insertions(+), 0 deletions(-) diff

[Qemu-devel] [PATCH 6/7] usb-serial: don't magically zap chardev on umplug

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 69b6e48..43214cd 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -421,7 +421,7 @@ static

[Qemu-devel] [PULL v4 0/7] serial device hotplug patch series.

2012-10-17 Thread Gerd Hoffmann
Hi, Next round of the serial device hotplug series. Left out chardev patches due to confligting in-flight patches and ongoing discussions, carrying only pci-serial and usb-serial bits. Adressed Anthonys comments: Added license to serial.h and moved documentation to docs/specs/pci-serial.txt.

[Qemu-devel] [PATCH 3/7] serial: add windows inf file for the pci card to docs

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/qemupciserial.inf | 109 1 files changed, 109 insertions(+), 0 deletions(-) create mode 100644 docs/qemupciserial.inf diff --git a/docs/qemupciserial.inf b/docs/qemupciserial.inf new file

[Qemu-devel] [PATCH 1/7] serial: split serial.c

2012-10-17 Thread Gerd Hoffmann
Split serial.c into serial.c, serial.h and serial-isa.c. While being at creating a serial.h header file move the serial prototypes from pc.h to the new serial.h. The latter leads to s/pc.h/serial.h/ in tons of boards which just want the serial bits from pc.h Signed-off-by: Gerd Hoffmann

[Qemu-devel] [PATCH 7/7] usb-serial: only expose device in guest when the chardev is open

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-serial.c | 19 +-- 1 files changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/usb/dev-serial.c b/hw/usb/dev-serial.c index 43214cd..a466f99 100644 --- a/hw/usb/dev-serial.c +++ b/hw/usb/dev-serial.c @@ -427,6

[Qemu-devel] [PATCH 5/7] serial: add pci-serial documentation

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/specs/pci-serial.txt | 34 ++ hw/serial-pci.c |2 ++ 2 files changed, 36 insertions(+), 0 deletions(-) create mode 100644 docs/specs/pci-serial.txt diff --git a/docs/specs/pci-serial.txt

Re: [Qemu-devel] [Patch]KVM: enabling per domain PLE

2012-10-17 Thread Hu, Xuekun
The problem with this is that it requires an administrator to understand the workload, not only of the guest, but also of other guests on the machine. With low overcommit, a high PLE window reduces unneeded exits, but with high overcommit we need those exits to reduce spinning. In

Re: [Qemu-devel] [RFC PATCH 0/6] chardev: convert to QOM

2012-10-17 Thread Gerd Hoffmann
Hi, I think the main decision point here is whether we introduce a separate chardev_add/chardev_del command or just use the qom-create command that has been posted previously. Do you have a git tree with this series + qom-create to look at and play with? thanks, Gerd

[Qemu-devel] [PATCH 2/7] serial: add pci variant

2012-10-17 Thread Gerd Hoffmann
So we get a hot-pluggable 16550 uart. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- default-configs/pci.mak |2 + hw/Makefile.objs|1 + hw/pci_ids.h|1 + hw/serial-pci.c | 101 +++ hw/serial.c |

[Qemu-devel] udev 42-qemu-usb.rules considered harmful?

2012-10-17 Thread Michael Tokarev
Hello. I noticed that some versions of linux guests shows quite bad behavour of mouse cursor: it freezes after some idle time, and when you move mouse, it jumps after some delay to rather distant position. So, mouse becomes freezy/jumpy, so to say. Quite some painful debugging pointed to the

Re: [Qemu-devel] udev 42-qemu-usb.rules considered harmful?

2012-10-17 Thread Gerd Hoffmann
On 10/17/12 10:41, Michael Tokarev wrote: Hello. I noticed that some versions of linux guests shows quite What is some? As far as I can see, this rule is to reduce polling interrupt frequency, but apparently it does not help: any usb device connected to guest, and the host CPU usage rises

Re: [Qemu-devel] udev 42-qemu-usb.rules considered harmful?

2012-10-17 Thread Michael Tokarev
On 17.10.2012 12:56, Gerd Hoffmann wrote: On 10/17/12 10:41, Michael Tokarev wrote: Hello. I noticed that some versions of linux guests shows quite What is some? I guess it is almost all modern distros. Debian wheezy, Ubuntu 12.4, current Fedora (17 I think) to name some. As far as I

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-17 Thread Vasilis Liaskovitis
On Sat, Oct 13, 2012 at 08:57:19AM +, Blue Swirl wrote: On Tue, Oct 9, 2012 at 5:04 PM, Vasilis Liaskovitis vasilis.liaskovi...@profitbricks.com wrote: snip Maybe even the dimmbus device shouldn't exist by itself after all, or it should be pretty much invisible to users. On real HW,

Re: [Qemu-devel] udev 42-qemu-usb.rules considered harmful?

2012-10-17 Thread Michael Tokarev
On 17.10.2012 13:15, Michael Tokarev wrote: But the mouse is jumpy anyway. I guess one can get used to this behavour, given the tradeoff and that the behavour is not VERY annoying -- it is annoying, but just for a bit, it feels like old mechanical mouse with bad sensor or dirty ball when you

Re: [Qemu-devel] [PATCH v3 9/9] chardev: add hotplug support.

2012-10-17 Thread Gerd Hoffmann
Hi, +- id: the chardev's ID, must be unique (json-string) +- backend: the chardev backend: file, socket, ... (json-string) +- path: file / device / unix socket path (json-string, optional) +- name: spice channel name (json-string, optional) +- host: host name (json-string, optional) +-

Re: [Qemu-devel] [PATCH v3 0/4] block-commit fixes

2012-10-17 Thread Kevin Wolf
Am 16.10.2012 22:33, schrieb Eric Blake: On 10/16/2012 01:49 PM, Jeff Cody wrote: v2 - v3 differences: * Simplified code in patch 2, minor commit rewording * Made conditional check more valgrind-friendly v1 - v2 differences: * Updated changes to be protocol friendly * Updated

Re: [Qemu-devel] [RFC PATCH v3 06/19] Implement -dimm command line option

2012-10-17 Thread Avi Kivity
On 10/17/2012 11:19 AM, Vasilis Liaskovitis wrote: I don't think so, but probably there's a limit of DIMMs that real controllers have, something like 8 max. In the case of i440fx specifically, do you mean that we should model the DRB (Dram row boundary registers in section 3.2.19 of the

[Qemu-devel] [PATCH 0/3] chardev hotplug patch series

2012-10-17 Thread Gerd Hoffmann
Hi, Here comes the updated chardev hotplug patch series. Addressed most review comments. It's chardev-add and chardev-remove now. Parameters have been added to the schema. Little nits and spell fixes here and there. Making 'backend' an enum is tricky given that the actual implementation

[Qemu-devel] [PATCH 1/3] chardev: add error reporting for qemu_chr_new_from_opts

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 24 +++- qemu-char.h |3 ++- vl.c|8 ++-- 3 files changed, 23 insertions(+), 12 deletions(-) diff --git a/qemu-char.c b/qemu-char.c index b082bae..e2e1da8 100644 --- a/qemu-char.c +++

[Qemu-devel] [PATCH 2/3] chardev: fix QemuOpts lifecycle

2012-10-17 Thread Gerd Hoffmann
qemu_chr_new_from_opts handles QemuOpts release now, so callers don't have to worry. It will either be saved in CharDriverState, then released in qemu_chr_delete, or in the error case released instantly. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 15 ++-

Re: [Qemu-devel] [Patch]KVM: enabling per domain PLE

2012-10-17 Thread Avi Kivity
On 10/17/2012 10:02 AM, Hu, Xuekun wrote: The problem with this is that it requires an administrator to understand the workload, not only of the guest, but also of other guests on the machine. With low overcommit, a high PLE window reduces unneeded exits, but with high overcommit we need

[Qemu-devel] [PATCH 3/3] chardev: add hotplug support.

2012-10-17 Thread Gerd Hoffmann
This patch adds chardev_add and chardev_remove monitor commands. They work similar to the netdev_{add,del} commands. The hmp version of chardev_add accepts like the -chardev command line option does. The qmp version expects the arguments being passed as named parameters. chardev_del just takes

Re: [Qemu-devel] udev 42-qemu-usb.rules considered harmful?

2012-10-17 Thread Gerd Hoffmann
Hi, But the mouse is jumpy anyway. I guess one can get used to this behavour, given the tradeoff and that the behavour is not VERY annoying -- it is annoying, but just for a bit, it feels like old mechanical mouse with bad sensor or dirty ball when you can move the mouse but cursor

Re: [Qemu-devel] [PATCH 10/10] tcg: Optimize mulu2

2012-10-17 Thread Avi Kivity
On 10/17/2012 03:09 AM, Richard Henderson wrote: On 2012-10-17 09:25, Aurelien Jarno wrote: +gen_opc_buf[op_index] = op = INDEX_op_mul_i32; Very minor nitpick: you probably don't need to set op there. Perhaps not, but I prefer to keep the variables in sync as we drop into

Re: [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-17 Thread Gerd Hoffmann
On 10/15/12 15:00, Hans de Goede wrote: Hi, On 10/15/2012 01:17 PM, Gerd Hoffmann wrote: On 10/15/12 12:38, Hans de Goede wrote: Often the guest will queue up new packets in response to a packet, in the async schedule with its IOC flag set, completing. By speeding up the frame-timer, we

Re: [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket

2012-10-17 Thread Gerd Hoffmann
On 10/15/12 12:38, Hans de Goede wrote: -usb_packet_setup(xfer-packet, dir, ep, xfer-trbs[0].addr, false); +int_req = false; +for (i = 0; i xfer-trb_count; i++) { +if (xfer-trbs[i].control TRB_TR_IOC) { +int_req = true; +break; +} +

Re: [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-17 Thread Hans de Goede
Hi, On 10/17/2012 01:01 PM, Gerd Hoffmann wrote: On 10/15/12 15:00, Hans de Goede wrote: Hi, On 10/15/2012 01:17 PM, Gerd Hoffmann wrote: On 10/15/12 12:38, Hans de Goede wrote: Often the guest will queue up new packets in response to a packet, in the async schedule with its IOC flag set,

Re: [Qemu-devel] [PATCH 13/22] usb: Add an int_req flag to USBPacket

2012-10-17 Thread Hans de Goede
Hi, On 10/17/2012 01:04 PM, Gerd Hoffmann wrote: On 10/15/12 12:38, Hans de Goede wrote: -usb_packet_setup(xfer-packet, dir, ep, xfer-trbs[0].addr, false); +int_req = false; +for (i = 0; i xfer-trb_count; i++) { +if (xfer-trbs[i].control TRB_TR_IOC) { +int_req

Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Gerd Hoffmann
Hi, +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called for devices which call these functions themselves. + */ +int (*handle_combined_data)(USBDevice *dev, USBPacket *p); +

Re: [Qemu-devel] [PATCH 06/22] ehci: Speed up the timer of raising int from the async schedule

2012-10-17 Thread Gerd Hoffmann
Hi, 1) It causes migration issues when migrating to / from an old version With -1 yes, shifting the scale shoudn't be a that big issue though as it is just a optimization. 2) We don't want to change the wakeup rate when the interrupt flag gets set as pending, but when it actually gets

[Qemu-devel] [PATCH 1/2] microblaze: Support setting of TLS ptr

2012-10-17 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@gmail.com Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- linux-user/syscall.c|2 ++ target-microblaze/cpu.h |1 + 2 files changed, 3 insertions(+), 0 deletions(-) diff --git a/linux-user/syscall.c b/linux-user/syscall.c index

[Qemu-devel] [PATCH 2/2] microblaze: Update PC before simulating syscall

2012-10-17 Thread edgar . iglesias
From: Edgar E. Iglesias edgar.igles...@gmail.com Fixes a clone() emulation bug were the new thread starts at the point of the syscall and thus clones in a loop. Signed-off-by: Edgar E. Iglesias edgar.igles...@gmail.com --- linux-user/main.c |2 +- 1 files changed, 1 insertions(+), 1

[Qemu-devel] [PATCH v3 1/2] qemu-img: Add --backing-chain option to info command

2012-10-17 Thread Stefan Hajnoczi
The qemu-img info --backing-chain option enumerates the backing file chain. For example, for base.qcow2 - snap1.qcow2 - snap2.qcow2 the output becomes: $ qemu-img info --backing-chain snap2.qcow2 image: snap2.qcow2 file format: qcow2 virtual size: 100M (104857600 bytes) disk size: 196K

[Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command

2012-10-17 Thread Stefan Hajnoczi
This series adds the --backing-chain option for enumerating the backing file chain. Given the topmost image it will print qemu-img info information for each image file in the chain. Special care needs to be taken when image files form an infinite loop. This is very unusual, most like due to

[Qemu-devel] [PATCH v3 2/2] qemu-iotests: Add 043 backing file chain infinite loop test

2012-10-17 Thread Stefan Hajnoczi
This new test verifies that qemu-img info --backing-chain safely aborts when an image file has a backing file infinite loop. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/043 | 94 tests/qemu-iotests/043.out | 66

Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno

2012-10-17 Thread Markus Armbruster
Luiz Capitulino lcapitul...@redhat.com writes: On Thu, 04 Oct 2012 18:16:13 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Il 04/10/2012 18:14, Luiz Capitulino ha scritto: +void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, + const char *fmt, ...)

Re: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Inline APIC cpu_env property setting

2012-10-17 Thread Jan Kiszka
On 2012-10-16 18:02, Andreas Färber wrote: Am 12.10.2012 03:26, schrieb Andreas Färber: This prepares for changing the variable type from void*. Signed-off-by: Andreas Färber afaer...@suse.de Cc: Igor Mammedov imamm...@redhat.com Paolo, are you happy with getting rid of the pointer

Re: [Qemu-devel] [PATCH 1/2] hmp: fix info cpus for sparc targets

2012-10-17 Thread Luiz Capitulino
On Wed, 17 Oct 2012 08:06:13 +0200 Aurelien Jarno aurel...@aurel32.net wrote: On Tue, Oct 16, 2012 at 11:01:45PM -0300, Luiz Capitulino wrote: On Wed, 17 Oct 2012 01:28:34 +0200 Aurelien Jarno aurel...@aurel32.net wrote: On sparc targets, info cpus returns this kind of output: |

Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: These functions help maintaining homogeneous formatting of error messages that include strerror values. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- error.c | 28 error.h | 9 + 2 file modificati, 37

Re: [Qemu-devel] [PATCH 01/18] error: add error_set_errno and error_setg_errno

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 14:56, Markus Armbruster ha scritto: Duplicates error_set() code without need. How about: void error_set_errno(Error **errp, int os_errno, ErrorClass err_class, const char *fmt, ...) { char *msg; va_start(ap, fmt); msg =

Re: [Qemu-devel] [PATCH 02/18] qemu-sockets: add Error ** to all functions

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 04/10/2012 18:19, Luiz Capitulino ha scritto: -int unix_listen_opts(QemuOpts *opts) +int unix_listen_opts(QemuOpts *opts, Error **errp) { -fprintf(stderr, unix sockets are not available on windows\n); +error_setg(errp, unix

[Qemu-devel] [PATCH 2/4] Setting -sandbox on as deafult

2012-10-17 Thread Eduardo Otubo
Now the seccomp filter will be set to on even if no argument -sandbox is given. Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- configure | 2 +- vl.c | 38 +++--- 2 files changed, 28 insertions(+), 12 deletions(-) diff --git a/configure

[Qemu-devel] [PATCH 3/4] Support for double whitelist filters

2012-10-17 Thread Eduardo Otubo
This patch includes a second whitelist right before the main loop. It's a smaller and more restricted whitelist, excluding execve() among many others. Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- qemu-seccomp.c | 94 --

[Qemu-devel] [PATCH 4/4] Warning messages on net devices hotplug

2012-10-17 Thread Eduardo Otubo
With the inclusion of the new double whitelist seccomp filter, Qemu won't be able to execve() in runtime, thus, no hotplug net devices allowed. Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- hmp.c | 6 ++ net.c | 13 + 2 files changed, 19 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: They are just wrappers and do not need a Win32-specific version. This gave me pause (it's my thick-headed day, apparently), until I realized that in addition to what the commit message says you also move related code. Please try harder to make review

Re: [Qemu-devel] [PATCH 03/18] qemu-sockets: unix_listen and unix_connect are portable

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:17, Markus Armbruster ha scritto: They are just wrappers and do not need a Win32-specific version. This gave me pause (it's my thick-headed day, apparently), until I realized that in addition to what the commit message says you also move related code. Please try harder to

[Qemu-devel] [PATCH 1/4] Adding new syscalls (bugzilla 855162)

2012-10-17 Thread Eduardo Otubo
According to the bug 855162[0] - there's the need of adding new syscalls to the whitelist whenn using Qemu with Libvirt. [1] - https://bugzilla.redhat.com/show_bug.cgi?id=855162 Reported-by: Paul Moore pmo...@redhat.com Signed-off-by: Eduardo Otubo ot...@linux.vnet.ibm.com --- qemu-seccomp.c |

[Qemu-devel] [PATCH 09/14] vga: stop direct access to DisplaySurface fields.

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga.c |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index a0ba94d..4d34469 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -1718,8 +1718,13 @@ static void vga_draw_graphic(VGACommonState *s, int

[Qemu-devel] [PATCH 04/14] pixman: helper functions

2012-10-17 Thread Gerd Hoffmann
Add some helper functions which will be put into use by following patches. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile.objs |1 + qemu-pixman.c | 60 + qemu-pixman.h | 32 ++ 3 files

[Qemu-devel] [PATCH 02/14] pixman: add submodule

2012-10-17 Thread Gerd Hoffmann
Add pixman submodule as fallback for old distros. Picking version 0.18.4. This is shipped by rhel6 and also the minimum version needed by spice so this should serve well as baseline. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- .gitmodules |3 +++ pixman |1 + 2 files

[Qemu-devel] [PATCH 06/14] console: make qemu_alloc_display static

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 48 console.h |2 -- 2 files changed, 24 insertions(+), 26 deletions(-) diff --git a/console.c b/console.c index 5e1c5f5..48d88e4 100644 --- a/console.c +++ b/console.c @@

[Qemu-devel] [PATCH 12/14] pixman/vnc: remove rgb_prepare_row* functions

2012-10-17 Thread Gerd Hoffmann
Let pixman do it instead. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc-enc-tight.c | 84 ++- 1 files changed, 10 insertions(+), 74 deletions(-) diff --git a/ui/vnc-enc-tight.c b/ui/vnc-enc-tight.c index 8013c5c..9fd2556 100644 ---

[Qemu-devel] [PATCH 14/14] pixman: drop obsolete fields from DisplaySurface

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |9 - console.h | 23 +-- 2 files changed, 13 insertions(+), 19 deletions(-) diff --git a/console.c b/console.c index d28b75e..048b48e 100644 --- a/console.c +++ b/console.c @@ -1297,14 +1297,10 @@

Re: [Qemu-devel] [PATCH 04/25] qemu-sockets: add nonblocking connect for Unix sockets

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: fixed connect_state memory leaks qemu-char.c| 2 +- qemu-sockets.c | 77 -- qemu_socket.h | 6 - 3 file

Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Impact?

Re: [Qemu-devel] [PATCH 05/25] migration: avoid using error_is_set and thus relying on errp != NULL

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:36, Markus Armbruster ha scritto: The migration code is using errp to detect internal errors, this means that it relies on errp being non-NULL. Impact? None because so far our only QMP client is HMP and never passes a NULL Error **. But if we had others, it would make sure

Re: [Qemu-devel] Any alternative to kqemu ?

2012-10-17 Thread Timothy Madden
On Mon, Oct 15, 2012 at 11:03 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/10/2012 12:52, Timothy Madden ha scritto: Hello Is kqemu deprecated ? It is simply not supported anymore. Is there an alternative to it ? No. That is tough ... ! So my hardware is officially obsolete. I

Re: [Qemu-devel] [PATCH] hw/qxl: guest bug on primary create with stride %4 != 0

2012-10-17 Thread Gerd Hoffmann
On 10/15/12 14:54, Alon Levy wrote: Due to usage of pixman for rendering on all spice surfaces we have pixman's requirement that the stride be word aligned. A guest not honoring that can crash spice and qemu with it due to failure to create a surface (in spice-server). Avoid this early on in

Re: [Qemu-devel] [PATCH 04/25] qemu-sockets: add nonblocking connect for Unix sockets

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:33, Markus Armbruster ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: fixed connect_state memory leaks qemu-char.c| 2 +- qemu-sockets.c | 77

Re: [Qemu-devel] [PATCH v3 2/4] monitor: Enable adding an inherited fd to an fd set

2012-10-17 Thread Kevin Wolf
Am 16.10.2012 20:08, schrieb Corey Bryant: qmp_add_fd() gets an fd that was received over a socket with SCM_RIGHTS and adds it to an fd set. This patch adds support that will enable adding an fd that was inherited on the command line to an fd set. Note: All of the code added to

Re: [Qemu-devel] Any alternative to kqemu ?

2012-10-17 Thread Wei-Ren Chen
Is there an alternative to it ? No. That is tough ... ! So my hardware is officially obsolete. I had to get away with those other emulators provided by commercial companies. VMWare said my hardware does not support virtualization (much like qemu), but VirtualBox worked surprisingly

Re: [Qemu-devel] Any alternative to kqemu ?

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:39, Timothy Madden ha scritto: On Mon, Oct 15, 2012 at 11:03 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/10/2012 12:52, Timothy Madden ha scritto: Hello Is kqemu deprecated ? It is simply not supported anymore. Is there an alternative to it ? No. That is tough

Re: [Qemu-devel] nvram and boot order

2012-10-17 Thread Gleb Natapov
On Wed, Oct 17, 2012 at 07:07:53AM +1100, Benjamin Herrenschmidt wrote: On Tue, 2012-10-16 at 14:55 -0500, Anthony Liguori wrote: 4) If -boot is specified, the parameter should alter the contents of NVRAM to change the boot order to what is specified by -boot. 5) If ,bootorder is

Re: [Qemu-devel] [Bug 1066055] Re: Network performance regression with vde_switch

2012-10-17 Thread Stefan Hajnoczi
On Tue, Oct 16, 2012 at 2:23 PM, Edivaldo de Araujo Pereira edivaldoapere...@yahoo.com.br wrote: Hi Stefan I finally could revert that commit in the latest snapshot; problem was I needed to revert one later, that modified hw/virtio-serial-bus.c accordingly; after that reversion, the

Re: [Qemu-devel] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 06:16, schrieb Eric Blake: I'm still seeing the corner case of: qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4- where the dup(3) will populate fd 4 prior to the point where we get to process the -add-fd fd=4 command to notice that the user started qemu-kvm with fd 4

[Qemu-devel] [PATCH 13/14] pixman/vnc: remove dead code.

2012-10-17 Thread Gerd Hoffmann
Switching the vnc server framebuffer to use 32bpp unconditionally turns the code bits which handle 8 and 16 bpp into dead code. Remove them. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc-enc-hextile.c | 32 - ui/vnc-enc-tight.c | 64

[Qemu-devel] [PATCH 03/14] pixman: windup in configure makefiles

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |9 + configure | 38 ++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index a9c22bf..5699101 100644 --- a/Makefile +++ b/Makefile @@ -105,6 +105,15

[Qemu-devel] [PATCH 08/14] qxl: stop direct access to DisplaySurface fields.

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/qxl-render.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/qxl-render.c b/hw/qxl-render.c index 47eb8b4..98ecb21 100644 --- a/hw/qxl-render.c +++ b/hw/qxl-render.c @@ -24,7 +24,7 @@ static void

[Qemu-devel] [PATCHv2 1/2] signal: added a wrapper for sigprocmask function

2012-10-17 Thread Alex Barcelo
Create a wrapper for signal mask changes initiated by the guest; this will give us a place to put code which prevents the guest from changing the handling of signals used by QEMU itself internally. The wrapper is called from all the guest-initiated sigprocmask, but is not called from internal

[Qemu-devel] [PATCHv2 0/2] Preparing safe sigprocmask wrapper on qemu-user

2012-10-17 Thread Alex Barcelo
qemu-user needs SIGSEGV (at least) for some internal use. If the guest application masks it and does unsafe sigprocmask, then the application crashes. Problems happen in applications with self-modifying code (who also change the signal mask). Other guest applications may have related problems if

[Qemu-devel] [PATCHv2 2/2] signal: sigsegv protection on do_sigprocmask

2012-10-17 Thread Alex Barcelo
Create a safe wrapper by protecting the signal mask. Instead of doing a simple passthrough of the sigprocmask, the wrapper manipulates the signal mask in a safe way for the qemu internal. This is done by avoiding SIGSEGV bit mask manipulation from the guest. We also return the same bit on the

[Qemu-devel] [PATCH 00/14] pixman patch series.

2012-10-17 Thread Gerd Hoffmann
Hi, First round of pixman patches for qemu, so we have something concrete to discuss. Applies on top of the console cleanups patch series posted a few days ago. The long-term goal is to stop reinventing the wheel over and over when it comes to pixel manipulation and to use pixman instead.

Re: [Qemu-devel] [PATCH 0/2] signal: Preparing safe sigprocmask wrapper on qemu-user

2012-10-17 Thread Alex Barcelo
Thanks Peter for all the feedback! I have just sent the v2 (have been on holiday this weekend, a bit offline). I hope that this one is a better patch. Sorry Riku, I have doubleposted the new patch to you, I slipped on the git send-email command, and sent the patch only to you at first (not to the

Re: [Qemu-devel] [PATCH 03/14] pixman: windup in configure makefiles

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 15:29, Gerd Hoffmann ha scritto: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- Makefile |9 + configure | 38 ++ 2 files changed, 47 insertions(+), 0 deletions(-) diff --git a/Makefile b/Makefile index a9c22bf..5699101

Re: [Qemu-devel] [PATCH 07/25] migration: use qemu-sockets to establish Unix sockets

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: This makes migration-unix.c again a cut-and-paste job from migration-tcp.c, exactly as it was in the beginning. :) Neat!

[Qemu-devel] [PATCH 01/14] console: remove DisplayAllocator

2012-10-17 Thread Gerd Hoffmann
Causes [temporary] preformance regression with 24bpp vga modes @ sdl. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 52 + console.h | 34 +++-- qemu-common.h |1 - ui/sdl.c | 117

[Qemu-devel] [PATCH 10/14] pixman: switch screendump function.

2012-10-17 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/vga.c | 39 +++ 1 files changed, 11 insertions(+), 28 deletions(-) diff --git a/hw/vga.c b/hw/vga.c index 4d34469..4ffd57c 100644 --- a/hw/vga.c +++ b/hw/vga.c @@ -2417,13 +2417,12 @@ void

[Qemu-devel] [PATCH 07/14] console: don't set PixelFormat alpha fields for 32bpp

2012-10-17 Thread Gerd Hoffmann
Currently it is inconstent, PixelFormat-amask is left unset whereas abits and amax and ashift are filled. As an alpha channel doesn't make sense for the vga framebuffer leave all alpha fields clear. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c |3 --- 1 files changed, 0

[Qemu-devel] [PATCH 05/14] pixman: add pixman image to DisplaySurface

2012-10-17 Thread Gerd Hoffmann
Surfaces are now allocated using pixman. DisplaySurface gets new struct fields with pixman image and data. DisplayChangeListeners can easily start using pixman now. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- console.c | 37 - console.h |3 +++

Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Hans de Goede
Hi, On 10/17/2012 01:29 PM, Gerd Hoffmann wrote: Hi, +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called for devices which call these functions themselves. + */ +int

[Qemu-devel] [PATCH 11/14] pixman/vnc: use pixman images in vnc.

2012-10-17 Thread Gerd Hoffmann
The vnc code uses *three* DisplaySurfaces: First is the surface of the actual QemuConsole, usually the guest screen, but could also be a text console (monitor/serial reachable via Ctrl-Alt-nr keys). This is left as-is. Second is the current server's view of the screen content. The vnc code

Re: [Qemu-devel] [PATCH 08/25] migration (outgoing): add error propagation for all protocols

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Error propagation is already there for socket backends, even though it is (and remains) incomplete because no Error is passed to the NonBlockingConnectHandler. Why is that a problem? Add it to other protocols, simplifying

Re: [Qemu-devel] [RFC PATCH 0/6] chardev: convert to QOM

2012-10-17 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, I think the main decision point here is whether we introduce a separate chardev_add/chardev_del command or just use the qom-create command that has been posted previously. Do you have a git tree with this series + qom-create to look at and play

Re: [Qemu-devel] [PATCHv4] qemu-img rebase: use empty string to rebase without backing file

2012-10-17 Thread Kevin Wolf
Am 16.10.2012 14:46, schrieb Alex Bligh: This patch allows an empty filename to be passed as the new base image name for qemu-img rebase to mean base the image on no backing file (i.e. independent of any backing file). According to Eric Blake, qemu-img rebase already supports this when '-u' is

Re: [Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command

2012-10-17 Thread Kevin Wolf
Am 17.10.2012 14:02, schrieb Stefan Hajnoczi: This series adds the --backing-chain option for enumerating the backing file chain. Given the topmost image it will print qemu-img info information for each image file in the chain. Special care needs to be taken when image files form an

Re: [Qemu-devel] [PATCH] Memory-API: Make eventfd adhere to device endianness

2012-10-17 Thread Avi Kivity
On 10/15/2012 08:30 PM, Alexander Graf wrote: Our memory API MMIO regions know the concept of device endianness. This is used to automatically swap endianness between devices and host CPU, depending on whether buses in between would swizzle the bits. The ioeventfd value comparison does not

Re: [Qemu-devel] [PATCH 08/25] migration (outgoing): add error propagation for all protocols

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 16:43, Markus Armbruster ha scritto: Error propagation is already there for socket backends, even though it is (and remains) incomplete because no Error is passed to the NonBlockingConnectHandler. Why is that a problem? It means that the exact error message still cannot be

Re: [Qemu-devel] [PATCH 11/25] nbd: ask and print error information from qemu-sockets

2012-10-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Before: $ qemu-system-x86_64 nbd:localhost:12345 inet_connect_opts: connect(ipv4,yakj.usersys.redhat.com,127.0.0.1,12345): Connection refused qemu-system-x86_64: could not open disk image nbd:localhost:12345: Connection refused

Re: [Qemu-devel] [PATCH v3 0/2] qemu-img: Add --backing-chain option to info command

2012-10-17 Thread Eric Blake
On 10/17/2012 08:47 AM, Kevin Wolf wrote: Am 17.10.2012 14:02, schrieb Stefan Hajnoczi: This series adds the --backing-chain option for enumerating the backing file chain. Given the topmost image it will print qemu-img info information for each image file in the chain. Thanks applied both

Re: [Qemu-devel] [PATCH 1/2] vnc: fix segfault due to failed handshake

2012-10-17 Thread Andreas Färber
Am 14.10.2012 15:08, schrieb Tim Hardeck: When the VNC server disconnects due to a failed handshake we don't have vs-bh allocated yet. Check for this case and don't delete it. Signed-off-by: Tim Hardeck thard...@suse.de --- ui/vnc.c |4 +++- 1 file changed, 3 insertions(+), 1

Re: [Qemu-devel] [PATCH 11/25] nbd: ask and print error information from qemu-sockets

2012-10-17 Thread Paolo Bonzini
Il 17/10/2012 16:51, Markus Armbruster ha scritto: /* Basic flow for negotiation The boilerplate pattern Error *local_err = NULL; FOO(..., *local_err); if (local_err) { qerror_report_err(local_err); error_free(local_err); } is spreading. Not quite

Re: [Qemu-devel] [PATCH 2/2] qemu queue: fix uninitialized removals

2012-10-17 Thread Andreas Färber
Tim, Am 14.10.2012 15:08, schrieb Tim Hardeck: When calling QTAILQ_REMOVE or QLIST_REMOVE on an unitialized list QEMU segfaults. Can this be reproduced by a user today? Or is this just fixing the case that a developer forgot to initialize a list? Regards, Andreas Check for this case

Re: [Qemu-devel] [PATCHv2 1/2] signal: added a wrapper for sigprocmask function

2012-10-17 Thread Peter Maydell
On 17 October 2012 15:18, Alex Barcelo abarc...@ac.upc.edu wrote: Create a wrapper for signal mask changes initiated by the guest; this will give us a place to put code which prevents the guest from changing the handling of signals used by QEMU itself internally. The wrapper is called from

Re: [Qemu-devel] [PATCH v3 4/4] qemu-config: Add new -add-fd command line option

2012-10-17 Thread Eric Blake
On 10/17/2012 08:02 AM, Kevin Wolf wrote: Am 17.10.2012 06:16, schrieb Eric Blake: I'm still seeing the corner case of: qemu-kvm -add-fd fd=3,set=1 -add-fd fd=4,set=2 4- where the dup(3) will populate fd 4 prior to the point where we get to process the -add-fd fd=4 command to notice that

  1   2   3   >