Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread David Woodhouse
On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers. Which means your suspend/resume is broken.

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2013 at 11:02:31AM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Feb 21, 2013 at 10:15:58AM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Feb 21, 2013 at 08:54:44PM +0800, Liu Ping Fan wrote: This

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2013 at 06:45:54PM +0200, Michael S. Tsirkin wrote: On Thu, Feb 21, 2013 at 10:15:58AM -0600, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Thu, Feb 21, 2013 at 08:54:44PM +0800, Liu Ping Fan wrote: This is a emulation to virtio-blk dataplane,

Re: [Qemu-devel] [PATCH 04/41] migration: push qemu_savevm_state_cancel out of qemu_savevm_state_*

2013-02-21 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: This is useful, because it lets us keep the cancellation callbacks inside the big lock while pushing the others out. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com If we need to rebase: ret =

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:12, David Woodhouse ha scritto: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers. Which means your suspend/resume is broken.

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Laszlo Ersek
On 02/21/13 18:12, David Woodhouse wrote: On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers.

Re: [Qemu-devel] [PATCH 05/41] block-migration: remove useless calls to blk_mig_cleanup

2013-02-21 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Now that the cancel callback is called consistently for all errors, we can avoid doing its work in the other callbacks. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 21/02/2013 17:29, Jan Kiszka ha scritto: In this context, I'd like to recall a detail: Real-time prioritization of those I/O threads will most probably require locking with prio-inversion avoidance (*). In that case external libs without a chance

Re: [Qemu-devel] [RFC for-1.4] Revert block: fix block tray status

2013-02-21 Thread Luiz Capitulino
On Thu, 7 Feb 2013 11:31:08 -0200 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 07 Feb 2013 14:28:33 +0100 Kevin Wolf kw...@redhat.com wrote: Am 07.02.2013 14:15, schrieb Luiz Capitulino: On Thu, 07 Feb 2013 14:12:10 +0100 Kevin Wolf kw...@redhat.com wrote: I think the

Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-21 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Always use qemu_file_get_error to detect errors, since that is how QEMUFile itself drops I/O after an error occurs. There is no need to propagate and check return values all the time. Also remove the complete member, since we know that it is set (via

Re: [Qemu-devel] [PATCH v4 3/6] add backup related monitor commands

2013-02-21 Thread Luiz Capitulino
On Thu, 21 Feb 2013 14:47:08 +0100 Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, Feb 21, 2013 at 06:21:32AM +, Dietmar Maurer wrote: +## +# @backup: +# +# Starts a VM backup. +# +# @backup-file: the backup file name +# +# @format: format of the backup file

Re: [Qemu-devel] [PATCH 13/41] migration: prepare to access s-state outside critical sections

2013-02-21 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Accessing s-state outside the big QEMU lock will simplify a bit the locking/unlocking of the iothread lock. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com We compensate the locking removal you did on

Re: [Qemu-devel] [PATCH 4/4] piix_pci: Implement reset for i440FX PAM configuration

2013-02-21 Thread Laszlo Ersek
On 02/21/13 12:02, David Woodhouse wrote: On Thu, 2013-02-21 at 09:17 +, David Woodhouse wrote: Thanks. I suppose I'd better test that I haven't broken suspend/resume first. I don't care about OS/2 or VDISK, but it's vaguely possible that suspend/resume might be another reset user which

Re: [Qemu-devel] [PATCH 13/41] migration: prepare to access s-state outside critical sections

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:42, Juan Quintela ha scritto: Paolo Bonzini pbonz...@redhat.com wrote: Accessing s-state outside the big QEMU lock will simplify a bit the locking/unlocking of the iothread lock. Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v4 4/6] introduce new vma archive format

2013-02-21 Thread Eric Blake
On 02/21/2013 08:32 AM, Dietmar Maurer wrote: Hint - look at how the qcow2 file format is specified. You need a lot more details - enough that someone could independently implement a program to read and create vma images that would be compatible with what your implementation produces. The

Re: [Qemu-devel] [PATCH 11/41] migration: simplify error handling

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:34, Juan Quintela ha scritto: This move buffered_flush() to inside the iothread lock. At least the commit message needs to be changed. No, it doesn't... Here is the full body of the migration thread: qemu_mutex_lock_iothread(); qemu_savevm_state_begin(s-file,

[Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-21 Thread Stefan Hajnoczi
Please try this patch: http://patchwork.ozlabs.org/patch/12/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1130533 Title: Documentation cannot be build since commit

[Qemu-devel] [Bug 1130533] Re: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39

2013-02-21 Thread FredBezies
Tried it. You can add it, it works ! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1130533 Title: Documentation cannot be build since commit c70a01e449536c616c85ab820c6fbad7d7e9cf39 Status in

[Qemu-devel] [PATCH 2/2] xnu kernel expects FLUSH to be cleared on STOP

2013-02-21 Thread Amadeusz Sławiński
otherwise it gets stuck in a loop so clear it when unsetting run when flush is set void IODBDMAStop( volatile IODBDMAChannelRegisters *registers) { IOSetDBDMAChannelControl( registers, IOClearDBDMAChannelControlBits( kdbdmaRun ) | IOSetDBDMAChannelControlBits(

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 18:25, Anthony Liguori ha scritto: What would be more problematic is the chardev flow control patches, which use the glib main loop directly. I don't recall your KVM forum presentation---did you need RT prioritization of the serial port too? It uses GSources which don't

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Anthony Liguori
David Woodhouse dw...@infradead.org writes: On Thu, 2013-02-21 at 18:10 +0100, Laszlo Ersek wrote: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM

Re: [Qemu-devel] [PATCH 12/14] usb-core: usb3 streams

2013-02-21 Thread Eduardo Habkost
On Thu, Feb 21, 2013 at 10:59:11AM +0100, Gerd Hoffmann wrote: This patch adds support for usb3 streams to the usb subsystem core. This is just adding a streams field / parameter in a number of places. Signed-off-by: Gerd Hoffmann kra...@redhat.com This broke the build on master: CC

[Qemu-devel] [PATCH] hw/usb/redirect.c: add missing parameter to usb_wakeup()

2013-02-21 Thread Eduardo Habkost
commit 8550a02d1239415342959f6a32d178bc05c557cc broke the build because the usb_wakeup() call wasn't changed to include the new 'stream' parameter. This changes the call to pass 0 as the 'stream' parameter. Signed-off-by: Eduardo Habkost ehabk...@redhat.com --- hw/usb/redirect.c | 2 +- 1 file

Re: [Qemu-devel] [RFC PATCH 3/3] KVM: s390: Hook up ioeventfds.

2013-02-21 Thread Cornelia Huck
On Thu, 21 Feb 2013 18:34:59 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 21, 2013 at 04:21:43PM +0100, Cornelia Huck wrote: On Thu, 21 Feb 2013 16:39:05 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 21, 2013 at 02:13:00PM +0100, Cornelia Huck wrote: As

[Qemu-devel] [PULL] QMP queue

2013-02-21 Thread Luiz Capitulino
The changes (since 70aa41b56ce3f34fceac44e828ba2d8cc19523ee) are available in the following repository: git://repo.or.cz/qemu/qmp-unstable.git queue/qmp Markus Armbruster (1): check-qjson: More thorough testing of UTF-8 in strings tests/check-qjson.c | 664

[Qemu-devel] [PULL] check-qjson: More thorough testing of UTF-8 in strings

2013-02-21 Thread Luiz Capitulino
From: Markus Armbruster arm...@redhat.com Test cases are scraped from Markus Kuhn's UTF-8 decoder capability and stress test at http://www.cl.cam.ac.uk/~mgk25/ucs/examples/UTF-8-test.txt Unfortunately, both JSON parser and formatter misbehave right now. This test expects current, incorrect

Re: [Qemu-devel] [PATCH 01/41] migration: simplify while loop

2013-02-21 Thread Juan Quintela
Paolo Bonzini pbonz...@redhat.com wrote: Unify the goto around the loop, with the exit condition at the end of it. Both can be expressed as while (ret = 0). Signed-off-by: Paolo Bonzini pbonz...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com

[Qemu-devel] OvmfPkg reset [was: Distinguish between reset types]

2013-02-21 Thread Laszlo Ersek
(1) The reset capability that OVMF exports via ACPI -- I agree that I should be effecting the 0xCF9 thing in the appropriate table. On a second thought, this will require a new build -D flag, or a PCD. I'm not worried about the ACPI 1.0 -- ACPI 2.0 change in the FADT, the table struct itself

[Qemu-devel] [PATCH 1/2] Fix dma interrupt

2013-02-21 Thread Amadeusz Sławiński
In openbios (drivers/ide.c) they are set to 000d 0002 000e 0003 000f 0004 (The last one seems to be not implemented in qemu) It follows convention of how they are set on real machines, both ide and dma ones are

[Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-02-21 Thread Matthew Anderson
If this isn't the correct list just let me know, I've run into a bug whereby a Windows guest (tested on Server 2008R2 and 2012) no longer receives RTC ticks when it has been idle for a random amount of time. HPET is disabled and the guest is running Hyper-V relaxed timers (same situation

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Jan Kiszka
On 2013-02-21 18:10, Paolo Bonzini wrote: Il 21/02/2013 17:29, Jan Kiszka ha scritto: In this context, I'd like to recall a detail: Real-time prioritization of those I/O threads will most probably require locking with prio-inversion avoidance (*). In that case external libs without a chance

Re: [Qemu-devel] [PATCH v4 00/10] main-loop: switch to g_poll(3) on POSIX hosts

2013-02-21 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 21/02/2013 18:25, Anthony Liguori ha scritto: What would be more problematic is the chardev flow control patches, which use the glib main loop directly. I don't recall your KVM forum presentation---did you need RT prioritization of the serial

Re: [Qemu-devel] [edk2] [RFC PATCH] Distinguish between reset types

2013-02-21 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 21/02/2013 18:12, David Woodhouse ha scritto: Since - I like kvm, and - I cannot easily change my hardware (which doesn't support UG), and - I prefer to run the RHEL-6 kernel which has old KVM, I depend on David's fix for the PAM registers.

Re: [Qemu-devel] [edk2] OvmfPkg reset [was: Distinguish between reset types]

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 19:24, Laszlo Ersek ha scritto: (1) The reset capability that OVMF exports via ACPI -- I agree that I should be effecting the 0xCF9 thing in the appropriate table. On a second thought, this will require a new build -D flag, or a PCD. I'm not worried about the ACPI 1.0 -- ACPI

[Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Eduardo Habkost
This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the command-line will look like: -numa node,cpus=A,,B,,C,,D Note that the following format, currently used by libvirt: -numa

Re: [Qemu-devel] [edk2] OvmfPkg reset [was: Distinguish between reset types]

2013-02-21 Thread Laszlo Ersek
On 02/21/13 20:31, Paolo Bonzini wrote: Il 21/02/2013 19:24, Laszlo Ersek ha scritto: (1) The reset capability that OVMF exports via ACPI -- I agree that I should be effecting the 0xCF9 thing in the appropriate table. On a second thought, this will require a new build -D flag, or a PCD. I'm

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code

2013-02-21 Thread Michael S. Tsirkin
On Mon, Feb 11, 2013 at 05:49:53PM -0500, Michael R. Hines wrote: From: Michael R. Hines mrhi...@us.ibm.com Signed-off-by: Michael R. Hines mrhi...@us.ibm.com --- include/qemu/rdma.h | 281 ++ migration-rdma.c| 1444 +++ 2

Re: [Qemu-devel] [PATCH 24028/24028] Evaluate breakpoint condition on target.

2013-02-21 Thread Paul Brook
In addition to the comments others made about patch formatting, etc: +/* conditional breakpoint evaluation on target*/ +pstrcat(buf, sizeof(buf), ;ConditionalBreakpoints+); I'm pretty sure this is a lie for most targets, given later on we have: +#if

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 4/6] initialize RDMA options when QEMU first runs on command-line

2013-02-21 Thread Michael S. Tsirkin
On Tue, Feb 19, 2013 at 09:42:45AM +0100, Paolo Bonzini wrote: Il 19/02/2013 07:00, Michael R. Hines ha scritto: Yes, this is done at migration time (see functions rdma_client_init and rdma_server_prepare()) To explain the host and port: The separate host and port are used by the

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0

2013-02-21 Thread Anthony Liguori
Peter Crosthwaite peter.crosthwa...@xilinx.com writes: num_interfaces only tells you how many interfaces the concrete child class has (as defined in the TypeInfo). This means if you have a child class which defines no interfaces of its own, but its parent has interfaces you cannot cast to

Re: [Qemu-devel] [PATCH v2 2/2] qom/object.c: Allow itf cast with num_itfs = 0

2013-02-21 Thread Anthony Liguori
Anthony Liguori aligu...@us.ibm.com writes: Peter Crosthwaite peter.crosthwa...@xilinx.com writes: num_interfaces only tells you how many interfaces the concrete child class has (as defined in the TypeInfo). This means if you have a child class which defines no interfaces of its own, but

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-21 Thread Michael S. Tsirkin
On Thu, Feb 14, 2013 at 02:29:09PM -0500, Michael R. Hines wrote: Orit (and anthony if you're not busy), I forgot to respond to this very important comment: On 02/13/2013 03:46 AM, Orit Wasserman wrote: Are you still using the tcp for transferring device state? If so you can

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-21 Thread Michael S. Tsirkin
On Tue, Feb 19, 2013 at 10:41:08AM -0500, Michael R. Hines wrote: On 02/18/2013 03:24 AM, Orit Wasserman wrote: Hi Michael, The guest device state is quite small (~100K probably less) especially when compared to the guest memory and we already are pinning the guest memory for RDMA any way I

Re: [Qemu-devel] [PATCH 3/9] event poll: make epoll work for normal fd

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:47PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com When event poll can work with normal fd, we can port them onto the event loop. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c | 36

[Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

2013-02-21 Thread Serge E. Hallyn
The snprintf format isn't taking into account the new 'left' and 'right' variables (for ipv6 []) when placing the ':', which should go immediately before the port. Signed-off-by: Serge Hallyn serge.hal...@ubuntu.com --- qemu-char.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the command-line will look like: -numa node,cpus=A,,B,,C,,D This is really, really ugly, and an

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 2/6] create migration-rdma.c for core RDMA migration code

2013-02-21 Thread Michael S. Tsirkin
On Mon, Feb 11, 2013 at 05:49:53PM -0500, Michael R. Hines wrote: +struct rdma_data { Picking on this but it's everywhere: should be RdmaData, with a typedef. Please check CODING_STYLE and follow the rules. Also, prefixing everything with rdma_ means I can't figure out which functions are local

Re: [Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

2013-02-21 Thread Michael Tokarev
22.02.2013 00:20, Serge E. Hallyn wrote: The snprintf format isn't taking into account the new 'left' and 'right' variables (for ipv6 []) when placing the ':', which should go immediately before the port. This fixes actual isse (also found by Serge), where `info chardev' prints

Re: [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the command-line will look like: -numa

Re: [Qemu-devel] [RFC PATCH 3/3] KVM: s390: Hook up ioeventfds.

2013-02-21 Thread Michael S. Tsirkin
On Thu, Feb 21, 2013 at 07:14:31PM +0100, Cornelia Huck wrote: On Thu, 21 Feb 2013 18:34:59 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Thu, Feb 21, 2013 at 04:21:43PM +0100, Cornelia Huck wrote: On Thu, 21 Feb 2013 16:39:05 +0200 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] Block I/O optimizations

2013-02-21 Thread Loic Dachary
Hi Stefan, Thanks a lot, I'm looking forward to it ;-) Cheers On 02/21/2013 09:11 AM, Stefan Hajnoczi wrote: On Mon, Feb 18, 2013 at 7:19 PM, Loic Dachary l...@dachary.org wrote: I recently tried to figure out the best and easiest ways to increase block I/O performances with qemu. Not being

Re: [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Markus Armbruster
Anthony Liguori anth...@codemonkey.ws writes: Markus Armbruster arm...@redhat.com writes: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the

Re: [Qemu-devel] [RFC PATCH RDMA support v2: 5/6] connection-setup code between client/server

2013-02-21 Thread Michael S. Tsirkin
I don't think people mind using RDMA specifically, small amounts of data can be sent using SEND commands. But it's cleaner not to use TCP for parts of data. On Tue, Feb 19, 2013 at 01:03:59AM -0500, Michael R. Hines wrote: This sounds great. My team was just discussing customizing

Re: [Qemu-devel] [PATCH 5/9] event poll: enable event poll handle more than one event each time

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:49PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Set handled event count at initialized time for the dedicated thread. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/dataplane/event-poll.c | 31

Re: [Qemu-devel] [PATCH] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Eduardo Habkost
On Thu, Feb 21, 2013 at 09:23:22PM +0100, Markus Armbruster wrote: Eduardo Habkost ehabk...@redhat.com writes: This allows , to be used a separator between each CPU range. Note that commas inside key=value command-line options have to be escaped using ,,, so the command-line will look

Re: [Qemu-devel] [PATCH 6/9] virtio net: introduce dataplane for virtio net

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 08:54:50PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This is a emulation to virtio-blk dataplane, which push the data handling out of biglock. And it is a try to implement this process in userspace, while vhost-net in kernel.

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:05:44PM +0100, Paolo Bonzini wrote: Il 21/02/2013 17:33, Stefan Hajnoczi ha scritto: Interesting patch series. I want to share my thoughts on the status of dataplane and what I'm currently working on. There will probably be some overlap that we can coordinate.

Re: [Qemu-devel] [PATCH 24028/24028] Evaluate breakpoint condition on target.Mechanism: translate gdb bytecode to TCG code and add to the translation block. Most of code is located in the new file tra

2013-02-21 Thread Peter Maydell
On 21 February 2013 14:02, Anna Neiman anna_nei...@mentor.com wrote: +#if defined(TARGET_ARM) +cpu_get_reg_var_func = cpu_get_reg_var_arm; +#else +cpu_get_reg_var_func = 0; +#endif No new for-each-target #ifdef ladders, please. Consider also whether you can abstract away some of the

Re: [Qemu-devel] [PATCH] dataplane: remove EventPoll in favor of AioContext

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote: During the review of the dataplane code, the EventPoll API morphed itself (not concidentially) into something very very similar to an AioContext. Thus, it is trivial to convert virtio-blk-dataplane to use AioContext, and a first

[Qemu-devel] [PATCH v2] vl.c: Support multiple CPU ranges on -numa option

2013-02-21 Thread Eduardo Habkost
This allows : to be used a separator between each CPU range, so the command-line may look like: -numa node,cpus=A-B:C-D Note that the following format, currently used by libvirt: -numa nodes,cpus=A-B,C-D will _not_ work, as , is the option separator for the command-line option parser, and

[Qemu-devel] [PATCH] xhci: fix bad print specifier

2013-02-21 Thread Hervé Poussineau
This fixes the following compilation error: hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘unsigned int’ Signed-off-by: Hervé Poussineau hpous...@reactos.org --- hw/usb/hcd-xhci.c |4 ++-- 1 file changed, 2

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: A socket may still have references to it in various queues at the time it is freed, causing memory corruptions. Signed-off-by: Vitaly Chipounov vitaly.chipou...@epfl.ch --- slirp/socket.c | 29 +

Re: [Qemu-devel] [PATCH] slirp: fixed potential use-after-free of a socket

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 03:47:25PM -0600, mdroth wrote: On Fri, Feb 15, 2013 at 12:00:13PM +0100, Vitaly Chipounov wrote: A socket may still have references to it in various queues at the time it is freed, causing memory corruptions. Signed-off-by: Vitaly Chipounov

Re: [Qemu-devel] [PATCH] dataplane: remove EventPoll in favor of AioContext

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 22:32, mdroth ha scritto: On Thu, Feb 21, 2013 at 05:29:55PM +0100, Paolo Bonzini wrote: During the review of the dataplane code, the EventPoll API morphed itself (not concidentially) into something very very similar to an AioContext. Thus, it is trivial to convert

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 22:07, mdroth ha scritto: 100% agree. In particular hw/dataplane/event-poll.c should be the first to go away, but AioContext provides the functionality that Ping Fan needs. But hw/dataplane/vring.c will probably be here for a longer Has there been any discussion around

Re: [Qemu-devel] [PATCH] fix wrong output with 'info chardev' for tcp socket.

2013-02-21 Thread mdroth
On Fri, Feb 22, 2013 at 12:29:44AM +0400, Michael Tokarev wrote: 22.02.2013 00:20, Serge E. Hallyn wrote: The snprintf format isn't taking into account the new 'left' and 'right' variables (for ipv6 []) when placing the ':', which should go immediately before the port. This fixes actual

Re: [Qemu-devel] [PATCH v4 0/6] Efficient VM backup for qemu

2013-02-21 Thread Paolo Bonzini
Il 21/02/2013 16:56, Dietmar Maurer ha scritto: In _your_ use case. That means that we should support using non-seekable pipes, but it doesn't mean that any other use case is irrelevant. In fact I think backing up to a normal raw or qcow2 image file is the interesting case for the

Re: [Qemu-devel] [PATCH] net: reduce the unnecessary memory allocation of multiqueue

2013-02-21 Thread Anthony Liguori
Jason Wang jasow...@redhat.com writes: Edivaldo reports a problem that the array of NetClientState in NICState is too large - MAX_QUEUE_NUM(1024) which will wastes memory even if multiqueue is not used. Instead of static arrays, solving this issue by allocating the queues on demand for

[Qemu-devel] GTK UI is now the default

2013-02-21 Thread Anthony Liguori
Since this is a pretty visible change for a lot of people, I thought I'd send a top level note. The GTK UI is now committed and is the default UI provided it's available. For anyone counting, it's been a little more than 7 years in the making:

Re: [Qemu-devel] BUG: RTC issue when Windows guest is idle

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 06:16:10PM +, Matthew Anderson wrote: If this isn't the correct list just let me know, I've run into a bug whereby a Windows guest (tested on Server 2008R2 and 2012) no longer receives RTC ticks when it has been idle for a random amount of time. HPET is disabled

[Qemu-devel] Build failure with -werror on i386

2013-02-21 Thread David Holsgrove
Configuring QEMU as ./configure --target-list=i386-softmmu --cpu=i386 --enable-werror results in following error cc1: warnings being treated as errors qemu-char.c: In function 'qmp_ringbuf_write': qemu-char.c:2764: error: passing argument 2 of 'g_base64_decode' from incompatible pointer type

Re: [Qemu-devel] [PATCH 0/9] introduce virtio net dataplane

2013-02-21 Thread mdroth
On Thu, Feb 21, 2013 at 11:12:01PM +0100, Paolo Bonzini wrote: Il 21/02/2013 22:07, mdroth ha scritto: 100% agree. In particular hw/dataplane/event-poll.c should be the first to go away, but AioContext provides the functionality that Ping Fan needs. But hw/dataplane/vring.c will

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] powerpc iommu: multiple TCE requests enabled

2013-02-21 Thread David Gibson
On Tue, Feb 19, 2013 at 06:43:35PM +1100, Alexey Kardashevskiy wrote: Currently only single TCE entry per requiest is supported (H_PUT_TCE). However PAPR+ specification allows multiple entry requests such as H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having less transitions to the host kernel via

Re: [Qemu-devel] [PATCH] seabios: Add a dummy PCI slot to irq mapping function

2013-02-21 Thread Kevin O'Connor
On Thu, Feb 21, 2013 at 09:12:23AM -0700, Alex Williamson wrote: This should never get called, but if we somehow get a new chipset that fails to implement their own pci_slot_get_irq function, fail gracefully and add a debug log message. Thanks. I pushed this and the second part of your

[Qemu-devel] CPU scheduling with TCG in SMP system emulation mode

2013-02-21 Thread Max Filippov
Hello. Do I understand it right that there's no dedicated mechanism other than icount that would switch current CPU in emulated SMP system and that in the absence of icount such scheduling is a side effect of interrupt delivery to the current CPU? -- Thanks. -- Max

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] powerpc iommu: multiple TCE requests enabled

2013-02-21 Thread Alexey Kardashevskiy
On 22/02/13 09:52, David Gibson wrote: On Tue, Feb 19, 2013 at 06:43:35PM +1100, Alexey Kardashevskiy wrote: Currently only single TCE entry per requiest is supported (H_PUT_TCE). However PAPR+ specification allows multiple entry requests such as H_PUT_TCE_INDIRECT and H_STUFFF_TCE. Having less

Re: [Qemu-devel] [PATCH for-1.4] pc: tag apic as overlap region

2013-02-21 Thread Alexey Korolev
On Wed, Feb 20, 2013 at 4:20 AM, Michael S. Tsirkin m...@redhat.com wrote: apic overlaps PCI space. On real hardware it has higher priority, emulate this correctly. This should addresses the following issue: Subject: Re: [BUG] Guest OS hangs on boot when 64bit BAR present (kvm-apic-msi

[Qemu-devel] [PATCH] qemu: define a TOM register to report the base of PCI

2013-02-21 Thread Xudong Hao
Define a TOM(top of memory) register to report the base of PCI memory, update memory region dynamically. The use case of this register defination is for Xen till now. Signed-off-by: Xudong Hao xudong@intel.com Signed-off-by: Xiantao Zhang xiantao.zh...@intel.com --- hw/pc.h | 4 ---

[Qemu-devel] [PATCH v4 RESEND 3/5] sheepdog: accept URIs

2013-02-21 Thread MORITA Kazutaka
The URI syntax is consistent with the NBD and Gluster syntax. The syntax is sheepdog[+tcp]://[host:port]/vdiname[#snapid|#tag] Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- block/sheepdog.c | 139 +-- qemu-doc.texi|

[Qemu-devel] [PATCH v4 RESEND 2/5] move socket_set_nodelay to osdep.c

2013-02-21 Thread MORITA Kazutaka
Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- block/sheepdog.c | 11 +-- gdbstub.c | 5 ++--- include/qemu/sockets.h | 1 + qemu-char.c| 6 -- slirp/tcp_subr.c | 3 +-- util/osdep.c | 6 ++ 6 files changed, 11

[Qemu-devel] [PATCH v4 RESEND 1/5] slirp/tcp_subr.c: fix coding style in tcp_connect

2013-02-21 Thread MORITA Kazutaka
Fix coding style in tcp_connect before the next patch. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- slirp/tcp_subr.c | 140 --- 1 file changed, 72 insertions(+), 68 deletions(-) diff --git a/slirp/tcp_subr.c

[Qemu-devel] [PATCH v4 RESEND 5/5] sheepdog: add support for connecting to unix domain socket

2013-02-21 Thread MORITA Kazutaka
This patch adds support for a unix domain socket for a connection between qemu and local sheepdog server. You can use the unix domain socket with the following syntax: $ qemu sheepdog+unix:///vdiname?socket=socket path[#snapid] Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp ---

[Qemu-devel] [PATCH v4 RESEND 4/5] sheepdog: use inet_connect to simplify connect code

2013-02-21 Thread MORITA Kazutaka
This uses the form host:port for the representation of the sheepdog server to use inet_connect. Signed-off-by: MORITA Kazutaka morita.kazut...@lab.ntt.co.jp --- block/sheepdog.c | 111 +++ 1 file changed, 30 insertions(+), 81 deletions(-) diff

[Qemu-devel] [PATCH v4 RESEND 0/5] sheepdog: unix domain socket support

2013-02-21 Thread MORITA Kazutaka
This series makes sheepdog accept URI syntax, and adds a unix domain socket support for a connection between qemu and local sheepdog server based on the syntax. Changes from v3: - fix wrong URI syntax in the commit log Changes from v2: - fix coding style in tcp_connect - accept URI syntax

[Qemu-devel] [PATCH v2] Fix guest OS hang when 64bit PCI bar present

2013-02-21 Thread Alexey Korolev
This patch addresses the issue fully described here: http://lists.nongnu.org/archive/html/qemu-devel/2013-02/msg01804.html Linux kernels prior to 2.6.36 do not disable the PCI device during enumeration process. Since lower and higher parts of a 64bit BAR are programmed separately this leads to

[Qemu-devel] [PATCH v2 6/6] load_linux: change kernel header size allocation

2013-02-21 Thread liguang
it's not necessary to alloc 8K bytes for kernel header, 0.5K is enough. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/pc.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index 30b3262..4f78d4f 100644 --- a/hw/pc.c +++ b/hw/pc.c @@

[Qemu-devel] [PATCH v2 0/6] change acpi numa info format passed from qemu to seabios

2013-02-21 Thread liguang
orginally, numa info was packed into an array of 64-bit data which was implicit and hard to maintain, so we define a struct for these info, hope to be as clear as enough. these changes also involved seabios paches which was sent to seabios mail-list. v2: changes to fix coding style

[Qemu-devel] [PATCH v2 5/6] load_linux: report open kernel file its size error

2013-02-21 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/pc.c | 16 +--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index fd3a68c..30b3262 100644 --- a/hw/pc.c +++ b/hw/pc.c @@ -652,12 +652,22 @@ static void load_linux(void *fw_cfg, char

[Qemu-devel] [PATCH v2 1/6] pc/bios: move common BIOS_CFG_IOPORT into fw_cfg.h

2013-02-21 Thread liguang
BIOS_CFG_IOPORT are commonly used, so move it to fw_cfg.h bochs_bios_init seems misleading, bios may be seabios, seabios is not only for bochs, and also we are in qemu. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/fw_cfg.h |4 hw/pc.c |9 - hw/sun4u.c |3

[Qemu-devel] [PATCH v2 4/6] pc: format load_linux()

2013-02-21 Thread liguang
seems this function was in wrong coding format so try correct it boldly. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/pc.c | 90 +++--- 1 files changed, 45 insertions(+), 45 deletions(-) diff --git a/hw/pc.c b/hw/pc.c index

[Qemu-devel] [PATCH v2 2/6] pc/numa: refactor bios_init function

2013-02-21 Thread liguang
orginally, numa data was packed into an array, which was implicit and hard to maintain, we define a struct for this data, hope to be as clear as enough. also, we only pass cpumask of corresponding nodes to seabios, and leave the paring work for it. Signed-off-by: liguang lig.f...@cn.fujitsu.com

[Qemu-devel] [PATCH v2 3/6] bitops: change BITS_TO_LONGS

2013-02-21 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- include/qemu/bitops.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/include/qemu/bitops.h b/include/qemu/bitops.h index 74e14e5..7758792 100644 --- a/include/qemu/bitops.h +++ b/include/qemu/bitops.h @@ -20,7 +20,7 @@

Re: [Qemu-devel] [PATCH] help: add docs for multiqueue tap options

2013-02-21 Thread Jason Wang
On 02/21/2013 11:09 PM, Markus Armbruster wrote: Jason Wang jasow...@redhat.com writes: Cc: Markus Armbruster arm...@redhat.com Cc: Jason Wang jasow...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com --- This patch is neede for 1.4 stable also. --- qapi-schema.json |6 ++

Re: [Qemu-devel] [PATCH] help: add docs for multiqueue tap options

2013-02-21 Thread Jason Wang
On 02/21/2013 11:12 PM, Markus Armbruster wrote: Jason Wang jasow...@redhat.com writes: Cc: Markus Armbruster arm...@redhat.com Cc: Jason Wang jasow...@redhat.com Signed-off-by: Jason Wang jasow...@redhat.com --- This patch is neede for 1.4 stable also. Forgot to mention, the recommended

Re: [Qemu-devel] [PATCH v4 4/6] introduce new vma archive format

2013-02-21 Thread Dietmar Maurer
Not in qemu. There's a reason that we ask for clean specs, independent of source code. That is the only way that we can later change the source code to do something more efficient or to define an extension, and still have clean documentation of what the extensions are, vs. how an older

Re: [Qemu-devel] [PATCH] xhci: fix bad print specifier

2013-02-21 Thread Stefan Weil
Am 21.02.2013 22:58, schrieb Hervé Poussineau: This fixes the following compilation error: hw/usb/hcd-xhci.c:1156:17: error: format ‘%llx’ expects argument of type ‘long long unsigned int’, but argument 4 has type ‘unsigned int’ Signed-off-by: Hervé Poussineau hpous...@reactos.org ---

Re: [Qemu-devel] [PATCH] net: reduce the unnecessary memory allocation of multiqueue

2013-02-21 Thread Jason Wang
On 02/22/2013 06:32 AM, Anthony Liguori wrote: Jason Wang jasow...@redhat.com writes: Edivaldo reports a problem that the array of NetClientState in NICState is too large - MAX_QUEUE_NUM(1024) which will wastes memory even if multiqueue is not used. Instead of static arrays, solving

Re: [Qemu-devel] GTK UI is now the default

2013-02-21 Thread Stefan Weil
Am 22.02.2013 00:04, schrieb Anthony Liguori: Since this is a pretty visible change for a lot of people, I thought I'd send a top level note. The GTK UI is now committed and is the default UI provided it's available. For anyone counting, it's been a little more than 7 years in the making:

Re: [Qemu-devel] [PATCH 9/9] target-i386: set [+-]feature using static properties

2013-02-21 Thread Igor Mammedov
On Tue, 19 Feb 2013 16:03:04 -0300 Eduardo Habkost ehabk...@redhat.com wrote: On Mon, Feb 11, 2013 at 05:35:11PM +0100, Igor Mammedov wrote: * Define static properties for cpuid feature bits * property names of CPUID features are changed to have f- prefix, so that it would be

Re: [Qemu-devel] GTK UI is now the default

2013-02-21 Thread Stefan Weil
Am 22.02.2013 07:08, schrieb Stefan Weil: Am 22.02.2013 00:04, schrieb Anthony Liguori: Since this is a pretty visible change for a lot of people, I thought I'd send a top level note. The GTK UI is now committed and is the default UI provided it's available. For anyone counting, it's been a

<    1   2   3   4   >