Re: [Qemu-devel] [PATCH 2/2] Revert gdbstub: Do not kill target in system emulation mode

2013-03-05 Thread Jan Kiszka
On 2013-03-05 17:03, Fabien Chouteau wrote: This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8. Should also tell us why (by pointing to the other commit e.g.). Will give this a try ASAP! Thanks, Jan Signed-off-by: Fabien Chouteau chout...@adacore.com --- gdbstub.c |2 --

Re: [Qemu-devel] The state of testing

2013-03-05 Thread Lucas Meneghel Rodrigues
On 03/04/2013 01:22 PM, Gerd Hoffmann wrote: Hi, How are things looking with device emulation, migration, monitor, char, etc? At the moment autotest/virt-test is pretty much the only workable thing for non-trivial devices because libqtest lacks infrastructure for pci and anything building

Re: [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets

2013-03-05 Thread Andreas Färber
Am 05.03.2013 16:38, schrieb Anthony Liguori: Paolo Bonzini pbonz...@redhat.com writes: On the x86, some devices need access to the CPU reset pin (INIT#). Provide a generic service to do this, using one of the internal cpu_interrupt targets. Generalize the PPC-specific code for

Re: [Qemu-devel] [PATCH] libcacard: correct T0 historical bytes size

2013-03-05 Thread Alon Levy
On Tue, Feb 26, 2013 at 01:58:36PM +0100, Marc-André Lureau wrote: ping Works, thanks. Reviewed-by: Alon Levy al...@redhat.com On Mon, Jan 14, 2013 at 5:18 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: ping On Sun, Dec 2, 2012 at 10:00 PM, Marc-André Lureau

Re: [Qemu-devel] [PATCH 0/3] Implement x86 soft reset

2013-03-05 Thread Andreas Färber
Am 05.03.2013 17:00, schrieb Paolo Bonzini: Il 05/03/2013 16:51, David Woodhouse ha scritto: (I think even my three cleanup patches for i440fx still haven't been pulled, have they? :( ) No. Michael, can you look at David's [PATCH 0/3] piix_pci cleanups? I just sent a ping. I asked Anthony

Re: [Qemu-devel] The state of testing

2013-03-05 Thread Gerd Hoffmann
Hi, I don't think we have *any* regular autotest coverage for master, have we? ^ Yes, there is coverage. There's a daily job called sanity that takes about 2.5 hours, that builds the latest kvm.git and installs it in the host, then reboots the box, builds the latest qemu master and runs:

Re: [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 17:10, Andreas Färber ha scritto: I would like to take this through qom-cpu please since I already changed cpu_interrupt() to CPUState with my last patch series, for which the prereqs got an Rb now. cpu_soft_reset() still needs to live outside qom/cpu.c due to the CPU

Re: [Qemu-devel] The state of testing

2013-03-05 Thread Lucas Meneghel Rodrigues
On 03/05/2013 01:14 PM, Gerd Hoffmann wrote: Hi, I don't think we have *any* regular autotest coverage for master, have we? ^ Yes, there is coverage. There's a daily job called sanity that takes about 2.5 hours, that builds the latest kvm.git and installs it in the host, then reboots the

Re: [Qemu-devel] The state of testing

2013-03-05 Thread Gerd Hoffmann
Hi, On virt-tests there are at least 48 tests that are easy to run and involve migration. A subset of them is executed regularly in the daily jobs: Sure, there are a bunch of tests already, which is good. But there are also important areas which are not covered at all yet. For example

Re: [Qemu-devel] [PATCH 2/2] Revert gdbstub: Do not kill target in system emulation mode

2013-03-05 Thread Fabien Chouteau
On 03/05/2013 05:07 PM, Jan Kiszka wrote: On 2013-03-05 17:03, Fabien Chouteau wrote: This reverts commit 00e94dbc7fd0110b0555d59592b004333adfb4b8. Should also tell us why (by pointing to the other commit e.g.). Yea, I should have put them together. Will give this a try ASAP! Thanks,

[Qemu-devel] socket,mcast looping back frames - IPv6 broken

2013-03-05 Thread Samuel Thibault
Hello, The reason why IPv6 does not work when using -net socket,mcast=foo is that since qemu explicitly sets IP_MULTICAST_LOOP to 1, it receives its own frames. When the IPv6 stack performs duplicate addresse detection (DAD) through a multicasted announce, it receives its own announcement, and

Re: [Qemu-devel] The state of testing

2013-03-05 Thread Lucas Meneghel Rodrigues
On 03/05/2013 01:23 PM, Gerd Hoffmann wrote: Hi, On virt-tests there are at least 48 tests that are easy to run and involve migration. A subset of them is executed regularly in the daily jobs: Sure, there are a bunch of tests already, which is good. But there are also important areas

[Qemu-devel] [PATCH] tcg: Don't make exitreq flag a local temporary

2013-03-05 Thread Richard Henderson
The value is not actually live across basic blocks, so there's no need for the local property. This eliminates storing the temporary to its home location at the branch. Cc: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Richard Henderson r...@twiddle.net --- include/exec/gen-icount.h | 2

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread David Woodhouse
On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Hm... on reflection, I don't actually know if this is true. Perhaps we *should* reset all devices. After all, in a real machine they'll

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-03-05 Thread Alexander Graf
On 02/06/2013 12:47 AM, Jesse Larrew wrote: Currently, the config size for virtio devices is hard coded. When a new feature is added that changes the config size, drivers that assume a static config size will break. For purposes of backward compatibility, there needs to be a way to inform

[Qemu-devel] Same Display contents on different outputs?

2013-03-05 Thread Erik Rull
Hi all, is it meanwhile possible to get the same screen output on a screen and on VNC? I would like to offer a direct terminal (with a real screen and keyboard) for user interaction and a VNC remote terminal e.g. for service access. Is it possible to configure it so that the guest sees only

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-03-05 Thread Christian Borntraeger
On 05/03/13 17:48, Alexander Graf wrote: On 02/06/2013 12:47 AM, Jesse Larrew wrote: Currently, the config size for virtio devices is hard coded. When a new feature is added that changes the config size, drivers that assume a static config size will break. For purposes of backward

[Qemu-devel] [PULL 0/6] SCSI patches for 2013-03-05

2013-03-05 Thread Paolo Bonzini
Anthony, The following changes since commit 76c48503c4c87afabf0c93acf78480f65276844d: Merge branch 'target-arm.next' of git://git.linaro.org/people/pmaydell/qemu-arm (2013-03-05 15:11:30 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git scsi-next for you

[Qemu-devel] [PATCH 4/6] scsi: do not call scsi_read_data/scsi_write_data for a canceled request

2013-03-05 Thread Paolo Bonzini
Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi-bus.c | 4 trace-events | 1 + 2 files changed, 5 insertions(+) diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c index a97f1cd..01e1dec 100644 --- a/hw/scsi-bus.c +++ b/hw/scsi-bus.c @@ -1508,6 +1508,10 @@

[Qemu-devel] [PATCH 1/6] iscsi: retry read, write, flush and unmap on unit attention check conditions

2013-03-05 Thread Paolo Bonzini
From: Peter Lieven p...@dlhnet.de the storage might return a check condition status for various reasons. (e.g. bus reset, capacity change, thin-provisioning info etc.) currently all these informative status responses lead to an I/O error which is populated to the guest. this patch introduces a

[Qemu-devel] [PATCH 6/6] scsi-disk: handle io_canceled uniformly and correctly

2013-03-05 Thread Paolo Bonzini
Always check it immediately after calling bdrv_acct_done, and always do a goto done in case the done label has to free some memory---as is the case for scsi_unmap_complete in the previous patch. This patch could fix problems that happen when a request is split into multiple parts, and one of them

Re: [Qemu-devel] [PATCH 2/3] hw/virtio-net.c: set config size using host features

2013-03-05 Thread Alexander Graf
On 02/06/2013 12:47 AM, Jesse Larrew wrote: Currently, the config size for virtio devices is hard coded. When a new feature is added that changes the config size, drivers that assume a static config size will break. For purposes of backward compatibility, there needs to be a way to inform

[Qemu-devel] [PATCH 2/6] iscsi: add iscsi_truncate support

2013-03-05 Thread Paolo Bonzini
From: Peter Lieven p...@dlhnet.de this patch adds iscsi_truncate which effectively allows for online resizing of iscsi volumes. for this to work you have to resize the volume on your storage and then call block_resize command in qemu which will issue a readcapacity16 to update the capacity. v4:

[Qemu-devel] [PATCH 5/6] scsi-disk: do not complete canceled UNMAP requests

2013-03-05 Thread Paolo Bonzini
Canceled requests should never be completed, and doing that could cause accesses to a NULL hba_private field. Cc: qemu-sta...@nongnu.org Reported-by: Stefan Priebe s.pri...@profihost.ag Tested-by: Stefan Priebe s.pri...@profihost.ag Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 17:59, David Woodhouse ha scritto: On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Hm... on reflection, I don't actually know if this is true. Perhaps we *should*

Re: [Qemu-devel] [PATCH qom-cpu v3 4/6] cpu: Introduce cpu_class_set_vmsd()

2013-03-05 Thread Andreas Färber
Am 26.02.2013 20:32, schrieb Eduardo Habkost: On Mon, Feb 25, 2013 at 07:22:48PM +0100, Andreas Färber wrote: This setter avoids redefining each VMStateDescription value to vmstate_dummy by not referencing the value for CONFIG_USER_ONLY. Suggested-by: Juan Quintela quint...@redhat.com

[Qemu-devel] [PATCH 02/18] hw: move fifo.[ch] to libqemuutil

2013-03-05 Thread Paolo Bonzini
fifo.c is generic code that can be easily unit tested. So it belongs in libqemuutil. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/Makefile.objs | 1 - hw/xilinx_spi.c | 2 +- hw/xilinx_spips.c | 2 +- include/migration/vmstate.h

[Qemu-devel] [PATCH 01/18] hw: move char backends to backends/

2013-03-05 Thread Paolo Bonzini
Braille and msmouse support is in hw/, but it is not hardware. Move it to the backends/ directory. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- backends/Makefile.objs | 4 {hw = backends}/baum.c| 4 ++-- {hw = backends}/msmouse.c | 2 +- hw/Makefile.objs

[Qemu-devel] [PULL 00/18] hw/ reorganization, part 1

2013-03-05 Thread Paolo Bonzini
This includes the mechanical changes, as well as moving stuff out of hw/. Boards and devices referencing CPU are moved to per-arch subdirectories. This part was uncontroversial, and I have already posted it separately in this exact shape. The following changes since commit

[Qemu-devel] [PATCH 08/18] ppc: do not use ../ in include files

2013-03-05 Thread Paolo Bonzini
This simplifies the scripted execution of the next patch. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ppc/e500-ccsr.h | 2 +- hw/ppc/e500plat.c | 2 +- hw/ppc/mpc8544ds.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/ppc/e500-ccsr.h b/hw/ppc/e500-ccsr.h

[Qemu-devel] [PATCH 3/6] iscsi: look for pkg-config file too

2013-03-05 Thread Paolo Bonzini
Due to library conflicts, Fedora will have to put libiscsi in /usr/lib/iscsi. Simplify configuration by using a pkg-config file. The Fedora package will distribute one, and the patch to add it has been sent to upstream libiscsi as well. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH 03/18] hw: move qdev-monitor.o to toplevel directory

2013-03-05 Thread Paolo Bonzini
qdev-monitor.c is the only core qdev file that is not used in user-mode emulation, and it does not define anything that is used by hardware models. Remove it from the hw/ directory and remove hw/qdev-monitor.h from hw/qdev.h too; this requires some files to have some new explicitly includes.

[Qemu-devel] [PATCH 11/18] ppc: express FDT dependency of pSeries and e500 boards via default-configs/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- configure | 3 --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 2 ++ default-configs/ppcemb-softmmu.mak | 1 + hw/ppc/Makefile.objs | 4 ++-- 5 files changed, 6

[Qemu-devel] [PATCH 14/18] i386: move files referencing CPU to hw/i386/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/i386/Makefile.objs| 4 +++- hw/{ = i386}/kvmvapic.c | 0 2 files changed, 3 insertions(+), 1 deletion(-) rename hw/{ = i386}/kvmvapic.c (100%) diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs index 5d071f4..a78c0b2 100644 ---

[Qemu-devel] [PATCH 05/18] virtio-9p: use CONFIG_VIRTFS, not CONFIG_LINUX

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio-pci.h | 2 +- hw/virtio.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/virtio-pci.h b/hw/virtio-pci.h index d24957c..e775525 100644 --- a/hw/virtio-pci.h +++ b/hw/virtio-pci.h @@ -75,7 +75,7 @@

[Qemu-devel] [PATCH 13/18] arm: move files referencing CPU to hw/arm/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/arm/Makefile.objs | 13 - hw/{ = arm}/armv7m.c | 0 hw/{ = arm}/exynos4210.c | 0 hw/{ = arm}/omap1.c | 0 hw/{ = arm}/omap2.c | 0 hw/{ = arm}/pxa2xx.c | 0 hw/{ = arm}/pxa2xx_gpio.c | 0 hw/{

[Qemu-devel] [PATCH 17/18] ppc: move more files to hw/ppc

2013-03-05 Thread Paolo Bonzini
These sPAPR files do not implement devices, move them over. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ppc/Makefile.objs| 8 hw/{ = ppc}/spapr_events.c | 0 hw/{ = ppc}/spapr_hcall.c | 0 hw/{ = ppc}/spapr_iommu.c | 0 hw/{ = ppc}/spapr_rtas.c | 0 5 files

[Qemu-devel] [PATCH 04/18] hw: move device-hotplug.o to toplevel, compile it once

2013-03-05 Thread Paolo Bonzini
The situation with device-hotplug.c is similar to qdev-monitor.c. Add a stub for pci_drive_hot_add, so that it can be compiled once, and move it out of hw/. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.objs | 2 +- hw/device-hotplug.c =

[Qemu-devel] [PATCH 18/18] sh: move files referencing CPU to hw/sh4/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/sh4/Makefile.objs | 4 +++- hw/{ = sh4}/sh7750.c | 0 hw/{ = sh4}/sh7750_regnames.c | 0 3 files changed, 3 insertions(+), 1 deletion(-) rename hw/{ = sh4}/sh7750.c (100%) rename hw/{ = sh4}/sh7750_regnames.c (100%)

[Qemu-devel] [PATCH 15/18] m68k: move files referencing CPU to hw/m68k/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/m68k/Makefile.objs| 3 ++- hw/{ = m68k}/mcf5206.c | 0 hw/{ = m68k}/mcf_intc.c | 0 3 files changed, 2 insertions(+), 1 deletion(-) rename hw/{ = m68k}/mcf5206.c (100%) rename hw/{ = m68k}/mcf_intc.c (100%) diff --git

[Qemu-devel] [PATCH 07/18] vt82c686: vt82c686 is not a PCI host bridge

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/vt82c686.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/vt82c686.c b/hw/vt82c686.c index 2d8e398..c2b1bfc 100644 --- a/hw/vt82c686.c +++ b/hw/vt82c686.c @@ -26,8 +26,6 @@ #include qemu/timer.h #include exec/address-spaces.h

Re: [Qemu-devel] [PATCH 2/3] pc: port 92 reset requires a low-high transition

2013-03-05 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: The PIIX datasheet says that before another INIT pulse can be generated via [port 92h], [bit 0] must be written back to a zero. This bug is masked right now because a full reset will clear the value of port 92h. But once we implement soft reset

Re: [Qemu-devel] [PATCH 3/3] hw: correctly implement soft reset

2013-03-05 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Signed-off-by: Paolo Bonzini pbonz...@redhat.com I'm quite confident these devices should trigger a soft reset but not confident this is

[Qemu-devel] [PATCH 06/18] virtio-9p: remove PCI dependencies from hw/9pfs/

2013-03-05 Thread Paolo Bonzini
Also move the 9p.h file to 9pfs/virtio-9p-device.h, for consistency with the corresponding .c file. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/9pfs/virtio-9p-device.c | 53 +--- hw/{9p.h = 9pfs/virtio-9p-device.h} | 4 +--

[Qemu-devel] [PATCH 10/18] build: always link device_tree.o into emulators if libfdt available

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- Makefile.target | 1 + configure | 7 +-- hw/arm/Makefile.objs| 1 - hw/microblaze/Makefile.objs | 1 - hw/ppc/Makefile.objs| 1 - 5 files changed, 2 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Peter Stuge
Paolo Bonzini wrote: That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't work if the PAM configuration is reset? Yeah, it sounded a bit weird when I wrote that commit message. This could be the case. How does it work on Coreboot? Yes all hardware except RAM in self-refresh

[Qemu-devel] [PATCH 16/18] ppc: move files referencing CPU to hw/ppc/

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/ppc/Makefile.objs| 13 ++--- hw/{ = ppc}/mpc8544_guts.c | 0 hw/{ = ppc}/ppc4xx_devs.c | 0 hw/{ = ppc}/ppce500_spin.c | 0 hw/{ = ppc}/spapr_vio.c| 0 hw/{ = ppc}/xics.c | 0 6 files changed, 6

Re: [Qemu-devel] [PATCH 16/19] qemu-char: move msmouse registeration to msmouse.c

2013-03-05 Thread Amit Shah
On (Mon) 18 Feb 2013 [15:48:13], Anthony Liguori wrote: +static CharDriverState *qemu_chr_open_pp(QemuOpts *opts) +{ +return NULL; +} I guess this was to fix up the compile broken by a previous commit. I've handled this in my rebase. Amit

Re: [Qemu-devel] [PATCH 3/3] hw: correctly implement soft reset

2013-03-05 Thread David Woodhouse
On Tue, 2013-03-05 at 16:04 +0100, Paolo Bonzini wrote: Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Is a keyboard reset also supposed to reset the A20 gate? -- dwmw2 smime.p7s Description: S/MIME cryptographic signature

[Qemu-devel] [Bug 1129571] Re: libreoffice armhf FTBFS

2013-03-05 Thread Serge Hallyn
@Peter, so you'd recommend testing for the javac hang with https://launchpadlibrarian.net/124927320/cmake.patch ? (will try until you shout no, you idiot) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 18:26, Peter Stuge ha scritto: That is: perhaps it's a *SeaBIOS* bug that suspend/resume doesn't work if the PAM configuration is reset? Yeah, it sounded a bit weird when I wrote that commit message. This could be the case. How does it work on Coreboot? Yes all

Re: [Qemu-devel] [PATCH 3/3] hw: correctly implement soft reset

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 18:22, David Woodhouse ha scritto: On Tue, 2013-03-05 at 16:04 +0100, Paolo Bonzini wrote: Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Is a keyboard reset also supposed to reset the A20 gate? Resetting with 0xFE is

[Qemu-devel] [PATCH 00/20] chardev flow control

2013-03-05 Thread Amit Shah
Changes from Anthony's earlier series: * Added patch 20 that makes flow control explicit in virtio-console * Fixed compile error in patch 13, qemu-char: make char drivers dynamically registerable, which had a wrong 'fix' in unrelated patch 16. * rebased to master Please apply. Orig. message

[Qemu-devel] [PATCH 01/20] char-socket: fix error reporting

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Right now the inet connect code tries all available addresses but until one doesn't fail. It passes local_err each time without clearing it from the previous failure. This can trigger an assert since the inet connect code tries to set an error on an

[Qemu-devel] [PATCH 03/20] char: add IOWatchPoll support

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com This is a special GSource that supports CharDriverState style poll callbacks. For reviewability and bisectability, this code is #if 0'd out in this patch to avoid unused warnings since all of the functions are static. Signed-off-by: Anthony Liguori

[Qemu-devel] [PATCH 04/20] qemu-char: convert fd_chr to use a GIOChannel

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com This uses the newly introduced IOWatchPoll source. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 103 1 file changed, 62

[Qemu-devel] [PATCH 02/20] qemu-char: remove dead/confusing logic with nb_stdio_clients

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com This code is very old dating back to 2007. What is puzzling is that STDIO_MAX_CLIENTS was always #define to 1 meaning that all of the code to deal with more than one client was unreachable. Just remove the whole mess of it. Signed-off-by: Anthony

[Qemu-devel] [PATCH 06/20] qemu-char: convert UDP to GIOChannel

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 68 +++-- 1 file changed, 57 insertions(+), 11 deletions(-) diff --git

[Qemu-devel] [PATCH 07/20] qemu-char: tcp: make use GIOChannel

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com I didn't bother switching to g_io_channel_read/write because we need to use sendmsg on Unix. No problem though since we're using an unbuffered channel. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com ---

[Qemu-devel] [PATCH 05/20] qemu-char: convert pty to GIOChannel

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 44 +++- 1 file changed, 27 insertions(+), 17 deletions(-) diff --git a/qemu-char.c b/qemu-char.c

[Qemu-devel] [PATCH 10/20] char: add gio watch fn for tcp backends

2013-03-05 Thread Amit Shah
Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index f1d089f..eb0ac81 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -2462,6 +2462,12 @@ static ssize_t tcp_chr_recv(CharDriverState *chr, char *buf,

[Qemu-devel] [PATCH 08/20] qemu-char: add watch support

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com This allows a front-end to request for a callback when the backend is writable again. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- include/char/char.h | 4 qemu-char.c | 32

[Qemu-devel] [PATCH 12/20] qemu-char: remove use of QEMUTimer in favor of glib idle function

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com qemu-char is now independent of the QEMU main loop. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- include/char/char.h | 2 +- qemu-char.c | 12 +--- 2 files changed, 6

[Qemu-devel] [PATCH 09/20] qemu-char: add pty watch

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com This lets ptys support adding front end watchs. Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 11/20] qemu-char: use a glib timeout instead of qemu-timer

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 68 - 1 file changed, 45 insertions(+), 23 deletions(-) diff --git

[Qemu-devel] [PATCH 13/20] qemu-char: make char drivers dynamically registerable

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- include/char/char.h | 2 + qemu-char.c | 110 +++- 2 files changed, 68 insertions(+), 44

[Qemu-devel] [PATCH 14/20] qemu-char: move spice registration to spice-qemu-char.c

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 6 -- spice-qemu-char.c | 10 ++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/qemu-char.c

[Qemu-devel] [PATCH 16/20] qemu-char: move msmouse registeration to msmouse.c

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/msmouse.c | 10 -- hw/msmouse.h | 7 --- qemu-char.c | 3 +-- 3 files changed, 9 insertions(+), 11 deletions(-) delete mode 100644

[Qemu-devel] [PATCH 17/20] qemu-char: move text console init to console.c

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- qemu-char.c | 1 - ui/console.c | 7 +++ 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index

[Qemu-devel] [PATCH 15/20] qemu-char: move baum registration to baum.c

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/baum.c | 9 - hw/baum.h | 30 -- qemu-char.c | 4 vl.c| 1 - 4 files changed, 8 insertions(+),

[Qemu-devel] [PATCH 18/20] serial: add flow control to transmit

2013-03-05 Thread Amit Shah
From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/serial.c | 28 +++- hw/serial.h | 2 -- 2 files changed, 11 insertions(+), 19 deletions(-) diff --git a/hw/serial.c

[Qemu-devel] [PATCH 19/20] virtio: console: add flow control

2013-03-05 Thread Amit Shah
The virtio-serial-bus already has the logic to make flow control work properly. Hook into the char layer's new ability to signal a backend is writable again. Signed-off-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 13 + 1 file changed, 13 insertions(+) diff --git

[Qemu-devel] [PATCH 20/20] virtio-serial: make flow control explicit in virtio-console

2013-03-05 Thread Amit Shah
virtio-console.c used to return a value less than the number of bytes asked to be written out to a chardev backend in case the backend is not writable. virtio-serial-bus.c then implicitly enabled flow control for that port. Make this explicit instead. Signed-off-by: Amit Shah

Re: [Qemu-devel] [PATCH 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets

2013-03-05 Thread Laszlo Ersek
Comments in-line. (In advance, can you please change your format-series alias so that format-patch gets -O/abs/path/to/order-file, where order-file puts *.h before *.c? Thanks.) On 03/05/13 16:04, Paolo Bonzini wrote On the x86, some devices need access to the CPU reset pin (INIT#). Provide a

[Qemu-devel] [PATCH 12/18] hw: move boards and other isolated files to hw/ARCH

2013-03-05 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/Makefile.objs | 1 - hw/alpha/Makefile.objs| 4 ++- hw/{alpha_dp264.c = alpha/dp264.c} | 0 hw/{alpha_pci.c = alpha/pci.c} | 0

Re: [Qemu-devel] [PATCH qom-cpu v3 0/6] QOM CPUState VMStateDescriptions

2013-03-05 Thread Andreas Färber
Am 25.02.2013 19:22, schrieb Andreas Färber: Andreas Färber (6): vmstate: Make vmstate_register() static inline stubs: Add a vmstate_dummy struct for CONFIG_USER_ONLY cpu: Register VMStateDescription through CPUState cpu: Introduce cpu_class_set_vmsd() target-i386: Update

Re: [Qemu-devel] [PATCH 2/3] pc: port 92 reset requires a low-high transition

2013-03-05 Thread Laszlo Ersek
On 03/05/13 16:04, Paolo Bonzini wrote: The PIIX datasheet says that before another INIT pulse can be generated via [port 92h], [bit 0] must be written back to a zero. This bug is masked right now because a full reset will clear the value of port 92h. But once we implement soft reset

Re: [Qemu-devel] [PATCH qom-cpu v2 0/7] QOM CPUState, part 9: CPU_COMMON for interrupts

2013-03-05 Thread Andreas Färber
Am 25.02.2013 19:45, schrieb Andreas Färber: Andreas Färber (7): target-cris/helper.c: Update Coding Style cpu: Move halted and interrupt_request fields to CPUState exec: Pass CPUState to cpu_reset_interrupt() cpu: Pass CPUState to cpu_interrupt() cpu: Replace do_interrupt() by

Re: [Qemu-devel] [PATCH 3/3] hw: correctly implement soft reset

2013-03-05 Thread Laszlo Ersek
comments in-line On 03/05/13 16:04, Paolo Bonzini wrote: Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/lpc_ich9.c | 7 ++- hw/pc.c | 3 ++- hw/pckbd.c| 5 +++--

[Qemu-devel] [PATCH v2 2/3] pc: port 92 reset requires a low-high transition

2013-03-05 Thread Paolo Bonzini
The PIIX datasheet says that before another INIT pulse can be generated via [port 92h], [bit 0] must be written back to a zero. This bug is masked right now because a full reset will clear the value of port 92h. But once we implement soft reset correctly, the next attempt to enable the A20 line

[Qemu-devel] [PATCH v2 1/3] cpu: make CPU_INTERRUPT_RESET available on all targets

2013-03-05 Thread Paolo Bonzini
On the x86, some devices need access to the CPU reset pin (INIT#). Provide a generic service to do this, using one of the internal cpu_interrupt targets. Generalize the PPC-specific code for CPU_INTERRUPT_RESET to other targets, and provide a function that will raise the interrupt on all CPUs.

[Qemu-devel] [PATCH v2 3/3] hw: correctly implement soft reset

2013-03-05 Thread Paolo Bonzini
Do not do a hard reset for port 92h, keyboard controller, or cf9h soft reset. These only reset the CPU. Reviewed-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/lpc_ich9.c | 7 ++- hw/pc.c | 3 ++- hw/pckbd.c| 5 +++-- hw/piix_pci.c |

[Qemu-devel] [PATCH v2 0/3] Implement x86 soft reset

2013-03-05 Thread Paolo Bonzini
This series makes various devices (port 92h, pckbd and the PIIX4/ICH9 southbridges) implement x86 soft reset correctly. v1-v2: rebased onto Andreas's branch, fixed target-ppc/cpu.h, renamed function Paolo Bonzini (3): cpu: make CPU_INTERRUPT_RESET available on all targets pc: port 92

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Laszlo Ersek
On 03/05/13 17:59, David Woodhouse wrote: On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Hm... on reflection, I don't actually know if this is true. Perhaps we *should* reset all

Re: [Qemu-devel] [PATCH v2 0/3] Implement x86 soft reset

2013-03-05 Thread Laszlo Ersek
On 03/05/13 20:00, Paolo Bonzini wrote: This series makes various devices (port 92h, pckbd and the PIIX4/ICH9 southbridges) implement x86 soft reset correctly. v1-v2: rebased onto Andreas's branch, fixed target-ppc/cpu.h, renamed function Paolo Bonzini (3): cpu: make

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Paolo Bonzini
Il 05/03/2013 20:12, Laszlo Ersek ha scritto: On 03/05/13 17:59, David Woodhouse wrote: On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Hm... on reflection, I don't actually know if

Re: [Qemu-devel] [PATCH 4/3] wakeup: only reset the CPU

2013-03-05 Thread Laszlo Ersek
On 03/05/13 20:25, Paolo Bonzini wrote: Il 05/03/2013 20:12, Laszlo Ersek ha scritto: On 03/05/13 17:59, David Woodhouse wrote: On Tue, 2013-03-05 at 17:03 +0100, Paolo Bonzini wrote: Resuming from suspend-to-RAM should not reset all devices. Only the CPU should get a reset signal. Hm...

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:56PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- qga/commands-posix.c | 87 ++ 1 files changed, 87 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Mon, Mar 04, 2013 at 11:19:57PM +0100, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- qga/commands-posix.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread Eric Blake
On 03/05/2013 01:03 PM, mdroth wrote: +buf = g_strdup_printf(/sys/devices/system/cpu/cpu%ld/online, + current); +f = fopen(buf, r); +if (f == NULL) { +error_setg_errno(local_err, errno, fopen(\%s\, \r\), buf); +}

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread Eric Blake
On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) { +#if defined(__linux__) + +buf = g_strdup_printf(/sys/devices/system/cpu/cpu%ld/online, +

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 01:22:03PM -0700, Eric Blake wrote: On 03/05/2013 01:03 PM, mdroth wrote: +buf = g_strdup_printf(/sys/devices/system/cpu/cpu%ld/online, + current); +f = fopen(buf, r); +if (f == NULL) { +

Re: [Qemu-devel] Dataplane and vhost-blk

2013-03-05 Thread Benoît Canet
You need to set a more specific goal. Some questions to get started: * Which workloads do you care about and what are their characteristics (sequential or random I/O, queue depth)? * Do you care about 1 vcpu guests or 4+ vcpu guests? (SMP scalability) * Are you using an image format?

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread Laszlo Ersek
On 03/05/13 21:03, mdroth wrote: On Mon, Mar 04, 2013 at 11:19:56PM +0100, Laszlo Ersek wrote: +#if defined(__linux__) There's a section in commands-posix.c set aside under linux-specific implementations for these, and another underneath for stubs so we can avoid having too many ifdef's.

Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-05 Thread Laszlo Ersek
On 03/05/13 21:09, mdroth wrote: Similar to comments in patch 2: is this supposed to be similar to the /sys/devices/system/cpu/{probe,release} entries currently documented? I don't have those on RHEL-6, and they aren't mentioned in upstream Documentation/cpu-hotplug.txt.

Re: [Qemu-devel] [PATCH 1/3] qga: introduce guest-get-vcpus / guest-set-vcpus with stubs

2013-03-05 Thread Eric Blake
On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- +# @guest-set-vcpus: +# +# Attempt to reconfigure (currently: enable/disable) logical processors inside +# the guest. +# +# The input list is processed node by node in order. In each node

Re: [Qemu-devel] [PATCH 3/3] qga: implement qmp_guest_set_vcpus() for Linux with sysfs

2013-03-05 Thread Eric Blake
On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- qga/commands-posix.c | 51 ++ 1 files changed, 51 insertions(+), 0 deletions(-) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread Laszlo Ersek
On 03/05/13 21:25, Eric Blake wrote: On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) { +#if defined(__linux__) + +buf =

Re: [Qemu-devel] [PATCH 0/3] *** make netlayer re-entrant ***

2013-03-05 Thread mdroth
On Sun, Mar 03, 2013 at 09:21:19PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com This series aim to make netlayer re-entrant, so netlayer can run out of biglock safely. I think most of the locking considerations are still applicable either way, but this series

Re: [Qemu-devel] [PATCH 2/3] qga: implement qmp_guest_get_vcpus() for Linux with sysfs

2013-03-05 Thread mdroth
On Tue, Mar 05, 2013 at 10:34:08PM +0100, Laszlo Ersek wrote: On 03/05/13 21:25, Eric Blake wrote: On 03/04/2013 03:19 PM, Laszlo Ersek wrote: Signed-off-by: Laszlo Ersek ler...@redhat.com --- GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp) { +#if defined(__linux__)

<    1   2   3   4   >