[Qemu-devel] [RFC PATCH 1/2] net: port tap onto glib

2013-03-13 Thread Liu Ping Fan
Bind each NetClientState with a GSource(ie,NetClientSource). Currently, these GSource attached with default context, but in future, after resolving the race between handlers and the interface exposed by NetClientInfo and other re-entrant issue, we can run NetClientState on different GMainContext

[Qemu-devel] [RFC PATCH 2/2] net: port hub onto glib

2013-03-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Attach each hubport with a GSource. Currently the GSource is attached to default main context, and the hub still run on iothread, but in future, after making the whole layer thread-safe, we will admit ports to run on different thread(GMainContext).

Re: [Qemu-devel] [PATCH 15/19] [fixup] vc

2013-03-13 Thread Gerd Hoffmann
On 03/12/13 18:42, Eric Blake wrote: On 03/12/2013 02:56 AM, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c |3 +++ 1 file changed, 3 insertions(+) Did something go wrong in your rebase? The subject line suggest you intended to squash this to another

Re: [Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-13 Thread Markus Armbruster
Anthony asked for a space between PATCH and vN in the subject. Please try to remember next time. Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can

[Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-13 Thread liguang
By now, all devices of QEMU do not have much more power management consideration, for example, if system do suspend, it will call all registered notifiers, this was loosely required, and the code to do power management state transition seems just do 'ugly emulation', rather than be conscious with

[Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort()

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/qdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 689cd54..2bed9d8 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -116,11 +116,10 @@ DeviceState *qdev_create(BusState *bus, const char

[Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/qdev-core.h |9 + hw/qdev.c | 96 2 files changed, 105 insertions(+), 0 deletions(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index e69c50b..805ac69 100644 ---

[Qemu-devel] [PATCH][RFC 04/14] qdev: add power on/off/suspend/wakeup handler

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/qdev-core.h |9 + hw/qdev.c | 96 2 files changed, 105 insertions(+), 0 deletions(-) diff --git a/hw/qdev-core.h b/hw/qdev-core.h index e69c50b..805ac69 100644 ---

[Qemu-devel] [PATCH][RFC 02/14] qdev: add power management method

2013-03-13 Thread liguang
In fact, every devices have to be aware of it's power management, so it can decide what to do when platform board switch it's power state between on/off/suspend/wakeup. Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/qdev-core.h |6 ++ 1 files changed, 6 insertions(+), 0

[Qemu-devel] [PATCH][RFC 10/14] piix4: refactor piix4's power callbacks

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/piix4.c | 14 -- 1 files changed, 12 insertions(+), 2 deletions(-) diff --git a/hw/piix4.c b/hw/piix4.c index c1cb94d..1066149 100644 --- a/hw/piix4.c +++ b/hw/piix4.c @@ -34,7 +34,7 @@ typedef struct PIIX4State { PCIDevice

[Qemu-devel] [PATCH][RFC 07/14] acpi: refactor acpi wakeup function

2013-03-13 Thread liguang
realize wakeup function for ICH9-LPC device Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/acpi.c | 20 +--- hw/acpi.h |3 ++- hw/lpc_ich9.c | 11 ++- 3 files changed, 21 insertions(+), 13 deletions(-) diff --git a/hw/acpi.c b/hw/acpi.c index

[Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files

2013-03-13 Thread liguang
ignore *.patch, *.gcda, *.gcno Signed-off-by: liguang lig.f...@cn.fujitsu.com --- .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 27ad002..9c234a3 100644 --- a/.gitignore +++ b/.gitignore @@ -80,6 +80,9 @@

[Qemu-devel] [PATCH][RFC 06/14] sysemu: remove PowerReason in sysemu.h

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- include/sysemu/sysemu.h |7 +-- 1 files changed, 1 insertions(+), 6 deletions(-) diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h index b19ec95..bf830da 100644 --- a/include/sysemu/sysemu.h +++ b/include/sysemu/sysemu.h @@

[Qemu-devel] [PATCH][RFC 12/14] ps2: call ps2_{kbd, mouse}_reset in kbd_reset

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/pckbd.c |3 +++ hw/ps2.c |8 hw/ps2.h |2 ++ 3 files changed, 9 insertions(+), 4 deletions(-) diff --git a/hw/pckbd.c b/hw/pckbd.c index 1ab8ada..f2570d8 100644 --- a/hw/pckbd.c +++ b/hw/pckbd.c @@ -374,6 +374,9 @@

[Qemu-devel] [PATCH][RFC 09/14] ich9: do lpc's power on by reset function

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/lpc_ich9.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c index 42f2dfa..9be6196 100644 --- a/hw/lpc_ich9.c +++ b/hw/lpc_ich9.c @@ -614,6 +614,7 @@ static void

[Qemu-devel] [PATCH][RFC 08/14] ich9: make lpc's reset also do pm_reset

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/acpi_ich9.c |4 ++-- hw/ich9.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/acpi_ich9.c b/hw/acpi_ich9.c index d2f9808..b78a32e 100644 --- a/hw/acpi_ich9.c +++ b/hw/acpi_ich9.c @@ -176,7 +176,7 @@ const

[Qemu-devel] [PATCH][RFC 14/14] uhci: refactor uhci's power callbacks

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/usb/hcd-uhci.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index f8c4286..008f567 100644 --- a/hw/usb/hcd-uhci.c +++ b/hw/usb/hcd-uhci.c @@ -414,6 +414,14 @@ static

[Qemu-devel] [PATCH][RFC 11/14] pckbd: refactor pckbd's power callbacks

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/pckbd.c | 22 -- 1 files changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/pckbd.c b/hw/pckbd.c index 3bad09b..1ab8ada 100644 --- a/hw/pckbd.c +++ b/hw/pckbd.c @@ -142,6 +142,12 @@ typedef struct KBDState {

[Qemu-devel] [PATCH][RFC 13/14] parallel: refactor parallel_reset function

2013-03-13 Thread liguang
Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/parallel.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/parallel.c b/hw/parallel.c index 3a4e06b..7dc53eb 100644 --- a/hw/parallel.c +++ b/hw/parallel.c @@ -427,9 +427,11 @@ static uint32_t

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-13 Thread KONRAD Frédéric
On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric fred.kon...@greensocs.com wrote: On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric fred.kon...@greensocs.com wrote: On 12/03/2013 15:42, Peter Maydell wrote: Yes, I

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 09:36:06AM +0800, Wenchao Xia wrote: 于 2013-3-12 23:43, Stefan Hajnoczi 写道: On Tue, Mar 12, 2013 at 04:30:41PM +0800, Wenchao Xia wrote: 于 2013-1-15 15:03, Wenchao Xia 写道: 于 2013-1-14 18:06, Stefan Hajnoczi 写道: On Mon, Jan 14, 2013 at 10:56:30AM +0800, Wenchao Xia

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread Stefan Hajnoczi
On Tue, Mar 12, 2013 at 05:34:24PM +0800, 解壁伟 wrote: Hi there: I've read this an article discribe the thread model in Qemu. http://blog.vmsplice.net/2011/03/qemu-internals-overall-architecture-and.html Is there really one thread per vcpu in qemu? When I run the qemu using -smp 16, I can

Re: [Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread Lei Li
On 03/12/2013 11:05 PM, Eric Blake wrote: On 03/12/2013 03:08 AM, Lei Li wrote: Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 34 ++ 1 file changed, 34 insertions(+) +void qmp_guest_set_time(int64_t time_ns, Error **errp) +{ +

Re: [Qemu-devel] [PATCH] qcow2: make is_allocated return true for zero clusters

2013-03-13 Thread Kevin Wolf
Am 06.03.2013 um 18:02 hat Paolo Bonzini geschrieben: Otherwise, live migration of the top layer will miss zero clusters and let the backing file show through. This also matches what is done in qed. QCOW2_CLUSTER_ZERO clusters are invalid in v2 image files. Check this directly in

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-13 Thread Kevin Wolf
Am 11.03.2013 um 12:52 hat Peter Lieven geschrieben: On 11.03.2013 12:44, Paolo Bonzini wrote: Il 11/03/2013 11:19, Peter Lieven ha scritto: Am 11.03.2013 um 11:16 schrieb Paolo Bonzini pbonz...@redhat.com: Il 11/03/2013 11:05, Peter Lieven ha scritto: ensure that there are no pending

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread 解壁伟
I read the article again, and I get the answer to my question in that paragraph. Thank you very much. As you've said, TCG's not thread-safe. Is it only the shared data structure(e.g TB) that prevent TCG to be thread-safe? I'm seeking a method to parallize TCG in order to parallize Qemu.

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread 解壁伟
Thank you very much. I've find the generation of thread in qemu, following your advice. qemu_init_vcpu() -- qemu_kvm_start_vcpu() [cpus.c] puck 于 2013/3/13 6:26, Laszlo Ersek 写道: On 03/12/13 10:34, 解壁伟 wrote: Hi there: I've read this an article discribe the thread model in Qemu.

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread Peter Maydell
On 13 March 2013 09:32, 解壁伟 xiebi...@ict.ac.cn wrote: I read the article again, and I get the answer to my question in that paragraph. Thank you very much. As you've said, TCG's not thread-safe. Is it only the shared data structure(e.g TB) that prevent TCG to be thread-safe? I'm seeking a

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread Laurent Desnogues
On Wed, Mar 13, 2013 at 10:51 AM, Peter Maydell peter.mayd...@linaro.org wrote: [...] For now, I need a emulator to emulate more cores efficiently.I want to analyze whether Qemu can be faster when it emulate more cores, while parallelism maybe a good choice. There has been some other research

[Qemu-devel] dataplane bug: fail to start VM with dataplane enable

2013-03-13 Thread Dunrong Huang
Hi, Paolo Stefan: When I test the dataplane feature with git master, I find that VM will hang if dataplane is enabled. But if I use qemu-1.4.0, VM can start normally. The command I boot QEMU is: x86_64-softmmu/qemu-system-x86_64 -enable-kvm -m 1024 -smp 2 -drive

Re: [Qemu-devel] [PATCH] qcow2: make is_allocated return true for zero clusters

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 10:14, Kevin Wolf ha scritto: Otherwise, live migration of the top layer will miss zero clusters and let the backing file show through. This also matches what is done in qed. QCOW2_CLUSTER_ZERO clusters are invalid in v2 image files. Check this directly in

[Qemu-devel] [PATCH 0/2 v4] Add Windows support for time resync by qemu-ga

2013-03-13 Thread lilei
From: Lei Li li...@linux.vnet.ibm.com This patch series attempts to add Windows implementation for qemu-ga commands guest-get-time and guest-set-time. The previous thread about the interfaces introduced and the POSIX-specific command implementation has already been accepted, the reference link:

[Qemu-devel] [PATCH 2/2] qga: add windows implementation for guest-set-time

2013-03-13 Thread lilei
From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 34 ++ 1 files changed, 34 insertions(+), 0 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 0a2bb34..a0c8d43 100644 ---

[Qemu-devel] [PATCH 1/2] qga: add windows implementation for guest-get-time

2013-03-13 Thread lilei
From: Lei Li li...@linux.vnet.ibm.com Signed-off-by: Lei Li li...@linux.vnet.ibm.com --- qga/commands-win32.c | 32 1 files changed, 32 insertions(+), 0 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 7e8ecb3..0a2bb34 100644 ---

Re: [Qemu-devel] [PATCH 3/3] iscsi_truncate: ensure there are no requests in flight

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 10:31, Kevin Wolf ha scritto: Isn't the real problem that I/O requests for _this_specific_ iscsi BDS must not be in flight? So what you reall need is bdrv_drain(iscsi_bs)? If I understand the code correctly, this boils down to: while (iscsi_process_flush(iscsilun)) {

[Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Gerd Hoffmann
Kill the dirty hack which hooks gtk vte initialization into the qemu consoles subsystem. The vte terminals are not related to qemu consoles at all. This simply doesn't belong there and it stands in the way when cleaning up the qemu consoles subsystem. So fix it up, quickly, before it sneaks

Re: [Qemu-devel] [PATCH V2 07/10] snapshot: qmp use new internal API for external snapshot transaction

2013-03-13 Thread Kevin Wolf
Am 12.03.2013 um 09:30 hat Wenchao Xia geschrieben: I redesigned the structure, Following is the fake code: typedef struct BdrvActionOps { /* check the request's validation, allocate p_opaque if needed */ int (*check)(BlockdevAction *action, void **p_opaque, Error **errp); /*

Re: [Qemu-devel] [PATCH v2 1/5] net: spread hub on AioContexts

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 03:26, liu ping fan ha scritto: +qemu_net_queue_append(port-nc.peer-send_queue, port-nc, +QEMU_NET_PACKET_FLAG_NONE, buf, len, NULL); +event_notifier_set(port-e); Why are the context and the EventNotifier a property of the port,

Re: [Qemu-devel] [PATCH v2 4/5] net: introduce lock to protect NetClientState's peer's access

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 02:26, liu ping fan ha scritto: On Tue, Mar 12, 2013 at 4:55 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 07/03/2013 03:53, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Introduce nc-send_lock, it shield off the race of nc-peer's reader and deleter.

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards making network layer mutlit-thread. The brief of the whole aim and plan is documented on http://wiki.qemu.org/Features/network_reentrant In these series, attach

Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

2013-03-13 Thread Kevin Wolf
Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: This includes basic PCI support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com +static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno) +{ +QPCIBusPC *s = container_of(bus, QPCIBusPC, bus); +static const int

Re: [Qemu-devel] dataplane bug: fail to start VM with dataplane enable

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 06:01:40PM +0800, Dunrong Huang wrote: Hi, Paolo Stefan: When I test the dataplane feature with git master, I find that VM will hang if dataplane is enabled. But if I use qemu-1.4.0, VM can start normally. The command I boot QEMU is:

Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 10:54:50AM +0800, Wenchao Xia wrote: 于 2013-3-13 0:16, Eric Blake 写道: On 03/12/2013 04:07 AM, Stefan Hajnoczi wrote: On Mon, Mar 11, 2013 at 07:23:02PM +0800, Wenchao Xia wrote: In the use of snapshot a way to retrieve related info at runtime is needed, so this

Re: [Qemu-devel] [PATCH 2/9] qapi_c_arrays.diff

2013-03-13 Thread Eric Blake
On 03/12/2013 09:09 PM, Joel Schopp wrote: Forward ported Mike's previously sent patch (see http://lists.gnu.org/archive/html/qemu-devel/2012-10/msg05782.html ) in my series since it impelments a qapi array interface the ASN.1 BER visitor needs. s/impelments/implements/ Generally these

Re: [Qemu-devel] [PATCH 0/2 v4] Add Windows support for time resync by qemu-ga

2013-03-13 Thread Eric Blake
On 03/13/2013 04:10 AM, li...@linux.vnet.ibm.com wrote: From: Lei Li li...@linux.vnet.ibm.com This patch series attempts to add Windows implementation for qemu-ga commands guest-get-time and guest-set-time. The previous thread about the interfaces introduced and the POSIX-specific

Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

2013-03-13 Thread Andreas Färber
Am 05.03.2013 14:53, schrieb Anthony Liguori: This includes basic PCI support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- configure | 2 +- tests/Makefile| 2 +- tests/libqos/pci-pc.c | 219 ++

Re: [Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-13 Thread Paolo Bonzini
Il 12/03/2013 23:43, Joel Schopp ha scritto: This patch reorganizes qemu file operations to be in their own source file instead of being lumped in savevm.c. Besides being more logical for maintenance it also makes it easier for future users of the file functions to add tests. v3 forward

Re: [Qemu-devel] About the Thread model in Qemu【 Is it one thread per vcpu?】

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 10:56, Laurent Desnogues ha scritto: There has been some other research work with QEMU in this area, you should probably look it up. However it has all been we fixed enough of the big problems to be able to run some benchmarks and write our research paper, so none of this is

[Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-03-13 Thread Pavel Dovgaluk
Added cleanup for Win32 TAP interface. Signed-off-by: Pavel Dovgalyukpavel.dovga...@gmail.com --- net/tap-win32.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/tap-win32.c b/net/tap-win32.c index 91e9e84..1c1176c 100644 --- a/net/tap-win32.c +++

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Kill the dirty hack which hooks gtk vte initialization into the qemu consoles subsystem. The vte terminals are not related to qemu consoles at all. This simply doesn't belong there and it stands in the way when cleaning up the qemu consoles subsystem.

Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info

2013-03-13 Thread Eric Blake
On 03/13/2013 05:34 AM, Stefan Hajnoczi wrote: { 'type': 'BlockDeviceInfo', 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', '*backing_file': 'str', 'backing_file_depth': 'int', 'encrypted': 'bool', 'encryption_key_missing': 'bool', 'bps': 'int',

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards making network layer mutlit-thread. The brief of the whole aim and plan is documented on

Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info

2013-03-13 Thread Kevin Wolf
Am 13.03.2013 um 13:29 hat Eric Blake geschrieben: On 03/13/2013 05:34 AM, Stefan Hajnoczi wrote: { 'type': 'BlockDeviceInfo', 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', '*backing_file': 'str', 'backing_file_depth': 'int', 'encrypted': 'bool',

Re: [Qemu-devel] [PULL v3 00/19] chardev: qapi conversion continued

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, git://git.kraxel.org/qemu chardev.3 Pushed chardev.4 ... Please send another pull request with a v2. Otherwise it confuses my scripts. Regards, Anthony Liguori chardev: add vc support to qapi [fixup] vc ... with these two

Re: [Qemu-devel] [PATCH V9 00/14] qmp/hmp interfaces for internal snapshot info

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 06:29:18AM -0600, Eric Blake wrote: On 03/13/2013 05:34 AM, Stefan Hajnoczi wrote: { 'type': 'BlockDeviceInfo', 'data': { 'file': 'str', 'ro': 'bool', 'drv': 'str', '*backing_file': 'str', 'backing_file_depth': 'int', 'encrypted':

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Kevin Wolf
Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: 于 2013-3-12 1:49, Eric Blake 写道: On 03/11/2013 05:23 AM, Wenchao Xia wrote: This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia

Re: [Qemu-devel] [PATCH] Added cleanup for Win32 TAP interface

2013-03-13 Thread Stefan Hajnoczi
On Wed, Mar 13, 2013 at 04:23:52PM +0400, Pavel Dovgaluk wrote: Added cleanup for Win32 TAP interface. Signed-off-by: Pavel Dovgalyukpavel.dovga...@gmail.com --- net/tap-win32.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/tap-win32.c

Re: [Qemu-devel] cg6 implementation in QEMU

2013-03-13 Thread Jean-Michel SCHRAMM
Hi Artyom, Hi Artyom, Thanks again for your interest. Le 07/03/2013 23:58, Artyom Tarasenko a écrit : Hi Jean Michel, On Thu, Mar 7, 2013 at 4:09 PM, Jean-Michel SCHRAMM jean.michel.schr...@genavir.fr wrote: Hello Artyom, Thanks for taking time to consider my needs for serial ports. I

Re: [Qemu-devel] [PATCH v2 0/7] threadpool: support multiple ThreadPools

2013-03-13 Thread Stefan Hajnoczi
On Thu, Mar 07, 2013 at 01:41:43PM +0100, Stefan Hajnoczi wrote: This patch series changes the global thread pool to a one ThreadPool per AioContext model. We still only use the main loop AioContext so in practice there is just one ThreadPool. But this opens the door to refactoring the

Re: [Qemu-devel] [RFC PATCH 8/8] libqos: add malloc

2013-03-13 Thread Kevin Wolf
Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- /dev/null +++ b/tests/libqos/malloc.h @@ -0,0 +1,26 @@ +#ifndef LIBQOS_MALLOC_H +#define LIBQOS_MALLOC_H + +#include stdint.h +#include sys/types.h + +typedef struct

Re: [Qemu-devel] [PATCH v2 0/9] tcg-arm improvements

2013-03-13 Thread Laurent Desnogues
On Tue, Mar 12, 2013 at 7:43 AM, Richard Henderson r...@twiddle.net wrote: Changes v1-v2: * Use more helper functions to handle K and N constraints. * Improve add2/sub2. * Improve epilogues, as suggested in the previous thread. * Fix a typo in the name of the deposit helper. *

[Qemu-devel] [PATCH 0/7] Spice / usb-redir chardev flowcontrol patches

2013-03-13 Thread Hans de Goede
Here is a series adding watch support to the spicevmc chardev backend and flowcontrol support to the usb-redir device. It begins with a few chardev related bugfixes which were found during the development of this series. Note that this series is based *on top of* Gerd Hoffmann's chardev.4 series

[Qemu-devel] [PATCH 2/7] virtio-console: Remove any pending watches on close

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/virtio-console.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c b/hw/virtio-console.c index 1d87c5b..ec0f91b 100644 --- a/hw/virtio-console.c +++ b/hw/virtio-console.c @@ -18,6 +18,7

[Qemu-devel] [PATCH 3/7] spice-qemu-char: Fix name parameter issues after qapi-ifying

2013-03-13 Thread Hans de Goede
The strings passed in through the qapi calls are dynamic memory, since we want to have them stick around longer then just the call to qemu_chr_open_spice_* we need to strdup them. Signed-off-by: Hans de Goede hdego...@redhat.com --- spice-qemu-char.c | 9 +++-- 1 file changed, 7

[Qemu-devel] [PATCH 5/7] spice-qemu-char: Add watch support

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- spice-qemu-char.c | 67 +++ 1 file changed, 63 insertions(+), 4 deletions(-) diff --git a/spice-qemu-char.c b/spice-qemu-char.c index 8a9236d..e9eea0d 100644 --- a/spice-qemu-char.c +++

[Qemu-devel] [PATCH 1/7] virtio-console: Also throttle when less was written then requested

2013-03-13 Thread Hans de Goede
This is necessary so that we get properly woken up to write the rest. Signed-off-by: Hans de Goede hdego...@redhat.com Acked-by: Amit Shah amit.s...@redhat.com --- hw/virtio-console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/virtio-console.c

[Qemu-devel] [PATCH 4/7] spice-qemu-char: Remove dead debugging code

2013-03-13 Thread Hans de Goede
Since commit d62e5f7036a018b2ad09f17ebd481bd28953d783 chardev: add spice support to qapi It is impossible to set the debug parameter, so all the dprintf calls are essentially nops. Since we've not needed the debug parameter in ages this is not a problem, if it later turns out we do need some more

[Qemu-devel] [PATCH 6/7] spice-qemu-char.c: Remove intermediate buffer

2013-03-13 Thread Hans de Goede
From: Alon Levy al...@redhat.com virtio-serial's buffer is valid when it calls us, and we don't access it otherwise: vmc_read is only called in response to wakeup, or else we set datalen=0 and throttle. Then vmc_read is called back, we return 0 (not accessing the buffer) and set the timer to

[Qemu-devel] [PATCH 7/7] usb-redir: Add flow control support

2013-03-13 Thread Hans de Goede
Signed-off-by: Hans de Goede hdego...@redhat.com --- hw/usb/redirect.c | 32 +++- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c index c519b9b..9ba714d 100644 --- a/hw/usb/redirect.c +++ b/hw/usb/redirect.c @@ -104,6

Re: [Qemu-devel] [RFC PATCH 1/8] qtest: add libqos

2013-03-13 Thread Anthony Liguori
Kevin Wolf kw...@redhat.com writes: Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: This includes basic PCI support. Signed-off-by: Anthony Liguori aligu...@us.ibm.com +static void *qpci_pc_iomap(QPCIBus *bus, QPCIDevice *dev, int barno) +{ +QPCIBusPC *s = container_of(bus,

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Gerd Hoffmann
On 03/13/13 13:29, Anthony Liguori wrote: Gerd Hoffmann kra...@redhat.com writes: Kill the dirty hack which hooks gtk vte initialization into the qemu consoles subsystem. The vte terminals are not related to qemu consoles at all. This simply doesn't belong there and it stands in the way

[Qemu-devel] [PATCH] dataplane: fix hang introduced by AioContext transition

2013-03-13 Thread Paolo Bonzini
The bug is that the EventNotifiers do have a NULL io_flush callback. Because _none_ of the callbacks on the dataplane AioContext have such a callback, aio_poll will simply do nothing. Fixed by adding the callbacks: the ioeventfd will always be polled (this can change in the future to pause/resume

Re: [Qemu-devel] [RFC PATCH 8/8] libqos: add malloc

2013-03-13 Thread Anthony Liguori
Kevin Wolf kw...@redhat.com writes: Am 05.03.2013 um 14:53 hat Anthony Liguori geschrieben: Signed-off-by: Anthony Liguori aligu...@us.ibm.com --- /dev/null +++ b/tests/libqos/malloc.h @@ -0,0 +1,26 @@ +#ifndef LIBQOS_MALLOC_H +#define LIBQOS_MALLOC_H + +#include stdint.h +#include

[Qemu-devel] [PATCH] qemu-iotests: add tests for rebasing zero clusters

2013-03-13 Thread Paolo Bonzini
If zero clusters are erroneously treated as unallocated, qemu-img rebase will copy the backing file's contents onto the cluster. The bug existed also in image streaming, but since the root cause was in qcow2's is_allocated implementation it is enough to test it with qemu-img. Signed-off-by:

Re: [Qemu-devel] Block I/O optimizations

2013-03-13 Thread Stefan Hajnoczi
On Thu, Feb 21, 2013 at 9:11 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Feb 18, 2013 at 7:19 PM, Loic Dachary l...@dachary.org wrote: I recently tried to figure out the best and easiest ways to increase block I/O performances with qemu. Not being a qemu expert, I expected to find a

Re: [Qemu-devel] [PATCH v6 2/8] virtio-blk: add the virtio-blk device.

2013-03-13 Thread KONRAD Frédéric
On 13/03/2013 09:24, KONRAD Frédéric wrote: On 12/03/2013 17:31, Cornelia Huck wrote: On Tue, 12 Mar 2013 16:22:22 +0100 KONRAD Frédéric fred.kon...@greensocs.com wrote: On 12/03/2013 16:12, Peter Maydell wrote: On 12 March 2013 15:08, KONRAD Frédéric fred.kon...@greensocs.com wrote: On

[Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction

2013-03-13 Thread Alon Levy
No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/qxl.c b/hw/qxl.c index ef69348..4cbab45 100644 ---

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: On 03/13/13 13:29, Anthony Liguori wrote: Gerd Hoffmann kra...@redhat.com writes: Kill the dirty hack which hooks gtk vte initialization into the qemu consoles subsystem. The vte terminals are not related to qemu consoles at all. This simply

Re: [Qemu-devel] [PATCH] spice: (32 bit only) fix surface cmd tracking destruction

2013-03-13 Thread Hans de Goede
Looks good, Acked-by: Hans de Goede hdego...@redhat.com On 03/13/2013 04:58 PM, Alon Levy wrote: No change for 64 bit arches, but for 32 bit previously we zeroed half the surfaces cmd array, instead of all of it. Signed-off-by: Alon Levy al...@redhat.com --- hw/qxl.c | 2 +- 1 file

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 13:34, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards making network layer mutlit-thread. The brief of the whole aim and plan

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Gerd Hoffmann
Hi, Also: Once I'm done with the console cleanup it will be easy to make 'vc' actually work with gtk. Please no. 'vc' needs to die. I don't want anyone using it... Likewise easy. 'vc' is a graphical chardev and it should be up to what UI layer to decide how to express it No.

Re: [Qemu-devel] [PATCHv5 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 08:45:51AM +0100, Markus Armbruster wrote: Anthony asked for a space between PATCH and vN in the subject. Please try to remember next time. Michael S. Tsirkin m...@redhat.com writes: libvirt has a long-standing bug: when removing the device, it can request

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread mdroth
On Wed, Mar 13, 2013 at 05:21:02PM +0100, Paolo Bonzini wrote: Il 13/03/2013 13:34, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards

Re: [Qemu-devel] [PATCH 17/20] qemu-char: move text console init to console.c

2013-03-13 Thread Anthony Liguori
Amit Shah amit.s...@redhat.com writes: From: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Amit Shah amit.s...@redhat.com This patch broke vc switching in GTK. --- qemu-char.c | 1 - ui/console.c | 7 +++ 2 files changed, 7

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 13:34, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 06:59, Liu Ping Fan ha scritto: These series aim to port network backend onto glib, and prepare for moving towards making network layer

Re: [Qemu-devel] [PATCH] chardev: add vte chardev

2013-03-13 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, Also: Once I'm done with the console cleanup it will be easy to make 'vc' actually work with gtk. Please no. 'vc' needs to die. I don't want anyone using it... Likewise easy. 'vc' is a graphical chardev and it should be up to what UI

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 18:06, mdroth ha scritto: But isn't there also an effort to make virtio-blk/virtio-net a model for threaded devices/subsystems in general, as opposed to accelerators for specific use-cases like tap-based backends? I think this is the main question, because most of the planning

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
Il 13/03/2013 18:23, Anthony Liguori ha scritto: I think the nesting is also a bit strange. Nesting's gone since we added coroutines. :) and AioContext's code is vastly simpler than GMainLoop's. For now. Fair enough. :) AioContext is also documented and unit tested, with tests for both

[Qemu-devel] [PATCH v6 0/3] DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. First patch only adds the event with ID, second patch adds a path field. Split this way for ease of backport (stable

[Qemu-devel] [PATCH v6 1/3] qdev: DEVICE_DELETED event

2013-03-13 Thread Michael S. Tsirkin
libvirt has a long-standing bug: when removing the device, it can request removal but does not know when the removal completes. Add an event so we can fix this in a robust way. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- QMP/qmp-events.txt| 16 hw/qdev.c

[Qemu-devel] [PATCH v6 2/3] qom: pass original path to unparent method

2013-03-13 Thread Michael S. Tsirkin
We need to know the original path since unparenting loses this state. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/qdev.c| 4 ++-- include/qom/object.h | 3 ++- qom/object.c | 4 +++- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/qdev.c

[Qemu-devel] [PATCH v6 3/3] qmp: add path to device_deleted event

2013-03-13 Thread Michael S. Tsirkin
Add QOM path to device deleted event. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- QMP/qmp-events.txt | 4 +++- hw/qdev.c | 9 - 2 files changed, 7 insertions(+), 6 deletions(-) diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt index 24cf3e8..dcc826d 100644 ---

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 18:23, Anthony Liguori ha scritto: I think the nesting is also a bit strange. Nesting's gone since we added coroutines. :) Okay, I owe AioContext a deeper look then. Regards, Anthony Liguori I would like the dataplane virtio code to

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Michael S. Tsirkin
On Wed, Mar 13, 2013 at 06:31:57PM +0100, Paolo Bonzini wrote: We could do that purely with AioContexts as well, but that rules out a large class of backends that offloaded event loops can interact with, such as Chardevs, so I think modelling how to handle both will provide a threading

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/03/2013 18:23, Anthony Liguori ha scritto: I think the nesting is also a bit strange. Nesting's gone since we added coroutines. :) Okay, deeper isn't that hard apparently. There's not a lot in AioContext. Specifically: 1) It has no facility

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 03/11/2013 05:23 AM, Wenchao Xia wrote: This patch adds block/snapshot.c and then moves the function there. It also fixes small code style errors reported by check script. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Paolo Bonzini
1) It has no facility for timer events Yup, it's on the todo list. 2) It's tied to file descriptors (only a problem for win32) The other way round: it's not tied to file descriptors for win32, which is already a problem for e.g. networked backends. main-loop.c has the code that is needed,

Re: [Qemu-devel] [RFC PATCH 0/2] port network layer onto glib

2013-03-13 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Wed, Mar 13, 2013 at 06:31:57PM +0100, Paolo Bonzini wrote: We could do that purely with AioContexts as well, but that rules out a large class of backends that offloaded event loops can interact with, such as Chardevs, so I think modelling

Re: [Qemu-devel] [PATCH v3] Move File operations to qemu-file.c

2013-03-13 Thread Joel Schopp
-util-obj-y = util/ qobject/ qapi/ trace/ +util-obj-y = util/ qobject/ qapi/ trace/ qemu-file.o Please either move it to util/ (and the include file to include/qemu/file.h), or leave it in common-obj-y. I prefer the former, since as a rule of thumb util-obj-y includes code that should be

Re: [Qemu-devel] [PATCH V9 01/14] block: move bdrv_snapshot_find() to block/snapshot.c

2013-03-13 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 12.03.2013 um 06:01 hat Wenchao Xia geschrieben: Oops, Since it belongs to block layer I hope it can be LGPL2. Do you know how to contact Fabrice Bellard to ask for a change? Fabrice is not the only copyright owner of this file. Just copy the

  1   2   >