Re: [Qemu-devel] [RFC PATCH RDMA support v4: 03/10] more verbose documentation of the RDMA transport

2013-03-21 Thread Michael S. Tsirkin
On Tue, Mar 19, 2013 at 01:49:34PM -0400, Michael R. Hines wrote: I also did a test using RDMA + cgroup, and the kernel killed my QEMU :) So, infiniband is not smart enough to know how to avoid pinning a zero page, I guess. - Michael On 03/19/2013 01:14 PM, Paolo Bonzini wrote: Il

[Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
core/umem.c seems to get the arguments to get_user_pages in the reverse order: it sets writeable flag and breaks COW for MAP_SHARED if and only if hardware needs to write the page. This breaks memory overcommit for users such as KVM: each time we try to register a page to send it to remote, this

Re: [Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files

2013-03-21 Thread li guang
ping ... can this change be accepted? 在 2013-03-13三的 16:01 +0800,liguang写道: ignore *.patch, *.gcda, *.gcno Signed-off-by: liguang lig.f...@cn.fujitsu.com --- .gitignore |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index

Re: [Qemu-devel] [PATCH][RFC 03/14] qdev: remove redundant abort()

2013-03-21 Thread li guang
ping ... can this change be accepted? 在 2013-03-18一的 09:26 +0100,Andreas Färber写道: Am 13.03.2013 09:01, schrieb liguang: Signed-off-by: liguang lig.f...@cn.fujitsu.com --- hw/qdev.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c

Re: [Qemu-devel] [RFC] qmp interface for save vmstate to image

2013-03-21 Thread Wenchao Xia
Hi, Pavel Sorry for late response. Hi Wenchao, It seems the we are working on the same thing. You are trying to improve the size of vmstate if you want to save it to file or as an internal snapshot. I'm also working on that issue and I think that my solution could be also used for

[Qemu-devel] [RFC qemu PATCH] only writing out the last byte of MAC makes it have effect

2013-03-21 Thread Amos Kong
The lengcy guests don't have mac programming command, we don't know when it's safe to use MAC. This patch changed qemu to makes MAC change effect when the last byte of MAC is written to config space. MAC address takes first 6 bytes of config space of virtio-net, the addr is 5 when the last byte

Re: [Qemu-devel] [PATCH v3] pciinit: Enable default VGA device

2013-03-21 Thread Gerd Hoffmann
On 03/20/13 17:58, Alex Williamson wrote: As QEMU gains PCI bridge and PCIe root port support, we won't always find the VGA device on the root bus. We therefore need to add support to find and enable a VGA device and the path to it through the VGA Enable support in the PCI bridge control

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Gerd Hoffmann
On 03/20/13 17:59, Alon Levy wrote: I thought we previously discussed this? Just implement a migration hook in the spice code. We did and Gerd objected so I sent this to have this discussion again, with him. migration section != migration hook. I think what Anthony asks for is to

Re: [Qemu-devel] [PATCH] qemu-ga: use key-value store to avoid recycling fd handles after restart

2013-03-21 Thread Markus Armbruster
mdroth mdr...@linux.vnet.ibm.com writes: On Wed, Mar 20, 2013 at 02:38:35PM -0400, Luiz Capitulino wrote: On Wed, 20 Mar 2013 13:14:21 -0500 mdroth mdr...@linux.vnet.ibm.com wrote: +handle = s-pstate.fd_counter++; +if (s-pstate.fd_counter 0) { +

Re: [Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 11:55:54PM -0700, Roland Dreier wrote: On Wed, Mar 20, 2013 at 11:18 PM, Michael S. Tsirkin m...@redhat.com wrote: core/umem.c seems to get the arguments to get_user_pages in the reverse order: it sets writeable flag and breaks COW for MAP_SHARED if and only if

Re: [Qemu-devel] TCG broken in system mode (was TCG assertion with qemu-system-mipsel)

2013-03-21 Thread Yeongkyoon Lee
On 03/18/2013 07:27 AM, Aurélien Jarno wrote: On Wed, Mar 06, 2013 at 07:10:17AM +0100, Aurélien Jarno wrote: On Wed, Mar 06, 2013 at 11:05:15AM +0900, Yeongkyoon Lee wrote: On 03/05/2013 11:18 PM, Aurélien Jarno wrote: On Mon, Mar 04, 2013 at 05:37:31PM +0100, Aurélien Jarno wrote: Hi, On

Re: [Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm

2013-03-21 Thread Markus Armbruster
Corey Bryant cor...@linux.vnet.ibm.com writes: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com --- hmp.c|8 qapi-schema.json | 12 tpm/tpm.c|9 - 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hmp.c

Re: [Qemu-devel] [PATCH 2/2] QMP: TPM QMP and man page documentation updates

2013-03-21 Thread Markus Armbruster
Corey Bryant cor...@linux.vnet.ibm.com writes: Signed-off-by: Corey Bryant cor...@linux.vnet.ibm.com Reviewed-by: Markus Armbruster arm...@redhat.com

Re: [Qemu-devel] [PATCH 09/23] console: displaystate init revamp

2013-03-21 Thread Gerd Hoffmann
Hi, Shouldn't get_alloc_displaystate() be used here instead? Thought about it, doesn't save a single line of code though, so I skipped the extra indirection. cheers, Gerd

[Qemu-devel] Use of flash for x86 BIOS (was: [PATCH 0/2] Implement migration support for pflash_cfi01)

2013-03-21 Thread Markus Armbruster
[Note cc: Jordan, who added flash to x86 in commit bd183c79] Peter Maydell peter.mayd...@linaro.org writes: These patches implement migration support for pflash_cfi01. The first patch just drops some useless state so we don't have to think about it for migration. NB that pflash_cfi01 is

Re: [Qemu-devel] large memory requirements for translate.c a barrier

2013-03-21 Thread qemu-devel
Penned by Paolo Bonzini on 20130316 3:14.29, we have: | Il 15/03/2013 20:21, Todd T. Fries ha scritto: |PID USERNAME PRI NICE SIZE RES STATE WAIT TIMECPU COMMAND | 28818 todd 640 1142M 53M onproc/0 - 2:01 17.24% cc1 | | For systems with lower limits on

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-21 Thread Gerd Hoffmann
On 03/20/13 21:06, Peter Maydell wrote: On 20 March 2013 09:43, Gerd Hoffmann kra...@redhat.com wrote: Multihead support: For each graphical console we'll create a gtk window, so with multiple graphics cards installed you get a gtk window for each. vte tabs are attached to the console #0

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Hans de Goede
Hi, On 03/20/2013 07:59 PM, Anthony Liguori wrote: Alon Levy al...@redhat.com writes: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com --- include/char/char.h | 12 qemu-char.c | 7 +++ 2 files changed, 19 insertions(+) diff --git

Re: [Qemu-devel] large memory requirements for translate.c a barrier

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 08:53, qemu-de...@email.fries.net ha scritto: load averages: 6.74, 6.23, 5.17leveno.fries.net 02:42:23 201 processes: 200 idle, 1 on processor CPU0 states: 0.4% user, 0.0% nice, 33.3% system, 37.1% interrupt, 29.1% idle CPU1 states: 0.2% user, 0.0%

Re: [Qemu-devel] [RFC ppc-next PATCH 2/6] kvm: hw/kvm is not x86-specific

2013-03-21 Thread Alexander Graf
If you repost this one with a proper patch description and without RFC, I'd be happy to apply it before the in-kernel MPIC implementation is done. Alex On 14.02.2013, at 07:31, Scott Wood wrote: Signed-off-by: Scott Wood scottw...@freescale.com --- hw/Makefile.objs |1 +

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Alexander Graf
On 14.02.2013, at 07:31, Scott Wood wrote: This is useful for when a user of the memory region API needs to communicate the absolute bus address to something outside QEMU (in particular, KVM). Signed-off-by: Scott Wood scottw...@freescale.com Peter, how does the VGIC implementation handle

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Hans de Goede
Hi, On 03/21/2013 09:27 AM, Hans de Goede wrote: Hi, On 03/20/2013 07:59 PM, Anthony Liguori wrote: Alon Levy al...@redhat.com writes: Alon Levy al...@redhat.com writes: Signed-off-by: Alon Levy al...@redhat.com --- include/char/char.h | 12 qemu-char.c | 7

Re: [Qemu-devel] [RFC ppc-next PATCH 5/6] kvm: export result of irqchip config check

2013-03-21 Thread Alexander Graf
On 14.02.2013, at 07:32, Scott Wood wrote: This allows platform code to register in-kernel irqchips that don't use the legacy KVM_CAP_IRQCHIP/KVM_CREATE_IRQCHIP interface. Signed-off-by: Scott Wood scottw...@freescale.com --- include/sysemu/kvm.h | 10 ++ kvm-all.c|

[Qemu-devel] [PATCH v15 3/6] introduce a new qom device to deal with panicked event

2013-03-21 Thread Hu Tao
pvpanic device is used to send guest panic event from guest to qemu. When guest panic happens, pvpanic device driver will write a event number to IO port 0x505(which is the IO port occupied by pvpanic device, by default). On receiving the event, pvpanic device will pause guest cpu(s), and send a

[Qemu-devel] [PATCH v15 4/6] pvpanic: add document of pvpanic

2013-03-21 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/specs/pvpanic.txt | 25 + 1 file changed, 25 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file mode 100644 index 000..761d20c --- /dev/null

[Qemu-devel] [RFC][PATCH v15 6/6] pvpanic: pass configurable ioport to seabios

2013-03-21 Thread Hu Tao
This lets seabios patch the corresponding SSDT entry. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/fw_cfg.h | 2 ++ hw/pvpanic.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/hw/fw_cfg.h b/hw/fw_cfg.h index 05c8df1..07cc941 100644 --- a/hw/fw_cfg.h +++ b/hw/fw_cfg.h

[Qemu-devel] [PATCH v15 2/6] add a new qevent: QEVENT_GUEST_PANICKED

2013-03-21 Thread Hu Tao
This event will be emited when qemu detects guest panic. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- QMP/qmp-events.txt| 14 ++ include/monitor/monitor.h | 1 + monitor.c | 1 + 3 files changed, 16

[Qemu-devel] [PATCH v15 1/6] add a new runstate: RUN_STATE_GUEST_PANICKED

2013-03-21 Thread Hu Tao
The guest will be in this state when it is panicked. Signed-off-by: Wen Congyang we...@cn.fujitsu.com Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- include/sysemu/sysemu.h | 1 + qapi-schema.json| 5 - qmp.c | 3 +-- vl.c| 13 +++-- 4

[Qemu-devel] [PATCH v15 0/6] Add pvpanic device to deal with guest panic event

2013-03-21 Thread Hu Tao
This series introduces a new simulated device, pvpanic, to notify qemu when guest panic event happens. Along with this series, there are two patches to add seabios ACPI driver and kernel ACPI driver for the device, respectively. Tested with combinations of qemu(kvm)/qemu(tcg), piix/q35, and

Re: [Qemu-devel] [RFC ppc-next PATCH 6/6] kvm/openpic: in-kernel mpic support

2013-03-21 Thread Alexander Graf
On 14.02.2013, at 07:32, Scott Wood wrote: This depends on RFC kernel interfaces proposed at: http://patchwork.ozlabs.org/patch/220359/ http://patchwork.ozlabs.org/patch/220362/ Signed-off-by: Scott Wood scottw...@freescale.com --- hw/kvm/Makefile.objs |1 + hw/kvm/openpic.c |

Re: [Qemu-devel] [RFC ppc-next PATCH 5/6] kvm: export result of irqchip config check

2013-03-21 Thread Jan Kiszka
On 2013-03-21 09:34, Alexander Graf wrote: On 14.02.2013, at 07:32, Scott Wood wrote: This allows platform code to register in-kernel irqchips that don't use the legacy KVM_CAP_IRQCHIP/KVM_CREATE_IRQCHIP interface. Signed-off-by: Scott Wood scottw...@freescale.com ---

Re: [Qemu-devel] [RFC ppc-next PATCH 5/6] kvm: export result of irqchip config check

2013-03-21 Thread Alexander Graf
On 21.03.2013, at 09:45, Jan Kiszka wrote: On 2013-03-21 09:34, Alexander Graf wrote: On 14.02.2013, at 07:32, Scott Wood wrote: This allows platform code to register in-kernel irqchips that don't use the legacy KVM_CAP_IRQCHIP/KVM_CREATE_IRQCHIP interface. Signed-off-by: Scott Wood

Re: [Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 12:15:33AM -0700, Roland Dreier wrote: I think this change will break the case where userspace tries to register an MR with read-only permission, but intends locally through the CPU to write to the memory. Shouldn't it set LOCAL_WRITE then? We're talking about

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-21 Thread Gerd Hoffmann
On 03/21/13 08:52, Gerd Hoffmann wrote: On 03/20/13 21:06, Peter Maydell wrote: On 20 March 2013 09:43, Gerd Hoffmann kra...@redhat.com wrote: Multihead support: For each graphical console we'll create a gtk window, so with multiple graphics cards installed you get a gtk window for each.

Re: [Qemu-devel] [PATCH 1/4] char: add a post_load callback

2013-03-21 Thread Alon Levy
On 03/20/13 17:59, Alon Levy wrote: I thought we previously discussed this? Just implement a migration hook in the spice code. We did and Gerd objected so I sent this to have this discussion again, with him. migration section != migration hook. I think what Anthony asks for

[Qemu-devel] [RFC][PATCH v15 5/6] pc_piix, pc_q35: export fw_cfg

2013-03-21 Thread Hu Tao
This lets other devices pass informations to seabios. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/i386/pc_piix.c | 7 --- hw/i386/pc_q35.c | 9 ++--- hw/pc.h | 6 ++ 3 files changed, 16 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c

Re: [Qemu-devel] [PATCH v2] Add option to mlock qemu and guest memory

2013-03-21 Thread Jan Kiszka
On 2013-02-14 21:21, Satoru Moriya wrote: We have some plans to migrate legacy enterprise systems which require low latency (10 msec order) to kvm virtualized environment. In our usecase, the system runs with other untrusted guests and so locking memory which is used by the system is needed to

[Qemu-devel] [PATCH v15 1/2] add pvpanic device driver

2013-03-21 Thread Hu Tao
pvpanic device is used to notify host(qemu) when guest panic happens. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg03630.html The version number is 15 to consist with qemu patches. src/acpi-dsdt-isa.dsl | 30

[Qemu-devel] [RFC 05/12] Add block_writev_buffer function

2013-03-21 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 13 + 1 file changed, 13 insertions(+) diff --git a/savevm.c b/savevm.c index fa07a86..2c8fb03 100644 --- a/savevm.c +++ b/savevm.c @@ -459,6 +459,18 @@ fail: return NULL; } +static int block_writev_buffer(void

[Qemu-devel] [RFC 04/12] Add stdio_writev_buffer function

2013-03-21 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/savevm.c b/savevm.c index 41dc87f..fa07a86 100644 --- a/savevm.c +++ b/savevm.c @@ -241,6 +241,11 @@ static int stdio_get_fd(void *opaque) return fileno(s-stdio_file); }

[Qemu-devel] [RFC 08/12] Use writev ops instead of put_buffer ops

2013-03-21 Thread Orit Wasserman
Update qemu_fflush and stdio_close to use writev ops Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/savevm.c b/savevm.c index d5834ca..9506a20 100644 --- a/savevm.c +++ b/savevm.c @@ -297,7 +297,7 @@

[Qemu-devel] [RFC 02/12] Add QemuFileWritevBuffer QemuFileOps

2013-03-21 Thread Orit Wasserman
This will allow us to write an iovec Signed-off-by: Orit Wasserman owass...@redhat.com --- include/migration/qemu-file.h | 7 +++ 1 file changed, 7 insertions(+) diff --git a/include/migration/qemu-file.h b/include/migration/qemu-file.h index df81261..8d3da9b 100644 ---

[Qemu-devel] [RFC 07/12] Store the data to send also in iovec

2013-03-21 Thread Orit Wasserman
All data is still copied into the static buffer. Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index ec64533..d5834ca 100644 --- a/savevm.c +++ b/savevm.c @@ -114,6 +114,7 @@

[Qemu-devel] [RFC 06/12] Update bytes_xfer in qemu_put_byte

2013-03-21 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/savevm.c b/savevm.c index 2c8fb03..ec64533 100644 --- a/savevm.c +++ b/savevm.c @@ -666,6 +666,8 @@ void qemu_put_byte(QEMUFile *f, int v) f-buf[f-buf_index++] = v;

[Qemu-devel] [RFC 11/12] Use qemu_put_buffer_no_copy for guest memory pages

2013-03-21 Thread Orit Wasserman
This will remove an unneeded copy of guest memory pages. For the page header and device state we still copy the data to the static buffer the other option is to allocate the memory on demand which is more expensive. Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 2 +- 1 file

[Qemu-devel] [RFC 09/12] More optimized qemu_put_be64/32/16

2013-03-21 Thread Orit Wasserman
qemu_put_be functions used qemu_put_byte this caused lots of 1 bytes buffers in the iovec. we move to use cpu_put_be64/32/16wu and put a single buffer per call. Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 20 1 file changed, 12 insertions(+), 8

[Qemu-devel] [RFC 12/12] Bye Bye put_buffer

2013-03-21 Thread Orit Wasserman
Removed all unused put_buffer code Signed-off-by: Orit Wasserman owass...@redhat.com --- include/migration/qemu-file.h | 8 savevm.c | 29 - 2 files changed, 37 deletions(-) diff --git a/include/migration/qemu-file.h

[Qemu-devel] [PATCH v15] pvpanic: pvpanic device driver

2013-03-21 Thread Hu Tao
pvpanic device is a qemu simulated device through which guest panic event is sent to host. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- ref: http://lists.nongnu.org/archive/html/qemu-devel/2013-03/msg03630.html The version number is 15 to consist with qemu patches.

[Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy

2013-03-21 Thread Orit Wasserman
This allow us to add a buffer to the iovec to send without copying it into the static buffer. Signed-off-by: Orit Wasserman owass...@redhat.com --- include/migration/qemu-file.h | 5 + savevm.c | 42 -- 2 files changed, 29

Re: [Qemu-devel] [RFC][PATCH v15 6/6] pvpanic: pass configurable ioport to seabios

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 09:35, Hu Tao ha scritto: This lets seabios patch the corresponding SSDT entry. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/fw_cfg.h | 2 ++ hw/pvpanic.c | 14 ++ 2 files changed, 16 insertions(+) diff --git a/hw/fw_cfg.h b/hw/fw_cfg.h index

Re: [Qemu-devel] [PATCH v15 4/6] pvpanic: add document of pvpanic

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 09:35, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- docs/specs/pvpanic.txt | 25 + 1 file changed, 25 insertions(+) create mode 100644 docs/specs/pvpanic.txt diff --git a/docs/specs/pvpanic.txt b/docs/specs/pvpanic.txt new file

Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index

Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
On Thu, Mar 21, 2013 at 10:11:54AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:08, Hu Tao ha scritto: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-)

Re: [Qemu-devel] [PATCH] block: fix bdrv_exceed_iops_limits wait computation

2013-03-21 Thread Stefan Hajnoczi
On Thu, Mar 21, 2013 at 09:18:27AM +0800, Zhi Yong Wu wrote: On Wed, 2013-03-20 at 16:12 +0100, Stefan Hajnoczi wrote: On Wed, Mar 20, 2013 at 03:56:33PM +0100, Benoît Canet wrote: But I don't understand why bs-slice_time is modified instead of keeping it constant at 100 ms:

Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/savevm.c b/savevm.c index 35c8d1e..41dc87f 100644 --- a/savevm.c +++ b/savevm.c @@ -39,6 +39,7 @@ #include

Re: [Qemu-devel] [RFC 01/12] Add iov_writev to use writev to send iovec (also for files)

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: We use writev because sendmsg can only be used on socket fds. Signed-off-by: Orit Wasserman owass...@redhat.com --- include/qemu/iov.h | 12 util/iov.c | 36 2 files changed, 48

Re: [Qemu-devel] [RFC 10/12] Add qemu_put_buffer_no_copy

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: +f-iov[f-iovcnt].iov_base = (uint8_t *)buf; +f-iov[f-iovcnt++].iov_len = size; + +f-is_write = 1; +f-bytes_xfer += size; + +if (f-buf_index = IO_BUF_SIZE || f-iovcnt = MAX_IOV_SIZE) { +qemu_fflush(f); } It

Re: [Qemu-devel] [RFC 04/12] Add stdio_writev_buffer function

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/savevm.c b/savevm.c index 41dc87f..fa07a86 100644 --- a/savevm.c +++ b/savevm.c @@ -241,6 +241,11 @@ static int

Re: [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: In migration all data is copied to a static buffer in QEMUFile, this hurts our network bandwidth and CPU usage especially with large guests. We switched to iovec for storing different buffers to send (even a byte field is considered as a

Re: [Qemu-devel] [PATCH] virtio-blk: Set default serial id

2013-03-21 Thread Paolo Bonzini
Il 20/03/2013 09:34, Asias He ha scritto: The solution is to do persistent naming either by really passing -device virtio-blk-pci,serial= or with udev inside the guest using the bus address (PCI devfn) like the new persistent network interface naming for Linux. '-virtio-blk-pci,serial='

Re: [Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
On Wed, Mar 20, 2013 at 11:55:54PM -0700, Roland Dreier wrote: On Wed, Mar 20, 2013 at 11:18 PM, Michael S. Tsirkin m...@redhat.com wrote: core/umem.c seems to get the arguments to get_user_pages in the reverse order: it sets writeable flag and breaks COW for MAP_SHARED if and only if

[Qemu-devel] [RFC 01/12] Add iov_writev to use writev to send iovec (also for files)

2013-03-21 Thread Orit Wasserman
We use writev because sendmsg can only be used on socket fds. Signed-off-by: Orit Wasserman owass...@redhat.com --- include/qemu/iov.h | 12 util/iov.c | 36 2 files changed, 48 insertions(+) diff --git a/include/qemu/iov.h

Re: [Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 02:13:38AM -0700, Roland Dreier wrote: On Thu, Mar 21, 2013 at 1:51 AM, Michael S. Tsirkin m...@redhat.com wrote: In that case, no, I don't see any reason for LOCAL_WRITE, since the only RDMA operations that will access this memory are remote reads. What is the

Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function

2013-03-21 Thread Orit Wasserman
On 03/21/2013 11:18 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/savevm.c b/savevm.c index 35c8d1e..41dc87f 100644 --- a/savevm.c

[Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Orit Wasserman
In migration all data is copied to a static buffer in QEMUFile, this hurts our network bandwidth and CPU usage especially with large guests. We switched to iovec for storing different buffers to send (even a byte field is considered as a buffer) and use writev to send the iovec. writev was chosen

Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:47, Orit Wasserman ha scritto: On 03/21/2013 11:18 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/savevm.c

[Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c| 9 + 2 files changed, 21 insertions(+), 2 deletions(-) diff --git a/src/acpi-dsdt-isa.dsl b/src/acpi-dsdt-isa.dsl index 87a31b9..43fe719 100644 --- a/src/acpi-dsdt-isa.dsl

Re: [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 11:09:19AM +0200, Orit Wasserman wrote: In migration all data is copied to a static buffer in QEMUFile, this hurts our network bandwidth and CPU usage especially with large guests. We switched to iovec for storing different buffers to send (even a byte field is

Re: [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:48, Michael S. Tsirkin ha scritto: A recent discussion about overcommitted memory made me think: this will still need to read pages into memory even if all we will do is send it out on the wire immediately, dirtying cache etc. Now, one property of RAM writes is that if

Re: [Qemu-devel] [PATCH v15 2/2] patch dsdt to use passed-in pvpanic ioport

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 05:08:34PM +0800, Hu Tao wrote: Signed-off-by: Hu Tao hu...@cn.fujitsu.com OK now you need to ACK GPLv2+ relicensing too :) Could you please review that message make acpi bits GPLv2 compatible and respond? --- src/acpi-dsdt-isa.dsl | 14 -- src/acpi.c

Re: [Qemu-devel] [RFC 07/12] Store the data to send also in iovec

2013-03-21 Thread Paolo Bonzini
Il 21/03/2013 10:09, Orit Wasserman ha scritto: All data is still copied into the static buffer. Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/savevm.c b/savevm.c index ec64533..d5834ca

[Qemu-devel] [RFC 03/12] Add socket_writev_buffer function

2013-03-21 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/savevm.c b/savevm.c index 35c8d1e..41dc87f 100644 --- a/savevm.c +++ b/savevm.c @@ -39,6 +39,7 @@ #include qmp-commands.h #include trace.h #include qemu/bitops.h

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] pseries: Move XICS initialization before cpu initialization

2013-03-21 Thread Alexander Graf
On 18.03.2013, at 04:38, David Gibson wrote: On Mon, Mar 18, 2013 at 04:12:11AM +0100, Alexander Graf wrote: On 18.03.2013, at 03:55, David Gibson wrote: On Fri, Mar 15, 2013 at 01:33:18PM +0100, Alexander Graf wrote: On 14.03.2013, at 02:53, David Gibson wrote: Currently, the

Re: [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Orit Wasserman
On 03/21/2013 11:29 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: In migration all data is copied to a static buffer in QEMUFile, this hurts our network bandwidth and CPU usage especially with large guests. We switched to iovec for storing different buffers to send

Re: [Qemu-devel] [PATCH V2] PPC/GDB: handle read and write of fpscr

2013-03-21 Thread Alexander Graf
On 19.03.2013, at 18:41, Fabien Chouteau wrote: Although the support of this register may be uncomplete, there are no reason to prevent the debugger from reading or writing it. Signed-off-by: Fabien Chouteau chout...@adacore.com Thanks, applied to ppc-next. Alex --- gdbstub.c

Re: [Qemu-devel] [RFC 03/12] Add socket_writev_buffer function

2013-03-21 Thread Orit Wasserman
On 03/21/2013 11:47 AM, Paolo Bonzini wrote: Il 21/03/2013 10:47, Orit Wasserman ha scritto: On 03/21/2013 11:18 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 14 ++ 1 file changed, 14

Re: [Qemu-devel] [PATCH] block: fix bdrv_exceed_iops_limits wait computation

2013-03-21 Thread Stefan Hajnoczi
On Wed, Mar 20, 2013 at 04:27:14PM +0100, Benoît Canet wrote: Now there is no oscillation and the wait_times do not grow or shrink under constant load from dd(1). Can you try this patch by itself to see if it fixes the oscillation? On my test setup it fixes the oscillation and lead to

Re: [Qemu-devel] [PATCH 04/11] qapi schema: add AcpiTableOptions

2013-03-21 Thread Laszlo Ersek
On 03/21/13 01:31, Laszlo Ersek wrote: On 03/21/13 00:45, Eric Blake wrote: On 03/20/2013 05:23 PM, Laszlo Ersek wrote: +# +# @oem_id: #optional OEM identifier (6 bytes) s/oem_id/oem-id/ In general, new QMP interfaces should use '-', not '_'. Indeed! I think this warrants a respin.

Re: [Qemu-devel] [PATCH][RFC 0/14] implement power chip

2013-03-21 Thread Peter Maydell
On 21 March 2013 00:36, li guang lig.f...@cn.fujitsu.com wrote: 在 2013-03-20三的 10:50 +,Peter Maydell写道: The devices should just implement appropriate signals/connections if they have a means of talking to a power controller, and the board model should wire them up. That's all. Hmm, can

Re: [Qemu-devel] [PATCH][RFC 01/14] gitignore: ignore more files

2013-03-21 Thread Peter Maydell
On 21 March 2013 06:24, li guang lig.f...@cn.fujitsu.com wrote: ping ... can this change be accepted? 在 2013-03-13三的 16:01 +0800,liguang写道: ignore *.patch, *.gcda, *.gcno Signed-off-by: liguang lig.f...@cn.fujitsu.com If you want a change to be considered for acceptance on its own, it's

Re: [Qemu-devel] [RFC qemu PATCH] only writing out the last byte of MAC makes it have effect

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 02:44:50PM +0800, Amos Kong wrote: The lengcy guests don't have mac programming command, we don't know when it's safe to use MAC. This patch changed qemu to makes MAC change effect when the last byte of MAC is written to config space. MAC address takes first 6 bytes

Re: [Qemu-devel] [RFC virt-spec PATCH] only writing out the last byte of MAC makes it have effect

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 11:02:36AM +0800, Amos Kong wrote: The lengcy guests don't have mac programming command, we don't know when it's safe to use MAC. We can change QEMU to make MAC change effect when the last byte of MAC is written to config space. Signed-off-by: Amos Kong

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Peter Maydell
On 21 March 2013 08:31, Alexander Graf ag...@suse.de wrote: On 14.02.2013, at 07:31, Scott Wood wrote: This is useful for when a user of the memory region API needs to communicate the absolute bus address to something outside QEMU (in particular, KVM). Signed-off-by: Scott Wood

Re: [Qemu-devel] [PATCH 22/23] gtk: show a window for each graphical QemuConsole

2013-03-21 Thread Peter Maydell
On 21 March 2013 08:51, Gerd Hoffmann kra...@redhat.com wrote: On 03/21/13 08:52, Gerd Hoffmann wrote: On 03/20/13 21:06, Peter Maydell wrote: On 20 March 2013 09:43, Gerd Hoffmann kra...@redhat.com wrote: Multihead support: For each graphical console we'll create a gtk window, so with

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Alexander Graf
On 21.03.2013, at 11:53, Peter Maydell wrote: On 21 March 2013 08:31, Alexander Graf ag...@suse.de wrote: On 14.02.2013, at 07:31, Scott Wood wrote: This is useful for when a user of the memory region API needs to communicate the absolute bus address to something outside QEMU (in

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Peter Maydell
On 21 March 2013 10:59, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 11:53, Peter Maydell wrote: Check kvm_arm_register_device() in target-arm/kvm.c. Basically the VGIC device model calls this function to say tell the kernel where this MemoryRegion is in the system address space, when

Re: [Qemu-devel] iscsi / block segfault regression

2013-03-21 Thread Peter Lieven
git bisect results: lieven@lieven-pc:~/git/qemu$ git bisect bad f500a6d3c2b9ef0bb06d0080d91d8ed3c1d68f58 is the first bad commit commit f500a6d3c2b9ef0bb06d0080d91d8ed3c1d68f58 Author: Kevin Wolf kw...@redhat.com Date: Mon Nov 12 17:35:27 2012 +0100 block: Avoid second open for format

[Qemu-devel] iscsi / block segfault regression

2013-03-21 Thread Peter Lieven
Hi, I currently try to debug a regression in git master with iscsi that happens with some iscsi volumes. I added debugging output to all aio calls into block/iscsi.c and it seems that immediately after brdv_open something is overwriting bs-opaque with a new pointer. ~/git/qemu$

Re: [Qemu-devel] [RFC 00/12] Migration: Remove copying of guest ram pages

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 10:53:55AM +0100, Paolo Bonzini wrote: Il 21/03/2013 10:48, Michael S. Tsirkin ha scritto: A recent discussion about overcommitted memory made me think: this will still need to read pages into memory even if all we will do is send it out on the wire immediately,

Re: [Qemu-devel] [RFC 07/12] Store the data to send also in iovec

2013-03-21 Thread Orit Wasserman
On 03/21/2013 11:56 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: All data is still copied into the static buffer. Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Peter Maydell
On 21 March 2013 11:05, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:01, Peter Maydell wrote: On 21 March 2013 10:59, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 11:53, Peter Maydell wrote: Check kvm_arm_register_device() in target-arm/kvm.c. Basically the VGIC device

Re: [Qemu-devel] iscsi / block segfault regression

2013-03-21 Thread Peter Lieven
Segfault happens if I specify format=iscsi in the -drive option group. In this case bdrv_swap() is called. Maybe there is a handling of bs-opaque missing?! Peter On 21.03.2013 12:03, Peter Lieven wrote: git bisect results: lieven@lieven-pc:~/git/qemu$ git bisect bad

Re: [Qemu-devel] [RFC 07/12] Store the data to send also in iovec

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 01:10:40PM +0200, Orit Wasserman wrote: On 03/21/2013 11:56 AM, Paolo Bonzini wrote: Il 21/03/2013 10:09, Orit Wasserman ha scritto: All data is still copied into the static buffer. Signed-off-by: Orit Wasserman owass...@redhat.com --- savevm.c | 13

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Alexander Graf
On 21.03.2013, at 12:09, Peter Maydell wrote: On 21 March 2013 11:05, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:01, Peter Maydell wrote: On 21 March 2013 10:59, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 11:53, Peter Maydell wrote: Check

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Peter Maydell
On 21 March 2013 11:14, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:09, Peter Maydell wrote: On 21 March 2013 11:05, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:01, Peter Maydell wrote: On 21 March 2013 10:59, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Alexander Graf
On 21.03.2013, at 12:01, Peter Maydell wrote: On 21 March 2013 10:59, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 11:53, Peter Maydell wrote: Check kvm_arm_register_device() in target-arm/kvm.c. Basically the VGIC device model calls this function to say tell the kernel where this

Re: [Qemu-devel] [PATCH v2 12/12] nbd: Check against invalid option combinations

2013-03-21 Thread Kevin Wolf
Am 20.03.2013 um 22:34 hat Eric Blake geschrieben: On 03/20/2013 12:39 PM, Kevin Wolf wrote: A file name may only specified if no host or socket path is specified. The latter two may not appear at the same time either. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/nbd.c | 14

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Alexander Graf
On 21.03.2013, at 12:22, Peter Maydell wrote: On 21 March 2013 11:14, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:09, Peter Maydell wrote: On 21 March 2013 11:05, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:01, Peter Maydell wrote: On 21 March 2013 10:59,

Re: [Qemu-devel] [PATCH] rdma: don't make pages writeable if not requiested

2013-03-21 Thread Michael S. Tsirkin
On Thu, Mar 21, 2013 at 11:32:30AM +0200, Michael S. Tsirkin wrote: On Wed, Mar 20, 2013 at 11:55:54PM -0700, Roland Dreier wrote: On Wed, Mar 20, 2013 at 11:18 PM, Michael S. Tsirkin m...@redhat.com wrote: core/umem.c seems to get the arguments to get_user_pages in the reverse order:

Re: [Qemu-devel] [RFC ppc-next PATCH 3/6] memory: add memory_region_to_address()

2013-03-21 Thread Peter Maydell
On 21 March 2013 11:29, Alexander Graf ag...@suse.de wrote: On 21.03.2013, at 12:22, Peter Maydell wrote: We already nest the VGIC inside another memory region (the a15mpcore container), and it works fine. This function is just iterating through everything any device asked me to tell the

  1   2   3   4   >