On 04/16/2013 09:56 AM, Eric Blake wrote:
On 04/16/2013 08:45 AM, Anthony Liguori wrote:
This test compares all of the default register values against the
spec. It turns out we deviate in quite a few places. These
places are really only visible to the BIOS though which is why
this hasn't
I'm sending patches for all commands in one patch series because the
savevm command depends on delvm command.
This patch series introduces new design of these commands:
* QMP vm-snapshot-save:
- { 'command': 'vm-snapshot-save',
'data': { 'name': 'str' },
'returns':
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands. The savevm and loadvm will
have their own patch series.
Now bdrv_snapshot_find takes more parameters. The name parameter
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 22 ++
block/qcow2-snapshot.c| 21 +++--
block/qcow2.h | 4 +++-
block/rbd.c | 11 ---
block/sheepdog.c | 6 --
QMP command vm-snapshot-delete no takes two parameters name and id. They are
optional, but one of the name or id must be provided. If both are provided they
will match only the snapshot with the same name and id. The command returns
SnapshotInfo only if the snapshot exists, if snapshot doesn't
Later in the patch series we will use this function few times.
This will avoid of duplicating the code.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
qemu-img.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index
QMP command vm-snapshot-load and HMP command loadvm behave similar to
vm-snapshot-delete and delvm. The only different is that they will load
the snapshot instead of deleting it.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
hmp-commands.hx | 16 +-
hmp.c |
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
savevm.c | 33 +++--
1 file changed, 11 insertions(+), 22 deletions(-)
diff --git a/savevm.c b/savevm.c
index 66753da..bc829a5 100644
--- a/savevm.c
+++ b/savevm.c
@@ -2195,7 +2195,7 @@ out:
}
static int
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
include/sysemu/sysemu.h | 7 ---
migration.c | 6 +++---
savevm.c| 38 +++---
3 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/include/sysemu/sysemu.h
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 55 ++-
block/qcow2-snapshot.c| 32 +++
block/qcow2.h | 8 +--
block/rbd.c | 19 +++-
block/sheepdog.c
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
include/sysemu/sysemu.h | 2 +-
migration.c | 9 +++
savevm.c| 64 -
3 files changed, 37 insertions(+), 38 deletions(-)
diff --git a/include/sysemu/sysemu.h
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 23 ++-
block/qcow2-snapshot.c| 18 --
block/qcow2.h | 4 +++-
block/rbd.c | 20 +++-
block/sheepdog.c | 22
QMP command vm-snapshot-save now takes one parameter name and the name is
mandatory. The command returns SnapshotInfo on success, otherwise it returns
an error message. If there is a snapshot with the same name it also returns
an error message and if you want to overwrite that snapshot, you will
Consolidate level, xlevel, xlevel2 fields in x86_def_t and CPUX86State.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v9:
* Merged target-i386: Move cpuid_xlevel, cpuid_xlevel2 fields in X86CPU
and target-i386: Move xlevel/xlevel2 in struct x86_def_t
in a single patch
---
Add appropriate spaces around operators, and break line where it needs
to be broken to allow feature-words array to be introduced without
having too-long lines.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v9:
* 1-char alignment change: keep the opening parenthesis of both
Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(),
and builtin_x86_defs, so they don't get too long once the *_features
fields are replaced by an array.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Changes v9:
* Merged all Break lines patches from previous series
Il 16/04/2013 03:10, Lucas Meneghel Rodrigues ha scritto:
Public bug reported:
Relevant qemu.git master commit:
24a6e7f4d91e9ed5f8117ecb083431a23f8609a0
When trying to migrate a VM using the TCP protocol, a segfault happened:
This fixes it in my tests (didn't get a segfault, but I
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all feature words (e.g. kvm_check_features_against_host(),
filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU
Changes v9:
* Merge patches 1,3 from v8 into a single patch (1/4)
* Merge pathces 4-6 from v8 into a single patch (3/4)
* 1-char alignment change on patch 2/4
* Improved description text of patch 4/4
Except for the 1-char alignment change on patch 2/4, the tree resulting from
this version
On 16 April 2013 18:27, Stefan Hajnoczi stefa...@gmail.com wrote:
What is the current status of the xbox target and what would a 12-week
GSoC project accomplish? The scope of the project needs to be clearly
defined so this information is critical.
Currently it runs the bios to completion
** Also affects: qemu
Importance: Undecided
Status: New
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1100843
Title:
Live Migration Causes Performance Issues
Status in QEMU:
New
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
s/covert/convert/ in the subject, if you send a v2 (but doesn't affect
git, so depending on how review goes, you may get lucky :)
I'm sending patches for all commands in one patch series because the
savevm command depends on delvm command.
This
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Later in the patch series we will use this function few times.
s/few/a few/
This will avoid of duplicating the code.
s/of//
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
qemu-img.c | 17 +++--
1 file changed, 11
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 22 ++
block/qcow2-snapshot.c| 21 +++--
block/qcow2.h | 4 +++-
block/rbd.c | 11 ---
The results of comment 23 suggest that the issue is not 100%
reproducible. Can you please run the benchmark 3-4 times
(presave/postrestore) and showall 4 results? One benchmark only, e.g.
simple read will do.
Also please try putting a big file on disk (something like dd
if=/dev/zero of=bigfile
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Finding snapshot by a name which could also be an id isn't best way
how to do it. There will be rewrite of savevm, loadvm and delvm to
improve the behavior of these commands. The savevm and loadvm will
have their own patch series.
Now
Ping for review -- I plan to put these into a target-arm
pullreq at the end of the week if nobody has any review
comments.
thanks
-- PMM
On 8 April 2013 15:43, Peter Maydell peter.mayd...@linaro.org wrote:
This patch series converts target-arm to doing migration via
a VMState structure, and
Eric Blake ebl...@redhat.com writes:
On 04/16/2013 09:56 AM, Eric Blake wrote:
On 04/16/2013 08:45 AM, Anthony Liguori wrote:
This test compares all of the default register values against the
spec. It turns out we deviate in quite a few places. These
places are really only visible to the
Stefan Berger stef...@linux.vnet.ibm.com writes:
Simplify the creation of the cancel path given the TPM's device path.
Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
No longer applies. Had you sent with
On Tue, 16 Apr 2013 13:12:03 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Break lines on kvm_check_features_against_host(), kvm_cpu_fill_host(),
and builtin_x86_defs, so they don't get too long once the *_features
fields are replaced by an array.
Signed-off-by: Eduardo Habkost
I know there are a few different trees out there. Not sure if anyone is
currently working on rebasing the earlier patch series. I had thought
we were aiming for 1.5 but we're getting pretty late for that.
Regards,
Anthony Liguori
On Tue, 16 Apr 2013 13:12:04 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all feature words (e.g.
On Tue, 16 Apr 2013 13:12:00 -0300
Eduardo Habkost ehabk...@redhat.com wrote:
Changes v9:
* Merge patches 1,3 from v8 into a single patch (1/4)
* Merge pathces 4-6 from v8 into a single patch (3/4)
* 1-char alignment change on patch 2/4
* Improved description text of patch 4/4
Except
Trivial 4-space indentation fix.
Signed-off-by: Eduardo Habkost ehabk...@redhat.com
---
Sending this so Andreas doesn't have to fix the indentation himself
before applying.
bsd-user/elfload.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/bsd-user/elfload.c
This replaces the feature-bit fields on both X86CPU and x86_def_t
structs with an array.
With this, we will be able to simplify code that simply does the same
operation on all feature words (e.g. kvm_check_features_against_host(),
filter_features_for_kvm(), add_flagname_to_bitmaps(), CPU
Hi Stefano,
When trying to start a hvm quest with xen-unstable and qemu-upstream, it ends
up stuck:
xc: info: VIRTUAL MEMORY ARRANGEMENT:
Loader:0010-0019c864
Modules: -
TOTAL: -2f80
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
QMP command vm-snapshot-delete no takes two parameters name and id. They are
s/no//
s/parameters/parameters:/
optional, but one of the name or id must be provided. If both are provided
they
will match only the snapshot with the same name and id.
Can you clarify what's not 100% reproducible? The only time that it is
not reproducible on my system is between different qemu machine types as
I listed. If tests are performed on same machine-type they are
reproducible 100% of the time on the same host and vm guest as shown in
comment #23.
I
On Mon, 15 Apr 2013 16:20:15 -0600
Eric Blake ebl...@redhat.com wrote:
On 04/15/2013 04:12 PM, Igor Mammedov wrote:
... via current_machine-cpu_hot_add() hook called by cpu-set QMP command,
for x86 target.
cpu-add's id argument is a CPU thread number in a range [0..max-cpus - 1)
Off
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/04/2013 15:41, guang li ha scritto:
Yes, you're right.
The motivation is I want to implement a device
called EC which is a notion from laptop for QEMU,
EC has some main functions, like keyboard, mouse,
low-speed device control(I2C), special
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 55
++-
block/qcow2-snapshot.c| 32 +++
block/qcow2.h | 8 +--
block/rbd.c
Sorry Stefan; I had an error with stg and did not CC you.
Just tell me if you want me to re-send with proper headers.
Lluis
--
And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer.
-- The Princess of Pure Reason, as
Please ignore this (incomplete) thread. Sorry for the inconvenience.
Lluis
--
And it's much the same thing with knowledge, for whenever you learn
something new, the whole world becomes that much richer.
-- The Princess of Pure Reason, as told by Norton Juster in The Phantom
Tollbooth
On Tue, 2013-04-16 at 13:45 -0500, Anthony Liguori wrote:
I know there are a few different trees out there. Not sure if anyone is
currently working on rebasing the earlier patch series. I had thought
we were aiming for 1.5 but we're getting pretty late for that.
Hi Anthony,
The branch
Simplify the creation of the cancel path given the TPM's device path.
Given the path /dev/tpm0 build the path /sys/class/misc/tpm0/device/cancel.
Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com
Reviewed-by: Eric Blake ebl...@redhat.com
---
v1-v2:
- followed changes in tree
---
Paolo Bonzini pbonz...@redhat.com writes:
This uses system calls directly for Unix file descriptors, so that the
efficient writev_buffer can be used. Pay attention to the possibility
of partial writes in writev.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
Needs rebasing:
CC
Nicholas A. Bellinger n...@linux-iscsi.org writes:
On Tue, 2013-04-16 at 13:45 -0500, Anthony Liguori wrote:
I know there are a few different trees out there. Not sure if anyone is
currently working on rebasing the earlier patch series. I had thought
we were aiming for 1.5 but we're getting
On 04/12/2013 05:59 PM, Stefan Berger wrote:
Move the TPM passthrough specific command line options to the passthrough
backend implementation and attach them to the backend's interface structure.
Add code to tpm.c for validating the TPM command line options.
Signed-off-by: Stefan Berger
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
include/sysemu/sysemu.h | 2 +-
migration.c | 9 +++
savevm.c| 64
-
3 files changed, 37 insertions(+), 38
Management apps like libvirt don't know to pay attention to
stderr unless there is a non-zero exit status.
* migration.c (process_incoming_migration_co): Exit with non-zero
status on failure.
Signed-off-by: Eric Blake ebl...@redhat.com
---
Noticed while reviewing:
Eric Blake ebl...@redhat.com writes:
Management apps like libvirt don't know to pay attention to
stderr unless there is a non-zero exit status.
* migration.c (process_incoming_migration_co): Exit with non-zero
status on failure.
Signed-off-by: Eric Blake ebl...@redhat.com
It looks like
On 04/13/2013 02:56 AM, Wenchao Xia wrote:
This patch introduce a new print function, which will output message to
monitor when it present. With it, bdrv_snapshot_dump() need no more buffer
and can avoid string truncation, bdrv_image_info_dump() can also be used by
hmp code later, besides
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
QMP command vm-snapshot-load and HMP command loadvm behave similar to
vm-snapshot-delete and delvm. The only different is that they will load
the snapshot instead of deleting it.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
hmp-commands.hx
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
block.c | 23 ++-
block/qcow2-snapshot.c| 18 --
block/qcow2.h | 4 +++-
block/rbd.c | 20 +++-
Hi All,
We have taken qemu-kvm version 1.2 for developing a patch that would do
cloning of a VM using pre-copy based live VM migration in qemu-kvm code.
After the migration is completed, we could see the cloned_Vm is up and
running, also handled network configuration (assigning new mac and Ip
On 04/16/2013 10:05 AM, Pavel Hrdina wrote:
I think you meant s/off/of/ in the subject.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
include/sysemu/sysemu.h | 7 ---
migration.c | 6 +++---
savevm.c| 38 +++---
3
在 2013-04-16二的 15:45 -0500,Anthony Liguori写道:
Paolo Bonzini pbonz...@redhat.com writes:
Il 10/04/2013 15:41, guang li ha scritto:
Yes, you're right.
The motivation is I want to implement a device
called EC which is a notion from laptop for QEMU,
EC has some main functions, like
On 04/16/2013 03:25:50 AM, Peter Maydell wrote:
On 16 April 2013 00:19, Scott Wood scottw...@freescale.com wrote:
This is useful for when a user of the memory region API needs to
communicate the absolute bus address to something outside QEMU
(in particular, KVM).
Signed-off-by: Scott Wood
The rbd cli tool now sends progress info to stderr; send that to the bit
bucket too.
Signed-off-by: Sage Weil s...@inktank.com
---
tests/qemu-iotests/common.rc |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index
On 04/13/2013 02:56 AM, Wenchao Xia wrote:
To make it clear about id and name in searching, the API is changed
a bit to distinguish them, and caller can choose to search by id or name.
Searching will be done with higher priority of id. This function also
returns negative value from
于 2013-4-11 1:33, Pavel Hrdina 写道:
On 10.4.2013 19:15, Eric Blake wrote:
On 04/10/2013 08:05 AM, Pavel Hrdina wrote:
Here is another proposal how to handle vm snapshots:
QMP vm-snapshot-save:
- { 'command': 'vm-snapshot-save',
'data': { 'name': 'str' },
'returns':
Hi, Pavel
I have implemented it at
http://lists.nongnu.org/archive/html/qemu-devel/2013-04/msg02533.html
in patch 1,2. Could u check if it satisfy your requirement, if yes maybe
you can directly use them.
Signed-off-by: Pavel Hrdina phrd...@redhat.com
---
savevm.c | 33
On 04/16/2013 12:49 AM, Paolo Bonzini wrote:
+#define RDMA_CHUNK_REGISTRATION
+#define RDMA_LAZY_CLIENT_REGISTRATION
Please drop these; no dead code.
These are important sender-side-only debugging flags.
I'll add an explicit debug-only comment.
+/* Do not merge data if larger than this. */
于 2013-4-16 21:52, Kevin Wolf 写道:
Am 13.04.2013 um 13:11 hat Wenchao Xia geschrieben:
Now qmp_transaction() can be extended with other operation,
external snapshot or backing chain creation, is just one case it.
Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com
---
blockdev.c | 68
From: Michael R. Hines mrhi...@us.ibm.com
The following changes since commit e0a83fc2c1582dc8d4453849852ebe6c258b7c3a:
qom: do nothing on unparent of object without parent (2013-04-16 16:10:21
-0500)
are available in the git repository at:
g...@github.com:hinesmr/qemu.git rdma_patch_v3
From: Michael R. Hines mrhi...@us.ibm.com
This takes advantages of the previous patches:
1. use the new QEMUFileOps hook 'save_page'
2. call out to the right accessor methods to invoke
the iteration hooks defined in QEMUFileOps
3. Expose a common way to zap zero pages
Signed-off-by:
From: Michael R. Hines mrhi...@us.ibm.com
This is used during RDMA initialization in order to
transmit a description of all the RAM blocks to the
peer for later dynamic chunk registration purposes.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
exec.c|9 +
From: Michael R. Hines mrhi...@us.ibm.com
These are the prototypes and implementation of new hooks that
RDMA takes advantage of to perform dynamic page registration.
An optional hook is also introduced for a custom function
to be able to override the default save_page function.
Also included
From: Michael R. Hines mrhi...@us.ibm.com
docs/rdma.txt contains full documentation,
wiki links, github url and contact information.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
docs/rdma.txt | 357 +
1 file changed, 357
From: Michael R. Hines mrhi...@us.ibm.com
This capability allows you to disable dynamic chunk registration
for better throughput on high-performance links.
It is enabled by default.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
migration.c | 10 ++
qapi-schema.json |
From: Michael R. Hines mrhi...@us.ibm.com
It's very helpful when debugging to print out migration throughput
after each iteration round to compare the different migration
technologies.
Signed-off-by: Michael R. Hines mrhi...@us.ibm.com
---
migration.c |8 ++--
1 file changed, 6
于 2013-4-17 7:42, Eric Blake 写道:
On 04/13/2013 02:56 AM, Wenchao Xia wrote:
This patch introduce a new print function, which will output message to
monitor when it present. With it, bdrv_snapshot_dump() need no more buffer
and can avoid string truncation, bdrv_image_info_dump() can also be
201 - 272 of 272 matches
Mail list logo