Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-10 Thread liu ping fan
On Thu, May 9, 2013 at 11:26 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, May 09, 2013 at 05:00:20PM +0800, liu ping fan wrote: On Thu, May 9, 2013 at 4:30 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, May 09, 2013 at 08:40:21AM +0800, Liu Ping Fan wrote: From: Liu Ping Fan

[Qemu-devel] kvm process disappears

2013-05-10 Thread Stefan Priebe - Profihost AG
Hello list, i've now seen this several times. A VM is suddently down no segfault nothing the kvm process just disappears... Anybody any idea how to debug this? Sadly i can't reproduce. Qemu version is 1.4.1. Greets Stefan

Re: [Qemu-devel] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION

2013-05-10 Thread Gabriel de Perthuis
Le 10/05/2013 05:30, Aneesh Kumar K.V a écrit : Gabriel de Perthuis g2p.c...@gmail.com writes: The current implementation checked for supported filesystems at mount time, but actual support depends on the path. Don't error out when finding unversioned paths. Can you elaborate this a bit

[Qemu-devel] [PATCH v3 2/3] ARM: Allow dumping of device tree

2013-05-10 Thread John Rigby
By calling qemu_devtree_dumpdtb near the end of load_dtb. Signed-off-by: John Rigby john.ri...@linaro.org --- changes in v3: - split patch hw/arm/boot.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 64b56ac..de71edf 100644 --- a/hw/arm/boot.c +++

[Qemu-devel] [PATCH v3 3/3] ARM: Add mach-virt platform

2013-05-10 Thread John Rigby
Add mach-virt platform support corresponding to /arch/arm/mach-virt in kernel tree. For now it is not virtual but instantiates a pl011 uart and an sp804 timer. The uart is need for a console the timer is needed when running without kvm and there is no arch timer. Signed-off-by: John Rigby

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-10 Thread Stefan Hajnoczi
On Fri, May 10, 2013 at 02:03:34PM +0800, liu ping fan wrote: On Thu, May 9, 2013 at 11:26 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, May 09, 2013 at 05:00:20PM +0800, liu ping fan wrote: On Thu, May 9, 2013 at 4:30 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Thu, May 09,

Re: [Qemu-devel] [pve-devel] kvm process disappears

2013-05-10 Thread Alexandre DERUMIER
I never seen this, sorry ... - Mail original - De: Stefan Priebe - Profihost AG s.pri...@profihost.ag À: pve-de...@pve.proxmox.com, qemu-devel qemu-devel@nongnu.org Envoyé: Vendredi 10 Mai 2013 08:12:39 Objet: [pve-devel] kvm process disappears Hello list, i've now seen this several

Re: [Qemu-devel] [pve-devel] kvm process disappears

2013-05-10 Thread Alexandre DERUMIER
Just an idea, maybe are you out of memory and process are killed ? nothing in logs ? - Mail original - De: Stefan Priebe - Profihost AG s.pri...@profihost.ag À: pve-de...@pve.proxmox.com, qemu-devel qemu-devel@nongnu.org Envoyé: Vendredi 10 Mai 2013 08:12:39 Objet: [pve-devel] kvm

[Qemu-devel] [PATCH v3 1/3] ARM: Allow boards to provide an fdt blob

2013-05-10 Thread John Rigby
If no fdt is provided on command line and the new field get_dtb in struct arm_boot_info is set then call it to get a device tree blob. Signed-off-by: John Rigby john.ri...@linaro.org --- changes in v3: - split patch hw/arm/boot.c| 30 +++--- include/hw/arm/arm.h

Re: [Qemu-devel] [pve-devel] kvm process disappears

2013-05-10 Thread Stefan Priebe - Profihost AG
Am 10.05.2013 09:20, schrieb Alexandre DERUMIER: Just an idea, maybe are you out of memory and process are killed ? nothing in logs ? 140GB free mem also nothing in dmesg... which logs did you mean? Stefan - Mail original - De: Stefan Priebe - Profihost AG

[Qemu-devel] [PATCH v3 0/2] Add mach-virt platform

2013-05-10 Thread John Rigby
Modify arm fdt handling so boards can provide a blob rather than requiring one on command line. Allow dumping of fdt blob as ppc e500 already does. Next add mach-virt platform that creates fdt blob from scratch describing its minimal hw which is a pl011 uart and a sp804 timer. Tested on amd64

Re: [Qemu-devel] [pve-devel] kvm process disappears

2013-05-10 Thread Alexandre DERUMIER
140GB free mem also nothing in dmesg... which logs did you mean?  I thinked of /var/log/messages, logs with OOM Killer. But seem to not be your case ;) Do you use HA ? - Mail original - De: Stefan Priebe - Profihost AG s.pri...@profihost.ag À: Alexandre DERUMIER aderum...@odiso.com

Re: [Qemu-devel] [Patch] Support for bridged networking on Mac OS X

2013-05-10 Thread Stefan Hajnoczi
On Thu, May 09, 2013 at 07:44:30PM +0100, Alasdair McLeay wrote: tun tap can be implemented on Mac OS X using http://tuntaposx.sourceforge.net It behaves in the same way as FreeBSD/OpenBSD implementations, but Qemu needs a patch to use the OpenBS/FreeBSD code. As per the patch listed in

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Paolo Bonzini
Il 09/05/2013 21:43, Chegu Vinod ha scritto: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help

Re: [Qemu-devel] kvm process disappears

2013-05-10 Thread Stefan Hajnoczi
On Fri, May 10, 2013 at 08:12:39AM +0200, Stefan Priebe - Profihost AG wrote: i've now seen this several times. A VM is suddently down no segfault nothing the kvm process just disappears... Anybody any idea how to debug this? Sadly i can't reproduce. Qemu version is 1.4.1. 1. Double-check

Re: [Qemu-devel] [RFC PATCH v5 2/3] Add 'auto-converge' migration capability

2013-05-10 Thread Paolo Bonzini
Il 09/05/2013 21:43, Chegu Vinod ha scritto: The auto-converge migration capability allows the user to specify if they choose live migration seqeunce to automatically detect and force convergence. Signed-off-by: Chegu Vinod chegu_vi...@hp.com --- include/migration/migration.h |2 ++

Re: [Qemu-devel] [RFC PATCH v5 1/3] Introduce async_run_on_cpu()

2013-05-10 Thread Paolo Bonzini
Il 09/05/2013 21:43, Chegu Vinod ha scritto: Introduce an asynchronous version of run_on_cpu() i.e. the caller doesn't have to block till the call back routine finishes execution on the target vcpu. Signed-off-by: Chegu Vinod chegu_vi...@hp.com --- cpus.c| 29

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 01:00, Chegu Vinod ha scritto: On 5/9/2013 1:24 PM, Igor Mammedov wrote: On Thu, 9 May 2013 12:43:20 -0700 Chegu Vinod chegu_vi...@hp.com wrote: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle

Re: [Qemu-devel] [PATCH v6 00/11] rdma: migration support

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 00:20, Chegu Vinod ha scritto: Wow, I didn't know that either. Perhaps this must be causing the entire QEMU process and its threads to seize up. It may be necessary to run the pinning command *outside* of QEMU's I/O lock in a separate thread if it's really that much overhead.

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] remove needless semicolon

2013-05-10 Thread Andreas Färber
Am 09.05.2013 08:23, schrieb Michael Tokarev: 08.05.2013 17:25, Anthony Liguori wrote: Michael Tokarev m...@tls.msk.ru writes: 08.05.2013 13:46, Trival wrote: Signed-off-by: Trival triv...@linux.vnet.ibm.com Something went wrong in sending this. This is not a valid SoB. So, do we not

Re: [Qemu-devel] [ANNOUNCE] QEMU 1.5.0-rc1 is now available

2013-05-10 Thread Christophe Lyon
Hi, Would it be possible to include the small patch at: https://lists.gnu.org/archive/html/qemu-devel/2013-05/msg00530.html Thanks Christophe. On 09.05.2013 00:29, Anthony Liguori wrote: Hi, On behalf of the QEMU Team, I'd like to announce the availability of the second release candidate

Re: [Qemu-devel] [PATCH 1/2] Vring: vring's listener's priority should higher than kvm

2013-05-10 Thread liu ping fan
On Fri, May 10, 2013 at 3:12 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Fri, May 10, 2013 at 02:03:34PM +0800, liu ping fan wrote: On Thu, May 9, 2013 at 11:26 PM, Stefan Hajnoczi stefa...@redhat.com wrote: On Thu, May 09, 2013 at 05:00:20PM +0800, liu ping fan wrote: On Thu, May 9,

Re: [Qemu-devel] [pve-devel] kvm process disappears

2013-05-10 Thread Stefan Priebe - Profihost AG
Am 10.05.2013 09:28, schrieb Alexandre DERUMIER: 140GB free mem also nothing in dmesg... which logs did you mean? I thinked of /var/log/messages, logs with OOM Killer. But seem to not be your case ;) Nothing... Do you use HA ? No Stefan

Re: [Qemu-devel] kvm process disappears

2013-05-10 Thread Stefan Priebe - Profihost AG
Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 08:12:39AM +0200, Stefan Priebe - Profihost AG wrote: i've now seen this several times. A VM is suddently down no segfault nothing the kvm process just disappears... Anybody any idea how to debug this? Sadly i can't

Re: [Qemu-devel] [PATCH] 9p: Be robust against paths without FS_IOC_GETVERSION

2013-05-10 Thread Aneesh Kumar K.V
Gabriel de Perthuis g2p.c...@gmail.com writes: Le 10/05/2013 05:30, Aneesh Kumar K.V a écrit : Gabriel de Perthuis g2p.c...@gmail.com writes: The current implementation checked for supported filesystems at mount time, but actual support depends on the path. Don't error out when finding

Re: [Qemu-devel] kvm process disappears

2013-05-10 Thread Stefan Hajnoczi
On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 08:12:39AM +0200, Stefan Priebe - Profihost AG wrote: 3. Either use gdb or an LD_PRELOAD library that catches exit(3) and

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 11:04:22AM +0800, Amos Kong wrote: On Thu, May 09, 2013 at 09:20:53PM -0500, Michael Roth wrote: Teach type generators about native types so they can generate the appropriate linked list types. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com ---

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread Laszlo Ersek
On 05/10/13 04:20, Michael Roth wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is still valid JSON) Fix this by detecting

[Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Paolo Bonzini
Cast debugging can have a substantial cost (20% or more, measured by Aurelien on qemu-system-ppc64). Instead of adding special-cased fast casts in the hot paths, we can just disable it in releases. At the same time, add tracing facilities that simplify the analysys of those problems that cast

[Qemu-devel] [PATCH for-1.5 1/9] qom: improve documentation of cast functions

2013-05-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index d0f99c5..41b7068 100644 --- a/include/qom/object.h +++ b/include/qom/object.h @@

[Qemu-devel] [PATCH for-1.5 2/9] qom: allow casting of a NULL class

2013-05-10 Thread Paolo Bonzini
This mimics what we do in object_dynamic_cast_assert. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 75e6aac..35f4694 100644 --- a/qom/object.c +++ b/qom/object.c

[Qemu-devel] [PATCH for-1.5 3/9] qom: add a fast path to object_class_dynamic_cast

2013-05-10 Thread Paolo Bonzini
For leaf classes, in many cases the callbacks will simply downcast the object back to the original class. Add this fast path to object_class_dynamic_cast, object_dynamic_cast will inherit it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 5 + 1 file changed, 5

[Qemu-devel] [PATCH for-1.5 4/9] qom: pass file/line/function to asserting casts

2013-05-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qom/object.h | 16 +++- qom/object.c | 15 +-- 2 files changed, 20 insertions(+), 11 deletions(-) diff --git a/include/qom/object.h b/include/qom/object.h index 41b7068..38f674f 100644 ---

[Qemu-devel] [PATCH for-1.5 6/9] qom: allow turning cast debugging off

2013-05-10 Thread Paolo Bonzini
Cast debugging can have a substantial cost (20% or more). Instead of adding special-cased fast casts in the hot paths, we can just disable it in releases. The tracing facilities we just added make it easier to analyze those problems that cast debugging would reveal. Signed-off-by: Paolo Bonzini

[Qemu-devel] [PATCH for-1.5 9/9] qom: simplify object_class_dynamic_cast, part 2

2013-05-10 Thread Paolo Bonzini
Detect ambiguous matches right away, without going through all interfaces first. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/qom/object.c b/qom/object.c index f82f12c..c69e6a3 100644

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread Eric Blake
On 05/09/2013 08:20 PM, Michael Roth wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is still valid JSON) Fix this by

[Qemu-devel] [PATCH 0/3] dataplane: change vring API to use VirtQueueElement

2013-05-10 Thread Paolo Bonzini
Hi Stefan, these three patches are a small step towards a good version of the RFC I posted on Monday. I can carry the final switch from hostmem to memory_region_find in my tree, but these should probably go through the block tree. Thanks, Paolo Paolo Bonzini (2): vring: create a common

[Qemu-devel] [PATCH 1/2] vring: create a common function to parse descriptors

2013-05-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/dataplane/vring.c | 113 1 file changed, 51 insertions(+), 62 deletions(-) diff --git a/hw/virtio/dataplane/vring.c b/hw/virtio/dataplane/vring.c index e0d6e83..bd1ff25 100644 ---

[Qemu-devel] [PATCH 2/2] dataplane: change vring API to use VirtQueueElement

2013-05-10 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/dataplane/virtio-blk.c | 83 ++--- hw/virtio/dataplane/vring.c | 46 +++- include/hw/virtio/dataplane/vring.h | 6 +-- 3 files changed, 59 insertions(+), 76 deletions(-)

[Qemu-devel] [PATCH for-1.5 8/9] qom: simplify object_class_dynamic_cast, part 1

2013-05-10 Thread Paolo Bonzini
Access everything from the class. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qom/object.c b/qom/object.c index f5f416b..f82f12c 100644 --- a/qom/object.c +++ b/qom/object.c @@ -457,15 +457,13 @@

[Qemu-devel] [PATCH for-1.5 5/9] qom: trace asserting casts

2013-05-10 Thread Paolo Bonzini
This provides a way to detect the cast that leads to a (reproducible) crash even when QOM cast debugging is disabled. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qom/object.c | 10 +- trace-events | 3 +++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH for-1.5] Revert pc: Kill the use flash device for BIOS unless KVM misfeature

2013-05-10 Thread Paolo Bonzini
This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entirely correct, there are 1.6 patches that fix the bug for real and without requiring machine type hacks. Let's think of the children who will have to read this code, and avoid a complicated mess of

Re: [Qemu-devel] [PATCH 0/2] pci-assign: MSI affinity support

2013-05-10 Thread Jan Kiszka
On 2013-05-09 18:35, Alex Williamson wrote: I posted these about 6 months ago and Jan felt we should implement MSI notifiers like we have for MSI-X. That still hasn't happened. Device assignments are the only currently known users - and you provide this feature, so... POWER does this nice

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread Laszlo Ersek
On 05/10/13 14:22, Eric Blake wrote: On 05/09/2013 08:20 PM, Michael Roth wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is

[Qemu-devel] [PATCH for-1.5 7/9] build: disable QOM cast debugging for official releases

2013-05-10 Thread Paolo Bonzini
QOM cast debugging is useful, but it can have a substantial cost. We will add a configure option to toggle it, in the meanwhile let's keep it disabled in official releases (including -rc). Replace the old CONFIG_ZERO_MALLOC that had the same rules but has been unused since we switched to

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Cast debugging can have a substantial cost (20% or more, measured by Aurelien on qemu-system-ppc64). [Needs citation] Instead of adding special-cased fast casts in the hot paths, we can just disable it in releases. At the same time, add tracing

Re: [Qemu-devel] [Qemu-trivial] [PATCH 2/2] remove needless semicolon

2013-05-10 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: Am 09.05.2013 08:23, schrieb Michael Tokarev: 08.05.2013 17:25, Anthony Liguori wrote: Michael Tokarev m...@tls.msk.ru writes: 08.05.2013 13:46, Trival wrote: Signed-off-by: Trival triv...@linux.vnet.ibm.com Something went wrong in sending this.

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Anthony Liguori
Chegu Vinod chegu_vi...@hp.com writes: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and let the migration thread catchup and help

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 15:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Cast debugging can have a substantial cost (20% or more, measured by Aurelien on qemu-system-ppc64). [Needs citation] Sure: http://permalink.gmane.org/gmane.comp.emulators.qemu/210830 49,73%

Re: [Qemu-devel] [PATCH 20/40] pci: use memory core for iommu support

2013-05-10 Thread Alexey Kardashevskiy
On 05/08/2013 12:16 AM, Paolo Bonzini wrote: From: Avi Kivity avi.kiv...@gmail.com Use the new iommu support in the memory core for iommu support. The only user, spapr, is also converted, but it still provides a DMAContext interface until the non-PCI bits switch to AddressSpace. Cc:

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Andreas Färber
Am 10.05.2013 15:08, schrieb Paolo Bonzini: Il 10/05/2013 15:01, Anthony Liguori ha scritto: I'd prefer not to disable but instead focus on improving performance. For 1.5? This is a regression in 1.5 due to more and more usage of foo_env_on_cpu. If CPUs were the only reason, we could

Re: [Qemu-devel] [PATCH v2 0/2] qga umask fix addenda

2013-05-10 Thread Luiz Capitulino
On Wed, 8 May 2013 17:31:34 +0200 Laszlo Ersek ler...@redhat.com wrote: I should have paid more attention to portability and error path cleanup in the CVE-2013-2007 fix. (We continue to assume, like the rest of qemu code, that qemu_set_cloexec() never fails internally. This should be a

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 15:23, Andreas Färber ha scritto: Am 10.05.2013 15:08, schrieb Paolo Bonzini: Il 10/05/2013 15:01, Anthony Liguori ha scritto: I'd prefer not to disable but instead focus on improving performance. For 1.5? This is a regression in 1.5 due to more and more usage of

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 02:47:18PM +0200, Laszlo Ersek wrote: On 05/10/13 14:22, Eric Blake wrote: On 05/09/2013 08:20 PM, Michael Roth wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the

Re: [Qemu-devel] [PATCH 20/40] pci: use memory core for iommu support

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 15:07, Alexey Kardashevskiy ha scritto: @@ -2234,10 +2239,12 @@ static void pci_device_class_init(ObjectClass *klass, void *data) k-props = pci_props; } -void pci_setup_iommu(PCIBus *bus, PCIDMAContextFunc fn, void *opaque) +void pci_setup_iommu(PCIBus *bus,

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 21:20:53 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Teach type generators about native types so they can generate the appropriate linked list types. Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- scripts/qapi-types.py | 43

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread Eric Blake
On 05/10/2013 06:47 AM, Laszlo Ersek wrote: The pre-patch code for JSON_INTEGER: obj = QOBJECT(qint_from_int(strtoll(token_get_value(token), NULL, 10))); doesn't check for errors at all. (I assume that JSON_INTEGER is selected by the parser, token_get_type(), based on syntax purely.) I

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Chegu Vinod
On 5/10/2013 6:07 AM, Anthony Liguori wrote: Chegu Vinod chegu_vi...@hp.com writes: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest for some duration and

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Daniel P. Berrange
On Fri, May 10, 2013 at 08:07:51AM -0500, Anthony Liguori wrote: Chegu Vinod chegu_vi...@hp.com writes: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs out of the guest

Re: [Qemu-devel] Profiling sparc64 emulation

2013-05-10 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 09/05/2013 20:30, Aurelien Jarno ha scritto: 13,16% libglib-2.0.so.0.3200.4 [.] g_hash_table_lookup 8,18% libglib-2.0.so.0.3200.4 [.] g_str_hash 2,47% qemu-system-ppc64[.] object_class_dynamic_cast 1,97% qemu-system-ppc64

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Aurelien Jarno
On Fri, May 10, 2013 at 03:30:17PM +0200, Paolo Bonzini wrote: Il 10/05/2013 15:23, Andreas Färber ha scritto: Am 10.05.2013 15:08, schrieb Paolo Bonzini: Il 10/05/2013 15:01, Anthony Liguori ha scritto: I'd prefer not to disable but instead focus on improving performance. For 1.5?

Re: [Qemu-devel] [PATCH 04/10] qapi: enable generation of native list code

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 21:20:56 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs qapi-types.c/qapi-visit.c Signed-off-by: Michael Roth mdr...@linux.vnet.ibm.com --- Makefile |6 +++--- 1 file changed, 3

Re: [Qemu-devel] [RFC PATCH v5 2/3] Add 'auto-converge' migration capability

2013-05-10 Thread Eric Blake
On 05/10/2013 01:43 AM, Paolo Bonzini wrote: +++ b/qapi-schema.json @@ -602,10 +602,13 @@ # This feature allows us to minimize migration traffic for certain work # loads, by sending compressed difference of the pages # +# @auto-converge: Migration supports automatic

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 10/05/2013 15:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Cast debugging can have a substantial cost (20% or more, measured by Aurelien on qemu-system-ppc64). [Needs citation] Sure:

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 10/05/2013 15:23, Andreas Färber ha scritto: Am 10.05.2013 15:08, schrieb Paolo Bonzini: Il 10/05/2013 15:01, Anthony Liguori ha scritto: I'd prefer not to disable but instead focus on improving performance. For 1.5? This is a regression in 1.5

[Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Andreas Färber
A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance. Reported-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by: Andreas Färber afaer...@suse.de ---

Re: [Qemu-devel] [PATCH for-1.5] Revert pc: Kill the use flash device for BIOS unless KVM misfeature

2013-05-10 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec. While Markus's analysis is entirely correct, there are 1.6 patches that fix the bug for real and without requiring machine type hacks. Let's think of the children who will have to read this

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Peter Maydell
On 10 May 2013 15:39, Andreas Färber afaer...@suse.de wrote: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance. static inline PowerPCCPU

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Aurelien Jarno
On Fri, May 10, 2013 at 09:27:28AM -0500, Anthony Liguori wrote: Paolo Bonzini pbonz...@redhat.com writes: Il 10/05/2013 15:01, Anthony Liguori ha scritto: Paolo Bonzini pbonz...@redhat.com writes: Cast debugging can have a substantial cost (20% or more, measured by Aurelien on

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Andreas Färber
Am 10.05.2013 16:42, schrieb Peter Maydell: On 10 May 2013 15:39, Andreas Färber afaer...@suse.de wrote: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance.

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 08:08:05AM -0600, Eric Blake wrote: On 05/10/2013 06:47 AM, Laszlo Ersek wrote: The pre-patch code for JSON_INTEGER: obj = QOBJECT(qint_from_int(strtoll(token_get_value(token), NULL, 10))); doesn't check for errors at all. (I assume that JSON_INTEGER is

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 16:39, Anthony Liguori ha scritto: I just oppose the notion of disabling casts and *especially* only disabling casts for official builds. This actually happens all the time. Exactly this kind of type-safe cast is disabled in releases of GCC, but enabled when building from svn

[Qemu-devel] [PATCH] ui/gtk.c: do not use gdk_display_warp_pointer when GTK ver 3.0

2013-05-10 Thread Igor Mitsyanko
Commit 9697f5d2d38e5dd1e64e8e0d64436e6d44e7b1fe gtk: custom cursor support introduced unconditional usage of gdk_display_warp_pointer(). This function is marked as deprecated since GTK-3.0, and triggers warning (error with -Werror) during compilation. Conditionally change

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 10 May 2013 15:39, Andreas Färber afaer...@suse.de wrote: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance.

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Andreas Färber
Am 10.05.2013 16:46, schrieb Aurelien Jarno: We have changed a pointer access in a hot path (and more are likely to come as far as I know) to a complex function. The correct way to fix that is to remove the complex function. FWIW I had started to investigate whether I can tweak TCG to use

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Anthony Liguori
Andreas Färber afaer...@suse.de writes: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance. Reported-by: Anthony Liguori aligu...@us.ibm.com Signed-off-by:

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 16:47, Andreas Färber ha scritto: Am 10.05.2013 16:42, schrieb Peter Maydell: On 10 May 2013 15:39, Andreas Färber afaer...@suse.de wrote: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Anthony Liguori
Daniel P. Berrange berra...@redhat.com writes: On Fri, May 10, 2013 at 08:07:51AM -0500, Anthony Liguori wrote: Chegu Vinod chegu_vi...@hp.com writes: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Paolo Bonzini
Il 10/05/2013 17:06, Anthony Liguori ha scritto: Andreas Färber afaer...@suse.de writes: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance. Reported-by: Anthony

Re: [Qemu-devel] [RFC PATCH v5 3/3] Force auto-convegence of live migration

2013-05-10 Thread Anthony Liguori
Chegu Vinod chegu_vi...@hp.com writes: On 5/10/2013 6:07 AM, Anthony Liguori wrote: Chegu Vinod chegu_vi...@hp.com writes: If a user chooses to turn on the auto-converge migration capability these changes detect the lack of convergence and throttle down the guest. i.e. force the VCPUs

Re: [Qemu-devel] CPU scheduling with TCG in SMP system emulation mode

2013-05-10 Thread Sebastian Huber
On 02/22/2013 01:46 AM, Max Filippov wrote: Hello. Do I understand it right that there's no dedicated mechanism other than icount that would switch current CPU in emulated SMP system and that in the absence of icount such scheduling is a side effect of interrupt delivery to the current CPU?

Re: [Qemu-devel] [PATCH 05/10] qapi: fix leak in unit tests

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 21:20:57 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: qmp_output_get_qobject() increments the qobject's reference count. Since we currently pass this straight into qobject_to_json() so we can feed the data into a QMP input visitor, we never actually free the

[Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Igor Mitsyanko
This fixes build for mingw32 Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com --- include/qemu/osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index 42545bc..17946a3 100644 --- a/include/qemu/osdep.h +++ b/include/qemu/osdep.h @@

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 21:20:58 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in the case where the number overflows/underflows int64 values (which is

Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Peter Maydell
On 10 May 2013 16:16, Igor Mitsyanko i.mitsya...@gmail.com wrote: This fixes build for mingw32 Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com --- include/qemu/osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/osdep.h b/include/qemu/osdep.h index

Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types

2013-05-10 Thread Luiz Capitulino
On Thu, 9 May 2013 21:20:52 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qapi-native-lists Sending this now since a number of series have popped up in the past that wanted

[Qemu-devel] [PATCH V2 1/2] hw/arm/exynos4210.c: convert chipid_and_omr to an mmio region

2013-05-10 Thread Igor Mitsyanko
From: Igor Mitsyanko i.mitsya...@samsung.com Exynos SoC was misusing memory_region_init_ram_ptr(): this interface can safely be used only for memory regions which size is a multiple of target page size. Change chipid_and_omr memory to an mmio region to fix this. Signed-off-by: Igor Mitsyanko

[Qemu-devel] [PATCH V2 2/2] exynos4210.c: register rom_mem for memory migration

2013-05-10 Thread Igor Mitsyanko
From: Igor Mitsyanko i.mitsya...@samsung.com Even if we do not register newly created RAM MemoryRegion for migration with vmstate_register_ram_global() function, ram_save_setup() still saves this region to snapshot file with empty idstr==. Consequently this results in error during VM loading in

[Qemu-devel] [PATCH V2 0/2] Fix memory migration for exynos 4210 SoC

2013-05-10 Thread Igor Mitsyanko
Fix issues in exynos4210 code which were blocking proper memory migration. V1-V2 PATCH1 now doesn't use memory_region_init_ram_ptr at all. Instead, it converts chipid memory to an mmio region. PATCH3 is dropped until hard freeze is over. It better be sent separately anyway. Igor Mitsyanko (2):

Re: [Qemu-devel] [PATCH] osdep.h: include sys/types.h for ssize_t definition

2013-05-10 Thread Igor Mitsyanko
On 05/10/2013 07:24 PM, Peter Maydell wrote: On 10 May 2013 16:16, Igor Mitsyanko i.mitsya...@gmail.com wrote: This fixes build for mingw32 Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com --- include/qemu/osdep.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/qemu/osdep.h

Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types

2013-05-10 Thread Luiz Capitulino
On Fri, 10 May 2013 17:40:20 +0200 Laszlo Ersek ler...@redhat.com wrote: On 05/10/13 17:30, Luiz Capitulino wrote: On Thu, 9 May 2013 21:20:52 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: These patches apply on top of qemu.git master, and can also be obtained from:

Re: [Qemu-devel] [PATCH 0/2] pci-assign: MSI affinity support

2013-05-10 Thread Alex Williamson
On Fri, 2013-05-10 at 14:40 +0200, Jan Kiszka wrote: On 2013-05-09 18:35, Alex Williamson wrote: I posted these about 6 months ago and Jan felt we should implement MSI notifiers like we have for MSI-X. That still hasn't happened. Device assignments are the only currently known users - and

[Qemu-devel] [Bug 1175513] Re: Qemu 1.5-git gpu clock control doesn`t work after guest reboot

2013-05-10 Thread commiethebeastie
And all work after killing qemu with ^C. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1175513 Title: Qemu 1.5-git gpu clock control doesn`t work after guest reboot Status in The Linux Kernel:

Re: [Qemu-devel] [PATCH for-1.5?] target-ppc: Drop unnecessary dynamic cast in ppc_env_get_cpu()

2013-05-10 Thread Andreas Färber
[resending after bounce] Am 10.05.2013 17:06, schrieb Anthony Liguori: Andreas Färber afaer...@suse.de writes: A transition from CPUPPCState to PowerPCCPU can be considered safe, just like PowerPCCPU::env access in the opposite direction. This should slightly improve interrupt performance.

Re: [Qemu-devel] [PATCH 01/10] qapi: qapi-types.py, native list support

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 10:07:45AM -0400, Luiz Capitulino wrote: On Thu, 9 May 2013 21:20:53 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Teach type generators about native types so they can generate the appropriate linked list types. Signed-off-by: Michael Roth

Re: [Qemu-devel] [PATCH for-1.5 0/9] Disable expensive QOM cast debugging for official releases

2013-05-10 Thread Aurelien Jarno
On Fri, May 10, 2013 at 02:16:34PM +0200, Paolo Bonzini wrote: Cast debugging can have a substantial cost (20% or more, measured by Aurelien on qemu-system-ppc64). Instead of adding special-cased fast casts in the hot paths, we can just disable it in releases. At the same time, add tracing

Re: [Qemu-devel] [PATCH v2 00/10] qapi: add support for lists of native types

2013-05-10 Thread Laszlo Ersek
On 05/10/13 17:30, Luiz Capitulino wrote: On Thu, 9 May 2013 21:20:52 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: These patches apply on top of qemu.git master, and can also be obtained from: git://github.com/mdroth/qemu.git qapi-native-lists Sending this now since a number of

Re: [Qemu-devel] [PATCH 06/10] json-parser: fix handling of large whole number values

2013-05-10 Thread mdroth
On Fri, May 10, 2013 at 11:17:17AM -0400, Luiz Capitulino wrote: On Thu, 9 May 2013 21:20:58 -0500 Michael Roth mdr...@linux.vnet.ibm.com wrote: Currently our JSON parser assumes that numbers lacking a mantissa are integers and attempts to store them as QInt/int64 values. This breaks in

[Qemu-devel] [RFC 0/7] Convert SD card model to AIO

2013-05-10 Thread Igor Mitsyanko
This is an initial attempt to change our SD card model to use asynchronious input/output API instead of synchronious one. This will require converting of every user also. Right now I've converted only PL181 model, and I'll wait for some feedback on taken approach before I'll continue with other

[Qemu-devel] [RFC 2/7] sd.c: introduce variable for trekking valid data

2013-05-10 Thread Igor Mitsyanko
Initialize it appropriately when various commands are processed. Signed-off-by: Igor Mitsyanko i.mitsya...@gmail.com --- hw/sd/sd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/sd/sd.c b/hw/sd/sd.c index 1dd1331..775a55c 100644 --- a/hw/sd/sd.c +++ b/hw/sd/sd.c @@ -116,6 +116,7 @@

  1   2   >