Re: [Qemu-devel] [PATCH] Remove twice include of qemu-common.h

2013-05-14 Thread Michael Tokarev
08.05.2013 08:39, qiaonuo...@cn.fujitsu.com wrote: From: Qiao Nuohan qiaonuo...@cn.fujitsu.com This patch is used to remove twice include of qemu-common.h in block/win32-aio.c Thanks, applied to the trivial patches queue. /mjt

Re: [Qemu-devel] [PATCH V5 0/5] block: make qmp_transaction extendable

2013-05-14 Thread Wenchao Xia
于 2013-5-8 19:21, Kevin Wolf 写道: Am 08.05.2013 um 12:25 hat Wenchao Xia geschrieben: This serial will package backing chain snapshot code as one case, to make it possible adding more operations later. v2: Address Kevin's comments: Use the same prototype prepare, commit, rollback model

Re: [Qemu-devel] [Bug 1179664] [NEW] migration.c:293: undefined reference to `__sync_val_compare_and_swap_4'

2013-05-14 Thread Stefan Hajnoczi
On Mon, May 13, 2013 at 08:46:27PM -, therock247uk wrote: Public bug reported: latest git qemu error i get on compiling with mingw LINK i386-softmmu/qemu-system-i386w.exe ../migration.o: In function `migrate_finish_set_state':

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: just wondering as i just compiled the latest git and qemu goes into none responding mode when i try to do any networking stuff on guests (both linux and windows) Works for me on qemu.git/master on Linux: $ git rev-parse HEAD

Re: [Qemu-devel] [PATCH RFC 08/13] range: add Range structure

2013-05-14 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 09:20:08PM +0100, Peter Maydell wrote: On 13 May 2013 21:01, Michael S. Tsirkin m...@redhat.com wrote: Sometimes we need to pass ranges around, add a handy structure for this purpose. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/qemu/range.h |

Re: [Qemu-devel] [PATCH v2 01/11] curl: introduce CURLSockInfo to BDRVCURLState.

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 10:26:20AM +0800, Fam Zheng wrote: We use socket provided by curl in the driver. Libcurl multi interface has option CURLMOPT_SOCKETFUNCTION for socket. Per man 3 curl_multi_setopt: ... CURLMOPT_SOCKETFUNCTION Pass a pointer to a function matching

Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-14 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: On 13 May 2013 21:01, Michael S. Tsirkin m...@redhat.com wrote: This fills in guest info table with misc information of interest to the guest. Will be used by ACPI table generation code. Bunch of coding style violations in

Re: [Qemu-devel] [PATCH v2 04/11] curl: fix curl_open

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 10:26:23AM +0800, Fam Zheng wrote: +if (!strncmp(s-url, http://;, strlen(http://;)) !s-accept_range) { +strncpy(state-errmsg, Server not supporting range., CURL_ERROR_SIZE); Please use pstrcpy(), it always NUL-terminates. strncpy(3) does not when the

Re: [Qemu-devel] [PATCH 1/3] configure: permit compilation on arm aarch64

2013-05-14 Thread Claudio Fontana
On 13.05.2013 20:29, Peter Maydell wrote: On 13 May 2013 14:28, Claudio Fontana claudio.font...@huawei.com wrote: support compiling on aarch64. Signed-off-by: Claudio Fontana claudio.font...@huawei.com This looks good, but it should be the last patch in the series, so we don't allow the

Re: [Qemu-devel] [PATCH v2 09/11] curl: release everything on curl_close

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 10:26:28AM +0800, Fam Zheng wrote: Release everything properly on curl_close. Signed-off-by: Fam Zheng f...@redhat.com --- block/curl.c | 37 - 1 file changed, 36 insertions(+), 1 deletion(-) Cleanup should be included in the

Re: [Qemu-devel] [PATCH v2 02/11] curl: change magic number to macro

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 10:26:21AM +0800, Fam Zheng wrote: @@ -70,7 +70,8 @@ typedef struct CURLState size_t buf_start; size_t buf_off; size_t buf_len; -char range[128]; +#define CURL_RANGE_SIZE 128 +char range[CURL_RANGE_SIZE]; char errmsg[CURL_ERROR_SIZE];

Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote: - CURLDataCache holds the user data read from libcurl, it is in a list ordered by access, the used cache is moved to list head on access, so the tail element is freed first. BDRVCURLState.cache_quota is the threshold to start

Re: [Qemu-devel] [PATCH 2/3] include/elf.h: add aarch64 ELF machine and relocs

2013-05-14 Thread Claudio Fontana
On 13.05.2013 20:34, Peter Maydell wrote: On 13 May 2013 14:31, Claudio Fontana claudio.font...@huawei.com wrote: we will use the 26bit relative relocations in the aarch64 tcg target. This patch looks OK, but can I ask you to just neaten up the #defines by making the column of values line

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Stefan Hajnoczi
On Mon, May 13, 2013 at 05:21:54PM -0400, Wolfgang Richter wrote: I'm working on a new patch series which will add a new QMP command, block-trace, which turns on tracing of writes for a specified block device and sends the stream unmodified to another block device. The 'trace' is meant to

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-14 Thread Stefan Hajnoczi
On Wed, May 08, 2013 at 02:49:00PM +0200, Kevin Wolf wrote: Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: @block-backup Start a point-in-time copy of a block device to a new destination. The status of ongoing block backup operations can be checked with query-block-jobs. The

Re: [Qemu-devel] [PATCH v2 2/3] block: add block-backup QMP command

2013-05-14 Thread Stefan Hajnoczi
On Fri, May 10, 2013 at 10:02:14PM -0600, Eric Blake wrote: On 04/29/2013 01:42 AM, Stefan Hajnoczi wrote: @block-backup +++ b/qapi-schema.json @@ -1715,6 +1715,37 @@ '*speed': 'int' } } ## +# @block-backup +# +# Start a point-in-time copy of a block device to

Re: [Qemu-devel] [PATCH v2 00/11] curl: fix curl read

2013-05-14 Thread Fam Zheng
On Tue, 05/14 10:22, Stefan Hajnoczi wrote: On Tue, May 14, 2013 at 10:26:19AM +0800, Fam Zheng wrote: - CURLDataCache holds the user data read from libcurl, it is in a list ordered by access, the used cache is moved to list head on access, so the tail element is freed first.

Re: [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver

2013-05-14 Thread Stefan Hajnoczi
On Wed, May 08, 2013 at 02:39:25PM +0200, Kevin Wolf wrote: Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: Sorry, but this patch doesn't look very close to mergable yet. Fair enough. I had some ideas on decoupling the backup block job from the core block layer, making fewer

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Kevin Wolf
Am 13.05.2013 um 23:21 hat Wolfgang Richter geschrieben: I'm working on a new patch series which will add a new QMP command, block-trace, which turns on tracing of writes for a specified block device and sends the stream unmodified to another block device.  The 'trace' is meant to be precise

[Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3

2013-05-14 Thread David Gibson
Hi, Here's the next version of my patches working towards integrating vfio with guest visible iommu support. These are on top of Paolo Bonzini's iommu branch at: git://github.com/bonzini/qemu.git Paolo says he has already merged patches 1-4, but they don't seem to have hit the published

[Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion

2013-05-14 Thread David Gibson
Currently do_pci_unregister_device() calls memory_region_del_subregion() on the device's bus_master_enable_region and the device's iommu region. But the bus_master_enable_region is an _alias_ to the iommu region, the iommu region is _not_ a subregion of it. I suspect this has slipped by only

[Qemu-devel] [PATCH 01/11] iommu: Fix compile error in ioapic.c

2013-05-14 Thread David Gibson
The iommu tree introduced a build bug into hw/i386/kvm/ioapic.c. Looks like a messed up copy and paste. Signed-off-by: David Gibson da...@gibson.dropbear.id.au --- hw/i386/kvm/ioapic.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/ioapic.c

[Qemu-devel] [PATCH 05/11] pci: Introduce helper to retrieve a PCI device's DMA address space

2013-05-14 Thread David Gibson
A PCI device's DMA address space (possibly an IOMMU) is returned by a method on the PCIBus. At the moment that only has one caller, so the method is simply open coded. We'll need another caller for VFIO, so this patch introduces a helper/wrapper function. Signed-off-by: David Gibson

[Qemu-devel] [PATCH 04/11] pci: Use AddressSpace rather than MemoryRegion to represent PCI DMA space

2013-05-14 Thread David Gibson
Currently the PCI iommu_fn hook returns a MemoryRegion * to represent the DMA address of this bus's IOMMU, although that MemoryRegion does have to be a root MemoryRegion. Several upcoming users of this need the extra features of an AddressSpace object, rather than a MemoryRegion, and while they

[Qemu-devel] [PATCH 06/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace

2013-05-14 Thread David Gibson
At the moment, most AddressSpace objects last as long as the guest system in practice, but that could well change in future. In addition, for VFIO we will be introducing some private per-AdressSpace information, which must be disposed of before the AddressSpace itself is destroyed. To reduce the

[Qemu-devel] [PATCH 03/11] pci: Rework PCI iommu lifetime assumptions

2013-05-14 Thread David Gibson
The current bus callbacks to assign and destroy an iommu memory region for a PCI device tacitly assume that the lifetime of that address space is tied to the lifetime of the PCI device. Although that's certainly possible, it's much more likely that the region will be (at least potentially) shared

[Qemu-devel] [PATCH 08/11] vfio: Create VFIOAddressSpace objects as needed

2013-05-14 Thread David Gibson
So far, VFIO has a notion of different logical DMA address spaces, but only ever uses one (system memory). This patch extends this, creating new VFIOAddressSpace objects as necessary, according to the AddressSpace reported by the PCI subsystem for this device's DMAs. This isn't enough yet to

[Qemu-devel] [PATCH 07/11] vfio: Introduce VFIO address spaces

2013-05-14 Thread David Gibson
The only model so far supported for VFIO passthrough devices is the model usually used on x86, where all of the guest's RAM is mapped into the (host) IOMMU and there is no IOMMU visible in the guest. This patch begins to relax this model, introducing the notion of a VFIOAddressSpace. This

[Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry

2013-05-14 Thread David Gibson
Currently, the IOMMUTLBEntry structure contains the translated address, but not the IOVA (original untranslated address). We're going to need it for upcoming changes, so add it in here, and populate it correctly in our one existing iommu implementation. Signed-off-by: David Gibson

[Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers

2013-05-14 Thread David Gibson
This patch adds a NotifierList to MemoryRegions which represent IOMMUs allowing other parts of the code to register interest in mappings or unmappings from the IOMMU. All IOMMU implementations will need to call memory_region_notify_iommu() to inform those waiting on the notifier list, whenever an

[Qemu-devel] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread David Gibson
This patch uses the new IOMMU notifiers to allow VFIO pass through devices to work with guest side IOMMUs, as long as the host-side VFIO iommu has sufficient capability and granularity to match the guest side. This works by tracking all map and unmap operations on the guest IOMMU using the

Re: [Qemu-devel] [RFC PATCH 1/2] mem: make phys_section and phys_map_nodes prepared for RCU

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 05:38, liu ping fan ha scritto: +struct PhysPageTable { +int ref; +PhysSection *phys_sections; +unsigned phys_sections_nb; +unsigned phys_sections_nb_alloc; +uint16_t phys_section_unassigned; +uint16_t phys_section_notdirty; +uint16_t

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Gerd Hoffmann
Hi, Several future developments that this will enable: - make it easier to use alternative firmware: any firmware can just load the ACPI tables from QEMU. case in point OVMF. UEFI obviously can create ACPI tables already so I don't think this is a valid advantage. Yea, but it

Re: [Qemu-devel] [PATCH RFC 10/13] i386: generate pc guest info

2013-05-14 Thread Peter Maydell
On 14 May 2013 09:06, Michael S. Tsirkin m...@redhat.com wrote: On Mon, May 13, 2013 at 09:23:54PM +0100, Peter Maydell wrote: Bunch of coding style violations in this patch which will need fixing at some point in the RFC-patch process. I went over it again and found one: One is not a bunch

Re: [Qemu-devel] [RFC PATCH 2/2] mem: prepare address_space listener rcu style

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 07:47, liu ping fan ha scritto: On Mon, May 13, 2013 at 5:31 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 13/05/2013 05:21, Liu Ping Fan ha scritto: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Each address space listener has PhysPageMap *cur_map, *next_map, the switch

Re: [Qemu-devel] [Bug 1179664] [NEW] migration.c:293: undefined reference to `__sync_val_compare_and_swap_4'

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 09:37, Stefan Hajnoczi ha scritto: On Mon, May 13, 2013 at 08:46:27PM -, therock247uk wrote: Public bug reported: latest git qemu error i get on compiling with mingw LINK i386-softmmu/qemu-system-i386w.exe ../migration.o: In function `migrate_finish_set_state':

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Peter Maydell
On 14 May 2013 10:29, Gerd Hoffmann kra...@redhat.com wrote: Anthony wrote: and is also a good reason why exposing this information via a common interface (fw_cfg) would be a good idea. Huh? As far I know we generate device trees in qemu It depends. For ARM we insist that the user provides

Re: [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 11:13, David Gibson ha scritto: Hi, Here's the next version of my patches working towards integrating vfio with guest visible iommu support. These are on top of Paolo Bonzini's iommu branch at: git://github.com/bonzini/qemu.git Paolo says he has already merged

Re: [Qemu-devel] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 11:13, David Gibson ha scritto: This patch uses the new IOMMU notifiers to allow VFIO pass through devices to work with guest side IOMMUs, as long as the host-side VFIO iommu has sufficient capability and granularity to match the guest side. This works by tracking all map and

Re: [Qemu-devel] [0/8] RFC: VFIO and guest side IOMMUs, revisited

2013-05-14 Thread Paolo Bonzini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 14/05/2013 04:39, David Gibson ha scritto: On Mon, May 13, 2013 at 03:30:26PM +0200, Paolo Bonzini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Il 13/05/2013 15:13, David Gibson ha scritto: On Mon, May 13, 2013 at 02:23:30PM +0200,

Re: [Qemu-devel] [RFC] block-trace Low Level Command Supporting Disk Introspection

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 10:50, Kevin Wolf ha scritto: Or, to translate it into our existing terminology, drive-mirror implements a passive mirror, you're proposing an active one (which we do want to have). With an active mirror, we'll want to have another choice: The mirror can be synchronous (guest

[Qemu-devel] [PATCH for-1.5] readline: Handle xterm escape sequences for Home/End keys

2013-05-14 Thread Kevin Wolf
This fixes the Home/End keys in the monitor using the GTK frontend. Signed-off-by: Kevin Wolf kw...@redhat.com --- readline.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/readline.c b/readline.c index d6e04d4..1c0f7ee 100644 --- a/readline.c +++ b/readline.c @@ -27,6

Re: [Qemu-devel] [PATCH for-1.5] readline: Handle xterm escape sequences for Home/End keys

2013-05-14 Thread Hans de Goede
Hi, Looks good, ack. Regards, Hans On 05/14/2013 12:15 PM, Kevin Wolf wrote: This fixes the Home/End keys in the monitor using the GTK frontend. Signed-off-by: Kevin Wolf kw...@redhat.com --- readline.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/readline.c

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: just wondering as i just compiled the latest git and qemu goes into none responding mode when i try to do any networking stuff on guests (both linux and

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 12:24, TeLeMan ha scritto: On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: just wondering as i just compiled the latest git and qemu goes into none responding mode when i try to do any

Re: [Qemu-devel] [0/8] Clean up PCI code to allow for multiple root buses

2013-05-14 Thread Michael S. Tsirkin
On Thu, May 09, 2013 at 10:31:04AM +1000, David Gibson wrote: The current PCI subsystem has kind of half-hearted support for multiple independent root buses - aka PCI domains - in the form of the PCIHostBus structure and its domain field. However, it doesn't quite work because

[Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2013-05-14 Thread Peter Maydell
It's very unlikely to be the patch you mention, since that's for SD card emulation and you're not using SD card emulation. It's probably just a regression between 1.4 and 1.5, and I'm fairly sure it's in some changes I made to the versatilepb PCI controller model -- I will investigate. -- You

[Qemu-devel] [PATCH (trivial)] remove some double-includes

2013-05-14 Thread Michael Tokarev
Some source files #include the same header more than once for no good reason. Remove second #includes in such cases. Signed-off-by: Michael Tokarev m...@tls.msk.ru --- I used more lines in context diff below, to show that these #includes are actually repeated. In some cases, however, list of

[Qemu-devel] [Bug 1094564] Re: images used as scsi disks not readable (qemu-system-arm, macos 10.8)

2013-05-14 Thread Joss Reeves
Ah, I interpreted it to mean scsi disk instead of SD card :) I'll leave this to the experts. Thanks so much for looking into this and please let me know if I can be of further assistance. -Joss -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes

2013-05-14 Thread Peter Maydell
On 14 May 2013 12:18, Michael Tokarev m...@tls.msk.ru wrote: Some source files #include the same header more than once for no good reason. Remove second #includes in such cases. diff --git a/translate-all.c b/translate-all.c index da93608..a18bf55 100644 --- a/translate-all.c +++

Re: [Qemu-devel] [PATCH 2/4] vnc: Support for LED state extension

2013-05-14 Thread Gerd Hoffmann
On 04/25/13 07:29, Lei Li wrote: +/* Sending the current led state message to the client */ +if (ledstate != current_led_state(vs)) { +vnc_led_state_change(vs); +} This check never becomes true as the vnc modifier/led state just got updated to match ledstate ... cheers,

[Qemu-devel] [Bug 1177774] Re: Gtk+ frontend fails to build

2013-05-14 Thread Brad Smith
With the 1.5 release so near does no one really care that the Gtk+ frontend does not build? I would think this would be a pretty important bug to fix before the release. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread TeLeMan
On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/05/2013 12:24, TeLeMan ha scritto: On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote: just wondering as i just compiled the

Re: [Qemu-devel] [PATCH v2 07/11] versatile_pci: Implement the correct PCI IRQ mapping

2013-05-14 Thread Peter Maydell
On 26 March 2013 11:08, Arnd Bergmann a...@arndb.de wrote: On Tuesday 26 March 2013, Peter Maydell wrote: On 26 March 2013 10:54, Arnd Bergmann a...@arndb.de wrote: Yes, very good. We will probably introduce sparse irq support on versatile in the near future, and then the value we write

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 13:39, TeLeMan ha scritto: On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/05/2013 12:24, TeLeMan ha scritto: On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May 14, 2013 at 12:02:24AM -, therock247uk wrote:

[Qemu-devel] [PATCH v2] blockdev: Rename BlockdevAction - TransactionAction

2013-05-14 Thread Kevin Wolf
There's no reason to restrict transactions to operations related to block devices, so rename the type now before schema introspection stops us from doing so. Also change the schema documentation of 'transaction' to not refer to block devices or snapshots any more. Signed-off-by: Kevin Wolf

Re: [Qemu-devel] [Bug 1179731] [NEW] is networking broken on windows hosts?

2013-05-14 Thread Paolo Bonzini
Il 14/05/2013 13:48, Paolo Bonzini ha scritto: Il 14/05/2013 13:39, TeLeMan ha scritto: On Tue, May 14, 2013 at 6:46 PM, Paolo Bonzini pbonz...@redhat.com wrote: Il 14/05/2013 12:24, TeLeMan ha scritto: On Tue, May 14, 2013 at 3:51 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, May

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Michael S. Tsirkin
On Mon, May 13, 2013 at 03:38:51PM -0500, Anthony Liguori wrote: I don't think it's a good idea to move BIOS functionality in QEMU. Just to clarify: generating ACPI tables is not BIOS functionality. It ended up in seabios for historical reasons. A normal scenario for ACPI tables is that they

[Qemu-devel] [PATCH for-1.5] portability: pty.h is glibc-specific

2013-05-14 Thread Paolo Bonzini
This should fix building the GTK+ front-end on BSDs. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- include/qemu-common.h | 12 qemu-char.c | 10 -- ui/gtk.c | 1 - 3 files changed, 12 insertions(+), 11 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Claudio Fontana
On 13.05.2013 20:28, Peter Maydell wrote: On 13 May 2013 14:33, Claudio Fontana claudio.font...@huawei.com wrote: add preliminary support for TCG target aarch64. Thanks for this patch. Some comments below. Signed-off-by: Claudio Fontana claudio.font...@huawei.com ---

[Qemu-devel] [Bug 1177774] Re: Gtk+ frontend fails to build

2013-05-14 Thread Paolo Bonzini
Sending a patch soon, please reply with Tested-by if it works. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/114 Title: Gtk+ frontend fails to build Status in QEMU: New Bug description:

[Qemu-devel] [PATCH for-1.5] spitz: fix compilation failure due to pty.h namespace pollution

2013-05-14 Thread Paolo Bonzini
pty.h is polluting the global namespace with a CTRL macro. spitz thus fails compilation with the patch at http://article.gmane.org/gmane.comp.emulators.qemu/211337 and this patch fixes it. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/arm/spitz.c | 100

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Peter Maydell
On 14 May 2013 13:01, Claudio Fontana claudio.font...@huawei.com wrote: On 13.05.2013 20:28, Peter Maydell wrote: On 13 May 2013 14:33, Claudio Fontana claudio.font...@huawei.com wrote: add preliminary support for TCG target aarch64. Thanks for this patch. Some comments below.

[Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function for acpi timer

2013-05-14 Thread Gerd Hoffmann
Otherwise the guest can crash qemu (NULL pointer dereference). https://bugzilla.redhat.com/show_bug.cgi?id=947691 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi/core.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index

Re: [Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function for acpi timer

2013-05-14 Thread Laszlo Ersek
On 05/14/13 14:29, Gerd Hoffmann wrote: Otherwise the guest can crash qemu (NULL pointer dereference). https://bugzilla.redhat.com/show_bug.cgi?id=947691 Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/acpi/core.c |7 +++ 1 file changed, 7 insertions(+) diff --git

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-05-14 Thread Laszlo Ersek
Hi, On 04/19/13 06:44, Amos Kong wrote: (qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and delay sometime, then send one up event. In this case, only key can be identified by guest. This patch changed qemu to intervally send down events to guest in

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Laurent Desnogues
On Tue, May 14, 2013 at 2:01 PM, Claudio Fontana claudio.font...@huawei.com wrote: [...] +static void tcg_target_qemu_prologue(TCGContext *s) +{ +int r; +int frame_size; /* number of 16 byte items */ + +/* we need to save (FP, LR) and X19 to X28 */ +frame_size = (1) +

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, Several future developments that this will enable: - make it easier to use alternative firmware: any firmware can just load the ACPI tables from QEMU. case in point OVMF. UEFI obviously can create ACPI tables already so I don't think this

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Anthony Liguori
Michael S. Tsirkin m...@redhat.com writes: On Mon, May 13, 2013 at 03:38:51PM -0500, Anthony Liguori wrote: I don't think it's a good idea to move BIOS functionality in QEMU. Just to clarify: generating ACPI tables is not BIOS functionality. It ended up in seabios for historical reasons.

Re: [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver

2013-05-14 Thread Stefan Hajnoczi
On Wed, May 08, 2013 at 02:39:25PM +0200, Kevin Wolf wrote: Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: diff --git a/include/block/blockjob.h b/include/block/blockjob.h index c290d07..6f42495 100644 --- a/include/block/blockjob.h +++ b/include/block/blockjob.h @@ -50,6

Re: [Qemu-devel] [PATCH v2 1/3] block: add basic backup support to block driver

2013-05-14 Thread Kevin Wolf
Am 14.05.2013 um 15:24 hat Stefan Hajnoczi geschrieben: On Wed, May 08, 2013 at 02:39:25PM +0200, Kevin Wolf wrote: Am 29.04.2013 um 09:42 hat Stefan Hajnoczi geschrieben: diff --git a/include/block/blockjob.h b/include/block/blockjob.h index c290d07..6f42495 100644 ---

Re: [Qemu-devel] KVM call agenda for 2013-05-14

2013-05-14 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda topics you are interested in. As there is no agenda no call. have a nice day, Juan.

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Gerd Hoffmann
Hi, and is also a good reason why exposing this information via a common interface (fw_cfg) would be a good idea. Huh? As far I know we generate device trees in qemu instead of expecting pseries firmware compile them from fw_cfg information. It depends on what firmware you are using.

Re: [Qemu-devel] [PATCH 3/3] tcg/aarch64: implement new TCG target for aarch64

2013-05-14 Thread Claudio Fontana
On 13.05.2013 21:49, Richard Henderson wrote: On 05/13/2013 06:33 AM, Claudio Fontana wrote: +enum aarch64_cond_code { +COND_EQ = 0x0, +COND_NE = 0x1, +COND_CS = 0x2, /* Unsigned greater or equal */ +COND_HS = 0x2, /* ALIAS greater or equal */ Clearer to define

Re: [Qemu-devel] [Qemu-ppc] [PATCH 11/11] vfio: Add guest side IOMMU support

2013-05-14 Thread David Gibson
On Tue, May 14, 2013 at 11:48:47AM +0200, Paolo Bonzini wrote: Il 14/05/2013 11:13, David Gibson ha scritto: This patch uses the new IOMMU notifiers to allow VFIO pass through devices to work with guest side IOMMUs, as long as the host-side VFIO iommu has sufficient capability and

[Qemu-devel] [PATCH v2 for-1.5 0/4] qcow2: Catch some L1 table index overflows

2013-05-14 Thread Kevin Wolf
Kevin Wolf (4): qcow2: Catch some L1 table index overflows block: Add hint to -EFBIG error message qcow2.py: Subcommand for changing header fields qemu-iotests: Try creating huge qcow2 image block.c | 8 -- block/qcow2-cluster.c| 23 --

[Qemu-devel] [PATCH v2 for-1.5 1/4] qcow2: Catch some L1 table index overflows

2013-05-14 Thread Kevin Wolf
This catches the situation that is described in the bug report at https://bugs.launchpad.net/qemu/+bug/865518 and goes like this: $ qemu-img create -f qcow2 huge.qcow2 $((1024*1024))T Formatting 'huge.qcow2', fmt=qcow2 size=1152921504606846976 encryption=off cluster_size=65536

[Qemu-devel] [PATCH v2 3/4] qcow2.py: Subcommand for changing header fields

2013-05-14 Thread Kevin Wolf
Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/qcow2.py | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/qemu-iotests/qcow2.py b/tests/qemu-iotests/qcow2.py index fecf5b9..44a2b45 100755 --- a/tests/qemu-iotests/qcow2.py +++

[Qemu-devel] [PATCH v2 4/4] qemu-iotests: Try creating huge qcow2 image

2013-05-14 Thread Kevin Wolf
It's supposed to fail gracefully instead of segfaulting. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/qemu-iotests/054 | 58 tests/qemu-iotests/054.out | 10 tests/qemu-iotests/common.rc | 2 +- tests/qemu-iotests/group |

Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes

2013-05-14 Thread Michael Tokarev
14.05.2013 15:30, Peter Maydell wrote: On 14 May 2013 12:18, Michael Tokarev m...@tls.msk.ru wrote: Some source files #include the same header more than once for no good reason. Remove second #includes in such cases. diff --git a/translate-all.c b/translate-all.c index da93608..a18bf55

Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes

2013-05-14 Thread Michael Tokarev
14.05.2013 18:16, Peter Maydell wrote: On 14 May 2013 15:15, Michael Tokarev m...@tls.msk.ru wrote: 14.05.2013 15:30, Peter Maydell wrote: There's already been a patch on the list for this one: http://patchwork.ozlabs.org/patch/240540/ Yes I know Peter, and actually this is the patch which

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-05-14 Thread Nicholas Thomas
Hi all, On Tue, 2013-02-12 at 08:06 +0100, Peter Lieven wrote: On 23.01.2013 11:03, Michael S. Tsirkin wrote: For future, we can try to set TUN_ONE_QUEUE flag on the interface, or try applying this patch 5d097109257c03a71845729f8db6b5770c4bbedc in kernel see if this helps. If have

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-05-14 Thread Peter Lieven
On 14.05.2013 16:21, Nicholas Thomas wrote: Hi all, On Tue, 2013-02-12 at 08:06 +0100, Peter Lieven wrote: On 23.01.2013 11:03, Michael S. Tsirkin wrote: For future, we can try to set TUN_ONE_QUEUE flag on the interface, or try applying this patch 5d097109257c03a71845729f8db6b5770c4bbedc in

[Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-14 Thread Stefan Priebe - Profihost AG
Am 10.05.2013 13:09, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 08:12:39AM +0200, Stefan Priebe - Profihost AG wrote: 3. Either use gdb or an

Re: [Qemu-devel] [SeaBIOS] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread David Woodhouse
On Tue, 2013-05-14 at 10:38 +0100, Peter Maydell wrote: It depends. For ARM we insist that the user provides the device tree that corresponds to the kernel they're going to run, and then we just tweak it a bit. Um... device trees describe hardware, and should not be at all kernel-specific.

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Anthony Liguori
Gerd Hoffmann kra...@redhat.com writes: Hi, and is also a good reason why exposing this information via a common interface (fw_cfg) would be a good idea. Huh? As far I know we generate device trees in qemu instead of expecting pseries firmware compile them from fw_cfg information.

[Qemu-devel] [Bug 1177774] Re: Gtk+ frontend fails to build

2013-05-14 Thread Brad Smith
For *BSD OS's you have to include termios.h.. In file included from /usr/local/include/gtk-2.0/gtk/gtk.h:234, from ui/gtk.c:44: /usr/local/include/gtk-2.0/gtk/gtkitemfactory.h:47: warning: function declaration isn't a prototype ui/gtk.c: In function 'gd_vc_init': ui/gtk.c:1141:

Re: [Qemu-devel] [PATCH RFC 00/13] qemu: generate acpi tables for the guest

2013-05-14 Thread Michael S. Tsirkin
On Tue, May 14, 2013 at 08:34:43AM -0500, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: On Mon, May 13, 2013 at 03:38:51PM -0500, Anthony Liguori wrote: I don't think it's a good idea to move BIOS functionality in QEMU. Just to clarify: generating ACPI tables is not

Re: [Qemu-devel] [PATCH (trivial)] remove some double-includes

2013-05-14 Thread Peter Maydell
On 14 May 2013 15:15, Michael Tokarev m...@tls.msk.ru wrote: 14.05.2013 15:30, Peter Maydell wrote: There's already been a patch on the list for this one: http://patchwork.ozlabs.org/patch/240540/ Yes I know Peter, and actually this is the patch which prompte me to look for other places.

Re: [Qemu-devel] tap devices not receiving packets from a bridge

2013-05-14 Thread Nicholas Thomas
Hi, On Tue, 2013-05-14 at 16:28 +0200, Peter Lieven wrote: Please check the tunnel mode in sysfs after your VM is started. It is likely that qemu overwrites the settings you made in the ruby script. Please check if the patch tap: set IFF_ONE_QUEUE per default is in your qemu 1.4.1

Re: [Qemu-devel] [PATCH v2 for-1.5 1/4] qcow2: Catch some L1 table index overflows

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 04:14:33PM +0200, Kevin Wolf wrote: This catches the situation that is described in the bug report at https://bugs.launchpad.net/qemu/+bug/865518 and goes like this: $ qemu-img create -f qcow2 huge.qcow2 $((1024*1024))T Formatting 'huge.qcow2', fmt=qcow2

Re: [Qemu-devel] [PATCH v2 for-1.5 2/4] block: Add hint to -EFBIG error message

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 04:14:34PM +0200, Kevin Wolf wrote: The limit of qcow2 files at least depends on the cluster size. If the image format has a cluster_size option, suggest to increase it. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 8 ++-- 1 file changed, 6

[Qemu-devel] [PULL for-1.5 0/2] Block patches for QEMU 1.5

2013-05-14 Thread Stefan Hajnoczi
Fixes from Kevin. The following changes since commit b087143b4d010451208264b7c841436aafe1cbb1: ui/gtk.c: do not use gdk_display_warp_pointer when GTK ver 3.0 (2013-05-13 09:52:49 -0500) are available in the git repository at: git://github.com/stefanha/qemu.git block for you to fetch

[Qemu-devel] [PATCH 1/2] qcow2: Catch some L1 table index overflows

2013-05-14 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com This catches the situation that is described in the bug report at https://bugs.launchpad.net/qemu/+bug/865518 and goes like this: $ qemu-img create -f qcow2 huge.qcow2 $((1024*1024))T Formatting 'huge.qcow2', fmt=qcow2 size=1152921504606846976

[Qemu-devel] [PATCH 2/2] block: Add hint to -EFBIG error message

2013-05-14 Thread Stefan Hajnoczi
From: Kevin Wolf kw...@redhat.com The limit of qcow2 files at least depends on the cluster size. If the image format has a cluster_size option, suggest to increase it. Signed-off-by: Kevin Wolf kw...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- block.c | 8 ++-- 1 file

Re: [Qemu-devel] [PATCH] monitor: intervally send down events to guest in hold time

2013-05-14 Thread Anthony Liguori
Laszlo Ersek ler...@redhat.com writes: Hi, On 04/19/13 06:44, Amos Kong wrote: (qemu) sendkey a 1000 Current design is that qemu only send one down event to guest, and delay sometime, then send one up event. In this case, only key can be identified by guest. This patch changed qemu to

Re: [Qemu-devel] [PATCH v2] isapc: Fix non-KVM qemu boot (read/write memory for isapc BIOS)

2013-05-14 Thread Anthony Liguori
Jordan Justen jordan.l.jus...@intel.com writes: The isapc machine with seabios currently requires the BIOS region to be read/write memory rather than read-only memory. KVM currently cannot support the BIOS as a ROM region, but qemu in non-KVM mode can. Based on this, isapc machine currently

Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-14 Thread Stefan Hajnoczi
On Tue, May 14, 2013 at 4:29 PM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 13:09, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 09:42, schrieb Stefan Hajnoczi: On Fri, May 10,

[Qemu-devel] [Bug 1177774] Re: Gtk+ frontend fails to build

2013-05-14 Thread Brad Smith
This should allow OS X to at least build. It looks like Solaris does not have openpty() and cfmakeraw() -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/114 Title: Gtk+ frontend fails to build

Re: [Qemu-devel] segfault in aio_bh_poll async.c:80 WAS: Re: kvm process disappears

2013-05-14 Thread Stefan Priebe - Profihost AG
Am 14.05.2013 17:05, schrieb Stefan Hajnoczi: On Tue, May 14, 2013 at 4:29 PM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013 13:09, schrieb Stefan Hajnoczi: On Fri, May 10, 2013 at 11:07 AM, Stefan Priebe - Profihost AG s.pri...@profihost.ag wrote: Am 10.05.2013

  1   2   >