Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-13 Thread Wenchao Xia
于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30 14:34, Stefan Hajnoczi wrote: + +static int coroutine_fn

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-13 Thread Wenchao Xia
于 2013-6-13 14:03, Wenchao Xia 写道: 于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30 14:34, Stefan Hajnoczi wrote: + +static

[Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Peter Lieven
Hi, I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system reset attacks in case the attacker has only access to the console of a vServer but not on the physical host and it would shrink RSS size

Re: [Qemu-devel] [PATCHv2 2/2] migration: do not overwrite zero pages

2013-06-13 Thread Peter Lieven
On 13.06.2013 05:30, Wenchao Xia wrote: 于 2013-6-10 18:14, Peter Lieven 写道: on incoming migration do not memset pages to zero if they already read as zero. this will allocate a new zero page and consume memory unnecessarily. even if we madvise a MADV_DONTNEED later this will only deallocate

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Frederic Konrad
On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 08:15:17AM +0200, fred.kon...@greensocs.com wrote:

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-13 Thread Alexey Kardashevskiy
Hi! I do not know how (yet) but this patch breaks qtest on x86 (I bisected it): make check-qtest V=1 QTEST_QEMU_BINARY=x86_64-softmmu/qemu-system-x86_64 MALLOC_PERTURB_=${MALLOC_PERTURB_:-$((RANDOM % 255 + 1))} gtester -k --verbose -m=quick tests/fdc-test tests/ide-test tests/hd-geo-test

Re: [Qemu-devel] [PATCH] spapr: add yet another maintainer

2013-06-13 Thread David Gibson
On Thu, Jun 13, 2013 at 02:10:43AM +0200, Alexander Graf wrote: On 13.06.2013, at 02:08, Alexey Kardashevskiy wrote: On 06/13/2013 12:33 AM, Alexander Graf wrote: On 12.06.2013, at 16:27, Alexey Kardashevskiy wrote: Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru ---

Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors

2013-06-13 Thread Julio Guerra
2013/6/7 Julio Guerra gu...@julio.in: However I can't judge whether all that code is right for e600 and whether you may want to share some code with e500 / e5500 in some way? CC'ing some Freescale folks. e600 is a very different core from e500/e5500. It is a 74xx derivative. The only

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-13 Thread Fam Zheng
On Thu, 06/13 14:07, Wenchao Xia wrote: 于 2013-6-13 14:03, Wenchao Xia 写道: 于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800, Fam Zheng wrote: On Thu, 05/30

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Alexey Kardashevskiy
On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Frederic Konrad
On 13/06/2013 08:46, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On 06/12/2013 07:03 PM,

Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-13 Thread Michael Tokarev
13.06.2013 03:49, Brad Smith wrote: [] It would be nice to get this in to fix the build with Solaris (that's if there is nothing else I am not aware of which breaks the build there) and to get this in the queue for 1.5 too. I'll test it on solaris 10 x86 tonight. Started downloading an

[Qemu-devel] [PATCH RFC 6/8] exec: Clean up unnecessary S390 ifdeffery

2013-06-13 Thread Markus Armbruster
Another issue missed in commit fdec991 is -mem-path: it needs to be rejected only for old S390 KVM, not for any S390. Not that I personally care, but the ifdeffery in qemu_ram_alloc_from_ptr() annoys me. Note that this doesn't actually make -mem-path work, as the kernel doesn't (yet?) support

[Qemu-devel] [PATCH RFC 8/8] pc_sysfw: Fix ISA BIOS init for ridiculously big flash

2013-06-13 Thread Markus Armbruster
pc_isa_bios_init() suffers integer overflow for flash larger than INT_MAX. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/block/pc_sysfw.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/hw/block/pc_sysfw.c b/hw/block/pc_sysfw.c index 412d1b0..aebefc9 100644

[Qemu-devel] [PATCH RFC 1/8] exec: Fix Xen RAM allocation with unusual options

2013-06-13 Thread Markus Armbruster
Issues: * We try to obey -mem-path even though it can't work with Xen. * To implement -machine mem-merge, we call memory_try_enable_merging(new_block-host, size). But with Xen, new_block-host remains null. Oops. Fix by separating Xen allocation from normal allocation. Signed-off-by:

[Qemu-devel] [PATCH RFC 3/8] exec: Reduce ifdeffery around -mem-path

2013-06-13 Thread Markus Armbruster
Instead of spreading its ifdeffery everywhere, confine it to qemu_ram_alloc_from_ptr(). Everywhere else, simply test block-fd, which is valid exactly when block uses -mem-path. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 37

Re: [Qemu-devel] [PATCH RFC 0/8] Guest memory allocation fixes cleanup

2013-06-13 Thread Markus Armbruster
Err, the RFC is accidental. Please review anyway. I'll respin for commit afterwards.

[Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Markus Armbruster
We abort() on memory allocation failure. abort() is appropriate for programming errors. Maybe most memory allocation failures are programming errors, maybe not. But guest memory allocation failure isn't, and aborting when the user asks for more memory than we can provide is not nice. exit(1)

[Qemu-devel] [PATCH RFC 5/8] s390: Make qemu_ram_remap() consistent with allocation

2013-06-13 Thread Markus Armbruster
Old S390 KVM wants guest RAM mapped in a peculiar way. Commit fdec991 changed qemu_ram_alloc_from_ptr() to do this only when necessary, but forgot to update qemu_ram_remap(). If qemu_ram_alloc_from_ptr() maps RAM the normal way, but qemu_ram_remap() remaps it the peculiar way, remapping changes

[Qemu-devel] [PATCH RFC 2/8] exec: Clean up fall back when -mem-path allocation fails

2013-06-13 Thread Markus Armbruster
With -mem-path, qemu_ram_alloc_from_ptr() first tries to allocate accordingly, but when it fails, it falls back to normal allocation. The fall back allocation code used to be effectively identical to the -mem-path not given code, until it started to diverge incommit 432d268. I believe the code

[Qemu-devel] [PATCH RFC 0/8] Guest memory allocation fixes cleanup

2013-06-13 Thread Markus Armbruster
All I wanted to do is exit(1) instead of abort() on guest memory allocation failure [07/08]. But that lead me into a minor #ifdef bog, and here's what I brought back. Enjoy! Markus Armbruster (8): exec: Fix Xen RAM allocation with unusual options exec: Clean up fall back when -mem-path

Re: [Qemu-devel] [libvirt] Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin'

2013-06-13 Thread Martin Kletzander
On 06/12/2013 04:29 PM, chandrashekar shastri wrote: Hi All, Upstream : virt-install and virt-manager fails to install the guest with the error qemu: could not load PC BIOS 'bios.bin' You are missing bios package for that. This depends on the distro you're using, but probably

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Michael S. Tsirkin
On Thu, Jun 13, 2013 at 04:46:09PM +1000, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at 07:04:48PM +1000, Alexey Kardashevskiy wrote: On

[Qemu-devel] [PATCH RFC 4/8] s390: Simplify the RAM allocation hook

2013-06-13 Thread Markus Armbruster
Less code and ifdeffery. Signed-off-by: Markus Armbruster arm...@redhat.com --- exec.c | 4 ++-- include/sysemu/kvm.h | 3 +-- kvm-all.c| 15 ++- target-s390x/kvm.c | 17 ++--- 4 files changed, 11 insertions(+), 28 deletions(-) diff --git

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Frederic Konrad
On 13/06/2013 09:23, Michael S. Tsirkin wrote: On Thu, Jun 13, 2013 at 04:46:09PM +1000, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013 07:16 PM, Michael S. Tsirkin wrote: On Wed, Jun 12, 2013 at

[Qemu-devel] solaris x86 in qemu?

2013-06-13 Thread Michael Tokarev
Hello. In order to verify some build issues on solaris, I tried to install sol10 x86 in a kvm vm. But unfortunately it does not work: after the grub prompt and choosing Solaris 10 x86 boot entry, the kernel gets loaded (there's a row of dots displayed during that), next, the following message

Re: [Qemu-devel] [RESEND PATCH] virtio-scsi: forward scsibus for virtio-scsi-pci.

2013-06-13 Thread Michael S. Tsirkin
On Thu, Jun 13, 2013 at 09:34:30AM +0200, Frederic Konrad wrote: On 13/06/2013 09:23, Michael S. Tsirkin wrote: On Thu, Jun 13, 2013 at 04:46:09PM +1000, Alexey Kardashevskiy wrote: On 06/13/2013 04:28 PM, Frederic Konrad wrote: On 12/06/2013 13:21, Alexey Kardashevskiy wrote: On 06/12/2013

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-13 Thread Wenchao Xia
于 2013-6-13 14:33, Fam Zheng 写道: On Thu, 06/13 14:07, Wenchao Xia wrote: 于 2013-6-13 14:03, Wenchao Xia 写道: 于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 11:56:18AM +0800,

Re: [Qemu-devel] [PATCH RFC 4/8] s390: Simplify the RAM allocation hook

2013-06-13 Thread Andreas Färber
Am 13.06.2013 09:02, schrieb Markus Armbruster: Less code and ifdeffery. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix

Re: [Qemu-devel] [PATCH] curl: refuse to open URL from HTTP server without range support

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 4:13 AM, Fam Zheng f...@redhat.com wrote: On Tue, 06/11 09:40, Stefan Hajnoczi wrote: On Tue, Jun 11, 2013 at 11:15:15AM +0800, Fam Zheng wrote: On Mon, Jun 10, 2013 at 5:21 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, Jun 09, 2013 at 10:34:54AM +0800,

Re: [Qemu-devel] [PATCH 05/11] snapshot: add paired functions for internal snapshot id and name

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 01:33:29PM +0800, Wenchao Xia wrote: 于 2013-6-11 17:14, Stefan Hajnoczi 写道: On Sat, Jun 08, 2013 at 02:58:01PM +0800, Wenchao Xia wrote: + +/* Following function generate id string, used by block driver, such as qcow2. + Since no better place to go, place the

Re: [Qemu-devel] [PATCH] vmdk: byteswap VMDK4Header.desc_offset field

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 10:06:43AM +0800, Fam Zheng wrote: On Mon, 06/10 16:32, Stefan Hajnoczi wrote: On Mon, Jun 10, 2013 at 04:04:55PM +0200, Kevin Wolf wrote: Am 10.06.2013 um 11:07 hat Stefan Hajnoczi geschrieben: Remember to byteswap VMDK4Header.desc_offset on big-endian machines.

Re: [Qemu-devel] [PATCH RFC 7/8] exec: Don't abort when we can't allocate guest memory

2013-06-13 Thread Andreas Färber
Am 13.06.2013 09:02, schrieb Markus Armbruster: We abort() on memory allocation failure. abort() is appropriate for programming errors. Maybe most memory allocation failures are programming errors, maybe not. But guest memory allocation failure isn't, and aborting when the user asks for

Re: [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X

2013-06-13 Thread Stefan Hajnoczi
On Wed, Jun 12, 2013 at 04:22:52PM +0200, Kevin Wolf wrote: The raw-posix driver has code to provide a /dev/cdrom on OS X even though it doesn't really exist. However, since commit c66a6157 the real filename is dismissed after finding it, so opening /dev/cdrom fails. Put the filename back into

Re: [Qemu-devel] [PATCH v2] vmdk: refuse to open higher version than supported

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 11:21:29AM +0800, Fam Zheng wrote: Refuse to open higher version for safety. Although we try to be compatible with published VMDK spec, VMware has newer version from ESXi 5.1 exported OVF/OVA, which we have no knowledge what's changed in it. And it is very likely to

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system reset attacks in case the attacker has only access to the console of a

Re: [Qemu-devel] virsh live migration w/o shared storage fails with error as vm is not running

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 10:31:04AM +0530, chandrashekar shastri wrote: We are testing the upstream KVM with : Kernel, Qemu, Libvirt, Virt-Manager is built from the source (git). kernel version : 3.9.0+ qemu version : QEMU emulator version 1.5.0 libvirt version : 1.0.5 virt-install :

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Peter Lieven
On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system reset attacks in case the attacker

Re: [Qemu-devel] [PATCH v2] create qemu_openpty_raw() helper function and move it to a separate file

2013-06-13 Thread Andreas Färber
Am 05.06.2013 17:25, schrieb Michael Tokarev: In two places qemu uses openpty() which is very system-dependent, and in both places the pty is switched to raw mode as well. Make a wrapper function which does both steps, and move all the system-dependent complexity into a separate file, together

Re: [Qemu-devel] about atexit() (was: [PATCH 5/5] hostmem: init/finalize hostmem listener)

2013-06-13 Thread liu ping fan
On Thu, Jun 13, 2013 at 12:38 PM, Amos Kong ak...@redhat.com wrote: On Mon, Apr 01, 2013 at 04:20:34PM +0800, Liu Ping Fan wrote: From: Liu Ping Fan pingf...@linux.vnet.ibm.com Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- vl.c |2 ++ 1 files changed, 2 insertions(+), 0

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v2] s390-qemu: cpu hotplug

2013-06-13 Thread Christian Borntraeger
On 07/06/13 19:27, Jason J. Herne wrote: Latest code for cpu Hotplug designed to be controled via the QOM infrastructure. cpu on S390 are treated as devices via a new platform independent infrastructure I designed to allow this new way to exist with the old way of representing cpus. The

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Peter Lieven
On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system reset attacks in case the attacker

Re: [Qemu-devel] [PATCH v5 03/11] block: add basic backup support to block driver

2013-06-13 Thread Stefan Hajnoczi
On Thu, Jun 13, 2013 at 02:33:40PM +0800, Fam Zheng wrote: On Thu, 06/13 14:07, Wenchao Xia wrote: 于 2013-6-13 14:03, Wenchao Xia 写道: 于 2013-6-7 15:18, Stefan Hajnoczi 写道: On Thu, Jun 06, 2013 at 04:56:49PM +0800, Fam Zheng wrote: On Thu, 06/06 10:05, Stefan Hajnoczi wrote: On Thu, Jun

Re: [Qemu-devel] [PATCH v2 03/17] memory: add ref/unref calls

2013-06-13 Thread Alexey Kardashevskiy
Fails on qtest_init() in tests/libqtest.c, Broken pipe. I cannot easily see what is wrong here with this patch but it is 100% reproducible on x86_64 :( On 06/13/2013 04:28 PM, Alexey Kardashevskiy wrote: Hi! I do not know how (yet) but this patch breaks qtest on x86 (I bisected it):

[Qemu-devel] [PATCH v2 0/6] port network layer onto glib

2013-06-13 Thread Liu Ping Fan
Currently, I drop slirp and frontend related code (I guess I can reuse some code by mdroth's QContext later). And this series only resolve the net core re-entrant problem. v1-v2: introduce netqueue re-entrant detection and defer it to BH Liu Ping Fan (6): net: introduce lock to protect

[Qemu-devel] [PATCH v2 1/6] net: introduce lock to protect NetQueue

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com NetQueue will be accessed by nc and its peers at the same time, need lock to protect it. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- include/net/net.h | 1 + net/queue.c | 13 + 2 files changed, 14 insertions(+)

[Qemu-devel] [PATCH v2 5/6] net: defer nested call to BH

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Nested call caused by -receive() will raise issue like deadlock, so postphone it to BH. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- net/queue.c | 40 ++-- 1 file changed, 38 insertions(+), 2

[Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com With refcnt, NetClientState's user can run agaist deleter. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- hw/core/qdev-properties-system.c | 14 include/net/net.h| 3 +++ net/hub.c|

[Qemu-devel] [PATCH v2 2/6] net: introduce lock to protect NetClientState's peer's access

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Introduce nc-peer_lock to shield off the race of nc-peer's reader and deleter. With it, after deleter finish, no new qemu_send_packet_xx() will append packet to peer-send_queue, therefore no new reference from packet-sender to nc will exist in

[Qemu-devel] [PATCH v2 4/6] net: force NetQue opaque to be NetClientState

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com qemu_net_client_setup() is the only user of qemu_new_net_queue(), which will pass in NetClientState. By forcing it be a NetClientState, we can ref/unref NetQueue's owner Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH v2 6/6] net: hub use lock to protect ports list

2013-06-13 Thread Liu Ping Fan
From: Liu Ping Fan pingf...@linux.vnet.ibm.com Hub ports will run on multi-threads, so use lock to protect them. Signed-off-by: Liu Ping Fan pingf...@linux.vnet.ibm.com --- net/hub.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/net/hub.c

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Stefan Hajnoczi
On Wed, Jun 12, 2013 at 11:41 PM, Michael Roth mdr...@linux.vnet.ibm.com wrote: Please respond here or CC qemu-sta...@nongnu.org on any patches you think should be included in the release. The cut-off date is 2013-06-19 for new patches. commit 293c51a6ee369228633a8428ab689f14c045ff98 Author:

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Andreas Färber
Hi, Am 13.06.2013 08:09, schrieb Peter Lieven: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. The current way of not zeroing memory has led to discovery of some firmware bugs that we wouldn't have found if QEMU

Re: [Qemu-devel] virsh live migration with non-shared storage fails with error as vm is not running

2013-06-13 Thread Eric Blake
On 06/12/2013 04:21 PM, chandrashekar shastri wrote: Hi All, I have attached the dedug log of libvirt, please let me with your comments. Spamming 3 separate lists with nearly a megabyte of logs is considered poor netiquette. It causes lots of server time to multiply that out to all the

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Peter Lieven
On 13.06.2013 11:22, Andreas Färber wrote: Hi, Am 13.06.2013 08:09, schrieb Peter Lieven: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. The current way of not zeroing memory has led to discovery of some firmware

[Qemu-devel] [Bug 668799] Re: qemu-arm segfaults executing msgmerge (gettext)

2013-06-13 Thread Peter Maydell
** Changed in: qemu-linaro Status: Fix Committed = Fix Released ** Changed in: qemu Status: Fix Committed = Fix Released ** Changed in: qemu-linaro Milestone: None = 2013.06 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

[Qemu-devel] [Bug 1190525] [NEW] fdisk still shows the /dev/sdb partitions even after the removal of scsi disk

2013-06-13 Thread chandrashekar shastri
Public bug reported: RHEL guest shows the partittions even after the removal of scsi disk: fdisk still shows the /dev/sdb partitions even after the removal of scsi disk. Guest details: --- Kernel : 2.6.32-358 Host Details : Upstream Kernel, Qemu, Libvirt and virt-manager

[Qemu-devel] [PATCH] Remove hardcoded xen-platform device initialization

2013-06-13 Thread Paul Durrant
The xen-platform device should be initialized by the Xen toolstack by passing the appropriate -device argument on the command line. Signed-off-by: Paul Durrant paul.durr...@citrix.com --- hw/i386/pc_piix.c |3 --- 1 file changed, 3 deletions(-) diff --git a/hw/i386/pc_piix.c

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Amos Kong
On Fri, May 31, 2013 at 08:31:17PM +0800, Amos Kong wrote: On Thu, May 30, 2013 at 11:48:46AM -0500, Anthony Liguori wrote: Amos Kong ak...@redhat.com writes: Guest driver sets repeat rate and delay time by KBD_CMD_SET_RATE, but ps2 backend doesn't process it and no auto-repeat

Re: [Qemu-devel] [PATCH] console: extend screendump monitor cmd

2013-06-13 Thread Amos Kong
On Wed, Jun 12, 2013 at 09:23:37AM -0400, Luiz Capitulino wrote: On Wed, 12 Jun 2013 15:21:20 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, -{ 'command': 'screendump', 'data': {'filename': 'str'} } +{ 'command': 'screendump', 'data': {'filename': 'str', +

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Andreas Färber
Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool ps2_keyboard_repeatstate_needed(void *opaque) { PS2KbdState *s = opaque; -return

[Qemu-devel] fdisk still shows the /dev/sdb partitions even after the removal of scsi disk

2013-06-13 Thread chandrashekar shastri
Hi, I have filed a bug fdisk still shows the /dev/sdb partitions even after the removal of scsi disk for the upstream kernel. Bug link: https://bugs.launchpad.net/qemu/+bug/1190525 RHEL guest shows the partittions even after the removal of scsi disk: fdisk still shows the /dev/sdb partitions

Re: [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X

2013-06-13 Thread Andreas Färber
Am 12.06.2013 16:22, schrieb Kevin Wolf: The raw-posix driver has code to provide a /dev/cdrom on OS X even though it doesn't really exist. However, since commit c66a6157 the real filename is dismissed after finding it, so opening /dev/cdrom fails. Put the filename back into the options QDict

[Qemu-devel] [PATCH] fix some printf errors when debug is enabled

2013-06-13 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- cputlb.c| 4 ++-- hw/acpi/piix4.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cputlb.c b/cputlb.c index 8c8..1230e9e 100644 --- a/cputlb.c +++ b/cputlb.c @@ -262,8 +262,8 @@ void tlb_set_page(CPUArchState

[Qemu-devel] [PATCH] remove call to type_initialize in object_new_with_type

2013-06-13 Thread Hu Tao
Since it's called in object_initialize_with_type later. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- qom/object.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/qom/object.c b/qom/object.c index 803b94b..38dc45e 100644 --- a/qom/object.c +++ b/qom/object.c @@ -406,9 +406,6 @@ Object

[Qemu-devel] [PATCH] fix typo: apci - acpi

2013-06-13 Thread Hu Tao
Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 4 ++-- hw/acpi/piix4.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c index 4a17f32..100b01f 100644 --- a/hw/acpi/ich9.c +++ b/hw/acpi/ich9.c @@ -215,11 +215,11 @@ void

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Markus Armbruster
Peter Lieven p...@kamp.de writes: On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise dontneed them afterwards. This would avoid system

Re: [Qemu-devel] [PATCH v2] kvm/openpic: in-kernel mpic support

2013-06-13 Thread Andreas Färber
Am 12.06.2013 22:32, schrieb Scott Wood: Enables support for the in-kernel MPIC that thas been merged into the KVM next branch. This includes irqfd/KVM_IRQ_LINE support from Alex Graf (along with some other improvements). Note from Alex regarding kvm_irqchip_create(): On x86, one would

Re: [Qemu-devel] [PATCH] fix typo: apci - acpi

2013-06-13 Thread Andreas Färber
Am 13.06.2013 12:51, schrieb Hu Tao: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- hw/acpi/ich9.c | 4 ++-- hw/acpi/piix4.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Andreas Färber afaer...@suse.de Andreas -- SUSE LINUX Products GmbH, Maxfeldstr. 5,

Re: [Qemu-devel] [PATCH] fix some printf errors when debug is enabled

2013-06-13 Thread Andreas Färber
Am 13.06.2013 12:51, schrieb Hu Tao: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- cputlb.c| 4 ++-- hw/acpi/piix4.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cputlb.c b/cputlb.c index 8c8..1230e9e 100644 --- a/cputlb.c +++ b/cputlb.c @@

Re: [Qemu-devel] [PATCH] fix some printf errors when debug is enabled

2013-06-13 Thread Andreas Färber
Am 13.06.2013 13:10, schrieb Andreas Färber: Am 13.06.2013 12:51, schrieb Hu Tao: Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- cputlb.c| 4 ++-- hw/acpi/piix4.c | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cputlb.c b/cputlb.c index 8c8..1230e9e

[Qemu-devel] [PATCH] virtio-ccw: reset bugfix

2013-06-13 Thread Cornelia Huck
Hi, here's another virtio-ccw bugfix which makes rebooting work better here. Christian Borntraeger (1): s390/virtio-ccw: Fix virtio reset hw/s390x/virtio-ccw.c |2 ++ 1 file changed, 2 insertions(+) -- 1.7.9.5

[Qemu-devel] [PATCH] s390/virtio-ccw: Fix virtio reset

2013-06-13 Thread Cornelia Huck
From: Christian Borntraeger borntrae...@de.ibm.com On virtio reset we must reset the indicator to avoid stale interrupts, e.g. after a reset. Signed-off-by: Christian Borntraeger borntrae...@de.ibm.com Cc: qemu-sta...@nongnu.org Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

[Qemu-devel] [PATCH 1/5] Revert block: Disable driver-specific options for 1.5

2013-06-13 Thread Kevin Wolf
This reverts commit 8ec7d390b0d50b5e5b4b1d8dba7ba40d64a70875. Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c | 118 ++- tests/qemu-iotests/group | 2 +- 2 files changed, 5 insertions(+), 115 deletions(-) diff --git

[Qemu-devel] [PATCH 0/5] qcow2: Discard freed clusters

2013-06-13 Thread Kevin Wolf
This series adds options to make qcow2 discard freed clusters, in several categories. By default, only freed clusters related to snapshots (i.e. mainly snapshot deletion) are discarded. Kevin Wolf (5): Revert block: Disable driver-specific options for 1.5 qcow2: Add refcount update reason to

[Qemu-devel] [PATCH 3/5] qcow2: Options to enable discard for freed clusters

2013-06-13 Thread Kevin Wolf
Deleted snapshots are discarded in the image file by default, discard requests take their default from the -drive discard=... option and other places that free clusters must always be enabled explicitly. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-refcount.c | 5 +

[Qemu-devel] [PATCH 5/5] block: Always enable discard on the protocol level

2013-06-13 Thread Kevin Wolf
Turning on discard options in qcow2 doesn't help a lot when the discard requests that it issues are thrown away by the raw-posix layer. This patch always enables discard functionality on the protocol level so that it's the image format's responsibility to send (or not) discard requests. Requests

[Qemu-devel] [PATCH 4/5] qcow2: Batch discards

2013-06-13 Thread Kevin Wolf
This optimises the discard operation for freed clusters by batching discard requests (both snapshot deletion and bdrv_discard end up updating the refcounts cluster by cluster). Note that we don't discard asynchronously, but keep s-lock held. This is to avoid that a freed cluster is reallocated

[Qemu-devel] [PATCH 2/5] qcow2: Add refcount update reason to all callers

2013-06-13 Thread Kevin Wolf
This adds a refcount update reason to all callers of update_refcounts(), so that a follow-up patch can use this information to decide whether clusters that reach a refcount of 0 should be discarded in the image file. Signed-off-by: Kevin Wolf kw...@redhat.com --- block/qcow2-cluster.c | 16

Re: [Qemu-devel] [PATCH RFC 1/8] exec: Fix Xen RAM allocation with unusual options

2013-06-13 Thread Stefano Stabellini
On Thu, 13 Jun 2013, Markus Armbruster wrote: Issues: * We try to obey -mem-path even though it can't work with Xen. * To implement -machine mem-merge, we call memory_try_enable_merging(new_block-host, size). But with Xen, new_block-host remains null. Oops. Fix by separating Xen

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Anthony Liguori
Markus Armbruster arm...@redhat.com writes: Peter Lieven p...@kamp.de writes: On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all memory resources on system reset and madvise

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Paolo Bonzini
Il 12/06/2013 17:41, Michael Roth ha scritto: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26: http://wiki.qemu.org/Planning/1.5 Please respond here or CC

Re: [Qemu-devel] [RFC] sanitize memory on system reset

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 07:56, Anthony Liguori ha scritto: Markus Armbruster arm...@redhat.com writes: Peter Lieven p...@kamp.de writes: On 13.06.2013 10:40, Stefan Hajnoczi wrote: On Thu, Jun 13, 2013 at 08:09:09AM +0200, Peter Lieven wrote: I was thinking if it would be a good idea to zeroize all

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Paolo Bonzini
Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool ps2_keyboard_repeatstate_needed(void *opaque) {

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Andreas Färber
Am 13.06.2013 14:27, schrieb Paolo Bonzini: Il 12/06/2013 17:41, Michael Roth ha scritto: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26:

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Frederic Konrad
On 12/06/2013 23:41, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26: http://wiki.qemu.org/Planning/1.5 Please respond here or CC

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Frederic Konrad
On 12/06/2013 23:41, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26: http://wiki.qemu.org/Planning/1.5 Please respond here or CC

Re: [Qemu-devel] fdisk still shows the /dev/sdb partitions even after the removal of scsi disk

2013-06-13 Thread Laszlo Ersek
On 06/13/13 12:19, chandrashekar shastri wrote: Hi, I have filed a bug fdisk still shows the /dev/sdb partitions even after the removal of scsi disk for the upstream kernel. Bug link: https://bugs.launchpad.net/qemu/+bug/1190525 RHEL guest shows the partittions even after the removal

Re: [Qemu-devel] [PATCH 2/2] Add monitor command mem-nodes

2013-06-13 Thread Eduardo Habkost
On Thu, Jun 13, 2013 at 09:40:14AM +0800, Wanlong Gao wrote: On 06/11/2013 09:40 PM, Eduardo Habkost wrote: On Tue, Jun 11, 2013 at 03:22:13PM +0800, Wanlong Gao wrote: On 06/05/2013 09:46 PM, Eduardo Habkost wrote: On Wed, Jun 05, 2013 at 11:58:25AM +0800, Wanlong Gao wrote: Add monitor

[Qemu-devel] [PATCH] target-arm: Make LPAE feature imply V7MP

2013-06-13 Thread Peter Maydell
The v7 ARM ARM specifies that the Large Physical Address Extension requires implementation of the Multiprocessing Extensions, so make our LPAE feature imply V7MP rather than specifying both in the A15 CPU initfn. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Doesn't make much

Re: [Qemu-devel] [PATCH 1/3] target-arm: add feature flag for ARMv8

2013-06-13 Thread Peter Maydell
On 7 June 2013 13:06, Mans Rullgard m...@mansr.com wrote: Signed-off-by: Mans Rullgard m...@mansr.com --- target-arm/cpu.c | 5 - target-arm/cpu.h | 1 + target-arm/translate.c | 1 + 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/target-arm/cpu.c

[Qemu-devel] [PATCH] exec: move io_mem_read/write to memory.h

2013-06-13 Thread Michael S. Tsirkin
implementation is in memory.c, move function to match. This allows use from places that don't pull in exec-all.h Signed-off-by: Michael S. Tsirkin m...@redhat.com --- include/exec/exec-all.h | 5 - include/exec/memory.h | 5 + 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

2013-06-13 Thread Peter Maydell
On 7 June 2013 13:06, Mans Rullgard m...@mansr.com wrote: The ARMv8 SEVL instruction is in the architectural hint space already emulated as nop. This makes the decoding of SEVL explicit for clarity. Signed-off-by: Mans Rullgard m...@mansr.com Reviewed-by: Peter Maydell

Re: [Qemu-devel] [PATCH] target-arm: Make LPAE feature imply V7MP

2013-06-13 Thread Andreas Färber
Am 13.06.2013 14:51, schrieb Peter Maydell: The v7 ARM ARM specifies that the Large Physical Address Extension requires implementation of the Multiprocessing Extensions, so make our LPAE feature imply V7MP rather than specifying both in the A15 CPU initfn. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH v2 1/2] ps2: add support of auto-repeat

2013-06-13 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 13/06/2013 06:19, Andreas Färber ha scritto: Am 31.05.2013 14:31, schrieb Amos Kong: diff --git a/hw/input/ps2.c b/hw/input/ps2.c index cdb18e6..fdb9912 100644 --- a/hw/input/ps2.c +++ b/hw/input/ps2.c @@ -615,7 +615,17 @@ static bool

Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

2013-06-13 Thread Andreas Färber
Am 07.06.2013 14:06, schrieb Mans Rullgard: The ARMv8 SEVL instruction is in the architectural hint space already emulated as nop. This makes the decoding of SEVL explicit for clarity. Signed-off-by: Mans Rullgard m...@mansr.com --- target-arm/translate.c | 1 + 1 file changed, 1

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Andreas Färber
Am 13.06.2013 14:44, schrieb Frederic Konrad: On 12/06/2013 23:41, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for 2013-06-26:

[Qemu-devel] [PATCH v2] target-arm: add feature flag for ARMv8

2013-06-13 Thread Mans Rullgard
Signed-off-by: Mans Rullgard m...@mansr.com --- Make V8 imply ARM_DIV and LPAE. --- target-arm/cpu.c | 7 ++- target-arm/cpu.h | 1 + target-arm/translate.c | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/target-arm/cpu.c b/target-arm/cpu.c index

Re: [Qemu-devel] Patch Round-up for stable 1.5.1, freeze on 2013-06-19

2013-06-13 Thread Frederic Konrad
On 13/06/2013 15:21, Andreas Färber wrote: Am 13.06.2013 14:44, schrieb Frederic Konrad: On 12/06/2013 23:41, Michael Roth wrote: Hi everyone, The following new patches are queued for QEMU stable v1.5.1: https://github.com/mdroth/qemu/commits/stable-1.5-staging The release is planned for

Re: [Qemu-devel] [PATCH 3/3] target-arm: explicitly decode SEVL instruction

2013-06-13 Thread Måns Rullgård
Andreas Färber afaer...@suse.de writes: Am 07.06.2013 14:06, schrieb Mans Rullgard: The ARMv8 SEVL instruction is in the architectural hint space already emulated as nop. This makes the decoding of SEVL explicit for clarity. Signed-off-by: Mans Rullgard m...@mansr.com ---

  1   2   >