[Qemu-devel] [PATCH v5 00/11] qemu-ga: fsfreeze on Windows using VSS

2013-07-03 Thread Tomoki Sekiyama
Hi, This is v5 of patch series to add fsfreeze for Windows qemu-guest-agent. changes from v4: -[03/11] Suppress warning about spacing arond 'catch' keyword in C++ -[06/11] Rename qga-prv-obj-y to qga-provider-obj-y -[06/11] Rework reference counting for CQGAVssProviderFactory -[07/11 (newly a

[Qemu-devel] [PATCH v5 11/11] QMP/qemu-ga-client: Make timeout longer for guest-fsfreeze-freeze command

2013-07-03 Thread Tomoki Sekiyama
guest-fsfreeze-freeze command can take longer than 3 seconds when heavy disk I/O is running. To avoid unexpected timeout, this changes the timeout to 60 seconds (timeout of pre-commit phase of VSS). Signed-off-by: Tomoki Sekiyama Reviewed-by: Paolo Bonzini Reviewed-by: Laszlo Ersek --- QMP/qem

Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto: > -return ga_install_service(path, log_filepath, > fixed_state_dir); > +if (ga_install_vss_provider()) { > +return EXIT_FAILURE; > +} > +if (ga_install_service(path,

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Anthony Liguori
Kevin Wolf writes: > Am 02.07.2013 um 19:06 hat Anthony Liguori geschrieben: >> Eric Blake writes: >> > On 07/02/2013 08:51 AM, Anthony Liguori wrote: >> >> Amos Kong writes: >> >> >> >>> Introduces new monitor command to query QMP schema information, >> >>> the return data is a nested dict/li

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Anthony Liguori
Paolo Bonzini writes: > Il 03/07/2013 14:54, Anthony Liguori ha scritto: >>> So, qapi-schema.json has to be readable/writable _mostly_ by humans. >>> That it is valid JSON is little more than a curious accident, because >> >> I can assure you that it wasn't an accident. > > Sure, it is not. But

Re: [Qemu-devel] [PATCH] monitor: Fix 'mouse_button': do not move mouse

2013-07-03 Thread Andreas Färber
Am 03.07.2013 14:50, schrieb Eugene Shatokhin: > If absolute positions are used, 'mouse_button' command moved mouse > pointer to (0, 0) before generating a mouse button event. The event was > therefore generated at incorrect position. > > This problem is now fixed. > > Signed-off-by: Eugene Shato

Re: [Qemu-devel] [Bug 1187529] [PATCH] Update mappings after PCI bridge live migration or save-restore.

2013-07-03 Thread Andreas Färber
Am 03.07.2013 17:04, schrieb Don Koch: > From: Don Koch > > Update mappings for PCI bridge after live migration. > > Signed-off-by: Don Koch > --- > This fixes bug 1187529: devices on a PCI bridge stop working after migration. Feel free to reference this as LP#1187529 in the commit message if

[Qemu-devel] [PATCH v5 09/11] qemu-ga: Call Windows VSS requester in fsfreeze command handler

2013-07-03 Thread Tomoki Sekiyama
Support guest-fsfreeze-freeze and guest-fsfreeze-thaw commands for Windows guests. When fsfreeze command is issued, it calls the VSS requester to freeze filesystems and applications. On thaw command, it again tells the VSS requester to thaw them. This also adds calling of initialize functions for

Re: [Qemu-devel] [PATCH v5 10/11] qemu-ga: Install Windows VSS provider on `qemu-ga -s install'

2013-07-03 Thread Tomoki Sekiyama
On 7/3/13 11:58 , "Paolo Bonzini" wrote: >Il 03/07/2013 17:49, Tomoki Sekiyama ha scritto: >> -return ga_install_service(path, log_filepath, >>fixed_state_dir); >> +if (ga_install_vss_provider()) { >> +return EXIT_FAILURE; >> +}

[Qemu-devel] [PATCH v3 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Michael Tokarev
From: Paolo Bonzini With mon:stdio you can exit the VM by switching to the monitor and sending the "quit" command. It is then useful to pass Ctrl-C to the VM instead of exiting. This in turn lets us stop tying the default signal handling behavior to -nographic, removing gratuitous differences b

[Qemu-devel] [PATCH v3 2/2] display: stop using DT_NOGRAPHIC, use DT_NONE

2013-07-03 Thread Michael Tokarev
It looks like initially there was -nographic option to turn off display, now there's another option of the same sort, -display none. But code in other places of qemu checks for DT_NOGRAPHIC and does not work well with -display none. Make DT_NOGRAPHIC an internal version which selects DT_NONE, and

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-03 Thread Andreas Färber
Am 03.07.2013 03:23, schrieb liu ping fan: > On Wed, Jul 3, 2013 at 12:36 AM, Anthony Liguori > wrote: >> Paolo Bonzini writes: >> >>> Il 02/07/2013 16:47, Anthony Liguori ha scritto: Jan Kiszka writes: > Objects can soon be referenced/dereference outside the BQL. So we need >

Re: [Qemu-devel] [PATCH] Xen PV Device

2013-07-03 Thread Stefano Stabellini
On Wed, 3 Jul 2013, Paul Durrant wrote: > This patch introduces a new Xen PV PCI device which will act as a new > binding point for PV drivers for Xen. > The device has parameterized vendor-id, device-id and revision to allow to > be configured as a binding point for any vendor's PV drivers. > > S

Re: [Qemu-devel] [PATCH v2 1/9] tcg: Split rem requirement from div requirement

2013-07-03 Thread Richard Henderson
On 07/03/2013 02:07 AM, Claudio Fontana wrote: > The list of TCG targets updated is incomplete: at least for aarch64, the > patchset breaks compilation because of missing definitions for > TCG_TARGET_HAS_rem_i32 and TCG_TARGET_HAS_rem_i64. Oops. Sloppy merging, that, failing to add aarch64. Fixe

Re: [Qemu-devel] [PATCH V1 1/2] Implement sync modes for drive-backup.

2013-07-03 Thread Ian Main
On Mon, Jul 01, 2013 at 02:16:12PM +0200, Paolo Bonzini wrote: > Il 28/06/2013 04:28, Ian Main ha scritto: > > This patch adds sync-modes to the drive-backup interface and > > implements the FULL, NONE and TOP modes of synchronization. > > > > FULL performs as before copying the entire contents of

[Qemu-devel] [PATCH qom-cpu 0/3] target-i386: log_cpu_state() cleanups

2013-07-03 Thread Andreas Färber
Hello, As a follow-up to my CPUState part 11 series changing log_cpu_state[_mask]() argument to CPUState, these patches propagate X86CPU argument where possible. This is in response to rth asking about type/placement of variables. I note that x86 had me confused in two other places where TCG help

[Qemu-devel] [PATCH qom-cpu 1/3] target-i386: Change LOG_PCALL_STATE() argument to CPUState

2013-07-03 Thread Andreas Färber
Since log_cpu_state_mask() argument was changed to CPUState, CPUArchState is no longer needed. Choose CPUState rather than X86CPU to not hide type mismatches with CPU(). Signed-off-by: Andreas Färber --- target-i386/seg_helper.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

[Qemu-devel] [PATCH qom-cpu 2/3] target-i386: Change do_interrupt_all() argument to X86CPU

2013-07-03 Thread Andreas Färber
log_cpu_state() needs CPUState. Signed-off-by: Andreas Färber --- target-i386/seg_helper.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target-i386/seg_helper.c b/target-i386/seg_helper.c index e0552d0..e789102 100644 --- a/target-i386/seg_helper.c +++ b/target-i3

[Qemu-devel] [PATCH qom-cpu 3/3] target-i386: Change do_smm_enter() argument to X86CPU

2013-07-03 Thread Andreas Färber
log_cpu_state_mask() needs CPUState. Signed-off-by: Andreas Färber --- cpu-exec.c | 2 +- target-i386/cpu.h| 2 +- target-i386/smm_helper.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/cpu-exec.c b/cpu-exec.c index 9c46846..6c784a7 100644 --- a

Re: [Qemu-devel] [PATCH] monitor: Fix 'mouse_button': do not move mouse

2013-07-03 Thread Eugene Shatokhin
Ah, I see it now. Thanks for the link, I should have found that thread earlier. Indeed, there can be several mice and keeping the position in global variables is a bad idea here. Will test your patches when you update them. Our automated testing system at ROSA Laboratory is quite similar to o

[Qemu-devel] [PATCH] spapr: Respect -bios command line option for SLOF

2013-07-03 Thread Andreas Färber
Allow the user to override the firmware file name rather than always using "slof.bin". Reported-by: Dinar Valeev Cc: Alexey Kardashevskiy Signed-off-by: Andreas Färber --- hw/ppc/spapr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c ind

Re: [Qemu-devel] [PATCH] spapr: Respect -bios command line option for SLOF

2013-07-03 Thread Alexander Graf
On 03.07.2013, at 21:26, Andreas Färber wrote: > Allow the user to override the firmware file name rather than always > using "slof.bin". > > Reported-by: Dinar Valeev > Cc: Alexey Kardashevskiy > Signed-off-by: Andreas Färber Thanks, applied to ppc-next. Alex > --- > hw/ppc/spapr.c | 5 +

Re: [Qemu-devel] [PATCH v2 3/4] ide: Set BSY bit during FLUSH

2013-07-03 Thread Alex Williamson
On Wed, 2013-06-05 at 15:17 +0200, Kevin Wolf wrote: > From: Andreas Färber > > The implementation of the ATA FLUSH command invokes a flush at the block > layer, which may on raw files on POSIX entail a synchronous fdatasync(). > This may in some cases take so long that the SLES 11 SP1 guest driv

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-07-03 Thread Alex Williamson
On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > From: Andreas Färber > > The implementation of the ATA FLUSH command invokes a flush at the block > layer, which may on raw files on POSIX entail a synchronous fdatasync(). > This may in some cases take so long that the SLES 11 SP1 guest dr

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-07-03 Thread Michael Roth
On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson wrote: > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: >> From: Andreas Färber >> >> The implementation of the ATA FLUSH command invokes a flush at the block >> layer, which may on raw files on POSIX entail a synchronous fdatasync(). >> Thi

[Qemu-devel] APM regression since v1.3.0-408-g9ee59f3

2013-07-03 Thread Sebastian Herbszt
Commit 9ee59f3 ("pc: remove bochs bios debug ports") broke the APM interface between QEMU and Bochs BIOS/SeaBIOS. Without APM support older guests are no longer able to power off the VM. This regression also affects older machine types like pc-1.2. Sebastian

Re: [Qemu-devel] [PATCH 10/17] block: define get_block_status return value

2013-07-03 Thread Peter Lieven
Am 03.07.2013 um 16:34 schrieb Paolo Bonzini : > Define the return value of get_block_status. Bits 0, 1, 2 and 8-62 > are valid; bit 63 (the sign bit) is reserved for errors. Bits 3-7 > are left for future extensions. Is Bit 8 not also reserved for future use? BDRV_SECTOR_BITS is 9. Can you e

Re: [Qemu-devel] moving CHR_EVENT_OPEN out of BH broke echo for muxed mon

2013-07-03 Thread Michael Roth
On Wed, Jul 3, 2013 at 1:03 AM, Michael Tokarev wrote: > Before > > commit bd5c51ee6c4f1c79cae5ad2516d711a27b4ea8ec > Author: Michael Roth > Date: Fri Jun 7 15:19:53 2013 -0500 > > qemu-char: don't issue CHR_EVENT_OPEN in a BH > > we had no echo by default with -nographic, and it gave > the

Re: [Qemu-devel] [PATCHv2 02/11] iscsi: read unmap info from block limits vpd page

2013-07-03 Thread Peter Lieven
Am 03.07.2013 um 05:43 schrieb ronnie sahlberg : > max_unmap : > > If the target does not return an explicit limit for max_unmap it will > return 0x which means "no limit". > thanks for the remark. i wasn't aware. > I think you should add a check for max_unmap and clamp it down to > s

[Qemu-devel] [PATCH v3 01/14] tcg: Add myself to general TCG maintainership

2013-07-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index ad9c860..7847e60 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -772,6 +772,7 @@ Tiny Code Generator (TCG) - Common code M: qemu-devel@non

[Qemu-devel] [PATCH v3 00/14] tcg: remainder and tcg-arm updates

2013-07-03 Thread Richard Henderson
Changes v2-v3: * Add myself to tcg maintainers, as per afaerber's suggestion. * Fix rebase error wrt aarch64, as per claudio. * Include tcg-arm unwind patch set; no point in half measures. r~ The following changes since commit ab8bf29078e0ab8347e2ff8b4e5542f7a0c751cf: Merge remote-trac

[Qemu-devel] [PATCH v3 03/14] tcg-arm: Don't implement rem

2013-07-03 Thread Richard Henderson
Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 14 -- tcg/arm/tcg-target.h | 3 +-- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 6be736b..8321f80 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-targe

[Qemu-devel] [PATCH v3 02/14] tcg: Split rem requirement from div requirement

2013-07-03 Thread Richard Henderson
There are several hosts with only a "div" insn. Remainder is computed manually from the quotient and inputs. We can do this generically. Signed-off-by: Richard Henderson --- tcg/aarch64/tcg-target.h | 2 ++ tcg/arm/tcg-target.h | 2 ++ tcg/hppa/tcg-target.h| 1 + tcg/ia64/tcg-target

[Qemu-devel] [PATCH v3 09/14] tcg-arm: Simplify logic in detecting the ARM ISA in use

2013-07-03 Thread Richard Henderson
GCC 4.8 defines a handy __ARM_ARCH symbol that we can use, which will make us nicely forward compatible with ARMv8 AArch32. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 62 +--- 1 file changed, 20 insertions(+), 42 deletions(-) diff

[Qemu-devel] [PATCH v3 05/14] tcg-ppc64: Don't implement rem

2013-07-03 Thread Richard Henderson
Reviewed-by: Andreas Färber Signed-off-by: Richard Henderson --- tcg/ppc64/tcg-target.c | 26 -- tcg/ppc64/tcg-target.h | 4 ++-- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/tcg/ppc64/tcg-target.c b/tcg/ppc64/tcg-target.c index 606b73d..0678de2 100644

[Qemu-devel] [PATCH v3 04/14] tcg-ppc: Don't implement rem

2013-07-03 Thread Richard Henderson
Reviewed-by: Andreas Färber Signed-off-by: Richard Henderson --- tcg/ppc/tcg-target.c | 14 -- tcg/ppc/tcg-target.h | 2 +- 2 files changed, 1 insertion(+), 15 deletions(-) diff --git a/tcg/ppc/tcg-target.c b/tcg/ppc/tcg-target.c index 29ca934..453ab6b 100644 --- a/tcg/ppc/tcg-targ

[Qemu-devel] [PATCH v3 07/14] tcg: Simplify logic using TCG_OPF_NOT_PRESENT

2013-07-03 Thread Richard Henderson
Expand the definition of "not present" to include "should not be present". This means we can simplify the logic surrounding the generic tcg opcodes for which the host backend ought not be providing definitions. Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 26 +++--- t

[Qemu-devel] [PATCH v3 06/14] tcg: Allow non-constant control macros

2013-07-03 Thread Richard Henderson
This allows TCG_TARGET_HAS_* to be a variable rather than a constant, which allows easier support for differing ISA levels for the host. Signed-off-by: Richard Henderson --- tcg/tcg-opc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 1296

[Qemu-devel] [PATCH v3 11/14] tcg: Fix high_pc fields in .debug_info

2013-07-03 Thread Richard Henderson
I don't think the debugger actually looks at this for anything, using the correct .debug_frame contents, but might as well get it all correct. Signed-off-by: Richard Henderson --- tcg/tcg.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tcg/tcg.c b/tcg/tcg.c index c7e656

[Qemu-devel] [PATCH v3 12/14] tcg: Move the CIE and FDE header definitions to common code

2013-07-03 Thread Richard Henderson
These will necessarily be the same layout for all hosts. This limits the amount of boilerplate required to implement jit debug for a host. Signed-off-by: Richard Henderson --- tcg/hppa/tcg-target.c | 35 ++- tcg/i386/tcg-target.c | 39 +-

[Qemu-devel] [PATCH v3 08/14] tcg-arm: Make use of conditional availability of opcodes for divide

2013-07-03 Thread Richard Henderson
We can now detect and use divide instructions at runtime, rather than having to restrict their availability to compile-time. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 16 ++-- tcg/arm/tcg-target.h | 14 -- 2 files changed, 22 insertions(+), 8 deletions(-

[Qemu-devel] [PATCH v3 13/14] tcg-i386: Use QEMU_BUILD_BUG_ON instead of assert for frame size

2013-07-03 Thread Richard Henderson
We can check the condition at compile time, rather than run time. Reviewed-by: Andreas Färber Signed-off-by: Richard Henderson --- tcg/i386/tcg-target.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index ae3de09..87eeab3

[Qemu-devel] [PATCH v3 10/14] tcg-arm: Use AT_PLATFORM to detect the host ISA

2013-07-03 Thread Richard Henderson
With this we can generate armv7 insns even when the OS compiles for a lower common denominator. The macros are arranged so that when we do compile for a given ISA, all of the runtime checks for that ISA are optimized away. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 22 +

[Qemu-devel] [PATCH v3 14/14] tcg-arm: Implement tcg_register_jit

2013-07-03 Thread Richard Henderson
Allows unwinding past the code_gen_buffer. Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 76 +--- 1 file changed, 67 insertions(+), 9 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index a46d2e0..f87464e 100644

Re: [Qemu-devel] [PATCH 12/23] ide: Convert FLUSH CACHE to ide_cmd_table handler

2013-07-03 Thread Alex Williamson
On Mon, 2013-06-24 at 11:10 +0200, Stefan Hajnoczi wrote: > From: Kevin Wolf > > Signed-off-by: Kevin Wolf > Signed-off-by: Stefan Hajnoczi > --- > hw/ide/core.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/hw/ide/core.c b/hw/ide/core.c > index 87897

Re: [Qemu-devel] [PATCH 12/23] ide: Convert FLUSH CACHE to ide_cmd_table handler

2013-07-03 Thread Alex Williamson
On Wed, 2013-07-03 at 15:41 -0600, Alex Williamson wrote: > On Mon, 2013-06-24 at 11:10 +0200, Stefan Hajnoczi wrote: > > From: Kevin Wolf > > > > Signed-off-by: Kevin Wolf > > Signed-off-by: Stefan Hajnoczi > > --- > > hw/ide/core.c | 14 -- > > 1 file changed, 8 insertions(+), 6

Re: [Qemu-devel] [PATCH 09/26] ide: Set BSY bit during FLUSH

2013-07-03 Thread Alex Williamson
On Wed, 2013-07-03 at 15:16 -0500, Michael Roth wrote: > On Wed, Jul 3, 2013 at 3:10 PM, Alex Williamson > wrote: > > On Wed, 2013-06-12 at 16:41 -0500, Michael Roth wrote: > >> From: Andreas Färber > >> > >> The implementation of the ATA FLUSH command invokes a flush at the block > >> layer, whi

Re: [Qemu-devel] [PATCH V3 00/10] Add support for binding guest numa nodes to host numa nodes

2013-07-03 Thread Wanlong Gao
Hi, who can pick this set up? Thanks, Wanlong Gao > As you know, QEMU can't direct it's memory allocation now, this may cause > guest cross node access performance regression. > And, the worse thing is that if PCI-passthrough is used, > direct-attached-device uses DMA transfer between device and

Re: [Qemu-devel] help me for nahanni device

2013-07-03 Thread DAI Weibin
Hello Cam, I try with QEMU version “qemu-1.5.1”, and attach three Nahanni devices. I am very glad that it is ok. We may not use the most recent version, can you tell me which qemu version or later supports multi Nahanni devices? Thank you. Best Regards weibin From: c...@ualberta.ca [mailto:c...

Re: [Qemu-devel] [PATCH 01/17] cow: make reads go at a decent speed

2013-07-03 Thread Fam Zheng
On Wed, 07/03 16:34, Paolo Bonzini wrote: > Do not do two reads for each sector; load each sector of the bitmap > and use bitmap operations to process it. > > Writes are still dog slow! > > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 54 ---

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-03 Thread Alexey Kardashevskiy
Alex, Anthony, ping? Do I need to post rebased version? I know there is something to fix for migration (Anthony mentioned once) but what? Thanks. On 06/27/2013 04:45 PM, Alexey Kardashevskiy wrote: > This series spent quite a lot of time waiting when David's PCI series > reaches the upstream but

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-03 Thread Anthony Liguori
On Wed, Jul 3, 2013 at 9:31 PM, Alexey Kardashevskiy wrote: > Alex, Anthony, ping? Do I need to post rebased version? I know there is > something to fix for migration (Anthony mentioned once) but what? Thanks. You need to rework the XICS patches no? You're also missing save/restore support for V

Re: [Qemu-devel] [PATCH v3 2/7] net: distinguish & defer nested call to BH

2013-07-03 Thread liu ping fan
On Thu, Jun 27, 2013 at 11:38 AM, Liu Ping Fan wrote: > When network layer can run on multi-thread, nested call caused by > nc->receive() will raise issue like deadlock. So postpone it to BH. > We distinguish nested call "A->B->A" from parallel call "A->B, B->A" > by using tls variable net_enter.

Re: [Qemu-devel] [PATCH 02/17] cow: make writes go at a less indecent speed

2013-07-03 Thread Fam Zheng
On Wed, 07/03 16:34, Paolo Bonzini wrote: > Only sync once per write, rather than once per sector. > > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 19 --- > 1 file changed, 16 insertions(+), 3 deletions(-) > > diff --git a/block/cow.c b/block/cow.c > index 204451e..133e59

Re: [Qemu-devel] [PATCH 00/17 v3] spapr: migration, pci, msi, power8

2013-07-03 Thread Alexey Kardashevskiy
On 07/04/2013 12:40 PM, Anthony Liguori wrote: > On Wed, Jul 3, 2013 at 9:31 PM, Alexey Kardashevskiy wrote: >> Alex, Anthony, ping? Do I need to post rebased version? I know there is >> something to fix for migration (Anthony mentioned once) but what? Thanks. > > You need to rework the XICS patc

Re: [Qemu-devel] [PATCH v3 5/7] net: introduce lock to protect net clients

2013-07-03 Thread liu ping fan
On Thu, Jun 27, 2013 at 11:38 AM, Liu Ping Fan wrote: Append commit log: NetClientStates come and go into the net_clients in parallel. So use lock to protect it. Stefanha, I will add lock in net_cleanup() as discussed in another thread. Regards, Pingfan > Signed-off-by: Liu Ping Fan > --- >

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Seiji Aguchi
> Patches need to make sense today, please do not add extra code with > potential future use in mind: > > 1. Other developers must be able to read and modify the current codebase >on its own. They do not know what potential future changes you were >thinking about. > > 2. You may never en

Re: [Qemu-devel] [PATCH v5] Add timestamp to error_report()

2013-07-03 Thread Seiji Aguchi
> -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@gmail.com] > Sent: Wednesday, July 03, 2013 5:14 AM > To: Seiji Aguchi > Cc: qemu-devel@nongnu.org; aligu...@us.ibm.com; berra...@redhat.com; > kw...@redhat.com; mtosa...@redhat.com; > arm...@redhat.com; Tomoki Sekiyama; pbonz

[Qemu-devel] [PATCH v6] add timestamp to error_report()

2013-07-03 Thread Seiji Aguchi
[Issue] When we offer a customer support service and a problem happens in a customer's system, we try to understand the problem by comparing what the customer reports with message logs of the customer's system. In this case, we often need to know when the problem happens. But, currently, there is

Re: [Qemu-devel] [PATCH 11/17] block: return get_block_status data and flags for formats

2013-07-03 Thread Fam Zheng
On Wed, 07/03 16:34, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > block/cow.c | 8 +++- > block/qcow.c | 9 - > block/qcow2.c| 16 ++-- > block/qed.c | 35 --- > block/sheepdog.c | 2 +- > block/vdi.c

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-07-03 Thread Sam Stoelinga
*** This bug is a duplicate of bug 1033727 *** https://bugs.launchpad.net/bugs/1033727 This maybe not a duplicate as we're using 1.3.1 and Windows 7 isn't working there either. All other Operating systems are working though. @Wessel: I believe the bug you pointed out as duplicate is saying th

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-03 Thread Amos Kong
On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: > Amos Kong writes: > > > On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: > >> Amos Kong writes: > [...] > >> >> This interface is abstract in the sense that it applies to all NICs. At > >> >> this time, it's

Re: [Qemu-devel] [PATCH] full introspection support for QMP

2013-07-03 Thread Amos Kong
On Tue, Jul 02, 2013 at 01:27:32PM -0500, Anthony Liguori wrote: > Eric Blake writes: > > > On 07/02/2013 11:01 AM, Paolo Bonzini wrote: > Arguably that rule of thumb would apply equally to the QEMU > build scripts which already parse qapi-schema.json. It could > be possible to nor

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-03 Thread liu ping fan
On Thu, Jul 4, 2013 at 12:36 AM, Andreas Färber wrote: > Am 03.07.2013 03:23, schrieb liu ping fan: >> On Wed, Jul 3, 2013 at 12:36 AM, Anthony Liguori >> wrote: >>> Paolo Bonzini writes: >>> Il 02/07/2013 16:47, Anthony Liguori ha scritto: > Jan Kiszka writes: > >> Objects ca

Re: [Qemu-devel] [PATCH] fsdev: Fix potential memory leak

2013-07-03 Thread M. Mohan Kumar
Stefan Weil writes: > This leak was reported by cppcheck. > > Signed-off-by: Stefan Weil Reviewed-by: M. Mohan Kumar > --- > fsdev/qemu-fsdev.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fsdev/qemu-fsdev.c b/fsdev/qemu-fsdev.c > index 6eaf36d..ccfec13 100644 > --- a/fsdev/q

Re: [Qemu-devel] [PATCH V3 08/10] NUMA: add qmp command set-mpol to set memory policy for NUMA node

2013-07-03 Thread Andreas Färber
Am 24.06.2013 09:12, schrieb Wanlong Gao: > The QMP command let it be able to set node's memory policy > through the QMP protocol. The qmp-shell command is like: > set-mpol nodeid=0 mem-policy=membind mem-hostnode=0-1 > > Signed-off-by: Wanlong Gao Can we make that a little more self-documen

Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-07-03 Thread liu ping fan
On Mon, Jul 1, 2013 at 9:20 PM, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 01/07/2013 15:00, Anthony Liguori ha scritto: I > cannot find the commit exactly, but I think mst added specific code for > that. >>> Right, I'm not questioning whether these functions have stron

Re: [Qemu-devel] [PATCH 12/17] qemu-img: add a "map" subcommand

2013-07-03 Thread Fam Zheng
On Wed, 07/03 16:34, Paolo Bonzini wrote: > This command dumps the metadata of an entire chain, in either tabular or JSON > format. > > Signed-off-by: Paolo Bonzini > --- > qemu-img-cmds.hx | 6 ++ > qemu-img.c | 186 > +++ > 2 files c

Re: [Qemu-devel] [PATCH] qom: Use atomics for object refcounting

2013-07-03 Thread Andreas Färber
Am 04.07.2013 06:46, schrieb liu ping fan: > On Thu, Jul 4, 2013 at 12:36 AM, Andreas Färber wrote: >> Am 03.07.2013 03:23, schrieb liu ping fan: >>> On Wed, Jul 3, 2013 at 12:36 AM, Anthony Liguori >>> wrote: Paolo Bonzini writes: > I'm not a big fan of kref (it seems _too_ thin

Re: [Qemu-devel] [PATCH 16/17] ppc64: Enable QEMU to run on POWER 8 DD1 chip.

2013-07-03 Thread Andreas Färber
Am 27.06.2013 08:45, schrieb Alexey Kardashevskiy: > From: Prerna Saxena > > This patch enables QEMU to launch VM guests on POWER8 chip. I have tested > this to work with BML kernel on P8 dd1 chip. > > Signed-off-by: Prerna Saxena > Signed-off-by: Alexey Kardashevskiy > Reviewed-by: Paul Macke

[Qemu-devel] 回复: Re: 回复: Re: Which part of qemu responds to ACPI control method?

2013-07-03 Thread bobooscar
Thank you laszlo. however, after I got DSDT.dsl, I found that there is no “_PTS” method, even if “_TTS” “_GTS”.   Then I go through all the acpi tables, still found no PTS/TTS methods:     acpidump > acpidump.out     acpixtract -a acpidump.out     for file in `ls |grep dat`; do iasl -a $file; done

Re: [Qemu-devel] [PATCH v3 2/2] net: introduce command to query rx-filter information

2013-07-03 Thread Markus Armbruster
Amos Kong writes: > On Tue, Jul 02, 2013 at 03:27:12PM +0200, Markus Armbruster wrote: >> Amos Kong writes: >> >> > On Tue, Jul 02, 2013 at 11:05:56AM +0200, Markus Armbruster wrote: >> >> Amos Kong writes: >> [...] >> >> >> This interface is abstract in the sense that it applies to all NICs.

Re: [Qemu-devel] [PATCH 3/4] qemu-char: Register ring buffer driver with correct name "ringbuf"

2013-07-03 Thread Markus Armbruster
Luiz Capitulino writes: > On Thu, 27 Jun 2013 16:22:09 +0200 > Markus Armbruster wrote: > >> The driver is new in 1.4, with the documented name "ringbuf". >> However, it's actual name is the completely undocumented "memory". >> Screwed up in commit 3949e59. Fix code to match documentation. >>

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/17] ppc64: Enable QEMU to run on POWER 8 DD1 chip.

2013-07-03 Thread Benjamin Herrenschmidt
On Thu, 2013-07-04 at 07:54 +0200, Andreas Färber wrote: > Am 27.06.2013 08:45, schrieb Alexey Kardashevskiy: > > From: Prerna Saxena > > > > This patch enables QEMU to launch VM guests on POWER8 chip. I have tested > > this to work with BML kernel on P8 dd1 chip. > > > > Signed-off-by: Prerna S

Re: [Qemu-devel] meaningless to compare irqfd's msi message with new msi message in virtio_pci_vq_vector_unmask

2013-07-03 Thread Zhanghaoyu (A)
> I searched "vector_irqfd" globally, no place found to set/change irqfd's msi > message, only irqfd's virq or users member may be changed in > kvm_virtio_pci_vq_vector_use, kvm_virtio_pci_vq_vector_release, etc. > So I think it's meaningless to do below check in virtio_pci_vq_vector_unmask, >

Re: [Qemu-devel] [PATCH 04/30] add a header file for atomic operations

2013-07-03 Thread liu ping fan
On Wed, Jul 3, 2013 at 1:59 PM, Paolo Bonzini wrote: > Il 03/07/2013 04:24, liu ping fan ha scritto: >>> > +- atomic operations in Linux are always on a 32-bit int type and >> 32-bit? int should be the integer type that the target processor is >> most efficient working with. > > Has Linux ever be

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:44, Michael Tokarev ha scritto: > V2: added code comments and documentation fixes by mjt > (hopefully the s-o-b stands still) Yes, s-o-b means I effectively donate the patch to the community. Paolo

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:44, Michael Tokarev ha scritto: > From: Paolo Bonzini > > With mon:stdio you can exit the VM by switching to the monitor and > sending the "quit" command. It is then useful to pass Ctrl-C to the > VM instead of exiting. > > This in turn lets us stop tying the default signal han

Re: [Qemu-devel] [PATCH 3/7] nbd: use BDS refcount

2013-07-03 Thread Paolo Bonzini
Il 03/07/2013 08:30, Fam Zheng ha scritto: >> > The close notifier runs when the user invokes a drive_del or eject >> > command from the monitor. The drive_get_ref/drive_put_ref delays the >> > bdrv_delete until after nbd.c has cleaned up all the connections. > But drive_put_ref is called by close

Re: [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-07-03 Thread Stefan Hajnoczi
On Wed, Jul 03, 2013 at 11:41:19AM +0800, liu ping fan wrote: > On Mon, Jul 1, 2013 at 7:50 PM, Stefan Hajnoczi wrote: > > On Thu, Jun 20, 2013 at 05:14:56PM +0800, liu ping fan wrote: > >> On Tue, Jun 18, 2013 at 8:41 PM, Stefan Hajnoczi > >> wrote: > >> > On Thu, Jun 13, 2013 at 05:03:03PM +08

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 04:54:46PM +0200, Kevin Wolf wrote: > Am 02.07.2013 um 16:42 hat Stefan Hajnoczi geschrieben: > > On Thu, Jun 20, 2013 at 04:26:09PM +0200, Benoît Canet wrote: > > > --- > > > docs/specs/qcow2.txt | 42 ++ > > > 1 file changed, 42 i

Re: [Qemu-devel] [PATCH v2 3/6] net: make netclient re-entrant with refcnt

2013-07-03 Thread liu ping fan
On Wed, Jul 3, 2013 at 3:49 PM, Stefan Hajnoczi wrote: > On Wed, Jul 03, 2013 at 11:41:19AM +0800, liu ping fan wrote: >> On Mon, Jul 1, 2013 at 7:50 PM, Stefan Hajnoczi wrote: >> > On Thu, Jun 20, 2013 at 05:14:56PM +0800, liu ping fan wrote: >> >> On Tue, Jun 18, 2013 at 8:41 PM, Stefan Hajnocz

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:stefano.stabell...@eu.citrix.com] > Sent: 02 July 2013 17:42 > To: Paul Durrant > Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [PATCH] Citrix PV Bus device [V3] > > On Tue, 2 Jul 2013, Paul Durrant wro

Re: [Qemu-devel] 回复: Re: Which part of qemu responds to ACPI control method?

2013-07-03 Thread Laszlo Ersek
On 07/03/13 04:14, bobooscar wrote: > Take the method “_PTS” for example, how could I know how it access a > certain hardware, and what hardware it accesses? I am a newbie in this > field, thanks in advance;) In "POSIX-like" guests, you can dump the ACPI tables with the "acpidump" utility (pmtools

Re: [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format

2013-07-03 Thread Qiao Nuohan
On 07/01/2013 07:45 PM, Stefan Hajnoczi wrote: I'm now convinced that kdump is worthwhile, thanks for providing data. It would be nice to see the flattened kdump approach. Hi Stefan and Luiz, Thanks for Stefan's review again! I am starting to implement the function using flatten format. And

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 11:23:56PM +0200, Benoît Canet wrote: > > > +QCOW2 can use one or more instance of a metadata journal. > > > > s/instance/instances/ > > > > Is there a reason to use multiple journals rather than a single journal > > for all entry types? The single journal area avoids see

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Kevin Wolf
Am 02.07.2013 um 23:23 hat Benoît Canet geschrieben: > Also since deduplication will not work on spinning disk I discarded the seek > time factor. Care to explain that in more detail? Why shouldn't it work on spinning disks? Kevin

Re: [Qemu-devel] [PATCH 6/9] vhost-scsi: new device supporting the tcm_vhost Linux kernel module

2013-07-03 Thread Asias He
On Wed, Jul 03, 2013 at 11:23:26AM +0800, Asias He wrote: > On Fri, Jun 21, 2013 at 10:16:48AM +, Libaiqing wrote: > > Hi Asias, > > > > > -Original Message- > > > From: Asias He [mailto:as...@redhat.com] > > > Sent: Thursday, June 20, 2013 5:39 PM > > > To: Libaiqing > > > Cc: Paolo B

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Kevin Wolf
Am 02.07.2013 um 23:26 hat Benoît Canet geschrieben: > > > 2. Byte-granularity means that read-modify-write is necessary to append > > >entries to the journal. Therefore a failure could destroy previously > > >committed entries. > > > > > >Any ideas how existing journals handle this?

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Michael Tokarev
03.07.2013 11:13, Paolo Bonzini wrote: ... >> --- a/qemu-options.hx >> +++ b/qemu-options.hx >> @@ -842,7 +842,8 @@ STEXI >> Normally, QEMU uses SDL to display the VGA output. With this option, >> you can totally disable graphical output so that QEMU is a simple >> command line application. The

Re: [Qemu-devel] [PATCH v3] linux-user: improve target_to_host_sock_type conversion

2013-07-03 Thread Petar Jovanovic
From: Peter Maydell [peter.mayd...@linaro.org] Sent: Tuesday, July 02, 2013 6:34 PM To: Petar Jovanovic Cc: Petar Jovanovic; qemu-devel@nongnu.org; aurel...@aurel32.net; riku.voi...@linaro.org; r...@twiddle.net Subject: Re: [PATCH v3] linux-user: improve t

Re: [Qemu-devel] [RFC V8 01/24] qcow2: Add journal specification.

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 11:23:56PM +0200, Benoît Canet wrote: > >Any ideas how existing journals handle this? By the way, I don't know much about journalling techniques. So I'm asking you these questions so that either you can answer them straight away or because they might warrant a look at

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Michael Tokarev
03.07.2013 12:09, Michael Tokarev wrote: ... > I'll resend a v3 with this change. The first 1/2 patch (trap signals) > and the actual code did not change. ... > @@ -2494,7 +2503,7 @@ listening on port would be: > @item -serial mon:telnet::,server,nowait > @end table > When monitor is m

Re: [Qemu-devel] Wayland support

2013-07-03 Thread Yu, Max A
Thanks Alex! Currently I'm trying to enable Wayland in Tizen Emulator. Tizen Emulator is a clone of QEMU. Tizen can run in it as guest OS. It seems like that spice does not fit this requirement. Thanks, Max -Original Message- From: Alexandre DERUMIER [mailto:aderum...@odiso.com] Sent:

Re: [Qemu-devel] [PATCH v2 1/2] trap signals for "-serial mon:stdio"

2013-07-03 Thread Paolo Bonzini
Just a couple more suggestions. > /mjt > > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -825,7 +825,11 @@ a text mode. Generally only the VGA device models > support text mode. > @item none > Do not display video output. The guest will still see an emulated > graphics card, but its outp

Re: [Qemu-devel] [PATCH v2] semaphore: fix a hangup problem under load on NetBSD hosts.

2013-07-03 Thread Laszlo Ersek
On 07/02/13 18:54, Izumi Tsutsui wrote: > Fix following bugs in "fallback implementation of counting semaphores > with mutex+condvar" added in c166cb72f1676855816340666c3b618beef4b976: > - waiting threads are not restarted properly if more than one threads >are waiting unblock signals in qemu_

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Tue, 2013-07-02 at 19:05 +0100, Stefano Stabellini wrote: > On Tue, 2 Jul 2013, Stefano Stabellini wrote: > > - the new device should have configurable vendor and device ids, so that > > host admins can select which vendor's PV drivers are going to be > > automatically installed on all your Wind

Re: [Qemu-devel] [PATCH v2] block: fix bdrv_flush() ordering in bdrv_close()

2013-07-03 Thread Stefan Hajnoczi
On Tue, Jul 02, 2013 at 03:36:25PM +0200, Stefan Hajnoczi wrote: > Since 80ccf93b we flush the block device during close. The > bdrv_drain_all() call should come before bdrv_flush() to ensure guest > write requests have completed. Otherwise we may miss pending writes > when flushing. > > Call bd

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Paul Durrant
> -Original Message- > From: Ian Campbell > Sent: 03 July 2013 09:29 > To: Stefano Stabellini > Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; > xen-de...@lists.xen.org > Subject: Re: [Xen-devel] [Qemu-devel] [PATCH] Citrix PV Bus device [V3] > > On Tue, 2013-07-0

Re: [Qemu-devel] [Xen-devel] [PATCH] Citrix PV Bus device [V3]

2013-07-03 Thread Ian Campbell
On Wed, 2013-07-03 at 09:34 +0100, Paul Durrant wrote: > > -Original Message- > > From: Ian Campbell > > Sent: 03 July 2013 09:29 > > To: Stefano Stabellini > > Cc: Paolo Bonzini; Paul Durrant; qemu-devel@nongnu.org; Anthony Liguori; > > xen-de...@lists.xen.org > > Subject: Re: [Xen-devel]

  1   2   >