Re: [Qemu-devel] [PATCH v2] block: fix vvfat error path for enable_write_target

2013-07-18 Thread Stefan Hajnoczi
On Wed, Jul 17, 2013 at 05:57:37PM +0800, Fam Zheng wrote: s-qcow and s-qcow_filename are allocated but not freed on error. Fix the possible leaks, remove unnecessary check for bdrv_new(), propagate ret code of bdrv_create() and also the one of enable_write_target(). Signed-off-by: Fam Zheng

Re: [Qemu-devel] [PATCHv3] block-migration: efficiently encode zero blocks

2013-07-18 Thread Peter Lieven
On 18.07.2013 07:03, Stefan Hajnoczi wrote: On Mon, Jul 15, 2013 at 12:55:05PM +0200, Peter Lieven wrote: @@ -114,16 +115,29 @@ static void blk_mig_unlock(void) static void blk_send(QEMUFile *f, BlkMigBlock * blk) { int len; +uint64_t flags = BLK_MIG_FLAG_DEVICE_BLOCK; + +if

Re: [Qemu-devel] [PATCH v8 0/3] Throttle-down guest to help with live migration convergence

2013-07-18 Thread Peter Lieven
Hi all, is it possible that not v8 of this patch got merged? Without checking line-by-line I see at least that this here +# @auto-converge: If enabled, QEMU will automatically throttle down the guest +# to speed up convergence of RAM migration. (since 1.6) +# is missing in

Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 11, 2013 at 02:16:17PM +0200, Peter Lieven wrote: this series adds logical block provisioning functions to the iscsi layer. it also is the first step to the change of migration to coroutines in block/iscsi. the changes to qemu-img and block migration have been split and will

Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.

2013-07-18 Thread Fam Zheng
On Wed, 07/17 13:04, Ian Main wrote: This patch adds the original source drive as a backing drive to our target image so that the target image will appear complete during backup. This is especially useful for SYNC_MODE_NONE as it allows export via NBD to have a complete point-in-time snapshot

Re: [Qemu-devel] [PATCH 0/4] export internal snapshot by qemu-nbd

2013-07-18 Thread Fam Zheng
On Thu, 07/18 10:28, Wenchao Xia wrote: 于 2013-7-17 23:21, Kevin Wolf 写道: Am 17.07.2013 um 16:23 hat Eric Blake geschrieben: On 07/17/2013 08:03 AM, Wenchao Xia wrote: This series allow user to read internal snapshot's contents without qemu-img convert. Another purpose is that, when qemu is

Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a map subcommand

2013-07-18 Thread Fam Zheng
On Tue, 07/16 18:29, Paolo Bonzini wrote: This command dumps the metadata of an entire chain, in either tabular or JSON format. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- v1-v2: mention encrypted clusters, use PRId64 qemu-img-cmds.hx | 6 ++ qemu-img.c | 185

Re: [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic

2013-07-18 Thread Marcel Apfelbaum
On Tue, 2013-07-16 at 12:48 -0400, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch. This file includes the entire protocol and

Re: [Qemu-devel] [PATCH 0/6] mips_malta: fixes to support YAMON firmware

2013-07-18 Thread Leon Alrae
ping On 28/06/13 14:20, Leon Alrae wrote: ping http://patchwork.ozlabs.org/patch/251250/ http://patchwork.ozlabs.org/patch/251254/ http://patchwork.ozlabs.org/patch/251253/ http://patchwork.ozlabs.org/patch/251251/ http://patchwork.ozlabs.org/patch/251252/

Re: [Qemu-devel] Possibility of unaligned DMA accesses via the QEMU DMA API?

2013-07-18 Thread Kevin Wolf
Am 17.07.2013 um 22:12 hat Mark Cave-Ayland geschrieben: On 17/07/13 14:35, Kevin Wolf wrote: Okay, so I've had a quick look at that DMA controller, and it seems that for a complete emulation, there's no way around using a bounce buffer (and calling directly into the block layer instead of

[Qemu-devel] [PATCHv4] block-migration: efficiently encode zero blocks

2013-07-18 Thread Peter Lieven
this patch adds a efficient encoding for zero blocks by adding a new flag indicating a block is completely zero. additionally bdrv_write_zeros() is used at the destination to efficiently write these zeroes. depending on the implementation this avoids that the destination target gets fully

Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata

2013-07-18 Thread Peter Lieven
On 16.07.2013 18:29, Paolo Bonzini wrote: This series adds a subcommand to map that can dump file metadata. Metadata that is dumped includes: - whether blocks are allocated in bs-file and, if so, where - whether blocks are zero - whether data is read from bs or bs-backing_hd Metadata is

[Qemu-devel] [PATCHv4 1/2] iscsi: add logical block provisioning information to iscsilun

2013-07-18 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 77 + 1 file changed, 77 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0bbf0b1..ab42f1e 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -49,6 +49,10 @@

[Qemu-devel] [PATCHv4 2/2] iscsi: add .bdrv_co_is_allocated

2013-07-18 Thread Peter Lieven
this patch adds a coroutine for .bdrv_co_is_allocated as well as a generic framework that can be used to build coroutines in block/iscsi. Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 130 + 1 file changed, 130 insertions(+)

[Qemu-devel] [PATCHv4 0/2] iscsi/qemu-img/block-migration enhancements

2013-07-18 Thread Peter Lieven
this series adds logical block provisioning functions to the iscsi layer. it also is the first step to the change of migration to coroutines in block/iscsi. v3-v4: - this series collapsed into 2 patches not yet merged. as per discussion write_zero optimization will be a different approach

Re: [Qemu-devel] [PATCHv3 00/10] iscsi/qemu-img/block-migration enhancements

2013-07-18 Thread Peter Lieven
On 17.07.2013 17:05, Paolo Bonzini wrote: Il 11/07/2013 14:16, Peter Lieven ha scritto: this series adds logical block provisioning functions to the iscsi layer. it also is the first step to the change of migration to coroutines in block/iscsi. the changes to qemu-img and block migration have

[Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

2013-07-18 Thread Peter Lieven
Signed-off-by: Peter Lieven p...@kamp.de --- block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index b560241..c7f0197 100644 --- a/block.c +++ b/block.c @@ -2250,7 +2250,7 @@ int bdrv_read_unthrottled(BlockDriverState *bs, int64_t sector_num,

Re: [Qemu-devel] [PATCH v2 00/17] Add qemu-img subcommand to dump file metadata

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 10:17, Peter Lieven ha scritto: maybe i have missed it in your patches, but would it be also possible to issue DISCARDZEROES ioctl on linux to return zero status for block devices also? I think that would belong in your patches. Once we have discard_zeroes, we can use it as you

Re: [Qemu-devel] [PATCH v2 12/17] qemu-img: add a map subcommand

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 09:25, Fam Zheng ha scritto: +/* Probe up to 1 G at a time. */ +sector_num = (curr.start + curr.length) BDRV_SECTOR_BITS; +nsectors_left = DIV_ROUND_UP(length, BDRV_SECTOR_SIZE) - sector_num; +n = MAX(1 (30 - BDRV_SECTOR_BITS),

Re: [Qemu-devel] [PATCHv4 0/2] iscsi/qemu-img/block-migration enhancements

2013-07-18 Thread Kevin Wolf
Am 18.07.2013 um 10:19 hat Peter Lieven geschrieben: this series adds logical block provisioning functions to the iscsi layer. it also is the first step to the change of migration to coroutines in block/iscsi. v3-v4: - this series collapsed into 2 patches not yet merged. as per discussion

Re: [Qemu-devel] [PATCHv4] block-migration: efficiently encode zero blocks

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 18, 2013 at 09:48:50AM +0200, Peter Lieven wrote: this patch adds a efficient encoding for zero blocks by adding a new flag indicating a block is completely zero. additionally bdrv_write_zeros() is used at the destination to efficiently write these zeroes. depending on the

[Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like Network/Display/... and sorting them by it. Marcel Apfelbaum (2): qemu-help: Sort devices

[Qemu-devel] [RFC PATCH 2/2] devices: Associate devices to their logical category

2013-07-18 Thread Marcel Apfelbaum
The category will be used to sort the devices displayed in the command line help. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Note that these are not all the needed changes, the only purpose of this patch is to be a proof of concept. hw/audio/ac97.c | 1 +

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- include/hw/qdev-core.h | 7 +++

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Kevin Wolf
Am 17.07.2013 um 17:54 hat ronnie sahlberg geschrieben: On Wed, Jul 17, 2013 at 3:25 AM, Kevin Wolf kw...@redhat.com wrote: Am 17.07.2013 um 11:58 hat Paolo Bonzini geschrieben: BTW, Peter and Ronnie: we were assuming that UNMAP with LBPRZ=1 always zeroes blocks, but is that true for

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Kevin Wolf
Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/07/2013 19:02, Peter Lieven ha scritto: For Disks we always use read/write16 so i think we Should also use writesame16. Or not? Yes. Remember you can

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] Add Enhanced Three-Speed Ethernet Controller (eTSEC)

2013-07-18 Thread Fabien Chouteau
On 07/17/2013 11:02 PM, Scott Wood wrote: On 07/17/2013 05:17:06 AM, Fabien Chouteau wrote: On 07/16/2013 07:50 PM, Scott Wood wrote: On 07/16/2013 10:28:28 AM, Fabien Chouteau wrote: On 07/16/2013 04:06 AM, Scott Wood wrote: On 07/10/2013 12:10:02 PM, Fabien Chouteau wrote: +if

Re: [Qemu-devel] [PATCH] linux-user: Fix pipe syscall return for SPARC

2013-07-18 Thread Peter Maydell
Ping? thanks -- PMM On 6 July 2013 17:39, Peter Maydell peter.mayd...@linaro.org wrote: SPARC is one of the CPUs which has a funny syscall ABI for the pipe syscall; add it to the set of special cases in do_pipe(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- bash is much more

Re: [Qemu-devel] [PATCH] linux-user: Fix target_stat and target_stat64 for OpenRISC

2013-07-18 Thread Peter Maydell
Ping? thanks -- PMM On 6 July 2013 21:44, Peter Maydell peter.mayd...@linaro.org wrote: OpenRISC uses the asm-generic versions of target_stat and target_stat64, but it was incorrectly using the x86/ARM/etc version due to a misplaced defined(TARGET_OPENRISC). The previously unused OpenRISC

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 11:23, Kevin Wolf ha scritto: Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/07/2013 19:02, Peter Lieven ha scritto: For Disks we always use read/write16 so i think we Should also use writesame16.

Re: [Qemu-devel] [PATCH qom-cpu v2 19/29] cpu: Replace cpu_single_env with CPUState cpu_single_cpu

2013-07-18 Thread Andreas Färber
Am 15.07.2013 17:29, schrieb Paolo Bonzini: Il 15/07/2013 17:20, Andreas Färber ha scritto: We have some ugly include chains - yes, it shouldn't be here forever. Just like the qemu/log.h situation is pretty unsatisfactory (I wouldve liked to place log_cpu_state() into qom/cpu.h but it depends

Re: [Qemu-devel] [PATCHv4 2/2] iscsi: add .bdrv_co_is_allocated

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 10:19, Peter Lieven ha scritto: this patch adds a coroutine for .bdrv_co_is_allocated as well as a generic framework that can be used to build coroutines in block/iscsi. This conflicts with my bdrv_get_block_status patches. Paolo Signed-off-by: Peter Lieven p...@kamp.de ---

Re: [Qemu-devel] [PATCHv4 1/2] iscsi: add logical block provisioning information to iscsilun

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 10:19, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block/iscsi.c | 77 + 1 file changed, 77 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index 0bbf0b1..ab42f1e 100644 ---

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Kevin Wolf
Am 18.07.2013 um 12:24 hat Paolo Bonzini geschrieben: Il 18/07/2013 11:23, Kevin Wolf ha scritto: Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/07/2013 19:02, Peter Lieven ha scritto: For Disks we always

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 18.07.2013 12:24, Paolo Bonzini wrote: Il 18/07/2013 11:23, Kevin Wolf ha scritto: Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/07/2013 19:02, Peter Lieven ha scritto: For Disks we always use read/write16 so

Re: [Qemu-devel] Buildbots out of disk space

2013-07-18 Thread Andreas Färber
Am 15.07.2013 08:43, schrieb Stefan Hajnoczi: On Mon, Jul 15, 2013 at 07:31:05AM +0200, Christian Berendt wrote: Think we should clean up the registered build slaves. Here's a list of offline slaves. Can they be removed from the bot? default_s390 This slave goes offline relatively often

Re: [Qemu-devel] [PATCHv4 2/2] iscsi: add .bdrv_co_is_allocated

2013-07-18 Thread Peter Lieven
On 18.07.2013 12:36, Paolo Bonzini wrote: Il 18/07/2013 10:19, Peter Lieven ha scritto: this patch adds a coroutine for .bdrv_co_is_allocated as well as a generic framework that can be used to build coroutines in block/iscsi. This conflicts with my bdrv_get_block_status patches. I know, but

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 12:44, Peter Lieven ha scritto: On 18.07.2013 12:24, Paolo Bonzini wrote: Il 18/07/2013 11:23, Kevin Wolf ha scritto: Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com: Il 17/07/2013 19:02, Peter Lieven ha

Re: [Qemu-devel] [PATCH] block: fix bdrv_read_unthrottled()

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 10:37, Peter Lieven ha scritto: Signed-off-by: Peter Lieven p...@kamp.de --- block.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index b560241..c7f0197 100644 --- a/block.c +++ b/block.c @@ -2250,7 +2250,7 @@ int

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 18.07.2013 12:56, Paolo Bonzini wrote: Il 18/07/2013 12:44, Peter Lieven ha scritto: On 18.07.2013 12:24, Paolo Bonzini wrote: Il 18/07/2013 11:23, Kevin Wolf ha scritto: Am 17.07.2013 um 19:48 hat Peter Lieven geschrieben: Am 17.07.2013 um 19:04 schrieb Paolo Bonzini pbonz...@redhat.com:

Re: [Qemu-devel] support using KVM_MEM_READONLY flag for regions commit and OVMF UEFI incompatibility

2013-07-18 Thread Hannes Reinecke
On 07/15/2013 03:21 PM, Oleksii Shevchuk wrote: I tried do run QEMU with OVMF UEFI bios (QEMU and EDK2 trunk). It hangs while booting: qemu-kvm -L . -bios OVMF.fd --enable-kvm -debugcon file:/tmp/debug -global isa-debugcon.iobase=0x402 -global PIIX4_PM.disable_s3=0 -global

Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 11, 2013 at 01:46:58PM +0800, Wenchao Xia wrote: diff --git a/include/qemu-common.h b/include/qemu-common.h index f439738..06c777f 100644 --- a/include/qemu-common.h +++ b/include/qemu-common.h @@ -191,6 +191,9 @@ int64_t strtosz_suffix(const char *nptr, char **end, const char

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread Ian Jackson
Fabio Fantoni writes (Re: [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu): Il 12/07/2013 17:33, George Dunlap ha scritto: On 12/07/13 13:36, Fabio Fantoni wrote: [someone wrote:] I'm just curious, why is this so complicated? Is this likely to be fragile and break in

Re: [Qemu-devel] [PATCH V5 0/8] add internal snapshot support at block device level

2013-07-18 Thread Stefan Hajnoczi
On Thu, Jul 11, 2013 at 01:46:56PM +0800, Wenchao Xia wrote: This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation:

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread George Dunlap
On 18/07/13 12:09, Ian Jackson wrote: Fabio Fantoni writes (Re: [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu): Il 12/07/2013 17:33, George Dunlap ha scritto: On 12/07/13 13:36, Fabio Fantoni wrote: [someone wrote:] I'm just curious, why is this so complicated? Is

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread Anthony Liguori
On Thu, Jul 18, 2013 at 6:09 AM, Ian Jackson ian.jack...@eu.citrix.com wrote: Fabio Fantoni writes (Re: [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu): Il 12/07/2013 17:33, George Dunlap ha scritto: On 12/07/13 13:36, Fabio Fantoni wrote: [someone wrote:] I'm just

Re: [Qemu-devel] [PATCH V5 2/8] snapshot: distinguish id and name in snapshot delete

2013-07-18 Thread Kevin Wolf
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: Snapshot creation actually already distinguish id and name since it take a structured parameter *sn, but delete can't. Later an accurate delete is needed in qmp_transaction abort and blockdev-snapshot-delete-sync, so change its prototype.

Re: [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic

2013-07-18 Thread Michael R. Hines
On 07/18/2013 03:30 AM, Marcel Apfelbaum wrote: On Tue, 2013-07-16 at 12:48 -0400, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Code that does need to be visible is kept well contained inside this file and this is the only new additional file to the entire patch.

[Qemu-devel] [RFC PATCH 2/2] devices: Associate devices to their logical category

2013-07-18 Thread Marcel Apfelbaum
The category will be used to sort the devices displayed in the command line help. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- Note that these are not all the needed changes, the only purpose of this patch is to be a proof of concept. hw/audio/ac97.c | 1 +

[Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like Network/Display/... and sorting them by it. Marcel Apfelbaum (2): qemu-help: Sort devices

[Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com --- include/hw/qdev-core.h | 7 +++

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread Ian Jackson
Anthony Liguori writes (Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu): The current way of creating each function will always be supported though. Thanks for that reply. I'm reassured. Ian.

Re: [Qemu-devel] [PATCH V5 3/8] qmp: add internal snapshot support in qmp_transaction

2013-07-18 Thread Kevin Wolf
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: Unlike savevm, the qmp_transaction interface will not generate snapshot name automatically, saving trouble to return information of the new created snapshot. Although qcow2 support storing multiple snapshots with same name but different

Re: [Qemu-devel] [PATCH v3 resend 4/8] rdma: core logic

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 14:07, Michael R. Hines ha scritto: On 07/18/2013 03:30 AM, Marcel Apfelbaum wrote: On Tue, 2013-07-16 at 12:48 -0400, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com Code that does need to be visible is kept well contained inside this file and this

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread Andreas Färber
Am 12.07.2013 13:06, schrieb George Dunlap: On 12/07/13 11:22, Fabio Fantoni wrote: Usage: usbversion=1|2|3 (default=2) Specifies the type of an emulated USB bus in the guest. 1 for usb1, 2 for usb2 and 3 for usb3, it is available only with upstream qemu. Default is 2. Signed-off-by: Fabio

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 13:04, Peter Lieven ha scritto: But if you set BDRV_DISCARD_WRITE_ZEROES, then you always need a fallback to bdrv_write_zeroes. Why not just call bdrv_write_zeroes to begin with? That's why extending bdrv_write_zeroes is preferable. In this case wo do not need a flag to the

Re: [Qemu-devel] [PATCH V5 0/8] add internal snapshot support at block device level

2013-07-18 Thread Kevin Wolf
Am 11.07.2013 um 07:46 hat Wenchao Xia geschrieben: This series brings internal snapshot support at block devices level, now we have two three methods to do block snapshot lively: 1) backing chain, 2) internal one and 3) drive-back up approach. Comparation: Advantages:

Re: [Qemu-devel] [PATCH v3] libxl: usb2 and usb3 controller support for upstream qemu

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 14:31, Andreas Färber ha scritto: I'm just curious, why is this so complicated? Is this likely to be fragile and break in the future? As pointed out previously, the bus=pci.0 bit will break with different PCI host bridges, such as the q35 machine existing today (-M q35 uses

Re: [Qemu-devel] [ [PATCH]] nVMX: Initialize IA32_FEATURE_CONTROL MSR in reset and migration

2013-07-18 Thread Eduardo Habkost
On Tue, Jul 16, 2013 at 03:01:58PM +0300, Gleb Natapov wrote: On Tue, Jul 16, 2013 at 07:56:25PM +0800, Arthur Chunqi Li wrote: On Tue, Jul 16, 2013 at 7:42 PM, Gleb Natapov g...@redhat.com wrote: On Sun, Jul 07, 2013 at 11:13:37PM +0800, Arthur Chunqi Li wrote: The recent KVM patch adds

[Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices

2013-07-18 Thread Kevin Wolf
Even if the VM is already stopped, we cannot assume that all data has already been successfully flushed to disk. The flush during the previous vm_stop() could have failed. Run bdrv_flush_all() unconditionally so that we get an error each time if the block device isn't really flushed.

Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices

2013-07-18 Thread Kevin Wolf
Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben: Even if the VM is already stopped, we cannot assume that all data has already been successfully flushed to disk. The flush during the previous vm_stop() could have failed. Run bdrv_flush_all() unconditionally so that we get an error each

Re: [Qemu-devel] [PATCH] cpus: Let vm_stop[_force_state]() always flush block devices

2013-07-18 Thread Eric Blake
On 07/18/2013 06:55 AM, Kevin Wolf wrote: Am 18.07.2013 um 14:52 hat Kevin Wolf geschrieben: Even if the VM is already stopped, we cannot assume that all data has already been successfully flushed to disk. The flush during the previous vm_stop() could have failed. Run bdrv_flush_all()

Re: [Qemu-devel] [PATCH V4 3/4] Add backing drive while performing backup.

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 08:39, Fam Zheng ha scritto: On Wed, 07/17 13:04, Ian Main wrote: This patch adds the original source drive as a backing drive to our target image so that the target image will appear complete during backup. This is especially useful for SYNC_MODE_NONE as it allows export via

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 18.07.2013 14:31, Paolo Bonzini wrote: Il 18/07/2013 13:04, Peter Lieven ha scritto: But if you set BDRV_DISCARD_WRITE_ZEROES, then you always need a fallback to bdrv_write_zeroes. Why not just call bdrv_write_zeroes to begin with? That's why extending bdrv_write_zeroes is preferable. In

Re: [Qemu-devel] [PATCH v5 00/21] AArch64 preparation patchset

2013-07-18 Thread Peter Maydell
On 1 July 2013 20:07, Peter Maydell peter.mayd...@linaro.org wrote: On 1 July 2013 18:34, Peter Maydell peter.mayd...@linaro.org wrote: This patchset is v5 of the preparation patchset that started off with Alex, was passed to John Rigby and now to me. Also available via git:

Re: [Qemu-devel] Possibility of unaligned DMA accesses via the QEMU DMA API?

2013-07-18 Thread Alexander Graf
On 18.07.2013, at 09:41, Kevin Wolf wrote: Am 17.07.2013 um 22:12 hat Mark Cave-Ayland geschrieben: On 17/07/13 14:35, Kevin Wolf wrote: Okay, so I've had a quick look at that DMA controller, and it seems that for a complete emulation, there's no way around using a bounce buffer (and

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 15:29, Peter Lieven ha scritto: If the driver would have a better method of writing zeroes than discard it simply should not set bdi-write_zeroes_w_discard = 1. If the driver had a better method of writing zeroes than discard, it simply should ignore the BDRV_MAY_UNMAP (or

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 10:27, Marcel Apfelbaum ha scritto: Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical categories like Network/Display/... and sorting them

[Qemu-devel] [PATCH] seccomp: add arch_prctl() to the syscall whitelist

2013-07-18 Thread Paul Moore
It appears that even a very simple /etc/qemu-ifup configuration can require the arch_prctl() syscall, see the example below: #!/bin/sh /sbin/ifconfig $1 0.0.0.0 up /usr/sbin/brctl addif switch $1 Signed-off-by: Paul Moore pmo...@redhat.com --- qemu-seccomp.c |3 ++-

[Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening

2013-07-18 Thread Laszlo Ersek
The new modes are equal-rank, exclusive sub-modes of LM_IN_PROGRESS. Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. Also enumerate explicitly what functions are valid to call in what modes: - opts_next_list() is valid to call while flattening a range, -

[Qemu-devel] [RFC 4/6] OptsVisitor: rebase opts_type_uint64() to parse_uint_full()

2013-07-18 Thread Laszlo Ersek
Simplify the code in preparation for the next patch. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 23 +-- 1 files changed, 5 insertions(+), 18 deletions(-) diff --git a/qapi/opts-visitor.c b/qapi/opts-visitor.c index 287aa06..ce6c290 100644 ---

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread ronnie sahlberg
On Thu, Jul 18, 2013 at 6:29 AM, Peter Lieven p...@kamp.de wrote: On 18.07.2013 14:31, Paolo Bonzini wrote: Il 18/07/2013 13:04, Peter Lieven ha scritto: But if you set BDRV_DISCARD_WRITE_ZEROES, then you always need a fallback to bdrv_write_zeroes. Why not just call bdrv_write_zeroes to

[Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes

2013-07-18 Thread Laszlo Ersek
We're going to need more state while processing a list of repeated options. This change eliminates repeated_opts_first and adds a new state variable: list_mode repeated_opts repeated_opts_first -- - --- LM_NONE NULL false

[Qemu-devel] [RFC 6/6] OptsVisitor: don't try to flatten overlong integer ranges

2013-07-18 Thread Laszlo Ersek
Prevent mistyped command line options from incurring high memory and CPU usage at startup. 64K elements in a range should be enough for everyone (TM). The OPTS_VISITOR_RANGE_MAX macro is public so that unit tests can construct corner cases with it. Signed-off-by: Laszlo Ersek ler...@redhat.com

Re: [Qemu-devel] Possibility of unaligned DMA accesses via the QEMU DMA API?

2013-07-18 Thread Kevin Wolf
Am 18.07.2013 um 15:44 hat Alexander Graf geschrieben: On 18.07.2013, at 09:41, Kevin Wolf wrote: Am 17.07.2013 um 22:12 hat Mark Cave-Ayland geschrieben: On 17/07/13 14:35, Kevin Wolf wrote: Okay, so I've had a quick look at that DMA controller, and it seems that for a complete

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 15:56 +0200, Paolo Bonzini wrote: Il 18/07/2013 10:27, Marcel Apfelbaum ha scritto: Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into

[Qemu-devel] [RFC 3/6] OptsVisitor: opts_type_int(): recognize intervals when LM_IN_PROGRESS

2013-07-18 Thread Laszlo Ersek
When a well-formed range value, bounded by signed integers, is encountered while processing a repeated option, enter LM_SIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 34 -- 1 files changed, 28

[Qemu-devel] [RFC 0/6] OptsVisitor: support / flatten integer ranges for repeating options

2013-07-18 Thread Laszlo Ersek
Consider the following QAPI schema fragment, for the purpose of command line parsing with OptsVisitor: { 'type': 'UInt16', 'data': { 'u16': 'uint16' }} { 'union': 'NumaOptions', 'data': { 'node': 'NumaNodeOptions', 'mem' : 'NumaMemOptions' }} { 'type': 'NumaNodeOptions',

[Qemu-devel] [PULL 1/2] target-alpha: Move alarm to vm_clock

2013-07-18 Thread Richard Henderson
Basing the alarm off the rtc_clock was silly. It leads to horrible spinning in the guest after being suspended and resumed, as it tries to catch up with lost ticks. This requires adding an accessor for reading the vm_clock too. Signed-off-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 18.07.2013 15:52, Paolo Bonzini wrote: Il 18/07/2013 15:29, Peter Lieven ha scritto: If the driver would have a better method of writing zeroes than discard it simply should not set bdi-write_zeroes_w_discard = 1. If the driver had a better method of writing zeroes than discard, it simply

[Qemu-devel] [PULL 0/2] alpha-softmmu updates

2013-07-18 Thread Richard Henderson
For reasons that are probably obvious in retrospect, the paravirtual alarm clocks should run on VM time, not wall clock time. Resume the guest and it'll spin like mad trying to make up for lost ticks. Please pull. r~ The following changes since commit

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Michael S. Tsirkin
On Thu, Jul 18, 2013 at 11:27:42AM +0300, Marcel Apfelbaum wrote: Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by:

[Qemu-devel] [RFC 5/6] OptsVisitor: opts_type_uint64(): recognize intervals when LM_IN_PROGRESS

2013-07-18 Thread Laszlo Ersek
When a well-formed range value, bounded by unsigned integers, is encountered while processing a repeated option, enter LM_UNSIGNED_INTERVAL and return the low bound. Signed-off-by: Laszlo Ersek ler...@redhat.com --- qapi/opts-visitor.c | 32 +++- 1 files changed, 27

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 15:55, ronnie sahlberg ha scritto: bdrv-write_zeroes will use writesame16 and set the unmap flag only if BDRV_MAY_DISCARD == 1 and BDRV_O_UNMAP == 1 and lbprz == 1. When you use WRITESAME16 you can ignore the lbprz flag. Just send a WRITESAME16 command with one block of data

Re: [Qemu-devel] [PULL 2/2] pc-bios: Update palcode-clipper

2013-07-18 Thread Peter Maydell
On 18 July 2013 15:02, Paolo Bonzini pbonz...@redhat.com wrote: Il 18/07/2013 15:50, Richard Henderson ha scritto: Update image to c87a92639b28ac42bc8f6c67443543b405dc479b, incorporating changes for vm_time. Signed-off-by: Richard Henderson r...@twiddle.net --- pc-bios/README |

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 16:09, Peter Lieven ha scritto: On 18.07.2013 15:52, Paolo Bonzini wrote: Il 18/07/2013 15:29, Peter Lieven ha scritto: If the driver would have a better method of writing zeroes than discard it simply should not set bdi-write_zeroes_w_discard = 1. If the driver had a better

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Marcel Apfelbaum marce...@redhat.com writes: Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel Apfelbaum marce...@redhat.com Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Peter Lieven
On 18.07.2013 16:20, Paolo Bonzini wrote: Il 18/07/2013 16:09, Peter Lieven ha scritto: On 18.07.2013 15:52, Paolo Bonzini wrote: Il 18/07/2013 15:29, Peter Lieven ha scritto: If the driver would have a better method of writing zeroes than discard it simply should not set

Re: [Qemu-devel] [PATCH 4/4] qemu-img: conditionally discard target on convert

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 16:32, Peter Lieven ha scritto: (Mis)alignment and granularity can be handled later. We can ignore them for now. Later, if we decide the best way to support them is a flag, we'll add it. Let's not put the cart before the horse. BTW, I expect alignment!=0 to be really, really

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Marcel Apfelbaum
On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: Marcel Apfelbaum marce...@redhat.com writes: Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before showing them to user. Signed-off-by: Marcel

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: Marcel Apfelbaum marce...@redhat.com writes: Categorize devices that appear as output to -device ? command by logical functionality. Sort the devices by logical categories before

Re: [Qemu-devel] [RFC 1/6] OptsVisitor: introduce basic list modes

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 15:59, Laszlo Ersek ha scritto: We're going to need more state while processing a list of repeated options. This change eliminates repeated_opts_first and adds a new state variable: list_mode repeated_opts repeated_opts_first -- -

Re: [Qemu-devel] [RFC 2/6] OptsVisitor: introduce list modes for interval flattening

2013-07-18 Thread Paolo Bonzini
Il 18/07/2013 15:59, Laszlo Ersek ha scritto: The new modes are equal-rank, exclusive sub-modes of LM_IN_PROGRESS. Teach opts_next_list(), opts_type_int() and opts_type_uint64() to handle them. Perhaps you could use a bitmap then: LM_NONE = 0 LM_STARTED = 1 LM_IN_PROGRESS = 2

Re: [Qemu-devel] [RFC PATCH 1/2] qemu-help: Sort devices by logical functionality

2013-07-18 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 18/07/2013 16:42, Marcel Apfelbaum ha scritto: On Thu, 2013-07-18 at 09:28 -0500, Anthony Liguori wrote: Marcel Apfelbaum marce...@redhat.com writes: Categorize devices that appear as output to -device ? command by logical functionality. Sort the

[Qemu-devel] [RFC 1/3] icount: base rt_clock on icount.

2013-07-18 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This bases rt_clock on icount, as vm_clock. So vm_clock = rt_clock. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- qemu-timer.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qemu-timer.c b/qemu-timer.c

[Qemu-devel] [RFC 0/3] Determinitic behaviour with icount.

2013-07-18 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com Hi everybody, As I said in the last email, we have issues with determinism with icount. We are wondering if determinism is really ensured with icount? We saw that the rt_clock is used at multiple place which is a pain for replaying the simulation

Re: [Qemu-devel] [PATCH V6 05/13] monitor: avoid use of global *cur_mon in readline_completion()

2013-07-18 Thread Luiz Capitulino
On Thu, 18 Jul 2013 09:55:51 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: 于 2013-7-18 3:34, Luiz Capitulino 写道: On Thu, 11 Jul 2013 11:13:41 +0800 Wenchao Xia xiaw...@linux.vnet.ibm.com wrote: Now all completion functions do not use *cur_mon any more, instead they use rs-mon. In

[Qemu-devel] [RFC 2/3] icount: sync vm_clock on the next event.

2013-07-18 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com We don't want vm_clock to be synchronized with rt_clock as it is not deterministic for replay. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- cpus.c | 11 +-- main-loop.c | 5 + 2 files changed, 14 insertions(+), 2

Re: [Qemu-devel] [RFC PATCH 0/2] qemu-help: improve -device command line help

2013-07-18 Thread Eric Blake
On 07/18/2013 07:56 AM, Paolo Bonzini wrote: Il 18/07/2013 10:27, Marcel Apfelbaum ha scritto: Running qemu with -device ? option returns ~145 lines. It is hard to manage understanding the output. Theses patches aim to partially solve the problem by dividing the devices into logical

[Qemu-devel] [RFC 3/3] icount: create a new icount based timer.

2013-07-18 Thread fred . konrad
From: KONRAD Frederic fred.kon...@greensocs.com This creates a new icount based timer, with no bias. It moves only with the instruction counter. Signed-off-by: KONRAD Frederic fred.kon...@greensocs.com --- cpus.c | 10 -- include/qemu/timer.h | 4 qemu-timer.c

  1   2   3   >