[Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On the real hardware, RTAS is called in real mode and therefore ignores top 4 bits of the address passed in the call. This fixes QEMU to do the same thing. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/ppc/spapr_rtas.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

Re: [Qemu-devel] [RFC v3 3/5] hw/arm/digic: add timer support

2013-09-05 Thread Antony Pavlov
On Wed, 4 Sep 2013 16:18:37 +1000 Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Wed, Sep 4, 2013 at 3:21 PM, Antony Pavlov antonynpav...@gmail.com wrote: Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/digic.c | 25 ++ hw/timer/Makefile.objs |

[Qemu-devel] [PATCH v6] powerpc: add PVR mask support

2013-09-05 Thread Alexey Kardashevskiy
IBM POWERPC processors encode PVR as a CPU family in higher 16 bits and a CPU version in lower 16 bits. Since there is no significant change in behavior between versions, there is no point to add every single CPU version in QEMU's CPU list. Also, new CPU versions of already supported CPU won't

Re: [Qemu-devel] BUG: memory API related abort (bisected)

2013-09-05 Thread Paolo Bonzini
Il 05/09/2013 03:08, Luiz Capitulino ha scritto: Reproducer: 1. Start QEMU with gdb support: $ qemu [...] -kernel [...] -s 2. Start gdb and install a breakpoint gdb /path/to/vmlinux (gdb) target remote localhost:1234 (gdb) b init_hw_perf_events Remote

Re: [Qemu-devel] [PATCH] linux-headers: update to 3.11

2013-09-05 Thread Paolo Bonzini
Il 05/09/2013 05:16, Alexey Kardashevskiy ha scritto: Sorry for my ignorance, but this is The Kernel, it is already there, broken or not, even if it is broken, qemu cannot stay isolated, no? This is a mechanical change, no more. It's a matter of keeping things bisectable. If we can

Re: [Qemu-devel] [PATCH v2] spapr-vscsi: Adding VSCSI capabilities

2013-09-05 Thread Alexey Kardashevskiy
On 09/02/2013 03:03 PM, Nikunj A. Dadhania wrote: This implements capabilities exchange between vscsi host and client. As at the moment no capability is supported, put zero flags everywhere and return. Signed-off-by: Nikunj A Dadhania nik...@linux.vnet.ibm.com Acked-by: Alexey

Re: [Qemu-devel] [PATCH v4 00/12] vfio on spapr-ppc64

2013-09-05 Thread Alexey Kardashevskiy
On 08/30/2013 08:15 PM, Alexey Kardashevskiy wrote: Yet another try with VFIO on SPAPR (server PPC64). Alex (Williamson), could you please give it some review and comment/sob/rb/ab (whichever suits) this stuff? Since kernel headers update is on its way to upstream, we could try to include this

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On the real hardware, RTAS is called in real mode and therefore ignores top 4 bits of the address passed in the call. Shouldn't we ignore the upper 4 bits for every memory access in real mode, not just that one parameter?

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Kevin Wolf
Am 04.09.2013 um 20:15 hat Benoît Canet geschrieben: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other types of BlockDrivers properly. Shouldn't

Re: [Qemu-devel] [PATCH RFC] Do not set SO_REUSEADDR on Windows

2013-09-05 Thread Michael Tokarev
04.09.2013 18:34, Jan Kiszka wrote: On 2013-09-04 16:27, Paolo Bonzini wrote: Il 04/09/2013 16:22, Sebastian Ottlik ha scritto: This patchset disabels all use of SO_REUSEADDR on Windows. On Windows systems the default behavior is equivalent to SO_REUSEADDR on other operating systems.

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On the real hardware, RTAS is called in real mode and therefore ignores top 4 bits of the address passed in the call. Shouldn't we ignore the upper 4 bits for every memory

[Qemu-devel] [RFC v4 1/5] hw/arm: add very initial support for Canon DIGIC SoC

2013-09-05 Thread Antony Pavlov
DIGIC is Canon Inc.'s name for a family of SoC for digital cameras and camcorders. There is no publicly available specification for DIGIC chips. All information about DIGIC chip internals is based on reverse engineering efforts made by CHDK (http://chdk.wikia.com) and Magic Lantern

[Qemu-devel] [RFC v4 0/5] hw/arm: add initial support for Canon DIGIC SoC

2013-09-05 Thread Antony Pavlov
[RFC v4 1/5] hw/arm: add very initial support for Canon DIGIC SoC [RFC v4 2/5] hw/arm/digic: prepare DIGIC-based boards support [RFC v4 3/5] hw/arm/digic: add timer support [RFC v4 4/5] hw/arm/digic: add UART support [RFC v4 5/5] hw/arm/digic: add NOR ROM support Changes since v3: 1. fix

[Qemu-devel] [RFC v4 3/5] hw/arm/digic: add timer support

2013-09-05 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/digic.c | 26 +++ hw/timer/Makefile.objs | 1 + hw/timer/digic-timer.c | 117 + hw/timer/digic-timer.h | 19 include/hw/arm/digic.h | 7 +++ 5 files

[Qemu-devel] [RFC v4 2/5] hw/arm/digic: prepare DIGIC-based boards support

2013-09-05 Thread Antony Pavlov
Also this patch adds initial support for Canon PowerShot A1100 IS compact camera. Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/Makefile.objs | 2 +- hw/arm/digic_boards.c | 63 +++ 2 files changed, 64 insertions(+), 1

[Qemu-devel] [RFC v4 4/5] hw/arm/digic: add UART support

2013-09-05 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/digic.c | 14 hw/char/Makefile.objs | 1 + hw/char/digic-uart.c | 197 + hw/char/digic-uart.h | 27 +++ include/hw/arm/digic.h | 4 + 5 files changed, 243

[Qemu-devel] [RFC v4 5/5] hw/arm/digic: add NOR ROM support

2013-09-05 Thread Antony Pavlov
Signed-off-by: Antony Pavlov antonynpav...@gmail.com --- hw/arm/digic_boards.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/hw/arm/digic_boards.c b/hw/arm/digic_boards.c index 0b99227..850e320 100644 --- a/hw/arm/digic_boards.c +++

[Qemu-devel] [RFC 1/3] bdrv: Use Error for opening images

2013-09-05 Thread Max Reitz
Add an Error ** parameter to bdrv_open, bdrv_file_open and bdrv_create to allow more specific error messages. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 6 +++--- block/blkdebug.c | 3 ++- block/blkverify.c | 3 ++- block/bochs.c |

[Qemu-devel] [RFC 0/3] block: Error parameter for opening/creating images

2013-09-05 Thread Max Reitz
This RFC adds an Error ** parameter to bdrv_open, bdrv_file_open, bdrv_create and the respective functions provided by a block driver. This results in more specific error information than just -errno provided to the user when opening or creating images (disregarding the fact that block drivers

[Qemu-devel] [RFC 2/3] block: Error parameter for opening functions

2013-09-05 Thread Max Reitz
Add an Error ** parameter to bdrv_open, bdrv_file_open, bdrv_create and associated functions to allow more specific error messages. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 164 -- block/blkdebug.c | 2 +-

[Qemu-devel] [RFC 3/3] qcow2: Use Error parameter

2013-09-05 Thread Max Reitz
Employ usage of the new Error ** parameter in qcow2_open, qcow2_create and associated functions. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2.c | 135 ++ 1 file changed, 88 insertions(+), 47 deletions(-) diff --git

[Qemu-devel] [PATCH 0/2] tcg-ppc: use new return-argument ld/st helpers

2013-09-05 Thread Paolo Bonzini
Last month I revived my old PowerBook, and here are the resulting patches to use the new return-argument ld/st helpers. I have a few more tcg-ppc patches but they have a much smaller performance impact so I'll wait till I have some more free time before posting. But the impact of the new helpers

[Qemu-devel] [PATCH 1/2] tcg-ppc: fix qemu_ld/qemu_st for AIX ABI

2013-09-05 Thread Paolo Bonzini
For the AIX ABI, the function pointer and small area pointer need to be loaded in the trampoline. The trampoline instead is called with a normal BL instruction. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- tcg/ppc/tcg-target.c | 17 + 1 file changed, 9 insertions(+), 8

[Qemu-devel] [PATCH 2/2] tcg-ppc: use new return-argument ld/st helpers

2013-09-05 Thread Paolo Bonzini
These use a 32-bit load-of-immediate to save a mflr+addi+mtlr sequence. Tested with a Windows 98 guest (pretty much the most recent thing I could run on my PPC machine) and kvm-unit-tests's sieve.flat. The speed up for sieve.flat is as high as 10% for qemu-system-i386, 25% (no kidding) for

[Qemu-devel] [ARM][regression][bisect] ARM target broken: test v5 image does not start kernel

2013-09-05 Thread Claudio Fontana
Hello all, I just finished bisecting a regression I am experiencing on ARM 32bit target, while testing qemu-system-arm built for the aarch64 host running the ARMv5 integrator image from our test page at http://wiki.qemu.org/Testing The breakage assumes the form of failure to start the kernel

Re: [Qemu-devel] [RFC 1/3] bdrv: Use Error for opening images

2013-09-05 Thread Kevin Wolf
Am 05.09.2013 um 10:10 hat Max Reitz geschrieben: Add an Error ** parameter to bdrv_open, bdrv_file_open and bdrv_create to allow more specific error messages. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 6 +++--- block/blkdebug.c | 3 ++-

[Qemu-devel] [PATCH] qemu-iotests: New test case in 061

2013-09-05 Thread Max Reitz
Add one test case for zero cluster expansion on qcow2 version downgrade in shared L2 tables (i.e., L2 tables with a refcount 1) and one for zero expansion on backed clusters in shared L2 tables. Signed-off-by: Max Reitz mre...@redhat.com --- Depends on (follow-up to): - block/qcow2: Image file

Re: [Qemu-devel] [ARM][regression][bisect] ARM target broken: test v5 image does not start kernel

2013-09-05 Thread Peter Maydell
On 5 September 2013 09:31, Claudio Fontana claudio.font...@huawei.com wrote: I just finished bisecting a regression I am experiencing on ARM 32bit target, After a painful bisection, I got a first bad commit, which when reverted on the latest QEMU fixes the issue for me. Maybe something needs

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Alexander Graf
On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all of the explicitly generated bswap opcodes. Cc: qemu-...@nongnu.org Signed-off-by: Richard Henderson

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 06:54, Alexey Kardashevskiy wrote: On 09/05/2013 02:30 PM, David Gibson wrote: On Tue, Sep 03, 2013 at 05:31:42PM +1000, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This is needed for migration, where a guest can

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Stefan Hajnoczi
On Wed, Sep 04, 2013 at 11:39:51AM +0200, Kevin Wolf wrote: First of all, excuse any inconsistencies in the following mail. I wrote it from top to bottom, and there was some thought process involved in almost every paragraph... I should add this disclaimer to all my emails ;-). Am 04.09.2013

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Stefan Hajnoczi
On Wed, Sep 04, 2013 at 11:55:23AM +0200, Benoît Canet wrote: I'm not sure if multiple journals will work in practice. Doesn't this re-introduce the need to order update steps and flush between them? This is a question for Benoît, who made this requirement. I asked him the same a

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On the real hardware, RTAS is called in real mode and therefore ignores top 4 bits of the address passed in the call.

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Stefan Hajnoczi
On Tue, Sep 03, 2013 at 03:45:52PM +0200, Kevin Wolf wrote: This contains an extension of the qcow2 spec that introduces journalling to the image format, plus some preliminary type definitions and function prototypes in the qcow2 code. Journalling functionality is a crucial feature for the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/2] tcg-ppc: use new return-argument ld/st helpers

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 10:22, Paolo Bonzini wrote: Last month I revived my old PowerBook, and here are the resulting patches to use the new return-argument ld/st helpers. I have a few more tcg-ppc patches but they have a much smaller performance impact so I'll wait till I have some more free

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 07:16 PM, Alexander Graf wrote: On 05.09.2013, at 06:54, Alexey Kardashevskiy wrote: On 09/05/2013 02:30 PM, David Gibson wrote: On Tue, Sep 03, 2013 at 05:31:42PM +1000, Alexey Kardashevskiy wrote: This allows guests to have a different timebase origin from the host. This

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 11:48, Alexey Kardashevskiy wrote: On 09/05/2013 07:16 PM, Alexander Graf wrote: On 05.09.2013, at 06:54, Alexey Kardashevskiy wrote: On 09/05/2013 02:30 PM, David Gibson wrote: [...] #endif /* TARGET_PPC64 */ } @@ -1082,6 +1102,9 @@ int

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Stefan Hajnoczi
On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other types of BlockDrivers properly. Shouldn't

Re: [Qemu-devel] [RFC PATCH] spapr: add initial ibm, client-architecture-support rtas call support

2013-09-05 Thread Paul Mackerras
On Wed, Sep 04, 2013 at 04:32:20PM -0500, Anthony Liguori wrote: On Wed, Sep 4, 2013 at 8:37 AM, Alexander Graf ag...@suse.de wrote: So IMHO this whole thing should be orthogonal to -cpu. Well, since we cannot change CPU class on the fly, yes, it should be a compatibility

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On the real hardware, RTAS is called in real mode and therefore ignores

Re: [Qemu-devel] Block Filters

2013-09-05 Thread Fam Zheng
On Thu, 09/05 12:01, Stefan Hajnoczi wrote: On Wed, Sep 04, 2013 at 08:15:36PM +0200, Benoît Canet wrote: Propagate operations like snapshot down the tree. block.c is designed for bs-file/bs-backing_hd kind of BlockDrivers, perhaps it needs to become a bit more generic to support other

Re: [Qemu-devel] [RFC PATCH] spapr: add initial ibm, client-architecture-support rtas call support

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 12:16, Paul Mackerras wrote: On Wed, Sep 04, 2013 at 04:32:20PM -0500, Anthony Liguori wrote: On Wed, Sep 4, 2013 at 8:37 AM, Alexander Graf ag...@suse.de wrote: So IMHO this whole thing should be orthogonal to -cpu. Well, since we cannot change CPU class on the fly,

[Qemu-devel] [RFC PATCH 0/6] Shared Library Module Support

2013-09-05 Thread Fam Zheng
This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules It's achieved in three steps, with extra bonus to change curl to a shared library module in the end (only to demonstrate the usage, no make install support of .so files yet). 1. Allow

[Qemu-devel] [RFC PATCH 1/6] make.rule: fix $(obj) to a real relative path

2013-09-05 Thread Fam Zheng
Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't hurt compiling

[Qemu-devel] [RFC PATCH 2/6] rule.mak: allow per object cflags and libs

2013-09-05 Thread Fam Zheng
Adds extract-libs in LINK to expand any per object libs, the syntax to define such a libs options is like: $(obj)/curl.o-libs = $(CURL_LIBS) in block/Makefile.objs. Similarly, $(obj)foo.o-cflags = $(FOO_CFLAGS) is also supported. Signed-off-by: Fam Zheng f...@redhat.com ---

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey Kardashevskiy a...@ozlabs.ru: On the real

[Qemu-devel] [RFC PATCH 3/6] Makefile: define curl cflags and libs with object

2013-09-05 Thread Fam Zheng
We have per object cflags and libs support now, move CURL_CFLAGS and CURL_LIBS from global option variables to a per object basis. Signed-off-by: Fam Zheng f...@redhat.com --- block/Makefile.objs | 3 ++- configure | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [RFC PATCH 5/6] module: load modules at start

2013-09-05 Thread Fam Zheng
Add module_load_all to load all DSO modules under: /usr/lib/qemu/block/ /usr/lib/qemu/net/ /usr/lib/qemu/ui/ when starting process. Requires gmodule-2.0 from glib. Signed-off-by: Fam Zheng f...@redhat.com --- configure | 20 +++- include/qemu/module.h |

[Qemu-devel] [RFC PATCH 6/6] curl: build as shared library

2013-09-05 Thread Fam Zheng
Produce block/curl.so with --enable-curl. make install is not installing it yet, manually copy it to /usr/lib/qemu/block/curl.so to make it loaded. Signed-off-by: Fam Zheng f...@redhat.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure

[Qemu-devel] [RFC PATCH 4/6] Makefile: introduce common-obj-m and block-obj-m for DSO

2013-09-05 Thread Fam Zheng
Add necessary rules and flags for shared object generation. common-obj-m will include block-obj-m, as common-obj-y for block-obj-y. The rules introduced here are: QEMU_CFLAGS += -shared -fPIC, for all %.o of shared objects. 1) %.o in $(common-obj-m) is compiled to %.o, with QEMU_CFLAGS

Re: [Qemu-devel] [RFC PATCH 0/6] Shared Library Module Support

2013-09-05 Thread Fam Zheng
On Thu, 09/05 18:20, Fam Zheng wrote: This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules It's achieved in three steps, with extra bonus to change curl to a shared library module in the end (only to demonstrate the usage, no make

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Christian Borntraeger
On 04/09/13 14:45, Andreas Färber wrote: Hello, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of

Re: [Qemu-devel] [RFC 0/3] block: Error parameter for opening/creating images

2013-09-05 Thread Kevin Wolf
Am 05.09.2013 um 10:10 hat Max Reitz geschrieben: This RFC adds an Error ** parameter to bdrv_open, bdrv_file_open, bdrv_create and the respective functions provided by a block driver. This results in more specific error information than just -errno provided to the user when opening or

[Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it

2013-09-05 Thread Michal Privoznik
Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- The issue still happens thus the patch is still valid.

Re: [Qemu-devel] [ARM][regression][bisect] ARM target broken: test v5 image does not start kernel

2013-09-05 Thread Claudio Fontana
Hi Peter, On 05.09.2013 10:59, Peter Maydell wrote: On 5 September 2013 09:31, Claudio Fontana claudio.font...@huawei.com wrote: I just finished bisecting a regression I am experiencing on ARM 32bit target, After a painful bisection, I got a first bad commit, which when reverted on the

Re: [Qemu-devel] [PATCH RESEND] configure: Undefine _FORTIFY_SOURCE prior using it

2013-09-05 Thread Peter Maydell
On 5 September 2013 11:54, Michal Privoznik mpriv...@redhat.com wrote: Currently, we are enforcing the _FORTIFY_SOURCE=2 without any previous detection if the macro has been already defined, e.g. by environment, or is just enabled by compiler by default. Signed-off-by: Michal Privoznik

Re: [Qemu-devel] Problems with QEMU sdcard while using glib 2.33.8

2013-09-05 Thread Taimoor Mirza
Hi Stefan, I am using released 1.5.0 version from http://wiki.qemu.org/Download. I think it should be same as commit ID 295d81c62414a63c625fa2e78175573d4b3f5ba4 I have observed some interesting behavior. This problem does not come if I use MinGW with GCC version 4.7.2. I was originally using

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Kevin Wolf
Am 05.09.2013 um 11:21 hat Stefan Hajnoczi geschrieben: On Wed, Sep 04, 2013 at 11:39:51AM +0200, Kevin Wolf wrote: However, what if we run 'qemu-img check -r leaks' with an old qemu-img version? It will reclaim the clusters used by the journal, and if we continue using the journal we'll

Re: [Qemu-devel] Questions about hvm domU default devices with upstream qemu

2013-09-05 Thread Stefano Stabellini
On Wed, 4 Sep 2013, Fabio Fantoni wrote: Il 04/09/2013 15:17, Stefano Stabellini ha scritto: On Wed, 4 Sep 2013, Fabio Fantoni wrote: Il 04/07/2013 15:51, Fabio Fantoni ha scritto: Last year I posted a question about default devices of upstream qemu that differ from qemu

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Andreas Färber
Am 05.09.2013 12:40, schrieb Christian Borntraeger: On 04/09/13 14:45, Andreas Färber wrote: Hello, Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-05 Thread Alexander Graf
On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/sclp.c |2 +- include/hw/s390x/sclp.h |8 2 files changed, 9

Re: [Qemu-devel] [PATCH 1/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Define New SCLP Codes

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Define new SCLP codes to improve code readability. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com s390-qemu: is really bad. For one, all QEMU patches are somehow about QEMU, so that's redundant. For

Re: [Qemu-devel] [PATCH 2/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP CPU Info

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Implement the CPU data in SCLP Read SCP Info. And implement Read CPU Info SCLP command. This data will be used by the guest to get information about hot plugged cpus. Signed-off-by: Jason J. Herne

[Qemu-devel] [QEMU-1.6 QEMU-Upstream PATCH] vl.c: Output error on invalid machine type provided

2013-09-05 Thread Michal Novotny
Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that doesn't support required machine type yet (the version user downgraded

Re: [Qemu-devel] [QEMU-1.6 QEMU-Upstream PATCH] vl.c: Output error on invalid machine type provided

2013-09-05 Thread Daniel P. Berrange
On Thu, Sep 05, 2013 at 01:36:09PM +0200, Michal Novotny wrote: Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you downgrade from one version of qemu to another that

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Benjamin Herrenschmidt
On Thu, 2013-09-05 at 11:08 +0200, Alexander Graf wrote: On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all of the explicitly generated bswap opcodes. Only nit: I

[Qemu-devel] [PATCH] abitypes.h: Remove incorrect ARM ABI_LLONG_ALIGNMENT

2013-09-05 Thread Peter Maydell
The ARM EABI specifies that 64 bit integers should be 8 aligned; remove our incorrect setting of 4 alignment. This has no actual effect since it only set the alignment for the 'abi_ullong' and 'abi_llong' types, which are used only inside code which is MIPS-specific, but it will avoid problems

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Benjamin Herrenschmidt
On Thu, 2013-09-05 at 19:48 +1000, Alexey Kardashevskiy wrote: I do not have pure guest timebase in QEMU and I need it on the destination. But I have host timebase + offset to calculate it. And tb_offset is already in ppc_tb_t. It looked logical to me to send the existing field and add

Re: [Qemu-devel] [PATCH 3/8] [PATCH RFC v3] s390-qemu: cpu hotplug - SCLP Event integration

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Add an sclp event for cpu was hot plugged. This allows Qemu to deliver an SCLP interrupt to the guest stating that the requested cpu hotplug was completed. Signed-off-by: Jason J. Herne

Re: [Qemu-devel] [RFC PATCH 5/6] module: load modules at start

2013-09-05 Thread Lluís Vilanova
Fam Zheng writes: Add module_load_all to load all DSO modules under: /usr/lib/qemu/block/ /usr/lib/qemu/net/ /usr/lib/qemu/ui/ when starting process. This should probably be based on a define with the prefix set at configure time. Adding directories from command-line arguments

Re: [Qemu-devel] [QEMU-1.6 QEMU-Upstream PATCH] vl.c: Output error on invalid machine type provided

2013-09-05 Thread Michal Novotny
On 09/05/2013 01:39 PM, Daniel P. Berrange wrote: On Thu, Sep 05, 2013 at 01:36:09PM +0200, Michal Novotny wrote: Output error message using qemu's error_report() function when user provides the invalid machine type on the command line. This also saves time to find what issue is when you

Re: [Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |5

Re: [Qemu-devel] [RFC PATCH 5/6] module: load modules at start

2013-09-05 Thread Michael Tokarev
05.09.2013 14:20, Fam Zheng wrote: Add module_load_all to load all DSO modules under: /usr/lib/qemu/block/ /usr/lib/qemu/net/ /usr/lib/qemu/ui/ when starting process. NACK. This is wrong, as has been mentioned already. For example, you can't expect to load ui/* from qemu-img,

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Kevin Wolf
Am 05.09.2013 um 11:35 hat Stefan Hajnoczi geschrieben: Although we are still discussing details of the on-disk layout, the general design is clear enough to discuss how the journal will be used. Today qcow2 uses Qcow2Cache to do lazy, ordered metadata updates. The performance is pretty

Re: [Qemu-devel] [RFC PATCH] spapr: add initial ibm, client-architecture-support rtas call support

2013-09-05 Thread Paul Mackerras
On Thu, Sep 05, 2013 at 12:19:09PM +0200, Alexander Graf wrote: On 05.09.2013, at 12:16, Paul Mackerras wrote: On Wed, Sep 04, 2013 at 04:32:20PM -0500, Anthony Liguori wrote: On Wed, Sep 4, 2013 at 8:37 AM, Alexander Graf ag...@suse.de wrote: So IMHO this whole thing should be

Re: [Qemu-devel] [PATCH] tci: Add implementation of rotl_i64, rotr_i64

2013-09-05 Thread Jay Foad
diff --git a/tci.c b/tci.c index 18c888e..94b7851 100644 --- a/tci.c +++ b/tci.c @@ -952,8 +952,16 @@ uintptr_t tcg_qemu_tb_exec(CPUArchState *env, uint8_t *tb_ptr) break; #if TCG_TARGET_HAS_rot_i64 case INDEX_op_rotl_i64: +t0 = *tb_ptr++; +

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of ipi_state

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 08:21 PM, Alexander Graf wrote: On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: On 09/05/2013 05:08 PM, Alexander Graf wrote: Am 05.09.2013 um 07:58 schrieb Alexey

[Qemu-devel] [PATCH 1/3] block: Additional info string in ImageInfo and BDI

2013-09-05 Thread Max Reitz
Add a string for additional information to ImageInfo and BlockDriverInfo. Also, use this string to emit the compatibility level and lazy_refcount value (on compat=1.1) for qcow2. Signed-off-by: Max Reitz mre...@redhat.com --- block.c | 3 ++- block/mirror.c| 6 --

[Qemu-devel] [PATCH 3/3] qemu-iotests: Additional info from qemu-img info

2013-09-05 Thread Max Reitz
Add a test for the additional information now provided by qemu-img info when used on qcow2 images. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/064 | 72 ++ tests/qemu-iotests/064.out | 17 +++ tests/qemu-iotests/group

[Qemu-devel] [PATCH 2/3] qemu-iotests: info-string filter in _img_info

2013-09-05 Thread Max Reitz
Filter out additional information specific to the image format provided by qemu-img info in _img_info. Signed-off-by: Max Reitz mre...@redhat.com --- tests/qemu-iotests/common.rc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/common.rc

[Qemu-devel] [PATCH 0/3] Provide additional info through qemu-img info

2013-09-05 Thread Max Reitz
qemu-img info provides only pretty general information about an image. For any image format, there might be specific options which cannot be represented in a universal way; for instance, qcow2 provides the compatibility and lazy_refcount options whose values are certainly interesting but currently

Re: [Qemu-devel] [RFC] qcow2 journalling draft

2013-09-05 Thread Benoît Canet
Then you get very quickly alternating sequences of L2 depends on refcount update (for allocation) and refcount update depends on L2 update (for freeing), which means that Qcow2Cache starts flushing all the time without accumulating many requests. These are cases that would benefit as well

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 09:42 PM, Benjamin Herrenschmidt wrote: On Thu, 2013-09-05 at 19:48 +1000, Alexey Kardashevskiy wrote: I do not have pure guest timebase in QEMU and I need it on the destination. But I have host timebase + offset to calculate it. And tb_offset is already in ppc_tb_t. It looked

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: On 09/05/2013 08:21 PM, Alexander Graf wrote: On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey Kardashevskiy wrote: On 09/05/2013 05:08 PM,

[Qemu-devel] [PATCH] vl.c: Implement SIGILL signal handler for triggering SIGSEGV

2013-09-05 Thread Michal Novotny
This is the patch to introduce SIGILL handler to be able to trigger SIGSEGV signal in qemu. This has been written to help debugging state when qemu crashes by SIGSEGV as a simple reproducer to emulate such situation in case of need. Signed-off-by: Michal Novotny minov...@redhat.com --- vl.c | 24

Re: [Qemu-devel] Questions about hvm domU default devices with upstream qemu

2013-09-05 Thread Fabio Fantoni
Il 05/09/2013 13:23, Stefano Stabellini ha scritto: On Wed, 4 Sep 2013, Fabio Fantoni wrote: Il 04/09/2013 15:17, Stefano Stabellini ha scritto: On Wed, 4 Sep 2013, Fabio Fantoni wrote: Il 04/07/2013 15:51, Fabio Fantoni ha scritto: Last year I posted a question about default devices of

Re: [Qemu-devel] [PATCH 1/3] block: Additional info string in ImageInfo and BDI

2013-09-05 Thread Eric Blake
On 09/05/2013 06:05 AM, Max Reitz wrote: Add a string for additional information to ImageInfo and BlockDriverInfo. Also, use this string to emit the compatibility level and lazy_refcount value (on compat=1.1) for qcow2. Signed-off-by: Max Reitz mre...@redhat.com --- +++ b/qapi-schema.json

Re: [Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All actual cpu initialization code is moved from boot time specific functions

Re: [Qemu-devel] [PATCH] Change email address

2013-09-05 Thread Peter Maydell
On 19 August 2013 14:51, Anthony Liguori anth...@codemonkey.ws wrote: My IBM email address will be unaccessible after August 23rd, 2013. Signed-off-by: Anthony Liguori anth...@codemonkey.ws --- a/.mailmap +++ b/.mailmap @@ -2,7 +2,7 @@ # into proper addresses so that they are counted

Re: [Qemu-devel] [PATCH 7/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Implement hot_add_cpu hook

2013-09-05 Thread Andreas Färber
Am 01.08.2013 16:12, schrieb Jason J. Herne: From: Jason J. Herne jjhe...@us.ibm.com Implement hot_add_cpu for S390 to allow hot plugging of cpus. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |3 +++ target-s390x/cpu.c | 32

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 13:44, Benjamin Herrenschmidt wrote: On Thu, 2013-09-05 at 11:58 +0200, Alexander Graf wrote: Yes. I do not really understand the problem here (and I am not playing dump). Do you suggest sending just the guest timebase and do not send the host timebase and the offset

Re: [Qemu-devel] [RFC PATCH] spapr: support time base offset migration

2013-09-05 Thread Benjamin Herrenschmidt
On Thu, 2013-09-05 at 11:58 +0200, Alexander Graf wrote: Yes. I do not really understand the problem here (and I am not playing dump). Do you suggest sending just the guest timebase and do not send the host timebase and the offset (one number instead of two)? I can do that, makes

Re: [Qemu-devel] [PATCH 4/8] [PATCH RFC v3] s390-qemu: cpu hotplug - Storage key global access

2013-09-05 Thread Alexander Graf
On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com Introduces global access to storage key data so we can set it for each cpu in the S390 cpu initialization routine. Signed-off-by: Jason J. Herne jjhe...@us.ibm.com --- hw/s390x/s390-virtio-ccw.c |

Re: [Qemu-devel] [PATCH 5/8] [PATCH RFC v3] s390-qemu: cpu hotplug - ipi_states enhancements

2013-09-05 Thread Alexander Graf
On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com Modify s390_cpu_addr2state to allow fetching state information for cpu addresses above smp_cpus. Hotplug requires this capability. Also add s390_cpu_set_state function to allow modification of

Re: [Qemu-devel] [PATCH] spapr-rtas: reset top 4 bits in parameters address

2013-09-05 Thread Alexey Kardashevskiy
On 09/05/2013 10:16 PM, Alexander Graf wrote: On 05.09.2013, at 14:04, Alexey Kardashevskiy wrote: On 09/05/2013 08:21 PM, Alexander Graf wrote: On 05.09.2013, at 12:17, Alexey Kardashevskiy wrote: On 09/05/2013 07:27 PM, Alexander Graf wrote: On 05.09.2013, at 09:40, Alexey

Re: [Qemu-devel] [PATCH 6/8] [PATCH RFC v3] s390-qemu: cpu hotplug - s390 cpu init improvements for hotplug

2013-09-05 Thread Alexander Graf
On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com s390_new_cpu is created to encapsulate the creation of a new QOM S390CPU object given a cpuid and a model string. All actual cpu initialization code is moved from boot time specific

Re: [Qemu-devel] [PATCH 1/3] block: Additional info string in ImageInfo and BDI

2013-09-05 Thread Max Reitz
On 2013-09-05 14:25, Eric Blake wrote: On 09/05/2013 06:05 AM, Max Reitz wrote: Add a string for additional information to ImageInfo and BlockDriverInfo. Also, use this string to emit the compatibility level and lazy_refcount value (on compat=1.1) for qcow2. Signed-off-by: Max Reitz

Re: [Qemu-devel] [PATCH 0/8] [PATCH RFC v3] s390 cpu hotplug

2013-09-05 Thread Alexander Graf
On 01.08.2013, at 16:12, Jason J. Herne wrote: From: Jason J. Herne jjhe...@us.ibm.com Latest code for cpu Hotplug on S390 architecture. This one is vastly simpler than v2 as we have decided to avoid the command line specification of -device s390-cpu. The last version can be found

Re: [Qemu-devel] [Qemu-ppc] [PATCH 16/16] target-ppc: Convert to new ldst opcodes

2013-09-05 Thread Alexander Graf
On 05.09.2013, at 13:40, Benjamin Herrenschmidt wrote: On Thu, 2013-09-05 at 11:08 +0200, Alexander Graf wrote: On 04.09.2013, at 23:05, Richard Henderson wrote: This lets us change le_mode to end_mode and fold away nearly all of the tests for the current cpu endianness, and removing all

  1   2   3   >