On 17.09.2013 19:21, Paolo Bonzini wrote:
Il 17/09/2013 19:18, Stefan Weil ha scritto:
Latest QEMU git is broken on Debian wheezy:
block/iscsi.c: In function ‘iscsi_co_get_block_status’:
block/iscsi.c:842:5: error: implicit declaration of function
‘iscsi_get_lba_status_task’
On 18.09.2013 10:48, Paolo Bonzini wrote:
Il 17/09/2013 15:48, Peter Lieven ha scritto:
Signed-off-by: Peter Lieven p...@kamp.de
---
block/raw_bsd.c |4
1 file changed, 4 insertions(+)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index 0bfa5fc..dfdb375 100644
---
On 2013-09-18 16:59, Stefan Hajnoczi wrote:
On Thu, Sep 05, 2013 at 02:05:13PM +0200, Max Reitz wrote:
diff --git a/block.c b/block.c
index 26639e8..9fd9f3a 100644
--- a/block.c
+++ b/block.c
@@ -1921,7 +1921,7 @@ void bdrv_round_to_clusters(BlockDriverState *bs,
On Thu, Sep 19, 2013 at 8:36 AM, Taimoor Mirza taimoor.m...@gmail.com wrote:
Please use Reply-All to keep the CC list on your reply email. This
way others on the mailing list can follow the discussion and
participate.
O1 disassembly is at http://pastebin.com/yxWAmmmf
O2 disassembly is at
On Wed, Sep 18, 2013 at 03:35:07PM +0100, Alex Bennée wrote:
stefa...@gmail.com writes:
Looks useful. To get more code coverage, flesh out the build
environment:
Thanks. Am I dreaming or are there some system image tests somewhere as well?
Anthony Liguori's qemu-test builds
On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît Canet wrote:
Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan Hajnoczi a écrit :
Hi Benoit,
Kevin and I had a chance to chat face-to-face and we discussed what
concrete changes are necessary to merge quorum (without solving all the
other
On Do, 2013-09-19 at 00:18 +0100, Burton, Ross wrote:
Hi,
The documentation for qemu's input devices says:
‘tablet’
Pointer device that uses absolute coordinates (like a touchscreen).
This means qemu is able to report the mouse position without having to
grab the mouse. Also overrides
Am 19.09.2013 um 10:26 hat Stefan Hajnoczi geschrieben:
On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît Canet wrote:
Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan Hajnoczi a écrit :
Hi Benoit,
Kevin and I had a chance to chat face-to-face and we discussed what
concrete changes are
Il 18/09/2013 17:35, Jan Beulich ha scritto:
On 18.09.13 at 17:26, Fabio Fantoni fabio.fant...@m2r.biz wrote:
Il 18/09/2013 16:30, Jan Beulich ha scritto:
On 18.09.13 at 16:12, Fabio Fantoni fabio.fant...@m2r.biz wrote:
Il 18/09/2013 14:42, Jan Beulich ha scritto:
On 18.09.13 at 14:29, Fabio
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/core.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 31960c2..cf59a1a 100644
--- a/hw/usb/core.c
+++
Hi,
Here comes the usb patch queue. It has a number of fixes, mostly for
xhci, and removes the old, pre-libusbx usb-host code.
please pull,
Gerd
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79:
Merge remote-tracking branch 'kiszka/queues/slirp' into staging
From: Hans de Goede hdego...@redhat.com
According to the xhci spec the total number of streams is
2 ^ (MaxPStreams + 1), and this is also how the Linux xhci driver
uses this field.
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
From: Hans de Goede hdego...@redhat.com
And use it instead of prying the USBEndpoint out of the packet struct
in various places.
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 32 ++--
1 file
From: Hans de Goede hdego...@redhat.com
The USBPacket-s in the transfers need to be cleaned up so that the memory
allocated by the iovec in there gets freed.
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/hcd-xhci.c | 5 +
1 file
From: Hans de Goede hdego...@redhat.com
Transfers are part of an epctx, which is part of a slot, which is part of
a xhci. Transfers cannot dynamically be moved from one epctx to another,
so once created their xhci, slotid and epid are constant, so lets set these
up at creation time, rather then
From: Hans de Goede hdego...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/usb/combined-packet.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/usb/combined-packet.c b/hw/usb/combined-packet.c
index 13f6602..ad77705
Nowdays rom size is fixed at 8192 for live migration compat reasons.
So we can ditch the pointless math trying to calculate the size needed.
Also make the size sanity check fail at compile time not runtime.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/display/qxl.c | 4 +---
1 file
Hi,
Here comes the spice patch queue. It elimitates qxl dependency on
TARGET_PAGE_SIZE, so qemu can enter the compile-once pool.
please pull,
Gerd
The following changes since commit 6c2679fc19560699679200fb42ab4659bcbe7f79:
Merge remote-tracking branch 'kiszka/queues/slirp' into staging
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/display/Makefile.objs | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/display/Makefile.objs b/hw/display/Makefile.objs
index 6e9fb3b..540df82 100644
--- a/hw/display/Makefile.objs
+++ b/hw/display/Makefile.objs
@@
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/display/qxl.c | 5 +++--
hw/display/qxl.h | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index c50e285..f0bfd2c 100644
--- a/hw/display/qxl.c
+++ b/hw/display/qxl.c
@@ -364,7 +364,7
No need to do target page size calculations here,
memory_region_set_dirty will care for us.
Signed-off-by: Gerd Hoffmann kra...@redhat.com
---
hw/display/qxl.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/display/qxl.c b/hw/display/qxl.c
index bcbf97a..ee2db0d 100644
On 19 September 2013 09:51, Gerd Hoffmann kra...@redhat.com wrote:
The documentation for qemu's input devices says:
‘tablet’
Pointer device that uses absolute coordinates (like a touchscreen).
This means qemu is able to report the mouse position without having to
grab the mouse. Also
On 19.09.13 at 11:22, Fabio Fantoni fabio.fant...@m2r.biz wrote:
This is logs from xl dmesg about Quantal (ubuntu 12.10) hvm domU with
qxl vga and patch x86-HVM-emul-split-large:
(d3) HVM Loader
[...]
So in particular no wrong mmio size messages.
qemu seem to crash at domU's xorg
On 19/09/13 11:01, Jan Beulich wrote:
On 19.09.13 at 11:22, Fabio Fantoni fabio.fant...@m2r.biz wrote:
This is logs from xl dmesg about Quantal (ubuntu 12.10) hvm domU with
qxl vga and patch x86-HVM-emul-split-large:
(d3) HVM Loader
[...]
So in particular no wrong mmio size messages.
qemu
On Wed, Sep 18, 2013 at 03:35:12PM +0200, Mario DE CHENNO wrote:
This time crashed just issuing a mount command:
Starting program: /vmstore/vmtools/qemu-nbd-from1.6.0
/vmstore/playground/archivioweb.img
[Thread debugging using libthread_db enabled]
[New Thread 0x755e3700 (LWP 7626)]
Hi,
I put printf statements in ui/sdl.c in sdl_grab_start() and _end(),
and entering the window with either tablet or wacom-tablet causes
those methods to be called and grabs taken. To the user it doesn't
appear to be grabbed as the grab gets released when the pointer
reaches the edge,
Using s-snapshots_size instead of snapshots_size for the metadata
overlap check in qcow2_write_snapshots leads to the detection of an
overlap with the main qcow2 image header when deleting the last
snapshot, since s-snapshots_size has not yet been updated and is
therefore non-zero. However, the
Il 19/09/2013 12:04, George Dunlap ha scritto:
On 19/09/13 11:01, Jan Beulich wrote:
On 19.09.13 at 11:22, Fabio Fantoni fabio.fant...@m2r.biz wrote:
This is logs from xl dmesg about Quantal (ubuntu 12.10) hvm domU with
qxl vga and patch x86-HVM-emul-split-large:
(d3) HVM Loader
[...]
So in
On Tue, Sep 17, 2013 at 05:09:39PM +0200, Gabriel Kerneis wrote:
Current coroutine performance benchmarks test only coroutine creation,
either directly or in a nested way. This patch adds a benchmark to
evaluate the performance of qemu_coroutine_yield.
Signed-off-by: Gabriel Kerneis
On Tue, Sep 17, 2013 at 06:26:48PM +0200, Gabriel Kerneis wrote:
The /perf/nesting benchmark is broken because the counters are
not reset after each iteration. Therefore, nesting is done only
on the first iteration, and skipped on every other.
This patch fixes the issue, and reduces the
On Wed, Sep 18, 2013 at 07:14:15PM +0800, Fam Zheng wrote:
We use the extent size as cluster size for flat extents (where no L1/L2
table is allocated so it's safe).
Why is the extent size passed as the cluster size parameter?
The cleaner fix would be to stop passing it as cluster size :).
On Wed, Sep 18, 2013 at 07:14:13PM +0800, Fam Zheng wrote:
This fixes two bugs of image opening. The vmdk fix also applies to 1.6.
Fam Zheng (2):
block: don't lose data from last incomplete sector
vmdk: fix cluster size check for flat extents
block.c | 2 +-
block/vmdk.c | 2 +-
Hi,
Am 18.09.2013 22:39, schrieb Eduardo Habkost:
Hi,
I would like to get your opinion on this:
Currently we have x2apic enabled only on SandyBridge and Haswell CPU
models because we try to keep the CPU models closer to real CPUs.
However, x2apic improves performance by reducing the
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block-migration.c |3 ++-
block.c |4
block/backup.c|2 +-
include/block/block.h |7 +++
4 files changed, 14 insertions(+), 2 deletions(-)
+++
Le Thursday 19 Sep 2013 à 10:57:50 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 10:26 hat Stefan Hajnoczi geschrieben:
On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît Canet wrote:
Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan Hajnoczi a écrit :
Hi Benoit,
Kevin and I had a
Am 19.09.2013 um 14:55 hat Benoît Canet geschrieben:
Le Thursday 19 Sep 2013 à 10:57:50 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 10:26 hat Stefan Hajnoczi geschrieben:
On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît Canet wrote:
Le Tuesday 17 Sep 2013 à 14:44:13 (+0200), Stefan
Le Thursday 19 Sep 2013 à 15:21:46 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 14:55 hat Benoît Canet geschrieben:
Le Thursday 19 Sep 2013 à 10:57:50 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 10:26 hat Stefan Hajnoczi geschrieben:
On Wed, Sep 18, 2013 at 05:05:27PM +0200, Benoît
Il 19/09/2013 10:11, Stefan Hajnoczi ha scritto:
On Thu, Sep 19, 2013 at 8:36 AM, Taimoor Mirza taimoor.m...@gmail.com wrote:
Please use Reply-All to keep the CC list on your reply email. This
way others on the mailing list can follow the discussion and
participate.
O1 disassembly is at
Sorry yes of course I have tried a different mirror but I think that the
problem was with my server installation because even my mail server was
not working correctly I will update this comment as soon as I have new
information.
@Shivakumar:
Thank you for your help anyway
--
You received this
Il 19/09/2013 09:24, Peter Lieven ha scritto:
do we still need this patch? if yes I can sent one shortly.
No, Stefan prepared it. I'll send a pull request shortly.
Paolo
Le Monday 02 Sep 2013 à 13:19:16 (-0300), Eduardo Habkost a écrit :
On Mon, Sep 02, 2013 at 05:06:37PM +0200, Benoît Canet wrote:
Some users running cpu intensive tasks checking the cache CPUID leaves at
startup and making decisions based on the result reported that the guest was
not
on 17/09/2013 21:49 Gleb Natapov said the following:
http://www.linux-kvm.org/page/Tracing
Gleb,
thank you very much!
Here's an interesting snippet from the trace:
qemu-system-x86-4639 [003] 263925.182731: kvm_entry:vcpu 0
qemu-system-x86-4639 [003] 263925.182733: kvm_exit:
Am 19.09.2013 um 15:38 hat Benoît Canet geschrieben:
Le Thursday 19 Sep 2013 à 15:21:46 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 14:55 hat Benoît Canet geschrieben:
Le Thursday 19 Sep 2013 à 10:57:50 (+0200), Kevin Wolf a écrit :
Am 19.09.2013 um 10:26 hat Stefan Hajnoczi
On Tue, Sep 17, 2013 at 06:43:16PM +0200, Stefan Weil wrote:
The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3:
block/stream.c:141:22: error:
‘copy’ may be used uninitialized in this function [-Werror=uninitialized]
This is not a real bug - a better compiler would not
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block.c | 29 +
include/block/block.h |2 ++
include/block/block_int.h | 13 +
3 files changed, 44 insertions(+)
Reviewed-by: Eric
Il 19/09/2013 09:29, Peter Lieven ha scritto:
On 18.09.2013 10:48, Paolo Bonzini wrote:
Il 17/09/2013 15:48, Peter Lieven ha scritto:
Signed-off-by: Peter Lieven p...@kamp.de
---
block/raw_bsd.c |4
1 file changed, 4 insertions(+)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
On Thu, Sep 19, 2013 at 08:51:39AM -0600, Eric Blake wrote:
On 09/19/2013 07:21 AM, Kevin Wolf wrote:
I was thinking more along the lines of:
-drive if=none,file.driver=quorum,format=raw,\
file.children[0].file.filename=/nfs1/test.qcow2, \
Note that this requires
Hi,
I've done some benchmarks regarding this series now. In particular, I've
created a 7G image, installed Arch Linux to a partition in the first 2G
and created an empty ext4 partition for benchmarking in the remaining 5G.
My first test consisted of running bonnie++ (bonnie++ -d [scratch
On 09/19/2013 07:21 AM, Kevin Wolf wrote:
I was thinking more along the lines of:
-drive if=none,file.driver=quorum,format=raw,\
file.children[0].file.filename=/nfs1/test.qcow2, \
Note that this requires shell quoting to protect you from globbing
changing the argv handed to
On Thu, Sep 19, 2013 at 6:01 PM, Alex Bennée alex.ben...@linaro.org wrote:
stefa...@gmail.com writes:
On Wed, Sep 18, 2013 at 03:35:07PM +0100, Alex Bennée wrote:
stefa...@gmail.com writes:
Looks useful. To get more code coverage, flesh out the build
environment:
Thanks. Am I
On 19 September 2013 17:23, Paolo Bonzini pbonz...@redhat.com wrote:
Similar patches to SDL have been rejected before because it breaks the
API, so I don't see the bug in SDL getting resolved.
Oh, didn't realize the bug is in the sdl library. That is a bit more
complicated then. SDL would
stefa...@gmail.com writes:
On Wed, Sep 18, 2013 at 03:35:07PM +0100, Alex Bennée wrote:
stefa...@gmail.com writes:
Looks useful. To get more code coverage, flesh out the build
environment:
Thanks. Am I dreaming or are there some system image tests somewhere as well?
Anthony
Il 19/09/2013 12:18, Gerd Hoffmann ha scritto:
Similar patches to SDL have been rejected before because it breaks the
API, so I don't see the bug in SDL getting resolved.
Oh, didn't realize the bug is in the sdl library. That is a bit more
complicated then. SDL would need a new grab
I guess it could be a problem with the mirror you are using. Have you
tried using a different mirror. Following is what I tried and I was able
to boot centos
virt-install \
-n test \
-r 1024 \
--disk path=/tmp/test.img,size=3 \
--vcpus=1 \
--os-type linux \
--os-variant=rhel6 \
--network
Am 06.09.2013 19:24, schrieb Stefan Weil:
Am 06.09.2013 19:16, schrieb Peter Maydell:
On 6 September 2013 17:46, Stefan Weil s...@weilnetz.de wrote:
This test case is fixed now:
sparc64-linux-user/qemu-sparc64 /usr/gnemul/qemu-sparc64/busybox ls -l
block.c
Signed-off-by: Stefan Weil
The first bug is simply that in 1.6.0 the default was changed by mistake
to cache=unsafe. This affects all block drivers. It is fixed in the
first patch.
The second is that Linux guests that support the CONFIG_WCE option were
mistaken into thinking that caching was writethrough, and thus did
Hello,
As reported yesterday on IRC, since the last round of pulls I am getting
the following warning-treated-as-error:
CCblock/stream.o
/home/andreas/QEMU/qemu/block/stream.c: In function ‘stream_run’:
/home/andreas/QEMU/qemu/block/stream.c:111:14: error: ‘copy’ may be used
uninitialized
Il 19/09/2013 18:59, Andreas Färber ha scritto:
Am 17.09.2013 18:43, schrieb Stefan Weil:
The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3:
block/stream.c:141:22: error:
‘copy’ may be used uninitialized in this function [-Werror=uninitialized]
This is not a real bug - a
Am 17.09.2013 18:43, schrieb Stefan Weil:
The patch fixes a warning from gcc (Debian 4.6.3-14+rpi1) 4.6.3:
block/stream.c:141:22: error:
‘copy’ may be used uninitialized in this function [-Werror=uninitialized]
This is not a real bug - a better compiler would not complain.
Now 'copy'
Am 19.09.2013 18:59, schrieb Stefan Weil:
Am 19.09.2013 18:52, schrieb Andreas Färber:
Hello,
As reported yesterday on IRC, since the last round of pulls I am getting
the following warning-treated-as-error:
CCblock/stream.o
/home/andreas/QEMU/qemu/block/stream.c: In function
(CCing Paolo, as he was involved in the previous discussion about TCG vs
KVM CPU models)
On Thu, Sep 19, 2013 at 01:50:58PM +0200, Andreas Färber wrote:
Hi,
Am 18.09.2013 22:39, schrieb Eduardo Habkost:
Hi,
I would like to get your opinion on this:
Currently we have x2apic enabled
Il 19/09/2013 19:18, Andriy Gapon ha scritto:
on 19/09/2013 19:53 Paolo Bonzini said the following:
1) Can you try loading the kvm_intel module with
emulate_invalid_guest_state=0?
Will do.
2) What are the contents of fs and gs? Why are they not zeroed?
Perhaps that is causing invalid
Am 19.09.2013 18:52, schrieb Andreas Färber:
Hello,
As reported yesterday on IRC, since the last round of pulls I am getting
the following warning-treated-as-error:
CCblock/stream.o
/home/andreas/QEMU/qemu/block/stream.c: In function ‘stream_run’:
Il 02/09/2013 17:06, Benoît Canet ha scritto:
Some users running cpu intensive tasks checking the cache CPUID leaves at
startup and making decisions based on the result reported that the guest was
not reflecting the host CPUID leaves when -cpu host is used.
This patch fix this.
On 09/19/2013 09:07 AM, Max Reitz wrote:
Hi,
I've done some benchmarks regarding this series now. In particular, I've
created a 7G image, installed Arch Linux to a partition in the first 2G
and created an empty ext4 partition for benchmarking in the remaining 5G.
Thank you for doing this!
That's why all my VMs were so fast lately. :)
This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
'cache' option, 2013-07-18).
Cc: qemu-sta...@nongnu.org
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
blockdev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush
on 19/09/2013 19:53 Paolo Bonzini said the following:
1) Can you try loading the kvm_intel module with
emulate_invalid_guest_state=0?
Will do.
2) What are the contents of fs and gs? Why are they not zeroed?
Perhaps that is causing invalid guest state emulation to run, and then
something is
Il 19/09/2013 18:58, Eduardo Habkost ha scritto:
I disagree, since this would also affect TCG. I would prefer to add
x2apic only to models that really have it and would be open to generally
enabling it for kvm_enabled() in instance_init/registration (so that
users can disable it via
Il 18/09/2013 19:35, Andreas Färber ha scritto:
Am 18.09.2013 16:41, schrieb Andrew Jones:
I don't know yet if want this feature on by default, so for now I'm
just adding support for -cpu ...,+kvm_pv_unhalt.
Signed-off-by: Andrew Jones drjo...@redhat.com
---
target-i386/cpu.c | 2 +-
1
On 09/19/2013 10:48 AM, Paolo Bonzini wrote:
That's why all my VMs were so fast lately. :)
This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
'cache' option, 2013-07-18).
And my name is tied to that one as a reviewer. Sorry for letting it
through in the first place.
On 09/19/2013 10:48 AM, Paolo Bonzini wrote:
The following sequence happens:
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the -drive option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled,
Il 19/09/2013 16:36, Andriy Gapon ha scritto:
Not sure how the code ends up at 0x9315 after that.
Events are dropped, probably corresponding to more emulation.
And here is original assembly code:
rret_tramp: movw $MEM_ESPR-0x08,%sp # Reset stack pointer
pushal
Brad Smith wrote:
On 20/01/13 1:12 PM, David Woodhouse wrote:
The PCI Firmware Specification apparently requires that the PCI Data
Structure be DWORD-aligned. The implementation in OVMF also requires
this, so vgabios ROMs don't work there. With this fixed, I can now
initialise the VGA ROM
Hi all,
In the most versions of the linux kernel (3.9+), kvm has increased the
number of user memory slots to 125:
#define KVM_SOFT_MAX_VCPUS 160
#define KVM_USER_MEM_SLOTS 125
/* memory slots that are not exposed to userspace */
#define KVM_PRIVATE_MEM_SLOTS 3
#define KVM_MEM_SLOTS_NUM
on 19/09/2013 20:26 Paolo Bonzini said the following:
I don't think that's what happens. It's more likely that for some
reason the emulator mis-parses the instruction.
Please confirm with info cpus that QEMU is looping there (just in
case), and attach the output of info registers (you can
The header struct VdiHeader is an on-disk structure for the image
format, and as such should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/vdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/vdi.c b/block/vdi.c
index dcbc27c..f8bdc92 100644
---
The VHD footer and header structs (vhd_footer and vhd_dyndisk_header)
are on-disk structures for the image format, and as such should be
packed.
Go ahead and make these typedefs as well, with the preferred QEMU
naming convention, so that the packed attribute is used consistently
with the struct.
on 19/09/2013 19:53 Paolo Bonzini said the following:
Il 19/09/2013 16:36, Andriy Gapon ha scritto:
Not sure how the code ends up at 0x9315 after that.
Events are dropped, probably corresponding to more emulation.
I've got a trace without dropped events between the last normal instruction
QCowHeader and QCowExtension are structs that reside in the on-disk
image format, and are read and written directly via bdrv_pread()/write(),
and as such should be packed to avoid any unintentional struct padding.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qcow2.c | 2 +-
block/qcow2.h
QEDHeader is read, and written, directly from on-disk images
via bdrv_pread()/write(). To avoid any unintentional padding,
these structs should be packed.
Signed-off-by: Jeff Cody jc...@redhat.com
---
block/qed.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/qed.h
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block/raw_bsd.c | 56
+--
1 file changed, 34 insertions(+), 22 deletions(-)
Reviewed-by: Eric Blake ebl...@redhat.com
--
Eric Blake eblake
cow_header_v2 is read and written directly from the image file
with bdrv_pread()/bdrv_pwrite(), and as such should be packed to
avoid unintentional padding.
Also change struct cow_header_v2 to a typedef, and some minor
code style changes to keep checkpatch.pl happy.
Signed-off-by: Jeff Cody
Several block image formats did not consistently use packed attributes
when directly reading / writing structures from disk (mainly image format
headers).
These series updates the image formats (see list below), to use
QEMU_PACKED for on-disk structs. (Some minor code cleanup may also
have
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
include/block/block_int.h | 12
1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
+
+/* optimal alignment for write zeroes requests in sectors */
+
On 09/19/2013 11:43 AM, Jeff Cody wrote:
cow_header_v2 is read and written directly from the image file
with bdrv_pread()/bdrv_pwrite(), and as such should be packed to
avoid unintentional padding.
Also change struct cow_header_v2 to a typedef, and some minor
code style changes to keep
Am 19.09.2013 20:53, schrieb Eric Blake:
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
include/block/block_int.h | 12
1 file changed, 12 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
+
+/* optimal alignment for
On 09/17/2013 07:48 AM, Peter Lieven wrote:
this patch does 2 things:
a) only do additional call outs if BDRV_BLOCK_ZERO is not already set.
b) use the newly introduced bdrv_has_discard_zeroes() to return the
zero state of an unallocated block. the used callout to
bdrv_has_zero_init()
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block.c | 34 +-
1 file changed, 33 insertions(+), 1 deletion(-)
diff --git a/block.c b/block.c
index 74ec342..ecc5be4 100644
--- a/block.c
+++ b/block.c
@@
On 09/17/2013 07:48 AM, Peter Lieven wrote:
this patch adds a call to completely zero out a block device.
the operation is sped up by checking the block status and
only writing zeroes to the device if they currently do not
return zeroes. optionally the zero writing can be sped up
by setting
On 09/05/2013 08:01 AM, Andreas Färber wrote:
Am 01.08.2013 16:12, schrieb Jason J. Herne:
From: Jason J. Herne jjhe...@us.ibm.com
...
This is what got us into the link discussion last time. If we do
for (i = 0; i ARRAY_SIZE(ipi_states); i++) {
name = g_strdup_printf(cpu[%i], i);
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block/iscsi.c | 16 +++-
1 file changed, 15 insertions(+), 1 deletion(-)
@@ -1522,7 +1534,9 @@ static BlockDriver bdrv_iscsi = {
.bdrv_aio_writev = iscsi_aio_writev,
On 09/17/2013 07:48 AM, Peter Lieven wrote:
now that bdrv_co_discard can handle limits we do not need
the request split logic here anymore.
Signed-off-by: Peter Lieven p...@kamp.de
---
block/iscsi.c | 67
+
1 file changed, 25
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
block/iscsi.c | 10 ++
1 file changed, 10 insertions(+)
Reviewed-by: Eric Blake ebl...@redhat.com
diff --git a/block/iscsi.c b/block/iscsi.c
index aabcddb..21b1ecf 100644
---
We previously allocated 32-bits per temp for the next_free_temp entry.
We now allocate 4 bits per temp across the 4 bitmaps.
Using a linked list meant that if a translator is tweeked, resulting in
temps being freed in a different order, that would have follow-on effects
throughout the TB. Always
On Sat, Sep 14, 2013 at 10:46:37AM +0100, Peter Maydell wrote:
On 14 September 2013 02:52, Christoffer Dall
christoffer.d...@linaro.org wrote:
On Fri, Sep 06, 2013 at 03:41:04PM +0100, Peter Maydell wrote:
The TCG QEMU GIC model is currently adopting the
GIC without Security Extensions
On 09/17/2013 07:48 AM, Peter Lieven wrote:
Signed-off-by: Peter Lieven p...@kamp.de
---
qemu-img.c |8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 3e5e388..7600b58 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -100,8 +100,10 @@
On 09/17/2013 07:48 AM, Peter Lieven wrote:
if the target has_zero_init = 0, but supports efficiently
writing zeroes by unmapping we call bdrv_zeroize to
avoid fully allocating the target. this currently
You don't like the shift key, do you? :)
s/this/This/ if you care about grammar in commit
On Thu, Sep 19, 2013 at 08:48:35PM +0100, Christoffer Dall wrote:
On Sat, Sep 14, 2013 at 10:46:37AM +0100, Peter Maydell wrote:
On 14 September 2013 02:52, Christoffer Dall
christoffer.d...@linaro.org wrote:
On Fri, Sep 06, 2013 at 03:41:04PM +0100, Peter Maydell wrote:
The TCG QEMU
On 09/05/2013 07:25 AM, Andreas Färber wrote:
Am 05.09.2013 12:40, schrieb Christian Borntraeger:
On 04/09/13 14:45, Andreas Färber wrote:
...
To cope with device_add s390-cpu adding the device to
/machine/peripheral/id or /machine/peripheral-anon/device[0] I *think*
we'll need link, which
1 - 100 of 140 matches
Mail list logo
