[Qemu-devel] About the IO queue inside qemu

2013-10-02 Thread Yaodong Yang
Hi all, I'm wondering is there any io queue inside qemu? Is there any IO scheduling inside it? I notice that there is an IO track feature inside block.c, but I do not know the purpose of it. Could someone explain it for me? Thanks a lot! Yaodong

Re: [Qemu-devel] KVM call minutes for 2013-10-01

2013-10-02 Thread Stefan Hajnoczi
On Wed, Oct 02, 2013 at 12:17:35AM +0900, Peter Maydell wrote: On 1 October 2013 23:54, Juan Quintela quint...@redhat.com wrote: - Multicore on Multicore: TCG has no locking, no people really working there (Alex Graf?) Apart from the TCG locking issues (which are conceptually tractable

Re: [Qemu-devel] R: qemu-nbd segmentation fault

2013-10-02 Thread Stefan Hajnoczi
On Thu, Sep 19, 2013 at 12:05 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Wed, Sep 18, 2013 at 03:35:12PM +0200, Mario DE CHENNO wrote: This time crashed just issuing a mount command: Starting program: /vmstore/vmtools/qemu-nbd-from1.6.0 /vmstore/playground/archivioweb.img [Thread

[Qemu-devel] [PATCH v7 5/6] qemu-iotests: Discard specific info in _img_info

2013-10-02 Thread Max Reitz
In _img_info, filter out additional information specific to the image format provided by qemu-img info, since tests designed for multiple image formats would produce different outputs for every image format otherwise. In a human-readable dump, that new information will always be last for each

[Qemu-devel] [PATCH v7 0/6] Provide additional info through qemu-img info

2013-10-02 Thread Max Reitz
qemu-img info provides only pretty general information about an image. For any image format, there might be specific options which cannot be represented in a universal way; for instance, qcow2 provides the compatibility and lazy_refcount options whose values are certainly interesting but currently

[Qemu-devel] [PATCH v7 1/6] qapi: Add ImageInfoSpecific type

2013-10-02 Thread Max Reitz
Add a new type ImageInfoSpecific as a union for image format specific information in ImageInfo. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- qapi-schema.json | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v7 2/6] block: Add bdrv_get_specific_info

2013-10-02 Thread Max Reitz
Add a function for retrieving an ImageInfoSpecific object from a block driver. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- block.c | 9 + block/qapi.c | 3 +++ include/block/block.h | 1 +

[Qemu-devel] [PATCH v7 4/6] qcow2: Add support for ImageInfoSpecific

2013-10-02 Thread Max Reitz
Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific. This contains the compatibility level as a string and an optional lazy_refcounts boolean (optional means mandatory for compat = 1.1 and not available for compat == 0.10). Also, add qcow2_get_specific_info, which returns this

[Qemu-devel] [PATCH v7 3/6] block/qapi: Human-readable ImageInfoSpecific dump

2013-10-02 Thread Max Reitz
Add a function for generically dumping the ImageInfoSpecific information in a human-readable format to block/qapi.c. Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to allow qemu-img info resp. qemu-io -c info to print that format specific information. Signed-off-by: Max

[Qemu-devel] [PATCH v7 6/6] qemu-iotests: Additional info from qemu-img info

2013-10-02 Thread Max Reitz
Add a test for the additional information now provided by qemu-img info when used on qcow2 images. This test only covers the human-readable output, not the JSON dump. Signed-off-by: Max Reitz mre...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- tests/qemu-iotests/065 | 72

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-10-02 Thread Paolo Bonzini
Il 25/09/2013 10:59, Michael S. Tsirkin ha scritto: I couldn't find on PCIe spec any mention that Root Complex Integrated EndPoint must be PCIe. But, from spec 1.3.2.3: - A Root Complex Integrated Endpoint must not require I/O resources claimed through BAR(s). - A Root Complex

Re: [Qemu-devel] [PATCH] coroutine: add ./configure --disable-coroutine-pool

2013-10-02 Thread Stefan Hajnoczi
On Tue, Oct 01, 2013 at 06:44:54PM +0200, Stefan Weil wrote: Am 01.10.2013 09:29, schrieb Gabriel Kerneis: On Tue, Oct 01, 2013 at 07:51:24AM +0200, Stefan Weil wrote: $ wine i386-softmmu/qemu-system-i386 -L pc-bios -cdrom /var/tmp/mini.iso -sdl # or -vnc :1 = Assertion in

Re: [Qemu-devel] [PATCH v6 08/20] block: vhdx - log parsing, replay, and flush support

2013-10-02 Thread Stefan Hajnoczi
On Tue, Oct 01, 2013 at 09:24:53AM -0400, Jeff Cody wrote: On Tue, Oct 01, 2013 at 01:31:36PM +0200, Stefan Hajnoczi wrote: On Wed, Sep 25, 2013 at 05:02:53PM -0400, Jeff Cody wrote: +} else if (!memcmp(desc-signature, zero, 4)) { +/* write 'count' sectors of sector */ +

Re: [Qemu-devel] [PATCH v6 00/20] VHDX log replay and write support, .bdrv_create()

2013-10-02 Thread Stefan Hajnoczi
On Tue, Oct 01, 2013 at 10:15:46AM -0400, Jeff Cody wrote: On Tue, Oct 01, 2013 at 03:41:04PM +0200, Stefan Hajnoczi wrote: On Wed, Sep 25, 2013 at 05:02:45PM -0400, Jeff Cody wrote: This patch series contains the initial VHDX log parsing, replay, write support, and image creation.

Re: [Qemu-devel] [PATCH] qcow2: Correct endianness in overlap check

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 08:59:28AM +0200, Max Reitz wrote: If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz mre...@redhat.com --- block/qcow2-refcount.c | 4 ++-- 1 file

Re: [Qemu-devel] [PATCH v5 05/14] xics: add pre_save/post_load dispatchers

2013-10-02 Thread David Gibson
On Thu, Sep 26, 2013 at 04:18:39PM +1000, Alexey Kardashevskiy wrote: The upcoming support of in-kernel XICS will redefine migration callbacks for both ICS and ICP so classes and callback pointers are added. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Looks ok. Reviewed-by: David

Re: [Qemu-devel] Attaching PCI devices to the PCIe root complex

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 10:53:07AM +0200, Paolo Bonzini wrote: Il 25/09/2013 10:59, Michael S. Tsirkin ha scritto: I couldn't find on PCIe spec any mention that Root Complex Integrated EndPoint must be PCIe. But, from spec 1.3.2.3: - A Root Complex Integrated Endpoint must not

Re: [Qemu-devel] [PATCH] qcow2: CHECK_OFLAG_COPIED is obsolete

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 09:21:07AM +0200, Max Reitz wrote: CHECK_OFLAG_COPIED as a parameter to check_refcounts_l1 and check_refcounts_l2 is obselete now, since the OFLAG_COPIED consistency check is actually no longer performed by these functions (but by check_oflag_copied). Signed-off-by:

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-10-02 Thread Stefan Hajnoczi
On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use bs-filename. Signed-off-by: Dunrong Huang riegama...@gmail.com --- block.c | 4 ++--

[Qemu-devel] [PATCH] Correction of the TLB handling of the OpenRISC target

2013-10-02 Thread Sebastian Macke
Hi, this patch corrects two problems for the OpenRISC Target in QEMU. The first one corrects one obvious bug concerning the handling of page faults while reading from a page. The second part removes a non-conforming behavior for the first page of the memory. I have tested this patch with

Re: [Qemu-devel] [OpenRISC] [PATCH] Correction of the TLB handling of the OpenRISC target

2013-10-02 Thread Stefan Kristiansson
On Wed, Oct 2, 2013 at 8:33 AM, Jia Liu pro...@gmail.com wrote: Hi Sebastian, On Wed, Oct 2, 2013 at 1:12 PM, Sebastian Macke sebast...@macke.de wrote: Hi, this patch corrects two problems for the OpenRISC Target in QEMU. The first one corrects one obvious bug concerning the

Re: [Qemu-devel] [OpenRISC] [PATCH] Correction of the TLB handling of the OpenRISC target

2013-10-02 Thread Sebastian Macke
Hi Jia, On 10/1/2013 10:33 PM, Jia Liu wrote: Hi Sebastian, On Wed, Oct 2, 2013 at 1:12 PM, Sebastian Macke sebast...@macke.de wrote: Hi, this patch corrects two problems for the OpenRISC Target in QEMU. The first one corrects one obvious bug concerning the handling of page faults while

Re: [Qemu-devel] Minimal Qemu build for Plan9

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 04:00:05AM -0400, Ashish Kaila wrote: Additionally if someone could point me to a to-do list of things to look out for while porting Qemu on a new platform (new OS/hardware), I would be extremely grateful. Has glib been ported to Plan 9? You need it since much of QEMU

[Qemu-devel] [PULL 0/1] chardev: handle qmp_chardev_add(KIND_MUX) failure

2013-10-02 Thread Gerd Hoffmann
Hi, Single chardev fix, $subject says all. please pull, Gerd The following changes since commit a684f3cf9b9b9c3cb82be87aafc463de8974610c: Merge remote-tracking branch 'kraxel/seabios-1.7.3.2' into staging (2013-09-30 17:15:27 -0500) are available in the git repository at:

[Qemu-devel] [PATCH 1/1] chardev: handle qmp_chardev_add(KIND_MUX) failure

2013-10-02 Thread Gerd Hoffmann
Cc: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- qemu-char.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/qemu-char.c b/qemu-char.c index f7f5464..2ca34cd 100644 --- a/qemu-char.c +++ b/qemu-char.c @@ -3271,7 +3271,12 @@

Re: [Qemu-devel] About the IO queue inside qemu

2013-10-02 Thread Stefan Hajnoczi
On Wed, Oct 02, 2013 at 01:28:11AM -0500, Yaodong Yang wrote: I'm wondering is there any io queue inside qemu? Is there any IO scheduling inside it? I notice that there is an IO track feature inside block.c, but I do not know the purpose of it. Could someone explain it for me? Thanks a lot!

[Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows

2013-10-02 Thread Sebastian Ottlik
This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with calls to the new function socket_set_fast_reuse. On Windows systems the default behaviour is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR can still be set but results in undesired behaviour in

[Qemu-devel] [PATCH v6 1/5] util: add socket_set_fast_reuse function which will replace setting SO_REUSEADDR

2013-10-02 Thread Sebastian Ottlik
If a socket is closed it remains in TIME_WAIT state for some time. On operating systems using BSD sockets the endpoint of the socket may not be reused while in this state unless SO_REUSEADDR was set on the socket. On windows on the other hand the default behaviour is to allow reuse (i.e. identical

[Qemu-devel] [PATCH v6 2/5] gdbstub: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik ott...@fzi.de --- gdbstub.c |6 ++ 1 file

[Qemu-devel] [PATCH v6 4/5] slirp: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik ott...@fzi.de --- slirp/misc.c |3 +--

[Qemu-devel] [PATCH v6 5/5] util: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. Signed-off-by: Sebastian Ottlik ott...@fzi.de --- util/qemu-sockets.c |6 +++---

[Qemu-devel] [PATCH v6 3/5] net: call socket_set_fast_reuse instead of setting SO_REUSEADDR

2013-10-02 Thread Sebastian Ottlik
SO_REUSEADDR should be avoided on Windows but is desired on other operating systems. So instead of setting it we call socket_set_fast_reuse that will result in the appropriate behaviour on all operating systems. An exception to this rule are multicast sockets where it is sensible to have multiple

[Qemu-devel] [PATCH RFC 01/11] s390/qemu: cpu modle disable list cpus

2013-10-02 Thread Michael Mueller
The patch disables the early invocation of list_cpus() to allow the dynamically initialization of all S390 cpu classes in current host runtime context. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- vl.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/vl.c

[Qemu-devel] [PATCH RFC 02/11] s390/qemu: cpu model extend config device

2013-10-02 Thread Michael Mueller
This patch extends the s390 config device interface by the following attributes used to impelemt cpu models: - KVM_DEV_S390_CONFIG_CPU_TYPE - KVM_DEV_S390_CONFIG_CPU_FACILITIES - KVM_DEV_S390_CONFIG_KVM_FACILITY_MASK Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com ---

[Qemu-devel] [PATCH RFC 06/11] s390/qemu: cpu model KVM properties requests

2013-10-02 Thread Michael Mueller
This patch implements the functions s390_fetch_kvm_host_props() and s390_request_kvm_cpu_config(). They respectively retrieve or request the machine type, cpu facilities and KVM facility mask supported by the host. Both functions are based on the s390 configuration device interface.

[Qemu-devel] [PATCH RFC 11/11] s390/qemu: cpu model enablement

2013-10-02 Thread Michael Mueller
This patch enables all previous cpu model related patches and allows the feature to become active. It basically implements the host properties being fetched from the host and applied to the predefined S390 cpu classes during initialization of the HW platform. In a second step, the requeted cpu

[Qemu-devel] [PATCH RFC 00/11] s390 cpu models for KVM accelerator

2013-10-02 Thread Michael Mueller
The following patch set implements S390 cpu models in KVM accellerator context. It is currently based on a configuration device interface not yet published for RFC. The implementation can as well be used to feed the currently discussed TCG related facility representation. Michael Mueller (11):

[Qemu-devel] [PATCH RFC 07/11] s390/qemu: cpu model class initialization

2013-10-02 Thread Michael Mueller
This patch provides routines to dynamically update the previously defined s390 cpu classes in the current host context. The main function issuing this process is s390_setup_cpu_classes(). It takes the current host context as parameter to setup the classes accordingly. It basically performs the

[Qemu-devel] [PATCH RFC 03/11] s390/qemu: cpu model cpu class definition

2013-10-02 Thread Michael Mueller
This patch implements the static part of the s390 cpu class definitions. It defines single cpu models by means of virtual cpu ids which contain information on the cpu generation, the machine class, the GA number and the machine type. The cpu id is used to instantiate a cpu classes per cpu id.

[Qemu-devel] [PATCH RFC 08/11] s390/qemu: cpu model command line option help

2013-10-02 Thread Michael Mueller
This patch provides a list of supported cpu models and aliases in the current host context. See command line option -cpu {help|?} The returned list is determined from the current host and and contains also well know alias names. It is sorted by appearance of the respective system: s390 2064-ga1

[Qemu-devel] [PATCH RFC 04/11] s390/qemu: cpu model cpu facilitiy support

2013-10-02 Thread Michael Mueller
This patch defines s390 cpu facilities and their appearance/disappearance. The implemented functions allow to calculate cpu model specific facility sets. These sets are assiciated to the defiend cpu classes used to calculate the list of supported cpu models. Signed-off-by: Michael Mueller

[Qemu-devel] [PATCH RFC 05/11] s390/qemu: cpu model alias support

2013-10-02 Thread Michael Mueller
This patch implements the infrastructure to dynamically add cpu model aliases. Signed-off-by: Michael Mueller m...@linux.vnet.ibm.com --- target-s390x/cpu-models.c | 66 +++ target-s390x/cpu-models.h | 11 2 files changed, 77 insertions(+)

Re: [Qemu-devel] [PULL 08/11] iscsi: add .bdrv_get_block_status

2013-10-02 Thread Peter Lieven
Am 19.09.2013 15:46, schrieb Paolo Bonzini: Il 19/09/2013 09:24, Peter Lieven ha scritto: do we still need this patch? if yes I can sent one shortly. No, Stefan prepared it. I'll send a pull request shortly. The patch disables iscsi_get_block_status completely. The C preprocessor can't check

[Qemu-devel] [PATCH RFC 09/11] s390/qemu: cpu model QMP query-cpu-definitions

2013-10-02 Thread Michael Mueller
This patch implements the QMP command query-cpu-definitions in the S390 context. The command returns a descending sorted list of cpu model names derived from the currently (in the current host context) supported set of cpu classes. That means a consumer can successfully request each reported cpu

[Qemu-devel] [PATCH RFC 10/11] s390/qemu: cpu model QMP query-cpu-model

2013-10-02 Thread Michael Mueller
This patch implements a new QMP request named cpu-model. It returns the cpu model of cpu 0. eg: request: '{execute : query-cpu-model } answer: '{return : 2817-ga1 } Alias names are resolved to their respactive machine type and GA names already during cpu instantiation. Thus, also a cpu name

[Qemu-devel] [PATCH] block/iscsi: reenable iscsi_co_get_block_status

2013-10-02 Thread Peter Lieven
Commit f35c934a accidently disabled iscsi_co_get_block_status for all libiscsi versions. Its not possible to check for enumeration constants in the C preprocessor. This patch changes the check to the preprocessor constant LIBISCSI_FEATURE_IOVECTOR which was introduced shortly after get_lba_status

Re: [Qemu-devel] [PATCH] block/iscsi: reenable iscsi_co_get_block_status

2013-10-02 Thread Paolo Bonzini
Il 02/10/2013 13:52, Peter Lieven ha scritto: Commit f35c934a accidently disabled iscsi_co_get_block_status for all libiscsi versions. Its not possible to check for enumeration constants in the C preprocessor. This patch changes the check to the preprocessor constant LIBISCSI_FEATURE_IOVECTOR

Re: [Qemu-devel] [PATCH RFC 10/11] s390/qemu: cpu model QMP query-cpu-model

2013-10-02 Thread Eric Blake
On 10/02/2013 05:33 AM, Michael Mueller wrote: This patch implements a new QMP request named cpu-model. It returns the cpu model of cpu 0. eg: request: '{execute : query-cpu-model } answer: '{return : 2817-ga1 } Alias names are resolved to their respactive machine type and GA names

Re: [Qemu-devel] [PATCH V3 2/7] qcow2: free allocated cluster on fail in qcow2_write_snapshots()

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:57AM +0800, Wenchao Xia wrote: Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qcow2-snapshot.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/block/qcow2-snapshot.c b/block/qcow2-snapshot.c index

Re: [Qemu-devel] [PATCH V3 6/7] qcow2: print message for error path in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 04:08:53PM -0600, Eric Blake wrote: On 09/08/2013 08:58 PM, Wenchao Xia wrote: The message will be print out with a macro enabled, which can s/print/printed/ be used to check which error path is taken. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH v6 0/5] Do not set SO_REUSEADDR on Windows

2013-10-02 Thread Eric Blake
On 10/02/2013 04:23 AM, Sebastian Ottlik wrote: This patchset disables most uses of SO_REUSEADDR on Windows and replaces it with calls to the new function socket_set_fast_reuse. On Windows systems the default behaviour is equivalent to SO_REUSEADDR on other operating systems. SO_REUSEADDR

Re: [Qemu-devel] [PATCH] block/qcow2: Use bdrv_truncate for size amend

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 12:17:41PM +0200, Max Reitz wrote: When amending the size option for a qcow2 image, use bdrv_truncate instead of qcow2_truncate directly, since the latter will not adjust the total_sectors count in the BDS structure (whereas the former will). Signed-off-by: Max Reitz

[Qemu-devel] [PATCH V4] disable blkverify external snapshot creation

2013-10-02 Thread Benoît Canet
Hello, Here is the new version of the snapshot forbidding patch. v4: do also the check in bs-file-drv (make it work with quorum) [Benoît] v3: functions return an enum [Jeff] rename forbiding function [Kevin] v2: Use NULL fields to avoid having to fill the new field in every

[Qemu-devel] [PATCH V4] block: Add BlockDriver.bdrv_check_ext_snapshot.

2013-10-02 Thread Benoît Canet
This field is used by blkverify to disable external snapshots creation. I will also be used by block filters like quorum to disable external snapshots creation. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 17 + block/blkverify.c | 2 ++

[Qemu-devel] [PATCH V9 00/11] Quorum block driver

2013-10-02 Thread Benoît Canet
It must be applied on top of block: Add BlockDriver.bdrv_check_ext_snapshot. This patchset create a block driver implementing a quorum using total qemu disk images. Writes are mirrored on the $total files. For the reading part the $total files are read at the same time and a vote is done to

[Qemu-devel] [PATCH V9 01/11] quorum: Create quorum.c, add QuorumSingleAIOCB and QuorumAIOCB.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs | 1 + block/quorum.c | 54 + 2 files changed, 55 insertions(+) create mode 100644 block/quorum.c diff --git a/block/Makefile.objs b/block/Makefile.objs index

[Qemu-devel] [PATCH V9 10/11] quorum: Add quorum_co_flush().

2013-10-02 Thread Benoît Canet
Makes a vote to select error if any. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 084d030..0a28ab1 100644 --- a/block/quorum.c +++ b/block/quorum.c

[Qemu-devel] [PATCH V9 04/11] blkverify: Extract qemu_iovec_clone() and qemu_iovec_compare() from blkverify.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/blkverify.c | 108 +- include/qemu-common.h | 2 + util/iov.c| 103 +++ 3 files changed, 107 insertions(+), 106 deletions(-) diff

[Qemu-devel] [PATCH V9 02/11] quorum: Create BDRVQuorumState and BlkDriver and do init.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 25 + 1 file changed, 25 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 76a1fbb..9557e61 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -15,6 +15,16 @@ #include block/block_int.h

[Qemu-devel] [PATCH V9 07/11] quorum: Add quorum_getlength().

2013-10-02 Thread Benoît Canet
Check that every bs file return the same length. If not return -EIO to disable the quorum and avoid length discrepancy. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/block/quorum.c

[Qemu-devel] [PATCH V9 05/11] quorum: Add quorum_aio_readv.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/block/quorum.c b/block/quorum.c index b49e3c6..f0fc0e9 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -101,14 +101,23

[Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Marcel Apfelbaum
Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin on each call. Added pci_* wrappers to replace qemu_set_irq, qemu_irq_raise, qemu_irq_lower and qemu_irq_pulse, setting the irq

[Qemu-devel] [PATCH V9 08/11] quorum: Add quorum_invalidate_cache().

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index b3649a4..223ad22 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -565,6 +565,16 @@ static int64_t

[Qemu-devel] [PATCH V9 06/11] quorum: Add quorum mechanism.

2013-10-02 Thread Benoît Canet
Use gnutls's SHA-256 to compare versions. Signed-off-by: Benoit Canet ben...@irqsave.net --- block/Makefile.objs | 2 +- block/quorum.c| 321 +- configure | 36 ++ include/monitor/monitor.h | 2 + monitor.c

[Qemu-devel] [PATCH V9 09/11] quorum: Add quorum_co_get_block_status.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 67 ++ 1 file changed, 67 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 223ad22..084d030 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -171,6

[Qemu-devel] [PATCH RFC v2 4/9] hw/vmxnet3: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
pci_set_irq uses PCI_INTERRUPT_PIN config register to compute device INTx pin to set. An assert is used to ensure that intx received from the quest OS corresponds to PCI_INTERRUPT_PIN. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/net/vmxnet3.c | 13 +++-- 1 file changed,

[Qemu-devel] [PATCH RFC v2 1/9] hw/core: Add interface to allocate and free a single IRQ

2013-10-02 Thread Marcel Apfelbaum
qemu_allocate_irq returns a single qemu_irq. The interface allows to specify an interrupt number. qemu_free_irq frees it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/core/irq.c| 16 include/hw/irq.h | 7 +++ 2 files changed, 23 insertions(+) diff --git

[Qemu-devel] [PATCH V9 11/11] quorum: Add quorum_open() and quorum_close().

2013-10-02 Thread Benoît Canet
Example of command line: -drive if=virtio,file.driver=quorum,\ file.children.0.file.filename=1.qcow2,\ file.children.1.file.filename=2.qcow2,\ file.children.2.file.filename=3.qcow2,\ file.vote_threshold=3 file.blkverify=on with file.vote_threshold=2 and two file can be passed to emulated

[Qemu-devel] [PATCH RFC v2 3/9] hw/pci-bridge: set PCI_INTERRUPT_PIN register before shpc init

2013-10-02 Thread Marcel Apfelbaum
The PCI_INTERRUPT_PIN will be used by shpc init, so was moved before the call to shpc_init. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci-bridge/pci_bridge_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-bridge/pci_bridge_dev.c

[Qemu-devel] [PATCH RFC v2 6/9] hw/xhci: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
pci_set_irq uses PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. Removed irq field from xhci state. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/usb/hcd-xhci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH v2 uq/master 0/2] KVM: issues with XSAVE support

2013-10-02 Thread Paolo Bonzini
Il 13/09/2013 15:55, Paolo Bonzini ha scritto: This series fixes two migration bugs concerning KVM's XSAVE ioctls. The second right now is only a theoretical problem, since the only XSAVE-specific state is AVX and all machines with XSAVE also have AVX. In the future, this will ensure that

[Qemu-devel] [PATCH RFC v2 7/9] hw: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. An irq is allocated using pci_allocate_irq wrapper only if is needed by non pci devices. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/audio/ac97.c

[Qemu-devel] [PATCH RFC v2 8/9] hw/pcie: AER and hot-plug events must use device's interrupt

2013-10-02 Thread Marcel Apfelbaum
The fields hpev_intx and aer_intx were removed because both AER and hot-plug events must use device's interrupt. Assert/deassert interrupts using pci_set_irq wrapper instead. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci/pcie.c | 4 ++-- hw/pci/pcie_aer.c | 4 ++--

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:27PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin on each call. Added pci_* wrappers to replace

Re: [Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:25PM +0300, Marcel Apfelbaum wrote: Note: Added RFC because not all affected devices were checked yet. What do you have in mind exactly? Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not

[Qemu-devel] [PATCH RFC v2 5/9] hw/vfio: set interrupts using pci irq wrappers

2013-10-02 Thread Marcel Apfelbaum
pci_set_irq and the other pci irq wrappers use PCI_INTERRUPT_PIN config register to compute device INTx pin to assert/deassert. Save INTx pin into the config register before calling pci_set_irq Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/misc/vfio.c | 11 ++- 1 file

[Qemu-devel] [PATCH RFC v2 9/9] hw/pci: removed irq field from PCIDevice

2013-10-02 Thread Marcel Apfelbaum
Instead of exposing the the irq field, pci wrappers to qemu_set_irq or qemu_irq_* can be used. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/pci/pci.c | 2 -- include/hw/pci/pci.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/hw/pci/pci.c b/hw/pci/pci.c index

[Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Marcel Apfelbaum
Note: Added RFC because not all affected devices were checked yet. Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx pin. Added pci_* wrappers to replace qemu_set_irq,

Re: [Qemu-devel] [PATCH RFC v2 2/9] hw/pci: add pci wrappers for allocating and asserting irqs

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 15:54 +0300, Michael S. Tsirkin wrote: On Wed, Oct 02, 2013 at 03:41:27PM +0300, Marcel Apfelbaum wrote: Interrupt pin is selected and saved into PCI_INTERRUPT_PIN register during device initialization. Devices should not call directly qemu_set_irq and specify the INTx

Re: [Qemu-devel] [PATCH] block/qcow2: Use bdrv_truncate for size amend

2013-10-02 Thread Max Reitz
On 2013-10-02 14:32, Stefan Hajnoczi wrote: On Mon, Sep 09, 2013 at 12:17:41PM +0200, Max Reitz wrote: When amending the size option for a qcow2 image, use bdrv_truncate instead of qcow2_truncate directly, since the latter will not adjust the total_sectors count in the BDS structure (whereas

[Qemu-devel] [PATCH V9 03/11] quorum: Add quorum_aio_writev and its dependencies.

2013-10-02 Thread Benoît Canet
Signed-off-by: Benoit Canet ben...@irqsave.net --- block/quorum.c | 123 + 1 file changed, 123 insertions(+) diff --git a/block/quorum.c b/block/quorum.c index 9557e61..b49e3c6 100644 --- a/block/quorum.c +++ b/block/quorum.c @@ -64,11

Re: [Qemu-devel] [PATCH RFC v2 0/9] hw/pci: set irq without selecting INTx pin

2013-10-02 Thread Marcel Apfelbaum
On Wed, 2013-10-02 at 15:58 +0300, Michael S. Tsirkin wrote: On Wed, Oct 02, 2013 at 03:41:25PM +0300, Marcel Apfelbaum wrote: Note: Added RFC because not all affected devices were checked yet. What do you have in mind exactly? Sanity test for *all* modified devices. Any other

Re: [Qemu-devel] [PATCH RFC v2 1/9] hw/core: Add interface to allocate and free a single IRQ

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:41:26PM +0300, Marcel Apfelbaum wrote: qemu_allocate_irq returns a single qemu_irq. The interface allows to specify an interrupt number. qemu_free_irq frees it. Signed-off-by: Marcel Apfelbaum marce...@redhat.com --- hw/core/irq.c| 16

Re: [Qemu-devel] [PATCH v2 0/9] target-s390 tcg improvements

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 19:17, Richard Henderson wrote: Changes v1-v2: * Squashed patches 1, 2, 4. The feedback from patch 1 called for a re-ordering of the patch set to better deal with STFL, but I could not find an ordering that worked well. I think this is probably just as clear as

Re: [Qemu-devel] [Bug 1233225] Re: mips/mipsel linux user float division problem

2013-10-02 Thread Peter Maydell
On 2 October 2013 14:22, Stefan Weil s...@weilnetz.de wrote: The original bug report said that it runs in QEMU system emulation (which I did not test because of lack of time). As system emulation uses the same cpu, it should be fine. ...that's what prompted me to ask, actually -- system

Re: [Qemu-devel] [PATCH 1/7] usb: remove old usb-host code

2013-10-02 Thread Jan Kiszka
On 2013-09-19 11:34, Gerd Hoffmann wrote: The usb-host code has been rewritten for qemu 1.5 to use libusb, the old code has been left in as temporary fallback. Now we are two releases further out, targeting the 1.7 release. No major issues with the new code poped up until now. Time to

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Igor Mammedov
On Wed, 2 Oct 2013 00:26:11 +0300 Michael S. Tsirkin m...@redhat.com wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I think it's reasonable to merge it and then refactor as QOM

Re: [Qemu-devel] [PATCH] block: vhdx - add migration blocker

2013-10-02 Thread Stefan Hajnoczi
On Tue, Oct 01, 2013 at 11:59:20AM -0400, Jeff Cody wrote: This blocks migration for VHDX image files, until the functionality can be supported. Signed-off-by: Jeff Cody jc...@redhat.com --- block/vhdx.c | 10 ++ 1 file changed, 10 insertions(+) Strictly speaking live migration

Re: [Qemu-devel] [PATCH V3 1/7] qcow2: restore nb_snapshots when fail in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:56AM +0800, Wenchao Xia wrote: If it is not restored after qcow2_write_snapshots() fail, a core dump will happen in bdrv_close() since access of invalid pointer. Signed-off-by: Wenchao Xia xiaw...@linux.vnet.ibm.com --- block/qcow2-snapshot.c |4 +++- 1

Re: [Qemu-devel] [PATCH V3 0/7] qcow2: rollback the modification on fail in snapshot creation

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 09, 2013 at 10:57:55AM +0800, Wenchao Xia wrote: V2: 1: all fail case will goto fail section. 2: add the goto code. v3: Address Stefan's comments: 2: don't goto fail after allocation failure. 3: use sn-l1size correctly in qcow2_free_cluster(). 4-7: add test case to

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: On Wed, 2 Oct 2013 00:26:11 +0300 Michael S. Tsirkin m...@redhat.com wrote: This code can also be found here: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git acpi While this patch still uses info not available in QOM, I

Re: [Qemu-devel] [PATCH] qcow2: Switch L1 table in a single sequence

2013-10-02 Thread Stefan Hajnoczi
On Mon, Sep 30, 2013 at 05:57:21PM +0200, Max Reitz wrote: Switching the L1 table in memory should be an atomic operation, as far as possible. Calling qcow2_free_clusters on the old L1 table on disk is not a good idea when the old L1 table is no longer valid and the address to the new one

Re: [Qemu-devel] [PATCH] block: use correct filename for error report

2013-10-02 Thread Dunrong Huang
On Wed, Oct 2, 2013 at 5:48 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Sep 24, 2013 at 06:14:01PM +0800, Dunrong Huang wrote: The content filename point to will be erased by qemu_opts_absorb_qdict() in raw_open_common() in drv-bdrv_file_open() So it's better to use

[Qemu-devel] [Bug 1234179] [NEW] QEMU segfaults during Windows 7 unattended install

2013-10-02 Thread Lucas Meneghel Rodrigues
Public bug reported: During today's automated qemu.git testing, a segmentation fault while installing Windows 7 SP1 happened. qemu.git top commit: 10/02 01:30:24 INFO | git:0150| git commit ID is a684f3cf9b9b9c3cb82be87aafc463de8974610c (tag v1.4.0-4237-ga684f3c) commit

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Igor Mammedov
On Wed, 2 Oct 2013 16:30:36 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: On Wed, 2 Oct 2013 00:26:11 +0300 Michael S. Tsirkin m...@redhat.com wrote: This code can also be found here:

Re: [Qemu-devel] [PATCH -V4 2/4] target-ppc: Fix page table lookup with kvm enabled

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 03:27, Aneesh Kumar K.V wrote: Alexander Graf ag...@suse.de writes: On 09/05/2013 10:16 AM, Aneesh Kumar K.V wrote: From: Aneesh Kumar K.Vaneesh.ku...@linux.vnet.ibm.com With kvm enabled, we store the hash page table information in the hypervisor. Use ioctl to read

Re: [Qemu-devel] [PATCH v7 00/27] qemu: generate acpi tables for the guest

2013-10-02 Thread Michael S. Tsirkin
On Wed, Oct 02, 2013 at 03:52:17PM +0200, Igor Mammedov wrote: On Wed, 2 Oct 2013 16:30:36 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Wed, Oct 02, 2013 at 03:05:52PM +0200, Igor Mammedov wrote: On Wed, 2 Oct 2013 00:26:11 +0300 Michael S. Tsirkin m...@redhat.com wrote:

Re: [Qemu-devel] [PATCH -V4 RESEND 0/6] target-ppc: Add support for dumping guest memory using qemu gdb server

2013-10-02 Thread Alexander Graf
On 01.10.2013, at 18:19, Aneesh Kumar K.V wrote: Hi, This patch series implement support for dumping guest memory using qemu gdb server. The last patch also enable qemu monitor command dump-guest-memory Thanks, applied all but 2/6 to ppc-next. I think the core dump bits should be more

[Qemu-devel] [PATCHv4] block/get_block_status: avoid redundant callouts on raw devices

2013-10-02 Thread Peter Lieven
if a raw device like an iscsi target or host device is used the current implementation makes a second call out to get the block status of bs-file. however, the raw driver already has called bdrv_get_block_status on bs-file. v4: use a flag to detect the raw driver instead of the strncmp hack.

Re: [Qemu-devel] [PATCH RFC 10/11] s390/qemu: cpu model QMP query-cpu-model

2013-10-02 Thread Michael Mueller
On Wed, 02 Oct 2013 06:06:32 -0600 Eric Blake ebl...@redhat.com wrote: On 10/02/2013 05:33 AM, Michael Mueller wrote: This patch implements a new QMP request named cpu-model. It returns the cpu model of cpu 0. eg: request: '{execute : query-cpu-model } answer: '{return : 2817-ga1 }

  1   2   >