Stephanie Taylor at the Google Open Source Blog has helped us publish
a post that features two projects from this year's Google Summer of
Code:
http://google-opensource.blogspot.de/2013/10/google-summer-of-code-veteran-orgs-qemu.html
Mike and Osier contributed summaries of the "QEMU Integrated
Co
There is errp passed in, so no need for local_err and error_propagate.
Signed-off-by: Fam Zheng
---
block/mirror.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/mirror.c b/block/mirror.c
index 7b95acf..f2e9558 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -50
There is only one failure point: bdrv_change_backing_file in this
function, so we can drop the qlist and try to change the backing file
before deleting anything.
This way bdrv_drop_intermediate is simplified while keeping the
operation transactional. A bonus is dropping an active BDS is supported
On Fri, 10/11 11:18, Wolfgang Richter wrote:
> Idea: Introduce a mode for drive-backup that duplicates writes to
> another target, not CoW. It is useful for introspecting (my use
> case), and for keeping a remote block device in sync with writes
> (helps with migration or backup).
>
>
>
> Issue
于 2013/10/11 21:35, Stefan Hajnoczi 写道:
On Fri, Oct 11, 2013 at 04:55:31PM +0800, Wenchao Xia wrote:
+/* Recursive FIFO lock
+ *
+ * This lock provides more features than a plain mutex:
+ *
+ * 1. Fairness - enforces FIFO order.
+ * 2. Nesting - can be taken recursively.
+ * 3. Contention callba
Public bug reported:
Pascal uses ^Vidmem for B800 console output. The terminal does not
oblige the Pascal OS code to scroll the output. Virtualbox emulation
works, so this must be a qemu bug. Using QEMU in KVM mode as Ubuntu LTS.
Source line to trip bug(in theory pushes VideoMem up one line):
pr
On Fri, Oct 11, 2013 at 11:35 AM, Stefan Hajnoczi wrote:
> On Thu, Oct 10, 2013 at 11:14:22PM +0100, Gabriel Kerneis wrote:
> > We were so excited about our QEMU/CPC GSoC project that we have decided
> > to write a 12-page article to share our experience:
> >
> >QEMU/CPC: static analys
> [1] http://gabriel.kerneis.info/research/files/kerneis-phd-thesis.pdf
> [2] http://gabriel.kerneis.info/research/files/cpc-2012.pdf
>
> Looks like you ruined my evening!
> > This indeed deserve some congrats, and looks interesting. Do you have an
> > epub version, so that one can study this con
On 10/11/2013 04:08 PM, Stefan Weil wrote:
> Am 11.10.2013 22:03, schrieb Don Koch:
>> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>>> * it's -> its
>>> * grammar fix in ui/vnc-enc-zywrle.h
>>>
>>> Signed-off-by: Stefan Weil
>>> ---
>>>
>>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>
From: Peter Maydell [peter.mayd...@linaro.org]
Sent: Friday, October 11, 2013 9:10 PM
To: Petar Jovanovic
Cc: QEMU Developers; QEMU Trivial; Riku Voipio; Petar Jovanovic; Aurelien Jarno
Subject: Re: [Qemu-devel] [PATCH] linux-user: pass correct parameter to
On 10/11/2013 04:10 PM, Peter Maydell wrote:
> On 12 October 2013 05:03, Don Koch wrote:
>> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>>> * it's -> its
>>> * grammar fix in ui/vnc-enc-zywrle.h
>>>
>>> Signed-off-by: Stefan Weil
>>> ---
>>>
>>> This is v3 of http://patchwork.ozlabs.org/patch/2574
On 12 October 2013 04:34, Stefan Weil wrote:
> * it's -> its
> * grammar fix in ui/vnc-enc-zywrle.h
>
> Signed-off-by: Stefan Weil
Reviewed-by: Peter Maydell
-- PMM
On 12 October 2013 05:03, Don Koch wrote:
> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>> * it's -> its
>> * grammar fix in ui/vnc-enc-zywrle.h
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>>
>> v3:
>> Don't try to improve a strange senten
On 10/11/2013 02:03 PM, Don Koch wrote:
>> In this method, H/L and X0/X1 is always same position.
>> - This lead us to more speed and less memory.
>> + This leads us to more speed and less memory.
>> Of cause, the result of both method is quite same
>> because it's only difference that coeff
Am 11.10.2013 22:03, schrieb Don Koch:
> On 10/11/2013 03:34 PM, Stefan Weil wrote:
>> * it's -> its
>> * grammar fix in ui/vnc-enc-zywrle.h
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>>
>> v3:
>> Don't try to improve a strange sentence i
On 10/11/2013 03:34 PM, Stefan Weil wrote:
> * it's -> its
> * grammar fix in ui/vnc-enc-zywrle.h
>
> Signed-off-by: Stefan Weil
> ---
>
> This is v3 of http://patchwork.ozlabs.org/patch/257416/.
>
> v3:
> Don't try to improve a strange sentence in the same context ("Of cause
> [...]").
>
>
* it's -> its
* grammar fix in ui/vnc-enc-zywrle.h
Signed-off-by: Stefan Weil
---
This is v3 of http://patchwork.ozlabs.org/patch/257416/.
v3:
Don't try to improve a strange sentence in the same context ("Of cause [...]").
qapi-schema.json|2 +-
slirp/if.c |2 +-
ui/vnc-e
This moves the endian translation functions out from the vhdx.c source,
into a separate source file. In addition to the previously defined
endian functions, new endian translation functions for log support are
added as well.
Signed-off-by: Jeff Cody
---
block/Makefile.objs | 2 +-
block/vhdx-e
Am 11.10.2013 21:12, schrieb Peter Maydell:
> On 12 October 2013 04:06, Stefan Weil wrote:
>> * it's -> its
>> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context
>> a sentence with unclear meaning which could not be fixed was removed.
>>
>> Signed-off-by: Stefan Weil
>> ---
>>
>> This is
This adds some magic number defines, and internal structure definitions
for VHDX log replay support. The struct VHDXLogEntries does not reflect
an on-disk data structure, and thus does not need to be packed.
Some minor code style fixes are applied as well.
Signed-off-by: Jeff Cody
---
block/vh
The non-global option output is suppresed in _make_test_img() for
output verification in the 0?? tests. This adds suppression for
the vhdx-unique options as well. This allows check -vhdx to run
successfully.
Signed-off-by: Jeff Cody
---
tests/qemu-iotests/common.rc | 4 +++-
1 file changed, 3
Just a couple of minor comments to help note where allocated
buffers are freed, and a typo fix.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 6 --
block/vhdx.h | 6 +++---
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 6cb0412..b497c27 100644
On 12 October 2013 04:06, Stefan Weil wrote:
> * it's -> its
> * Grammar fix in ui/vnc-enc-zywrle.h. In the same context
> a sentence with unclear meaning which could not be fixed was removed.
>
> Signed-off-by: Stefan Weil
> ---
>
> This is an update of patch http://patchwork.ozlabs.org/patch/
This patch series contains the initial VHDX log parsing, replay,
write support, and image creation.
=== v7 changes ===
https://github.com/codyprime/qemu-kvm-jtc/tree/vhdx-write-v7-upstream
Rebased to latest qemu/master (picked up vhdx r/o tests, migration blocker)
Patch 8/19: * validate log des
On 11 October 2013 22:03, Petar Jovanovic wrote:
> From: Petar Jovanovic
>
> Fix shmctl issue by passing correct parameter buf to do_shmctl().
Reviewed-by: Peter Maydell
It would be nice if you gave more detail than "shmctl issue"...
(for instance there are some known issues that affect some
a
Bit shifting can be fun, but in this case it was unnecessary. The
upper 44 bits of the 64-bit BAT entry is specifies the File Offset,
so we shifted the bits to get access to the value.
However, per the spec the value is in MB. So we dutifully shifted back
to the left by 20 bits, to convert to a
* it's -> its
* Grammar fix in ui/vnc-enc-zywrle.h. In the same context
a sentence with unclear meaning which could not be fixed was removed.
Signed-off-by: Stefan Weil
---
This is an update of patch http://patchwork.ozlabs.org/patch/257416/
(Spelling fixes).
v2: Don't try to fix a strange se
This removes the IMGFMT_GENERIC blocker for read-only, so existing
iotests run read/write tests for vhdx images created by qemu-img (e.g.
tests 001, 002, 003).
In addition, this updates the sample image test for the Hyper-V
created image, to verify we can write it as well.
Signed-off-by: Jeff Cod
This adds the ability to update the headers in a VHDX image, including
generating a new MS-compatible GUID.
As VHDX depends on uuid.h, VHDX is now a configurable build option. If
VHDX support is enabled, that will also enable uuid as well. The
default is to have VHDX enabled.
To enable/disable
This adds support for writing to VHDX image files, using coroutines.
Writes into the BAT table goes through the VHDX log. Currently, BAT
table writes occur when expanding a dynamic VHDX file, and allocating a
new BAT entry.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 196 +++
Mark Cave-Ayland a écrit :
OpenBIOS prior to SVN r1225 had a horrible bug when accessing PCI
configuration space for PPC Mac architectures - instead of writing the PCI
configuration data value to the data register address, it would instead write
it to the data register address plus the PCI config
In preparation for VHDX log support, move these structures to the
header.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 52
block/vhdx.h | 48
2 files changed, 48 insertions(+), 52 deletions(-)
d
On 12 October 2013 02:38, Alvise Rigo wrote:
> Both KVM and TCG populate the cpreg_list with 64 bit registers IDs, but in
> the TCG side the cpreg_list is sorted using the 32 bit id version while in
> the kvm side the 64 bit id version is used.
> This patch makes the sorting of the cpreg_list co
On 11 October 2013 15:09, Stefan Weil wrote:
> - This lead us to more speed and less memory.
> - Of cause, the result of both method is quite same
> - because it's only difference that coefficient position.
> + This leads us to more speed and less memory.
> + Of course, the result of both methods
This tests the replay of a data sector in a VHDX image file.
The image file is a 10G dynamic image, with 4MB block size. The
image was created with qemu-img, and the log left unplayed by
modification of the vhdx image format driver.
It was verified under both QEMU and Hyper-V that the image file
This adds support for VHDX image creation, for images of type "Fixed"
and "Dynamic". "Differencing" types (i.e., VHDX images with backing
files) are currently not supported.
Options for image creation include:
* log size:
The size of the journaling log for VHDX. Minimum is 1MB,
Regions in the image file cannot overlap - the log, region tables,
and metdata must all be unique and non-overlapping.
This adds region checking by means of a QLIST; there can be a variable
number of regions and metadata (there may be metadata or region tables
that we do not recognize / know about
This adds support for writing to the VHDX log.
For spec details, see VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
There are a few limitations to this log support:
1.) There is no caching yet
2.) The log is flushed after each entry
The primary wr
VHDXPage83Data and VHDXParentLocatorHeader both incorrectly had their
MSGUID fields set as arrays of 16. This is incorrect (it stems from
an early version where those fields were uint_8 arrays). Those fields
were, up to this patch, unused.
Also, there were a couple of typos and incorrect wording
This is preperation for vhdx_create(). The ability to write headers,
and calculate the number of BAT entries will be needed within the
create() functions, so move this relevant code into helper functions.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 121 +++---
Allow tracking of first file write in the VHDX image, as well as
the ability to update the GUID in the header. This is in preparation
for log support.
Signed-off-by: Jeff Cody
---
block/vhdx.c | 30 --
block/vhdx.h | 6 ++
2 files changed, 30 insertions(+), 6 de
Signed-off-by: Jeff Cody
---
block/vhdx.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 241703a..3f06ce3 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -778,6 +778,17 @@ exit:
}
+static void vhdx_close(BlockDri
In preparation for vhdx_create(), move more endian translation
functions out to vhdx-endian.c.
Signed-off-by: Jeff Cody
---
block/vhdx-endian.c | 75 +
block/vhdx.c| 20 +++---
block/vhdx.h| 9 ++-
3 files changed,
This adds support for VHDX v0 logs, as specified in Microsoft's
VHDX Specification Format v1.00:
https://www.microsoft.com/en-us/download/details.aspx?id=34750
The following support is added:
* Log parsing, and validation - validate that an existing log
is correct.
* Log search - search throug
On Thu, Sep 12, 2013 at 9:46 PM, Laszlo Ersek wrote:
> When qemu dies unexpectedly, for example in response to an explicit
> abort() call, or (more importantly) when an external signal is delivered
> to it that results in a coredump, sometimes it is useful to extract the
> guest vmcore from the qe
From: Max Reitz
Make use of the error parameter in the opening and creating functions in
block/raw-win32.c.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/raw-win32.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/block/raw-win32.c b/block/
The main intent of this patch is to consolidate the whitelist checks to
a single point in the code instead of spreading it everywhere. This adds
a nicer error message for read-only whitelisting, too, in places where
it was still missing.
The patch also contains a bonus bug fix: By finding the form
From: Max Reitz
Add a new ImageInfoSpecificQCow2 type as a subtype of ImageInfoSpecific.
This contains the compatibility level as a string and an optional
lazy_refcounts boolean (optional means mandatory for compat >= 1.1 and
not available for compat == 0.10).
Also, add qcow2_get_specific_info,
The compare_u64 function was not sorting the KVM cpreg_list in the right way
due to the wrong returned value. Since we are comparing two 64bit values we
can't simply return their difference if the returned type is int.
Signed-off-by: Alvise Rigo
---
target-arm/kvm.c | 6 +-
1 file changed,
Both KVM and TCG populate the cpreg_list with 64 bit registers IDs, but in the
TCG side the cpreg_list is sorted using the 32 bit id version while in the kvm
side the 64 bit id version is used.
This patch makes the sorting of the cpreg_list consistent between KVM and TCG.
Signed-off-by: Alvise R
From: Max Reitz
qcow2_write_snapshots does contain a fail label and there is no reason
not to use it on some errors; therefore, we should always jump there on
error.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 7 ---
1 file changed, 4 insertions(+), 3 d
This moves as much as possible of the processing of the 'media' option
to drive_init so that it can only be accessed using legacy functions,
but never with anything blockdev-add related.
Signed-off-by: Kevin Wolf
Reviewed-by: Benoit Canet
Reviewed-by: Eric Blake
---
blockdev.c | 73 +++
From: Max Reitz
Add a function for generically dumping the ImageInfoSpecific information
in a human-readable format to block/qapi.c.
Use this function in bdrv_image_info_dump and qemu-io-cmds.c:info_f to
allow qemu-img info resp. qemu-io -c info to print that format specific
information.
Signed
From: Max Reitz
Evaluate the runtime overlap check options and set
BDRVQcowState.overlap_check appropriately.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 29 -
1 file changed, 28 insertions(+), 1 deletion(-)
diff --git a/block/qcow2.c b/
From: "Michael S. Tsirkin"
ATM we set AHCI mode on 1st GHC write.
Spec says we should set it on reset.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Kevin Wolf
---
hw/ide/ahci.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c
inde
From: Jeff Cody
This adds the VHDX format to the qemu-iotests format, and adds
a read test. The test reads from an existing sample image, that
was created with Hyper-V under Windwos Server 2012.
The image file is a 1GB dynamic image, with 32MB blocks.
The pattern 0xa5 exists from 0MB-33MB (pas
From: Max Reitz
Add an option to the open command to specify runtime options for the
block driver used.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
qemu-io.c | 39 +++
1 file changed, 31 insertions(+), 8 deletions(-)
diff --git a/qemu-io.c b/qem
Alexander Graf writes:
> On 11.10.2013, at 13:13, Aneesh Kumar K.V
> wrote:
>
>> From: "Aneesh Kumar K.V"
>>
>> With kvm enabled, we store the hash page table information in the hypervisor.
>> Use ioctl to read the htab contents. Without this we get the below error when
>> trying to read the
BlockDriverStates shouldn't be affected by an unplugged guest device,
except if created with the legacy -drive command line option or the
drive_add HMP command.
Make the automatic deletion as well as cancelling of jobs conditional on
an enable_auto_del boolean that is only set in drive_init().
Si
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
blockdev.c | 54 +++---
1 file changed, 27 insertions(+), 27 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index b543f6d..b11155c 100644
--- a/blockdev.c
+++ b/block
From: Max Reitz
If an error occurs during qcow2_write_snapshots, the newly allocated
snapshot table clusters are leaked and should thus be freed.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/qcow2-snapshot.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/qcow2-s
From: Fam Zheng
Move the blank line to above the test step banner, so it looks clearer
in blocks.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/059 | 8
tests/qemu-iotests/059.out | 8
2 files changed, 8 insertions(+), 8 deletions(-)
diff --g
This moves all of the geometry options (cyls/heads/secs/trans) to
drive_init so that they can only be accessed using legacy functions, but
never with anything blockdev-add related.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
blockdev.c | 136 +++
From: Wenchao Xia
This command will package the clean operations in tests. Now root Makefile
simply calls the command and do not care the details of it any more. Original
the built binaries for test will not be removed, now they will be deleted
in clean operation.
Signed-off-by: Wenchao Xia
Rev
From: Max Reitz
Extend 060 by a test which creates a corrupted image with an active L2
entry pointing to an inactive L2 table and writes to the corresponding
guest offset.
Also, use overlap-check=all for all tests in 060.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iote
Am 11.10.2013 09:55, schrieb Stefan Hajnoczi:
> On Thu, Oct 10, 2013 at 07:42:30PM +0200, Stefan Weil wrote:
>> Am 10.10.2013 11:39, schrieb Stefan Hajnoczi:
>>> qemu.org is held by a third-party and no core community contributor has
>>> access to the DNS configuration. This leaves the website exp
From: Max Reitz
Add a test for the additional information now provided by qemu-img info
when used on qcow2 images. It also tests the qemu QMP output from the
query-block command when running qemu with different runtime options
than specified in the image (ImageInfoSpecific should always refer to
From: Max Reitz
Add a new test case for discarding preallocated zero clusters; doing
this should not result in any leaks.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/066 | 63 ++
tests/qemu-iotests/066.out | 13
From: Fam Zheng
An extra 'p++' after while loop when *p == '\n' will move p to unknown
data position, risking parsing junk data or memory access violation.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 7 +--
1 file changed, 5 insertions(
Hi,
> BTW: what about OVMF and core boot, how would they know that there is more
> then 1Tb RAM?
They should look at fw_cfg too. Both have support for fw_cfg already,
but don't parse the e820 table today. Shouldn't be that hard to add
though.
cheers,
Gerd
Upstream OpenBIOS now implements SBus probing in order to determine the
contents of a physical bus slot, which is required to allow OpenBIOS to
identify the framebuffer without help from the fw_cfg interface.
SBus probing works by detecting the presence of an FCode program
(effectively tokenised F
This is an updated version of the previous patch with the following changes:
v2:
- Rebased onto git master
- Move FCode ROM load from sun4m board to TCX device
- Update README file to reflect origin of QEMU,tcx.bin ROM
- Add QEMU,tcx.bin ROM to Makefile so it is copied to the correct place
This introduces a new 'base' key for struct definitions that refers to
another struct type. On the JSON level, the fields of the base type are
included directly into the same namespace as the fields of the defined
type, like with unions. On the C level, a pointer to a struct of the
base type is inc
For examples see the changes to qmp-commands.hx.
Signed-off-by: Kevin Wolf
---
blockdev.c | 57 ++
qapi-schema.json | 236 +++
qmp-commands.hx | 55 +
3 files changed, 348 insertions(+)
diff --git a/blockdev.c
blockdev-add shouldn't automatically generate IDs, but will keep most of
the DriveInfo creation code.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Wenchao Xia
Reviewed-by: Eric Blake
---
blockdev.c| 32 +---
include/qemu/option.h | 1 +
From: Max Reitz
Propagate errors in raw_create rather than directly reporting and
afterwards discarding them.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/raw_bsd.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/block/raw_bsd.c b/block/raw_bsd.c
index d6
From: Peter Lieven
if a raw device like an iscsi target or host device is used
the current implementation makes a second call out to get
the block status of bs->file.
Signed-off-by: Peter Lieven
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block.c | 6 ++
block/raw
On 10/11/2013 05:53 AM, Tom Musta wrote:
>
> This patch series continues adding support for the PowerPC Vector Scalar
> Extension
> (VSX). Patches are relative to the Stage 1 delivery (see
> http://lists.nongnu.org/archive/html/qemu-ppc/2013-09/msg00231.html).
>
> This series adds the following
Using multiple calls to error_report here means every line is
prefaced with the (potentially long) pci-assign command line
arguments.
Use a single error_printf to preserve the intended formatting.
Since this code path is always preceded by an error_report call,
we don't lose the command line repor
On 10/11/2013 02:19 AM, Markus Armbruster wrote:
> Cole Robinson writes:
>
>> Using multiple calls to error_report here means every line is
>> prefaced with the (potentially long) pci-assign command line
>> arguments. Use a single error_report to preserve the intended
>> formatting.
>
> The orth
On 10/11/2013 09:18 AM, Wolfgang Richter wrote:
> Idea: Introduce a mode for drive-backup that duplicates writes to
> another target, not CoW. It is useful for introspecting (my use
> case), and for keeping a remote block device in sync with writes
> (helps with migration or backup).
>
>
>
> T
On 10/11/2013 08:20 AM, Juan Quintela wrote:
> From: Juan Quintela
>
> I am assuming that we are testing all the device pages on the loop, that is
> right?
>
> Signed-off-by: Juan Quintela
> Signed-off-by: Juan Quintela
Double S-o-B throughout the series looks a bit odd. Might be worth
usin
Eric Blake wrote:
> On 10/11/2013 08:20 AM, Juan Quintela wrote:
>> From: Juan Quintela
>>
>> I am assuming that we are testing all the device pages on the loop,
>> that is right?
>>
>> Signed-off-by: Juan Quintela
>> Signed-off-by: Juan Quintela
>
> Double S-o-B throughout the series looks a
Idea: Introduce a mode for drive-backup that duplicates writes to
another target, not CoW. It is useful for introspecting (my use
case), and for keeping a remote block device in sync with writes
(helps with migration or backup).
Issue with current modes: All of the current modes are well-desig
The remaining users shouldn't be there with blockdev-add and are easy to
move to drive_init().
Bonus bug fix: As a side effect, CD-ROM drives can now use block drivers
on the read-only whitelist without explicitly specifying read-only=on,
even if a format is explicitly specified.
Signed-off-by: K
This requires moving the automatic ID generation at the same time, so
let's do that as well.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
blockdev.c | 157 -
1 file changed, 73 insertions(+), 84 deletio
This gives us meaningful error messages for the blockdev-add QMP
command.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
blockdev.c | 56 +++-
1 file changed, 31 insertions(+), 25 deletions(-)
diff --git a/block
Block devices creates with -drive and drive_add should automatically
disappear if the guest device is unplugged. blockdev-add ones shouldn't.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
tests/qemu-iotests/067 | 133
It's already ignored and only prints a deprecation message. No use in
making it available in new interfaces.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
blockdev.c | 21 +++--
1 file changed, 11 insertions(+), 10 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index
It's always IF_NONE for blockdev-add.
Signed-off-by: Kevin Wolf
Reviewed-by: Benoit Canet
Reviewed-by: Eric Blake
---
blockdev.c | 40 ++--
1 file changed, 22 insertions(+), 18 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index 149ddc1..e25f0b8 100644
IF_NONE allows read-only, which makes forbidding it in this place
for other types pretty much pointless.
Instead, make sure that all devices for which the check would have
errored out check in their init function that they don't get a read-only
BlockDriverState. This catches even cases where IF_NO
Working on a QDict instead of a QemuOpts that accepts anything is more
in line with bdrv_open(). A QDict is what qmp_blockdev_add() already has
anyway, so this saves additional conversions. And last, but not least,
it allows later patches to easily extract legacy options into a
separate, typed Qemu
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
scripts/qapi-types.py | 11 ---
scripts/qapi-visit.py | 8 ++--
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/scripts/qapi-types.py b/scripts/qapi-types.py
index 5222463..566fe5e 100644
--- a/scripts/qapi-types.
If a read-only device is configured with copy-on-read=on, the old code
only prints a warning and automatically disables copy on read. Make it
a real error for blockdev-add.
Signed-off-by: Kevin Wolf
Reviewed-by: Max Reitz
Reviewed-by: Eric Blake
---
block.c| 9 +++--
blockdev.c | 31 +
From: Fam Zheng
This is a header flag and we needs sparse for the header.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 4
tests/qemu-iotests/059 | 4
tests/qemu-iotests/059.out | 4
3 files changed, 12 insertions(+)
diff --git a/block
From: Wenchao Xia
Usually we may configure and make, then goto ./tests/qemu-iotest,
check. In this case an error will happen since helper program
was not built. This patch simply build it by default. A better way
may be introducing Makefile in ./tests/qemu-iotest, but it is more
complicate to han
From: Fam Zheng
Convert "fprintf(stderr,..." and standardize error messages:
Remove a few local_error's and use errp.
Remove "VMDK:" or "Vmdk:" prefixes in error message and fix to upper
case.
Signed-off-by: Fam Zheng
Signed-off-by: Kevin Wolf
---
block/vmdk.c | 116 ++
From: Max Reitz
Make use of the error parameter in the opening and creating functions in
block/raw-posix.c.
Signed-off-by: Max Reitz
Signed-off-by: Kevin Wolf
---
block/raw-posix.c | 72 --
tests/qemu-iotests/051.out | 2 +-
2 files change
From: Max Reitz
Add a function for retrieving an ImageInfoSpecific object from a block
driver.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block.c | 9 +
block/qapi.c | 3 +++
include/block/block.h | 1 +
include/b
From: Max Reitz
Introduces the macros QCOW2_OL_CONSTANT and QCOW2_OL_ALL in addition to
the already existing QCOW2_OL_CACHED, signifying all metadata overlap
checks that can be performed in constant time (regardless of image size
etc.) and truly all available overlap checks, respectively.
Signed
1 - 100 of 231 matches
Mail list logo
