Re: [Qemu-devel] [SeaBIOS] [PATCH v2] map 64-bit PCI BARs at location provided by emulator

2013-10-15 Thread Igor Mammedov
On Tue, 15 Oct 2013 11:14:36 +0200 Gerd Hoffmann kra...@redhat.com wrote: Hi, What is the state of the qemu side patches btw? I've them ready but they conflict with you 1Tb in e820 RFC, I can post relevant patches as soon as we agree on this topic. May I pick up your patch and post

Re: [Qemu-devel] Why is TYPE_CPU no-user? (was: [PATCH RFC 0/9] Clean up and fix no_user)

2013-10-15 Thread Peter Maydell
On 15 October 2013 13:24, Markus Armbruster arm...@redhat.com wrote: To go beyond RFC with this series, I need to explain why TYPE_CPU cannot_instantiate_with_device_add_yet. ...isn't this just because it's an abstract type? -- PMM

Re: [Qemu-devel] [SeaBIOS] qemu 1.7 seabios -- release planning

2013-10-15 Thread Kevin O'Connor
On Tue, Oct 15, 2013 at 12:04:05PM +0200, Gerd Hoffmann wrote: Hi, It's probably going to be a bit tough this time. We are pretty late in the qemu 1.7 devel cycle, soft freeze today, and a big chunk of code (ahci-tables-from qemu) which needs seabios support[1] is just about to be

[Qemu-devel] Should the i8259 devices remain no-user? (was: [PATCH RFC 8/9] isa: Clean up use of cannot_instantiate_with_device_add_yet)

2013-10-15 Thread Markus Armbruster
Paolo, or maybe Andreas, To go beyond RFC with this series, I need to explain why isa-i8259 and kvm-i8259 cannot_instantiate_with_device_add_yet, or drop that. I'd appreciate your help. Both are derived from TYPE_PIC_COMMON, which is derived from TYPE_ISA_DEVICE. I figure isa-i8259

Re: [Qemu-devel] [PATCH] linux-user: create target_structs header to place ipc_perm and shmid_ds

2013-10-15 Thread Petar Jovanovic
Ping http://patchwork.ozlabs.org/patch/281527/ Regards, Petar From: Petar Jovanovic [petar.jovano...@rt-rk.com] Sent: Tuesday, October 08, 2013 7:32 PM To: qemu-devel@nongnu.org Cc: Petar Jovanovic; aurel...@aurel32.net; riku.voi...@linaro.org;

Re: [Qemu-devel] guest-dump-memory

2013-10-15 Thread Laszlo Ersek
On 10/14/13 10:18, Phi Debian wrote: Hi All, I tried to subscribe to this list, but never got teh confirm mail. So I write here non subscribed, so add my email addr in replies. I am trying to use guest-dump-memory on arm (arm32, armv7* name it) with qemu 1.6.1. The command is

Re: [Qemu-devel] [ANNOUNCE] We are now in soft freeze for 1.6

2013-10-15 Thread Peter Maydell
On 21 July 2013 13:52, Anthony Liguori aligu...@us.ibm.com wrote: Peter Maydell peter.mayd...@linaro.org writes: I've just noticed that this is still inconsistent. That page says: Soft feature freeze. Major features should have initial code committed by this date. but it links to

Re: [Qemu-devel] Should the i8259 devices remain no-user?

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 14:43, Markus Armbruster ha scritto: Paolo, or maybe Andreas, To go beyond RFC with this series, I need to explain why isa-i8259 and kvm-i8259 cannot_instantiate_with_device_add_yet, or drop that. I'd appreciate your help. Both are derived from TYPE_PIC_COMMON, which is

[Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore

2013-10-15 Thread Laszlo Ersek
Also sort the test-* entries in the latter. Signed-off-by: Laszlo Ersek ler...@redhat.com --- .gitignore | 9 - tests/.gitignore | 11 +-- 2 files changed, 9 insertions(+), 11 deletions(-) diff --git a/.gitignore b/.gitignore index 8e1b73f..7f4c106 100644 --- a/.gitignore

Re: [Qemu-devel] Why is TYPE_CPU no-user?

2013-10-15 Thread Andreas Färber
Hi Markus, Am 15.10.2013 14:24, schrieb Markus Armbruster: To go beyond RFC with this series, I need to explain why TYPE_CPU cannot_instantiate_with_device_add_yet. Would you be so kind and help me out with a suitable comment? From what I remember this was done when I started the whole

[Qemu-devel] Which functions of southbridges should be no-user? (was: [PATCH RFC 0/9] Clean up and fix no_user)

2013-10-15 Thread Markus Armbruster
Andreas, To go beyond RFC with this series, I need to explain why the IDE controller functions of southbridges piix3-ide, piix3-ide-xen, piix4-ide and via-ide cannot_instantiate_with_device_add_yet, or drop that. I'd appreciate your help. Our modelling of PCI devices is weird, to put it

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-10-15 Thread Peter Maydell
On 16 September 2013 13:50, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for it to change (see

Re: [Qemu-devel] [PATCH] .gitignore: ignore qmp-commands.txt

2013-10-15 Thread Luiz Capitulino
On Tue, 15 Oct 2013 10:58:39 +0800 Fam Zheng f...@redhat.com wrote: This file is moved out from QMP/ to BUILD dir, change the ignore file too. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Luiz Capitulino lcapitul...@redhat.com PS: Assuming this will be taken by Michael. ---

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-15 Thread Andreas Färber
Am 15.10.2013 15:21, schrieb Markus Armbruster: Andreas, To go beyond RFC with this series, I need to explain why the IDE controller functions of southbridges piix3-ide, piix3-ide-xen, piix4-ide and via-ide cannot_instantiate_with_device_add_yet, or drop that. I'd appreciate your help.

Re: [Qemu-devel] [PATCH v2] net/net: Change the default mac address of nic

2013-10-15 Thread mike
On 10/15/2013 08:36 PM, Eric Blake wrote: On 10/14/2013 11:07 PM, Stefan Weil wrote: Is it reasonable to get a random mac address in your guest? I don't think so. It would no longer be possible to connect to a guest using ssh, restart that guest and connect again with ssh. Agreed - libvirt

Re: [Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions

2013-10-15 Thread Peter Maydell
Ping^2, seven weeks after initial post and code review. Frankly, our mechanism for committing patches which aren't obviously localised to a specific subsystem sucks :-( It seems like pretty much every time it takes multiple pings and a month or two before anything gets into the tree. (at least

[Qemu-devel] [PULL] target-xtensa queue

2013-10-15 Thread Max Filippov
) are available in the git repository at: git://github.com/OSLL/qemu-xtensa.git tags/20131015-xtensa for you to fetch changes up to ca529f8e13557cc2feb2eee3872d422712d9bcb0: target-xtensa: add in_asm logging (2013-10-15 17:23:46 +0400

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Gerd Hoffmann
On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you could not find the time. I think we are better off merging them for 1.7 and

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you

Re: [Qemu-devel] KVM call for agenda for 2013-10-15

2013-10-15 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. There are no topics for Today agenda, so no call. Later, Juan.

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 6:43 AM, Gerd Hoffmann kra...@redhat.com wrote: On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you could not

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 15:51, Anthony Liguori ha scritto: From 41/43: The interface is actually backwards-compatible with existing PIIX4 ACPI (though not migration compatible). And does AFAIK translate to, I have tested migration from new and old and old and new with this series? I suspect the

Re: [Qemu-devel] Why is TYPE_CPU no-user?

2013-10-15 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 15 October 2013 13:24, Markus Armbruster arm...@redhat.com wrote: To go beyond RFC with this series, I need to explain why TYPE_CPU cannot_instantiate_with_device_add_yet. ...isn't this just because it's an abstract type? Abstract types have

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Igor Mammedov
On Tue, 15 Oct 2013 06:51:30 -0700 Anthony Liguori anth...@codemonkey.ws wrote: On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you

Re: [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore

2013-10-15 Thread Eric Blake
On 10/15/2013 07:10 AM, Laszlo Ersek wrote: Also sort the test-* entries in the latter. Signed-off-by: Laszlo Ersek ler...@redhat.com --- .gitignore | 9 - tests/.gitignore | 11 +-- 2 files changed, 9 insertions(+), 11 deletions(-) This feels backwards to me. I'd

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Gerd Hoffmann
On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review some of the patches, since you didn't respond either all's well or you could not find the time. I think we are better off merging them for 1.7 and

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 7:01 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 15/10/2013 15:51, Anthony Liguori ha scritto: From 41/43: The interface is actually backwards-compatible with existing PIIX4 ACPI (though not migration compatible). And does AFAIK translate to, I have tested

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 06:53:54AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 6:43 AM, Gerd Hoffmann kra...@redhat.com wrote: On Mo, 2013-10-14 at 15:42 -0700, Anthony Liguori wrote: Michael S. Tsirkin m...@redhat.com writes: Anthony, I know you wanted to review some of the

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 7:20 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin m...@redhat.com wrote: On Mon, Oct 14, 2013 at 03:42:37PM -0700, Anthony Liguori wrote: Michael S.

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-10-15 Thread Peter Maydell
On 12 September 2013 11:17, Peter Maydell peter.mayd...@linaro.org wrote: This patch series adds a 'virt' platform which uses the kernel's mach-virt (fully device-tree driven) support to create a simple minimalist platform intended for use for KVM VM guests. The major change here is that

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:17:59AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 7:01 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 15/10/2013 15:51, Anthony Liguori ha scritto: From 41/43: The interface is actually backwards-compatible with existing PIIX4 ACPI (though not

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-10-15 Thread Alex Bennée
peter.mayd...@linaro.org writes: On 16 September 2013 13:50, alex.ben...@linaro.org wrote: From: Alex Bennée a...@bennee.com Commit 9b8c69243 broke the ability to boot the kernel as the value returned by unassigned_mem_read returned non-zero and left the kernel looping forever waiting for

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: On Tue, Oct 15, 2013 at 7:20 AM, Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 06:51:30AM -0700, Anthony Liguori wrote: On Mon, Oct 14, 2013 at 10:28 PM, Michael S. Tsirkin m...@redhat.com wrote: On

Re: [Qemu-devel] [PATCH v2 1/1] integrator: fix Linux boot failure by emulating dbg

2013-10-15 Thread Peter Maydell
On 15 October 2013 15:25, Alex Bennée alex.ben...@linaro.org wrote: peter.mayd...@linaro.org writes: This sounds like the code was written based on the kernel, not on the board docs, which is wrong, so I think it could use rephrasing. There's no need to mention previous behaviour either IMHO

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState, +vmstate_test_no_use_acpi_pci_hotplug,

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +VMSTATE_STRUCT_TEST(pci0_status, PIIX4PMState,

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: I cannot reasonable revert a series like this before we cut GA. It's very simple actually. Here's a patch to disable it all. diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 63ae2ae..1a5a70c 100644 --- a/hw/i386/pc_piix.c

Re: [Qemu-devel] [PATCH 0/9] Remove legacy unaligned bswap functions

2013-10-15 Thread Michael S. Tsirkin
On Sun, Aug 25, 2013 at 03:59:28PM +0100, Peter Maydell wrote: The bswap.h header includes a set of legacy unaligned functions that (since commit c732a52d3 at the beginning of this year) are just wrappers for underlying {ld,st}type functions. The legacy functions aren't used in many places, so

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-15 Thread Kevin Wolf
Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben: Am 15.10.2013 15:21, schrieb Markus Armbruster: Andreas, To go beyond RFC with this series, I need to explain why the IDE controller functions of southbridges piix3-ide, piix3-ide-xen, piix4-ide and via-ide

[Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-10-15 Thread Peter Maydell
The documentation of how overlapping memory regions behave and how the priority system works was rather brief, and confusion about priorities seems to be quite common for developers trying to understand how the memory region system works, so expand and clarify it. This includes a worked example

Re: [Qemu-devel] [PATCH v2 0/4] avoid CONFIG_NO_* using rules.mak logic/string fns

2013-10-15 Thread Peter Maydell
Ping^2! thanks -- PMM On 27 September 2013 04:02, Peter Maydell peter.mayd...@linaro.org wrote: Ping! thanks -- PMM On 14 September 2013 02:25, Peter Maydell peter.mayd...@linaro.org wrote: This is based on a set of patches by Ákos Kovács which were lurking at the beginning of his

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: Please put together a summary of the testing this series has gone through. I still think there should be automated testing as part of this but if the manual testing is sufficiently thorough I'll reconsider for 1.7. Regards,

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, - struct pci_status), +

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:50:24PM +0200, Paolo Bonzini wrote: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2,

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-10-15 Thread Eric Blake
On 10/15/2013 08:42 AM, Peter Maydell wrote: The documentation of how overlapping memory regions behave and how the priority system works was rather brief, and confusion about priorities seems to be quite common for developers trying to understand how the memory region system works, so expand

[Qemu-devel] [PATCH v2 00/12] virtio: cleanup and fix hot-unplug

2013-10-15 Thread Paolo Bonzini
This series fixes hot-unplug of virtio devices, which can crash due to dangling pointer accesses. The current implementation supports guest-initiated hot-unplug via the virtio_bus_destroy_device function, but not hot-unplugging the virtio device by virtue of unplugging its parent container

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-15 Thread Andreas Färber
Am 15.10.2013 16:41, schrieb Kevin Wolf: having two IDE controllers using the same I/O ports won't work, obviously. So if you would allow -device or device-add for them, you'd need options to configure the ports at least. Or a new can_only_be_instantiated_once flag. :) Or proper error handling

[Qemu-devel] [PATCH v2 02/12] virtio-bus: remove vdev field

2013-10-15 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/virtio-bus.c | 63 +- hw/virtio/virtio-mmio.c| 9 +++---

[Qemu-devel] [PATCH v2 07/12] virtio-serial: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/char/virtio-serial-bus.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/char/virtio-serial-bus.c

[Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

2013-10-15 Thread Paolo Bonzini
Similar to the PCI bug that prompted these patches, virtio-ccw will segfault after the reworking of hotplug/hot-unplug. Prepare for this by moving virtio_ccw_stop_ioeventfd to before the freeing of the proxy device. A better place for this could be the device_unplugged callback for the

[Qemu-devel] [PATCH v2 03/12] virtio-ccw: remove vdev field

2013-10-15 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/s390x/virtio-ccw.c | 80 --- hw/s390x/virtio-ccw.h | 1 - 2 files

[Qemu-devel] [PATCH v2 08/12] virtio-net: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/net/virtio-net.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c index

[Qemu-devel] [PATCH v2 09/12] virtio-scsi: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/vhost-scsi.c| 11 +-- hw/scsi/virtio-scsi.c | 15 +++ include/hw/virtio/virtio-scsi.h | 2 +- 3 files

[Qemu-devel] [PATCH v2 06/12] virtio-blk: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/block/virtio-blk.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index

[Qemu-devel] [PATCH v2 11/12] virtio-rng: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/virtio-rng.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c index

[Qemu-devel] [PATCH v2 05/12] virtio-bus: cleanup plug/unplug interface

2013-10-15 Thread Paolo Bonzini
Right now we have these pairs: - virtio_bus_plug_device/virtio_bus_destroy_device. The first takes a VirtIODevice, the second takes a VirtioBusState - device_plugged/device_unplug callbacks in the VirtioBusClass (here it's just the naming that is inconsistent) - virtio_bus_destroy_device

Re: [Qemu-devel] [PATCH v2 0/4] avoid CONFIG_NO_* using rules.mak logic/string fns

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 16:47, Peter Maydell ha scritto: Ping^2! thanks -- PMM I have placed this in a branch together with Fam's module patches and will send a pull request tomorrow or Thursday (aka as soon as I get the occasion to test Fam's patches). Paolo

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: Seemed cleaner not to. It certainly would be if we had a self-descriptive migration stream format. However, what we have is send bytes, parse them on the destination, hope the format matches. Hence, anything that makes the format

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-10-15 Thread Eric Blake
On 10/15/2013 08:52 AM, Eric Blake wrote: On 10/15/2013 08:42 AM, Peter Maydell wrote: The documentation of how overlapping memory regions behave and how the priority system works was rather brief, and confusion about priorities seems to be quite common for developers trying to understand how

Re: [Qemu-devel] [PATCH] move test-* from .gitignore to tests/.gitignore

2013-10-15 Thread Laszlo Ersek
On 10/15/13 16:11, Eric Blake wrote: On 10/15/2013 07:10 AM, Laszlo Ersek wrote: Also sort the test-* entries in the latter. Signed-off-by: Laszlo Ersek ler...@redhat.com --- .gitignore | 9 - tests/.gitignore | 11 +-- 2 files changed, 9 insertions(+), 11

Re: [Qemu-devel] [PATCH v2 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

2013-10-15 Thread Cornelia Huck
On Tue, 15 Oct 2013 16:52:42 +0200 Paolo Bonzini pbonz...@redhat.com wrote: Similar to the PCI bug that prompted these patches, virtio-ccw will segfault after the reworking of hotplug/hot-unplug. Prepare for this by moving virtio_ccw_stop_ioeventfd to before the freeing of the proxy device.

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:54:24PM +0200, Paolo Bonzini wrote: Il 15/10/2013 16:54, Michael S. Tsirkin ha scritto: Seemed cleaner not to. It certainly would be if we had a self-descriptive migration stream format. However, what we have is send bytes, parse them on the

Re: [Qemu-devel] Which functions of southbridges should be no-user?

2013-10-15 Thread Anthony Liguori
On Tue, Oct 15, 2013 at 7:41 AM, Kevin Wolf kw...@redhat.com wrote: Am 15.10.2013 um 15:31 hat Andreas Färber geschrieben: Am 15.10.2013 15:21, schrieb Markus Armbruster: Andreas, To go beyond RFC with this series, I need to explain why the IDE controller functions of southbridges

[Qemu-devel] [PATCH v5 1/2] target-arm: Move call to disas_vfp_insn out of disas_coproc_insn.

2013-10-15 Thread Will Newton
Floating point is an extension to the instruction set rather than a coprocessor, so call it directly from the ARM and Thumb decode functions. Signed-off-by: Will Newton will.new...@linaro.org --- target-arm/translate.c | 29 - 1 file changed, 24 insertions(+), 5

[Qemu-devel] [PATCH v5 2/2] target-arm: Implement ARMv8 VSEL instruction.

2013-10-15 Thread Will Newton
This adds support for the VSEL floating point selection instruction which was added in ARMv8. Signed-off-by: Will Newton will.new...@linaro.org --- target-arm/translate.c | 130 - 1 file changed, 129 insertions(+), 1 deletion(-) Changes in v5: -

Re: [Qemu-devel] [RFC PATCH] spapr-vty: workaround reg property for old kernels

2013-10-15 Thread Alexander Graf
On 10/15/2013 10:50 AM, Alexey Kardashevskiy wrote: Old kernels ( 3.1) handle hvcX devices different in different parts. Sometime the kernel assumes that the hvc device numbers start from zero and if there is just one hvc, then it is hvc0. However kernel's add_preferred_console() uses the very

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-10-15 Thread Peter Maydell
On 15 October 2013 15:58, Tom Sutcliffe tom.sutcli...@bromium.com wrote: Thumbs up from me testing on Arndale. My only issue is that virt and vexpress-a15 add virtio-mmio devices in the opposite order to each other, for the same set of -device command line arguments. It would avoid future

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto: Because the same version can have multiple formats depending on a datum that is not part of the migration stream. I see. Will it be OK if I'll update the version? The version is constant, you cannot change it depending on which PCI flavor

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:09:36PM +0200, Paolo Bonzini wrote: Il 15/10/2013 17:07, Michael S. Tsirkin ha scritto: Because the same version can have multiple formats depending on a datum that is not part of the migration stream. I see. Will it be OK if I'll update the version? The

Re: [Qemu-devel] [PATCH v7 0/3] hw/arm: Add 'virt' platform

2013-10-15 Thread Tom Sutcliffe
On 15 Oct 2013, at 16:00, Peter Maydell peter.mayd...@linaro.org wrote: On 15 October 2013 15:58, Tom Sutcliffe tom.sutcli...@bromium.com wrote: Thumbs up from me testing on Arndale. My only issue is that virt and vexpress-a15 add virtio-mmio devices in the opposite order to each other,

[Qemu-devel] [PATCH v2 10/12] virtio-balloon: switch exit callback to VirtioDeviceClass

2013-10-15 Thread Paolo Bonzini
This ensures hot-unplug is handled properly by the proxy. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/virtio-balloon.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/virtio/virtio-balloon.c

Re: [Qemu-devel] [Nbd] Hibernate and qemu-nbd

2013-10-15 Thread Stefan Hajnoczi
On Thu, Oct 10, 2013 at 11:15 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Fri, Oct 04, 2013 at 07:30:45AM -0700, Mark Trumpold wrote: On 9/26/13 10:18 PM, Stefan Hajnoczi stefa...@gmail.com wrote: Try the qemu-nbd --persistent option. That should prevent it from shutting down when

[Qemu-devel] [PATCH v2 12/12] virtio-pci: add device_unplugged callback

2013-10-15 Thread Paolo Bonzini
This fixes a crash in hot-unplug of virtio-pci devices behind a PCIe switch. The crash happens because the ioeventfd is still set whent the child is destroyed (destruction happens in postorder). Then the proxy tries to unset to ioeventfd, but the virtqueue structure that holds the EventNotifier

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Igor Mammedov
On Tue, 15 Oct 2013 17:51:28 +0300 Michael S. Tsirkin m...@redhat.com wrote: On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: Please put together a summary of the testing this series has gone through. I still think there should be automated testing as part of this but if

Re: [Qemu-devel] [PATCH v2 03/12] virtio-ccw: remove vdev field

2013-10-15 Thread Cornelia Huck
On Tue, 15 Oct 2013 16:52:44 +0200 Paolo Bonzini pbonz...@redhat.com wrote: The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/s390x/virtio-ccw.c | 80

[Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/virtio-pci.c | 110 + hw/virtio/virtio-pci.h | 1 - 2 files

Re: [Qemu-devel] [PULL 00/43] pci, pc, acpi fixes, enhancements

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:51:28PM +0300, Michael S. Tsirkin wrote: On Tue, Oct 15, 2013 at 07:21:34AM -0700, Anthony Liguori wrote: Please put together a summary of the testing this series has gone through. I still think there should be automated testing as part of this but if the manual

[Qemu-devel] [PATCH 4/4] pc: add 'etc/pcimem64-minimum-address' fw_cfg interface to SeaBIOS

2013-10-15 Thread Igor Mammedov
'etc/pcimem64-minimum-address' will allow QEMU to communicate to BIOS where PCI memory address space mapping starts in high memory. Allowing BIOS start mapping 64-bit PCI BARs at address where QEMU placed this mapping vs. hardcoded value right after highmem RAM. That will allow QEMU to reserve

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy *proxy) static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) { VirtIOPCIProxy *proxy = opaque; -VirtIODevice *vdev =

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-10-15 Thread Peter Maydell
On 15 October 2013 15:52, Eric Blake ebl...@redhat.com wrote: On 10/15/2013 08:42 AM, Peter Maydell wrote: +It is valid to add subregions to a region which is not a pure container +(that is, to an MMIO, RAM or ROM region). This means that the region +will act like a container, except that any

Re: [Qemu-devel] [PATCH v2] docs/memory.txt: Clarify and expand priority/overlap documentation

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 03:42:34PM +0100, Peter Maydell wrote: The documentation of how overlapping memory regions behave and how the priority system works was rather brief, and confusion about priorities seems to be quite common for developers trying to understand how the memory region system

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy *proxy) static void virtio_ioport_write(void *opaque, uint32_t addr, uint32_t val) {

Re: [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-15 Thread Stefan Weil
Am 11.10.2013 17:05, schrieb Kevin Wolf: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the check would have errored out check in their init function that they don't get a read-only

Re: [Qemu-devel] [PATCH v13 0/8] Shared Library Module Support

2013-10-15 Thread Paolo Bonzini
Il 11/10/2013 03:16, Fam Zheng ha scritto: This series implements feature of shared object building as described in: http://wiki.qemu.org/Features/Modules The main idea behind modules is to isolate dependencies on third party libraries from qemu executables, such as libglusterfs or librbd,

Re: [Qemu-devel] [PATCH v2 03/12] virtio-ccw: remove vdev field

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 17:19, Cornelia Huck ha scritto: The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/s390x/virtio-ccw.c | 80

Re: [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-15 Thread Stefan Weil
Am 15.10.2013 17:59, schrieb Kevin Wolf: Am 15.10.2013 um 17:53 hat Stefan Weil geschrieben: Am 11.10.2013 17:05, schrieb Kevin Wolf: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Michael S. Tsirkin
On Tue, Oct 15, 2013 at 05:53:39PM +0200, Paolo Bonzini wrote: Il 15/10/2013 17:40, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:52:45PM +0200, Paolo Bonzini wrote: @@ -257,7 +271,7 @@ static void virtio_pci_stop_ioeventfd(VirtIOPCIProxy *proxy) static void

Re: [Qemu-devel] [RFC PATCH v3 4/5] Update documentation for LTTng ust tracing

2013-10-15 Thread Mohamad Gebai
Running this gives me: quote UST events: - None /quote Before or after running qemu. What is the mechanism lttng expects to find out all these events? Either the user should belong the group tracing, or launch the lttng-sessiond daemon (lttng-sessiond -d). + +Create

Re: [Qemu-devel] [PULL 54/61] blockdev: Remove IF_* check for read-only blockdev_init

2013-10-15 Thread Kevin Wolf
Am 15.10.2013 um 17:53 hat Stefan Weil geschrieben: Am 11.10.2013 17:05, schrieb Kevin Wolf: IF_NONE allows read-only, which makes forbidding it in this place for other types pretty much pointless. Instead, make sure that all devices for which the check would have errored out check in

Re: [Qemu-devel] [PATCH 17/21] target-i386: set [+-]feature using static properties

2013-10-15 Thread Igor Mammedov
On Tue, 16 Jul 2013 00:26:14 +0200 Igor Mammedov imamm...@redhat.com wrote: ... +X86CPU_FEAT(feat-kvmclock,0, FEAT_KVM), +X86CPU_FEAT(feat-kvm-nopiodelay, 1, FEAT_KVM), +X86CPU_FEAT(feat-kvm-mmu, 2, FEAT_KVM), +X86CPU_FEAT(feat-kvmclock2, 3, FEAT_KVM),

Re: [Qemu-devel] [PULL 42/43] piix4: add acpi pci hotplug support

2013-10-15 Thread Anthony Liguori
Paolo Bonzini pbonz...@redhat.com writes: Il 15/10/2013 16:35, Michael S. Tsirkin ha scritto: On Tue, Oct 15, 2013 at 04:31:31PM +0200, Paolo Bonzini wrote: Il 14/10/2013 17:01, Michael S. Tsirkin ha scritto: -VMSTATE_STRUCT(pci0_status, PIIX4PMState, 2, vmstate_pci_status, -

[Qemu-devel] [PATCH v3 2/2] spapr: Use DeviceClass::fw_name for device tree CPU node

2013-10-15 Thread Andreas Färber
Instead of relying on cpu_model, obtain the device tree node label per CPU. Use DeviceClass::fw_name as source. Whenever DeviceClass::fw_name is unknown, default to PowerPC,UNKNOWN. As a consequence, spapr_fixup_cpu_dt() can operate on each CPU's fw_name, obsoleting sPAPREnvironment::cpu_model,

[Qemu-devel] [PATCH v3 0/2] target-ppc: Tidy sPAPR device tree CPU nodes

2013-10-15 Thread Andreas Färber
Hello Alexey and Alex, This series cleans up the fdt CPU nodes for -M pseries as attempted by Prerna. v3 uses DeviceClass::fw_name for name storage exclusively, with PowerPC,UNKNOWN as fallback. Regards, Andreas v2 - v3: * Drop any type-based model name mangling and default to PowerPC,UNKNOWN

[Qemu-devel] [PATCH v3 1/2] target-ppc: Fill in OpenFirmware names for some PowerPCCPU families

2013-10-15 Thread Andreas Färber
Set the expected values for POWER7, POWER7+, POWER8 and POWER5+. Note that POWER5+ and POWER7+ are intentionally lacking the '+', so the lack of a POWER7P family constitutes no problem. Signed-off-by: Andreas Färber afaer...@suse.de --- target-ppc/translate_init.c | 3 +++ 1 file changed, 3

Re: [Qemu-devel] [PATCH v2 04/12] virtio-pci: remove vdev field

2013-10-15 Thread Paolo Bonzini
Il 15/10/2013 18:06, Michael S. Tsirkin ha scritto: It's not datapath if you're using ioeventfd, is it? Well not everyone uses dataplane/vhost. ioeventfd does not require dataplane/vhost. Anyway for 1.8 I do want to get rid of BusChild altogether, just not now. Paolo It's the same for MSIX

[Qemu-devel] [PATCH v3 01/12] virtio-ccw: move virtio_ccw_stop_ioeventfd to virtio_ccw_busdev_unplug

2013-10-15 Thread Paolo Bonzini
Similar to the PCI bug that prompted these patches, virtio-ccw will segfault after the reworking of hotplug/hot-unplug. Prepare for this by moving virtio_ccw_stop_ioeventfd to before the freeing of the proxy device. A better place for this could be the device_unplugged callback for the

[Qemu-devel] [PATCH v3 05/12] virtio-bus: cleanup plug/unplug interface

2013-10-15 Thread Paolo Bonzini
Right now we have these pairs: - virtio_bus_plug_device/virtio_bus_destroy_device. The first takes a VirtIODevice, the second takes a VirtioBusState - device_plugged/device_unplug callbacks in the VirtioBusClass (here it's just the naming that is inconsistent) - virtio_bus_destroy_device

[Qemu-devel] [PATCH v3 02/12] virtio-bus: remove vdev field

2013-10-15 Thread Paolo Bonzini
The vdev field is complicated to synchronize. Just access the BusState's list of children. Cc: qemu-sta...@nongnu.org Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- hw/virtio/virtio-bus.c | 65 +- hw/virtio/virtio-mmio.c| 9 +++---

[Qemu-devel] [PATCH v3 00/12] virtio: cleanup and fix hot-unplug

2013-10-15 Thread Paolo Bonzini
This series fixes hot-unplug of virtio devices, which can crash due to dangling pointer accesses. The current implementation supports guest-initiated hot-unplug via the virtio_bus_destroy_device function, but not hot-unplugging the virtio device by virtue of unplugging its parent container

<    1   2   3   >