Here's another pull request for the trivial-patches queue.
Since the previous pull request (which weren't pulled), I
removed a few patches which weren't marked for-1.7, and added
two more bugfixes on top (fixing python invocations).
What's left are either trivial stuff not affecting anything
This series contains patches for broken images.
Max Reitz (4):
qcow2: Move reading nb_snapshots in qcow2_open
qcow2-refcount: Sanitize refcount table size
qcow2: Sanitize refcount table size
qcow2: Check validity of backing file name length
block/qcow2-refcount.c | 4
Any goto fail between having read nb_snapshots (returning a non-zero
value) and allocating s-snapshots (through qcow2_read_snapshots())
results in qcow2_free_snapshots() being called, dereferencing
s-snapshots which is still NULL.
Fix this by moving the reading of nb_snapshots right before the
The len variable is a signed integer, therefore it may overflow when
reading the backing file name length from the qcow2 image header. This
case should be handled explicitly.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2.c | 5 +
1 file changed, 5 insertions(+)
diff --git
Make sure there were no overflows when calculating the in-memory
refcount table size from the number of its clusters in-file.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2.c | 8
1 file changed, 8 insertions(+)
diff --git a/block/qcow2.c b/block/qcow2.c
index
Make sure the refcount table size will not overflow when multiplied by
sizeof(uint64_t) and implicitly casted to int.
Signed-off-by: Max Reitz mre...@redhat.com
---
block/qcow2-refcount.c | 4
1 file changed, 4 insertions(+)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
This patch replaces foreign and local address/port couples in Socket
structure by 2 sockaddr_storage which can be casted in sockaddr_in or
sockaddr_in6.
Direct access to address and port is still possible thanks to some
\#define, so retrocompatibility of the existing code is assured.
The
A sa_family_t is now passed in argument to udp_attach instead of using a
hardcoded AF_INET to call qemu_socket().
Signed-off-by: Guillaume Subiron maet...@subiron.org
---
slirp/ip_icmp.c | 2 +-
slirp/udp.c | 7 ---
slirp/udp.h | 2 +-
3 files changed, 6 insertions(+), 5 deletions(-)
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to
manage second-scale timers.
Signed-off-by: Guillaume Subiron maet...@subiron.org
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
include/qemu/timer.h | 32
1 file
Basically, this patch replaces arp by resolution every time arp
means mac resolution and not specifically ARP.
Some indentation problems are solved in functions that will be modified
in the next patches (ip_input…).
In if_encap, a switch is added to prepare for the IPv6 case. Some code
is
This patch adds the functions needed to handle IPv6 packets. ICMPv6 and
NDP headers are implemented.
Slirp is now able to send NDP Router or Neighbor Advertisement when it
receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6
prefix, the guest is now able to perform stateless
This patch makes solookup() compatible with all address family. Also,
this function was only compatible with TCP. Having the socket list in
argument, it is now compatible with UDP too. Finally, some optimization
code is factorized inside the function (the function look at the last
returned result
This patch simply adds a sa_family_t argument to remove the hardcoded
AF_INET in the call of qemu_socket().
Signed-off-by: Guillaume Subiron maet...@subiron.org
---
slirp/slirp.h | 2 +-
slirp/tcp_input.c | 3 ++-
slirp/tcp_subr.c | 5 +++--
3 files changed, 6 insertions(+), 4 deletions(-)
Before this patch, if sosendto fails, udp_input is executed as if the
packet was sent. This could cause memory leak.
This patch adds a goto bad to cut the execution of this function.
Signed-off-by: Guillaume Subiron maet...@subiron.org
---
slirp/udp.c | 1 +
1 file changed, 1 insertion(+)
diff
This patch adds IPv6 case in TCP functions refactored by the last
patches.
This also adds IPv6 pseudo-header in tcpiphdr structure.
Finally, tcp_input() is called by ip6_input().
Signed-off-by: Guillaume Subiron maet...@subiron.org
Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org
---
This patch adds udp6_input() and udp6_output().
It also adds the IPv6 case in sorecvfrom().
Finally, udp_input() is called by ip6_input().
Signed-off-by: Guillaume Subiron maet...@subiron.org
---
slirp/Makefile.objs | 2 +-
slirp/ip6_input.c | 3 +-
slirp/socket.c | 7 ++-
Disambiguation : icmp_error is renamed into icmp_send_error, since it
doesn't manage errors, but only sends ICMP Error messages.
Adding icmp6_send_error to send ICMPv6 Error messages. This function is
simpler than the v4 version.
Adding some calls in various functions to send ICMP errors, when a
This patch factorizes some duplicate code into a new function,
sotranslate_out(). This function perform the address translation when a
packet is transmitted to the host network. If the paquet is destinated
to the host, the loopback address is used, and if the paquet is
destinated to the virtual
This patchs adds parameters to manage some new options in the qemu -net
command.
Slirp IPv6 address, network prefix, and DNS IPv6 address can be given in
argument to the qemu command.
Defaults parameters are respectively fc00::2, fc00::, /64 and fc00::3.
Signed-off-by: Yann Bordenave
This patch adds an IPv6 address to the DNS relay. in6_equal_dns() is
developed using this Slirp attribute.
sotranslate_in/out() are also updated to manage the IPv6 case so the
guest can be able to join the host using one of the Slirp addresses.
Signed-off-by: Guillaume Subiron maet...@subiron.org
Basically, this patch adds some switch in various TCP functions to
prepare them for the IPv6 case.
To have something to switch in tcp_input() and tcp_respond(), a new
argument is used to give them the sa_family of the addresses they are
working on.
Signed-off-by: Guillaume Subiron
This patch factorizes the tcpiphdr structure to put the IPv4 fields in
an union, for addition of version 6 in further patch.
Using some macros, retrocompatibility of the existing code is assured.
This patch also fixes the SLIRP_MSIZE and margin computation in various
functions, and makes them
On Nov 15, 2013, at 7:39 PM, Tomoki Sekiyama tomoki.sekiy...@hds.com wrote:
On 11/3/13 3:59 , Gal Hammer gham...@redhat.com wrote:
Reviewed-by: Gal Hammer gham...@redhat.com
On 01/11/2013 23:47, Tomoki Sekiyama wrote:
Currently, qemu-ga for Windows fails to execute guset-fsfreeze-freeze
Hello,
This is a respin of IPv6 in Qemu -net user mode.
These patches add ICMPv6, NDP, and make UDP and TCP compatible with
IPv6. We have made some refactoring to make current code compatible with
IPv6.
Some patches, like 2 and 13, can be reviewed using
interdiff -w /dev/null patchfile
to get
On Thu, Nov 14, 2013 at 05:42:26PM +0200, Avi Kivity wrote:
On 11/14/2013 05:37 PM, Michael S. Tsirkin wrote:
On Thu, Nov 14, 2013 at 04:56:43PM +0200, Avi Kivity wrote:
On 11/14/2013 04:40 PM, Michael S. Tsirkin wrote:
On Thu, Nov 14, 2013 at 08:54:11AM +, Avi Kivity wrote:
Michael S.
Here's a bug, some examples are as follows:
1.Assuming Guest's filesystem size 6M.
2.For vexpress_a15, the loader_start = 2048M.
If we set guest ram_size range from 2048M+128M to 2048M+128M+6M,
then the initrd load failed.
3.For mach-virt, the loader_start = 128M.
If we set guest ram_size range
On 11/17/2013 05:37 PM, Michael S. Tsirkin wrote:
On Thu, Nov 14, 2013 at 05:42:26PM +0200, Avi Kivity wrote:
On 11/14/2013 05:37 PM, Michael S. Tsirkin wrote:
On Thu, Nov 14, 2013 at 04:56:43PM +0200, Avi Kivity wrote:
On 11/14/2013 04:40 PM, Michael S. Tsirkin wrote:
On Thu, Nov 14, 2013
On 17 November 2013 16:10, ChenQun chenq...@gmail.com wrote:
Here's a bug, some examples are as follows:
1.Assuming Guest's filesystem size 6M.
2.For vexpress_a15, the loader_start = 2048M.
If we set guest ram_size range from 2048M+128M to 2048M+128M+6M,
then the initrd load failed.
3.For
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqobject/qerror.o
qobject/qerror.c: In function ‘qerror_from_info’:
qobject/qerror.c:53:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqga/commands.o
qga/commands.c: In function ‘slog’:
qga/commands.c:28:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
g_logv(syslog,
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqga/commands.o
qga/commands.c: In function ‘slog’:
qga/commands.c:28:5: error:
function might be possible candidate for ‘gnu_printf’ format attribute
[-Werror=suggest-attribute=format]
g_logv(syslog,
This patch is superseded by a new one.
v2 fixes three more format strings and is needed for 32 bit hosts.
Stefan
Am 17.11.2013 19:01, schrieb Stefan Weil:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCqga/commands.o
qga/commands.c: In function ‘slog’:
Apparently, this is the fix (althoug I haven't tested it yet)
can someone confirm if it helps, and if so, apply it?
http://virtuallyfun.superglobalmegacorp.com/?p=3245;
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
Public bug reported:
QEMU version: 1.6.90.0 from 2013 11 16
Host OS: Windows XP SP3 x86
Host machine: 3.2 GHz AMD Athlon 64 dual core processor, 4 GB DDR II (3.2 seen
by the OS) memory
Guest OS: Grub4Dos boot manager menu
Problem: it needs pdcurses.dll and it won't start without it.
** Affects:
Public bug reported:
QEMU version: 1.6.90.0 from 2013 11 16
Host OS: Windows XP SP3 x86
Host machine: 3.2 GHz AMD Athlon 64 dual core processor, 4 GB DDR II (3.2 seen
by the OS) memory
Guest OS: Grub4Dos boot manager menu
Problem: when I use qemu-system-i386.exe -drive
Public bug reported:
QEMU version: 1.6.90.0 from 2013 11 16
Host OS: Windows XP SP3 x86
Host machine: 3.2 GHz AMD Athlon 64 dual core processor, 4 GB DDR II (3.2 seen
by the OS) memory
Guest OS: Grub4Dos boot manager menu
Problem: you can't assign more than 880 MB memory to the VM, although with
On Tue, Oct 29, 2013 at 04:10:59PM +, Bhushan Bharat-R65777 wrote:
Hi Christoffer,
Not related to the patch, for edge type of interrupt, will setting bit in
ICD_SPENDR generate interrupt?
Hi Bharat,
That depends, if the interrupt was not previously pending, setting the
bit for the
17.11.2013 22:00, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
function might be possible candidate for
Am 2013-10-14 23:46, schrieb Michael Walle:
This allows us to completely remove CPULM32State from DisasContext.
Instead, copy the fields we need to DisasContext.
Cc: Andreas Färber afaer...@suse.de
Signed-off-by: Michael Walle mich...@walle.cc
---
changes since v1:
- instead of storing a
Warning from ccc-analyzer:
libcacard/cac.c:192:13: warning: Value stored to 'ret' is never read
ret = VCARD_DONE;
^ ~~
Here 'ret' is assigned a value inside of a switch statement and also after
that switch statement.
Signed-off-by: Stefan Weil
Warning from ccc-analyzer:
libcacard/vcard_emul_nss.c:937:9: warning:
Value stored to 'cert_count' is never read
cert_count = options-vreader[i].cert_count;
^~~
Signed-off-by: Stefan Weil s...@weilnetz.de
---
libcacard/vcard_emul_nss.c |
Am 17.11.2013 21:40, schrieb Michael Tokarev:
17.11.2013 22:00, Stefan Weil wrote:
gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra):
CCm68k-softmmu/hw/m68k/mcf5206.o
hw/i386/acpi-build.c: In function ‘build_append_nameseg’:
hw/i386/acpi-build.c:294:5: error:
On 11/16/2013 08:12 PM, Martin T wrote:
So I'm thinking there must be some other place where cpu_ldq_data() gets
defined which does something else, however, I haven't been able to find it
searching through the sources.
It's constructed via macro glue. See include/exec/softmmu_exec.h.
r~
On 11/15/2013 09:40 PM, Paolo Bonzini wrote:
Il 15/11/2013 06:14, Alexey Kardashevskiy ha scritto:
It does not feel that we really need CPUState::kvm_cpu_id and
direct calling of kvm_arch_vcpu_id() would be enough.
Indeed -- and it should be kvm_ppc_vcpu_id() since other architectures
do
This adds very basic handlers for ibm,get-system-parameter and
ibm,set-system-parameter RTAS calls.
The only parameter handled at the moment is
platform-processor-diagnostics-run-mode which is always disabled and
does not support changing. This is expected to make
ppc64_cpu --run-mode=1 happy.
From: Paul Mackerras pau...@samba.org
This makes sure that all NUMA memory blocks beside within RAM or
have zero length.
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru
---
This is a bugfix for:
-m 500
-smp 8,sockets=2,cores=2,threads=2
-numa node,nodeid=0,cpus=0-3,mem=500
-numa
The SPAPR specification says that the RMA starts at the LPAR's logical
address 0 and is the first logical memory block reported in
the LPAR’s device tree.
So SLOF only maps the first block and that block needs to span
the full RMA.
This makes sure that the RMA area is where SLOF expects it.
The first patch got RB from Thomas, and the second one is new but depends
on the first one so I am (re)posting them together. Thanks.
Alexey Kardashevskiy (1):
spapr: make sure RMA is in first mode of first memory node
Paul Mackerras (1):
spapr: limit numa memory regions by ram size
Hi,
So after talking to a few people at kvm forum I think the GPU code
should probably use the dataplane stuff from the outset,
The main advantages I think this gives me is being able to dequeue
objects from the vq from a thread and send irq vectors from there as
well.
Though since it appears
2013/11/15 Stefan Hajnoczi stefa...@gmail.com
On Thu, Nov 14, 2013 at 04:15:28PM +0800, Chunyan Liu wrote:
Set NOCOW flag to newly created images to solve performance issues on
btrfs.
Btrfs has terrible performance when hosting VM images, even more when
the guest
in those VM are also
2013/11/15 Kevin Wolf kw...@redhat.com
Am 15.11.2013 um 06:01 hat Chunyan Liu geschrieben:
Set NOCOW flag to newly created images to solve performance issues on
btrfs.
Btrfs has terrible performance when hosting VM images, even more when
the guest
in those VM are also using btrfs as
On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote:
v6:
- update comment typo
- remove is_number()
Anyone pick this set up?
Thanks
Yuan
They wrap blkdebug break and remove_break.
Add optional argument resume to cancel_and_wait().
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/iotests.py | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/iotests.py
iotests.py already has one.
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/040 | 15 ---
1 file changed, 15 deletions(-)
diff --git a/tests/qemu-iotests/040 b/tests/qemu-iotests/040
index a2e18c5..0e85136 100755
--- a/tests/qemu-iotests/040
+++
This adds remove_break command to block, which removes a break point defined
with break. It is used in iotests.py to pause and resume drive in block job
cases to make the test deterministic.
v5: Addressing Max's comments (thanks for reviewing)
[02] Resume all the requests.
[03] Fix event=
This adds remove_break command which is the reverse of blkdebug
command break: it removes all breakpoints with given tag and resumes
all the requests.
Signed-off-by: Fam Zheng f...@redhat.com
---
block.c | 13 +
block/blkdebug.c | 27
Pause the drive and start the block job, so we won't miss the block job.
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/030 | 16 +++-
tests/qemu-iotests/040 | 4 +++-
tests/qemu-iotests/055 | 15 +++
3 files changed, 25 insertions(+), 10 deletions(-)
Fam Zheng (2):
qemu-iotests: Filter qemu-io output in 025
qemu-iotests: Filter out 'qemu-io ' prompt
tests/qemu-iotests/013.out | 44080 -
tests/qemu-iotests/014.out | 64204 ++---
tests/qemu-iotests/017.out | 1080
Signed-off-by: Fam Zheng f...@redhat.com
---
tests/qemu-iotests/025 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/025 b/tests/qemu-iotests/025
index a7241cc..9426c93 100755
--- a/tests/qemu-iotests/025
+++ b/tests/qemu-iotests/025
@@ -56,7 +56,7 @@
60 matches
Mail list logo
