Re: [Qemu-devel] First Patch, Requesting Comments‏

2013-11-18 Thread Max Filippov
Hi Varad, On Mon, Nov 18, 2013 at 5:49 PM, Varad Gautam varadgau...@gmail.com wrote: Hi! I'm new here, and am working on my first bug. I have posted a patch for Bug#603872 [1]. It's incomplete right now, but please have a look and tell me if I'm headed in the right direction. (I don't know if

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 10:32 AM, Amos Kong wrote: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Signed-off-by: Amos Kong ak...@redhat.com Reviewed-by: Vlad Yasevich vyase...@redhat.com -vlad --- v2: put gchar *path inside rxfilter_notify_enabled block ---

Re: [Qemu-devel] [PATCH v2 for-1.7] qom: Fix memory leak in object_property_set_link()

2013-11-18 Thread Andreas Färber
Am 15.11.2013 18:09, schrieb Vlad Yasevich: Save the result of the call to object_get_cannonical_path() so we can free it. Signed-off-by: Vlad Yasevich vyase...@redhat.com Cc: qemu-sta...@nongnu.org Reviewed-by: Andreas Färber afaer...@suse.de in case Anthony wants to pick it up himself,

Re: [Qemu-devel] [PATCH v2] virtio-net: fix the memory leak in rxfilter_notify()

2013-11-18 Thread Andreas Färber
Am 18.11.2013 16:32, schrieb Amos Kong: object_get_canonical_path() returns a gchar*, it should be freeed by the caller. Cc: qemu-sta...@nongnu.org Signed-off-by: Amos Kong ak...@redhat.com --- v2: put gchar *path inside rxfilter_notify_enabled block --- hw/net/virtio-net.c | 8

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. I have also put it at [1] now. Thanks. Varad [1] https://bugs.launchpad.net/qemu/+bug/603872

[Qemu-devel] [Bug 603872] Re: [Feature request] qemu-img image conversion does not show percentage

2013-11-18 Thread Varad
Incomplete patch. Usecase: `qemu-img convert` with -p now shows the write speed. 1. I'm calculating the speed using the time taken to run the for(;;) at qemu-img.c:1477. I figured that every time this loop runs, n1 sectors are converted, and so I calculate the write_speed accordingly. Is this

Re: [Qemu-devel] [PATCH] qtest: Adding -display none to new tests

2013-11-18 Thread Andreas Färber
Hi, Am 15.11.2013 20:54, schrieb Kevin Wolf: Without it, you either get a window for a short time, or worse, test failures when 'make check' isn't run in an X session. Signed-off-by: Kevin Wolf kw...@redhat.com --- tests/blockdev-test.c | 2 +- tests/qdev-monitor-test.c | 2 +- 2

Re: [Qemu-devel] [RESEND][PATCH 1.7] migration: drop MADVISE_DONT_NEED for incoming zero pages

2013-11-18 Thread Paolo Bonzini
Il 18/11/2013 13:48, Peter Lieven ha scritto: On 24.10.2013 11:14, Paolo Bonzini wrote: Il 24/10/2013 08:21, Peter Lieven ha scritto: Additionally we memmap target memory so it is essentially zero initialized (except for e.g. option roms and bios which are loaded into target memory although

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-18 Thread Paolo Bonzini
Il 18/11/2013 16:37, Peter Lieven ha scritto: If I specify: -smp 2,sockets=1,cores=2,threads=1 to a Windows 2012 R2 Server it crashes at boot time. -smp 2 works. for Linux /proc/cpuinfo reveals no cpu layout information (sibliings, cores, threads etc.) with this patch applied and a manual

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-18 Thread Anthony Liguori
On Nov 18, 2013 7:05 AM, Stefan Hajnoczi stefa...@gmail.com wrote: On Mon, Nov 18, 2013 at 02:52:53PM +1000, Dave Airlie wrote: So after talking to a few people at kvm forum I think the GPU code should probably use the dataplane stuff from the outset, The main advantages I think this

Re: [Qemu-devel] [PATCH 2/3] ui/vnc: optimize dirty bitmap tracking

2013-11-18 Thread Anthony Liguori
On Nov 18, 2013 12:20 AM, Peter Lieven p...@kamp.de wrote: vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty. vnc_refresh_server_surface does almost the same. this patch optimizes both by utilizing the heavily

[Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-18 Thread Andreas Färber
This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +-- tests/hd-geo-test.c | 2 +- tests/i440fx-test.c | 2 +-

Re: [Qemu-devel] dataplane, thread and gpu stuff

2013-11-18 Thread Paolo Bonzini
Il 18/11/2013 16:03, Stefan Hajnoczi ha scritto: As of today, there are still two vring implementations in hw/virtio/virtio.c and hw/virtio/dataplane/vring.c. This means it isn't clean and easy to integrate into a new device yet. Existing dataplane devices basically take advantage of the

[Qemu-devel] [Bug 685096] Re: USB Passthrough not working for Windows 7 guest

2013-11-18 Thread Serge Hallyn
@FanFan, if you start such a vm and do 'ps -ef | grep kvm' should see the kvm command line which is working for you. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/685096 Title: USB Passthrough

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Andreas Färber
Am 18.11.2013 16:59, schrieb Varad Gautam: To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. Unfortunately several copies of your mail arrived on the list today, and only one actually has the patch

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-18 Thread Stefan Hajnoczi
On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c | 6 +++--- tests/fw_cfg-test.c | 3 +--

Re: [Qemu-devel] [PATCH] qtest: Use -display none by default

2013-11-18 Thread Andreas Färber
Am 18.11.2013 17:48, schrieb Stefan Hajnoczi: On Mon, Nov 18, 2013 at 05:36:34PM +0100, Andreas Färber wrote: This avoids each test needing to add it to suppress windows popping up. Signed-off-by: Andreas Färber afaer...@suse.de --- tests/boot-order-test.c | 2 +- tests/endianness-test.c |

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Eric Blake
On 11/18/2013 09:45 AM, Andreas Färber wrote: Am 18.11.2013 16:59, schrieb Varad Gautam: To discuss the code you really should post the patch, I couldn't find any related code by your link. Hi! I had posted the patch onto the list. Unfortunately several copies of your mail arrived on the

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 10:02 AM, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr is written. This assumes that guest driver will write all the macaddr from bit 0 to bit 5 when it changes the

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Varad Gautam
On Mon, Nov 18, 2013 at 10:31 PM, Eric Blake ebl...@redhat.com wrote: Often-times, this happens when a new contributor fails to realize that the list is moderated, but that we will moderate non-subscriber's messages through. What commonly happens is that a new contributor sends a message,

Re: [Qemu-devel] First Patch, Requesting Comments

2013-11-18 Thread Eric Blake
On 11/18/2013 11:41 AM, Varad Gautam wrote: On Mon, Nov 18, 2013 at 10:31 PM, Eric Blake ebl...@redhat.com wrote: Varad, as a new contributor, you are in a position to possibly help us: what documentation pages did you read to learn where to post your patches, so that we can try and modify

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 12:33:20PM -0500, Vlad Yasevich wrote: On 11/18/2013 10:02 AM, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr is written. This assumes that guest driver will

Re: [Qemu-devel] [PATCH] e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 02:42 PM, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 12:33:20PM -0500, Vlad Yasevich wrote: On 11/18/2013 10:02 AM, Michael S. Tsirkin wrote: On Tue, Nov 05, 2013 at 07:17:18PM +0800, Amos Kong wrote: We currently just update the HMP NIC info when the last bit of macaddr

[Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make QEMU behave more like hardware. Let's stick to the tried heuristic for 1.7 and possibly revisit for 1.8. Reported-by: Vlad Yasevich vyase...@redhat.com Cc: Amos Kong

[Qemu-devel] Self-modifying code with REP-prefix on TCG

2013-11-18 Thread Clemens Kolbitsch
Hi guys, a quick search on the archives did not reveal anything - if this is already a known issue, please don't kick me ;) We encountered an issue using TCG, where self-modifying code is overwriting the executing instruction, causing different behavior in TCG and a real CPU. Clearly, when code

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 02:47 PM, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make QEMU behave more like hardware. Let's stick to the tried heuristic for 1.7 and possibly revisit for 1.8.

Re: [Qemu-devel] [PATCH 14/60] AArch64: Add orr instruction emulation

2013-11-18 Thread Richard Henderson
On 11/18/2013 11:55 PM, Michael Matz wrote: I think we need to either explicitly convert the tcg_shift to a TCGv_i32, or we need to use an open coded version of the rotr_i64 that inserts at (32 - n) instead of (64 - n) What do you think? I think converting tcg_shift might eventually

Re: [Qemu-devel] [PULL 11/13] target-i386: forward CPUID cache leaves when -cpu host is used

2013-11-18 Thread Peter Lieven
Am 18.11.2013 17:11, schrieb Paolo Bonzini: Il 18/11/2013 16:37, Peter Lieven ha scritto: If I specify: -smp 2,sockets=1,cores=2,threads=1 to a Windows 2012 R2 Server it crashes at boot time. -smp 2 works. for Linux /proc/cpuinfo reveals no cpu layout information (sibliings, cores, threads

Re: [Qemu-devel] [PATCH 2/3] ui/vnc: optimize dirty bitmap tracking

2013-11-18 Thread Peter Lieven
Am 18.11.2013 17:27, schrieb Anthony Liguori: On Nov 18, 2013 12:20 AM, Peter Lieven p...@kamp.de mailto:p...@kamp.de wrote: vnc_update_client currently scans the dirty bitmap of each client bitwise which is a very costly operation if only few bits are dirty.

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make QEMU behave more like hardware. Let's stick to the tried heuristic for 1.7 and possibly revisit for 1.8. If

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make QEMU behave more like hardware. Let's stick to the tried

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into hardware specs shows this does not actually make

[Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

2013-11-18 Thread Richard Henderson
hw/i386/acpi-build.c:294:5: error: implicit declaration of function ‘g_string_vprintf’ [-Werror=implicit-function-declaration] g_string_vprintf(s, format, args); Introduced in 2.14. hw/i386/acpi-build.c:427:5: error: implicit declaration of function ‘g_array_get_element_size’

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit cd5be5829c1ce87aa6b3a7806524fac07ac9a757. Digging into

Re: [Qemu-devel] [PATCH v2] spapr: add ibm, (get|set)-system-parameter

2013-11-18 Thread Alexander Graf
On 17.11.2013, at 22:09, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is platform-processor-diagnostics-run-mode which is always disabled and does not

Re: [Qemu-devel] [PATCH v2] target-ppc: move POWER7+ to a separate family

2013-11-18 Thread Alexander Graf
On 18.11.2013, at 03:55, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 11/12/2013 06:18 PM, Alexey Kardashevskiy wrote: On 11/09/2013 11:20 AM, Alexey Kardashevskiy wrote: On 11/09/2013 03:59 AM, Andreas Färber wrote: Am 08.11.2013 15:54, schrieb Alexey Kardashevskiy: On 11/09/2013 12:44

Re: [Qemu-devel] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)

2013-11-18 Thread Stefan Weil
Please note that this patch fixes real bugs, namely wrong format strings. As far as I could see those bugs are only in code branches which handle rare error conditions, so maybe they only have a low priority. Nevertheless they can be fixed in QEMU 1.7. Do we need a pull request, or can it be

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200, Michael S. Tsirkin wrote: This reverts commit

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 02:33:16PM -0700, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon,

[Qemu-devel] [PULL for-1.7 01/13] tcg-ia64: Use TCGMemOp within qemu_ldst routines

2013-11-18 Thread Richard Henderson
Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 173 ++ 1 file changed, 91 insertions(+), 82 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index

[Qemu-devel] [PULL for-1.7 00/13] tcg-ia64 improvements

2013-11-18 Thread Richard Henderson
These are extracted from a larger patch set, including only the subset that has been reviewed by Aurelien. Patch 5 fixes a serious bug in the ia64 backend, so I'd like to ensure this gets fixed for 1.7. r~ The following changes since commit 5c5432e7d630592ddcc1876ac8a1505f8f14ef15: Merge

[Qemu-devel] [PULL for-1.7 13/13] tcg-ia64: Introduce tcg_opc_bswap64_i

2013-11-18 Thread Richard Henderson
Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 63 +++ 1 file changed, 28 insertions(+), 35 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index

[Qemu-devel] [PULL for-1.7 04/13] tcg-ia64: Simplify brcond

2013-11-18 Thread Richard Henderson
There was a misconception that a stop bit is required between a compare and the branch that uses the predicate set by the compare. This lead to the usage of an extra bundle in which to perform the compare. The extra bundle left room for constants to be loaded for use with the compare insn. If

[Qemu-devel] [PULL for-1.7 05/13] tcg-ia64: Move AREG0 to R32

2013-11-18 Thread Richard Henderson
Since the move away from the global areg0, we're no longer globally reserving areg0. Which means our use of R7 clobbers a call-saved register. Shift areg0 into the windowed registers. Indeed, choose the incoming parameter register that it comes to us by. This requires moving the register

[Qemu-devel] [PULL for-1.7 06/13] tcg-ia64: Avoid unnecessary stop bit in tcg_out_alu

2013-11-18 Thread Richard Henderson
When performing an operation with two input registers, we'd leave the stop bit (and thus an extra cycle) that's only needed when one or the other input is a constant. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 17

[Qemu-devel] [PULL for-1.7 11/13] tcg-ia64: Introduce tcg_opc_movi_a

2013-11-18 Thread Richard Henderson
Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 2f630f4..afcb1ad

[Qemu-devel] [PULL for-1.7 09/13] tcg-ia64: Use A3 form of logical operations

2013-11-18 Thread Richard Henderson
We can and/or/xor/andcm small constants, saving one cycle. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 64 +++ 1 file changed, 34 insertions(+), 30 deletions(-) diff

[Qemu-devel] [PULL for-1.7 08/13] tcg-ia64: Use SUB_A3 and ADDS_A4 for subtraction

2013-11-18 Thread Richard Henderson
We can subtract from more small constants that just 0 with one insn, and we can add the negative for most small constants. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 25 +++-- 1 file changed, 23

[Qemu-devel] [PULL for-1.7 12/13] tcg-ia64: Introduce tcg_opc_ext_i

2013-11-18 Thread Richard Henderson
Being able to extend from 64-bits (with a mov) simplifies a few places where the conditional breaks the train of thought. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 54

[Qemu-devel] [PULL for-1.7 10/13] tcg-ia64: Introduce tcg_opc_mov_a

2013-11-18 Thread Richard Henderson
Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 35 --- 1 file changed, 16 insertions(+), 19 deletions(-) diff --git a/tcg/ia64/tcg-target.c b/tcg/ia64/tcg-target.c index 322955b..2f630f4

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 21:47 +0200,

[Qemu-devel] [PULL for-1.7 03/13] tcg-ia64: Handle constant calls

2013-11-18 Thread Richard Henderson
Using only indirect calls results in 3 bundles (one to load the descriptor address), and 4 stop bits. By looking through the descriptor to the constants, we can perform the call with 2 bundles and only 1 stop bit. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson

[Qemu-devel] [PULL for-1.7 02/13] tcg-ia64: Use shortcuts for nop insns

2013-11-18 Thread Richard Henderson
There's no need to go through the full opcode-to-insn function call to generate nops. This makes the source a bit more readable. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c | 251

[Qemu-devel] [PULL for-1.7 07/13] tcg-ia64: Use ADDS for small addition

2013-11-18 Thread Richard Henderson
Avoids a wasted cycle loading up small constants. Simplify the code assuming the tcg optimizer is going to work and don't expect the first operand of the add to be constant. Acked-by: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/ia64/tcg-target.c

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 23:47 +0200, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 02:33:16PM -0700, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote:

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 03:40:51PM -0700, Alex Williamson wrote: On Mon, 2013-11-18 at 17:07 -0500, Vlad Yasevich wrote: On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon,

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Michael S. Tsirkin
On Mon, Nov 18, 2013 at 03:26:09PM -0700, Alex Williamson wrote: On Mon, 2013-11-18 at 23:47 +0200, Michael S. Tsirkin wrote: On Mon, Nov 18, 2013 at 02:33:16PM -0700, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson

Re: [Qemu-devel] [for-1.7] hw/i386/acpi-build.c vs glib-2.12

2013-11-18 Thread Michael S. Tsirkin
On Tue, Nov 19, 2013 at 06:49:40AM +1000, Richard Henderson wrote: hw/i386/acpi-build.c:294:5: error: implicit declaration of function ‘g_string_vprintf’ [-Werror=implicit-function-declaration] g_string_vprintf(s, format, args); Introduced in 2.14. hw/i386/acpi-build.c:427:5:

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Vlad Yasevich
On 11/18/2013 05:40 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 17:07 -0500, Vlad Yasevich wrote: On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 17:07 -0500, Vlad Yasevich wrote: On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:09 -0500, Vlad Yasevich wrote: On 11/18/2013 02:58 PM,

Re: [Qemu-devel] [PATCH for-1.7] Revert e1000/rtl8139: update HMP NIC when every bit is written

2013-11-18 Thread Alex Williamson
On Mon, 2013-11-18 at 17:55 -0500, Vlad Yasevich wrote: On 11/18/2013 05:40 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 17:07 -0500, Vlad Yasevich wrote: On 11/18/2013 04:33 PM, Alex Williamson wrote: On Mon, 2013-11-18 at 15:57 -0500, Vlad Yasevich wrote: On 11/18/2013 03:33 PM,

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-18 Thread Laszlo Ersek
On 11/12/13 16:11, Laszlo Ersek wrote: - Boot progress bar and console (efifb) continue to work (tested with both 1GB and 5GB guest sizes). Turns out one can't be diligent enough. This patch causes (or exposes, dependent on your POV) breakage. It breaks the cirrus video output for both

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-18 Thread Igor Mammedov
On Tue, 19 Nov 2013 00:34:31 +0100 Laszlo Ersek ler...@redhat.com wrote: On 11/12/13 16:11, Laszlo Ersek wrote: - Boot progress bar and console (efifb) continue to work (tested with both 1GB and 5GB guest sizes). Turns out one can't be diligent enough. This patch causes (or

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-18 Thread Laszlo Ersek
On 11/19/13 01:04, Igor Mammedov wrote: On Tue, 19 Nov 2013 00:34:31 +0100 Laszlo Ersek ler...@redhat.com wrote: On 11/12/13 16:11, Laszlo Ersek wrote: - Boot progress bar and console (efifb) continue to work (tested with both 1GB and 5GB guest sizes). Turns out one can't be diligent

Re: [Qemu-devel] [PATCH v2] spapr: add ibm, (get|set)-system-parameter

2013-11-18 Thread Alexey Kardashevskiy
On 11/19/2013 07:58 AM, Alexander Graf wrote: On 17.11.2013, at 22:09, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is

[Qemu-devel] [PATCH v3] target-ppc: move POWER7+ to a separate family

2013-11-18 Thread Alexey Kardashevskiy
So far POWER7+ was a part of POWER7 family. However it has a different PVR base value so in order to support PVR masks, it needs a separate family class. This adds a new family class, PVR base and mask values and moves Power7+ v2.1 CPU to a new family. The class init function is copied from the

Re: [Qemu-devel] [RFC PATCH v2 3/6] hw: arm_gic: Keep track of SGI sources

2013-11-18 Thread Christoffer Dall
On Mon, Oct 14, 2013 at 04:36:24PM +0100, Peter Maydell wrote: On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: Right now the arm gic emulation doesn't keep track of the source of an SGI (which apparently Linux guests don't use, or they're fine with assuming

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-11-18 Thread Christoffer Dall
On Fri, Sep 27, 2013 at 09:11:18AM +0100, Alex Bennée wrote: christoffer.d...@linaro.org writes: [...] + +static void translate_active(GICState *s, int irq, int cpu, + uint32_t *field, bool to_kernel) +{ +int cm = (irq GIC_INTERNAL) ? (1 cpu) :

[Qemu-devel] QEMU and golang

2013-11-18 Thread Petros Aggelatos
Hello guys, I'm using qemu-arm-static and binfmt_misc to have an ARM chroot on my laptop. Although most programs run fine when I run a go program or the go compiler itself it crashes. Digging into the issue I found that the problem has to do with go trying to use all the signals. I also found a

Re: [Qemu-devel] [RFC PATCH v2 6/6] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-11-18 Thread Christoffer Dall
On Tue, Oct 15, 2013 at 12:15:03PM +0100, Peter Maydell wrote: On 26 September 2013 22:03, Christoffer Dall christoffer.d...@linaro.org wrote: Save and restore the ARM KVM VGIC state from the kernel. We rely on QEMU to marshal the GICState data structure and therefore simply synchronize

[Qemu-devel] [PATCH v3 0/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-18 Thread Alexey Kardashevskiy
This reworks RTAS code to use predefined macros vs. numbers and adds handlers for ibm,get-system-parameter and ibm,set-system-parameter. Alexey Kardashevskiy (2): spapr-rtas: replace constants with macros spapr-rtas: add ibm,(get|set)-system-parameter hw/ppc/spapr_rtas.c | 86

[Qemu-devel] [PATCH v3 1/2] spapr-rtas: replace return code constants with macros

2013-11-18 Thread Alexey Kardashevskiy
Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- hw/intc/xics.c | 24 hw/nvram/spapr_nvram.c | 16 hw/ppc/spapr_events.c | 6 +++--- hw/ppc/spapr_pci.c | 42 +- hw/ppc/spapr_rtas.c| 34

[Qemu-devel] [PATCH v3 2/2] spapr-rtas: add ibm, (get|set)-system-parameter

2013-11-18 Thread Alexey Kardashevskiy
This adds very basic handlers for ibm,get-system-parameter and ibm,set-system-parameter RTAS calls. The only parameter handled at the moment is platform-processor-diagnostics-run-mode which is always disabled and does not support changing. This is expected to make ppc64_cpu --run-mode=1 happy.

[Qemu-devel] [Bug 1252009] Re: slow boot on USB drives

2013-11-18 Thread David Brenner
** Attachment added: Boot test with the new version https://bugs.launchpad.net/qemu/+bug/1252009/+attachment/3912214/+files/New%20version%20test.asf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [Bug 1252009] Re: slow boot on USB drives

2013-11-18 Thread David Brenner
** Attachment added: Boot files https://bugs.launchpad.net/qemu/+bug/1252009/+attachment/3912216/+files/boot%20files.7z -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1252009 Title: slow boot

[Qemu-devel] [Bug 1252009] Re: slow boot on USB drives

2013-11-18 Thread David Brenner
** Attachment added: Boot test with the old version https://bugs.launchpad.net/qemu/+bug/1252009/+attachment/3912215/+files/Old%20version%20test.asf -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU.

[Qemu-devel] [RFC PATCH v3 3/4] kvm: Common device control API functions

2013-11-18 Thread Christoffer Dall
Introduces two simple functions: int kvm_device_ioctl(int fd, int type, ...); int kvm_create_device(KVMState *s, uint64_t type, bool test); These functions wrap the basic ioctl-based interactions with KVM in a way similar to other KVM ioctl wrappers. Reviewed-by: Peter Maydell

[Qemu-devel] [RFC PATCH v3 2/4] kvm: Introduce kvm_arch_irqchip_create

2013-11-18 Thread Christoffer Dall
Introduce kvm_arch_irqchip_create an arch-specific hook in preparation for architecture-specific use of the device control API to create IRQ chips. Following patches will implement the ARM irqchip create method to prefer the device control API over the older KVM_CREATE_IRQCHIP API. Reviewed-by:

[Qemu-devel] [RFC PATCH v3 0/4] Create ARM KVM VGIC with device control API

2013-11-18 Thread Christoffer Dall
This patch series adds generic support for issuing device control related ioctls and supports creating the ARM KVM-accelerated VGIC using the device control API while maintaining backwards compatibility for older kernels. This is an RFC patch set because it relies on kernel header changes that

[Qemu-devel] [RFC PATCH v3 1/4] kvm: Update headers for device control api

2013-11-18 Thread Christoffer Dall
Update the KVM kernel headers to add support for the device control API on ARM used to create in-kernel devices and set and get attributes on these. This is needed for VGIC save/restore with KVM ARM targets. Headers are included from: git://git.linaro.org/people/cdall/linux-kvm-arm.git

[Qemu-devel] [RFC PATCH v3 01/10] hw: arm_gic: Fix gic_set_irq handling

2013-11-18 Thread Christoffer Dall
For some reason only edge-triggered or enabled level-triggered interrupts would set the pending state of a raised IRQ. This is not in compliance with the specs, which indicate that the pending state is separate from the enabled state, which only controls if a pending interrupt is actually

[Qemu-devel] [RFC PATCH v3 4/4] arm: vgic device control api support

2013-11-18 Thread Christoffer Dall
Support creating the ARM vgic device through the device control API and setting the base address for the distributor and cpu interfaces in KVM VMs using this API. Because the older KVM_CREATE_IRQCHIP interface needs the irq chip to be created prior to creating the VCPUs, we first test if we can

[Qemu-devel] [RFC PATCH v3 03/10] hw: arm_gic: Keep track of SGI sources

2013-11-18 Thread Christoffer Dall
Right now the arm gic emulation doesn't keep track of the source of an SGI (which apparently Linux guests don't use, or they're fine with assuming CPU 0 always). Add the necessary matrix on the GICState structure and maintain the data when setting and clearing the pending state of an IRQ. Note

[Qemu-devel] [RFC PATCH v3 04/10] arm_gic: Support setting/getting binary point reg

2013-11-18 Thread Christoffer Dall
Add a binary_point field to the gic emulation structure and support setting/getting this register now when we have it. We don't actually support interrupt grouping yet, oh well. Signed-off-by: Christoffer Dall christoffer.d...@linaro.org Changelog [v3]: - Treat writes for GIC prior to v2 as

[Qemu-devel] [RFC PATCH v3 05/10] arm_gic: Rename GIC_X_TRIGGER to GIC_X_EDGE_TRIGGER

2013-11-18 Thread Christoffer Dall
TRIGGER can really mean mean anything (e.g. was it triggered, is it level-triggered, is it edge-triggered, etc.). Rename to EDGE_TRIGGER to make the code comprehensible without looking up the data structure. Signed-off-by: Christoffer Dall christoffer.d...@linaro.org --- hw/intc/arm_gic.c

[Qemu-devel] [RFC PATCH v3 07/10] arm_gic: Fix gic_acknowledge_irq pending bit clear

2013-11-18 Thread Christoffer Dall
The pending flags for level-triggered interrupts should not be cleared if the interrupt input signal remains asserted. Signed-off-by: Christoffer Dall christoffer.d...@linaro.org Changelog[3]: - New patch in the series --- hw/intc/arm_gic.c | 10 +++--- 1 file changed, 7 insertions(+), 3

[Qemu-devel] [RFC PATCH v3 00/10] Support arm-gic-kvm save/restore

2013-11-18 Thread Christoffer Dall
Implement support to save/restore the ARM KVM VGIC state from the kernel. The basic appraoch is to transfer state from the in-kernel VGIC to the emulated arm-gic state representation and let the standard QEMU vmstate save/restore handle saving the arm-gic state. Restore works by reversing the

[Qemu-devel] [RFC PATCH v3 09/10] arm_gic: Add GICC_APRn state to the GICState

2013-11-18 Thread Christoffer Dall
The GICC_APRn registers are not currently supported by the ARM GIC v2.0 emulation. This patch adds the missing state. The state was previously added in the main vgic save/restore patch, but moved to a separate patch as suggested under review. Note that we also change the number of APRs to use a

[Qemu-devel] [RFC PATCH v3 06/10] arm_gic: Keep track of GICD_CPENDR and GICD_SPENDR

2013-11-18 Thread Christoffer Dall
If software writes to the ISPENDR and sets the pending state of a level-triggered interrupt, the falling edge of the hardware input must not clear the pending state. Conversely, if software writes to the ICPENDR, the pending state of a level-triggered interrupt should only be cleared if the

[Qemu-devel] [RFC PATCH v3 08/10] vmstate: Add uint32 2D-array support

2013-11-18 Thread Christoffer Dall
Add support for saving VMState of 2D arrays of uint32 values. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Christoffer Dall christoffer.d...@linaro.org --- include/migration/vmstate.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/migration/vmstate.h

[Qemu-devel] [RFC PATCH v3 02/10] hw: arm_gic: Introduce gic_set_priority function

2013-11-18 Thread Christoffer Dall
To make the code slightly cleaner to look at and make the save/restore code easier to understand, introduce this function to set the priority of interrupts. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Christoffer Dall christoffer.d...@linaro.org --- hw/intc/arm_gic.c

[Qemu-devel] [RFC PATCH v3 10/10] hw: arm_gic_kvm: Add KVM VGIC save/restore logic

2013-11-18 Thread Christoffer Dall
Save and restore the ARM KVM VGIC state from the kernel. We rely on QEMU to marshal the GICState data structure and therefore simply synchronize the kernel state with the QEMU emulated state in both directions. We take some care on the restore path to check the VGIC has been configured with

[Qemu-devel] console muti-head some more design input

2013-11-18 Thread Dave Airlie
So I've started banging my head against using QemuConsole as the container for a single output, and have been left with the usual 10 ways to design things, but since I don't want to spend ages implementing one way just to be told its unacceptable it would be good to get some more up front design

[Qemu-devel] [PATCH v2 0/2] Add cache mode option to qemu-iotests

2013-11-18 Thread Fam Zheng
The first patch adds -c mode option to ./check and convert -nocache to an alias to -c none. The mode is used in qemu-io. The second patch modifies iotests.py to use the cache mode option in qemu drive command line. Fam Zheng (2): qemu-iotests: Add -c cache-mode option qemu-iotests: Honour

[Qemu-devel] [PATCH v2 2/2] qemu-iotests: Honour cache mode in iotests.py

2013-11-18 Thread Fam Zheng
This will allow overriding cache mode from the -c mode option. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/iotests.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fb10ff4..c84a1a5

[Qemu-devel] [PATCH v2 1/2] qemu-iotests: Add -c cache-mode option

2013-11-18 Thread Fam Zheng
The option sets cache mode used in the tests. -nocache is changed to an alias to -c none, and internally passes -t none to qemu-io. Python scripts will make use of option this in the next commit. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/common | 18 -- 1

Re: [Qemu-devel] [PATCH] qemu-iotests: Add -c cache-mode to check

2013-11-18 Thread Fam Zheng
On 2013年11月18日 23:38, Kevin Wolf wrote: Am 18.11.2013 um 16:29 hat Stefan Hajnoczi geschrieben: On Thu, Nov 14, 2013 at 10:24:04AM +0800, Fam Zheng wrote: The default cache mode for drive options is changed to writethrough, and overridable with ./check -c mode. Please make the default

Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: Filter out qemu-io in all tests

2013-11-18 Thread Fam Zheng
The second patch is too big in size (over 10M), and rejected by list moderator. You can PULL from git branch: https://github.com/famz/qemu.git 035-filter-qemu-io On 2013年11月18日 15:21, Fam Zheng wrote: Fam Zheng (2): qemu-iotests: Filter qemu-io output in 025 qemu-iotests:

Re: [Qemu-devel] Multi-head support RFC

2013-11-18 Thread Gerd Hoffmann
Hi, I think it would be better if the HwOps calls all took a QemuConsole instead of the opaque structure. The hw implementations can dig their opaque structure out from there. QemuConsole is private to ui/console.c though (and I prefer to keep it this way). So we need either a helper

Re: [Qemu-devel] [PATCH] tcg: Use bitmaps for free temporaries

2013-11-18 Thread Richard Henderson
Ping? r~ On 09/20/2013 05:58 AM, Richard Henderson wrote: We previously allocated 32-bits per temp for the next_free_temp entry. We now allocate 4 bits per temp across the 4 bitmaps. Using a linked list meant that if a translator is tweeked, resulting in temps being freed in a different

<    1   2   3   >