Re: [Qemu-devel] pci: single device at function != 0

2013-11-20 Thread Benjamin Herrenschmidt
On Wed, 2013-11-20 at 18:39 +1100, Alexey Kardashevskiy wrote: Hi! It turned out that it is possible to start QEMU with a single PCI device placed at 0:0:1.1. I.e. function#1 and there is no function#0. The existing QEMU only fails if there is function#0 AND the multifunction bit is not set

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread Gerd Hoffmann
Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored somewhere. Oh yea, input. That needs quite some work for multihead / multiseat. I think we should *not* try to hack that into the ui. We should extend

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-20 Thread Gerd Hoffmann
Hi, btw: q35 has a fixed 1G window, max low ram addr is 0xb00, the remaining address space (0xb000 - 0xc000) is used for mmconfig. Is it really fixed? My understanding is it's programmed by firmware, you can put mmconfig whereever you want. Not really fixed, but it is

Re: [Qemu-devel] [edk2] [edk2 PATCH 0/1] OvmfPkg: grab ACPI tables from QEMU

2013-11-20 Thread Gerd Hoffmann
Hi, If you simply relax (drop) the stage-wise hole-setting, that will at best create a situation where OVMF and qemu duplicate the logic. This info needs to be passed down to OVMF (maybe it already is, somewhere in fw_cfg!), in some form that's more approachable than an ACPI table. (We

[Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-20 Thread Chunyan Liu
Add 'nocow' create option so that users could set nocow flag to newly created images, which could solve performance issues on btrfs. Btrfs has terrible performance when hosting VM images, even more when the guest in those VM are also using btrfs as file system. One way to mitigate this bad

[Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Stefan Hajnoczi
Hi Gerd, make check is failing on kraxel_rhel61 due to the following: ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1) http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782 Can you investigate? Perhaps there are stale files. (There is a

Re: [Qemu-devel] Buildbot failure: multiboot.o link error on OpenBSD current

2013-11-20 Thread Stefan Hajnoczi
Sorry I forgot to CC qemu-devel on this: On Wed, Nov 20, 2013 at 10:06 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Hi Brad, The QEMU buildbot is failing on brad_openbsd_current as follows: Building optionrom/multiboot.img ld: multiboot.o: relocation R_X86_64_16 can not be used when

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Stefan Hajnoczi
Sorry, I forgot to CC qemu-devel on this: On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Hi, The mingw32 build is failing as follows: In file included from qga/vss-win32.c:17: ./qga/vss-win32/requester.h:31: error: expected '=', ',', ';', 'asm' or

Re: [Qemu-devel] [PATCH 0/9] usb: redirection streams support + small fixes

2013-11-20 Thread Gerd Hoffmann
On Di, 2013-11-19 at 14:36 +0100, Hans de Goede wrote: Hi Gerd, Here are my outstanding qemu usb patches. Most of them have been send before and are just rebases. As before these depend on kernel / libusb streams support, which will hopefully go upstream for 3.14 . Queued thinks up. I

Re: [Qemu-devel] [PATCH 0/4 v4] block, arm: Fix buffered flash writes on VExpress

2013-11-20 Thread Stefan Hajnoczi
On Tue, Oct 22, 2013 at 09:35:52AM -0700, Roy Franz wrote: This patchset fixes buffered flash writes on the VExpress platform. Buffered writes should now work properly on platforms whose flash interface width is different from the device width. The default is for the device-width to be set

Re: [Qemu-devel] [PATCH 0/4] add sunxi machine

2013-11-20 Thread Peter Maydell
On 20 November 2013 07:53, liguang lig.f...@cn.fujitsu.com wrote: this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... Li Guang (4) hw/arm: add new machine type sunxi hw/arm/sunxi-soc: add interrupt controller

Re: [Qemu-devel] [PATCH 0/4 v4] block, arm: Fix buffered flash writes on VExpress

2013-11-20 Thread Peter Maydell
On 20 November 2013 09:22, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Oct 22, 2013 at 09:35:52AM -0700, Roy Franz wrote: This patchset fixes buffered flash writes on the VExpress platform. Buffered writes should now work properly on platforms whose flash interface width is different

Re: [Qemu-devel] [PATCH] MAINTAINERS: add sheepdog development mailing list

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 03:51:59PM +0800, Liu Yuan wrote: This will help people find mailing list relevant to sheepdog. Cc: Stefan Hajnoczi stefa...@redhat.com Cc: Kevin Wolf kw...@redhat.com Signed-off-by: Liu Yuan namei.u...@gmail.com --- MAINTAINERS |1 + 1 file changed, 1

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 00:00, Luigi Rizzo ha scritto: I recently found out that without kvm enabled, and especially with -smp 2 or greater, qemu becomes incredibly slow (to the point that you can see kernel messages in the quest print one character at a time). This happens with a Linux host (even

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] qobject: Fix compiler warning (missing gnu_printf format attribute)

2013-11-20 Thread Michael Tokarev
17.11.2013 22:00, Stefan Weil wrote: gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CCqobject/qerror.o qobject/qerror.c: In function ‘qerror_from_info’: qobject/qerror.c:53:5: error: function might be possible candidate for ‘gnu_printf’ format attribute

[Qemu-devel] [PATCH v2 0/9] Clean up IDE after completion of qdevification

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Obvious cleanups possible since we no longer have the special case of a non-qdevified controller. v2: * Dropped PATCH 1/10 ide: Break all non-qdevified controllers Andreas qdevified them since; thanks! * Series renamed from Drop code for non-qdevified

[Qemu-devel] [PATCH v2 3/9] ide: Don't block-align IDEState member smart_selftest_data

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com All uses are simple array subscripts. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index 0022cc5..2ed7cb8 100644 ---

[Qemu-devel] [PATCH v2 1/9] ide: Move IDEDevice pointer from IDEBus to IDEState

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/core.c | 2 +- hw/ide/internal.h | 3 +-- hw/ide/qdev.c | 12 +++- 3 files changed, 5 insertions(+), 12 deletions(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index

[Qemu-devel] [PATCH v2 8/9] ide: Drop redundant IDEState member model

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com It's a copy of dev-serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used

[Qemu-devel] [PATCH v2 4/9] ide: Drop redundant IDEState member bs

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com It's a copy of dev-conf.bs. The copy was needed for non-qdevified controllers, which lacked dev. Note how pci_piix3_xen_ide_unplug() cleared the copy. We'll get back to that in the next few commits. Signed-off-by: Markus Armbruster arm...@redhat.com

[Qemu-devel] [PATCH v2 5/9] ide: Drop redundant IDEState geometry members

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Members cylinders, heads, sectors, chs_trans are copies of dev-conf.cyls, dev-conf.heads, dev-conf.secs, dev-chs_trans. Copies were needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copies (it

[Qemu-devel] [PATCH v2 6/9] ide: Drop redundant IDEState member version

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com It's a copy of dev-version. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used

[Qemu-devel] [PATCH v2 2/9] ide: Use IDEState member dev for device connected test

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com Testing dev is more obvious than testing bs, in my opinion. Signed-off-by: Markus Armbruster arm...@redhat.com --- hw/ide/ahci.c | 8 hw/ide/core.c | 56 - hw/ide/microdrive.c |

[Qemu-devel] [PATCH v2 9/9] ide: Drop redundant IDEState member wwn

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com It's a copy of dev-wwn. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used after

[Qemu-devel] [PATCH v2 7/9] ide: Drop redundant IDEState member drive_serial_str

2013-11-20 Thread armbru
From: Markus Armbruster arm...@redhat.com It's a copy of dev-serial. The copy was needed for non-qdevified controllers, which lacked dev. Note that pci_piix3_xen_ide_unplug() did not clear the copy (it only cleared the copy of bs). Begs the question whether stale data could have been used

Re: [Qemu-devel] [PATCH v2 03/20] block: add flags argument to bdrv_co_write_zeroes tracepoint

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:26PM +0100, Paolo Bonzini wrote: diff --git a/trace-events b/trace-events index 8695e9e..6175b61 100644 --- a/trace-events +++ b/trace-events @@ -64,7 +64,7 @@ bdrv_lock_medium(void *bs, bool locked) bs %p locked %d bdrv_co_readv(void *bs, int64_t sector_num,

Re: [Qemu-devel] [PATCH v2 04/20] block: add bdrv_aio_write_zeroes

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:27PM +0100, Paolo Bonzini wrote: diff --git a/trace-events b/trace-events index 6175b61..a18ea59 100644 --- a/trace-events +++ b/trace-events @@ -60,6 +60,7 @@ bdrv_aio_discard(void *bs, int64_t sector_num, int nb_sectors, void *opaque) bs bdrv_aio_flush(void

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:29PM +0100, Paolo Bonzini wrote: @@ -2761,14 +2761,19 @@ static int coroutine_fn bdrv_co_do_write_zeroes(BlockDriverState *bs, while (nb_sectors 0 !ret) { int num = nb_sectors; -/* align request */ -if

Re: [Qemu-devel] [PATCH for-1.7?] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 06:28, Wangting (Kathy) ha scritto: Hi Paolo and Stefan, I am really sorry for my email before that I didn't say clearly about the bug fix. f-bytes_xfer means the number of bytes which is send from source to destination during the migration. It is limited by the f-xfer_limit

Re: [Qemu-devel] [PATCH 1/8] ui/sdl2 : initial port to SDL 2.0 (v1.2)

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com I've ported the SDL1.2 code over, and rewritten it to use the SDL2 interface. Looks sane on a quick glance. Didn't look in detail yet. I would have suggested to put stuff into structs instead of using

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Luigi Rizzo
On Wed, Nov 20, 2013 at 10:41:22AM +0100, Paolo Bonzini wrote: Il 20/11/2013 00:00, Luigi Rizzo ha scritto: I recently found out that without kvm enabled, and especially with -smp 2 or greater, qemu becomes incredibly slow (to the point that you can see kernel messages in the quest print

Re: [Qemu-devel] [PATCH 21/21] block: add spice block device backend

2013-11-20 Thread Marc-André Lureau
/note to self: - add failing case where nbd channel isn't connected before and after migration (do not wait for nbd init or disconnection) On Mon, Nov 18, 2013 at 1:25 PM, Marc-André Lureau marcandre.lur...@gmail.com wrote: From: Marc-André Lureau marcandre.lur...@redhat.com Signed-off-by:

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 11:22, Stefan Hajnoczi ha scritto: + num bs-bl.write_zeroes_alignment) { Here '' is used... +if (sector_num % bs-bl.write_zeroes_alignment != 0) { +/* Make a small request up to the first aligned sector. */ num

Re: [Qemu-devel] [PATCH 2/8] console: add state notifiers for ui-display

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com These are to be used for the UI to signal the video display, and vice-versa about changes in the state of a console, like size and offsets in relation to other consoles for input handling. See other

Re: [Qemu-devel] [PATCH 3/8] console: add information retrival wrappers

2013-11-20 Thread Gerd Hoffmann
Hi, +int qemu_get_console_index(QemuConsole *con); Makes sense to have that. There are other retrival wrappers already (qemu_console_is_*). I'd like to see the new one placed next to the others, and follow the name convention (i.e. use qemu_console_get_index). +int

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 12:00, Luigi Rizzo ha scritto: WITHOUT THE PATCH, booting becomes slow as soon as the timer tick starts and we load dummynet (which also starts a kernel thread every millisecond). You should be able to see how the printing of kernel messages slows down

[Qemu-devel] [PULL] migration queue

2013-11-20 Thread Juan Quintela
Hi Anthony Please apply. Brown paper bug where we are adding total size in each iteration, and not the real transmitted value. Thanks, Juan. The following changes since commit 394cfa39ba24dd838ace1308ae24961243947fb8: Merge remote-tracking branch 'quintela/migration.next' into staging

Re: [Qemu-devel] [PATCH 6/8] virtio-gpu: v0.1 of the virtio based GPU code.

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This is the basic virtio-gpu which is multi-head capable, ARGB cursor support, unaccelerated. I'd like to see an overview on the design of the virtual hardware. What is the purpose of the virtio

[Qemu-devel] [PATCH] The calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Juan Quintela
From: Wangting (Kathy) kathy.wangt...@huawei.com In qemu_put_buffer(), bytes_xfer += size is wrong, it will be more than expected, and should be bytes_xfer += l. Signed-off-by: zhangmin zhangm...@huawei.com Signed-off-by: Juan Quintela quint...@redhat.com --- savevm.c | 2 +- 1 file changed, 1

Re: [Qemu-devel] [PATCH] the calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Juan Quintela
Wangting (Kathy) kathy.wangt...@huawei.com wrote: In qemu_put_buffer(), bytes_xfer += size is wrong, it will be more than expected, and should be bytes_xfer += l. Signed-off-by: zhangmin zhangm...@huawei.com Good spot. Applied and sent pull request to Anthony.

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7 v2] qga: Fix compiler warnings (missing format attribute, wrong format strings)

2013-11-20 Thread Michael Tokarev
17.11.2013 22:19, Stefan Weil wrote: gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CCqga/commands.o qga/commands.c: In function ‘slog’: qga/commands.c:28:5: error: function might be possible candidate for ‘gnu_printf’ format attribute

Re: [Qemu-devel] [Qemu-trivial] [PATCH for 1.7] acpi-build: Fix compiler warning (missing gnu_printf format attribute)

2013-11-20 Thread Michael Tokarev
17.11.2013 22:00, Stefan Weil wrote: gcc 4.8.2 reports this warning when extra warnings are enabled (-Wextra): CCm68k-softmmu/hw/m68k/mcf5206.o hw/i386/acpi-build.c: In function ‘build_append_nameseg’: hw/i386/acpi-build.c:294:5: error: function might be possible candidate for

[Qemu-devel] [PATCH for 1.7] target-i386: yield to another VCPU on PAUSE

2013-11-20 Thread Paolo Bonzini
After commit b1bbfe7 (aio / timers: On timer modification, qemu_notify or aio_notify, 2013-08-21) FreeBSD guests report a huge slowdown. The problem shows up as soon as FreeBSD turns out its periodic (~1 ms) tick, but the timers are only the trigger for a pre-existing problem. Before the

Re: [Qemu-devel] [PATCH 7/8] virtio-vga: v1

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 15:52 +1000, Dave Airlie wrote: From: Dave Airlie airl...@redhat.com This is a virtio-vga device built on top of the virtio-gpu device. Ah, I see what you use the wrapping for. Hmm. I think you should use a common base class instead, i.e. something like virtio-gpu-base

[Qemu-devel] [PATCH 0/2] qdict_flatten() fixes

2013-11-20 Thread Kevin Wolf
Kevin Wolf (2): qdict: Fix memory leak in qdict_do_flatten() qdict: Optimise qdict_do_flatten() qobject/qdict.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) -- 1.8.1.4

[Qemu-devel] [PATCH 1/2] qdict: Fix memory leak in qdict_do_flatten()

2013-11-20 Thread Kevin Wolf
Reported-by: Laszlo Ersek ler...@redhat.com Signed-off-by: Kevin Wolf kw...@redhat.com --- qobject/qdict.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qobject/qdict.c b/qobject/qdict.c index 0f3e0a6..60d6cd5 100644 --- a/qobject/qdict.c +++ b/qobject/qdict.c @@ -481,7

[Qemu-devel] [PATCH 2/2] qdict: Optimise qdict_do_flatten()

2013-11-20 Thread Kevin Wolf
Nested QDicts used to be both entered recursively in order to move their entries to the target QDict and also be moved themselves to the target QDict like all other objects. This is harmless because for the top level, qdict_do_flatten() will encounter the (now empty) QDict for a second time and

Re: [Qemu-devel] [PATCH] The calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Orit Wasserman
On 11/20/2013 01:26 PM, Juan Quintela wrote: From: Wangting (Kathy) kathy.wangt...@huawei.com In qemu_put_buffer(), bytes_xfer += size is wrong, it will be more than expected, and should be bytes_xfer += l. Signed-off-by: zhangmin zhangm...@huawei.com Signed-off-by: Juan Quintela

Re: [Qemu-devel] [PATCH 0/2] qdict_flatten() fixes

2013-11-20 Thread Laszlo Ersek
On 11/20/13 13:09, Kevin Wolf wrote: Kevin Wolf (2): qdict: Fix memory leak in qdict_do_flatten() qdict: Optimise qdict_do_flatten() qobject/qdict.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Had to look at my earlier review to page-in this stuff. The

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: Hi Gerd, make check is failing on kraxel_rhel61 due to the following: ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1) http://buildbot.b1-systems.de/qemu/builders/default_x86_64_rhel61/builds/782

Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:30PM +0100, Paolo Bonzini wrote: +static int vhdx_get_info(BlockDriverState *bs, BlockDriverInfo *bdi) +{ +BDRVVHDXState *s = bs-opaque; + +bdi-cluster_size = +(s-logical_sector_size / BDRV_SECTOR_SIZE) * s-block_size; I thought s-block_size is

Re: [Qemu-devel] [PATCH v2 07/20] vpc, vhdx: add get_info

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 13:39, Stefan Hajnoczi ha scritto: + +bdi-cluster_size = +(s-logical_sector_size / BDRV_SECTOR_SIZE) * s-block_size; I thought s-block_size is in bytes. Why multiply by the logical block size in 512-byte sectors? My mistake. Paolo

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Alex Bligh
Paolo, On 20 Nov 2013, at 11:19, Paolo Bonzini wrote: Before Alex's patch, setting a timer did a timer_settime system call. After, setting the timer exits QEMU's event loop (which uses poll) and reenters it with a new deadline. This wouldn't be a problem; the difference is between one

Re: [Qemu-devel] commit b1bbfe72 causes huge slowdown with no kvm

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 14:47, Alex Bligh ha scritto: I think you are saying this sounds like another underlying bug (no pause instruction) uncovered by the timer patches rather than a bug in the timer patches. Reading http://software.intel.com/file/27087 perhaps the answer is for pause to yield

Re: [Qemu-devel] [PATCH for 1.7] target-i386: do not override nr_cores for -cpu host

2013-11-20 Thread Eduardo Habkost
On Tue, Nov 19, 2013 at 05:49:46PM +0100, Paolo Bonzini wrote: Commit 787aaf5 (target-i386: forward CPUID cache leaves when -cpu host is used, 2013-09-02) brings bits 31..26 of CPUID leaf 04h out of sync with the APIC IDs that QEMU reserves for each package. This number must come from -smp

Re: [Qemu-devel] [PATCH for 1.7] target-i386: yield to another VCPU on PAUSE

2013-11-20 Thread Luigi Rizzo
On Wed, Nov 20, 2013 at 12:54:02PM +0100, Paolo Bonzini wrote: After commit b1bbfe7 (aio / timers: On timer modification, qemu_notify or aio_notify, 2013-08-21) FreeBSD guests report a huge slowdown. The problem shows up as soon as FreeBSD turns out its periodic (~1 ms) tick, but the timers

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-20 Thread Stefan Hajnoczi
On Tue, Nov 19, 2013 at 06:07:43PM +0100, Paolo Bonzini wrote: +static void scsi_disk_emulate_write_same(SCSIDiskReq *r, uint8_t *inbuf) +{ +SCSIRequest *req = r-req; +SCSIDiskState *s = DO_UPCAST(SCSIDiskState, qdev, req-dev); +uint32_t nb_sectors =

Re: [Qemu-devel] [PATCH v2 20/20] scsi-disk: correctly implement WRITE SAME

2013-11-20 Thread Paolo Bonzini
Il 20/11/2013 15:18, Stefan Hajnoczi ha scritto: +if (buffer_is_zero(inbuf, s-qdev.blocksize)) { Where is inbuf's size checked? It must be s-qdev.blocksize for this code to be correct. See scsi_req_length: case WRITE_SAME_10: case WRITE_SAME_16: cmd-xfer =

Re: [Qemu-devel] [PATCH 0/4 v4] block, arm: Fix buffered flash writes on VExpress

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 09:27:22AM +, Peter Maydell wrote: On 20 November 2013 09:22, Stefan Hajnoczi stefa...@gmail.com wrote: On Tue, Oct 22, 2013 at 09:35:52AM -0700, Roy Franz wrote: This patchset fixes buffered flash writes on the VExpress platform. Buffered writes should now work

Re: [Qemu-devel] [PATCH v2 06/20] block: make bdrv_co_do_write_zeroes stricter in producing aligned requests

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 12:01:46PM +0100, Paolo Bonzini wrote: Il 20/11/2013 11:22, Stefan Hajnoczi ha scritto: + num bs-bl.write_zeroes_alignment) { Here '' is used... +if (sector_num % bs-bl.write_zeroes_alignment != 0) { +/* Make a small

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread John Baboval
On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored somewhere. Oh yea, input. That needs quite some work for multihead / multiseat. I think we should *not* try

[Qemu-devel] [PATCH 6/6] usb-tablet: add microsoft os descriptor support

2013-11-20 Thread Gerd Hoffmann
Set SelectiveSuspendEnabled registy entry to one. This makes Windows use remote suspend by default, without manual registry fiddeling. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-hid.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c

[Qemu-devel] [PATCH 2/6] Revert usb-tablet: Don't claim wakeup capability for USB-2 version

2013-11-20 Thread Gerd Hoffmann
This reverts commit aa1c9e971e80d25b92908dce3dec7c38b49480ea. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/dev-hid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/dev-hid.c b/hw/usb/dev-hid.c index 5956720..5e667f0 100644 --- a/hw/usb/dev-hid.c +++

[Qemu-devel] [PATCH v2] curses: fixup SIGWINCH handler mess

2013-11-20 Thread Gerd Hoffmann
Don't run code in the signal handler, only set a flag. Use sigaction(2) to avoid non-portable signal(2) semantics. Make #ifdefs less messy. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/curses.c | 44 1 file changed, 28 insertions(+), 16

[Qemu-devel] [PATCH 5/6] usb: add support for microsoft os descriptors

2013-11-20 Thread Gerd Hoffmann
This patch adds support for special usb descriptors used by microsoft windows. They allow more fine-grained control over driver binding and adding entries to the registry for configuration. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/Makefile.objs | 2 +- hw/usb/desc-msos.c |

[Qemu-devel] [PATCH 0/6] usb: remote wakeup improvements

2013-11-20 Thread Gerd Hoffmann
Hi, USB patch series from the ReduceWakeupRate department. Patch #1 implements remote wakeup support to the ehci emulation. Patch #2 reverts a workaround for lacking ehci remote wakeup support in the highspeed version of the usb tablet. Patches #3 + #4 are small preparations for #5.

[Qemu-devel] [PULL 5/7] openrisc-timer: Reduce overhead, Separate clock update functions

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de The clock value is only evaluated when really necessary reducing the overhead of the timer handling. This also solves a problem in the way the Linux kernel handles the timer and the expected accuracy. The old version could lead to inaccurate timings.

[Qemu-devel] [PULL 4/7] target-openrisc: Correct wrong epcr register in interrupt handler

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de This patch corrects several misbehaviors during an interrupt process. Most of the time the pc is already correct and therefore no special treatment of the exceptions is necessary. Tested by checking crashing programs which otherwise work in or1ksim.

[Qemu-devel] [PULL 7/7] target-openrisc: Correct carry flag check of l.addc and l.addic test cases

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de The test cases did not correctly test for the carry flag. Signed-off-by: Sebastian Macke sebast...@macke.de Reviewed-by: Jia Liu pro...@gmail.com Signed-off-by: Jia Liu pro...@gmail.com --- tests/tcg/openrisc/test_addc.c | 8 +---

[Qemu-devel] [PULL 3/7] target-openrisc: Remove executable flag for every page

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de Pages should be flagged executable only if the tlb executable flag is set or the mmu is off. Signed-off-by: Sebastian Macke sebast...@macke.de Reviewed-by: Jia Liu pro...@gmail.com Signed-off-by: Jia Liu pro...@gmail.com --- target-openrisc/mmu.c | 4

[Qemu-devel] [PULL 6/7] target-openrisc: Correct memory bounds checking for the tlb buffers

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de The mtspr and mfspr routines didn't check for the correct memory boundaries. This fixes a segmentation fault while booting Linux. Signed-off-by: Sebastian Macke sebast...@macke.de Reviewed-by: Jia Liu pro...@gmail.com Signed-off-by: Jia Liu

Re: [Qemu-devel] [PATCH 26/60] AArch64: Add ADR instruction emulation

2013-11-20 Thread Michael Matz
Hi, On Tue, 19 Nov 2013, Claudio Fontana wrote: +uint64_t imm; +uint64_t base; + +imm = get_sbits(insn, 5, 19) 2; +imm |= get_bits(insn, 29, 2); does this work with negative values? Yes. get_sbits returns a sign extended (32bit) int, the shift doesn't change

Re: [Qemu-devel] [PATCH 50/60] AArch64: Add Floating-point-fixed-point

2013-11-20 Thread Michael Matz
Hi, On Tue, 19 Nov 2013, Janne Grunau wrote: +static void handle_fpfpconv(DisasContext *s, uint32_t insn) +{ +int opcode = get_bits(insn, 16, 3); +int rmode = get_bits(insn, 20, 2); rmode is at 19 +case 0x1: /* [S|U]CVTF (scalar-float) */ and it's case 0x0: for

[Qemu-devel] [PULL 0/7] OpenRISC patch queue for 1.7

2013-11-20 Thread Jia Liu
Hi Anthony, Hi Blue, This is my OpenRISC patch queue for 1.7, it have been well tested, please pull. Thanks to Sebastian Macke, it made move optimization and fix some bugs. The following changes since commit 394cfa39ba24dd838ace1308ae24961243947fb8: Merge remote-tracking branch

[Qemu-devel] [PATCH 4/6] usb: move usb_{hi, lo} helpers to header file.

2013-11-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/desc.c | 10 -- hw/usb/desc.h | 11 +++ 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/hw/usb/desc.c b/hw/usb/desc.c index 5dbe754..f18a043 100644 --- a/hw/usb/desc.c +++ b/hw/usb/desc.c @@ -6,16 +6,6 @@

[Qemu-devel] [PULL 1/7] target-openrisc: Speed up move instruction

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de The OpenRISC architecture does not have its own move register instruction. Instead it uses either l.addi rd, r0, x or l.ori rd, rs, 0 or l.or rd, rx, r0 The l.ori instruction is automatically optimized but not the l.addi instruction. This patch optimizes

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread Gerd Hoffmann
On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored somewhere. Oh yea, input. That needs quite some

Re: [Qemu-devel] [PATCH] qemu-img create: add -o nocow option

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 04:50:29PM +0800, Chunyan Liu wrote: block/cow.c | 22 ++ block/qcow.c | 22 ++ block/qcow2.c | 22 ++ I think you can avoid modifying all the image formats:

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote: On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: Hi Gerd, make check is failing on kraxel_rhel61 due to the following: ERROR:tests/libqtest.c:71:init_socket: assertion failed (ret != -1): (-1 != -1)

[Qemu-devel] [PATCH 3/6] usb: add vendor request defines

2013-11-20 Thread Gerd Hoffmann
Add defines for vendor specific usb control requests. Group defines by Device / Interface / Endpoint while being at it. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/hw/usb.h | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/include/hw/usb.h

[Qemu-devel] [PULL 2/7] target-openrisc: Remove unnecessary code generated by jump instructions

2013-11-20 Thread Jia Liu
From: Sebastian Macke sebast...@macke.de The sr_f variable is only used for the l.bf and l.bnf instructions. For clarity the code is also rewritten using a switch statement instead of if chaining. Signed-off-by: Sebastian Macke sebast...@macke.de Reviewed-by: Jia Liu pro...@gmail.com

[Qemu-devel] [PATCH 1/6] ehci: implement port wakeup

2013-11-20 Thread Gerd Hoffmann
Update portsc register and raise irq in case a suspended port is woken up, so remote wakeup works on our ehci ports. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- hw/usb/hcd-ehci.c | 18 -- trace-events | 3 +++ 2 files changed, 19 insertions(+), 2 deletions(-) diff

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-20 Thread Andreas Färber
Am 19.11.2013 21:01, schrieb Peter Maydell: I find myself with a use case where I would like to set a CPU object property from the board model init function (specifically, I'd like the board model to be able to say this CPU will boot via PSCI so if you're KVM then start it appropriately).

Re: [Qemu-devel] ARM cpu object, setting properties from board model

2013-11-20 Thread Peter Maydell
On 20 November 2013 15:19, Andreas Färber afaer...@suse.de wrote: My first thought without reviewing the code is to just inline object_new() followed by object_property_set_bool() in the machine - that's what I've done for my downstream rl78, where I needed to postpone realizing the CPU until

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread John Baboval
On 11/20/2013 10:14 AM, Gerd Hoffmann wrote: On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and this needs to be stored

Re: [Qemu-devel] [PATCH 0/2] qdict_flatten() fixes

2013-11-20 Thread Stefan Hajnoczi
On Wed, Nov 20, 2013 at 01:09:19PM +0100, Kevin Wolf wrote: Kevin Wolf (2): qdict: Fix memory leak in qdict_do_flatten() qdict: Optimise qdict_do_flatten() qobject/qdict.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) Thanks, applied to my block-next tree:

Re: [Qemu-devel] Buildbot failure: libqtest init_socket assertion failure

2013-11-20 Thread Andreas Färber
Am 20.11.2013 16:16, schrieb Stefan Hajnoczi: On Wed, Nov 20, 2013 at 01:38:31PM +0100, Gerd Hoffmann wrote: On Mi, 2013-11-20 at 10:00 +0100, Stefan Hajnoczi wrote: Hi Gerd, make check is failing on kraxel_rhel61 due to the following: ERROR:tests/libqtest.c:71:init_socket: assertion failed

[Qemu-devel] virtio-net: network stops responding in Win2k3 server

2013-11-20 Thread ing. Mario De Chenno
Hi all. We are facing some network issues on some Windows Server 2003 machines. In short, network seems to lock up and stops responding even to ping requests. From TCPdump on the tap interface on the server I only see arp request to the gateway, without replies. Increased tx overruns on the some

Re: [Qemu-devel] [PATCH v6 RESENT 0/2] sheepdog: add user-defined redundancy option

2013-11-20 Thread Liu Yuan
On Mon, Nov 18, 2013 at 01:58:50PM +0800, Liu Yuan wrote: On Thu, Nov 07, 2013 at 10:56:36PM +0800, Liu Yuan wrote: v6: - update comment typo - remove is_number() Anyone pick this set up? Ping again. Without this two patches, qemu-img can't create|convert erasure coded images for

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Tomoki Sekiyama
Hi Stefan, On 11/20/13 4:16 , Stefan Hajnoczi stefa...@gmail.com wrote: Sorry, I forgot to CC qemu-devel on this: On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Hi, The mingw32 build is failing as follows: In file included from qga/vss-win32.c:17:

Re: [Qemu-devel] Buildbot failure: qga/vss-win32/requester.h compile error

2013-11-20 Thread Stefan Weil
Am 20.11.2013 18:40, schrieb Tomoki Sekiyama: Hi Stefan, On 11/20/13 4:16 , Stefan Hajnoczi stefa...@gmail.com wrote: Sorry, I forgot to CC qemu-devel on this: On Wed, Nov 20, 2013 at 10:14 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Hi, The mingw32 build is failing as follows: In

Re: [Qemu-devel] [PATCH for 1.7] kvm: Fix uninitialized cpuid_data

2013-11-20 Thread Stefan Weil
Am 07.11.2013 12:15, schrieb Gleb Natapov: On Wed, Nov 06, 2013 at 10:35:27PM +0100, Stefan Weil wrote: This error was reported by valgrind when running qemu-system-x86_64 with kvm: ==975== Conditional jump or move depends on uninitialised value(s) ==975==at 0x521C38: cpuid_find_entry

Re: [Qemu-devel] [PATCH for-1.7] mips jazz: do not raise data bus exception when accessing invalid addresses

2013-11-20 Thread Hervé Poussineau
Ping again for 1.7. This fixes a regression introduced in 1.6.0, reported by some people on mailing list ([1] Hervé [1] http://lists.gnu.org/archive/html/qemu-devel/2013-11/msg02055.html Hervé Poussineau a écrit : Ping for 1.7 Paolo Bonzini a écrit : Il 04/11/2013 23:26, Hervé Poussineau

[Qemu-devel] pcm.c:7843:(snd_pcm_recover) underrun occurred

2013-11-20 Thread Francesco Turco
Hello. I'm not sure if asking in qemu-devel is the right thing to do, as I'm not a QEMU developer, but stefanha in the #qemu IRC channel told me to do so. :-) I'm running QEMU 1.6.1 on a 64-bit Gentoo Linux system. The guest operating system is Windows 7 32-bit. I get multiple identical

[Qemu-devel] a bug in qemu-retranslator with Windows7 x64 Zero Page Thread

2013-11-20 Thread Anna Melekhova
Dear Sirs, I've run into a curious bug in qemu retranslator that looks like a code self-modification from Zero Page Thread. Test case: Win7 x64 on installation while running w/o KVM gives a BSOD. 45/45 - 100% reproduction. I've tried to analyze dumps but it is installation stage and qemu has

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-20 Thread Stefan Berger
On 11/19/2013 06:03 PM, Anthony Liguori wrote: On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant cor...@linux.vnet.ibm.com wrote: This patch series provides support for a

[Qemu-devel] [Bug 1253465] [NEW] qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3

2013-11-20 Thread adrelanos
Public bug reported: qemu-img convert in.vmdk -O RAW out.img Fails with: qemu-img: 'image' uses a vmdk feature which is not supported by this qemu version: VMDK version 3 qemu-img version 1.6.1 ** Affects: qemu Importance: Undecided Status: New -- You received this bug

Re: [Qemu-devel] [PATCH 0/4] add sunxi machine

2013-11-20 Thread Li Guang
Hi, Peter Peter Maydell wrote: On 20 November 2013 07:53, liguanglig.f...@cn.fujitsu.com wrote: this patch-set implemented a device-reduced machine type for Allwinner's sunxi series SoC, like sunxi-4i/5i/7i ... Li Guang (4) hw/arm: add new machine type sunxi

Re: [Qemu-devel] console muti-head some more design input

2013-11-20 Thread Dave Airlie
On Thu, Nov 21, 2013 at 1:14 AM, Gerd Hoffmann kra...@redhat.com wrote: On Mi, 2013-11-20 at 09:32 -0500, John Baboval wrote: On 11/20/2013 03:12 AM, Gerd Hoffmann wrote: Hi, I think you are only considering output here, for input we definitely need some idea of screen layout, and

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-20 Thread Anthony Liguori
On Wed, Nov 20, 2013 at 2:01 PM, Stefan Berger stef...@linux.vnet.ibm.com wrote: On 11/19/2013 06:03 PM, Anthony Liguori wrote: On Tue, Nov 19, 2013 at 1:32 PM, Corey Bryant cor...@linux.vnet.ibm.com wrote: On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM,

  1   2   >