Re: [Qemu-devel] [PATCH v2] docs/specs/qcow2.txt: fix incorrect bits of offsets in entries

2014-01-20 Thread Kevin Wolf
Am 17.01.2014 um 08:40 hat Stefan Hajnoczi geschrieben: > On Mon, Dec 30, 2013 at 04:00:17PM +0800, Hu Tao wrote: > > Fix incorrect bits of offsets in refcount table entry, l1 table > > entry and l2 table entry. See REFT_OFFSET_MASK, L1E_OFFSET_MASK > > and L2E_OFFSET_MASK. > > > > Fix a typo whil

Re: [Qemu-devel] [PATCH 0/3] acpi unit-test: fixes and improvements

2014-01-20 Thread Michael S. Tsirkin
On Thu, Jan 16, 2014 at 05:50:45PM +0200, Marcel Apfelbaum wrote: > patch 1: refactoring >Addressed Michael S. Tsirkin's prev comments: >Renamed ssdt_tables to tables to avoid confusion. > patch 2: resolved iasl crash > Addressed Michael S. Tsirkin's prev comments: > Do not assume

Re: [Qemu-devel] [PATCH v3 01/29] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2014-01-20 Thread Kevin Wolf
Am 17.01.2014 um 23:39 hat Benoît Canet geschrieben: > Le Friday 17 Jan 2014 à 15:14:51 (+0100), Kevin Wolf a écrit : > > This function separates filling the BlockLimits from bdrv_open(), which > > allows it to call it from other operations which may change the limits > > (e.g. modifications to the

Re: [Qemu-devel] [PATCH v3 28/29] qemu-iotests: Test pwritev RMW logic

2014-01-20 Thread Kevin Wolf
Am 18.01.2014 um 17:01 hat Max Reitz geschrieben: > On 17.01.2014 15:15, Kevin Wolf wrote: > >Signed-off-by: Kevin Wolf > >--- > > block.c| 7 ++ > > block/blkdebug.c | 8 ++ > > include/block/block.h | 8 ++ > > tests/qemu-iotests/077 | 278 > > +

Re: [Qemu-devel] [PATCH v3 01/29] block: Move initialisation of BlockLimits to bdrv_refresh_limits()

2014-01-20 Thread Peter Lieven
On 20.01.2014 10:31, Kevin Wolf wrote: Am 17.01.2014 um 23:39 hat Benoît Canet geschrieben: Le Friday 17 Jan 2014 à 15:14:51 (+0100), Kevin Wolf a écrit : This function separates filling the BlockLimits from bdrv_open(), which allows it to call it from other operations which may change the limi

Re: [Qemu-devel] [PATCH] gtk: Support keyboard translation for hosts running Windows

2014-01-20 Thread Paolo Bonzini
Il 19/01/2014 22:18, Stefan Weil ha scritto: > Ping^3. What is missing to get this patch applied? It was sent more than > a month ago (2012-12-07). You are Win32 maintainer, just send a pull request. Paolo

Re: [Qemu-devel] [PATCHv4 0/6] ui/vnc: update optimizations

2014-01-20 Thread Peter Lieven
Ping On 08.01.2014 10:08, Peter Lieven wrote: this series includes several optimizations for the ui/vnc guest to server and server to client update cycles. comments/reviews appreciated. v3->v4: - patch 1,4,6 unchanged - patch 2: fix 2 missing changes from 16 -> VNC_DIRTY_PIXELS_PER_BI

Re: [Qemu-devel] [PATCH v3 27/29] qemu-io: New command 'sleep'

2014-01-20 Thread Kevin Wolf
Am 18.01.2014 um 00:55 hat Max Reitz geschrieben: > On 17.01.2014 15:15, Kevin Wolf wrote: > >There is no easy way to check that a request correctly waits for a > >different request. With a sleep command we can at least approximate it. > > > >Signed-off-by: Kevin Wolf > >--- > > qemu-io-cmds.c |

Re: [Qemu-devel] [PATCH 09/10] PPC: Add u-boot firmware for e500

2014-01-20 Thread Alexander Graf
> Am 20.01.2014 um 01:17 schrieb Peter Maydell : > >> On 19 January 2014 23:44, Alexander Graf wrote: >> This adds a special build of u-boot tailored for the e500 platforms we >> emulate. It is based on patches that are currently in the review process, >> so there's no hash commit to refer to y

Re: [Qemu-devel] [RFC v2 1/6] rfifolock: add recursive FIFO lock

2014-01-20 Thread Fam Zheng
On Fri, 01/10 09:45, Stefan Hajnoczi wrote: > QemuMutex does not guarantee fairness and cannot be acquired > recursively: > > Fairness means each locker gets a turn and the scheduler cannot cause > starvation. > > Recursive locking is useful for composition, it allows a sequence of > locking oper

Re: [Qemu-devel] [RFC v2 2/6] aio: add aio_context_acquire() and aio_context_release()

2014-01-20 Thread Fam Zheng
On Fri, 01/10 09:45, Stefan Hajnoczi wrote: > It can be useful to run an AioContext from a thread which normally does > not "own" the AioContext. For example, request draining can be > implemented by acquiring the AioContext and looping aio_poll() until all > requests have been completed. > > The

[Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message

2014-01-20 Thread Alon Levy
Signed-off-by: Alon Levy --- hw/display/qxl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/display/qxl.c b/hw/display/qxl.c index e4f172e..f6af470 100644 --- a/hw/display/qxl.c +++ b/hw/display/qxl.c @@ -1367,7 +1367,8 @@ static void qxl_create_guest_primary(PCIQXLDevi

[Qemu-devel] [PATCH 2/2] qxl: clear irq on reset

2014-01-20 Thread Alon Levy
Without this we occasionally trigger an assert at hw/pci/pci.c:pcibus_reset that asserts the irq_count is zero on reset. This has become a problem with the new drm driver for linux, since doing a reboot from console causes a race between console updates that set the irq and the reset assertion tha

Re: [Qemu-devel] [PATCH V3 01/01] Docs: Introduce multiport serial support in qemupciserial.inf.

2014-01-20 Thread Hervé Poussineau
Miki Mishael a écrit : Support for pci-serial-2x and pci-serial-4x was added to the inf file. Standard Windows driver mf.sys used to split single function device into per-port nodes. Signed-off-by: Miki Mishael Signed-off-by: Dmitry Fleytman --- Reviewed-by: Hervé Pou

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Michael S. Tsirkin
On Tue, Dec 17, 2013 at 06:56:06PM +0100, Gerd Hoffmann wrote: > > I merged your patch but split it: q35 is separate and piix > > is separate. Would you like me to drop the q35 part then? > > If you are fine with q35 having only 2G lowmem keep it. It's safe. > > We can sort the mmconfig setup af

[Qemu-devel] [PATCH] build: Fix installation of target-dependent files

2014-01-20 Thread Lluís Vilanova
Pass all the relevant sub-directory make variables. Signed-off-by: Lluís Vilanova --- Makefile |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index bdff4e4..02ae76d 100644 --- a/Makefile +++ b/Makefile @@ -366,7 +366,7 @@ endif $(INSTAL

Re: [Qemu-devel] [PATCH 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice

2014-01-20 Thread Michael S. Tsirkin
On Tue, Jan 14, 2014 at 05:55:54PM +0100, Igor Mammedov wrote: > make qdev_unplug()/device_set_realized() to call hotplug handler's > plug/unplug methods if available and remove not needed anymore > hot(un)plug handling from PCIDevice. > > In case if hotplug handler is not available, revert to the

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Michael S. Tsirkin
On Fri, Jan 17, 2014 at 04:10:16PM -0500, Gabriel L. Somlo wrote: > On Fri, Jan 10, 2014 at 05:13:11PM +0100, Igor Mammedov wrote: > > > On Fri, Jan 10, 2014 at 01:37:14PM +0100, Paolo Bonzini wrote: > > > > Il 09/01/2014 22:44, Gabriel L. Somlo ha scritto: > > > > > 1. hardcode "IRQNoFlags(){2, 8}

Re: [Qemu-devel] [PATCH 1/2] hw/display/qxl: improve framebuffer error message

2014-01-20 Thread Markus Armbruster
Alon Levy writes: > Signed-off-by: Alon Levy > --- > hw/display/qxl.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/hw/display/qxl.c b/hw/display/qxl.c > index e4f172e..f6af470 100644 > --- a/hw/display/qxl.c > +++ b/hw/display/qxl.c > @@ -1367,7 +1367,8 @@ static v

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Paolo Bonzini
Il 20/01/2014 12:58, Michael S. Tsirkin ha scritto: > I think at this point I agree. > > I think the hack looking for the SMC device is safer than _OSI: OSPMs > are known to do crazy things when they see _OSI, such as assuming they > need to try and emulate the OS probed. Source? Paolo

Re: [Qemu-devel] [RFC][PATCH 0/2] qapi: Allow modularization of QAPI schema files

2014-01-20 Thread Lluís Vilanova
Lluís Vilanova writes: > Adds the "include(...)" primitive to the syntax of QAPI schema files, allowing > these to be modularized into multiple per-topic files in the future. I missed the maintainers on the original mail, although I'm not sure this is the right selection. Lluis -- "And it's

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Igor Mammedov
On Fri, 17 Jan 2014 16:10:16 -0500 "Gabriel L. Somlo" wrote: > On Fri, Jan 10, 2014 at 05:13:11PM +0100, Igor Mammedov wrote: > > > On Fri, Jan 10, 2014 at 01:37:14PM +0100, Paolo Bonzini wrote: > > > > Il 09/01/2014 22:44, Gabriel L. Somlo ha scritto: > > > > > 1. hardcode "IRQNoFlags(){2, 8}" a

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 12:57:50PM +0100, Paolo Bonzini wrote: > Il 20/01/2014 12:58, Michael S. Tsirkin ha scritto: > > I think at this point I agree. > > > > I think the hack looking for the SMC device is safer than _OSI: OSPMs > > are known to do crazy things when they see _OSI, such as assumin

Re: [Qemu-devel] RFC: ACPI, HPET._CRS, MacOSX vs. WinXP

2014-01-20 Thread Paolo Bonzini
Il 20/01/2014 13:08, Michael S. Tsirkin ha scritto: >>> > > >>> > > I think the hack looking for the SMC device is safer than _OSI: OSPMs >>> > > are known to do crazy things when they see _OSI, such as assuming they >>> > > need to try and emulate the OS probed. >> > >> > Source? >> > >> > Paol

Re: [Qemu-devel] Exposing and calculating CPU APIC IDs (was Re: [RFC 1/3] target-i386: moving registers of vmstate from cpu_exec_init() to x86_cpu_realizefn())

2014-01-20 Thread Igor Mammedov
On Fri, 17 Jan 2014 17:13:55 -0200 Eduardo Habkost wrote: > On Wed, Jan 15, 2014 at 03:37:04PM +0100, Igor Mammedov wrote: > > On Wed, 15 Jan 2014 20:24:01 +0800 > > Chen Fan wrote: > > > On Tue, 2014-01-14 at 11:40 +0100, Igor Mammedov wrote: > > > > On Tue, 14 Jan 2014 17:27:20 +0800 > > > > C

Re: [Qemu-devel] device_add error handling regressed in v1.5.0

2014-01-20 Thread Markus Armbruster
Paolo Bonzini writes: > Il 17/01/2014 11:23, Markus Armbruster ha scritto: >> Watch this: >> >> $ upstream-qemu -nodefaults -S -display none -monitor stdio >> QEMU 1.7.50 monitor - type 'help' for more information >> (qemu) device_add e1000,netdev=xxx >> Property 'e1000.netdev' ca

Re: [Qemu-devel] [PATCH 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice

2014-01-20 Thread Igor Mammedov
On Mon, 20 Jan 2014 13:36:39 +0200 "Michael S. Tsirkin" wrote: > On Tue, Jan 14, 2014 at 05:55:54PM +0100, Igor Mammedov wrote: > > make qdev_unplug()/device_set_realized() to call hotplug handler's > > plug/unplug methods if available and remove not needed anymore > > hot(un)plug handling from P

Re: [Qemu-devel] [PATCH v2] qdev: add the device to the QOM tree before using it to set a link

2014-01-20 Thread Paolo Bonzini
Il 02/01/2014 02:02, Amos Kong ha scritto: > Test steps: > (qemu) device_add e1000,addr=adsf > Property 'e1000.addr' doesn't take value 'adsf' > (qemu) info qtree > Then qemu crashed. > > Currently we set a link to the new device for qdev parent bus, but the > device hasn't been added to QOM

Re: [Qemu-devel] [PATCH 9/9] hw/pci: switch to a generic hotplug handling for PCIDevice

2014-01-20 Thread Paolo Bonzini
Il 20/01/2014 13:45, Igor Mammedov ha scritto: > On Mon, 20 Jan 2014 13:36:39 +0200 > "Michael S. Tsirkin" wrote: > >> On Tue, Jan 14, 2014 at 05:55:54PM +0100, Igor Mammedov wrote: >>> make qdev_unplug()/device_set_realized() to call hotplug handler's >>> plug/unplug methods if available and rem

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Gerd Hoffmann
On Mo, 2014-01-20 at 13:23 +0200, Michael S. Tsirkin wrote: > On Tue, Dec 17, 2013 at 06:56:06PM +0100, Gerd Hoffmann wrote: > > > I merged your patch but split it: q35 is separate and piix > > > is separate. Would you like me to drop the q35 part then? > > > > If you are fine with q35 having only

Re: [Qemu-devel] device_add error handling regressed in v1.5.0

2014-01-20 Thread Markus Armbruster
Markus Armbruster writes: > Paolo Bonzini writes: > >> Il 17/01/2014 11:23, Markus Armbruster ha scritto: >>> Watch this: >>> >>> $ upstream-qemu -nodefaults -S -display none -monitor stdio >>> QEMU 1.7.50 monitor - type 'help' for more information >>> (qemu) device_add e1000,netdev=

Re: [Qemu-devel] [PATCH v2] qdev: add the device to the QOM tree before using it to set a link

2014-01-20 Thread Markus Armbruster
Amos Kong writes: > Test steps: > (qemu) device_add e1000,addr=adsf > Property 'e1000.addr' doesn't take value 'adsf' > (qemu) info qtree > Then qemu crashed. > > Currently we set a link to the new device for qdev parent bus, but the > device hasn't been added to QOM tree. When it fails to

[Qemu-devel] [PATCH uq/master] kvm: always update the MPX model specific register

2014-01-20 Thread Paolo Bonzini
The original patch from Liu Jinsong restricted them to reset or full state updates, but that's unnecessary (and wrong) since the BNDCFGS MSR has no side effects. Cc: Liu Jinsong Signed-off-by: Paolo Bonzini --- target-i386/kvm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH v2] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
Fix signed to unsigned comparison in qxl_create_guest_primary and add the size of the framebuffer to the error message used when setting the guest bug state (which causes a complete guess blackout until reset, so it helps if it is verbose). Signed-off-by: Alon Levy --- hw/display/qxl.c | 7 -

Re: [Qemu-devel] [PATCH v2] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Markus Armbruster
Alon Levy writes: > Fix signed to unsigned comparison in qxl_create_guest_primary and add > the size of the framebuffer to the error message used when setting the > guest bug state (which causes a complete guess blackout until reset, so > it helps if it is verbose). > > Signed-off-by: Alon Levy

Re: [Qemu-devel] [PATCH v2] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Peter Maydell
On 20 January 2014 13:29, Alon Levy wrote: > Fix signed to unsigned comparison in qxl_create_guest_primary and add > the size of the framebuffer to the error message used when setting the > guest bug state (which causes a complete guess blackout until reset, so > it helps if it is verbose). > > Si

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 01:58:45PM +0100, Gerd Hoffmann wrote: > On Mo, 2014-01-20 at 13:23 +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 17, 2013 at 06:56:06PM +0100, Gerd Hoffmann wrote: > > > > I merged your patch but split it: q35 is separate and piix > > > > is separate. Would you like me t

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Gerd Hoffmann
On Mo, 2014-01-20 at 15:59 +0200, Michael S. Tsirkin wrote: > On Mon, Jan 20, 2014 at 01:58:45PM +0100, Gerd Hoffmann wrote: > > On Mo, 2014-01-20 at 13:23 +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 17, 2013 at 06:56:06PM +0100, Gerd Hoffmann wrote: > > > > > I merged your patch but split i

[Qemu-devel] [PULL 00/29] acpi, pci, pc, virtio fixes and enhancements

2014-01-20 Thread Michael S. Tsirkin
The following changes since commit 1cf892ca2689c84960b4ce4d2723b6bee453711c: SPARC: Fix LEON3 power down instruction (2014-01-15 15:37:33 +1000) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_anthony for you to fetch changes up to ed25eb3

[Qemu-devel] [PULL 01/29] Python-lang gdb script to extract x86_64 guest vmcore from qemu coredump

2014-01-20 Thread Michael S. Tsirkin
From: Laszlo Ersek When qemu dies unexpectedly, for example in response to an explicit abort() call, or (more importantly) when an external signal is delivered to it that results in a coredump, sometimes it is useful to extract the guest vmcore from the qemu process' memory image. The guest vmcor

[Qemu-devel] [PULL 08/29] configure: add CONFIG_IASL to config-host.h

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Acpi unit-tests will extract iasl executable from CONFIG_IASL define. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- scripts/create_config | 4 1 file changed, 4 insertions(+) diff --git a/scripts/create_config b/scripts/create_config index

[Qemu-devel] [PULL 04/29] virtio: Fix return value for dummy function vhost_net_virtqueue_pending

2014-01-20 Thread Michael S. Tsirkin
From: Stefan Weil cgcc complains that -ENOSYS is not a good value for 'bool'. A dummy virtio will never have pending queue entries, so let us return false. Signed-off-by: Stefan Weil Signed-off-by: Michael S. Tsirkin --- hw/net/vhost_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-

[Qemu-devel] [PULL 03/29] ACPI: Fix AppleSMC _STA size

2014-01-20 Thread Michael S. Tsirkin
From: "Gabriel L. Somlo" Minimize the storage used for AppleSMC's _STA (8bit), relying on ASL to implicitly convert it to the officially specified 32bit value. Signed-off-by: Gabriel Somlo Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-build.c | 11 +-- hw/i386/acpi-dsdt-isa.

[Qemu-devel] [PULL 05/29] acpi unit-test: add test files

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Added unit-test's expected aml files to be compared with the actual ACPI tables. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/pc/APIC | Bin 0 -> 120 bytes tests/acpi-test-data/pc/DSDT | Bin 0 -> 4407 bytes tests/acpi-tes

[Qemu-devel] [PULL 10/29] acpi unit-test: added script to rebuild the expected aml files

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Acpi unit-test will fail every time the acpi tables change. This script rebuild the expected aml files, so the test will pass. It also validates the modifications. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- tests/acpi-test-data/rebuild-expecte

[Qemu-devel] [PULL 11/29] acpi unit-test: hook to rebuild expected aml files

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum When running the test with TEST_ACPI_REBUILD_AML=y environment variable, the test will rebuild and validate the expected aml files. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- tests/acpi-test.c | 30 +- 1 file change

[Qemu-devel] [PULL 06/29] configure: added acpi unit-test files

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Ensure configure will set-up links for the files if the build is created in other directory. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- configure | 4 1 file changed, 4 insertions(+) diff --git a/configure b/configure index 3782a6a..3266

[Qemu-devel] [PULL 09/29] acpi unit-test: extract iasl executable from configuration

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum The test checked if iasl is installed by running "iasl" and checking the error output. It is better to use the iasl executable as appears in configuration. Signed-off-by: Marcel Apfelbaum Signed-off-by: Michael S. Tsirkin --- tests/acpi-test.c | 31 -

[Qemu-devel] [PULL 13/29] acpi unit-test: renamed ssdt_tables to tables

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum Just a refactoring, ssdt_tables name was confusing as it included other tables as well. Signed-off-by: Marcel Apfelbaum Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- tests/acpi-test.c | 48 1 file

[Qemu-devel] [PULL 07/29] acpi unit-test: compare DSDT and SSDT tables against expected values

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum This test will run only if iasl is installed on the host machine. The test plan: 1. Dumps the ACPI tables as AML on the disk. 2. Runs iasl to disassembly the tables into ASL files. 3. Runs iasl to disassembly the offline AML files into ASL files. 4. Compares the ASL fil

[Qemu-devel] [PULL 12/29] tests: fix acpi to work on bigendian host

2014-01-20 Thread Michael S. Tsirkin
From: Alexey Kardashevskiy Double endianness convertion make this test failing on POWERPC machine running in big-endian. This fixes the test to success on big-endian host. Signed-off-by: Alexey Kardashevskiy Signed-off-by: Michael S. Tsirkin --- tests/acpi-test.c | 6 +++--- 1 file changed,

[Qemu-devel] [PULL 23/29] pc: set PRST base in DSDT depending on chipset

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-dsdt-cpu-hotplug.dsl | 2 +- hw/i386/acpi-dsdt.dsl | 1 + hw/i386/q35-acpi-dsdt.dsl | 1 + 3 files changed, 3 insertions(+), 1 deletion(-) d

[Qemu-devel] [PULL 24/29] pc: PIIX DSDT: exclude CPU/PCI hotplug & GPE0 IO range from PCI bus resources

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov .. so that they might not be used by PCI devices. Note: Resort to concatenating templates with preprocessor help, because 1.0b spec isn't supporting ConcatenateResTemplate, as result Windows XP fails to execute PCI0._CRS method if ConcatenateResTemplate() is used. Signed-off

[Qemu-devel] [PULL 17/29] pci: add pci_for_each_bus_depth_first

2014-01-20 Thread Michael S. Tsirkin
Useful for ACPI hotplug. Signed-off-by: Michael S. Tsirkin --- include/hw/pci/pci.h | 14 ++ hw/pci/pci.c | 28 2 files changed, 42 insertions(+) diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h index 754b82d..5252346 100644 --- a/include

[Qemu-devel] [PULL 20/29] acpi-build: enable hotplug for PCI bridges

2014-01-20 Thread Michael S. Tsirkin
This enables support for device hotplug behind pci bridges. Bridge devices themselves need to be pre-configured on qemu command line. Design: - at machine init time, assign "bsel" property to bridges with hotplug support - dynamically (At ACPI table read) generate ACPI code to handle

Re: [Qemu-devel] Assertion failure in qemu-char.c

2014-01-20 Thread Paolo Bonzini
Il 20/01/2014 13:37, Wesley Holevinski ha scritto: > > Hi all, > > I'm running into an issue that's causing my guests to crash while > using vm-channels. There is an assertion that's failing in qemu-char.c, > that, when it happens causes my guest to go down. The error can be seen > in the host-si

[Qemu-devel] [PULL 25/29] pc: Q35 DSDT: exclude CPU hotplug IO range from PCI bus resources

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov ... for range defined at hw/acpi/ich9.c:ICH9_PROC_BASE Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- hw/i386/acpi-dsdt-pci-crs.dsl | 7 --- hw/i386/acpi-dsdt.dsl | 7 +++ hw/i386/q35-acpi-dsdt.dsl |

[Qemu-devel] [PULL 27/29] pc: ACPI: unify source of CPU hotplug IO base/len

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov use C headers defines as source of IO base/len for respective values in ASL code. Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/cpu_hotplug_defs.h | 1 + hw/acpi/piix4.c| 5 ++--- hw/

[Qemu-devel] [PULL 19/29] piix4: add acpi pci hotplug support

2014-01-20 Thread Michael S. Tsirkin
Add support for acpi pci hotplug using the new infrastructure. PIIX4 legacy interface is maintained as is for machine types 1.6 and older. Signed-off-by: Michael S. Tsirkin --- include/hw/i386/pc.h | 5 hw/acpi/piix4.c | 75 +--- 2 files

Re: [Qemu-devel] [PATCH v2] x86: gigabyte alignment for ram

2014-01-20 Thread Michael S. Tsirkin
On Mon, Jan 20, 2014 at 03:01:50PM +0100, Gerd Hoffmann wrote: > On Mo, 2014-01-20 at 15:59 +0200, Michael S. Tsirkin wrote: > > On Mon, Jan 20, 2014 at 01:58:45PM +0100, Gerd Hoffmann wrote: > > > On Mo, 2014-01-20 at 13:23 +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec 17, 2013 at 06:56:06P

[Qemu-devel] [PULL 22/29] acpi: ich9: add CPU hotplug handling to Q35 machine

2014-01-20 Thread Michael S. Tsirkin
From: Igor Mammedov .. use IO port 0cd8-0xcf7 range for CPU present bitmap Signed-off-by: Igor Mammedov Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin --- include/hw/acpi/cpu_hotplug_defs.h | 1 + include/hw/acpi/ich9.h | 4 hw/acpi/ich9.c

[Qemu-devel] [PULL 14/29] acpi unit-test: resolved iasl crash

2014-01-20 Thread Michael S. Tsirkin
From: Marcel Apfelbaum It seems that iasl has an issue when disassembles some ACPI tables using the command line: iasl -e DSDT -e SSDT -d HPET Modified the iasl command line to "iasl -d HPET" until the problem is solved. The command line remained the same for DSDT and SSDT tables. Reported-by:

[Qemu-devel] [PATCH 2/3] qemu-progress: Fix progress printing on SIGUSR1

2014-01-20 Thread Kevin Wolf
Since commit a7aae221 ('Switch SIG_IPI to SIGUSR1'), SIGUSR1 is blocked during startup, breaking the progress report in tools. This patch reenables the signal when initialising a progress report. Signed-off-by: Kevin Wolf --- util/qemu-progress.c | 10 ++ 1 file changed, 10 insertions(+

[Qemu-devel] [Bug 1263318] Re: Cannot add a USB 2.0 device under QEMU when running eudev

2014-01-20 Thread Francesco Turco
I just tried with eudev-1.4, but I get the same problem as with version 1.3. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1263318 Title: Cannot add a USB 2.0 device under QEMU when running eudev

[Qemu-devel] [v19 01/25] add def_value_str to QemuOptDesc

2014-01-20 Thread Chunyan Liu
Add def_value_str (default value) to QemuOptDesc, to replace function of the default value in QEMUOptionParameter. And improved related functions. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h |3 +- util/qemu-option.c| 76 ++

[Qemu-devel] [PATCH 3/3] Documentation: qemu-img: Mention SIGUSR1 progress report

2014-01-20 Thread Kevin Wolf
Document the SIGUSR1 behaviour of qemu-img. Also, added compare to the list of subcommands that support -p. Signed-off-by: Kevin Wolf --- qemu-img.texi | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qemu-img.texi b/qemu-img.texi index 778e967..f86a86d 100644 --- a/qemu-im

[Qemu-devel] [v19 02/25] qapi: output def_value_str when query command line options

2014-01-20 Thread Chunyan Liu
Change qapi interfaces to output the newly added def_value_str when query command line options. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- qapi-schema.json |8 ++-- qmp-commands.hx|2 ++ util/qemu-config.c |4 3 files changed, 12 insertions(+), 2 delet

[Qemu-devel] [v19 03/25] improve some functions in qemu-option.c

2014-01-20 Thread Chunyan Liu
Improve opt_get and opt_set group of functions. For opt_get, check and handle NUlL input; for opt_set, when set to an existing option, rewrite the option with new value. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- util/qemu-option.c | 80

[Qemu-devel] [v19 06/25] cow.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
cow.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/cow.c | 46 ++ 1 files changed, 22 insertions(+), 24 deletions(-) diff --git a/block/cow.c b/block/cow.c index 6318228..6688a87 100644

[Qemu-devel] [v19 07/25] gluster.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
gluster.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/gluster.c | 44 ++-- 1 files changed, 22 insertions(+), 22 deletions(-) diff --git a/block/gluster.c b/block/gluster.c index 563d497..

[Qemu-devel] [PATCH v3] hw/display/qxl: fix signed to unsigned comparison

2014-01-20 Thread Alon Levy
Several small signedness / overflow corrections to qxl_create_guest_primary: 1. use 64 bit unsigned for size to avoid overflow possible from two 32 bit multiplicants. 2. correct sign for requested_height 3. add a more verbose error message when setting guest bug state (which causes a complete guess

[Qemu-devel] [v19 08/25] iscsi.c: replace QEMUOptionParamter with QemuOpts

2014-01-20 Thread Chunyan Liu
iscsi.c: replace QEMUOptionParamter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/iscsi.c | 61 - 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index c0ea0

[Qemu-devel] [v19 11/25] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options

2014-01-20 Thread Chunyan Liu
qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img amend' Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c |4 +- block/qcow2.c | 88 - include/block/block.h |2 +- include/blo

[Qemu-devel] [v19 12/25] qed.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
qed.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qed.c | 89 +-- block/qed.h |3 +- 2 files changed, 45 insertions(+), 47 deletions(-) diff --git a/block/qed.c b/block

[Qemu-devel] [v19 09/25] qcow.c: replace QEMUOptionParamter with QemuOpts

2014-01-20 Thread Chunyan Liu
qcow.c: replace QEMUOptionParamter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow.c | 61 - 1 files changed, 30 insertions(+), 31 deletions(-) diff --git a/block/qcow.c b/block/qcow.c index be2a72e..

[Qemu-devel] [v19 10/25] qcow2.c: replace QEMUOptionParameter with QemuOpts in create

2014-01-20 Thread Chunyan Liu
qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img create'. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/qcow2.c | 176 1 files changed, 88 insertions(+), 88 deletions(-) diff --git a/block/qcow2.c b/blo

[Qemu-devel] [v19 04/25] add some QemuOpts functions for replace work

2014-01-20 Thread Chunyan Liu
Add some qemu_opt functions to replace the same functionality of QEMUOptionParameter handling. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- include/qemu/option.h |7 +++ util/qemu-option.c| 131 + 2 files changed, 138 insert

[Qemu-devel] [v19 13/25] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
raw-posix.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw-posix.c | 60 1 files changed, 28 insertions(+), 32 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c

[Qemu-devel] [v19 21/25] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
raw_bsd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/raw_bsd.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/block/raw_bsd.c b/block/raw_bsd.c index 297e03f..4ae12dd 100644 --

[Qemu-devel] [v19 05/25] change block layer to support both QemuOpts and QEMUOptionParameter

2014-01-20 Thread Chunyan Liu
Change block layer to support both QemuOpts and QEMUOptionParameter. After this patch, it will change backend drivers one by one. At the end, QEMUOptionParameter will be removed and only QemuOpts is kept. Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block.c | 33

[Qemu-devel] [v19 20/25] vpc.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
vpc.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vpc.c | 52 +++- 1 files changed, 27 insertions(+), 25 deletions(-) diff --git a/block/vpc.c b/block/vpc.c index 1d326cb..f77f4a5

[Qemu-devel] [v19 18/25] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
vdi.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vdi.c | 71 -- 1 files changed, 34 insertions(+), 37 deletions(-) diff --git a/block/vdi.c b/block/vdi.c index 2d7490f..e5

[Qemu-devel] [v19 19/25] vmdk.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
vmdk.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vmdk.c | 109 + 1 files changed, 55 insertions(+), 54 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 974eaff.

Re: [Qemu-devel] [PATCH v3] target-ppc: gdbstub allow byte swapping for, reading/writing registers

2014-01-20 Thread Alexander Graf
On 17.01.2014, at 22:02, Thomas Falcon wrote: > This patch allows registers to be properly read from and written to > when using the gdbstub to debug a ppc guest running in little > endian mode. It accomplishes this goal by byte swapping the values of > any registers if the MSR:LE value is set.

[Qemu-devel] [PATCH] target-i386: enable x2apic by default on more recent CPU models

2014-01-20 Thread Eduardo Habkost
This enables x2apic on the following CPU models: Conroe, Penryn, Nehalem, Westmere, Opteron_G[12345]. Normally we try to keep the CPU model definitions as close as the real CPUs as possible, but x2apic can be emulated by KVM without host CPU support for x2apic, and it improves performance by reduc

[Qemu-devel] [v19 22/25] vhdx.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
vhdx.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vhdx.c | 93 +++-- block/vhdx.h |1 + 2 files changed, 45 insertions(+), 49 deletions(-) diff --git a/block/vhdx.c b/bloc

Re: [Qemu-devel] [PATCH] target-ppc: ppc64 target's virtio can be either endian. (v3)

2014-01-20 Thread Alexander Graf
On 17.01.2014, at 14:52, Greg Kurz wrote: > We base it on the OS endian, as reflected by the endianness of the > interrupt vectors (handled through the ILE bit in the LPCR register). > > This patch implements virtio_get_byteswap() over LPCR. > > Using first_cpu to fetch the registers from KVM

[Qemu-devel] [v19 23/25] vvfat.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
vvfat.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/vvfat.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index c59cbdb..81733bc 100644 --- a/block/vvfat.c +++ b/blo

[Qemu-devel] [v19 15/25] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-01-20 Thread Chunyan Liu
rbd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang Signed-off-by: Chunyan Liu --- block/rbd.c | 63 +-- 1 files changed, 31 insertions(+), 32 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index f453f04..6

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-20 Thread Peter Maydell
On 20 January 2014 14:20, Alexander Graf wrote: > I think I see the problem now. You're thinking about LE hosts, not LE guests. > > I think the only really sensible options would be to > > a) Always use a statically define target endianness (big for ppc) > b) Always use host endianness > Curr

Re: [Qemu-devel] [PATCH] spapr: fix H_SET_MODE to sync LPCR with KVM

2014-01-20 Thread Alexander Graf
On 17.01.2014, at 07:13, Alexey Kardashevskiy wrote: > The kvm_cpu_exec() only puts registers to KVM if the @kvm_vcpu_dirty flag > has been set. > > This adds registers sync which also sets @kvm_vcpu_dirty so we store new > LPCR to KVM before continuing with the KVM_RUN ioctl. > > Signed-off-b

Re: [Qemu-devel] [PATCH v2 0/4] X86/KVM: enable Intel MPX for KVM

2014-01-20 Thread Paolo Bonzini
Il 12/12/2013 12:09, Liu, Jinsong ha scritto: > Paolo Bonzini wrote: >> Il 12/12/2013 06:47, Liu, Jinsong ha scritto: >>> Paolo Bonzini wrote: Il 11/12/2013 09:31, Liu, Jinsong ha scritto: > Paolo, comments for version 2? I think I commented that it's fine, I'm just waiting for a

[Qemu-devel] [PULL 0/8] KVM uq/master changes for 2014-01-20

2014-01-20 Thread Paolo Bonzini
Anthony, the following changes since commit 6747f6456fd1e5e986b6385ff5d706c79ebd8a32: Merge remote-tracking branch 'rth/tcg-temp-order' into staging (2013-12-10 16:14:36 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git uq/master for you to

[Qemu-devel] [PULL 1/9] target-i386: Intel MPX

2014-01-20 Thread Paolo Bonzini
From: Liu Jinsong Add some MPX related definiation, and hardcode sizes and offsets of xsave features 3 and 4. It also add corresponding part to kvm_get/put_xsave, and vmstate. Signed-off-by: Liu Jinsong Signed-off-by: Paolo Bonzini --- target-i386/cpu.c | 4 target-i386/cpu.h |

Re: [Qemu-devel] KVM and variable-endianness guest CPUs

2014-01-20 Thread Alexander Graf
On 18.01.2014, at 11:15, Peter Maydell wrote: > On 18 January 2014 07:32, Alexander Graf wrote: >>> Am 18.01.2014 um 05:24 schrieb Christoffer Dall >>> : On Fri, Jan 17, 2014 at 06:52:57PM +, Peter Maydell wrote: Having thought a little more about this, my opinion is:

[Qemu-devel] [PULL 2/9] target-i386: do not special case TSC writeback

2014-01-20 Thread Paolo Bonzini
From: Fernando Luis Vázquez Cao Newer kernels are capable of synchronizing TSC values of multiple VCPUs on writeback, but we were excluding the power up case, which is not needed anymore. Signed-off-by: Fernando Luis Vazquez Cao Signed-off-by: Paolo Bonzini Signed-off-by: Fernando Luis Vázque

[Qemu-devel] [PULL 8/9] KVM: fix addr type for KVM_IOEVENTFD

2014-01-20 Thread Paolo Bonzini
From: Alexey Kardashevskiy The @addr here is a guest physical address and can easily be bigger than 4G. This changes uint32_t to hwaddr. Cc: qemu-sta...@nongnu.org Cc: Michael S. Tsirkin Signed-off-by: Alexey Kardashevskiy Signed-off-by: Paolo Bonzini --- kvm-all.c | 2 +- 1 file changed, 1

[Qemu-devel] [PULL 7/9] KVM: Retry KVM_CREATE_VM on EINTR

2014-01-20 Thread Paolo Bonzini
From: thomas knych Upstreaming this change from Android (https://android-review.googlesource.com/54211). On heavily loaded machines with many VM instances we see KVM_CREATE_VM failing with EINTR on this path: kvm_dev_ioctl_create_vm -> kvm_create_vm -> kvm_init_mmu_notifier -> mmu_notifier_re

Re: [Qemu-devel] [PATCH] spapr: reset @kvm_vcpu_dirty before starting CPU

2014-01-20 Thread Alexander Graf
On 15.01.2014, at 05:57, Alexey Kardashevskiy wrote: > Normally QEMU kvm_arch_get_registers() reads registers and sets a dirty > flag which prevents further registers reading from KVM till > kvm_arch_put_registers() executes and resets the flag. > > However if we run QEMU with "-S" ("suspended"

[Qemu-devel] [PULL 5/9] kvm: x86: Separately write feature control MSR on reset

2014-01-20 Thread Paolo Bonzini
From: Jan Kiszka If the guest is running in nested mode on system reset, clearing the feature MSR signals the kernel to leave this mode. Recent kernels processes this properly, but leave the VCPU state undefined behind. It is the job of userspace to bring it to a proper shape. Therefore, write th

  1   2   3   >