[Qemu-devel] [PATCH v20 24/26] vvfat.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vvfat.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vvfat.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index

[Qemu-devel] [PATCH v20 14/26] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
raw-posix.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/raw-posix.c | 58 1 files changed, 27 insertions(+), 31 deletions(-) diff

[Qemu-devel] [PATCH v10 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Qiao Nuohan
'query-dump-guest-memory-capability' is used to query the available formats for 'dump-guest-memory'. The output of the command will be like: - { execute: query-dump-guest-memory-capability } - { return: { formats: [elf, kdump-zlib, kdump-lzo, kdump-snappy] } Signed-off-by:

[Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
qed.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/qed.c | 89 +-- block/qed.h |3 +- 2 files changed, 45 insertions(+), 47

[Qemu-devel] [PATCH v20 17/26] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
rbd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/rbd.c | 63 +-- 1 files changed, 31 insertions(+), 32 deletions(-) diff --git

[Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
ssh.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/ssh.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/block/ssh.c b/block/ssh.c

[Qemu-devel] [PATCH v20 16/26] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
raw_bsd.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/raw_bsd.c | 27 --- 1 files changed, 16 insertions(+), 11 deletions(-) diff --git a/block/raw_bsd.c

[Qemu-devel] [PATCH v20 21/26] vmdk.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vmdk.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vmdk.c | 109 + 1 files changed, 55 insertions(+), 54 deletions(-) diff --git

[Qemu-devel] [PATCH v20 22/26] vpc.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vpc.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vpc.c | 52 +++- 1 files changed, 27 insertions(+), 25 deletions(-) diff --git

[Qemu-devel] [PATCH v20 20/26] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
vdi.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/vdi.c | 71 -- 1 files changed, 34 insertions(+), 37 deletions(-) diff --git

[Qemu-devel] [PATCH v20 18/26] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
sheepdog.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/sheepdog.c | 101 +- 1 files changed, 47 insertions(+), 54 deletions(-) diff

[Qemu-devel] [PATCH v20 25/26] cleanup QEMUOptionParameter

2014-02-11 Thread Chunyan Liu
Now all places using QEMUOptionParameter could use QemuOpts too, remove QEMUOptionParameter related code. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block.c | 57 ++- block/cow.c |2 +-

[Qemu-devel] [PATCH v20 26/26] change back to original name from bdrv_create2 to bdrv_create

2014-02-11 Thread Chunyan Liu
Rename the new driver callback bdrv_create2 to the old name bdrv_create. Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block.c |4 ++-- block/cow.c |2 +- block/gluster.c |8

[Qemu-devel] [PATCH v20 07/26] cow.c: replace QEMUOptionParameter with QemuOpts

2014-02-11 Thread Chunyan Liu
cow.c: replace QEMUOptionParameter with QemuOpts Signed-off-by: Dong Xu Wang wdon...@linux.vnet.ibm.com Signed-off-by: Chunyan Liu cy...@suse.com --- block/cow.c | 46 ++ 1 files changed, 22 insertions(+), 24 deletions(-) diff --git a/block/cow.c

Re: [Qemu-devel] Ping for patch linux-user: add binfmt wrapper for argv[0] handling

2014-02-11 Thread Alexander Graf
On 12.02.2014, at 03:30, Dennis Lan (dlan) dennis.y...@gmail.com wrote: Hi Folks: Any chance to get this patch accepted into master branch? I found it useful when chroot into another system. Origianl post can be found here[1], would be quite easy to forward port to latest code. [1]

Re: [Qemu-devel] [Qemu-ppc] PowerPC Decimal Floating Point

2014-02-11 Thread Alexander Graf
On 11.02.2014, at 18:14, Tom Musta tommu...@gmail.com wrote: QEMU is currently lacking support for the Decimal Floating Point category of instructions (see Power ISA V2.07 Chapter 6). I intend to add this support. Has this topic been investigated before and if so can anyone point me to

[Qemu-devel] PC value translation from guest VA to host VA.

2014-02-11 Thread Gaurav Sharma
Can anyone point it out to me where is the pc value translated from guest virtual address to host virtual address ? Thanks, Gaurav

Re: [Qemu-devel] [PATCH] virtio-net: remove function calls from assert

2014-02-11 Thread Joel Stanley
On Tue, Feb 11, 2014 at 3:40 PM, Michael S. Tsirkin m...@redhat.com wrote: Just to clarify, I applied this because code looks nicer this way. We don't support build with NDEBUG - a whole bunch of stuff will break if you do. I tweaked the commit log to make this clear. Ok. Thanks for

Re: [Qemu-devel] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Eduardo Habkost
On Mon, Feb 10, 2014 at 11:39:51PM +0100, Andreas Färber wrote: Am 10.02.2014 11:21, schrieb Eduardo Habkost: +static const TypeInfo x86_cpu_host_type_info = { +.name = CPU_CLASS_NAME(host), +.parent = TYPE_X86_CPU, +.instance_size = sizeof(X86CPU), +.instance_init =

Re: [Qemu-devel] [qom-cpu PATCH 7/7 v9] target-i386: CPU model subclasses

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 23:39, Andreas Färber ha scritto: I'd rather finish my investigations and discuss my v10 patches but Paolo is already asking whether Eduardo should send a PULL, so here's my textual reply informing of some thoughts and WIP. ;) Don't worry, :) I was asking you if you are fine with

Re: [Qemu-devel] [FIX V2] block: Fix device snapshots broken by the block filter snapshots patchset.

2014-02-11 Thread Fam Zheng
On Mon, 02/10 22:49, Benoît Canet wrote: Take into account the fact that a block filter like quorum will be in bs-file while a regular block driver device is really on the top level. Signed-off-by: Benoit Canet ben...@irqsave.net --- block.c | 14 -- 1 file changed, 8

Re: [Qemu-devel] question about patch send the gratuitous by guest

2014-02-11 Thread Jason Wang
On 02/11/2014 03:43 PM, Huangweidong (C) wrote: Hi, I found the network was broken after migrating the vm, the same as you said in Send the gratuitous by guest.The vm modify the mac of network card.IN the scenario with vlan the network was broken too. The guest driver of virtio-net in

Re: [Qemu-devel] [PATCH] Use error_is_set() only when necessary

2014-02-11 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Mon, 02/10 15:54, Luiz Capitulino wrote: @@ -875,13 +875,13 @@ DriveInfo *drive_init(QemuOpts *all_opts, BlockInterfaceType block_default_type) /* Actual block device init: Functionality shared with blockdev-add */ dinfo =

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: On 02/10/2014 02:16 PM, Luiz Capitulino wrote: On Sat, 1 Feb 2014 12:52:42 +0100 Martin Kletzander mklet...@redhat.com wrote: Introduce 'query-chardev-backends' QMP command which lists all supported character device backends. Signed-off-by: Martin

Re: [Qemu-devel] [PATCH v2 0/2] qapi: Allow modularization of QAPI schema files

2014-02-11 Thread Markus Armbruster
Lluís Vilanova vilan...@ac.upc.edu writes: Adds the include(...) primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- Changes in v2: * Change the scripts to use an

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Kevin Wolf
Am 11.02.2014 um 02:39 hat Fam Zheng geschrieben: On Wed, 01/29 12:17, Stefan Hajnoczi wrote: qmp-shell hides the QMP wire protocol JSON encoding from the user. Most of the time this is helpful and makes the command-line human-friendly. Some QMP commands take a dict as an argument. In

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Markus Armbruster
Fam Zheng f...@redhat.com writes: On Wed, 01/29 12:17, Stefan Hajnoczi wrote: qmp-shell hides the QMP wire protocol JSON encoding from the user. Most of the time this is helpful and makes the command-line human-friendly. Some QMP commands take a dict as an argument. In order to express

[Qemu-devel] [PATCH 1/6] target-xtensa: add RRRI4 opcode format fields

2014-02-11 Thread Max Filippov
This encoding is used by cache instructions. Signed-off-by: Max Filippov jcmvb...@gmail.com --- target-xtensa/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-xtensa/translate.c b/target-xtensa/translate.c index dc5e78f..b0b7fa0 100644 ---

[Qemu-devel] [PATCH 2/6] target-xtensa: add basic checks to dcache opcodes

2014-02-11 Thread Max Filippov
Check privilege level for privileged instructions (DHI, DHU, DII, DIU, DIWB, DIWBI, DPFL are privileged), memory accessibility for instructions that reference memory (all DH* and DPFL) and windowed register validity for all data cache instructions. Signed-off-by: Max Filippov jcmvb...@gmail.com

[Qemu-devel] [PATCH 0/6] target-xtensa: add basic checks to cache opcodes

2014-02-11 Thread Max Filippov
Hello, this series adds basic checks (privilege level, address validity, windowed register validation) to all cache opcodes. This improves emulation quality and allows to debug cache-related issues that happen on real hardware. Max Filippov (6): target-xtensa: add RRRI4 opcode format fields

[Qemu-devel] [PATCH 4/6] target-xtensa: add overridable test_init macro

2014-02-11 Thread Max Filippov
Some test suites, like MMU, need per-test initialization. Don't make them redefine test macro, add test_init for that purpose. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tests/tcg/xtensa/macros.inc | 4 tests/tcg/xtensa/test_mmu.S | 4 ++-- 2 files changed, 6 insertions(+), 2

[Qemu-devel] [PATCH 3/6] target-xtensa: add basic checks to icache opcodes

2014-02-11 Thread Max Filippov
Check privilege level for privileged instructions (IHU, III, IIU and IPFL are privileged), memory accessibility for instructions that reference memory (IH* and IPFL) and windowed register validity for all instruction cache instructions. Signed-off-by: Max Filippov jcmvb...@gmail.com ---

[Qemu-devel] [PATCH 5/6] target-xtensa: allow using core configuration in tests

2014-02-11 Thread Max Filippov
Add path to the core configuration directory to test build command and replace .include asm directive with #include to enable preprocessing. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tests/tcg/xtensa/Makefile | 11 +++ tests/tcg/xtensa/macros.inc | 2 ++

[Qemu-devel] [PATCH 6/6] target-xtensa: add basic tests for cache opcodes

2014-02-11 Thread Max Filippov
Test that non-locking prefetch operations don't cause exceptions on missing TLB and that other 'hit' cache operations do. Signed-off-by: Max Filippov jcmvb...@gmail.com --- tests/tcg/xtensa/Makefile | 1 + tests/tcg/xtensa/test_cache.S | 97 +++ 2

Re: [Qemu-devel] [PATCH v5 RESEND 2/4] raw, qcow2: don't convert file size to sector size

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: and avoid convert it back later. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c | 8 block/raw-posix.c | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index

Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: This patch prepares for the subsequent patches. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 12 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/block/qcow2.c

Re: [Qemu-devel] [PATCH v2 19/35] target-arm: A64: Make cache ID registers visible to AArch64

2014-02-11 Thread Hu Tao
On Fri, Feb 07, 2014 at 10:27:35AM +, Peter Maydell wrote: On 7 February 2014 07:35, Hu Tao hu...@cn.fujitsu.com wrote: On Fri, Jan 31, 2014 at 03:45:27PM +, Peter Maydell wrote: Make the cache ID system registers (CLIDR, CCSELR, CCSIDR, CTR) s/CCSELR/CSSELR/ visible to

Re: [Qemu-devel] [PATCH v5 RESEND 3/4] raw-posix: Add full image preallocation option

2014-02-11 Thread Fam Zheng
On Tue, 02/11 15:07, Hu Tao wrote: This patch adds a new option preallocation for raw format, and implements full preallocation. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/raw-posix.c | 43 +++ 1 file changed, 35 insertions(+), 8

Re: [Qemu-devel] [PATCH v2 00/35] AArch64 system mode: system register rework

2014-02-11 Thread Peter Maydell
On 11 February 2014 06:11, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Im finished with my review of this one, all outstanding comments/queries are addressed so for any patches w/o my RB already: acked-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Thanks. I'll put some of the

Re: [Qemu-devel] [PATCH v8 03/13] dump: add API to write header of flatten format

2014-02-11 Thread Markus Armbruster
Laszlo Ersek ler...@redhat.com writes: On 02/10/14 23:48, Luiz Capitulino wrote: On Mon, 10 Feb 2014 22:57:15 +0100 Laszlo Ersek ler...@redhat.com wrote: In short, -Werror and bisection don't mix. They already don't, and we shouldn't expect them to. I understand what you're saying, and I

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 14:29, Markus Armbruster ha scritto: Markus Armbruster arm...@redhat.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 06/02/2014 15:30, Markus Armbruster ha scritto: Visitors get passed a pointer to the visited object. The generated visitors try to cope with this

Re: [Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts

2014-02-11 Thread Paolo Bonzini
Il 10/02/2014 17:12, Laszlo Ersek ha scritto: I'd checked every piece of output I'd found, but hadn't found the query-command-line-options; I think you're right there are no other \n's in there - but also all the other .help texts are much briefer and less chatty; maybe I need to just chop

Re: [Qemu-devel] [PATCH 02/16] target-i386: cleanup 'foo=val' feature handling

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:42PM +0100, Igor Mammedov wrote: features family, model, stepping, level, hv_spinlocks are treated similarly when passed from command line, so it's not necessary to handle each of them individually. Collapse them to one catch-all branch which will treat any not

Re: [Qemu-devel] [PATCH 03/16] target-i386: cpu: convert 'level' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:43PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH 04/16] target-i386: cpu: convert 'xlevel' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:44PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Fam Zheng
On Tue, 02/11 09:41, Kevin Wolf wrote: Am 11.02.2014 um 02:39 hat Fam Zheng geschrieben: On Wed, 01/29 12:17, Stefan Hajnoczi wrote: qmp-shell hides the QMP wire protocol JSON encoding from the user. Most of the time this is helpful and makes the command-line human-friendly. Some

Re: [Qemu-devel] [PATCH 05/16] target-i386: cpu: convert 'family' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:45PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com --- Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH] QMP: allow JSON dict arguments in qmp-shell

2014-02-11 Thread Fam Zheng
On Tue, 02/11 09:43, Markus Armbruster wrote: Fam Zheng f...@redhat.com writes: On Wed, 01/29 12:17, Stefan Hajnoczi wrote: qmp-shell hides the QMP wire protocol JSON encoding from the user. Most of the time this is helpful and makes the command-line human-friendly. Some QMP

Re: [Qemu-devel] [PATCH 07/16] target-i386: cpu: convert 'stepping' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:47PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Dr. David Alan Gilbert
* Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: This was guarding against a full fifo rather than an empty fifo when popping. Fix. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Reviewed-by: Dr. David Alan Gilbert dgilb...@redhat.com I think this brings it back

Re: [Qemu-devel] Looking for project ideas and mentors for Google Summer of Code 2014

2014-02-11 Thread Stefan Hajnoczi
On Mon, Feb 3, 2014 at 8:45 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Project ideas Please post project ideas on the wiki page below. Project ideas should be suitable as a 12-week project that a student fluent in C/Python/etc can complete. No prior knowledge of QEMU/KVM/libvirt

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Martin Kletzander
On Mon, Feb 10, 2014 at 10:49:35PM -0800, Peter Crosthwaite wrote: This was guarding against a full fifo rather than an empty fifo when popping. Fix. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Reviewed-by: Martin Kletzander mklet...@redhat.com With this patch qemu

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptyness check

2014-02-11 Thread Michael Tokarev
11.02.2014 10:49, Peter Crosthwaite wrote: This was guarding against a full fifo rather than an empty fifo when popping. Fix. I've applied this to qemu-trivial for now, if no one will pick it up before the next -trivial pull, -- because the original change were merged using -trivial too. I

Re: [Qemu-devel] [Qemu-trivial] [PATCH] net: Include iov.h in checksum.h

2014-02-11 Thread Michael Tokarev
10.02.2014 14:20, Stefan Hajnoczi пишет: On Fri, Feb 07, 2014 at 08:54:00AM +0100, Alexander Graf wrote: Am 07.02.2014 um 08:05 schrieb Michael Tokarev m...@tls.msk.ru: 06.02.2014 19:30, Alexander Graf wrote: The checksum calculation header exports a function that refers to struct iov

Re: [Qemu-devel] [PATCH v3 2/5] qtest: Add scripts/qtest/qtest.py

2014-02-11 Thread Benoît Canet
The Tuesday 11 Feb 2014 à 14:40:59 (+0800), Fam Zheng wrote : This removes the dummy scripts/qtest and adds scripts/qtest/qtest.py as a python library for qtest protocol. This is a skeleton with a basic cmd method to execute a command, reading and parsing of qtest output will be added later

Re: [Qemu-devel] [PATCH v3 5/5] qemu-iotests: Add 080 for IO throttling

2014-02-11 Thread Benoît Canet
The Tuesday 11 Feb 2014 à 14:41:02 (+0800), Fam Zheng wrote : This case utilizes qemu-io command aio_{read,write} -q to verify the effectiveness of IO throttling options. It's implemented by driving the vm timer from qtest protocol, so the throttling timers are signaled with determined time

[Qemu-devel] [PATCH] QMP: allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Fam Zheng
As another convinience to allow using commands that expect a dict as argument, this patch adds support for foo.bar=value syntax, similar to command line argument style: (QEMU) blockdev-add options.driver=file options.id=drive1 options.filename=... Signed-off-by: Fam Zheng f...@redhat.com --

Re: [Qemu-devel] [PATCH v2 07/10] target-mips: kvm: Add main KVM support for MIPS

2014-02-11 Thread James Hogan
Hi Andreas, On 10/02/14 14:07, Andreas Färber wrote: +#define dprintf(fmt, ...) \ dprintf is the name of a stdio.h function, so DPRINTF may be a better name. Okay. +int kvm_arch_init_vcpu(CPUState *env) Please use env only for CPUMIPSState, use cpu or cs here. The usual convention is

Re: [Qemu-devel] [PATCH v3 3/5] qemu-iotests: Add VM method qtest() to iotests.py

2014-02-11 Thread Benoît Canet
The Tuesday 11 Feb 2014 à 14:41:00 (+0800), Fam Zheng wrote : This will allow test case to run command in qtest protocol. It's write-only for now. Signed-off-by: Fam Zheng f...@redhat.com --- tests/qemu-iotests/iotests.py | 17 +++-- 1 file changed, 15 insertions(+), 2

Re: [Qemu-devel] [PATCH 06/16] target-i386: cpu: convert 'model' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:46PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH 08/16] target-i386: cpu: convert 'vendor' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:48PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH 09/16] target-i386: cpu: convert 'model-id' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:49PM +0100, Igor Mammedov wrote: * check if (model_id == NULL) looks unnecessary now, since all builtin model-ids are not NULL and user shouldn't be able to set it NULL (cpumodel string parsing code takes care of it, if feature is specified as model-id= on command

Re: [Qemu-devel] [PATCH 10/16] target-i386: cpu: convert 'tsc-frequency' to static property

2014-02-11 Thread Eduardo Habkost
On Wed, Nov 27, 2013 at 11:28:50PM +0100, Igor Mammedov wrote: Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Eduardo Habkost ehabk...@redhat.com -- Eduardo

Re: [Qemu-devel] [PATCH 2/5] introduce two marcos to dump the options info

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: We will use the marocs to generate two tables, which contain the option name and argument information. Signed-off-by: Amos Kong ak...@redhat.com --- qemu-options-wrapper.h | 18 ++ 1 file changed, 18 insertions(+) diff --git

Re: [Qemu-devel] [PATCH 1/2] QemuOpts: introduce qemu_find_opts_singleton

2014-02-11 Thread Igor Mammedov
On Mon, 10 Feb 2014 18:00:39 +0100 Laszlo Ersek ler...@redhat.com wrote: comments below On 02/06/14 09:16, Igor Mammedov wrote: From: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Igor Mammedov imamm...@redhat.com ---

Re: [Qemu-devel] CPU models and feature probing (was Re: [PATCH qom-cpu 00/16 v10] target-i386: convert CPU) features into properties

2014-02-11 Thread Eduardo Habkost
On Fri, Feb 07, 2014 at 11:55:25AM +0100, Paolo Bonzini wrote: Il 07/02/2014 11:16, Eduardo Habkost ha scritto: You are not alone. I remember we spent lots of time trying to convince Anthony to allow global properties and compat_props affect dynamic properties not just static properties, and

Re: [Qemu-devel] [PULL 00/29] target-arm queue

2014-02-11 Thread Peter Maydell
On 8 February 2014 15:57, Peter Maydell peter.mayd...@linaro.org wrote: Pull request for the target-arm queue... thanks -- PMM The following changes since commit 3ea3bd62451ac79478b440ad9fe2a4cd69783a1f: Merge remote-tracking branch 'remotes/juanquintela/tags/migration/20140204-1' into

Re: [Qemu-devel] [PATCH 3/5] query-command-line-options: query all the options in qemu-options.hx

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: vm_config_groups[] contain the options which have parameter, but some legcy options haven't been added to vm_config_groups[]. All the options can be found in qemu-options.hx, this patch used two new marcos to generate two tables, we can check if the option

Re: [Qemu-devel] [PATCH 4/5] introduce QEMU_OPTIONS_GENERATE_HELPMSG

2014-02-11 Thread Markus Armbruster
Amos Kong ak...@redhat.com writes: This patch introduced a new maroc, it will be used to dump the help messages of all the options. macro. Also misspelled in PATCH 2/5.

Re: [Qemu-devel] [PATCH v3 0/3] spapr: fix H_SET_MODE

2014-02-11 Thread Alexander Graf
On 02/11/2014 08:44 AM, Alexey Kardashevskiy wrote: On 01/22/2014 04:43 PM, Alexey Kardashevskiy wrote: This fixes H_SET_MODE. Alexey Kardashevskiy (3): target-ppc: introduce powerisa-207-server flag spapr-hcall: fix little-endian resource handling in H_SET_MODE spapr-hcall: add

Re: [Qemu-devel] [PATCH v3 0/3] spapr: fix H_SET_MODE

2014-02-11 Thread Alexey Kardashevskiy
On 02/11/2014 11:12 PM, Alexander Graf wrote: On 02/11/2014 08:44 AM, Alexey Kardashevskiy wrote: On 01/22/2014 04:43 PM, Alexey Kardashevskiy wrote: This fixes H_SET_MODE. Alexey Kardashevskiy (3): target-ppc: introduce powerisa-207-server flag spapr-hcall: fix little-endian resource

Re: [Qemu-devel] [PATCH 5/5] query-command-line-options: return help message for legacy options

2014-02-11 Thread Markus Armbruster
[Note cc: Eric] Amos Kong ak...@redhat.com writes: Some legacy options that have arguments weren't added to vm_config_groups[], so query-command-line-options returns a NULL parameters infolist. This patch try to return help message for this kind of legacy options. Example: {

[Qemu-devel] [PATCH] memory: fix warning during make

2014-02-11 Thread Gonglei (Arei)
Hi From 3e8c08565cc546b79d720b92e4a46470a57086bc Mon Sep 17 00:00:00 2001 From: Gonglei arei.gong...@huawei.com Date: Tue, 11 Feb 2014 06:32:45 -0500 Subject: [PATCH] memory: fix warning during make fix warning during make include/exec/ram_addr.h:66: warning: implicit declaration of function

Re: [Qemu-devel] [PATCH 10/10] qapi: Clean up null checking in generated visitors

2014-02-11 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: Il 10/02/2014 14:29, Markus Armbruster ha scritto: Markus Armbruster arm...@redhat.com writes: Paolo Bonzini pbonz...@redhat.com writes: Il 06/02/2014 15:30, Markus Armbruster ha scritto: Visitors get passed a pointer to the visited object. The

Re: [Qemu-devel] [PATCH] vnc: Fix qemu crashed when vnc client disconnect suddenly

2014-02-11 Thread Gonglei (Arei)
ping Best regards, -Gonglei -Original Message- From: Gonglei (Arei) Sent: Thursday, January 23, 2014 9:31 PM To: qemu-devel@nongnu.org Cc: 'aligu...@amazon.com'; Luonengjun; Huangweidong (Hardware); 'Gerd Hoffmann' Subject: [PATCH] vnc: Fix qemu crashed when vnc client

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk

2014-02-11 Thread Alex Bennée
Dr. David Alan Gilbert dgilb...@redhat.com writes: * Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: This was guarding against a full fifo rather than an empty fifo when popping. Fix. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PATCH bugfix v1 1/1] char/serial: Fix emptynesscheckk

2014-02-11 Thread Dr. David Alan Gilbert
* Alex Benn?e (alex.ben...@linaro.org) wrote: Dr. David Alan Gilbert dgilb...@redhat.com writes: * Peter Crosthwaite (peter.crosthwa...@xilinx.com) wrote: This was guarding against a full fifo rather than an empty fifo when popping. Fix. Signed-off-by: Peter Crosthwaite

[Qemu-devel] QEMU 2.0 release schedule proposal

2014-02-11 Thread Stefan Hajnoczi
It's time to agree on the QEMU 2.0 release schedule so we can make a release within the next 2-3 months. The following proposal is the output of IRC discussion. Juan figured out the dates and got feedback from several of us. Speak up if you have concerns about the dates. Anthony: Please

[Qemu-devel] [PATCH v3 2/3] qapi: Add a primitive to include other files from a QAPI schema file

2014-02-11 Thread Lluís Vilanova
Adds the include(...) primitive to the syntax of QAPI schema files. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- docs/qapi-code-gen.txt |8 scripts/qapi.py| 36 ++-- 2 files changed, 42 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v3 3/3] qapi: Add tests for the include directive

2014-02-11 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- tests/Makefile|3 ++- tests/qapi-schema/include-cycle.err |1 + tests/qapi-schema/include-cycle.exit |1 + tests/qapi-schema/include-cycle.json |1 +

[Qemu-devel] [PATCH v3 0/3] qapi: Allow modularization of QAPI schema files

2014-02-11 Thread Lluís Vilanova
Adds the include(...) primitive to the syntax of QAPI schema files, allowing these to be modularized into multiple per-topic files in the future. Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- Changes in v3: * Fix documentation examples regarding how the input file is passed to the

[Qemu-devel] [PATCH v3 1/3] qapi: Use an explicit input file

2014-02-11 Thread Lluís Vilanova
Use an explicit input file on the command-line instead of reading from standard input Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu --- Makefile | 24 ++-- docs/qapi-code-gen.txt|4 ++--

[Qemu-devel] [PATCH 07/16] slirp: Factorizing address translation

2014-02-11 Thread Samuel Thibault
This patch factorizes some duplicate code into a new function, sotranslate_out(). This function perform the address translation when a packet is transmitted to the host network. If the paquet is destinated to the host, the loopback address is used, and if the paquet is destinated to the virtual

[Qemu-devel] [PATCH 03/16] qemu/timer.h : Adding function to second scale

2014-02-11 Thread Samuel Thibault
This patch adds SCALE_S, timer_new_s(), and qemu_clock_get_s in qemu/timer.h to manage second-scale timers. Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org --- include/qemu/timer.h | 32 1 file

[Qemu-devel] [PATCH 04/16] slirp: Adding IPv6, ICMPv6 Echo and NDP autoconfiguration

2014-02-11 Thread Samuel Thibault
This patch adds the functions needed to handle IPv6 packets. ICMPv6 and NDP headers are implemented. Slirp is now able to send NDP Router or Neighbor Advertisement when it receives Router or Neighbor Solicitation. Using a 64bit-sized IPv6 prefix, the guest is now able to perform stateless

[Qemu-devel] [PATCH 02/16] slirp: Generalizing and neutralizing code before adding IPv6 stuff

2014-02-11 Thread Samuel Thibault
Basically, this patch replaces arp by resolution every time arp means mac resolution and not specifically ARP. Some indentation problems are solved in functions that will be modified in the next patches (ip_input…). In if_encap, a switch is added to prepare for the IPv6 case. Some code is

[Qemu-devel] [PATCH 05/16] slirp: Adding ICMPv6 error sending

2014-02-11 Thread Samuel Thibault
Disambiguation : icmp_error is renamed into icmp_send_error, since it doesn't manage errors, but only sends ICMP Error messages. Adding icmp6_send_error to send ICMPv6 Error messages. This function is simpler than the v4 version. Adding some calls in various functions to send ICMP errors, when a

[Qemu-devel] [PATCHv3 00/16] slirp: Adding IPv6 support to Qemu -net user mode

2014-02-11 Thread Samuel Thibault
Hello, This is a respin of IPv6 in Qemu -net user mode. These patches add ICMPv6, NDP, and make UDP and TCP compatible with IPv6. We have made some refactoring to make current code compatible with IPv6. Some patches, like 2 and 13, can be reviewed using interdiff -w /dev/null patchfile to get

[Qemu-devel] [PATCH 11/16] slirp: Adding family argument to tcp_fconnect()

2014-02-11 Thread Samuel Thibault
This patch simply adds a sa_family_t argument to remove the hardcoded AF_INET in the call of qemu_socket(). Signed-off-by: Guillaume Subiron maet...@subiron.org --- slirp/slirp.h | 2 +- slirp/tcp_input.c | 3 ++- slirp/tcp_subr.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-)

[Qemu-devel] [PATCH 14/16] slirp: Handle IPv6 in TCP functions

2014-02-11 Thread Samuel Thibault
This patch adds IPv6 case in TCP functions refactored by the last patches. This also adds IPv6 pseudo-header in tcpiphdr structure. Finally, tcp_input() is called by ip6_input(). Signed-off-by: Guillaume Subiron maet...@subiron.org Signed-off-by: Samuel Thibault samuel.thiba...@ens-lyon.org ---

Re: [Qemu-devel] [PATCH v3] qmp: expose list of supported character device backends

2014-02-11 Thread Eric Blake
On 02/11/2014 01:32 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: Hmm, right now, the ChardevBackend union pre-dates when we added flat unions. For flat unions, we can set a discriminator to be an enum type [1], at which point the code generator then validates that we

[Qemu-devel] [PATCH 08/16] slirp: Factorizing and cleaning solookup()

2014-02-11 Thread Samuel Thibault
This patch makes solookup() compatible with all address family. Also, this function was only compatible with TCP. Having the socket list in argument, it is now compatible with UDP too. Finally, some optimization code is factorized inside the function (the function look at the last returned result

[Qemu-devel] [PATCH 13/16] slirp: Generalizing and neutralizing various TCP functions before adding IPv6 stuff

2014-02-11 Thread Samuel Thibault
Basically, this patch adds some switch in various TCP functions to prepare them for the IPv6 case. To have something to switch in tcp_input() and tcp_respond(), a new argument is used to give them the sa_family of the addresses they are working on. Signed-off-by: Guillaume Subiron

Re: [Qemu-devel] [PATCH V6 00/10] qapi script: support enum as discriminator and better enum name

2014-02-11 Thread Eric Blake
On 02/10/2014 02:48 PM, Wenchao Xia wrote: This series address two issues: 1. support using enum as discriminator in union. For example, if we have following define in qapi schema: { 'enum': 'EnumOne', 'data': [ 'value1', 'value2', 'value3' ] } { 'type': 'UserDefBase0', 'data': {

Re: [Qemu-devel] [PATCH v5 RESEND 1/4] qapi: introduce PreallocMode and a new PreallocMode full.

2014-02-11 Thread Eric Blake
On 02/11/2014 12:07 AM, Hu Tao wrote: This patch prepares for the subsequent patches. Signed-off-by: Hu Tao hu...@cn.fujitsu.com --- block/qcow2.c| 8 qapi-schema.json | 12 2 files changed, 16 insertions(+), 4 deletions(-) +++ b/qapi-schema.json @@ -4419,3

Re: [Qemu-devel] [PATCH v8 13/13] dump: add 'query-dump-guest-memory-capability' command

2014-02-11 Thread Eric Blake
On 02/11/2014 12:19 AM, Paolo Bonzini wrote: Il 11/02/2014 03:47, Luiz Capitulino ha scritto: On Tue, 11 Feb 2014 00:34:37 +0100 Paolo Bonzini pbonz...@redhat.com wrote: Il 11/02/2014 00:30, Laszlo Ersek ha scritto: However, I don't see the point in having the format-option field. What

Re: [Qemu-devel] [PATCH] QMP: allow dot separated dict path arguments in qmp-shell

2014-02-11 Thread Stefan Hajnoczi
On Tue, Feb 11, 2014 at 06:45:05PM +0800, Fam Zheng wrote: diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-shell index d374b35..9c84551 100755 --- a/scripts/qmp/qmp-shell +++ b/scripts/qmp/qmp-shell @@ -112,7 +112,14 @@ class QMPShell(qmp.QEMUMonitorProtocol): value

Re: [Qemu-devel] [PATCH v2 1/3] Rework --name to use QemuOpts

2014-02-11 Thread Eric Blake
On 02/11/2014 02:07 AM, Paolo Bonzini wrote: Il 10/02/2014 17:12, Laszlo Ersek ha scritto: I'd checked every piece of output I'd found, but hadn't found the query-command-line-options; I think you're right there are no other \n's in there - but also all the other .help texts are much

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-11 Thread Orit Wasserman
On 02/08/2014 09:23 PM, Stefan Priebe wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set the migration caps to false. So it seems to be a xbzrle bug. XBZRLE is disabled by default (actually all capabilities are off by default) What version of

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-11 Thread Stefan Priebe - Profihost AG
Am 11.02.2014 14:32, schrieb Orit Wasserman: On 02/08/2014 09:23 PM, Stefan Priebe wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set the migration caps to false. So it seems to be a xbzrle bug. XBZRLE is disabled by default (actually all

  1   2   3   >