Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
于 2014/2/14 17:23, Markus Armbruster 写道:
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
于 2014/2/13 23:14, Markus Armbruster 写道:
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
It will check whether the values specified are written correctly,
On Tue, Feb 11, 2014 at 01:03:05PM +0100, Markus Armbruster wrote:
Amos Kong ak...@redhat.com writes:
vm_config_groups[] contain the options which have parameter, but some
legcy options haven't been added to vm_config_groups[].
All the options can be found in qemu-options.hx, this patch
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
于 2014/2/13 23:14, Markus Armbruster 写道:
Wenchao Xia xiaw...@linux.vnet.ibm.com writes:
It is bad that same key was specified twice, especially when a union have
two branches with same condition. This patch can prevent it.
Signed-off-by:
On Fr, 2014-02-07 at 13:51 +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS statically since PCI hotplug
region size became runtime changeable.
So replace static hole punching with dynamically consumed
resources in a child device on
On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS statically since PCI hotplug
region size became runtime changeable.
What makes it
Thanks for all your answers.
I understand that what I want to achieve seemed pretty confused. I will try
to clarify :
On real hardware, I have an I2C device used to get temperatures, pressure
etc... and it works on x86 and there were no QEMU virtualized hardware
corresponding.
I don't really
On Tue, Feb 11, 2014 at 01:19:16PM +0100, Markus Armbruster wrote:
[Note cc: Eric]
Hi Markus,
Amos Kong ak...@redhat.com writes:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch
On 17 February 2014 00:17, Peter Crosthwaite
peter.crosthwa...@xilinx.com wrote:
On Sun, Feb 16, 2014 at 2:07 AM, Peter Maydell peter.mayd...@linaro.org
wrote:
Implement the DAIF system register which is a view of the
DAIF bits in PSTATE.
Signed-off-by: Peter Maydell
On Wed, Feb 12, 2014 at 02:00:51PM -0700, Eric Blake wrote:
On 01/27/2014 08:53 PM, Amos Kong wrote:
Some legacy options that have arguments weren't added to
vm_config_groups[], so query-command-line-options returns a
NULL parameters infolist. This patch try to return help message
for
s/offet/offset/
Signed-off-by: Kevin Wolf kw...@redhat.com
---
trace-events | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/trace-events b/trace-events
index ab11f97..3713063 100644
--- a/trace-events
+++ b/trace-events
@@ -495,10 +495,10 @@
Il 17/02/2014 09:35, Alex David ha scritto:
- Are there solutions that seems more adapted to my case ? Like using
USB-I2C bridge ?
From an upstream point of view, a host passthrough device pair (one
object talking to /dev/i2c-N on the host, and one device per sensor
talking to the other
2014-02-17 10:19 GMT+01:00 Paolo Bonzini pbonz...@redhat.com:
Il 17/02/2014 09:35, Alex David ha scritto:
- Are there solutions that seems more adapted to my case ? Like using
USB-I2C bridge ?
From an upstream point of view, a host passthrough device pair (one object
talking to
* Michael R. Hines (mrhi...@linux.vnet.ibm.com) wrote:
On 02/06/2014 08:26 PM, Dr. David Alan Gilbert wrote:
Hi Isaku,
I hit a seg in qemu_rdma_cleanup in the code changed by your
'[PATCH] rdma: clean up of qemu_rdma_cleanup()'
migration-rdma.c ~ 2241
if (rdma-qp) {
Il 17/02/2014 10:38, Alex David ha scritto:
From an upstream point of view, a host passthrough device pair (one
object talking to /dev/i2c-N on the host, and one device per sensor
talking to the other object) would be the best.
i2c-N is on the guest, that's why I want to
On Sat, Feb 15, 2014 at 06:03:21PM +0100, Max Reitz wrote:
If the image file cannot be opened and was created as a temporary file,
it should be deleted; thus, in this case, we should jump to the
unlink_and_fail label and not just to fail.
Reported-by: Benoît Canet ben...@irqsave.net
Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben:
Commit 1b90d56e changed the implementation of in/out imm to not assign
the accessed port number to cpu_T[0] as it appeared unnecessary.
However, currently gen_check_io() makes use of cpu_T[0] to implement the
I/O bitmap checks, so it's in fact
On Thu, Jan 02, 2014 at 09:02:11AM +0800, Amos Kong wrote:
Test steps:
(qemu) device_add e1000,addr=adsf
Property 'e1000.addr' doesn't take value 'adsf'
(qemu) info qtree
Then qemu crashed.
Currently we set a link to the new device for qdev parent bus, but the
device hasn't been
Am 14.02.2014 um 20:17 hat Ian Main geschrieben:
On Thu, Feb 13, 2014 at 09:59:40AM +0100, Kevin Wolf wrote:
Am 12.02.2014 um 18:36 hat Ian Main geschrieben:
This is the sister command to blockdev-add. In Fam's example he uses
the drive_del HMP command to clean up but it would be much
On Mon, Feb 17, 2014 at 09:32:35AM +0100, Gerd Hoffmann wrote:
On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS statically since PCI
On Thu, 2014-02-13 at 10:44 +0100, Igor Mammedov wrote:
On Thu, 13 Feb 2014 14:14:08 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Tue, 2014-01-21 at 11:10 +0100, Andreas Färber wrote:
Am 21.01.2014 10:51, schrieb Chen Fan:
On Tue, 2014-01-21 at 10:31 +0100, Igor Mammedov
On Sun, 16 Feb 2014 17:53:45 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS statically since PCI hotplug
region size became runtime changeable.
Il 17/02/2014 11:01, Alex David ha scritto:
I indeed don't use paravirtualization.
Virtio _is_ paravirtualization. :)
I'm emulating a bunch of sensors/actuators.
If I virtualize my sensors and attach them to the i2c-dev with -device,
how do I get those data on the host then ?
It depends
On Mon, 17 Feb 2014 18:24:09 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Thu, 2014-02-13 at 10:44 +0100, Igor Mammedov wrote:
On Thu, 13 Feb 2014 14:14:08 +0800
Chen Fan chen.fan.f...@cn.fujitsu.com wrote:
On Tue, 2014-01-21 at 11:10 +0100, Andreas Färber wrote:
Am
On Mo, 2014-02-17 at 12:28 +0200, Michael S. Tsirkin wrote:
On Mon, Feb 17, 2014 at 09:32:35AM +0100, Gerd Hoffmann wrote:
On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became
On 17 February 2014 10:14, Kevin Wolf kw...@redhat.com wrote:
Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben:
Commit 1b90d56e changed the implementation of in/out imm to not assign
the accessed port number to cpu_T[0] as it appeared unnecessary.
However, currently gen_check_io() makes use
Am 15.02.2014 um 02:40 hat Max Reitz geschrieben:
On 12.02.2014 23:06, Benoît Canet wrote:
From: Benoît Canet ben...@irqsave.net
Add code to do num_children reads in parallel and cleanup the structures
afterward.
afterwards
Signed-off-by: Benoit Canet ben...@irqsave.net
Reviewed-by:
Right now, the temperature property must be written in milli-celsius, but it
reads back the value in 8.8 fixed point. Fix this by letting the property
read back the original value (possibly rounded). Also simplify the code that
does the conversion.
Before:
(QEMU) qom-set
On Mon, Feb 17, 2014 at 11:33:23AM +0100, Igor Mammedov wrote:
On Sun, 16 Feb 2014 17:53:45 +0200
Michael S. Tsirkin m...@redhat.com wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
Since introduction of PCIHP, it became problematic to
punch hole in PCI0._CRS
On Mon, Feb 17, 2014 at 11:46:13AM +0100, Gerd Hoffmann wrote:
On Mo, 2014-02-17 at 12:28 +0200, Michael S. Tsirkin wrote:
On Mon, Feb 17, 2014 at 09:32:35AM +0100, Gerd Hoffmann wrote:
On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote:
On Fri, Feb 07, 2014 at 01:51:27PM +0100,
Am 17.02.2014 um 11:47 hat Peter Maydell geschrieben:
On 17 February 2014 10:14, Kevin Wolf kw...@redhat.com wrote:
Am 24.01.2014 um 11:19 hat Kevin Wolf geschrieben:
Commit 1b90d56e changed the implementation of in/out imm to not assign
the accessed port number to cpu_T[0] as it appeared
Prodded by Alex David's i2c thread, I tried running i2cdetect on an x86
machine, and it reported all addresses as occupied. This small series
fixes it.
Paolo Bonzini (3):
smbus: allow returning an error from reads
smbus: return -1 if nothing found at the given address
pm_smbus: correctly
Fix coding standards in the meanwhile.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/i2c/smbus.c | 62 +++---
include/hw/i2c/smbus.h | 12 +-
2 files changed, 50 insertions(+), 24 deletions(-)
diff --git a/hw/i2c/smbus.c
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
hw/i2c/smbus.c | 6 +++---
include/hw/i2c/smbus.h | 6 +++---
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/hw/i2c/smbus.c b/hw/i2c/smbus.c
index 25d2d04..a8931b7 100644
--- a/hw/i2c/smbus.c
+++ b/hw/i2c/smbus.c
@@
Without this patch, i2cdetect will report all addresses as present.
With it, only 0x50..0x57 are present.
Before:
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f
10: 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f
20: 20 21
Am 17.02.2014 11:23, schrieb Amos Kong:
On Thu, Jan 02, 2014 at 09:02:11AM +0800, Amos Kong wrote:
Test steps:
(qemu) device_add e1000,addr=adsf
Property 'e1000.addr' doesn't take value 'adsf'
(qemu) info qtree
Then qemu crashed.
Currently we set a link to the new device for qdev
Hello all,
On Fri, Feb 14, 2014 at 1:16 PM, David Marchand david.march...@6wind.comwrote:
In HEAD, ivshmem seems to be the only place where qemu_chr_open_eventfd()
is used :
$ git grep qemu_chr_open_eventfd
hw/misc/ivshmem.c:chr = qemu_chr_open_eventfd(eventfd);
A NULL value is not added to visitor's stack, but there
is no check for that when the visitor tries to return
that value, leading to Qemu crash.
Signed-off-by: Marcel Apfelbaum marce...@redhat.com
---
qapi/qmp-output-visitor.c | 5 +
1 file changed, 5 insertions(+)
diff --git
On 8 February 2014 13:12, Peter Maydell peter.mayd...@linaro.org wrote:
On 3 February 2014 14:45, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
Sorry for the delay folks, totally forgot that one.
Here is the seabios update to 1.7.4 final.
please pull,
Gerd
The following changes since
Am 17.02.2014 11:57, schrieb Paolo Bonzini:
Right now, the temperature property must be written in milli-celsius, but it
reads back the value in 8.8 fixed point. Fix this by letting the property
read back the original value (possibly rounded). Also simplify the code that
does the conversion.
Hi Anthony,
I would like to get the Travis tests up and running on the official
QEMU GitHub mirror to try and shorten the loop between the build
breaking and people being notified. I'm quite happy to set this up if
you add me to the QEMU organisation (my GitHub username is: stsquad).
There are
On So, 2014-02-16 at 00:41 -0500, Jan Vesely wrote:
Signed-off-by: Jan Vesely jano.ves...@gmail.com
This should have a usb_version property, like usb-tablet has.
cheers,
Gerd
@@ -78,7 +80,7 @@ static void tmp105_set_temperature(Object *obj, Visitor
*v, void *opaque,
return;
}
-s-temperature = ((int16_t) (temp * 0x800 / 128000)) 4;
+s-temperature = (int16_t) (temp * 256 / 1000);
Did you check whether those magic 4 bits shift
On 17 February 2014 12:09, Alex Bennée alex.ben...@linaro.org wrote:
I would like to get the Travis tests up and running on the official
QEMU GitHub mirror to try and shorten the loop between the build
breaking and people being notified. I'm quite happy to set this up if
you add me to the QEMU
2014-02-17 11:38 GMT+01:00 Paolo Bonzini pbonz...@redhat.com:
Il 17/02/2014 11:01, Alex David ha scritto:
I indeed don't use paravirtualization.
Virtio _is_ paravirtualization. :)
Ok, now that seems much more understandable... I missed that point ha.
I'm emulating a bunch of
On 09/02/14 15:32, Andreas Färber wrote:
IIUC SUNW,cgthree is an optional device, so it's not covered by my
qom-test. Please follow-up with a tests/cg3-test.c so that it gets
covered. Compare my recent PCI NIC series for how such a stub could look
like, in particular vmxnet3-test.c since this
On 09/02/14 15:33, Peter Maydell wrote:
It's been a little while since I looked, however this was my interpretation
of the table 3-12 on p.66 of the SBus specification. While that particular
table refers to the acknowledgment cycle from the slave back to the master,
it seems to work here in the
Am 15.02.2014 um 04:30 hat Max Reitz geschrieben:
bdrv_file_open() is now nearly a subset of bdrv_open(), except for the
fact that bdrv_file_open() is for protocols and bdrv_open() for block
drivers. It is possible to use bdrv_file_open() with a block driver, but
in that case that block driver
On 10/02/14 08:20, Paolo Bonzini wrote:
Il 09/02/2014 16:24, Mark Cave-Ayland ha scritto:
Alright I can change those for the next version of the patch. Does that
mean the use of hex output is now a display option rather than a
separate property type?
info qtree will always print both
On 14/02/14 14:54, Peter Crosthwaite wrote:
The short answer is we don't know because we don't have any documentation.
Sigh This has happened quite a lot lately.
If the kernel driver has macros, re-use them as much as possible. If
you have a vague idea on whats, what, a few well invented
info qtree will always print both decimal and hex.
If I try that here then with the CG3 patch applied the prom_addr
property is always just displayed in decimal...? Or have I missed
something obvious here?
Grammar sucks. :)
It *will* always print both decimal and hex once HEX64 is gone.
On Mon, Feb 17, 2014 at 8:56 AM, Michael S. Tsirkin m...@redhat.com wrote:
On Mon, Feb 17, 2014 at 12:42:45AM +0100, Paolo Bonzini wrote:
Il 15/02/2014 19:10, Michael Tokarev ha scritto:
13 февраля 2014 г. 16:03:12 GMT+04:00, Antonios Motakis
a.mota...@virtualopensystems.com пишет:
I'm emulating a bunch of sensors/actuators.
If I virtualize my sensors and attach them to the i2c-dev with -device,
how do I get those data on the host then ?
It depends on your use case.
It could be that you can make them return a constant value.
Otherwise, you may want to use a
On Sat, 02/15 11:01, Markus Armbruster wrote:
Jeff Cody jc...@redhat.com writes:
On Fri, Feb 14, 2014 at 05:45:40PM +0100, Kevin Wolf wrote:
Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/cow.c | 12 +++-
Ping?
Thanks,
Fam
On Mon, 02/10 14:48, Fam Zheng wrote:
Rewrote the executable directory patch and added Darwin API in
qemu_init_exec_dir().
v20:
Dropped the argv0 passing patch from v19. Refactored qemu_get_exec_dir()
in
patch 01. Three patches are affected:
[01/11]
On Mo, 2014-02-17 at 11:56 +, Peter Maydell wrote:
On 8 February 2014 13:12, Peter Maydell peter.mayd...@linaro.org wrote:
On 3 February 2014 14:45, Gerd Hoffmann kra...@redhat.com wrote:
Hi,
Sorry for the delay folks, totally forgot that one.
Here is the seabios update to 1.7.4
Il 17/02/2014 14:11, Alex David ha scritto:
I've tried using tmp105. As my linux isn't 64bits, i'm using
qemu-system-i386... It crashes my computer when I use it with my linux
image (it's a debian .qcow2..., easy to do some tests...).
You mean crashes your host?
I will most probably need a
Il 17/02/2014 14:15, Fam Zheng ha scritto:
Does this mean that error_is_set() is always used by programmer to check a
non-NULL error pointer? Is there any case to call error_is_set(errp) without
knowing if errp is NULL or not? If no, should we enforce the rule and add
assert(errp) in
Hi,
This is a new tentative for the patches 2/5 to 5/5 from the target-ppc: Add
support for dumping guest memory using qemu gdb server patchset:
https://lists.nongnu.org/archive/html/qemu-ppc/2014-01/msg00380.html
All patches have been rebased on the current ppc-next head (72c798d7dccc).
To
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
Correctly update the htab_mask using the return value of
KVM_PPC_ALLOCATE_HTAB ioctl. Also we don't update sdr1
on GET_SREGS for HV. We check for external htab and if
found true, we don't need to update sdr1
[ fixed pte group offset
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
This support updating htab managed by the hypervisor. Currently we don't have
any user for this feature. This actually bring the store_hpte interface
in-line with the load_hpte one. We may want to use this when we want to
emulate henter hcall
On Mon, Feb 17, 2014 at 02:20:10PM +0100, Paolo Bonzini wrote:
Il 17/02/2014 14:15, Fam Zheng ha scritto:
Does this mean that error_is_set() is always used by programmer to check a
non-NULL error pointer? Is there any case to call error_is_set(errp) without
knowing if errp is NULL or not? If
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
With kvm enabled, we store the hash page table information in the hypervisor.
Use ioctl to read the htab contents. Without this we get the below error when
trying to read the guest address
(gdb) x/10 do_fork
0xc0098660 do_fork:
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com
For updating in kernel htab we need to provide both pte0 and pte1, hence update
the interface to take pte0 and pte1 together
[ ldq_phys() API change, Greg Kurz gk...@linux.vnet.ibm.com ]
Signed-off-by: Aneesh Kumar K.V
On 17 February 2014 13:17, Gerd Hoffmann kra...@redhat.com wrote:
On Mo, 2014-02-17 at 11:56 +, Peter Maydell wrote:
It looks like this pull request updates our seabios
module to a revision that isn't actually present in
git://git.qemu-project.org/seabios.git/. Gerd, do you
have a fix for
On Thu, 02/13 13:34, Benoît Canet wrote:
The Wednesday 29 Jan 2014 à 13:07:30 (+0800), Fam Zheng wrote :
@@ -368,6 +371,7 @@ void virtio_blk_data_plane_create(VirtIODevice *vdev,
VirtIOBlkConf *blk,
{
VirtIOBlockDataPlane *s;
int fd;
+Error *local_err = NULL;
Am 15.02.2014 um 04:30 hat Max Reitz geschrieben:
Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the
call to bdrv_file_open(). Additionally, make bdrv_file_open() static and
therefore bdrv_open() the only way to call it.
Consequently, all existing calls to
On Thu, 02/13 13:24, Benoît Canet wrote:
The Wednesday 29 Jan 2014 à 13:07:29 (+0800), Fam Zheng wrote :
+bool bdrv_op_is_blocked(BlockDriverState *bs, BlockOpType op, Error **errp)
+{
+BdrvOpBlocker *blocker;
+assert((int) op = 0 op BLOCK_OP_TYPE_MAX);
+if
On Thu, 02/13 13:49, Benoît Canet wrote:
The Wednesday 29 Jan 2014 à 13:07:32 (+0800), Fam Zheng wrote :
This is the common but non-trivial steps to assign or change the
backing_hd of BDS.
Signed-off-by: Fam Zheng f...@redhat.com
---
block.c | 34
On Thu, 02/13 14:48, Benoît Canet wrote:
The Wednesday 29 Jan 2014 à 13:07:37 (+0800), Fam Zheng wrote :
Similar to drive-backup, but this command uses a device id as target
instead of creating/opening an image file.
Also add blocker on target bs, since the target is also a named device
2014-02-17 14:19 GMT+01:00 Paolo Bonzini pbonz...@redhat.com:
Il 17/02/2014 14:11, Alex David ha scritto:
I've tried using tmp105. As my linux isn't 64bits, i'm using
qemu-system-i386... It crashes my computer when I use it with my linux
image (it's a debian .qcow2..., easy to do some
Il 17/02/2014 14:16, Fam Zheng ha scritto:
Ping?
I'll send a pull request for patches 1-10 later.
Paolo
Am 15.02.2014 um 04:30 hat Max Reitz geschrieben:
The fail and success paths of bdrv_file_open() may be further shortened
by reusing code already existent in bdrv_open(). This includes
bdrv_file_open() not taking the reference to options which allows the
removal of QDECREF(options) in that
On Mon, 02/17 14:34, Paolo Bonzini wrote:
Il 17/02/2014 14:16, Fam Zheng ha scritto:
Ping?
I'll send a pull request for patches 1-10 later.
Bravo, thanks!
Fam
On Thu, 02/13 13:37, Benoît Canet wrote:
The Wednesday 29 Jan 2014 à 13:07:29 (+0800), Fam Zheng wrote :
diff --git a/include/block/block_int.h b/include/block/block_int.h
index 0bcf1c9..4e558d0 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -270,6 +270,8 @@
On Fri, Feb 14, 2014 at 4:38 PM, Andreas Färber afaer...@suse.de wrote:
Am 14.02.2014 15:43, schrieb Stefan Hajnoczi:
On Sun, Feb 09, 2014 at 12:21:41PM +0100, Andreas Färber wrote:
Despite 1ad3c6abc0d67e00b84abaa5527bc64b70ca2205, supplying invalid
arguments to the QEMU process still leaked a
Hi,
After a solid few months of work the QEMU master branch [1] has now reached
instruction feature parity with the suse-1.6 [6] tree that a lot of people
have been using to build various aarch64 binaries. In addition to the
SUSE work we have fixed numerous edge cases and finished off classes of
Currently, gluster:///volname/img and (using file. options)
file.driver=gluster,file.filename=foo will segfault. Also,
//host/volname/img will be rejected, but it is a valid URL
that should be accepted just fine with file.driver=gluster.
Accept all of these, by inferring missing transport and
qemu-nbd is one of the few valid users of qerror_report_err. Move
the error-reporting socket wrappers there.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/block/nbd.h | 4
nbd.c | 50 --
qemu-nbd.c | 52
Before:
$ ./qemu-io-old
qemu-io-old open -r -o file.driver=nbd
one of path and host must be specified.
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
$ ./qemu-io-old
qemu-io-old open -r -o file.driver=nbd,file.host=foo,file.path=bar
path
Most of the block drivers are not using the Error** argument to bdrv_open,
and instead just printing errors to stderr. This series improves that,
and as a consequence it also avoids abuse of errno numbers.
The only hurdle (caught by qemu-iotests, too) is VMDK, where we currently
parse a file
Before:
$ qemu-io-old
qemu-io-old open -r -o file.driver=nbd
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
$ ./qemu-io-old
qemu-io-old open -r -o file.driver=nbd,file.host=foo,file.path=bar
path and host may not be used at the same time.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/gluster.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/block/gluster.c b/block/gluster.c
index f9dd37f..bc9c59f 100644
--- a/block/gluster.c
+++ b/block/gluster.c
@@ -175,7 +175,8 @@ out:
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
include/block/nbd.h | 1 -
nbd.c | 8 ++--
2 files changed, 2 insertions(+), 7 deletions(-)
diff --git a/include/block/nbd.h b/include/block/nbd.h
index e10ab82..1b39c06 100644
--- a/include/block/nbd.h
+++
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/curl.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/block/curl.c b/block/curl.c
index a807584..7edb3cc 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -456,30 +456,27 @@ static int
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/cow.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/block/cow.c b/block/cow.c
index 7fc0b12..0564744 100644
--- a/block/cow.c
+++ b/block/cow.c
@@ -82,7 +82,7 @@ static int cow_open(BlockDriverState *bs,
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/qcow.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/block/qcow.c b/block/qcow.c
index 948b0c5..a915bc3 100644
--- a/block/qcow.c
+++ b/block/qcow.c
@@ -119,17 +119,19 @@ static int
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/vhdx.c | 21 +
1 file changed, 9 insertions(+), 12 deletions(-)
diff --git a/block/vhdx.c b/block/vhdx.c
index 55689cf..bd3081b 100644
--- a/block/vhdx.c
+++ b/block/vhdx.c
@@ -402,9 +402,10 @@ int
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/iscsi.c | 45 +++--
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index c97c040..95a1030 100644
--- a/block/iscsi.c
+++ b/block/iscsi.c
@@ -1065,35
Before:
$ ./qemu-io-old
qemu-io-old open -r -o file.driver=iscsi,file.filename=foo
Failed to parse URL : foo
qemu-io-old: can't open device (null): Could not open 'foo': Invalid
argument
After:
$ ./qemu-io
qemu-io open -r -o file.driver=iscsi,file.filename=foo
Instead of just putting it in debugging output, we can now put the
value in an Error.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/vdi.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/block/vdi.c b/block/vdi.c
index f3c6acf..1966d62
Returning Wrong medium type for an image that does not have a valid
header is a bit weird. Improve the error by mentioning what format
was trying to open it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/bochs.c | 3 ++-
block/cow.c | 3 ++-
block/parallels.c | 3 ++-
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/vmdk.c | 41 ++---
1 file changed, 30 insertions(+), 11 deletions(-)
diff --git a/block/vmdk.c b/block/vmdk.c
index ff6f5ee..c834512 100644
--- a/block/vmdk.c
+++ b/block/vmdk.c
@@ -529,6 +529,32 @@
Before:
$ ./qemu-io-old
qemu-io-old open -r -o driver=vvfat,fat-type=24,dir=i386-softmmu
Valid FAT types are only 12, 16 and 32
qemu-io-old: can't open device (null): Could not open image: Invalid
argument
After:
$ ./qemu-io
qemu-io open -r -o
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/qed.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/block/qed.c b/block/qed.c
index b9ca7ac..b13ef8a 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -398,7 +398,7 @@ static int
Am 17.02.2014 um 14:15 hat Fam Zheng geschrieben:
On Sat, 02/15 11:01, Markus Armbruster wrote:
Jeff Cody jc...@redhat.com writes:
On Fri, Feb 14, 2014 at 05:45:40PM +0100, Kevin Wolf wrote:
Am 11.02.2014 um 18:03 hat Paolo Bonzini geschrieben:
Signed-off-by: Paolo Bonzini
This prepares for propagating errors from vmdk_open_sparse and
vmdk_open_desc_file up to the caller of vmdk_open.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/vmdk.c | 22 +++---
tests/qemu-iotests/059.out | 4 ++--
2 files changed, 17 insertions(+),
Currently, we just try reading a VMDK file as both image and descriptor.
This makes it hard to choose which of the two attempts gave the best error.
We'll decide in advance if the file looks like an image or a descriptor,
and this patch is the first step to that end.
Signed-off-by: Paolo Bonzini
Now that we can return the right errors, use the Error** parameter
to pass them back instead of just printing them.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
block/vmdk.c | 11 ++-
tests/qemu-iotests/059.out | 6 ++
2 files changed, 8 insertions(+), 9
The test (!!(mem-flags KVM_MEM_LOG_DIRTY_PAGES) == enable) is not
good because the condition is valid when enable == 0 and current dirty log
memory flag is set.
As a consequence kvm_log_global_stop() does not stop the KVM dirty log
tracking: kvm_set_migration_log(0) didn't do its job.
So instead
Vincent KHERBACHE (1):
Properly check if 'log dirty' flags have changed
kvm-all.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
--
1.8.3.1
1 - 100 of 379 matches
Mail list logo
