[Qemu-devel] [PATCH 2/7] allwinner-a10-pic: fix interrupt clear behaviour

2014-02-17 Thread Beniamino Galvani
According to this mail thread [1], writing to pending register seems to have no effect on actual pending status of interrupts. This means that the only way to clear a pending interrupt is to clear the interrupt source. This patch implements such behaviour. [1] http://lkml.org/lkml/2013/7/6/59 Sig

[Qemu-devel] [PATCH 1/7] allwinner-a10-pic: set vector address when an interrupt is pending

2014-02-17 Thread Beniamino Galvani
This patch implements proper updating of the vector register which should hold, according to the A10 user manual, the vector address for the interrupt currently active on the CPU IRQ input. Interrupt priority is not implemented at the moment and thus the first pending interrupt is returned. Signe

Re: [Qemu-devel] [PULL 00/22] QMP queue

2014-02-17 Thread Luiz Capitulino
On Sat, 15 Feb 2014 15:36:05 + Peter Maydell wrote: > On 13 February 2014 15:30, Luiz Capitulino wrote: > > The following changes since commit 9d74f6fef0801ca2ce5c9d38d59b85bf03c27669: > > > > Merge remote-tracking branch 'remotes/alon/pull-libcacard.glusterfs' into > > staging (2014-02-1

[Qemu-devel] [PATCH 7/7] allwinner-emac: update irq status after writes to interrupt registers

2014-02-17 Thread Beniamino Galvani
The irq line status must be updated after writes to the INT_CTL and INT_STA registers. Signed-off-by: Beniamino Galvani --- hw/net/allwinner_emac.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 91931ac..d780ba0 100644 --- a/hw/ne

[Qemu-devel] [PATCH 4/7] allwinner-a10-pit: use level triggered interrupts

2014-02-17 Thread Beniamino Galvani
Converts the interrupt generation logic to the use of level triggered interrupts. Signed-off-by: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/hw/timer/allwinner-a10-pit.c b/hw/timer/allwinner-a10-pit.c inde

[Qemu-devel] [PATCH 6/7] allwinner-emac: set autonegotiation complete bit on link up

2014-02-17 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani --- hw/net/allwinner_emac.c |4 ++-- include/hw/net/allwinner_emac.h |1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/hw/net/allwinner_emac.c b/hw/net/allwinner_emac.c index 469f2f0..91931ac 100644 --- a/hw/net/allwinner_emac.c

Re: [Qemu-devel] [PATCH RESEND] block/iscsi: query for supported VPD pages

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 18:34, Peter Lieven ha scritto: this patch ensures that we only query for block provisioning and block limits vpd pages if they are advertised. It also cleans up the inquiry code and eliminates some redundant code. Signed-off-by: Peter Lieven Thanks, I've queued it. It conflict

[Qemu-devel] [PATCH] target-arm: Fix incorrect arithmetic constructing short-form PAR for ATS ops

2014-02-17 Thread Peter Maydell
Correct some obviously nonsensical bit manipulation spotted by Coverity when constructing the short-form PAR value for ATS operations. Signed-off-by: Peter Maydell --- Presumably most guests don't actually care what the exact cause of a fault was when the v-to-p translation they asked for comes b

[Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init

2014-02-17 Thread Peter Maydell
The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs; use the correct constant in the loop initializing our output sysbus IRQs so that we don't overrun the output_irq[] array. Signed-off-by: Peter Maydell --- hw/intc/exynos4210_combiner.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [Qemu-devel] [PATCH v20 12/26] qcow2.c: replace QEMUOptionParameter with QemuOpts in amend options

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > qcow2.c: replace QEMUOptionParameter with QemuOpts in 'qemu-img amend' > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block.c |4 +- > block/qcow2.c | 90 --

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-17 Thread Gabriel L. Somlo
On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: > Well there is a bigger issue: any interrupt with > multiple sources is broken. > > __kvm_irq_line_state does a logical OR of all sources, > before XOR with polarity. > > This makes no sense if polarity is active low. So, do yo

Re: [Qemu-devel] [PATCH v20 13/26] qed.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > qed.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qed.c | 89 > +-- > block/qed.h |3 +- > 2 files changed, 45 in

Re: [Qemu-devel] [PATCH] qapi: output visitor crashes qemu if it encounters a NULL value

2014-02-17 Thread Marcel Apfelbaum
On Mon, 2014-02-17 at 10:38 -0700, Eric Blake wrote: > On 02/17/2014 04:52 AM, Marcel Apfelbaum wrote: > > A NULL value is not added to visitor's stack, but there > > is no check for that when the visitor tries to return > > that value, leading to Qemu crash. > > Do you have an easy formula for re

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-17 Thread Gabriel L. Somlo
On Mon, Feb 17, 2014 at 12:57:00PM -0500, Gabriel L. Somlo wrote: > On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: > > Well there is a bigger issue: any interrupt with > > multiple sources is broken. > > > > __kvm_irq_line_state does a logical OR of all sources, > > before XOR

Re: [Qemu-devel] [PATCH] hw/intc/exynos4210_combiner: Don't overrun output_irq array in init

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 18:53, Peter Maydell ha scritto: The Exynos4210 combiner has IIC_NIRQ inputs and IIC_NGRP outputs; use the correct constant in the loop initializing our output sysbus IRQs so that we don't overrun the output_irq[] array. Signed-off-by: Peter Maydell --- hw/intc/exynos4210_combine

[Qemu-devel] [PATCH 0/7] Allwinner A10 fixes

2014-02-17 Thread Beniamino Galvani
This series introduces some fixes and missing features found while trying to run mainline Linux kernel on emulated Allwinner A10. Most of the changes are related to interrupt handling but there are also some fixes to EMAC and timer. With this applied I'm able to boot Linux 3.14-rc2 using a NFS ro

Re: [Qemu-devel] [PATCH v20 14/26] raw-posix.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > raw-posix.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/raw-posix.c | 58 > 1 files changed, 27 insertions(+), 31 deletio

[Qemu-devel] [PATCH 3/7] allwinner-a10-pit: avoid generation of spurious interrupts

2014-02-17 Thread Beniamino Galvani
The model was generating interrupts for all enabled timers after the expiration of one of them. Avoid this by passing to the timer callback function a structure containing the index of the expired timer. Signed-off-by: Beniamino Galvani --- hw/timer/allwinner-a10-pit.c | 30 +++

[Qemu-devel] [PULL 03/12] rules.mak: allow per object cflags and libs

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng Adds extract-libs in LINK to expand any "per object libs", the syntax to define such a libs options is like: foo.o-libs := $(CURL_LIBS) in block/Makefile.objs. Similarly, foo.o-cflags := $(FOO_CFLAGS) is also supported. "foo.o" must be listed in a nested var

[Qemu-devel] [PULL 02/12] rules.mak: fix $(obj) to a real relative path

2014-02-17 Thread Paolo Bonzini
From: Fam Zheng Makefile.target includes rule.mak and unnested common-obj-y, then prefix them with '../', this will ignore object specific QEMU_CFLAGS in subdir Makefile.objs: $(obj)/curl.o: QEMU_CFLAGS += $(CURL_CFLAGS) Because $(obj) here is './block', instead of '../block'. This doesn't

Re: [Qemu-devel] [RFC 2/3] target-i386: add -smp X,apics=0x option

2014-02-17 Thread Eric Blake
On 01/14/2014 02:27 AM, Chen Fan wrote: > This option provides the infrastructure for specifying apicids when > boot VM, For example: > > #boot with apicid 0 and 2: > -smp 2,apics=0xA,maxcpus=4 /* 1010 */ > #boot with apicid 1 and 7: > -smp 2,apics=0x41,maxcpus=8 /* 0100 0001 */ This syntax

Re: [Qemu-devel] [RFC 3/3] target-i386: add qmp command 'query-cpus' to display apic_id

2014-02-17 Thread Eric Blake
On 01/14/2014 02:27 AM, Chen Fan wrote: > this patch provided the apic_id display as using command 'query-cpus'. > > Signed-off-by: Chen Fan > --- > cpus.c | 1 + > qapi-schema.json | 4 +++- > 2 files changed, 4 insertions(+), 1 deletion(-) > > +++ b/qapi-schema.json > @@ -783,6 +78

Re: [Qemu-devel] [PATCH v20 15/26] raw-win32.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > raw-win32.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/raw-win32.c | 33 + > 1 files changed, 17 insertions(+), 16 deletions(-) > > @@ -506,

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 19:01, Gabriel L. Somlo ha scritto: On Mon, Feb 17, 2014 at 12:57:00PM -0500, Gabriel L. Somlo wrote: On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: Well there is a bigger issue: any interrupt with multiple sources is broken. __kvm_irq_line_state does a logic

Re: [Qemu-devel] [PATCH v3 01/20] nbd: produce a better error if neither host nor port is passed

2014-02-17 Thread Eric Blake
On 02/17/2014 06:43 AM, Paolo Bonzini wrote: > Before: > $ qemu-io-old > qemu-io-old> open -r -o file.driver=nbd > qemu-io-old: can't open device (null): Could not open image: Invalid > argument > $ ./qemu-io-old > qemu-io-old> open -r -o file.driver=nbd,file.host=foo,file.path

Re: [Qemu-devel] [PATCH v20 16/26] raw_bsd.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > raw_bsd.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/raw_bsd.c | 27 --- > 1 files changed, 16 insertions(+), 11 deletions(-) > Reviewed-by: Eric B

[Qemu-devel] [PATCH 0/4] linux-user: four patches for coverity errors

2014-02-17 Thread Peter Maydell
This patchset contains fixes for four bugs spotted by coverity; mostly these are problems in error-handling codepaths. Peter Maydell (4): linux-user/elfload.c: Avoid calling g_free() on uninitialized data linux-user/signal.c: Don't pass sigaction uninitialised sa_flags linux-user: Fix error

[Qemu-devel] [PATCH 2/4] linux-user/signal.c: Don't pass sigaction uninitialised sa_flags

2014-02-17 Thread Peter Maydell
When forcing a fatal signal, we weren't initialising the sa_flags field in the struct sigaction we used to reset the signal handler to SIG_DFL. Signed-off-by: Peter Maydell --- linux-user/signal.c | 1 + 1 file changed, 1 insertion(+) diff --git a/linux-user/signal.c b/linux-user/signal.c index

[Qemu-devel] [PATCH 4/4] linux-user: Fix error handling in target_to_host_semarray()

2014-02-17 Thread Peter Maydell
Fix two issues in error handling in target_to_host_semarray(): * don't leak the host_array buffer if lock_user fails * return an error if malloc() fails Signed-off-by: Peter Maydell --- linux-user/syscall.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/linux-user/sy

[Qemu-devel] [PATCH 1/4] linux-user/elfload.c: Avoid calling g_free() on uninitialized data

2014-02-17 Thread Peter Maydell
Avoid calling g_free() on unintialized data in the error-handling paths in elf_core_dump() by splitting the initialization of the elf_note_info struct out of fill_note_info() so that it's always valid to call free_note_info() whether we got to the point of being able to fill_note_info() or not. Si

[Qemu-devel] [PATCH 3/4] linux-user: Fix error handling in lock_iovec()

2014-02-17 Thread Peter Maydell
In lock_iovec() if lock_user() failed we were doing an unlock_user but not a free(vec), which is the wrong way round. We were also assuming that free() and unlock_user() don't touch errno, which is not guaranteed. Fix both these problems. Signed-off-by: Peter Maydell --- linux-user/syscall.c | 1

Re: [Qemu-devel] [PATCH v20 17/26] rbd.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > rbd.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/rbd.c | 63 > +-- > 1 files changed, 31 insertions(+), 32 deletions

Re: [Qemu-devel] [PATCH 0/3] ARM: three easy patches for coverity-reported issues

2014-02-17 Thread Paolo Bonzini
Il 17/02/2014 15:37, Peter Maydell ha scritto: Three random easy patches fixing issues reported by Coverity Scan. Peter Maydell (3): hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses hw/net/stellaris_enet: Avoid unintended sign extension hw/timer/arm_timer: Avoid array overru

Re: [Qemu-devel] [PATCH v20 18/26] sheepdog.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > sheepdog.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/sheepdog.c | 101 > +- > 1 files changed, 47 insertions(+), 54 dele

Re: [Qemu-devel] Delegating tasks for the GitHub mirror

2014-02-17 Thread Stefan Weil
Am 17.02.2014 16:41, schrieb Markus Armbruster: > Peter Maydell writes: > >> On 17 February 2014 12:09, Alex Bennée wrote: >>> I would like to get the Travis tests up and running on the "official" >>> QEMU GitHub mirror to try and shorten the loop between the build >>> breaking and people being

Re: [Qemu-devel] PC-BSD installer does not boot with 1.7.4 (bisected)

2014-02-17 Thread Kevin O'Connor
On Mon, Feb 17, 2014 at 09:35:30PM +0400, Michael Tokarev wrote: > 10.02.2014 19:41, Kevin O'Connor wrote: > [] > > There hasn't been much comment, but I have pushed this patch to the > > main seabios repo for now. > > Xin Li (Cc'ed) replied to this email. Yes. Thanks. It would be good for Free

[Qemu-devel] [PATCH 2/4] trace: [tracetool,trivial] Style changes

2014-02-17 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 25 +++-- scripts/tracetool/backend/__init__.py |2 +- scripts/tracetool/format/__init__.py |2 +- scripts/tracetool/format/c.py |4 ++-- scripts/tracetool/format/d.py |

[Qemu-devel] [PATCH 0/4] Tracetool cleanup

2014-02-17 Thread Lluís Vilanova
Minimizes the amount of backend code, making it simpler to add new/different backends. Also performs other cleanups all around. Signed-off-by: Lluís Vilanova --- Lluís Vilanova (4): trace: [tracetool] Add method 'Event.api' to build event names trace: [tracetool,trivial] Style chang

[Qemu-devel] [PATCH 1/4] trace: [tracetool] Add method 'Event.api' to build event names

2014-02-17 Thread Lluís Vilanova
Makes it easier to ensure proper naming across the different frontends and backends. Signed-off-by: Lluís Vilanova --- scripts/tracetool/__init__.py | 10 +- scripts/tracetool/backend/dtrace.py |6 +++--- scripts/tracetool/backend/simple.py | 10 +- scripts/traceto

[Qemu-devel] [PATCH 3/4] trace: [tracetool] Identify formats directly used by QEMU

2014-02-17 Thread Lluís Vilanova
Signed-off-by: Lluís Vilanova --- scripts/tracetool/format/__init__.py | 13 - scripts/tracetool/format/c.py|3 +++ scripts/tracetool/format/d.py|3 +++ scripts/tracetool/format/events_c.py |3 +++ scripts/tracetool/format/events_h.py |3 +++ scripts/

[Qemu-devel] [PATCH 4/4] trace: [tracetool] Minimize the amount of per-backend code

2014-02-17 Thread Lluís Vilanova
Backends now only contain the essential backend-specific code, and most of the work is moved to frontend code. Signed-off-by: Lluís Vilanova --- scripts/simpletrace.py|6 -- scripts/tracetool/__init__.py | 24 ++ scripts/tracetool/backend/__init__.py | 72 +++

[Qemu-devel] [PATCH] trace: Multi-backend tracing

2014-02-17 Thread Lluís Vilanova
Adds support to compile QEMU with multiple tracing backends at the same time. For example, you can compile QEMU with: $ ./configure --enable-trace-backend=ftrace,dtrace Where 'ftrace' can be handy for having an in-flight record of events, and 'dtrace' can be later used to extract more informa

Re: [Qemu-devel] RFC: ioapic polarity vs. qemu os-x guest

2014-02-17 Thread Gabriel L. Somlo
On Mon, Feb 17, 2014 at 07:06:11PM +0100, Paolo Bonzini wrote: > Il 17/02/2014 19:01, Gabriel L. Somlo ha scritto: > >On Mon, Feb 17, 2014 at 12:57:00PM -0500, Gabriel L. Somlo wrote: > >>On Sun, Feb 16, 2014 at 06:23:11PM +0200, Michael S. Tsirkin wrote: > >>>Well there is a bigger issue: any inte

Re: [Qemu-devel] [PATCH] trace: Multi-backend tracing

2014-02-17 Thread Lluís Vilanova
This patch depends on the "Tracetool cleanup" series. The idea is based on Kazuya's "trace backend: introduce multi tracing backend" series. Thanks, Lluis

[Qemu-devel] [PATCH] target-arm: Load correct access bits from ARMv5 level 2 page table descriptors

2014-02-17 Thread Peter Maydell
In ARMv5 level 2 page table descriptors, each 4K or 64K page is split into four subpages, each of which can have different access permission settings, which are specified by four two-bit fields in the l2 descriptor. A long-standing cut-and-paste error meant we were using the wrong bits in the virtu

Re: [Qemu-devel] [PATCH v2, Ping] SMBIOS: Upgrade Type17 to v2.3, add Type2

2014-02-17 Thread Kevin O'Connor
On Mon, Feb 17, 2014 at 11:09:48AM -0500, Gabriel L. Somlo wrote: > On Fri, Feb 07, 2014 at 04:37:58PM +0100, Paolo Bonzini wrote: > >Il 06/02/2014 14:38, Gabriel L. Somlo ha scritto: > >>On Wed, Feb 05, 2014 at 08:02:25PM -0500, Kevin O'Connor wrote: > >>> Thanks. In general, though, it is prefer

Re: [Qemu-devel] [PATCH] virtio-net: Do not filter VLANs without F_CTRL_VLAN

2014-02-17 Thread Stefan Fritsch
On Sun, 16 Feb 2014, Michael S. Tsirkin wrote: > On Wed, Feb 12, 2014 at 10:46:28PM +0100, Stefan Fritsch wrote: > > If VIRTIO_NET_F_CTRL_VLAN is not negotiated, do not filter out all > > VLAN-tagged packets but send them to the guest. > > > > Signed-off-by: Stefan Fritsch > > Thanks for the pa

[Qemu-devel] [PULL v2 18/49] twl92230: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() and direct parent field accesses with QOM cast macro. Rename parent field. Add missing braces while at it. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/timer/twl92230.c | 35 +-- 1 file changed, 21 insert

[Qemu-devel] [PULL v2 35/49] qapi: Add size parser to StringInputVisitor

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Signed-off-by: Paolo Bonzini Reviewed-by: Eric Blake Reviewed-by: Igor Mammedov Signed-off-by: Andreas Färber --- qapi/string-input-visitor.c | 24 1 file changed, 24 insertions(+) diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visi

[Qemu-devel] [PULL v2 30/49] ipack: QOM parent field cleanup for IPackBus

2014-02-17 Thread Andreas Färber
Clean up the only user of IPackBus::qbus field and rename it. Acked-by: Alberto Garcia Signed-off-by: Andreas Färber --- hw/char/ipack.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/char/ipack.h b/hw/char/ipack.h index b62066f..a386b88 100644 --- a/hw/char/ipack.h +

[Qemu-devel] [PULL v2 34/49] qtest: Don't segfault with invalid -qtest option

2014-02-17 Thread Andreas Färber
From: Fam Zheng This prints an error message, instead of core dump, when "-qtest" option value is invalid, e.g.: $ ./x86_64-softmmu/qemu-system-x86_64 -qtest unknown qemu-system-x86_64: Failed to initialize device for qtest: "unknown" Signed-off-by: Fam Zheng Signed-off-by:

[Qemu-devel] [PULL v2 19/49] i2c: Drop FROM_I2C_SLAVE() macro

2014-02-17 Thread Andreas Färber
We now use type-specific QOM cast macros instead. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- include/hw/i2c/i2c.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index 9df987b..4986ebc 100644 --- a/include/hw/i2c/i2c.h +++ b

[Qemu-devel] [PULL v2 31/49] ipack: QOM parent field cleanup for IPackDevice

2014-02-17 Thread Andreas Färber
Rename the IPackDevice::qdev field to avoid accidental use. Acked-by: Alberto Garcia Signed-off-by: Andreas Färber --- hw/char/ipack.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/char/ipack.h b/hw/char/ipack.h index a386b88..e95ffe8 100644 --- a/hw/char/ipack.h ++

[Qemu-devel] [PULL v2 42/49] qdev: Use human mode in "info qtree"

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- qdev-monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qdev-monitor.c b/qdev-monitor.c index f385fb3..b37778f 100644 --- a/qdev-mo

[Qemu-devel] [PULL v2 48/49] qapi: Refine human printing of sizes

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini This fixes several bugs or shortcomings of the previous pretty-printer. In particular: * use PRIu64 instead of casting to long long * the exact value is included too * the correct unit of measure (MiB, GiB, etc.) is used. PiB and EiB are added too. * due to an off-by-one

[Qemu-devel] [PULL v2 36/49] qdev: Sizes are now parsed by StringInputVisitor

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c index b949f0e.

[Qemu-devel] [PULL v2 32/49] ipoctal232: QOM parent field cleanup

2014-02-17 Thread Andreas Färber
Clean up accesses to IPOctalState::dev field and rename it. Acked-by: Alberto Garcia Signed-off-by: Andreas Färber --- hw/char/ipoctal232.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/char/ipoctal232.c b/hw/char/ipoctal232.c index b33cfff..99bab4d 100644 --

[Qemu-devel] [PULL v2 49/49] qtest: Include system headers before user headers

2014-02-17 Thread Andreas Färber
From: Stefan Hajnoczi It is dangerous to include user headers before system headers since user macros can affect system headers. Signed-off-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/endianness-test.c | 2 +- tests/fw_cfg-test.c | 7 +++ tests/i440fx-test.c | 11

[Qemu-devel] [PULL v2 33/49] ipack: Move IndustryPack out of hw/char/

2014-02-17 Thread Andreas Färber
Move the header defining an IPackBus and IPackDevice base class into a new include/ directory and move their implementation and a PCI-IndustryPack bridge out of hw/char/ directory into a new hw/ipack/. Acked-by: Alberto Garcia Signed-off-by: Andreas Färber --- hw/Makefile.objs

[Qemu-devel] [PULL v2 39/49] qdev: Legacy properties are just strings

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini prop->info->legacy_name is still used by "-device foo,?". Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/core/

[Qemu-devel] [PULL v2 37/49] qdev: Remove legacy parsers for hex8/32/64

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini The hexNN property types have not been accepting values not prefixed by "0x" since QEMU 1.2. Parse those values as decimals now. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c |

Re: [Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema

2014-02-17 Thread Eric Blake
On 02/17/2014 03:24 PM, Andreas Färber wrote: > From: Paolo Bonzini > > Reviewed-by: Igor Mammedov > Reviewed-by: Eric Blake > Signed-off-by: Paolo Bonzini > Signed-off-by: Andreas Färber > --- > +++ b/qapi-schema.json > @@ -28,7 +28,65 @@ >'data': [ 'GenericError', 'CommandNotFound', 'D

[Qemu-devel] [PULL v2 38/49] qdev: Legacy properties are now read-only

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c | 10 +- hw/core/qdev.c| 30 ++ include/hw/qdev-core.h| 1 - 3 files changed, 3

[Qemu-devel] [PULL v2 43/49] qdev: Remove most legacy printers

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Their functionality is either aesthetic only (e.g. on/off vs. true/false) or obtained by the "human mode" of StringOutputVisitor. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c |

[Qemu-devel] [PULL v2 46/49] qdev: Add enum property types to QAPI schema

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c | 20 +++- hw/i386/kvm/i8254.c | 6 ++--- hw/timer/mc146818rtc.c| 14 ++-- include/hw/block/block.h

[Qemu-devel] [PULL v2 45/49] block: Handle "rechs" and "large" translation options

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Sure, CHS translation is an obscure topic, and legacy options for hard-disk geometries are obscure as well. But since QEMU does nothing with it except telling the BIOS, and since there "large" and "rechs" are listed in the enums, parsing them seems to be the bare minimum. Ac

Re: [Qemu-devel] [PATCH 4/5] tcg/i386: Use ANDN instruction

2014-02-17 Thread Richard Henderson
On 02/16/2014 12:12 PM, Aurelien Jarno wrote: > On Fri, Jan 31, 2014 at 08:43:37AM -0600, Richard Henderson wrote: >> > Note that the optimizer cannot simplify ANDC X,Y,C to AND X,Y,~C >> > so we must handle constants in the implementation of andc. > I do wonder if it actually won't be a better ide

Re: [Qemu-devel] [PATCH 0/6] A64: finish Neon 3-reg-diff category, add LDTR/STTR

2014-02-17 Thread Richard Henderson
On 02/16/2014 12:21 PM, Peter Maydell wrote: > Another patchset of random filling in the gaps in our Neon > coverage. Patches 1 through 5 complete our handling of the > three-reg-different category of Neon instructions. > > Patch 6 implements the "unprivileged load/store" LDTR/STTR > instructions.

Re: [Qemu-devel] [PATCH 5/6] target-arm: A64: Implement PMULL instruction

2014-02-17 Thread Richard Henderson
On 02/16/2014 12:21 PM, Peter Maydell wrote: > +/* Helper function for 64 bit polynomial multiply case: > + * perform PolynomialMult(op1, op2) and return either the top or > + * bottom half of the 128 bit result. > + */ > +uint64_t HELPER(neon_pmull_64_lo)(CPUARMState *env, uint64_t op1, uint64_t

[Qemu-devel] [PULL v2 06/49] qom-test: Test shutdown in addition to startup

2014-02-17 Thread Andreas Färber
From: Markus Armbruster Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber --- tests/qom-test.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/qom-test.c b/tests/qom-test.c index 24cb9c5..3316a11 100644 --- a/tests/qom-test.c +++ b/tests/qo

Re: [Qemu-devel] [PATCH 5/6] target-arm: A64: Implement PMULL instruction

2014-02-17 Thread Peter Maydell
On 17 February 2014 16:29, Richard Henderson wrote: > On 02/16/2014 12:21 PM, Peter Maydell wrote: >> +/* Helper function for 64 bit polynomial multiply case: >> + * perform PolynomialMult(op1, op2) and return either the top or >> + * bottom half of the 128 bit result. >> + */ >> +uint64_t HELPER(

[Qemu-devel] [PULL v2 40/49] qdev: Inline qdev_prop_parse()

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties.c| 8 +--- include/hw/qdev-properties.h | 2 -- qdev-monitor.c | 4 ++-- 3 files changed, 3 insertions(+), 11 de

[Qemu-devel] [PULL v2 16/49] lm832x: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() and direct parent field accesses with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/input/lm832x.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/hw/input/l

[Qemu-devel] [PULL v2 29/49] ipack: Convert to QOM realize

2014-02-17 Thread Andreas Färber
Acked-by: Alberto Garcia Signed-off-by: Andreas Färber --- hw/char/ipack.c | 41 ++--- hw/char/ipack.h | 6 -- hw/char/ipoctal232.c | 8 +++- 3 files changed, 29 insertions(+), 26 deletions(-) diff --git a/hw/char/ipack.c b/hw/char/ipack.c

[Qemu-devel] [PULL v2 23/49] tests: Add pcnet qtest

2014-02-17 Thread Andreas Färber
Test PCI only for now. Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 4 tests/pcnet-test.c | 33 + 2 files changed, 37 insertions(+) create mode 100644 tests/pcnet-test.c diff --git a/tests/Makefile b/tests/Makefile i

[Qemu-devel] [PULL v2 21/49] tests: Add vmxnet3 qtest

2014-02-17 Thread Andreas Färber
Note that this will emit a warning: [vmxnet3][WR][vmxnet3_peer_has_vnet_hdr]: Peer has no virtio extension. Task offloads will be emulated. Reviewed-by: Dmitry Fleytman Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 5 + tests/vmxnet3-test.c | 33 +++

[Qemu-devel] [PULL v2 03/49] target-ppc: Make ppc40x CPUs available in ppcemb

2014-02-17 Thread Andreas Färber
Not only 44x CPUs (BookE) but also 40x CPUs can run with 1k page size. Move the criteria to a central inline function to avoid repetition and #ifdef'fery. Update qom-test to no longer exempt them. Signed-off-by: Andreas Färber --- target-ppc/translate_init.c | 38 +++

[Qemu-devel] [PULL v2 17/49] ds1338: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/timer/ds1338.c | 21 + 1 file changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/timer/ds1338.c b/hw/timer/ds1338.c index

Re: [Qemu-devel] [PATCH 5/5] tcg/i386: Use SHLX/SHRX/SARX instructions

2014-02-17 Thread Richard Henderson
On 02/16/2014 08:21 AM, Paolo Bonzini wrote: > Il 31/01/2014 15:43, Richard Henderson ha scritto: >> +gen_shift_maybe_vex: >> +if (have_bmi2 && !const_args[2]) { >> +tcg_out_vex_modrm(s, vexop + rexw, args[0], args[2], args[1]); >> +break; >> +} >> +

Re: [Qemu-devel] [PATCH v8 00/13] Make 'dump-guest-memory' dump in kdump-compressed format

2014-02-17 Thread Luiz Capitulino
On Tue, 11 Feb 2014 12:00:56 -0500 Luiz Capitulino wrote: > On Tue, 28 Jan 2014 14:21:53 +0800 > qiaonuohan wrote: > > > Hi, all > > > > The last version is here: > > http://lists.nongnu.org/archive/html/qemu-devel/2014-01/msg00209.html > > > > Command 'dump-guest-memory' was introduced to du

Re: [Qemu-devel] [PATCH v20 19/26] ssh.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > ssh.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/ssh.c | 31 +++ > 1 files changed, 15 insertions(+), 16 deletions(-) > > .bdrv_getlength

[Qemu-devel] [PULL v2 14/49] ssd0303: QOM'ify

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/display/ssd0303.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/hw/display/ssd0303.c b/hw/display/ssd0303.c

[Qemu-devel] [PULL v2 41/49] qapi: Add human mode to StringOutputVisitor

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini This will be used by "info qtree". For numbers it prints both the decimal and hex values. For sizes it rounds to the nearest power of 2^10. For strings, it puts quotes around the string and separates NULL and empty string. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blak

[Qemu-devel] [PULL v2 28/49] tests: Add ipoctal232 qtest

2014-02-17 Thread Andreas Färber
Acked-by: Alberto Garcia Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 7 +++ tests/ipoctal232-test.c | 33 + 2 files changed, 40 insertions(+) create mode 100644 tests/ipoctal232-test.c diff --git a/tests/Makefil

[Qemu-devel] [PULL v2 22/49] tests: Add rtl8139 qtest

2014-02-17 Thread Andreas Färber
Reviewed-by: Stefan Hajnoczi Signed-off-by: Andreas Färber --- tests/Makefile | 3 +++ tests/rtl8139-test.c | 33 + 2 files changed, 36 insertions(+) create mode 100644 tests/rtl8139-test.c diff --git a/tests/Makefile b/tests/Makefile index 8c06abb..d7993

[Qemu-devel] [PULL v2 47/49] qdev: Use QAPI type names for properties

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Use "drive", "chr", etc. only for legacy_name (which shows up in -device foo,? output). Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/core/qdev-properties-system.c | 12 hw/core/qdev-prop

[Qemu-devel] [PULL v2 15/49] max7310: QOM'ify

2014-02-17 Thread Andreas Färber
Replace FROM_I2C_SLAVE() usages with QOM cast macro. Rename parent field. Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/gpio/max7310.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/hw/gpio/max7310.c b/hw/gpio/max7310.c index 5

[Qemu-devel] [PULL v2 44/49] qdev: Remove hex8/32/64 property types

2014-02-17 Thread Andreas Färber
From: Paolo Bonzini Replace them with uint8/32/64. Reviewed-by: Igor Mammedov Reviewed-by: Eric Blake Signed-off-by: Paolo Bonzini Signed-off-by: Andreas Färber --- hw/audio/adlib.c | 2 +- hw/audio/cs4231a.c | 2 +- hw/audio/gus.c | 2 +- hw/audio/pcs

[Qemu-devel] [PULL v2 09/49] i2c: Rename i2c_bus to I2CBus

2014-02-17 Thread Andreas Färber
Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/acpi/piix4.c | 6 +++--- hw/arm/exynos4210.c | 2 +- hw/arm/musicpal.c | 4 ++-- hw/arm/nseries.c| 2 +- hw/arm/pxa2xx.c | 6 +++--- hw/arm/realview.c | 4 ++-

[Qemu-devel] [PULL v2 04/49] tests: Fix gcov paths for relocated device sources

2014-02-17 Thread Andreas Färber
Commit 49ab747f668f421138d5b40d83fa279c4c5e278d moved fdc.c, hd-geometry.c, m48t59.c, tmp105.c into hw/ subdirectories; commit 0ddfaf7fe4c8453446730328bf348b7c6438e4f8 did for mc146818rtc.c. Cc: Paolo Bonzini Signed-off-by: Andreas Färber --- tests/Makefile | 12 ++-- 1 file changed, 6

[Qemu-devel] [PULL v2 05/49] qom-test: Run for all available machines

2014-02-17 Thread Andreas Färber
From: Markus Armbruster Get available machines via QMP instead of hardcoding a list that's perpetually out of date. Xen machines can work only when running under the Xen hypervisor. Blacklist them. Signed-off-by: Markus Armbruster Signed-off-by: Andreas Färber --- tests/qom-test.c | 274

[Qemu-devel] [PULL v2 00/49] QOM devices patch queue 2014-02-17

2014-02-17 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. v2 is rebased to fix a merge conflict, fixes some gcov warnings and adds 2 Acked-bys and 2 qtest patches. Regards, Andreas Cc: Peter Maydell Cc: Anthony Liguori Cc: Markus Armbruster Cc: Alexander Graf Cc: Stefan Hajnoczi Cc:

[Qemu-devel] [PULL v2 02/49] ppcemb-softmmu: Drop Mac and e500 emulation

2014-02-17 Thread Andreas Färber
They are still available in ppc-softmmu and ppc64-softmmu. Signed-off-by: Andreas Färber --- default-configs/ppc-softmmu.mak| 1 + default-configs/ppc64-softmmu.mak | 1 + default-configs/ppcemb-softmmu.mak | 20 hw/ppc/Makefile.objs | 4 ++-- 4 files c

[Qemu-devel] [PULL v2 08/49] nand: Don't use qdev_create() in nand_init()

2014-02-17 Thread Andreas Färber
Commit 7426aa72c36c908a7d0eae3e38568bb0a70de479 (nand: Don't inherit from Sysbus) changed the parent type of TYPE_NAND but continued to use qdev_create(), which handled a NULL BusState as SysBus. Use object_new() instead, and reuse the TYPE_NAND define while at it. Reported-by: Markus Armbruster

[Qemu-devel] [PULL v2 12/49] z2: QOM'ify AER915

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename the parent field. Reuse the type constant in z2_init(). Reviewed-by: Peter Crosthwaite [AF: Use TYPE_AER915 in z2_init() too] Signed-off-by: Andreas Färber --- hw/arm/z2.c | 20 +--- 1 file changed, 13 insertions(+),

Re: [Qemu-devel] [PATCH v20 20/26] vdi.c: replace QEMUOptionParameter with QemuOpts

2014-02-17 Thread Eric Blake
On 02/11/2014 11:33 PM, Chunyan Liu wrote: > vdi.c: replace QEMUOptionParameter with QemuOpts > > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/vdi.c | 71 -- > 1 files changed, 34 insertions(+), 37 deletions(-)

[Qemu-devel] [PULL v2 10/49] pxa2xx: QOM'ify I2C slave

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() and direct parent field accesses with QOM cast macro. Rename parent field to assure we caught all. Reuse type constant in pxa2xx_i2c_init(). Add some missing braces while at it. Signed-off-by: Andreas Färber --- hw/arm/pxa2xx.c | 38 +--

[Qemu-devel] [PULL v2 11/49] tosa: QOM'ify DAC

2014-02-17 Thread Andreas Färber
Replace usages of FROM_I2C_SLAVE() with QOM cast macro. Rename parent field. Use type constant in tosa_tg_init(). Reviewed-by: Peter Crosthwaite Signed-off-by: Andreas Färber --- hw/arm/tosa.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/hw/arm/tosa.c b/

[Qemu-devel] [PULL v2 01/49] qtest: don't report signals if qtest driver enabled

2014-02-17 Thread Andreas Färber
From: "Michael S. Tsirkin" qtest driver always uses signals to kill qemu no need to report it, whatever the accelerator state. Add API to detect qtest driver, and suppress reporting signals in this case. Reported-by: Andreas Färber Signed-off-by: Michael S. Tsirkin Signed-off-by: Andreas Färb

[Qemu-devel] [PULL v2 07/49] tests: Run qom-test for every architecture

2014-02-17 Thread Andreas Färber
From: Peter Maydell Rather than requiring every new architecture to remember to add a line to the Makefile to say that qom-test will work on it, autogenerate the list of supported architectures by looking at the files in default-configs (as configure does), and add qom-test to the test list for a

<    1   2   3   4   >