Andreas Färber writes:
> Am 18.02.2014 13:54, schrieb Markus Armbruster:
>> Peter, can you merge this patch? v2 is from December 20, and the
>> changes since then have been limited to the commit message.
>>
>> In case Peter doesn't want to take it directly: Andreas, would you be
>> willing to t
On 17 February 2014 13:23, Peter Maydell wrote:
> On 17 February 2014 13:17, Gerd Hoffmann wrote:
>> The seabios mirroring doesn't seem to be automatic (or the automatic
>> mirroring is broken). Usually Anthony updates the seabios.git tree
>> manually.
>>
>> Upstream git repo is git://git.seabio
On 02/18/2014 05:33 AM, Vincent KHERBACHE wrote:
> The test (!!(mem->flags & KVM_MEM_LOG_DIRTY_PAGES) == enable) is wrong
> because
> the condition is valid when enable = 0 and current dirty log memory flag is
> set.
> As a consequence kvm_log_global_stop() does not stop the KVM dirty log
> trac
On 02/17/2014 10:53 PM, mrhi...@linux.vnet.ibm.com wrote:
> From: "Michael R. Hines"
>
> This series allows us to send the contents of the entire MigrationInfo
> structure to the
> destination once the migration is over. This is very useful for analyzing
> the result of a migration, and particul
The Saturday 15 Feb 2014 à 04:30:23 (+0100), Max Reitz wrote :
> The fail and success paths of bdrv_file_open() may be further shortened
> by reusing code already existent in bdrv_open(). This includes
> bdrv_file_open() not taking the reference to options which allows the
> removal of QDECREF(opti
Ok, thank you very much for your help then. I'm gonna spend some time on
this.
If qemu-dev / you are interested in what I've done later, I'll send a new
mail.
2014-02-18 14:05 GMT+01:00 Paolo Bonzini :
> Il 18/02/2014 13:48, Alex David ha scritto:
>
>>
>> 2014-02-17 17:11 GMT+01:00 Paolo Bonzi
Il 18/02/2014 14:44, Alex David ha scritto:
Ok, thank you very much for your help then. I'm gonna spend some time on
this.
If qemu-dev / you are interested in what I've done later, I'll send a
new mail.
Yes, if you get the USB-I2C bridge to work, we'd be interested in
including it in QEMU!
The Saturday 15 Feb 2014 à 04:30:19 (+0100), Max Reitz wrote :
> Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the
> call to bdrv_file_open(). Additionally, make bdrv_file_open() static and
> therefore bdrv_open() the only way to call it.
>
> Consequently, all existing calls
Il 18/02/2014 13:44, Andreas Färber ha scritto:
> There isn't really a standard criterion. It's up to each maintainer to
> be stricter or looser on what goes to stable.
The criteria is pretty simple: Was the breakage in the last release
already or was it introduced only intermittently.
You ha
On 02/18/2014 05:06 AM, Michael S. Tsirkin wrote:
> On Mon, Feb 17, 2014 at 11:58:11AM -0500, Vlad Yasevich wrote:
>> On 02/17/2014 11:56 AM, Eric Blake wrote:
>>> On 02/17/2014 09:52 AM, Eric Blake wrote:
On 02/16/2014 07:27 PM, Amos Kong wrote:
> Stefan Fritsch just fixed a virtio-net dr
On Tue, 18 Feb 2014, Paolo Bonzini wrote:
> Il 18/02/2014 13:45, Stefano Stabellini ha scritto:
> > Disk unplug: hw/ide/piix.c:pci_piix3_xen_ide_unplug (see the beginning
> > of the email :-P).
> > It is called by hw/xen/xen_platform.c:platform_fixed_ioport_writew, in
> > response to the guest writ
Il 18/02/2014 15:25, Stefano Stabellini ha scritto:
On Tue, 18 Feb 2014, Paolo Bonzini wrote:
Il 18/02/2014 13:45, Stefano Stabellini ha scritto:
Disk unplug: hw/ide/piix.c:pci_piix3_xen_ide_unplug (see the beginning
of the email :-P).
It is called by hw/xen/xen_platform.c:platform_fixed_ioport
On Tue, 18 Feb 2014, Igor Mammedov wrote:
> On Tue, 18 Feb 2014 12:45:29 +
> Stefano Stabellini wrote:
>
> > On Tue, 18 Feb 2014, Paolo Bonzini wrote:
> > > Il 18/02/2014 13:16, Stefano Stabellini ha scritto:
> > > > It looks like that this series breaks disk unplug
> > > > (hw/ide/piix.c:pci
Le 18/02/2014 14:23, Eric Blake a écrit :
>> -return err;
>> -}
>> +err = kvm_slot_dirty_pages_log_change(mem, (bool)enable);
>
> Is this a v2 post? Any reason you reposted without addressing my
> earlier review?
> https://lists.gnu.org/archive/html/qemu-devel/2014-02/
On Tue, Feb 18, 2014 at 11:02:52AM +0100, Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Stefan Hajnoczi writes:
> >
> >> The QEMU process stays running if the test case fails. This patch fixes
> >> the leak by installing a SIGABRT signal handler which invokes
> >> qtest_end().
> >>
This commit updates the status for the HMP, QAPI and QMP trees from
"Supported" to "Maintained".
In practice this means that patch review and pull requests may take
longer. Also, I'll rely more on reviewers such as Eric Blake so that
I'm able to send pull requests regularly.
Signed-off-by: Luiz C
On Tue, Feb 18, 2014 at 10:55:56AM +0100, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > On Mon, Feb 17, 2014 at 05:49:31PM +0100, Markus Armbruster wrote:
> >> Stefan Hajnoczi writes:
> >> > if (s->qemu_pid != -1) {
> >> > kill(s->qemu_pid, SIGTERM);
> >> > wait
On Tue, Feb 18, 2014 at 11:43:10AM +0100, Markus Armbruster wrote:
> Paolo Bonzini writes:
>
> > Il 18/02/2014 11:05, Markus Armbruster ha scritto:
> >>> > Yes, SIGABRT is synchronous for all purposes. So the only danger is
> >>> > that g_string_free() or g_free() could fail while we're in
> >>>
On 02/18/2014 01:38 PM, Greg Kurz wrote:
From: Rusty Russell
virtio data structures are defined as "target endian", which assumes
that's a fixed value. In fact, that actually means it's
platform-specific.
The OASIS virtio 1.0 spec will fix this. Meanwhile, create a hook for
little endian ppc
Stefan Hajnoczi writes:
> On Tue, Feb 18, 2014 at 11:02:52AM +0100, Markus Armbruster wrote:
>> Markus Armbruster writes:
>>
>> > Stefan Hajnoczi writes:
>> >
>> >> The QEMU process stays running if the test case fails. This patch fixes
>> >> the leak by installing a SIGABRT signal handler wh
Signed-off-by: Stefan Hajnoczi
---
tests/libqtest.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tests/libqtest.c b/tests/libqtest.c
index c9a4f89..2876ce4 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -43,7 +43,6 @@ struct QTestState
int qmp_fd;
bool irq_level[MAX_IRQ
The QEMU process stays running if the test case fails. This patch fixes
the leak by installing a SIGABRT signal handler which invokes
qtest_end().
Signed-off-by: Stefan Hajnoczi
---
tests/libqtest.c | 31 +--
1 file changed, 25 insertions(+), 6 deletions(-)
diff --g
On 18 February 2014 09:17, Stefan Hajnoczi wrote:
> When I drive on the highway I stay on the lanes but I guess I could just
> slide along the side barriers :). It's a style issue but close(-1)
> annoys me in strace so I try to avoid doing it.
As an aside, ever try stracing gtester? It implement
On Tue, Feb 18, 2014 at 05:03:27PM +0200, Michael S. Tsirkin wrote:
> On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> > On 02/18/2014 01:38 PM, Greg Kurz wrote:
> > >From: Rusty Russell
> > >
> > >virtio data structures are defined as "target endian", which assumes
> > >that's a
On 02/18/2014 04:03 PM, Michael S. Tsirkin wrote:
On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
On 02/18/2014 01:38 PM, Greg Kurz wrote:
From: Rusty Russell
virtio data structures are defined as "target endian", which assumes
that's a fixed value. In fact, that actually mea
On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> On 02/18/2014 01:38 PM, Greg Kurz wrote:
> >From: Rusty Russell
> >
> >virtio data structures are defined as "target endian", which assumes
> >that's a fixed value. In fact, that actually means it's
> >platform-specific.
> >
> >The
v2:
* Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
* Use sigemptyset() to avoid assumption about signal mask [Markus]
* if (fd != -1) close(fd) is no longer necessary [Markus]
This series prevents the following qtest issues:
1. Leaking the pidfile if QEMU startup fai
2014-02-18
--
* [Qemu-devel] [PATCH V17 00/11] Add support for binding guest numa
nodes
Any news about this? (Vinod)
* Should we change anything to get more people to sign for the call?
There hasn't been a call in quite a long time. Ideas? (me)
* x2apic?
- Pending patch for cp
2014-02-18
--
* x2apic?
- Pending patch for cpu feature flag.
- Should this be the default.
- It is not for 32bits, but should it be for 64bit?
- libvirt always use x2apic, unconditionally?
- What happens if one side of migration uses -m
On Tue, Feb 18, 2014 at 04:02:18PM +0100, Alexander Graf wrote:
> On 02/18/2014 04:03 PM, Michael S. Tsirkin wrote:
> >On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> >>On 02/18/2014 01:38 PM, Greg Kurz wrote:
> >>>From: Rusty Russell
> >>>
> >>>virtio data structures are defined
On 02/18/2014 04:11 PM, Michael S. Tsirkin wrote:
On Tue, Feb 18, 2014 at 04:02:18PM +0100, Alexander Graf wrote:
On 02/18/2014 04:03 PM, Michael S. Tsirkin wrote:
On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
On 02/18/2014 01:38 PM, Greg Kurz wrote:
From: Rusty Russell
vi
On Mon, Feb 17, 2014 at 06:55:34PM +, Peter Maydell wrote:
> Fix two issues in error handling in target_to_host_semarray():
> * don't leak the host_array buffer if lock_user fails
> * return an error if malloc() fails
With this patch I get on ubuntu raring x86_64 (gcc 4.7):
In function ‘tar
On 18 February 2014 15:10, Riku Voipio wrote:
> On Mon, Feb 17, 2014 at 06:55:34PM +, Peter Maydell wrote:
>> Fix two issues in error handling in target_to_host_semarray():
>> * don't leak the host_array buffer if lock_user fails
>> * return an error if malloc() fails
>
> With this patch I g
On Tue, 18 Feb 2014 17:03:27 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> > On 02/18/2014 01:38 PM, Greg Kurz wrote:
> > >From: Rusty Russell
> > >
> > >virtio data structures are defined as "target endian", which assumes
> > >that's a fix
qtest_init() cannot use exec*p() to launch QEMU since the exec*p()
functions take an argument array while qtest_init() takes char
*extra_args. Therefore we execute /bin/sh -c and let the
shell parse the argument string.
This left /bin/sh as our child process and our child's child was QEMU.
We st
The ethernet device in the musicpal only has two tx queues,
but we modelled it with four CTDP registers, presumably a
cut and paste from the rx queue registers. Since the tx_queue[]
array is only 2 entries long this allowed a guest to overrun
this buffer. Remove the nonexistent registers.
Signed-o
Quick experiment to gauge the likelihood of conflicts: I reran
coccinelle on v1.7.0, then attempted to merge the result into master. I
got *two* conflicts. I backed out with "git-merge --abort", then merged
with "git-merge -s recursive -X ours g_new.old" to drop both conflicting
hunks, and the re
Il 18/02/2014 15:54, Stefan Hajnoczi ha scritto:
The QEMU process stays running if the test case fails. This patch fixes
the leak by installing a SIGABRT signal handler which invokes
qtest_end().
Signed-off-by: Stefan Hajnoczi
---
tests/libqtest.c | 31 +--
1 file
On Tue, 18 Feb 2014 16:12:08 +0100
Cornelia Huck wrote:
> On Tue, 18 Feb 2014 17:03:27 +0200
> "Michael S. Tsirkin" wrote:
>
> > On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> > > On 02/18/2014 01:38 PM, Greg Kurz wrote:
> > > >From: Rusty Russell
> > > >
> > > >virtio data
So we don't spam stderr with (guest-triggerable) messages by default.
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 90 +++
1 file changed, 45 insertions(+), 45 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 12575
Hi,
Nothing major. Cleanups, bugfixes, xhci emulation improvements.
please pull,
Gerd
The following changes since commit 46eef33b89e936ca793e13c4aeea1414e97e8dbb:
Fix QEMU build on OpenBSD on x86 archs (2014-02-17 11:44:00 +)
are available in the git repository at:
git://git.krax
Frameid specifies frames not microframes, so we
need to shift it to get the microframe index.
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 8d9cfe8..706cdc7 100644
--- a/hw/us
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 8261d00..12575dd 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -2038,9 +2038,7 @@ static int xhci_submit(XHCIState *xhc
Found by Coverity.
Reported-by: Markus Armbruster
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-xhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index 0fa814e..8d9cfe8 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -3636,7
From: Pantelis Koukousoulas
Replace magic constants in device bmAttributes with symbolic ones
from Linux kernel ch9.h
Signed-off-by: Pantelis Koukousoulas
Signed-off-by: Gerd Hoffmann
---
hw/usb/desc.c | 2 +-
hw/usb/dev-audio.c| 2 +-
hw/usb/dev-bluetooth.c
Allow the scheduled transfer time be a bit behind, to
compensate for latencies. Without this xhci will wait
way to often for the mfindex wraparound, assuming the
scheduled time is in the future just because qemu is
a bit behind in processing the iso transfer requests.
Signed-off-by: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann
---
hw/usb/hcd-uhci.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c
index ad814b5..0820244 100644
--- a/hw/usb/hcd-uhci.c
+++ b/hw/usb/hcd-uhci.c
@@ -252,9 +252,11 @@ static bool uhci_queue_verify(UHCIQueue *queue, uint32_
On 02/18/2014 07:39 AM, Luiz Capitulino wrote:
> This commit updates the status for the HMP, QAPI and QMP trees from
> "Supported" to "Maintained".
>
> In practice this means that patch review and pull requests may take
> longer. Also, I'll rely more on reviewers such as Eric Blake so that
> I'm a
fwrite() returns the number of items written. But when there is one
error, it can return a short write.
In the particular bug that I was tracking, I did a migration to a
read-only filesystem. And it was able to finish the migration
correctly. fwrite() never returned a negative error code, nor z
On Tue, Feb 18, 2014 at 03:11:37PM +, Peter Maydell wrote:
> On 18 February 2014 15:10, Riku Voipio wrote:
> > On Mon, Feb 17, 2014 at 06:55:34PM +, Peter Maydell wrote:
> >> Fix two issues in error handling in target_to_host_semarray():
> >> * don't leak the host_array buffer if lock_use
> Am 18.02.2014 um 16:45 schrieb Cornelia Huck :
>
> On Tue, 18 Feb 2014 16:12:08 +0100
> Cornelia Huck wrote:
>
>> On Tue, 18 Feb 2014 17:03:27 +0200
>> "Michael S. Tsirkin" wrote:
>>
On Tue, Feb 18, 2014 at 03:48:38PM +0100, Alexander Graf wrote:
> On 02/18/2014 01:38 PM, Greg Kur
On 17 February 2014 01:20, Alistair Francis wrote:
> This patch implements the ARM PMCCNTR register including
> the disable and reset components of the PMCR register.
>
> Signed-off-by: Alistair Francis
> ---
> This patch assumes that non-invasive debugging is not permitted
> when determining if
On 02/11/2014 05:00 PM, Juan Quintela wrote:
> fwrite() returns the number of items written. But when there is one
> error, it can return a short write.
>
> In the particular bug that I was tracking, I did a migration to a
> read-only filesystem. And it was able to finish the migration
> correct
On 02/18/2014 08:56 AM, Juan Quintela wrote:
> fwrite() returns the number of items written. But when there is one
> error, it can return a short write.
>
> In the particular bug that I was tracking, I did a migration to a
> read-only filesystem. And it was able to finish the migration
> correct
Il 18/02/2014 13:33, Vincent KHERBACHE ha scritto:
diff --git a/kvm-all.c b/kvm-all.c
index 2ca9143..f104f87 100644
--- a/kvm-all.c
+++ b/kvm-all.c
@@ -355,7 +355,7 @@ static int kvm_set_migration_log(int enable)
{
KVMState *s = kvm_state;
KVMSlot *mem;
-int i, err;
+int i, err
On Tue, 18 Feb 2014 17:02:18 +0100
Alexander Graf wrote:
>
>
> > Am 18.02.2014 um 16:45 schrieb Cornelia Huck :
> >
> > On Tue, 18 Feb 2014 16:12:08 +0100
> > Cornelia Huck wrote:
> >
> >> On Tue, 18 Feb 2014 17:03:27 +0200
> >> "Michael S. Tsirkin" wrote:
> >>
> On Tue, Feb 18, 2014
On 02/18/2014 05:17 PM, Cornelia Huck wrote:
On Tue, 18 Feb 2014 17:02:18 +0100
Alexander Graf wrote:
Am 18.02.2014 um 16:45 schrieb Cornelia Huck :
On Tue, 18 Feb 2014 16:12:08 +0100
Cornelia Huck wrote:
On Tue, 18 Feb 2014 17:03:27 +0200
"Michael S. Tsirkin" wrote:
On Tue, Feb 18, 2
Am 06.02.2014 16:08, schrieb Markus Armbruster:
> From: Alexander Graf
>
> When we have 2 separate qdev devices that both create a qbus of the
> same type without specifying a bus name or device name, we end up
> with two buses of the same name, such as ide.0 on the Mac machines:
>
> dev: maci
On Tue, 18 Feb 2014 13:33:17 +0200
"Michael S. Tsirkin" wrote:
> On Tue, Feb 18, 2014 at 12:10:27PM +0100, Igor Mammedov wrote:
> > On Mon, 17 Feb 2014 13:02:18 +0200
> > "Michael S. Tsirkin" wrote:
> >
> > > On Mon, Feb 17, 2014 at 11:33:23AM +0100, Igor Mammedov wrote:
> > > > On Sun, 16 Feb
Am 10.02.2014 17:48, schrieb Michael S. Tsirkin:
> From: Igor Mammedov
>
> Currently it's possible to make PCIDevice not hotpluggable
> by using no_hotplug field of PCIDeviceClass. However it
> limits this only to PCI devices and prevents from
> generalizing hotplug code.
>
> So add similar fiel
On Mon, 17 Feb 2014 09:32:35 +0100
Gerd Hoffmann wrote:
> On So, 2014-02-16 at 17:53 +0200, Michael S. Tsirkin wrote:
> > On Fri, Feb 07, 2014 at 01:51:27PM +0100, Igor Mammedov wrote:
> > > Since introduction of PCIHP, it became problematic to
> > > punch hole in PCI0._CRS statically since PCI h
Stefan Hajnoczi writes:
> v2:
> * Don't call qtest_end() from SIGABRT handler to avoid reentrancy [Paolo]
> * Use sigemptyset() to avoid assumption about signal mask [Markus]
> * if (fd != -1) close(fd) is no longer necessary [Markus]
>
> This series prevents the following qtest issues:
>
> 1.
On 13 February 2014 14:26, Peter Maydell wrote:
> +static void init_cpus(const char *cpu_model, const char *privdev,
> + hwaddr periphbase, qemu_irq *pic)
> +{
> +ObjectClass *cpu_oc = cpu_class_by_name(TYPE_ARM_CPU, cpu_model);
> +DeviceState *dev;
> +SysBusDevice
Sometimes is not enough to get property's value,
but it is needed to know if the value was actually set.
This is especially useful when querying bool properties
and having different defaults on different scenarios.
Signed-off-by: Marcel Apfelbaum
---
include/qom/object.h | 11 +++
qom/o
Signed-off-by: Janne Grunau
---
linux-user/main.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/linux-user/main.c b/linux-user/main.c
index cabc9e1..9192977 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -953,7 +953,8 @@ static int do_strex_a64(CPUARMState *
On Mon, 17 Feb 2014 09:29:20 +0100
Gerd Hoffmann wrote:
> On Fr, 2014-02-07 at 13:51 +0100, Igor Mammedov wrote:
> > Since introduction of PCIHP, it became problematic to
> > punch hole in PCI0._CRS statically since PCI hotplug
> > region size became runtime changeable.
> >
> > So replace static
On 18 February 2014 16:46, Janne Grunau wrote:
> Signed-off-by: Janne Grunau
> ---
> linux-user/main.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Peter Maydell
-- PMM
Il 18/02/2014 17:46, Marcel Apfelbaum ha scritto:
Sometimes is not enough to get property's value,
but it is needed to know if the value was actually set.
This is especially useful when querying bool properties
and having different defaults on different scenarios.
I think this needs to go toge
"Dr. David Alan Gilbert (git)" wrote:
> From: "Dr. David Alan Gilbert"
>
> Push zero'd pages into the XBZRLE cache
> A page that was cached by XBZRLE, zero'd and then XBZRLE'd again
> was being compared against a stale cache value
>
> Don't use 'qemu_put_buffer_async' to put pages from th
On Tue, 18 Feb 2014 17:35:16 +0100
Andreas Färber wrote:
> Am 10.02.2014 17:48, schrieb Michael S. Tsirkin:
> > From: Igor Mammedov
> >
> > Currently it's possible to make PCIDevice not hotpluggable
> > by using no_hotplug field of PCIDeviceClass. However it
> > limits this only to PCI devices
Juan Quintela writes:
> fwrite() returns the number of items written. But when there is one
> error, it can return a short write.
>
> In the particular bug that I was tracking, I did a migration to a
> read-only filesystem. And it was able to finish the migration
> correctly. fwrite() never re
Move setting DeviceClass.hotpluggable default from
class_base_init() to device's own class_init().
Reported-by: Andreas Färber
Signed-off-by: Igor Mammedov
---
hw/core/qdev.c | 16
1 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/core/qdev.c b/hw/core/qdev.c
On Tue, 18 Feb 2014, Paolo Bonzini wrote:
> Il 18/02/2014 15:25, Stefano Stabellini ha scritto:
> > On Tue, 18 Feb 2014, Paolo Bonzini wrote:
> > > Il 18/02/2014 13:45, Stefano Stabellini ha scritto:
> > > > Disk unplug: hw/ide/piix.c:pci_piix3_xen_ide_unplug (see the beginning
> > > > of the email
On Tue, 2014-02-18 at 17:51 +0100, Paolo Bonzini wrote:
> Il 18/02/2014 17:46, Marcel Apfelbaum ha scritto:
> > Sometimes is not enough to get property's value,
> > but it is needed to know if the value was actually set.
> >
> > This is especially useful when querying bool properties
> > and having
j...@jannau.net writes:
> Signed-off-by: Janne Grunau
> ---
> linux-user/main.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/linux-user/main.c b/linux-user/main.c
> index cabc9e1..9192977 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -953,7 +9
Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto:
It is used to replace qemu_opt_get_bool that provides a
parameter for a default value. In this case we need to
differentiate "no value" from "false."
But what would the getter return in that case? If possible, it's better
to initialize to the
bdrv_file_open() is now nearly a subset of bdrv_open(), except for the
fact that bdrv_file_open() is for protocols and bdrv_open() for block
drivers. It is possible to use bdrv_file_open() with a block driver, but
in that case that block driver must be explicitly specified.
Due to these great simi
Allow bdrv_open() to handle references to existing block devices just as
bdrv_file_open() is already capable of.
Signed-off-by: Max Reitz
---
block.c | 44 +---
block/qcow2.c | 4 ++--
block/vmdk.c | 3 ++-
block/vvfat.c
Add the bdrv_open() option BDRV_O_PROTOCOL which results in passing the
call to bdrv_file_open(). Additionally, make bdrv_file_open() static and
therefore bdrv_open() the only way to call it.
Consequently, all existing calls to bdrv_file_open() have to be adjusted
to use bdrv_open() with the BDRV_
This option is now unnecessary since specifying BDRV_O_PROTOCOL as flag
will do exactly the same.
Signed-off-by: Max Reitz
Reviewed-by: Benoit Canet
Reviewed-by: Kevin Wolf
---
block.c | 27 ---
block/blkdebug.c | 2 +-
block/blkverify.c | 4 ++-
The fail paths of bdrv_file_open() and bdrv_open() naturally exhibit
similarities, thus it is possible to reuse the one from bdrv_open() and
shorten the one in bdrv_file_open() accordingly.
Also, setting bs->options in bdrv_file_open() is not necessary if it is
already done in bdrv_open().
Signed
On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote:
> From: Beno??t Canet
>
> Example of command line:
>
> -drive if=virtio,driver=quorum,\
> children.0.file.filename=1.raw,\
> children.0.node-name=1.raw,\
> children.0.driver=raw,\
> children.1.file.filename=2.raw,\
> children.1.node-
Change bdrv_file_open() to take a simple pointer to an already existing
BDS instead of an indirect one. The BDS will be created in bdrv_open()
if necessary.
Signed-off-by: Max Reitz
Reviewed-by: Benoit Canet
Reviewed-by: Kevin Wolf
---
block.c | 24 +---
1 file changed, 13
Remove the reference parameter and the related handling code from
bdrv_file_open(), since it exists in bdrv_open() now as well.
Signed-off-by: Max Reitz
Reviewed-by: Benoit Canet
Reviewed-by: Kevin Wolf
---
block.c | 32 +++-
1 file changed, 7 insertions(+), 25 dele
Make bdrv_open() take a pointer to a BDS pointer, similarly to
bdrv_file_open(). If a pointer to a NULL pointer is given, bdrv_open()
will create a new BDS with an empty name; if the BDS pointer is not
NULL, that existing BDS will be reused (in the same way as bdrv_open()
already did).
Signed-off-
The Tuesday 18 Feb 2014 à 17:37:08 (+), Leandro Dorileo wrote :
> On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote:
> > From: Beno??t Canet
> >
> > Example of command line:
> >
> > -drive if=virtio,driver=quorum,\
> > children.0.file.filename=1.raw,\
> > children.0.node-name=1.r
On 18.02.2014 18:37, Leandro Dorileo wrote:
On Tue, Feb 18, 2014 at 01:11:26PM +0100, Beno??t Canet wrote:
From: Beno??t Canet
Example of command line:
-drive if=virtio,driver=quorum,\
children.0.file.filename=1.raw,\
children.0.node-name=1.raw,\
children.0.driver=raw,\
children.1.file.filena
Am 18.02.2014 18:26, schrieb Paolo Bonzini:
> Il 18/02/2014 18:11, Marcel Apfelbaum ha scritto:
>> It is used to replace qemu_opt_get_bool that provides a
>> parameter for a default value. In this case we need to
>> differentiate "no value" from "false."
>
> But what would the getter return in tha
On 18.02.2014 13:11, Benoît Canet wrote:
From: Benoît Canet
Writes are mirrored num_children times on num_children devices.
Signed-off-by: Benoit Canet
---
block/quorum.c | 103 +
1 file changed, 103 insertions(+)
Since you apparent
Commit 40d225009ef accidentally changed the behaviour of
gic_acknowledge_irq() for the NVIC. The NVIC doesn't have SGIs,
so this meant we hit an assertion:
gic_acknowledge_irq: Assertion `s->sgi_pending[irq][cpu] != 0' failed.
Return NVIC acknowledge-irq to its previous behaviour, like 11MPCore.
Le 18/02/2014 17:16, Paolo Bonzini a écrit :
> This patch is not correct, because it introduces another one: if dirty
> logging was enabled on the memory region (kvm_dirty_pages_log_change),
> it will be disabled after migration.
Yes you're right that was my initial goal, I didn't distinguish the
The fail and success paths of bdrv_file_open() may be further shortened
by reusing code already existent in bdrv_open(). This includes
bdrv_file_open() not taking the reference to options which allows the
removal of QDECREF(options) in that function.
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wo
On 18.02.2014 13:11, Benoît Canet wrote:
From: Benoît Canet
This patchset enables the core of the quorum mechanism.
The num_children reads are compared to get the majority version and if this
version exists more than threshold times the guest won't see the error at all.
If a block is corrupted
On 18/02/14 4:45 AM, Peter Maydell wrote:
On 18 February 2014 00:36, Brad Smith wrote:
Just one issue... just curious why my last name is missing
from the commit?
Ah, we've run into a bug in patchwork. I downloaded your patch:
http://patchwork.ozlabs.org/patch/299656/
but patchwork reconst
On 18.02.2014 13:11, Benoît Canet wrote:
From: Benoît Canet
Makes a vote to select error if any.
Signed-off-by: Benoit Canet
---
block/quorum.c | 28
1 file changed, 28 insertions(+)
The same thing as for patch 3 (unchanged from v17):
Reviewed-by: Max Reitz
On 18.02.2014 13:11, Benoît Canet wrote:
From: Benoît Canet
Example of command line:
-drive if=virtio,driver=quorum,\
children.0.file.filename=1.raw,\
children.0.node-name=1.raw,\
children.0.driver=raw,\
children.1.file.filename=2.raw,\
children.1.node-name=2.raw,\
children.1.driver=raw,\
chil
Am 18.02.2014 17:56, schrieb Igor Mammedov:
> Move setting DeviceClass.hotpluggable default from
> class_base_init() to device's own class_init().
>
> Reported-by: Andreas Färber
> Signed-off-by: Igor Mammedov
Thanks, applied to qom-next:
https://github.com/afaerber/qemu-cpu/commits/qom-next
A
Hi Tom,
I would love to test your latest non-upstream qemu patches, because
the better emulation of VSX may enable me to get libguestfs working on
ppc64p7.
Do you have a public git tree anywhere which contains something
testable? The published patches no longer cleanly apply to qemu.git.
Rich.
Am 18.02.2014 13:38, schrieb Greg Kurz:
> On Fri, 14 Feb 2014 12:59:49 +0100
> Andreas Färber wrote:
>
>> Hi,
>>
>> [...]
>>
>> It might've helped if Rusty had actually used our
>> scripts/get_maintainer.pl script to CC people. While Anthony seems to
>> have reviewed some patches (usually Reviewe
On Tue, Feb 18, 2014 at 11:21:33AM +0100, Gerd Hoffmann wrote:
> > Unfortunately, if we change the smbios in SeaBIOS, it will show up on
> > all machine types that use the new version of SeaBIOS. We've had
> > issues with this type of change before as various OSes react
> > differently to the chan
101 - 200 of 253 matches
Mail list logo
