[Qemu-devel] [PATCH v2 0/3] Trivial patches

2014-03-18 Thread Maria Kustova
These patches are the part of OPW application. Two of them update help messages of qemu-io utility. And last one replaces fprintf() with error_setg() in curl.c Changes v1 - v2: * Removed trailing \n from the error string in error_setg() call Maria Kustova (3): qemu-io-cmds: Fixed typo in

[Qemu-devel] [PATCH v2 3/3] qemu-io: Extended --cmd description in usage text

2014-03-18 Thread Maria Kustova
It's not clear from the usage description that --cmd option accepts its argument as a string, so any special symbols have to be quoted from the shell. Updates in usage text: - Specified parameter format for --cmd option. - Added an instruction how to get help for --cmd option. Signed-off-by:

[Qemu-devel] [PATCH v2 1/3] qemu-io-cmds: Fixed typo in example for writev.

2014-03-18 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- qemu-io-cmds.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-io-cmds.c b/qemu-io-cmds.c index f1de24c..5707bda 100644 --- a/qemu-io-cmds.c +++ b/qemu-io-cmds.c @@ -1087,7 +1087,7 @@ writev_help(void) writes a range of

[Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API.

2014-03-18 Thread Maria Kustova
Signed-off-by: Maria Kustova mari...@catit.be --- Changes v1 - v2: * Removed trailing \n from the error string --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index 3494c6d..359637e 100644 --- a/block/curl.c +++ b/block/curl.c @@

Re: [Qemu-devel] [PATCH] linux-user: don't warn on missing capget/capset

2014-03-18 Thread Riku Voipio
On 17 March 2014 22:17, Andreas Färber afaer...@suse.de wrote: Am 17.03.2014 12:55, schrieb riku.voi...@linaro.org: From: Riku Voipio riku.voi...@linaro.org some people get numerous unimplemented capget/capset warnings. Since qemu linux-user is not secure to begin with, just skip the

Re: [Qemu-devel] [ANNOUNCE] QEMU 2.0.0-rc0 is now available

2014-03-18 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 19:30 +0100, Andreas Färber wrote: Hi, Am 14.03.2014 04:19, schrieb Anthony Liguori: On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.0 release. This release is meant for testing purposes and should not

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot access memory at address 0x88013fffd3a0 (gdb) I suppose this is x86-64, not

[Qemu-devel] [PULL 1/1] ui/vnc: fix vmware VGA incompatiblities

2014-03-18 Thread Gerd Hoffmann
From: Peter Lieven p...@kamp.de this fixes invalid rectangle updates observed after commit 12b316d with the vmware VGA driver. The issues occured because the server and client surface update seems to be out of sync at some points and the max width of the surface is not dividable by

[Qemu-devel] [PULL for-2.0 0/1] vnc bugfix

2014-03-18 Thread Gerd Hoffmann
Hi, Most recent vnc update had a regression with vmware vga. Here is the fix for it. please pull, Gerd The following changes since commit 315b59344126beab85a62b53582794b14436a5a4: Merge remote-tracking branch 'remotes/borntraeger/tags/kvm-s390-20140317' into staging (2014-03-17 22:31:33

Re: [Qemu-devel] [PATCH v2 1/5] linux-headers: add new interfaces

2014-03-18 Thread Cornelia Huck
On Mon, 17 Mar 2014 18:24:08 + Peter Maydell peter.mayd...@linaro.org wrote: On 17 March 2014 18:11, Cornelia Huck cornelia.h...@de.ibm.com wrote: Per-vm capability enablement, adapter interrupt sources, irq routing on s390. Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] ahci: fix sysbus support

2014-03-18 Thread Paolo Bonzini
Il 11/02/2014 01:32, Peter Maydell ha scritto: @@ -1311,7 +1312,7 @@ static const VMStateDescription vmstate_sysbus_ahci = { .name = sysbus-ahci, .unmigratable = 1, /* Still buggy under I/O load */ .fields = (VMStateField []) { -VMSTATE_AHCI(ahci, AHCIPCIState), +

Re: [Qemu-devel] [PATCH v3 0/5] gtk: Fix deprecation warnings, misc bug fixes

2014-03-18 Thread Gerd Hoffmann
On Mo, 2014-03-17 at 16:06 -0400, Cole Robinson wrote: First patch documents a configure option. Next 3 patches fix deprecation warnings on gtk 3.10. Last patch changes the 'quit' shortcut use the ctrl+alt convention. Queued for 2.1 devel cycle. thanks, Gerd

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Paolo Bonzini
Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot access memory at address 0x88013fffd3a0

Re: [Qemu-devel] [PATCH v22 03/25] improve some functions in qemu-option.c

2014-03-18 Thread Chunyan Liu
2014-03-17 5:19 GMT+08:00 Leandro Dorileo l...@dorileo.org: Hi Chunyan, On Tue, Mar 11, 2014 at 09:00:04PM +, Leandro Dorileo wrote: Hi, On Tue, Mar 11, 2014 at 03:26:51PM +0800, Chunyan Liu wrote: 2014-03-11 5:21 GMT+08:00 Eric Blake ebl...@redhat.com: On 03/10/2014 02:29

Re: [Qemu-devel] [PATCH v22 03/25] improve some functions in qemu-option.c

2014-03-18 Thread Chunyan Liu
2014-03-18 3:58 GMT+08:00 Leandro Dorileo l...@dorileo.org: Hi, On Mon, Mar 10, 2014 at 03:31:39PM +0800, Chunyan Liu wrote: Improve opt_get and opt_set group of functions. For opt_get, check and handle NULL input; for opt_set, when set to an existing option, rewrite the option with

Re: [Qemu-devel] [PATCH v2 3/5] KVM: s390: adapter interrupt sources

2014-03-18 Thread Heiko Carstens
On Mon, Mar 17, 2014 at 07:11:37PM +0100, Cornelia Huck wrote: Add a new interface to register/deregister sources of adapter interrupts identified by an unique id via the flic. Adapters may also be maskable and carry a list of pinned pages. These adapters will be used by irq routing later.

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in make clean

2014-03-18 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Am 17.03.2014 09:30, schrieb Markus Armbruster: Stefan Weil s...@weilnetz.de writes: Am 14.03.2014 09:38, schrieb Fam Zheng: DANGEROUS: don't try it before you read to the end. A first make distclean will unset $(DSOSUF), a following make distclean

Re: [Qemu-devel] [PATCH v2 3/5] KVM: s390: adapter interrupt sources

2014-03-18 Thread Cornelia Huck
On Tue, 18 Mar 2014 09:11:19 +0100 Heiko Carstens heiko.carst...@de.ibm.com wrote: On Mon, Mar 17, 2014 at 07:11:37PM +0100, Cornelia Huck wrote: Add a new interface to register/deregister sources of adapter interrupts identified by an unique id via the flic. Adapters may also be maskable

Re: [Qemu-devel] [PATCH] block: Add error handling to bdrv_invalidate_cache()

2014-03-18 Thread Kevin Wolf
Am 12.03.2014 um 16:00 hat Kevin Wolf geschrieben: If it returns an error, the migrated VM will not be started, but qemu exits with an error message. Signed-off-by: Kevin Wolf kw...@redhat.com Applied to the block branch. Kevin

Re: [Qemu-devel] [PATCH v2 0/3] Trivial patches

2014-03-18 Thread Kevin Wolf
Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben: These patches are the part of OPW application. Two of them update help messages of qemu-io utility. And last one replaces fprintf() with error_setg() in curl.c Changes v1 - v2: * Removed trailing \n from the error string in error_setg()

Re: [Qemu-devel] [PATCH v2 1/5] KVM: eventfd: Fix lock order inversion.

2014-03-18 Thread Cornelia Huck
On Mon, 17 Mar 2014 22:55:49 +0100 Christian Borntraeger borntrae...@de.ibm.com wrote: On 17/03/14 19:11, Cornelia Huck wrote: When registering a new irqfd, we call its -poll method to collect any event that might have previously been pending so that we can trigger it. This is done under

Re: [Qemu-devel] [PATCH] Makefile: Don't find and delete when $(DSOSUF) is empty in make clean

2014-03-18 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 17 March 2014 18:51, Andreas Färber afaer...@suse.de wrote: Am 17.03.2014 09:30, schrieb Markus Armbruster: Stefan Weil s...@weilnetz.de writes: Am 14.03.2014 09:38, schrieb Fam Zheng: DANGEROUS: don't try it before you read to the end. A

[Qemu-devel] [PATCH v2 1/7] target-arm: Decouple AArch64 cp registers

2014-03-18 Thread Alvise Rigo
Relying on the AArch64 views for the migration of cp registers values makes impossible to have a successful migration between TCG and KVM because the latter uses the AArch32 indexes format: force the AArch32 processor to not generate the cp registers belonging to the 64bit architecture.

Re: [Qemu-devel] [PATCH v2 3/3] qemu-io: Extended --cmd description in usage text

2014-03-18 Thread Kevin Wolf
Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben: It's not clear from the usage description that --cmd option accepts its argument as a string, so any special symbols have to be quoted from the shell. For future patches, please make sure to wrap your lines in the commit message at ideally

[Qemu-devel] [PATCH v2 4/7] target-arm: Exclude IC bit from L2CTLR

2014-03-18 Thread Alvise Rigo
The real hardware seems to not set the Interrupt Controller bit of the L2CTLR cp register; on the contrary it could set some other bits regarding RAM features that are not modelled in TCG, so we can mask them out. Signed-off-by: Alvise Rigo a.r...@virtualopensystems.com --- target-arm/cpu.c | 8

[Qemu-devel] [PATCH v2 0/7] target-arm: KVM to TCG migration

2014-03-18 Thread Alvise Rigo
QEMU at the moment doesn't allow the migration between KVM and TCG, in both directions. This limitation is due first of all to the different set of coprocessor registers supported by KVM and TCG, but also in the way the coprocessors values are copied from the incoming data to the local QEMU

[Qemu-devel] [PATCH v2 2/7] target-arm: Migrate CCSIDR registers

2014-03-18 Thread Alvise Rigo
Since KVM migrates the values of the CCSIDR registes as cp17 coprocessors registers values, we do the same in TCG, in such a way to not let the migration fail. The values of these registers will be read by the guest with the usual mechanism (writing into CSSELR to select the desired Cache Size ID

[Qemu-devel] [PATCH v2 3/7] target-arm: Add a way to mask some

2014-03-18 Thread Alvise Rigo
One of the issues blocking the migration from KVM to TCG is that the former processor reads the coprocessors values directly from the underlying hardware. TCG however, for the way it emulates some registers, is not able to verify the incoming values, failing the migration. Add a mask to the

[Qemu-devel] [PATCH v2 6/7] target-arm: Added ADFSR/AIFSR and REVIDR

2014-03-18 Thread Alvise Rigo
These registers are required in TCG because they are migrated by KVM: their absence from the cpreg table leads to a migration failure. Signed-off-by: Alvise Rigo a.r...@virtualopensystems.com --- target-arm/cpu.h| 1 + target-arm/helper.c | 9 + 2 files changed, 10 insertions(+)

[Qemu-devel] [PATCH v2 5/7] target-arm: Make TTBR0/1 and TTBRC cp

2014-03-18 Thread Alvise Rigo
Revisit the definitions of the cp registers TTBR0/1 and TTBRC in such a way to use the AArch32 ids format when the guest is using a 32bit model. Signed-off-by: Alvise Rigo a.r...@virtualopensystems.com --- target-arm/helper.c | 38 +++--- 1 file changed, 27

[Qemu-devel] [PATCH v2 7/7] target-arm: Minor cp registers changes

2014-03-18 Thread Alvise Rigo
Minor changes still required to enable KVM - TCG migration: * The MPIDR register is now migrated, as KVM does. * Implemented the SMP bit of the AUXCR register, the other bits are masked through attr_mask because not supported. * Added the attr_mask to ID_PFR0 to exclude the

Re: [Qemu-devel] [PATCH v4 6/7] raven: fix PCI bus accesses with size 1

2014-03-18 Thread Artyom Tarasenko
On Mon, Mar 17, 2014 at 11:00 PM, Hervé Poussineau hpous...@reactos.org wrote: Signed-off-by: Hervé Poussineau hpous...@reactos.org Reviewed-by: Artyom Tarasenko atar4q...@gmail.com --- hw/pci-host/prep.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 1/2 V4] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details.

2014-03-18 Thread Stefan Hajnoczi
On Mon, Mar 10, 2014 at 02:21:34PM +0100, Romain Dolbeau wrote: Anyway, I probably won't be able to update the patch, I've already spent a lot more time on it than I should have :-/ Your decision. The patches can't be merged until the review comments have been resolved. Stefan

Re: [Qemu-devel] [PATCH v2 2/3] block: Replaced old error handling with error reporting API.

2014-03-18 Thread Kevin Wolf
Am 18.03.2014 um 06:59 hat Maria Kustova geschrieben: Signed-off-by: Maria Kustova mari...@catit.be --- Changes v1 - v2: * Removed trailing \n from the error string --- block/curl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/curl.c b/block/curl.c index

Re: [Qemu-devel] [PATCH] configure: Show trace output file conditionally

2014-03-18 Thread Stefan Hajnoczi
On Fri, Mar 14, 2014 at 09:09:10PM +0100, Stefan Weil wrote: It is only used with the simple trace backend. Signed-off-by: Stefan Weil s...@weilnetz.de --- configure |2 ++ 1 file changed, 2 insertions(+) Thanks, applied to my tracing-next tree:

Re: [Qemu-devel] [PATCH] vl.c: Fix memory leak in qemu_register_machine

2014-03-18 Thread Markus Armbruster
Marcel Apfelbaum marce...@redhat.com writes: On Mon, 2014-03-17 at 22:53 +0100, Christian Borntraeger wrote: since commit 261747f176f6 (vl: Use MachineClass instead of global QEMUMachine list) valgrind complains about the following: ==54082== 57 bytes in 3 blocks are definitely lost in loss

Re: [Qemu-devel] qapi-commands.py generates code that uses uninitialized variables

2014-03-18 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: This is something clang's -fsanitize=undefined spotted. The code generated by qapi-commands.py in qmp-marshal.c for qmp_marshal_* functions where there are some optional arguments looks like this: bool has_force = false; bool force;

Re: [Qemu-devel] [PATCH v2 2/2] qcow2: Fix fail path in realloc_refcount_block()

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 23:04 hat Max Reitz geschrieben: If qcow2_alloc_clusters() fails, new_offset and ret will both be negative after the fail label, thus passing the first if condition and subsequently resulting in a call of qcow2_free_clusters() with an invalid (negative) offset parameter. Fix

Re: [Qemu-devel] [PATCH v2 0/2] qcow2: Fix return path of realloc_refcount_block()

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 23:04 hat Max Reitz geschrieben: This series fixes the fail path of the static function realloc_refcount_block() in block/qcow2-refcount.c which is used for repairing corrupted image files. While doing so, the whole return path is cleaned up and the comment describing the

Re: [Qemu-devel] [PATCH v2 0/3] Trivial patches

2014-03-18 Thread Stefan Hajnoczi
On Tue, Mar 18, 2014 at 09:59:16AM +0400, Maria Kustova wrote: These patches are the part of OPW application. Two of them update help messages of qemu-io utility. And last one replaces fprintf() with error_setg() in curl.c Changes v1 - v2: * Removed trailing \n from the error string in

[Qemu-devel] [PATCH] block: Remove -errno return value from bdrv_assign_node_name

2014-03-18 Thread Kevin Wolf
It takes an errp argument. That's enough for error handling. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index acb70fd..b4f3f77 100644 --- a/block.c +++ b/block.c @@ -783,18

Re: [Qemu-devel] [PATCH v2] convert fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create()

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 15:59 hat Stefan Hajnoczi geschrieben: On Sat, Mar 15, 2014 at 03:05:23PM +0530, Aakriti Gupta wrote: This patch converts fprintf() calls to error_setg() in block/qed.c:bdrv_qed_create() (error_setg() is part of error reporting API in include/qapi/error.h)

Re: [Qemu-devel] [PATCH for-2.0] block/nfs: bump libnfs requirement to 1.9.3

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 09:37 hat Peter Lieven geschrieben: libnfs prior to 1.9.3 contains a bug that will report wrong transfer sizes if the file offset grows beyond 4GB and RPC responses are received out of order. this error is not detectable and fixable in qemu. additionally 1.9.3 introcudes

Re: [Qemu-devel] [PATCH for-2.0] block/nfs: report errors from libnfs

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 09:37 hat Peter Lieven geschrieben: if an NFS operation fails we should report what libnfs knows about the failure. It is likely more than just an error code. Signed-off-by: Peter Lieven p...@kamp.de Thanks, applied to the block branch for qemu 2.0. Kevin

Re: [Qemu-devel] [PATCH] block: Remove -errno return value from bdrv_assign_node_name

2014-03-18 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: It takes an errp argument. That's enough for error handling. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/block.c b/block.c index acb70fd..b4f3f77

Re: [Qemu-devel] [Qemu-trivial] [PULL 0/4] Travis Updates

2014-03-18 Thread Alex Bennée
Michael Tokarev m...@tls.msk.ru writes: 12.03.2014 18:13, alex.ben...@linaro.org wrote: From: Alex Bennée alex.ben...@linaro.org are available in the git repository at: g...@github.com:stsquad/qemu.git travis-updates for you to fetch changes up to

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-18 Thread Markus Armbruster
Cc'ing a few interested parties. Hamilton, Peter A. peter.hamil...@jhuapl.edu writes: Hi qemu-devel, I am a member of a development team based out of the Johns Hopkins University Applied Physics Laboratory. Over the past year and a half, we've been working with the OpenStack community on

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot

Re: [Qemu-devel] [PATCH v3] net: L2TPv3 transport

2014-03-18 Thread Stefan Hajnoczi
On Tue, Mar 11, 2014 at 12:45:30PM +, anton.iva...@kot-begemot.co.uk wrote: +/* This protocol number is passed getaddrinfo(), and not + * used directly. If you give gettaddrinfo() what one is + * supposed to give - INET, RAW, 0, the result is not + * set correctly. + * Setting the args to

Re: [Qemu-devel] [PATCH] block: Remove -errno return value from bdrv_assign_node_name

2014-03-18 Thread Kevin Wolf
Am 18.03.2014 um 11:09 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: It takes an errp argument. That's enough for error handling. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 21 ++--- 1 file changed, 10 insertions(+), 11

Re: [Qemu-devel] [PATCH v3] net: L2TPv3 transport

2014-03-18 Thread Anton Ivanov (antivano)
On 18/03/14 10:44, Stefan Hajnoczi wrote: On Tue, Mar 11, 2014 at 12:45:30PM +, anton.iva...@kot-begemot.co.uk wrote: +/* This protocol number is passed getaddrinfo(), and not + * used directly. If you give gettaddrinfo() what one is + * supposed to give - INET, RAW, 0, the result is not

Re: [Qemu-devel] [PATCH] target-alpha: fix the braces

2014-03-18 Thread Paolo Bonzini
Il 17/03/2014 19:07, Richard Henderson ha scritto: On 03/17/2014 04:28 AM, Paolo Bonzini wrote: Conform to coding style, and avoid further occurrences of bugs due to misplaced braces. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- target-alpha/translate.c | 313

Re: [Qemu-devel] [PATCH] block: Remove -errno return value from bdrv_assign_node_name

2014-03-18 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 18.03.2014 um 11:09 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: It takes an errp argument. That's enough for error handling. Signed-off-by: Kevin Wolf kw...@redhat.com --- block.c | 21 ++--- 1 file

Re: [Qemu-devel] [PATCH 03/10] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-03-18 Thread Gonglei (Arei)
Sorry for late. @@ -161,6 +171,11 @@ int cache_insert(PageCache *cache, uint64_t addr, const uint8_t *pdata) /* actual update of entry */ it = cache_get_by_addr(cache, addr); +if ((it-it_data != NULL) (it-it_age + +CACHED_PAGE_LIFETIME current_age)) { +

Re: [Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge process

2014-03-18 Thread Gonglei (Arei)
'already got some feedback earlier on this and had this task in the list of things to work on... :) Having the throttling start with some per-defined degree and then have that degree gradually increase ...either a) automatically as shown in Juan's example above (or) b) via

[Qemu-devel] [PATCH v3 01/10] XBZRLE: Fix one XBZRLE corruption issues

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com The page may not be inserted into cache after executing save_xbzrle_page. In case of failure to insert, the original page should be sent rather than the page in the cache. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei

[Qemu-devel] [PATCH v3 00/10] migration: Optimizate the xbzrle and fix two corruption issues

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com V2--V3 * rename the bitmap_sync_cnt to bitmap_sync_counter * expose xbzrle cache miss rate V1--V2 * expose the counter that logs the times of updating the dirty bitmap to end user. a. Optimization the xbzrle remarkable decrease the cache misses. The

[Qemu-devel] [PATCH v3 07/10] migration: Fix the migrate auto converge process

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com It is inexact and complex to use the migration transfer speed to determine whether migration is converging. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 26 +++--- 1

[Qemu-devel] [PATCH v3 04/10] migration: expose xbzrle cache miss rate

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com expose xbzrle cache miss rate Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 18 ++ hmp.c | 2 ++ include/migration/migration.h |

[Qemu-devel] [PATCH v3 10/10] XBZRLE: update the doc of XBZRLE

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com update the doc of XBZRLE Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- docs/xbzrle.txt | 7 +++ 1 file changed, 7 insertions(+) diff --git a/docs/xbzrle.txt b/docs/xbzrle.txt index cc3a26a..cdf1e3e

[Qemu-devel] [PATCH v3 02/10] migration: Add counters of updating the dirty bitmap

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com Add counters to log the times of updating the dirty bitmap. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 5 + 1 file changed, 5 insertions(+) diff --git a/arch_init.c b/arch_init.c

[Qemu-devel] [PATCH v3 03/10] migration: expose the bitmap_sync_counter to the end user

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com expose the counter that log the times of updating the dirty bitmap to end user. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- arch_init.c | 1 + hmp.c | 2 ++

[Qemu-devel] [PATCH v3 05/10] XBZRLE: optimize XBZRLE to decrease the cache missing

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com Avoid hot pages being replaced by others to remarkably decrease cache Sample results with the test program which quote from xbzrle.txt ran in vm:(migrate bandwidth:1GE and xbzrle cache size 8MB) the test program: include stdlib.h include stdio.h int

[Qemu-devel] [PATCH v3 09/10] migration: clear the dead code

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com clear the dead code Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 13 - page_cache.c | 58

[Qemu-devel] [PATCH v3 06/10] XBZRLE: rebuild the cache_is_cached function

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com Rebuild the cache_is_cached function by cache_get_by_addr. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- page_cache.c | 38 -- 1 file changed, 16 insertions(+), 22

Re: [Qemu-devel] [PATCH v3 0/5] qom: link property fixes

2014-03-18 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 09:51:19PM +0100, Stefan Hajnoczi wrote: v3: * Split first commit for easier reviewing [afaerber] * Turn bool argument into flags bitmask [pbonzini] * Rename set() callback to check() [pbonzini] * Rename object_property_default_set_link() to

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Juan Quintela
Le Tan tamlokv...@gmail.com wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it means. So, please, can anyone help me, telling me the mechanism or semantic of coroutine? Thanks! google, 1st hit, wikipedia:

[Qemu-devel] target-i386: guest variable shift by 0 provokes shift by -1

2014-03-18 Thread Peter Maydell
If you run 'make check' under clang's -fsanitize=undefined, then (among other things) the acpi test provokes these warnings: /home/petmay01/linaro/qemu-from-laptop/qemu/tcg/optimize.c:833:44: runtime error: shift exponent 18446744073709551615 is too large for 64-bit type 'tcg_target_ulong' (aka

Re: [Qemu-devel] semantics of qemu_peek_buffer ?

2014-03-18 Thread Juan Quintela
Dr. David Alan Gilbert dgilb...@redhat.com wrote: Hi Juan, What are the semantics of 'qemu_peek_buffer'? - is it supposed to guarantee (if there are no errors) that it will read 'size' bytes? (i.e. it should block) We are talking qemu, specifically migration. quarantee is always a

Re: [Qemu-devel] virtio device error reporting best practice?

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 15:49 hat Laszlo Ersek geschrieben: On 03/17/14 15:40, Peter Maydell wrote: On 17 March 2014 14:28, Laszlo Ersek ler...@redhat.com wrote: On 03/17/14 07:02, Dave Airlie wrote: The main reason I'm considering this stuff is for security reasons if the guest asks for

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Luiz Capitulino
On Tue, 18 Mar 2014 08:19:52 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a memory address, you will get an error from gdb: (gdb) p node_data[0]-node_id Cannot

[Qemu-devel] [PATCH v3 08/10] migration: optimize xbzrle by reducing data copy

2014-03-18 Thread arei.gonglei
From: ChenLiang chenlian...@huawei.com Reducing data copy can reduce cpu overhead. Signed-off-by: ChenLiang chenlian...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 8 +++- 1 file changed, 3 insertions(+), 5

[Qemu-devel] [PATCH v4 1/5] qom: split object_property_set_link()

2014-03-18 Thread Stefan Hajnoczi
The path resolution logic in object_property_set_link() should be a separate function. This makes the code easier to read and maintain. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qom/object.c | 59 +++ 1 file changed, 39

Re: [Qemu-devel] [PATCH v3 0/5] qom: link property fixes

2014-03-18 Thread Stefan Hajnoczi
On Wed, Mar 05, 2014 at 09:51:19PM +0100, Stefan Hajnoczi wrote: v3: * Split first commit for easier reviewing [afaerber] * Turn bool argument into flags bitmask [pbonzini] * Rename set() callback to check() [pbonzini] * Rename object_property_default_set_link() to

[Qemu-devel] [PATCH v4 0/5] v4:

2014-03-18 Thread Stefan Hajnoczi
v3: * Split first commit for easier reviewing [afaerber] * Turn bool argument into flags bitmask [pbonzini] * Rename set() callback to check() [pbonzini] * Rename object_property_default_set_link() to object_property_allow_set_link() * Rename qdev_prop_default_set_link() to

[Qemu-devel] [PATCH v4 5/5] virtio-rng: avoid default_backend refcount leak

2014-03-18 Thread Stefan Hajnoczi
QOM child properties take a reference to the object and release it when the property is deleted. Therefore we should unref the default_backend after we have added it as a child property. Cc: KONRAD Frederic fred.kon...@greensocs.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Markus Armbruster
Juan Quintela quint...@redhat.com writes: Le Tan tamlokv...@gmail.com wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it means. So, please, can anyone help me, telling me the mechanism or semantic of coroutine?

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Luiz Capitulino
On Tue, 18 Mar 2014 11:30:42 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more than 4GB of memory and try to look at a

[Qemu-devel] [PATCH v4 3/5] qom: make QOM link property unref optional

2014-03-18 Thread Stefan Hajnoczi
Some object_property_add_link() callers expect property deletion to unref the link property object. Other callers expect to manage the refcount themselves. The former are currently broken and therefore leak the link property object. This patch adds a flags argument to object_property_add_link()

[Qemu-devel] [PATCH v4 4/5] qom: add check() argument to object_property_add_link()

2014-03-18 Thread Stefan Hajnoczi
There are currently three types of object_property_add_link() callers: 1. The link property may be set at any time. 2. The link property of a DeviceState instance may only be set before realize. 3. The link property may never be set, it is read-only. Something similar can already be achieved

Re: [Qemu-devel] semantics of qemu_peek_buffer ?

2014-03-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: Dr. David Alan Gilbert dgilb...@redhat.com wrote: Hi Juan, What are the semantics of 'qemu_peek_buffer'? - is it supposed to guarantee (if there are no errors) that it will read 'size' bytes? (i.e. it should block) We are talking

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-18 Thread Stefan Hajnoczi
On Mon, Mar 17, 2014 at 08:48:08PM -0400, Hamilton, Peter A. wrote: Hi qemu-devel, I am a member of a development team based out of the Johns Hopkins University Applied Physics Laboratory. Over the past year and a half, we've been working with the OpenStack community on several security

Re: [Qemu-devel] KVM call agenda for 2014-03-18

2014-03-18 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please, send any topic that you are interested in covering. Thanks, Juan. Sorry for being late. No topics - No call (I will learn daylight savings at some point :-()) Later, Juan.

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Juan Quintela
Markus Armbruster arm...@redhat.com wrote: Juan Quintela quint...@redhat.com writes: Le Tan tamlokv...@gmail.com wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it means. So, please, can anyone help me, telling

[Qemu-devel] [PATCH v4 2/5] qom: don't make link NULL on object_property_set_link() failure

2014-03-18 Thread Stefan Hajnoczi
The error behavior of object_property_set_link() is dangerous. It sets the link property object to NULL if an error occurs. A setter function should either succeed or fail, it shouldn't leave the value NULL on failure. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- qom/object.c | 29

Re: [Qemu-devel] n ways block filters

2014-03-18 Thread Kevin Wolf
Am 17.03.2014 um 17:02 hat Stefan Hajnoczi geschrieben: On Mon, Mar 17, 2014 at 4:12 AM, Fam Zheng f...@redhat.com wrote: On Fri, 03/14 16:57, Benoît Canet wrote: I discussed a bit with Stefan on the list and we came to the conclusion that the block filter API need group support.

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-18 Thread Daniel P. Berrange
On Tue, Mar 18, 2014 at 02:08:19PM +0100, Stefan Hajnoczi wrote: On Mon, Mar 17, 2014 at 08:48:08PM -0400, Hamilton, Peter A. wrote: Hi qemu-devel, I am a member of a development team based out of the Johns Hopkins University Applied Physics Laboratory. Over the past year and a half,

[Qemu-devel] [PATCH for-2.0] vl.c: Fix OpenBSD compilation issue due to namespace collisions

2014-03-18 Thread Marcel Apfelbaum
Machine rewriting added MACHINE macro which is already in use by other OpenBSD library. Since qemu/sockets.h exposes the OpenBSD namespace, the minimalistic approach is to add it as the first QEMU include. Reported-by: Brad Smith b...@comstyle.com Signed-off-by: Marcel Apfelbaum

[Qemu-devel] [Bug 1293975] [NEW] Guest is destroyed after live migration

2014-03-18 Thread Robert Hu
Public bug reported: Environment: Host OS (ia32/ia32e/IA64):ia32e Guest OS (ia32/ia32e/IA64):ia32e Guest OS Type (Linux/Windows):Linux kvm.git Commit:8fbb1daf3e8254afc17fc4490b69db00920197ae qemu.git Commit: 6fffa26244737f8fd8641a21fee29bd6aa9fdff5 Host Kernel Version:3.14.0-rc3

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Markus Armbruster
Juan Quintela quint...@redhat.com writes: Markus Armbruster arm...@redhat.com wrote: Juan Quintela quint...@redhat.com writes: Le Tan tamlokv...@gmail.com wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it

Re: [Qemu-devel] [for-2.1 PATCH v2 2/2] i386/acpi-build: support hotplug of VCPU with APIC ID 0xFF

2014-03-18 Thread Michael S. Tsirkin
On Mon, Mar 17, 2014 at 05:05:17PM +0100, Laszlo Ersek wrote: Building on the previous patch, raise the maximal count of processor objects / NTFY branches / CPON elements from 255 to 256. This allows the VCPU with APIC ID 0xFF to be hotplugged. Signed-off-by: Laszlo Ersek ler...@redhat.com

Re: [Qemu-devel] How to understand the coroutine context?

2014-03-18 Thread Leandro Dorileo
Hi, On Tue, Mar 18, 2014 at 07:56:16AM +0800, Le Tan wrote: Hi, I am diving into the source code of qemu. I see the word coroutine appears in so many places. I can't figure out what it means. So, please, can anyone help me, telling me the mechanism or semantic of coroutine? Thanks! If you

Re: [Qemu-devel] [PATCH for-2.0] vl.c: Fix OpenBSD compilation issue due to namespace collisions

2014-03-18 Thread Peter Maydell
On 18 March 2014 13:39, Marcel Apfelbaum marce...@redhat.com wrote: Machine rewriting added MACHINE macro which is already in use by other OpenBSD library. Since qemu/sockets.h exposes the OpenBSD namespace, the minimalistic approach is to add it as the first QEMU include. Reported-by: Brad

Re: [Qemu-devel] Adding dmcrypt to QEMU block drivers

2014-03-18 Thread Kevin Wolf
Am 18.03.2014 um 14:30 hat Daniel P. Berrange geschrieben: Also, we shouldn't be focusing on QCow2 here. While we're certainly aiming to obsolete QCow2's encryption, we should be aiming to cover any of the drivers. eg people using the built-in rbd/iscsi/gluster/nfs backends want to be able to

Re: [Qemu-devel] target-i386: guest variable shift by 0 provokes shift by -1

2014-03-18 Thread Richard Henderson
On 03/18/2014 05:33 AM, Peter Maydell wrote: 0x7fe9a5f 82 mov_i64 tmp1,rcx 83 mov_i64 tmp0,rax 84 movi_i64 tmp13,$0x1f 85 and_i64 tmp1,tmp1,tmp13 86 movi_i64 tmp13,$0x1 87 sub_i64 tmp3,tmp1,tmp13 88 shl_i64 tmp3,tmp0,tmp3 89 shl_i64 tmp0,tmp0,tmp1 90 ext32u_i64

[Qemu-devel] [Bug 1293975] Re: Guest is destroyed after live migration

2014-03-18 Thread Dr. David Alan Gilbert
Can you capture a backtrace for the failure? Is the seg happening in the source or destination qemu? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1293975 Title: Guest is destroyed after live

Re: [Qemu-devel] [PATCH for-2.0] vl.c: Fix OpenBSD compilation issue due to namespace collisions

2014-03-18 Thread Marcel Apfelbaum
On Tue, 2014-03-18 at 16:05 +0200, Marcel Apfelbaum wrote: On Tue, 2014-03-18 at 13:57 +, Peter Maydell wrote: On 18 March 2014 13:39, Marcel Apfelbaum marce...@redhat.com wrote: Machine rewriting added MACHINE macro which is already in use by other OpenBSD library. Since

Re: [Qemu-devel] target-i386: guest variable shift by 0 provokes shift by -1

2014-03-18 Thread Peter Maydell
On 18 March 2014 14:20, Richard Henderson r...@twiddle.net wrote: On 03/18/2014 05:33 AM, Peter Maydell wrote: In this case the constant propagation code is smart enough to figure out that tmp1 is always zero at op 85, and therefore tmp3 is -1 at op 87. It then tries to use the shift constant

Re: [Qemu-devel] [PATCH for-2.0?] target-i386: fix gdb debugging with large memory guests

2014-03-18 Thread Jan Kiszka
On 2014-03-18 14:00, Luiz Capitulino wrote: On Tue, 18 Mar 2014 11:30:42 +0100 Jan Kiszka jan.kis...@siemens.com wrote: On 2014-03-18 08:36, Paolo Bonzini wrote: Il 18/03/2014 08:19, Jan Kiszka ha scritto: On 2014-03-18 02:54, Luiz Capitulino wrote: If you start a Linux guest with more

[Qemu-devel] [PATCH v2] block: Add error handling to bdrv_invalidate_cache()

2014-03-18 Thread Kevin Wolf
If it returns an error, the migrated VM will not be started, but qemu exits with an error message. Signed-off-by: Kevin Wolf kw...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com Reviewed-by: Eric Blake ebl...@redhat.com --- v2: - Update quorum as well (not built by default, so it

  1   2   3   >