Re: [Qemu-devel] [PULL 08/38] pci-assign: accept Error from monitor_handle_fd_param2()

2014-05-09 Thread Eric Blake
On 05/08/2014 12:52 PM, Luiz Capitulino wrote: From: Laszlo Ersek ler...@redhat.com Propagate any errors in monitor fd handling up to get_real_device(), and report them there. We'll continue the propagation upwards when get_real_device() becomes a leaf itself (when none of its callees will

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Brad Smith
On 08/05/14 10:54 AM, Peter Maydell wrote: On 8 May 2014 15:47, Brad Smith b...@comstyle.com wrote: The following commit broke the build of QEMU.. linux-user: remove configure option for setting uname release http://git.qemu.org/?p=qemu.git;a=commit;h=e586822a58b6609edb5ea929e8a4aa394d32389f

Re: [Qemu-devel] [PATCH 3/8] hw/display/pxa2xx_lcd: Fix 16bpp+alpha and 18bpp+alpha palette formats

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell peter.mayd...@linaro.org wrote: The pxa2xx palette entry 16bpp plus transparency format is xxxTR000GG00B000, and 18bpp plus transparency is xxxTRR00GG00BB00. Correct errors in the code for reading these and

[Qemu-devel] [Bug 1307473] Re: guest hang due to missing clock interrupt

2014-05-09 Thread Launchpad Bug Tracker
Status changed to 'Confirmed' because the bug affects multiple users. ** Changed in: qemu (Ubuntu) Status: New = Confirmed -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307473 Title:

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 10 May 2014 00:02, Brad Smith b...@comstyle.com wrote: On 08/05/14 10:54 AM, Peter Maydell wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? I do not use it personally but it is common sense that commits must not be breaking the build.

Re: [Qemu-devel] [PATCH 4/8] hw/arm/omap1: Avoid unintended sign extension writing omap_rtc YEARS_REG

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell peter.mayd...@linaro.org wrote: When writing to the YEARS_REG register, if the year value is 99 then the multiplication by 31536000 will overflow into the sign bit of a 32 bit value and then be erroneously sign-extended if time_t is 64 bits. Add a

Re: [Qemu-devel] [PATCH 5/8] hw/dma/omap_dma: Add (uint32_t) casts when shifting uint16_t by 16

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell peter.mayd...@linaro.org wrote: Add missing (uint32_t) casts in cases where we're trying to put a uint16_t value into the top half of a 32-bit field. These were already present in some but not all places. Signed-off-by: Peter Maydell

Re: [Qemu-devel] [PATCH 6/8] hw/timer/exynos4210_mct: Avoid overflow in exynos4210_ltick_recalc_count

2014-05-09 Thread Peter Crosthwaite
On Fri, May 9, 2014 at 4:46 AM, Peter Maydell peter.mayd...@linaro.org wrote: Add casts to avoid potentially overflowing the multiplications of 32 bit quantities in exynos4210_ltick_recalc_count(). Signed-off-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Peter Crosthwaite

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Brad Smith
On 09/05/14 7:35 PM, Peter Maydell wrote: On 10 May 2014 00:02, Brad Smith b...@comstyle.com wrote: On 08/05/14 10:54 AM, Peter Maydell wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? I do not use it personally but it is common sense

[Qemu-devel] [PATCH 0/4] replace some fprintf(stderr, ...) with error_report()

2014-05-09 Thread Le Tan
This series of patches replaces some more occurrences of fprintf(stderr, ...) with error_report() and removes the trailing \n. Some of them are not changed because I am not sure if they should be changed. There are some inconsistency while dealing with macros that involves fprintf(stderr,...),

[Qemu-devel] [PATCH 2/4] audio: replace fprintf(stderr, ...) with error_report() in audio

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files audio/*. The trailing \ns of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan tamlokv...@gmail.com --- audio/spiceaudio.c |2 +- audio/wavcapture.c |4 ++-- 2

[Qemu-devel] [PATCH 1/4] arch_init: replace fprintf(stderr, ...) with error_report() in arch_init.c

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in the file arch_init.c. The trailing \ns of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan tamlokv...@gmail.com --- arch_init.c | 36 +--- 1

[Qemu-devel] [PATCH 4/4] bsd-user: replace fprintf(stderr, ...) with error_report()

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files bsd-user/*. The trailing \ns of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan tamlokv...@gmail.com --- bsd-user/bsdload.c |2 +- bsd-user/elfload.c |2 +-

[Qemu-devel] [PATCH 3/4] block: replace fprintf(stderr, ...) with error_report() in block/

2014-05-09 Thread Le Tan
Replace fprintf(stderr,...) with error_report() in files block/*, block.c, block-migration.c and blockdev.c. The trailing \ns of the @fmt argument have been removed because @fmt of error_report() should not contain newline. Signed-off-by: Le Tan tamlokv...@gmail.com --- block-migration.c |

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 10 May 2014 00:49, Brad Smith b...@comstyle.com wrote: This is just excuses and points out poor project process. There could easily be a staging branch to deal with this. I have no objection if you'd like to sort out our build and test infrastructure. thanks -- PMM

Re: [Qemu-devel] '.' IDs and certain names breaks -global and -set

2014-05-09 Thread Alistair Francis
On Tue, Apr 15, 2014 at 8:32 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Tue, Apr 15, 2014 at 1:38 AM, Andreas Färber afaer...@suse.de wrote: Am 14.04.2014 09:13, schrieb Markus Armbruster: Alistair Francis alistair.fran...@xilinx.com writes: On Wed, Apr 9, 2014 at 9:58 PM,

[Qemu-devel] [Bug 1318091] [NEW] Perfctr MSRs not available to Guest OS on AMD Phenom II

2014-05-09 Thread Barret
Public bug reported: The AMD Phenom(tm) II X4 965 Processor (family 16, model 4, stepping 3) has the 4 architecturally supported perf counters at MSRs. The selectors are c001000-c001003, and the counters are c001004-c001007. I've verified that the MSRs are there and working by manually setting

[Qemu-devel] [PATCH] preallocate memory after NUMA policy configuration

2014-05-09 Thread Marcelo Tosatti
(note: applies on top of patchset of current thread) Preallocate memory after the NUMA policy has been instantiated. This is necessary to guarantee memory is allocated with specified NUMA policy in place. Signed-off-by: Marcelo Tosatti mtosa...@redhat.com diff --git a/backends/hostmem.c

Re: [Qemu-devel] [PATCH] preallocate memory after NUMA policy configuration

2014-05-09 Thread Hu Tao
On Fri, May 09, 2014 at 03:24:52AM -0300, Marcelo Tosatti wrote: (note: applies on top of patchset of current thread) Preallocate memory after the NUMA policy has been instantiated. This is necessary to guarantee memory is allocated with specified NUMA policy in place. Signed-off-by:

[Qemu-devel] [Bug 1316115] Re: linux-user qemu-arm NEON support

2014-05-09 Thread Christopher Horler
I didn't test it on real hardware yet - but I resolved the issue and found the root cause last night: This perhaps should have been more obvious to me in the beginning, but readelf -l shows a program header similar to this: INTERP 0x00394600 0x00394600

Re: [Qemu-devel] [Bug] cirrus_vga: qemu abort at booting when configure vgamem_mb = 2

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 03:47 +, Gonglei (Arei) wrote: Hi, Gerd The issue consequentially occur, I have tested various qemu versions, including the current qemu.git. Missing sanity check. It's not valid. We mimic existing hardware here, and the cirrus card emulated has 4 MB video

Re: [Qemu-devel] [Bug] cirrus_vga: qemu abort at booting when configure vgamem_mb = 2

2014-05-09 Thread Gonglei (Arei)
Hi, -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, May 09, 2014 2:49 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org Subject: Re: [Bug] cirrus_vga: qemu abort at booting when configure vgamem_mb = 2 On Fr, 2014-05-09 at 03:47 +, Gonglei

Re: [Qemu-devel] [PATCH] spapr: pci: clean msi info when releasing it

2014-05-09 Thread liu ping fan
On Wed, May 7, 2014 at 3:20 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/07/2014 04:51 PM, Liu Ping Fan wrote: In current code, we use phb-msi_table[ndev].nvec to indicate whether this msi entries are used by a device or not. So when unplug a pci device, we should reset nvec to zero.

Re: [Qemu-devel] [PATCH 1/5] xen, gfx passthrough: basic graphics passthrough support

2014-05-09 Thread Zhang, Yang Z
Anthony PERARD wrote on 2014-03-22: On Fri, Feb 21, 2014 at 02:44:09PM +0800, Yang Zhang wrote: From: Yang Zhang yang.z.zh...@intel.com basic gfx passthrough support: - add a vga type for gfx passthrough - retrieve VGA bios from host 0xC, then load it to guest 0xC -

Re: [Qemu-devel] [PATCH v2] block/raw-posix: Try both FIEMAP and SEEK_HOLE

2014-05-09 Thread Paolo Bonzini
Il 06/05/2014 21:00, Max Reitz ha scritto: The current version of raw-posix always uses ioctl(FS_IOC_FIEMAP) if FIEMAP is available; lseek with SEEK_HOLE/SEEK_DATA are not even compiled in in this case. However, there may be implementations which support the latter but not the former (e.g.,

[Qemu-devel] [PATCH] kvm: make one_reg helpers available for everyone

2014-05-09 Thread Cornelia Huck
s390x introduced helper functions for getting/setting one_regs with commit 860643bc. However, nothing about these is s390-specific. Alexey Kardashevskiy had already posted a general version, so let's merge the two patches and massage the code a bit. CC: Alexey Kardashevskiy a...@ozlabs.ru

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Riku Voipio
Hi Craig, On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: On 7 May 2014 15:48, Peter Maydell peter.mayd...@linaro.org wrote: On 7 May 2014 15:34, Paul Jimenez 1317...@bugs.launchpad.net wrote: Bug description: Using the latest version of qemu-user-static from trusty,

Re: [Qemu-devel] [PATCH] block: Fix open flags with BDRV_O_SNAPSHOT

2014-05-09 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 10:24:21AM +0200, Kevin Wolf wrote: Perhaps the monitor should be changed to avoid printing so many useless control characters, then we'd hit the limit less often... Stefan, didn't you plan to do something like this? Or was it unrelated? I encountered this when

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 03:57, Gonglei (Arei) ha scritto: Hi, Vhost devices need to do VHOST_SET_MEM_TABLE ioctl in vhost_dev_start() to tell vhost kernel modules GPA to HVA memory mappings, which consume is expensively. The reason is same as KVM_SET_GSI_ROUTING ioctl. That is, in ioctl processing, kmod

Re: [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 02:04, Josh Durgin ha scritto: On 05/08/2014 07:34 AM, Stefan Hajnoczi wrote: Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll(). The .bdrv_detach_aio_context() and .bdrv_attach_aio_context()

Re: [Qemu-devel] [PATCH] linux-user: Return correct errno for unsupported netlink socket

2014-05-09 Thread Riku Voipio
Hi, On Mon, May 05, 2014 at 08:04:45PM -0700, Ed Swierk wrote: This fixes Cannot open audit interface - aborting. when the EAFNOSUPPORT errno differs between the target and host architectures (e.g. mips target and x86_64 host). Thanks, looks good - applied to linux-user tree. Signed-off-by:

Re: [Qemu-devel] virtio-serial-pci very expensive during live migration

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 02:53, Chris Friesen ha scritto: Turns out I spoke too soon. With the patch applied, it boots, but if I try to do a live migration both the source and destination crash. This happens for both the master branch as well as the stable-1.4 branch. The destination doesn't crash,

Re: [Qemu-devel] [RFC] dataplane: IOThreads and writing dataplane-capable code

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 07:58:11PM +0100, Dr. David Alan Gilbert wrote: * Stefan Hajnoczi (stefa...@gmail.com) wrote: On Thu, May 8, 2014 at 3:44 PM, Dr. David Alan Gilbert dgilb...@redhat.com wrote: * Stefan Hajnoczi (stefa...@redhat.com) wrote: snip How to synchronize with an

Re: [Qemu-devel] [PATCH v3 18/25] rbd: use BlockDriverState's AioContext

2014-05-09 Thread Stefan Hajnoczi
On Thu, May 08, 2014 at 05:04:16PM -0700, Josh Durgin wrote: On 05/08/2014 07:34 AM, Stefan Hajnoczi wrote: Drop the assumption that we're using the main AioContext. Convert qemu_bh_new() to aio_bh_new() and qemu_aio_wait() to aio_poll(). The .bdrv_detach_aio_context() and

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Peter Maydell
On 9 May 2014 09:14, Riku Voipio riku.voi...@iki.fi wrote: Hi Craig, On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: Original 2011 patch: http://lists.gnu.org/archive/html/qemu-trivial/2011-12/msg00025.html (hitting the 'reply' button gets us back the original email address

Re: [Qemu-devel] [PATCH v3.1 00/31] NUMA series, and hostmem improvements

2014-05-09 Thread Hu Tao
On Thu, May 08, 2014 at 04:51:56PM +0200, Paolo Bonzini wrote: Il 06/05/2014 11:27, Hu Tao ha scritto: This series includes work on QOMifying the memory backends. the idea is to delegate all properties of the memory backend to a new QOM class hierarchy, in which the concrete classes are

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Thursday, May 08, 2014 7:22 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; jbeul...@suse.com; stefano.stabell...@eu.citrix.com; fabio.fant...@m2r.biz;

Re: [Qemu-devel] [PATCH] spapr: pci: clean msi info when releasing it

2014-05-09 Thread Alexey Kardashevskiy
On 05/09/2014 05:04 PM, liu ping fan wrote: On Wed, May 7, 2014 at 3:20 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 05/07/2014 04:51 PM, Liu Ping Fan wrote: In current code, we use phb-msi_table[ndev].nvec to indicate whether this msi entries are used by a device or not. So when unplug a

[Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com In Xen platform, after using upstream qemu, the all of pci devices will show hotplug in the windows guest, no matter whether they can be hotpluged. It is unfriendly. The PCI devices that can not be hotpluged are hidden by modifing the DSDT entries of PCI

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Riku Voipio
Hi, On 8 May 2014 17:54, Peter Maydell peter.mayd...@linaro.org wrote: On 8 May 2014 15:47, Brad Smith b...@comstyle.com wrote: The following commit broke the build of QEMU.. linux-user: remove configure option for setting uname release

[Qemu-devel] [BUG] 50MB/min logspam: dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1

2014-05-09 Thread Philipp Hahn
Hello, a Xen-4.1-3 host system filled its log file with the message dma: unregistered DMA channel used nchan=0 dma_pos=0 dma_len=1 The happened two times was a Windows Server 2003 with GPLPV 0.11.0.372: one VM was migrated to that host and one was directly started there. After a restart of the

Re: [Qemu-devel] [Bug 1317090] Re: qemu fails on ELF files with no section headers

2014-05-09 Thread Riku Voipio
On Fri, May 09, 2014 at 09:20:54AM +0100, Peter Maydell wrote: On 9 May 2014 09:14, Riku Voipio riku.voi...@iki.fi wrote: Hi Craig, On Wed, May 07, 2014 at 03:53:38PM +0100, Peter Maydell wrote: Original 2011 patch: http://lists.gnu.org/archive/html/qemu-trivial/2011-12/msg00025.html

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 08:38 +, Gonglei (Arei) wrote: This is done by runtime patching: Which appears to involve an awful lot of jumping through hoops... Please can you explain why it is necessary, as opposed to e.g. using a dynamic set of SSDTs? Ok, we will delete some

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Gonglei (Arei)
Hi, -Original Message- From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Friday, May 09, 2014 4:15 PM To: Gonglei (Arei); qemu-devel@nongnu.org Cc: m...@redhat.com; Herongguang (Stephen); Huangweidong (C) Subject: Re: [RFC] vhost: Can we change synchronize_rcu to call_rcu in

Re: [Qemu-devel] [PATCH v3] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, Ian -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Friday, May 09, 2014 5:05 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; xen-de...@lists.xen.org; jbeul...@suse.com; stefano.stabell...@eu.citrix.com; fabio.fant...@m2r.biz;

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Jan Beulich
On 09.05.14 at 10:47, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com In Xen platform, after using upstream qemu, the all of pci devices will show hotplug in the windows guest, no matter whether they can be hotpluged. It is unfriendly. The PCI devices that can not be

Re: [Qemu-devel] Question about RAM migration flags

2014-05-09 Thread Dr. David Alan Gilbert
* Peter Lieven (p...@kamp.de) wrote: Hi, while working on ram migration and reading through the code I realized that qemu does not stop loading a saved VM or rejecting an incoming migration if there is a flag in the stream that it does not understand. An unknown flag is simply ignored.

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
-Original Message- From: Jan Beulich [mailto:jbeul...@suse.com] Sent: Friday, May 09, 2014 5:36 PM To: Gonglei (Arei) Cc: anthony.per...@citrix.com; ian.campb...@citrix.com; stefano.stabell...@eu.citrix.com; johannes.kra...@googlemail.com; Gaowei (UVP); Hanweidong (Randy);

[Qemu-devel] [PATCH 2/5] block: New bdrv_nb_sectors()

2014-05-09 Thread Markus Armbruster
A call to retrieve the image size converts between bytes and sectors several times: * BlockDriver method bdrv_getlength() returns bytes. * refresh_total_sectors() converts to sectors, rounding up, and stores in total_sectors. * bdrv_getlength() converts total_sectors back to bytes (now

[Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Markus Armbruster
Issues addressed in this series: * BlockDriver method bdrv_getlength() generally returns -errno, but some implementations return -1 instead. Fix them [PATCH 1]. * Frequent conversions between sectors and bytes complicate the code needlessly. Clean up some [PATCH 2+3]. * bdrv_getlength()

[Qemu-devel] [PATCH 5/5] block: Avoid bdrv_get_geometry() where errors should be detected

2014-05-09 Thread Markus Armbruster
bdrv_get_geometry() hides errors. Use bdrv_nb_sectors() or bdrv_getlength() instead where that's obviously inappropriate. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 11 +--- block/qapi.c | 14 +++--- qemu-img.c | 85

[Qemu-devel] [PATCH 1/5] raw-posix: Fix raw_getlength() to always return -errno on error

2014-05-09 Thread Markus Armbruster
We got a merry mix of -1 and -errno here. Signed-off-by: Markus Armbruster arm...@redhat.com --- block/raw-posix.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/block/raw-posix.c b/block/raw-posix.c index 3ce026d..9bf06e5 100644 ---

[Qemu-devel] [PATCH 4/5] block: Drop superfluous aligning of bdrv_getlength()'s value

2014-05-09 Thread Markus Armbruster
It returns a multiple of the sector size. Signed-off-by: Markus Armbruster arm...@redhat.com --- block.c | 1 - block/qcow2.c | 1 - 2 files changed, 2 deletions(-) diff --git a/block.c b/block.c index 1b99cb1..89cab7c 100644 --- a/block.c +++ b/block.c @@ -1228,7 +1228,6 @@ void

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Jan Beulich
On 09.05.14 at 11:45, arei.gong...@huawei.com wrote: From: Jan Beulich [mailto:jbeul...@suse.com] And it also seem pretty pointless to send a v4 without addressing all comments you got on v3. I don't think so. I have absorbed Ian's all suggestion on v3. And for other questions have been

[Qemu-devel] [PATCH 3/5] block: Use bdrv_nb_sectors() when sectors, not bytes are wanted

2014-05-09 Thread Markus Armbruster
Instead of bdrv_nb_sectors(). Aside: a few of these callers don't handle errors. I didn't investigate whether they should. Signed-off-by: Markus Armbruster arm...@redhat.com --- block-migration.c | 9 - block.c | 40 ++-- block/qcow2.c

Re: [Qemu-devel] [RFC] vhost: Can we change synchronize_rcu to call_rcu in vhost_set_memory() in vhost kernel module?

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 11:04, Gonglei (Arei) ha scritto: Yes, for example enabling/disabling PCI BARs would have that effect. Yes, but PCI BARs are mapped in PCI hole, and they are not overlapped with ram memory regions, so disable or enable PCI BARs would not change ram MRs' mapping. PCI BARs can

Re: [Qemu-devel] QEMU build broken

2014-05-09 Thread Peter Maydell
On 9 May 2014 09:57, Riku Voipio riku.voi...@linaro.org wrote: On 8 May 2014 17:54, Peter Maydell peter.mayd...@linaro.org wrote: Ah, bsd-user. Do you actually use it, or is it just in the default compile that you're running? One year since last bsd-user specific patch, I take we need a new

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:45 +, Gonglei (Arei) wrote: And it also seem pretty pointless to send a v4 without addressing all comments you got on v3. I don't think so. I have absorbed Ian's all suggestion on v3. And for other questions have been answered too, in despite of is me or not.

[Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Peter Krempa
The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't. As other functions such as qemu_gluster_open() in the gluster block code report their errors based on this fact we need to make sure that errno is set on each failure. This fixes a crash of

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Gonglei (Arei)
Hi, First, please forgive me for my bad English. It's so sad. -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Friday, May 09, 2014 5:57 PM To: Gonglei (Arei) Cc: Jan Beulich; xen-de...@lists.xen.org; anthony.per...@citrix.com;

[Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: Hi, First, please forgive me for my bad English. It's so sad. -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Friday, May 09, 2014 5:57 PM To: Gonglei (Arei) Cc: Jan Beulich;

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 18:21 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
Hi, -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, May 09, 2014 6:31 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; pbonz...@redhat.com; Huangweidong (C); Blue Swirl Subject: Re: [PATCH] cirrus_vga: adding sanity

[Qemu-devel] [PATCH] Split ram_save_block

2014-05-09 Thread Dr. David Alan Gilbert (git)
From: Dr. David Alan Gilbert dgilb...@redhat.com ram_save_block is getting a bit too complicated, and does two separate things: 1) Finds a page to send 2) Sends the page (dealing with compression etc) Split into 'ram_save_page' to send the page and deal with compression (2) Rename

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gerd Hoffmann
Hi, BTW, what's your opinion about isa cirrus vga device, Gerd? I'd do the same check there. cheers, Gerd

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size [checkpatch false positive?]

2014-05-09 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, May 09, 2014 6:55 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; pbonz...@redhat.com; Huangweidong (C); Blue Swirl Subject: Re: [PATCH] cirrus_vga: adding sanity

[Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB and 16 MB vram size. Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Michael Tokarev
09.05.2014 15:04, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept 8 MB

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility,

Re: [Qemu-devel] [PULL 0/9] Tracing patches

2014-05-09 Thread Peter Maydell
On 7 May 2014 18:16, Stefan Hajnoczi stefa...@redhat.com wrote: I forgot to open the QEMU 2.1 tracing queue. Let's get started! The following changes since commit 9898370497da3f18e0c9555b65c858eabc78ab50: Merge remote-tracking branch 'remotes/kraxel/tags/pull-smbios-2' into staging

Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: The docs for glfs_init suggest that the function sets errno on every failure. In fact it doesn't. As other functions such as qemu_gluster_open() in the gluster block code report their errors based on this fact we need to make sure

Re: [Qemu-devel] [PATCH v2] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 13:04, schrieb arei.gong...@huawei.com: From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4 MB video memory. Also for backward compatibility, accept

Re: [Qemu-devel] QEMU 2.1 release schedule?

2014-05-09 Thread Peter Maydell
On 9 May 2014 02:07, Michael Roth mdr...@linux.vnet.ibm.com wrote: Quoting Peter Maydell (2014-05-08 08:48:01) Paolo suggested on IRC: soft freeze mid june, hard freeze beginning of july, release end of july or beginning of august? Which works for me. Some concrete dates: * 17 June:

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Andreas Färber
Am 09.05.2014 12:59, schrieb Gonglei (Arei): -Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Friday, May 09, 2014 6:55 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; afaer...@suse.de; m...@redhat.com; pbonz...@redhat.com; Huangweidong (C); Blue Swirl

Re: [Qemu-devel] [PATCH] kvmclock: Ensure time in migration never goes backward

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 04:28, Marcelo Tosatti ha scritto: Alex, Unability to upgrade systems is not an excuse to fix the bug in the wrong place. It may be an excuse to fix the bug in both places though. Paolo

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Gerd Hoffmann
Hi, virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, so this would break a lot of setups. It wouldn't. libvirt sticks that into the xml, but it doesn't set any qemu parameters. The libvirt parameter actually predates the qemu property for setting the size. Looking at

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Peter Maydell
On 8 May 2014 19:52, Luiz Capitulino lcapitul...@redhat.com wrote: The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into staging (2014-05-08 10:57:25 +0100) are available in the git repository at:

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: Hi, virt-manager/libvirt seems to default to 9 MByte of Vram for cirrus, so this would break a lot of setups. It wouldn't. libvirt sticks that into the xml, but it doesn't set any qemu parameters. The libvirt parameter actually predates the

Re: [Qemu-devel] [PATCH] cirrus_vga: adding sanity check for vram size

2014-05-09 Thread Paolo Bonzini
Il 09/05/2014 13:18, Dr. David Alan Gilbert ha scritto: * arei.gong...@huawei.com (arei.gong...@huawei.com) wrote: From: Gonglei arei.gong...@huawei.com when configure a invalid vram size for cirrus card, such as less 2 MB, which will crash qemu. Follow the real hardware, the cirrus card has 4

Re: [Qemu-devel] [PATCH 1/6] xics: add flags for interrupts

2014-05-09 Thread Mike Day
On Thu, May 8, 2014 at 11:12 PM, Alexey Kardashevskiy a...@ozlabs.ru wrote: There are a couple ways to mitigate this type of situation by using alternative data structures to inform the loop traversal. I don't know if it is worth the effort, though. Here I lost you :) If I read the code

Re: [Qemu-devel] [PATCH 0/5] Clean up around bdrv_getlength()

2014-05-09 Thread Stefan Hajnoczi
On Fri, May 09, 2014 at 11:48:13AM +0200, Markus Armbruster wrote: Issues addressed in this series: * BlockDriver method bdrv_getlength() generally returns -errno, but some implementations return -1 instead. Fix them [PATCH 1]. * Frequent conversions between sectors and bytes complicate

Re: [Qemu-devel] [PATCH v3 1/4] vl.c: extend -m option to support options for memory hotplug

2014-05-09 Thread Christian Borntraeger
On 07/05/14 20:05, Matthew Rosato wrote: From: Igor Mammedov imamm...@redhat.com From: Igor Mammedov imamm...@redhat.com Add following parameters: slots - total number of hotplug memory slots maxmem - maximum possible memory slots and maxmem should go in pair and maxmem should be

Re: [Qemu-devel] Question about RAM migration flags

2014-05-09 Thread Peter Lieven
Am 09.05.2014 um 11:43 schrieb Dr. David Alan Gilbert dgilb...@redhat.com: * Peter Lieven (p...@kamp.de) wrote: Hi, while working on ram migration and reading through the code I realized that qemu does not stop loading a saved VM or rejecting an incoming migration if there is a flag in

Re: [Qemu-devel] [PATCH] gluster: Correctly propagate errors when volume isn't accessible

2014-05-09 Thread Peter Krempa
On 05/09/14 13:39, Stefan Hajnoczi wrote: On Fri, May 09, 2014 at 12:08:10PM +0200, Peter Krempa wrote: ... Please use scripts/checkpatch.pl to check coding style in the future. I added {} around the if statement body. QEMU always uses curlies even for 1-statement bodies. Ah, right,

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Markus Armbruster
Peter Maydell peter.mayd...@linaro.org writes: On 8 May 2014 19:52, Luiz Capitulino lcapitul...@redhat.com wrote: The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: Merge remote-tracking branch 'remotes/spice/tags/pull-spice-7' into staging (2014-05-08 10:57:25

Re: [Qemu-devel] [PATCH] hw/arm/spitz: Avoid clash with Windows header symbol MOD_SHIFT

2014-05-09 Thread Peter Maydell
On 20 February 2014 19:45, Peter Maydell peter.mayd...@linaro.org wrote: The Windows headers provided by MinGW define MOD_SHIFT. Avoid it by using SPITZ_MOD_* for our constants here. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- The other approach would be just to #undef

Re: [Qemu-devel] [PULL 00/38] QMP queue

2014-05-09 Thread Luiz Capitulino
On Fri, 09 May 2014 14:54:45 +0200 Markus Armbruster arm...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org writes: On 8 May 2014 19:52, Luiz Capitulino lcapitul...@redhat.com wrote: The following changes since commit 6b342cc9c872e82620fdd32730cd92affa8a19b3: Merge

Re: [Qemu-devel] [PATCH v18 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-05-09 Thread Markus Armbruster
No longer applies. It's been four weeks :( Fam Zheng f...@redhat.com writes: v18: Address reviewing comments from Jeff and Eric. Rebased to current master. Side by side diff from v17: http://bit.ly/1oO2Fvt [01/15] block: Add BlockOpType enum Add Jeff's reviewed-by.

[Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Stefan Priebe - Profihost AG
Hello list, i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine running Qemu 2.0. I started the target machine with: -machine type=pc-i440fx-1.5 / -machine type=pc-i440fx-1.7 But the migration simply fails. Migrating Qemu 2.0 to Qemu 2.0 succeeds. I see no output at the monitor of

[Qemu-devel] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit

2014-05-09 Thread Peter Maydell
Add a U suffix to avoid shifting into the sign bit (which is undefined behaviour in C). Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- Another one from clang's sanitizer... hw/audio/intel-hda.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Konrad Rzeszutek Wilk
On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: Hi, First, please forgive me for my bad English. It's so sad. -Original Message- From: Ian Campbell [mailto:ian.campb...@citrix.com] Sent: Friday,

Re: [Qemu-devel] [Xen-devel] [PATCH v4] Hvmloader: Modify ACPI to only supply _EJ0 methods for PCIslots that support hotplug by runtime patching

2014-05-09 Thread Ian Campbell
On Fri, 2014-05-09 at 09:25 -0400, Konrad Rzeszutek Wilk wrote: On Fri, May 09, 2014 at 11:26:35AM +0100, Ian Campbell wrote: On Fri, 2014-05-09 at 10:15 +, Gonglei (Arei) wrote: Hi, First, please forgive me for my bad English. It's so sad. -Original Message-

Re: [Qemu-devel] [PATCH v3 12/16] tcg-s390: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson r...@twiddle.net wrote: And use tcg pointer differencing functions as appropriate. Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/s390/tcg-target.c | 91 --- tcg/s390/tcg-target.h | 2 ++

Re: [Qemu-devel] [PATCH v18 00/15] Drop in_use from BlockDriverState and enable point-in-time snapshot exporting over NBD

2014-05-09 Thread Fam Zheng
On Fri, 05/09 15:08, Markus Armbruster wrote: No longer applies. It's been four weeks :( Hi Markus, Thanks for noticing this, I'll rebase and send another revision now. Fam Fam Zheng f...@redhat.com writes: v18: Address reviewing comments from Jeff and Eric. Rebased to current

Re: [Qemu-devel] [PATCH v3 14/16] tcg-mips: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson r...@twiddle.net wrote: And use tcg pointer differencing functions as appropriate. Cc: Aurelien Jarno aurel...@aurel32.net Signed-off-by: Richard Henderson r...@twiddle.net Reviewed-by: Peter Maydell peter.mayd...@linaro.org -- PMM

Re: [Qemu-devel] Migration from older Qemu to Qemu 2.0.0 does not work

2014-05-09 Thread Dr. David Alan Gilbert
* Stefan Priebe - Profihost AG (s.pri...@profihost.ag) wrote: Hello list, i was trying to migrate older Qemu (1.5 and 1.7.2) to a machine running Qemu 2.0. I started the target machine with: -machine type=pc-i440fx-1.5 / -machine type=pc-i440fx-1.7 I'd expect you to have to run with

Re: [Qemu-devel] [PATCH v3 15/16] tci: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 28 April 2014 20:28, Richard Henderson r...@twiddle.net wrote: And use tcg pointer differencing functions as appropriate. Cc: Stefan Weil s...@weilnetz.de Signed-off-by: Richard Henderson r...@twiddle.net --- tcg/tci/tcg-target.c | 19 +-- tcg/tci/tcg-target.h | 1 + 2

Re: [Qemu-devel] [PATCH] hw/audio/intel-hda: Avoid shift into sign bit

2014-05-09 Thread Gerd Hoffmann
On Fr, 2014-05-09 at 14:22 +0100, Peter Maydell wrote: Add a U suffix to avoid shifting into the sign bit (which is undefined behaviour in C). Added to audio patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH v3 10/16] tcg-arm: Define TCG_TARGET_INSN_UNIT_SIZE

2014-05-09 Thread Peter Maydell
On 2 May 2014 16:24, Richard Henderson r...@twiddle.net wrote: On 05/02/2014 08:19 AM, Peter Maydell wrote: This change also confused me but we're again relying on movi32 generating correct-but-inefficient code now, right? Yes. IMO if we want to do a constant pool, let's do a proper one,

  1   2   >