Re: [Qemu-devel] [PATCH v2 7/9] usb-ehci: add ehci-pci device exit function

2014-06-04 Thread Gerd Hoffmann
On Di, 2014-06-03 at 18:54 +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com clean up ehci resource when ehci pci device exit. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ehci-pci.c | 33 + 1 file changed, 33

Re: [Qemu-devel] [PATCH v2 0/9] usb: usb host adapter hotplug

2014-06-04 Thread Gerd Hoffmann
Hi, changes since v1: * add more completely resource cleanup for every usb host adapter. Looks good overall. How did you test this? cheers, Gerd

Re: [Qemu-devel] [PATCH v2 7/9] usb-ehci: add ehci-pci device exit function

2014-06-04 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, June 04, 2014 2:10 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; Luonengjun; Huangweidong (C); Huangpeng (Peter) Subject: Re: [PATCH v2 7/9] usb-ehci: add ehci-pci device exit function On Di,

Re: [Qemu-devel] [PATCH v2 1/2] sheepdog: fix vdi object update after live snapshot

2014-06-04 Thread Liu Yuan
On Tue, Jun 03, 2014 at 11:58:21PM +0900, Hitoshi Mitake wrote: On Tue, Jun 3, 2014 at 9:41 PM, Liu Yuan namei.u...@gmail.com wrote: On Tue, Jun 03, 2014 at 01:54:21PM +0900, Hitoshi Mitake wrote: sheepdog driver should decide a write request is COW or not based on inode object which is

[Qemu-devel] [PATCH v2 0/8] Obtain dirty bitmap via VM logging

2014-06-04 Thread Sanidhya Kashyap
Hi, The following patches introduce the support of dirty bitmap logging and dumping to a specified file. Still, some work is still left in the area of runstates that I will try to work on after discussing this patch series. v1 -- v2: * Added two new run states to avoid simultaneous execution of

[Qemu-devel] [PATCH v2 2/8] bitmap dump code via QAPI framework

2014-06-04 Thread Sanidhya Kashyap
Following are the changes made with respect to the previous version: Chen's advice 1) Replaced DIRTY_MEMORY_LOG_BITMAP with DIRTY_MEMORY_MIGRATION and completely removed the DIRTY_MEMORY_LOG_BITMAP flag. Eric's advice 2) Replaced FILE pointer with file descriptor. 3) Replaced fopen/fclose with

[Qemu-devel] [PATCH v2 8/8] python script for extracting bitmap from a binary file

2014-06-04 Thread Sanidhya Kashyap
No particular functional change. This file does not need to be included in the Makefile as it will be only useful once the user has generated the bitmap file via bitmap dump process. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- scripts/extract-bitmap.py | 64

[Qemu-devel] [PATCH v2 3/8] RunState: added two new flags for bitmap dump and migration process

2014-06-04 Thread Sanidhya Kashyap
I have added two new flags - RUN_STATE_MIGRATE and RUN_STATE_DUMP_BITMAP. These both flags behave same as RUN_STATE_RUNNING flag. The purpose of introducing these flags is to avoid running both migration and dump bitmap process simultaneously. I haven't added many transitions to the

Re: [Qemu-devel] [PATCH v2 0/9] usb: usb host adapter hotplug

2014-06-04 Thread Gonglei (Arei)
-Original Message- From: Gerd Hoffmann [mailto:kra...@redhat.com] Sent: Wednesday, June 04, 2014 2:12 PM To: Gonglei (Arei) Cc: qemu-devel@nongnu.org; Luonengjun; Huangweidong (C); Huangpeng (Peter) Subject: Re: [PATCH v2 0/9] usb: usb host adapter hotplug Hi, changes since

[Qemu-devel] [PATCH v2 4/8] bitmap dump process with runstates

2014-06-04 Thread Sanidhya Kashyap
Introduced both runstates: RUN_STATE_MIGRATE and RUN_STATE_DUMP_BITMAP to both migration and bitmap dump process. I want the bitmap dump process to get canceled so whenever the state changes from RUN_STATE_BITMAP to something else. But, this does not happen when I stop the guest via stop qmp

[Qemu-devel] [PATCH v2 7/8] set the frequency of the dump bitmap process

2014-06-04 Thread Sanidhya Kashyap
No particular functional change. Corrected some mistakes. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 15 +++ hmp.c| 12 hmp.h| 1 + qapi-schema.json | 10 ++ qmp-commands.hx | 23

[Qemu-devel] [PATCH v2 1/8] enable sharing of the function between migration and bitmap dump

2014-06-04 Thread Sanidhya Kashyap
As advised by Eric, I have enabled sharing of the function between of the function that syncs the dirty bitmap obtained via kvm ioctl. I have tried to make the least changes to the functions by concentrating only on the function definitions. Signed-off-by: Sanidhya Kashyap

Re: [Qemu-devel] [PATCH v1 07/16] target-arm: Add HCR_EL2

2014-06-04 Thread Edgar E. Iglesias
On Tue, Jun 03, 2014 at 11:27:55AM +0100, Alex Bennée wrote: Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/cpu.h| 35 +++

Re: [Qemu-devel] [PATCH v1 10/16] target-arm: Break out exception masking to a separate func

2014-06-04 Thread Edgar E. Iglesias
On Tue, Jun 03, 2014 at 11:32:59AM +0100, Alex Bennée wrote: Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- cpu-exec.c | 5 ++--- target-arm/cpu.h | 16 2 files

Re: [Qemu-devel] [PATCH v1 13/16] target-arm: A64: Emulate the HVC insn

2014-06-04 Thread Edgar E. Iglesias
On Tue, Jun 03, 2014 at 11:41:25AM +0100, Alex Bennée wrote: Edgar E. Iglesias writes: From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/cpu.h | 7 ++- target-arm/helper-a64.c| 1 +

Re: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read

2014-06-04 Thread Fam Zheng
On Tue, 06/03 15:37, Paolo Bonzini wrote: I guess this is more of an RFC, but still a useful starting point for discussion. Il 03/06/2014 14:52, Fam Zheng ha scritto: diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h index e406efa..74f0f32 100644 ---

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 03:10, Jidong Xiao ha scritto: diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c index 4389959..b8b282d 100644 --- a/qemu-2.0.0/target-i386/kvm.c.orig +++ b/qemu-2.0.0/target-i386/kvm.c @@ -530,7 +530,7 @@ int kvm_arch_init_vcpu(CPUState *cs)

Re: [Qemu-devel] [PATCH] util/hbitmap.c: Use ctpopl rather than reimplementing a local equivalent

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 01:41, Peter Maydell ha scritto: The function popcountl() in hbitmap.c is effectively a reimplementation of what host-utils.h provides as ctpopl(). Use ctpopl() directly; this fixes a failure to compile on NetBSD (whose strings.h erroneously exposes a system popcountl() which

[Qemu-devel] [PATCH v2 6/8] cancel mechanism for an already running dump bitmap process

2014-06-04 Thread Sanidhya Kashyap
No particular functional changes. Rectified some previous mistakes. Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 8 qmp-commands.hx | 20

Re: [Qemu-devel] [PATCH] target-arm: implement PD0/PD1 bits for TTBCR

2014-06-04 Thread Aggeler Fabian
On 02 Jun 2014, at 18:02, Peter Maydell peter.mayd...@linaro.org wrote: On 30 May 2014 16:15, Fabian Aggeler aggel...@ethz.ch wrote: Corrected handling of writes to TTBCR for ARMv8 (previously UNK/SBZP bits are not RES0) and ARMv7 (new bits PD0/PD1 for CPUs with Security Extensions).

Re: [Qemu-devel] [PATCH] target-arm: Prepare cpreg writefns/readfns for EL3/SecExt

2014-06-04 Thread Aggeler Fabian
On 31 May 2014, at 02:09, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Fri, May 16, 2014 at 10:43 PM, Fabian Aggeler aggel...@ethz.ch wrote: This patch changes some readfns/writefns to use raw_write and raw_read functions, wich use the fieldoffset specified which in

Re: [Qemu-devel] [PATCH] Qemu: Fix eax for cpuid leaf 0x40000000

2014-06-04 Thread Jidong Xiao
On Wed, Jun 4, 2014 at 3:09 AM, Paolo Bonzini pbonz...@redhat.com wrote: Il 04/06/2014 03:10, Jidong Xiao ha scritto: diff --git a/qemu-2.0.0/target-i386/kvm.c.orig b/qemu-2.0.0/target-i386/kvm.c index 4389959..b8b282d 100644 --- a/qemu-2.0.0/target-i386/kvm.c.orig +++

Re: [Qemu-devel] [PATCH microblaze v1 0/6] Microblaze Device QOM cleanups

2014-06-04 Thread Edgar E. Iglesias
On Thu, May 29, 2014 at 02:21:52AM -0700, Peter Crosthwaite wrote: Hi Andreas, Edgar, Hi Peter, This looks good to me. I'm afk most of this and the next week but will give run tests and put in my queue after that. Unless Andreas wants to take it through his queue. Thanks, Edgar Another 4

[Qemu-devel] [PATCH v2 5/8] hmp interface for dirty bitmap dump

2014-06-04 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap sanidhya.ii...@gmail.com --- hmp-commands.hx | 16 hmp.c | 16 hmp.h | 1 + 3 files changed, 33 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 2e462c0..1665587 100644 --- a/hmp-commands.hx

Re: [Qemu-devel] [PATCH] target-microblaze: Delete unused sign_extend() function

2014-06-04 Thread Edgar E. Iglesias
On Tue, Jun 03, 2014 at 06:59:21PM +0100, Peter Maydell wrote: The sign_extend() function is unused; delete it. Reviewed-by: Edgar E. Iglesias edgar.igles...@xilinx.com Peter, feel free to push this straight in. Thanks, Edgar Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- We

Re: [Qemu-devel] [PATCH 0/5] gtk: fixes, cleanups and text consoles without vte

2014-06-04 Thread Stefan Weil
Am 03.06.2014 10:01, schrieb Gerd Hoffmann: Hi, Current gtk patch queue. A bunch of cleanups and fixes. Most notable change is patch #5 which winds up qemu text terminal emulation in gtk, so '-chardev vc' works even when building without vte (i.e. on windows). Gerd Hoffmann (5):

Re: [Qemu-devel] [PATCH v1 13/16] target-arm: A64: Emulate the HVC insn

2014-06-04 Thread Alex Benn�e
Edgar E. Iglesias writes: On Tue, Jun 03, 2014 at 11:41:25AM +0100, Alex Bennée wrote: Edgar E. Iglesias writes: static inline void arm_log_exception(int idx) @@ -204,6 +205,11 @@ static inline uint32_t syn_aa64_svc(uint32_t imm16) return (EC_AA64_SVC ARM_EL_EC_SHIFT) |

[Qemu-devel] [RFC PATCH V2 0/2] support xen HVM direct kernel boot

2014-06-04 Thread Chunyan Liu
After your valuable suggestions, I'll continue the work to support stubdom. But since stubdom currently uses qemu-xen-traditional and will switch to qemu upstream in future, in a period of time, stubdom HVM direct kernel boot won't be in working status. So, before continuing the stubdom support

[Qemu-devel] [RFC PATCH V2 1/2] xen: pass kernel initrd to qemu

2014-06-04 Thread Chunyan Liu
xen side patch to support xen HVM direct kernel boot: support 'kernel', 'ramdisk', 'root', 'extra' in HVM config file, parse config file, pass -kernel, -initrd, -append parameters to qemu. It's working with seabios and non-stubdom. Rombios and stubdom cases are currently not supported. [config

[Qemu-devel] [RFC PATCH V2 2/2] qemu: support xen hvm direct kernel boot

2014-06-04 Thread Chunyan Liu
qemu side patch to support xen HVM direct kernel boot: if -kernel exists, calls xen_load_linux(), which will read kernel/initrd and add a linuxboot.bin or multiboot.bin option rom. The linuxboot.bin/multiboot.bin will load kernel/initrd and jump to execute kernel directly. It's working when xen

Re: [Qemu-devel] [PATCH 0/5] gtk: fixes, cleanups and text consoles without vte

2014-06-04 Thread Gerd Hoffmann
Hi Gerd, its great to get text terminals without VTE now. I tested the series on a Linux x86_64 host. Native QEMU for this host seems to work fine. QEMU for 64 bit Windows with wine64 shows several issues: * The text consoles are named vc1, vc2, vc3 in the menu. Yep. It's because we

[Qemu-devel] [PULL 5/7] docs/multiseat.txt: use autoseat

2014-06-04 Thread Gerd Hoffmann
When using the autoseat feature of systemd/logind we'll only need a single udev rule for the pci bridge, which simplifies the guest setup a bit. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/multiseat.txt | 54 +++--- 1 file changed, 31

[Qemu-devel] [PULL 4/7] input/vnc: use kbd delays in press_key

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/vnc.c b/ui/vnc.c index 61b1f93..1684206 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -1553,7 +1553,9 @@ static void press_key(VncState *vs, int keysym) { int keycode =

[Qemu-devel] [PULL 0/7] input patch queue

2014-06-04 Thread Gerd Hoffmann
Hi, This pull adds the keyboard delay support for the input layer and it updates the multiseat.txt doc file. please pull, Gerd The following changes since commit e00fcfeab3d452cba3d0a08991a39ab15df66424: Merge remote-tracking branch 'remotes/awilliam/tags/vfio-pci-for-qemu-20140602.0'

[Qemu-devel] [PULL 3/7] input/curses: add kbd delay between keydown and keyup events

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/curses.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/ui/curses.c b/ui/curses.c index de85f76..8edb038 100644 --- a/ui/curses.c +++ b/ui/curses.c @@ -277,31 +277,41 @@ static void curses_refresh(DisplayChangeListener *dcl)

[Qemu-devel] [PULL 7/7] docs/multiseat.txt: add note about spice

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/multiseat.txt | 8 1 file changed, 8 insertions(+) diff --git a/docs/multiseat.txt b/docs/multiseat.txt index dd3a831..67151e0 100644 --- a/docs/multiseat.txt +++ b/docs/multiseat.txt @@ -47,6 +47,14 @@ in a separate tab. You can

[Qemu-devel] [PULL 2/7] input: use kbd delays for send_key monitor command

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 45 ++--- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index 2a53860..3025f50 100644 --- a/ui/input-legacy.c +++

[Qemu-devel] [PULL 1/7] input: add support for kbd delays

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/input.h | 1 + ui/input.c | 108 +++-- 2 files changed, 106 insertions(+), 3 deletions(-) diff --git a/include/ui/input.h b/include/ui/input.h index aa99b0c..5d5ac00 100644 ---

[Qemu-devel] [PATCH v2] linux-user/signal.c: define __SIGRTMIN/MAX for non-GNU platforms

2014-06-04 Thread Natanael Copa
The __SIGRTMIN and __SIGRTMAX are glibc internals and are not available on all platforms, so we define those if they are missing. We also check that those corresponds with the posix variables SIGRTMIN/SIGRTMAX which may only be available during runtime. This is needed for musl libc.

Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation

2014-06-04 Thread Paolo Bonzini
Il 03/06/2014 11:54, Peter Maydell ha scritto: In system emulation it's clear how we should implement things: TARGET_WORDS_BIGENDIAN is never set, data accesses honour CPSR.E by doing MO_BE or MO_LE accesses, instruction accesses are always MO_LE, and SCTLR.B is implemented by XORing the address

[Qemu-devel] [PULL 6/7] docs/multiseat.txt: gtk joined the party

2014-06-04 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/multiseat.txt | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/docs/multiseat.txt b/docs/multiseat.txt index 126f39d..dd3a831 100644 --- a/docs/multiseat.txt +++ b/docs/multiseat.txt @@ -6,16 +6,20 @@

Re: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read

2014-06-04 Thread Fam Zheng
On Tue, 06/03 15:37, Paolo Bonzini wrote: I guess this is more of an RFC, but still a useful starting point for discussion. Il 03/06/2014 14:52, Fam Zheng ha scritto: diff --git a/include/hw/virtio/virtio-blk.h b/include/hw/virtio/virtio-blk.h index e406efa..74f0f32 100644 ---

Re: [Qemu-devel] [PATCH] aio: fix qemu_bh_schedule() bh-ctx race condition

2014-06-04 Thread Stefan Hajnoczi
On Tue, Jun 03, 2014 at 02:52:40PM +0200, Stefan Priebe - Profihost AG wrote: Tested-by: Stefan Priebe s.pri...@profihost.ag Thanks!

Re: [Qemu-devel] [PATCH v1 06/16] target-arm: Add FAR_EL2 and 3

2014-06-04 Thread Alex Benn�e
Edgar E. Iglesias writes: On Tue, Jun 03, 2014 at 11:22:51AM +0100, Alex Bennée wrote: Edgar E. Iglesias writes: Ahh my confusion from earlier is now clear. Perhaps the two commits should be merged? Hi, The point is to have a non-functional diff and then incrementally add the

Re: [Qemu-devel] [PATCH 1/3] nbd: Handle fixed new-style clients.

2014-06-04 Thread Stefan Hajnoczi
On Mon, Jun 02, 2014 at 11:09:02PM +0100, Hani Benhabiles wrote: On Mon, Jun 02, 2014 at 02:32:06PM +0200, Stefan Hajnoczi wrote: On Sat, May 31, 2014 at 10:39:40PM +0100, Hani Benhabiles wrote: Signed-off-by: Hani Benhabiles h...@linux.com --- include/block/nbd.h | 6 ++

Re: [Qemu-devel] [PATCH v3 0/8] virtio-blk: use alias properties in transport devices

2014-06-04 Thread Stefan Hajnoczi
On Tue, Jun 03, 2014 at 05:11:23PM +0200, Cornelia Huck wrote: On Fri, 30 May 2014 13:17:41 +0200 Stefan Hajnoczi stefa...@redhat.com wrote: v3: * Split qdev_alias_all_properties() into its own patch [Peter Crosthwaite] * Do not dereference DEVICE_CLASS(class) inline [Peter

[Qemu-devel] [PATCH v3 4/4] target-ppc: Add support for new nmi() CPU callback

2014-06-04 Thread Alexey Kardashevskiy
This defines a nmi() callback for POWERPC CPU class so the nmi HMP/QMP command gets supported for POWERPC machines. This calls POWERPC_EXCP_RESET (vector 0x100) in the guest to deliver NMI. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v3: * ppc_cpu_do_nmi() is exported from

[Qemu-devel] [PATCH v3 3/4] target-i386: Migrate to new nmi() CPU callback

2014-06-04 Thread Alexey Kardashevskiy
This defines a nmi() callback for i386 CPU class. This removes #ifdef I386 branch in qmp_inject_nmi so new i386's nmi() callback is going to be used for NMI. This changes code to inject NMI on the current CPU instead of injecting it on every CPU. However that does not seem to be an issue. Since

[Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-04 Thread Alexey Kardashevskiy
This introduces an NMI (non maskable interrupt) callback per CPU class which QMP's nmi command may use to issue NMI on a CPU. This adds support for it in qmp_inject_nmi(). Since no architecture supports it at the moment, there is no change in behaviour. This changes inject-nmi command

Re: [Qemu-devel] [PATCH 1/1] dataplane: bail out on unsupported transport

2014-06-04 Thread Stefan Hajnoczi
On Tue, Jun 03, 2014 at 05:31:06PM +0200, Cornelia Huck wrote: If the virtio transport does not support notifiers (like s390-virtio), we can't use dataplane. Bail out early and let the user know what is wrong. Signed-off-by: Cornelia Huck cornelia.h...@de.ibm.com ---

[Qemu-devel] [PATCH v3 2/4] target-s390x: Migrate to new nmi() CPU callback

2014-06-04 Thread Alexey Kardashevskiy
This defines a nmi() callback for s390 CPU class. This removes #ifdef s390 branch in qmp_inject_nmi so new s390's nmi() callback is going to be used for NMI. Since nmi()-calling code is platform independent, CPUState::cpu_index is used instead of S390CPU::env.cpu_num. There should not be any

[Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Alexey Kardashevskiy
This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The change to existing behaviour is that x86 only delivers NMI to the current monitored CPU now, not to every CPU. Please comment. Thanks. Changes: v3: * patches reorganized * comments from v2 addressed, more details are

Re: [Qemu-devel] [PATCH] migration: Increase default max_downtime from 30ms to 300ms

2014-06-04 Thread Alexey Kardashevskiy
On 05/05/2014 09:20 PM, Juan Quintela wrote: Alexey Kardashevskiy a...@ozlabs.ru wrote: On 04/13/2014 12:38 AM, Alexey Kardashevskiy wrote: On 03/27/2014 08:01 PM, Markus Armbruster wrote: Adding Juan. Ping? Patch is OK for me. Who else needs to be ok to get this in upstream? :)

Re: [Qemu-devel] [PATCH v2 5/6] qemu-bridge-helper: Fix fd leak in main()

2014-06-04 Thread Stefan Hajnoczi
On Wed, May 28, 2014 at 09:21:39PM +0800, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com initialize fd and ctlfd, and close them at the end Signed-off-by: Gonglei arei.gong...@huawei.com --- qemu-bridge-helper.c | 9 +++-- 1 file changed, 7 insertions(+), 2

Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak

2014-06-04 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: Call g_free() after cache_fini() in migration_end(), but do not call g_free() after call cache_fini() in xbzrle_cache_resize() which will cause memory leak. cache_init() and cache_fini() are pair, so need let cache_fini() call g_free(cache) to

Re: [Qemu-devel] [Bug 1324112] [NEW] qemu parallel building error on libcacard.la

2014-06-04 Thread Stefan Hajnoczi
On Wed, May 28, 2014 at 12:52:10PM -, tal zilcer wrote: im building qemu with a large make -j value(9). sometimes the build fails because of an error: libtool: link: ar cru .libs/libcacard.a stubs/arch-query-cpu-def.o stubs/clock-warp.o stubs/cpu-get-clock.o stubs/cpu-get-icount.o

Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected

2014-06-04 Thread Markus Armbruster
Chen Gang gang.chen.5...@gmail.com writes: 'encoded_buf' and 'current_buf' are lock protected during using in save_xbzrle_page() in ram_save_page(), and during freeing in migration_end(). So recommend to let them lock protected during starting, just like we have done to 'cache'. I'd

Re: [Qemu-devel] [PATCH qom v1 1/1] qom: object: remove parent pointer when unparenting

2014-06-04 Thread Stefan Hajnoczi
On Mon, Jun 02, 2014 at 10:35:30AM +1000, Peter Crosthwaite wrote: Ping! Andreas seems to be offline (vacation?). I'm sure he'll see this when he gets back. Stefan

Re: [Qemu-devel] [PATCH 1/1] Makefile: Correct path in stripping tool binaries

2014-06-04 Thread Peter Maydell
On 4 June 2014 02:37, Sam Bobroff sam.bobr...@au1.ibm.com wrote: Allow make install to handle tool binaries that reside in sub-directories. Without this patch make install will fail if it needs to strip a tool binary (e.g. debugging is not enabled) that is installed from a subdirectory. An

Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-04 Thread Kevin Wolf
Am 03.06.2014 um 17:51 hat Paolo Bonzini geschrieben: Il 03/06/2014 16:37, Kevin Wolf ha scritto: Am 03.06.2014 um 16:16 hat Paolo Bonzini geschrieben: With virtio-blk dataplane, I/O errors might occur while QEMU is not in the main I/O thread. However, it's invalid to call vm_stop when

Re: [Qemu-devel] [PATCH v2 4/8] linux-user: arm: handle CPSR.E correctly in strex emulation

2014-06-04 Thread Peter Maydell
On 4 June 2014 08:48, Paolo Bonzini pbonz...@redhat.com wrote: Il 03/06/2014 11:54, Peter Maydell ha scritto: In system emulation it's clear how we should implement things: TARGET_WORDS_BIGENDIAN is never set, data accesses honour CPSR.E by doing MO_BE or MO_LE accesses, instruction

[Qemu-devel] [PATCH v3 09/10] usb: tag usb host controller as hotpluggable

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com usb host controller should be able to support hotplug/unplug, as the same as the other pci devices, which not enable multifunction capability. BTW, the qemu have not the capability to support hotplug mulitfuncition pci devices at present. Signed-off-by:

[Qemu-devel] [PATCH v3 03/10] usb-ohci: add exit function

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com clean up ohci resource when ohci pci device exit. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ohci.c | 21 + 1 file changed, 21 insertions(+) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index dc1adbf..b513a13

[Qemu-devel] [PATCH v3 06/10] usb-ehci: add ehci unrealize funciton

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com cleanup ehci controller resource, both pci and sysbus if they're necessary. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ehci.c | 29 + hw/usb/hcd-ehci.h | 1 + 2 files changed, 30 insertions(+) diff --git

[Qemu-devel] [PATCH v3 07/10] usb-ehci: add ehci-pci device exit function

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com clean up ehci resource when ehci pci device exit. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ehci-pci.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/hw/usb/hcd-ehci-pci.c b/hw/usb/hcd-ehci-pci.c index

[Qemu-devel] [PATCH v3 01/10] usb: add usb_bus_release function

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com add global variables releasing logic when the usb buses were removed or hot-unpluged. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/bus.c | 7 +++ include/hw/usb.h | 1 + 2 files changed, 8 insertions(+) diff --git a/hw/usb/bus.c

[Qemu-devel] [PATCH v3 10/10] usb: add usb host adapters exit trace

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ehci.c | 2 ++ hw/usb/hcd-uhci.c | 2 ++ hw/usb/hcd-xhci.c | 2 ++ trace-events | 3 +++ 4 files changed, 9 insertions(+) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index

[Qemu-devel] [PATCH v3 05/10] usb-ehci: add vmstate properity for EHCIState

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com since hotunplug the ehci host adapter, we should delete vm_change_state_handler also, so the VMChangeStateEntry should be saved in EHCIState. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ehci.c | 2 +- hw/usb/hcd-ehci.h | 1 + 2 files

[Qemu-devel] [PATCH v3 02/10] usb-ohci: Fix memory leak for ohci timer

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-ohci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci.c b/hw/usb/hcd-ohci.c index cd87074..dc1adbf 100644 --- a/hw/usb/hcd-ohci.c +++ b/hw/usb/hcd-ohci.c @@

[Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com add support for usb host adapter hotplug, as the same as other pci devices. change since v2: * add ehci unrealize function suggested by Gerd. * add usb host adapters exit trace. * rebase on latest qemu master tree. changes since v1: * rework

[Qemu-devel] [PATCH v3 04/10] usb-uhci: clean up uhci resource when pci-uhci exit

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com clean up uhci resource when uhci pci device exit. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-uhci.c | 16 1 file changed, 16 insertions(+) diff --git a/hw/usb/hcd-uhci.c b/hw/usb/hcd-uhci.c index c3bf72c..4e8a640 100644

Re: [Qemu-devel] [PATCH 4/4] s390x/kvm: hw debugging support via guest PER facility

2014-06-04 Thread David Hildenbrand
On 30/05/14 11:01, Alexander Graf wrote: On 30.05.14 10:57, Christian Borntraeger wrote: On 30/05/14 10:32, Alexander Graf wrote: +case KVM_HW_BP: +if (find_hw_breakpoint(arch_info-addr, -1, arch_info-type)) { +ret = EXCP_DEBUG; +} +

Re: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 09:53, Fam Zheng ha scritto: For the sake of restarting requests, we also need dataplane to populate the out field for dataplane. We can also take the occasion to change it from struct virtio_blk_outhdr * to struct virtio_blk_outhdr for non-dataplane and use iov_discard_front

Re: [Qemu-devel] [PATCH v27 07/33] QemuOpts: add qemu_opt_get_*_del functions for replace work

2014-06-04 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 05:58:32PM +0800, Chunyan Liu wrote: diff --git a/util/qemu-option.c b/util/qemu-option.c index 4d2d4d1..32e1d50 100644 --- a/util/qemu-option.c +++ b/util/qemu-option.c @@ -575,6 +575,19 @@ static void qemu_opt_del(QemuOpt *opt) g_free(opt); } +/*

Re: [Qemu-devel] [PATCH] block: asynchronously stop the VM on I/O errors

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 10:28, Kevin Wolf ha scritto: Breaking this invariant means that you have a very small window where {'execute':'cont'} would actually not restart the VM. I think this should be fixed by dropping the request in vm_start, like this: [...] Sounds like an option. Do we need to send

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 10:08, Alexey Kardashevskiy ha scritto: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The change to existing behaviour is that x86 only delivers NMI to the current monitored CPU now, not to every CPU. Please comment. Thanks. Changes: v3: * patches

[Qemu-devel] [PATCH v3 08/10] usb-xhci: add exit function

2014-06-04 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com clean up xhci resource when xhci pci device exit. Signed-off-by: Gonglei arei.gong...@huawei.com --- hw/usb/hcd-xhci.c | 46 ++ 1 file changed, 46 insertions(+) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Peter Maydell
On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The change to existing behaviour is that x86 only delivers NMI to the current monitored CPU now, not to every CPU. So this series means that the nmi

Re: [Qemu-devel] [PATCH v27 00/33] replace QEMUOptionParameter with QemuOpts

2014-06-04 Thread Stefan Hajnoczi
On Wed, May 07, 2014 at 05:58:25PM +0800, Chunyan Liu wrote: This patch series is to replace QEMUOptionParameter with QemuOpts, so that only one Qemu Option structure is kept in QEMU code. --- Changes to v26: * Following Eric's comment, backward split 2/33, 3/33. (repurpose

Re: [Qemu-devel] [PATCH resend] block: fix wrong order in live block migration setup

2014-06-04 Thread Stefan Hajnoczi
On Wed, Jun 04, 2014 at 11:47:37AM +0800, chai wen wrote: The function init_blk_migration is better to be called before set_dirty_tracking as the reasons below. If we want to track dirty blocks via dirty_maps on a BlockDriverState when doing live block-migration, its correspoding

Re: [Qemu-devel] [PATCH 5/5] virtio-blk: Drop VirtIOBlockReq.read

2014-06-04 Thread Stefan Hajnoczi
On Tue, Jun 03, 2014 at 03:37:29PM +0200, Paolo Bonzini wrote: QEMUIOVector *inhdr;/* iovecs for virtio_blk_inhdr */ This can be unified with the in field; the status is only one byte, so using a full-blown QEMUIOVector is overkill. Stefan, what do you think? I thought

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Alexey Kardashevskiy
On 06/04/2014 07:16 PM, Peter Maydell wrote: On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The change to existing behaviour is that x86 only delivers NMI to the current monitored CPU now, not to every

Re: [Qemu-devel] [PATCH v2] qemu-img: Document check exit codes

2014-06-04 Thread Stefan Hajnoczi
On Mon, Jun 02, 2014 at 10:15:21PM +0200, Max Reitz wrote: The exit code 63 (check not supported by image format) was not even documented in the comment above the check command in the source code; add it, as it does indeed seem useful. Also, document all of check's exit codes in the manpage.

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Peter Maydell
On 4 June 2014 10:30, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/04/2014 07:16 PM, Peter Maydell wrote: On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The change to existing behaviour is that x86

Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Free 'cache' in cache_fini() to avoid memory leak

2014-06-04 Thread Dr. David Alan Gilbert
* Chen Gang (gang.chen.5...@gmail.com) wrote: Call g_free() after cache_fini() in migration_end(), but do not call g_free() after call cache_fini() in xbzrle_cache_resize() which will cause memory leak. cache_init() and cache_fini() are pair, so need let cache_fini() call g_free(cache) to

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Alexander Graf
On 04.06.14 11:33, Peter Maydell wrote: On 4 June 2014 10:30, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/04/2014 07:16 PM, Peter Maydell wrote: On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported. The

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Alexey Kardashevskiy
On 06/04/2014 07:33 PM, Peter Maydell wrote: On 4 June 2014 10:30, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/04/2014 07:16 PM, Peter Maydell wrote: On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are supported.

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 11:33, Peter Maydell ha scritto: On 4 June 2014 10:30, Alexey Kardashevskiy a...@ozlabs.ru wrote: On 06/04/2014 07:16 PM, Peter Maydell wrote: On 4 June 2014 09:08, Alexey Kardashevskiy a...@ozlabs.ru wrote: This adds an NMI handler per CPUs. x86, s390 and ppc CPUS are

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Peter Maydell
On 4 June 2014 10:39, Paolo Bonzini pbonz...@redhat.com wrote: It's a kind of emergency button on real machines. On PCs it sends an NMI and this results in some kind of crash dump if the OS is configured appropriately. The command may be ill-named for historical reasons, but the effect is

Re: [Qemu-devel] [PATCH v3 0/4] cpus: Add generic NMI support

2014-06-04 Thread Alexander Graf
On 04.06.14 11:47, Peter Maydell wrote: On 4 June 2014 10:39, Paolo Bonzini pbonz...@redhat.com wrote: It's a kind of emergency button on real machines. On PCs it sends an NMI and this results in some kind of crash dump if the OS is configured appropriately. The command may be ill-named for

Re: [Qemu-devel] [PATCH v2] thread-pool: fix deadlock when callbacks depends on each other

2014-06-04 Thread Stefan Hajnoczi
On Mon, Jun 02, 2014 at 09:15:27AM +0200, Marcin Gibuła wrote: When two coroutines submit I/O and first coroutine depends on second to complete (by calling bdrv_drain_all), deadlock may occur. bdrv_drain_all() is a very heavy-weight operation. Coroutines should avoid it if possible. Please

Re: [Qemu-devel] [PATCH-trivial] arch_init.c: Always be sure that 'encoded_buf' and 'current_buf' are lock protected

2014-06-04 Thread Dr. David Alan Gilbert
* Chen Gang (gang.chen.5...@gmail.com) wrote: Firstly, thank you very much for reviewing the related 2 patches. On 06/03/2014 03:31 PM, ChenLiang wrote: On 2014/6/2 20:35, Chen Gang wrote: 'encoded_buf' and 'current_buf' are lock protected during using in save_xbzrle_page() in

Re: [Qemu-devel] [PATCH v2 1/8] enable sharing of the function between migration and bitmap dump

2014-06-04 Thread Juan Quintela
Sanidhya Kashyap sanidhya.ii...@gmail.com wrote: As advised by Eric, I have enabled sharing of the function between of the function that syncs the dirty bitmap obtained via kvm ioctl. I have tried to make the least changes to the functions by concentrating only on the function definitions.

Re: [Qemu-devel] [PATCH v2 3/8] RunState: added two new flags for bitmap dump and migration process

2014-06-04 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: I have added two new flags - RUN_STATE_MIGRATE and RUN_STATE_DUMP_BITMAP. These both flags behave same as RUN_STATE_RUNNING flag. The purpose of introducing these flags is to avoid running both migration and dump bitmap process

Re: [Qemu-devel] [PATCH v2 4/6] target-arm: add emulation of PSCI calls for system emulation

2014-06-04 Thread Rob Herring
On Tue, Jun 3, 2014 at 6:14 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 23 May 2014 03:30, Rob Herring robherri...@gmail.com wrote: From: Rob Herring rob.herr...@linaro.org Add support for handling PSCI calls in system emulation. Both version 0.1 and 0.2 of the PSCI spec are

Re: [Qemu-devel] [Bug 1324112] [NEW] qemu parallel building error on libcacard.la

2014-06-04 Thread tal zilcer
Version 2.0.0 Isn’t the libcacard Makefile run as a recursive make? how do you keep the dependencies between two different makes(libcacard and trace)? -Original Message- From: boun...@canonical.com [mailto:boun...@canonical.com] On Behalf Of Stefan Hajnoczi Sent: Wednesday, June 04,

Re: [Qemu-devel] [PATCH v2 2/8] bitmap dump code via QAPI framework

2014-06-04 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: Following are the changes made with respect to the previous version: Chen's advice +if (qemu_write_full(fd, ram_bitmap_pages, sizeof(int64_t)) 0) { +b-state = LOG_BITMAP_STATE_ERROR; +goto log_thread_end; +} + +

Re: [Qemu-devel] [PATCH v2 1/8] enable sharing of the function between migration and bitmap dump

2014-06-04 Thread Sanidhya Kashyap
Exporting a function without a prefix could be dangerous. Later, Juan. Any particular solution, as the function is being used at two places. -- Sanidhya Kashyap

Re: [Qemu-devel] [PATCH v2 4/6] target-arm: add emulation of PSCI calls for system emulation

2014-06-04 Thread Peter Maydell
On 4 June 2014 11:09, Rob Herring robherri...@gmail.com wrote: On Tue, Jun 3, 2014 at 6:14 AM, Peter Maydell peter.mayd...@linaro.org wrote: This won't build on non-Linux hosts: you can't assume the linux-headers/ includes are available except within code guarded by CONFIG_KVM. What do you

Re: [Qemu-devel] [PATCH v2] thread-pool: fix deadlock when callbacks depends on each other

2014-06-04 Thread Paolo Bonzini
Il 04/06/2014 12:01, Stefan Hajnoczi ha scritto: Without this patch, I could reproduce this bug with snapshot-commit with about 1 per 10 tries. With this patch, I couldn't reproduce it any more. Signed-off-by: Marcin Gibula m.gib...@beyond.pl --- This is an interesting bug that definitely

  1   2   3   4   5   >