Re: [Qemu-devel] [PATCH 3/3] ppc debug: Add debug stub support

2014-06-12 Thread bharat.bhus...@freescale.com
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Wednesday, June 11, 2014 6:35 PM > To: Bhushan Bharat-R65777 > Cc: qemu-...@nongnu.org; qemu-devel@nongnu.org > Subject: Re: [PATCH 3/3] ppc debug: Add debug stub support > > On 06/10/2014 05:06 PM, Bharat Bhushan

Re: [Qemu-devel] [PATCH v28 00/33] replace QEMUOptionParameter with QemuOpts

2014-06-12 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Thu, Jun 05, 2014 at 05:20:39PM +0800, Chunyan Liu wrote: >> This patch series is to replace QEMUOptionParameter with QemuOpts, so that >> only >> one Qemu Option structure is kept in QEMU code. >> >> --- >> Changes to v27: >> * rebase to git master (code has been

Re: [Qemu-devel] [PATCH] add command to position mouse pointer in absolute mode

2014-06-12 Thread Markus Armbruster
Gerd Hoffmann writes: > Hi, > >> +.name = "mouse_move_abs", >> +.args_type = "dx_str:s,dy_str:s,dz_str:s?", >> +.params = "dx dy [dz]", >> +.help = "send mouse move events (absolute coordinates)", >> +.mhandler.cmd = do_mouse_move_abs, >>

Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5

2014-06-12 Thread Michael S. Tsirkin
On Tue, Jun 10, 2014 at 07:15:13PM +0800, Hu Tao wrote: > note: based on MST's numa tree. > > changes are error messages and docs tweaks to address comments to > v4. Applied, numa tree applied to the pci tree as well. Two points I would like to see addressed before it's going upstream: -

Re: [Qemu-devel] Using virtio for inter-VM communication

2014-06-12 Thread Henning Schild
On Thu, 12 Jun 2014 08:48:04 +0200 Markus Armbruster wrote: > Vincent JARDIN writes: > > > On 10/06/2014 18:48, Henning Schild wrote:> Hi, > >> In a first prototype i implemented a ivshmem[2] device for the > >> hypervisor. That way we can share memory between virtual machines. > >> Ivshmem is

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini wrote: > Il 29/05/2014 11:12, Greg Kurz ha scritto: > > int virtio_load(VirtIODevice *vdev, QEMUFile *f) > > { > > [...] > > nheads = vring_avail_idx(&vdev->vq[i]) - > > vdev->vq[i].last_avail_idx; > >^^^

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: > On Thu, 29 May 2014 12:16:26 +0200 > Paolo Bonzini wrote: > > Il 29/05/2014 11:12, Greg Kurz ha scritto: > > > int virtio_load(VirtIODevice *vdev, QEMUFile *f) > > > { > > > [...] > > > nheads = vring_avail_idx(&vdev->vq[i])

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto: > I would use the /machine object itself, not an extra object. Otherwise > this looks good. "/machine" object is "machine" parameter from s390_init()? How do I add an interface to it? Create a machine class as it is done by spapr_machine_in

Re: [Qemu-devel] [PATCH v5 00/16] NUMA series v5

2014-06-12 Thread Hu Tao
On Thu, Jun 12, 2014 at 10:41:18AM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 10, 2014 at 07:15:13PM +0800, Hu Tao wrote: > > note: based on MST's numa tree. > > > > changes are error messages and docs tweaks to address comments to > > v4. > > Applied, numa tree applied to the pci tree as wel

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/3] spapr: add uuid/host details to device tree

2014-06-12 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: >> Useful for identifying the guest/host uniquely within the >> guest. Adding following properties to the guest root node. >> >> vm,uuid - uuid of the guest >> host-model - Host model number >> host-serial - Host mac

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/3] ppc: spapr-rtas - implement os-term rtas call

2014-06-12 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 06/10/2014 05:56 PM, Nikunj A Dadhania wrote: >> PAPR compliant guest calls this in absence of kdump. After >> receiving this call qemu could trigger a guest dump. This guest dump >> can be used to analyse using crash tool. >> >> Signed-off-by: Nikunj A Dadhani

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Igor Mammedov
On Thu, 12 Jun 2014 03:22:24 -0300 Eduardo Habkost wrote: > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > definitions to corresponding class registration code. > > Having the PC code converted to pure QOM registration code will help us > move PC-specific machine stat

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Marcel Apfelbaum
On Thu, 2014-06-12 at 10:02 +0200, Igor Mammedov wrote: > On Thu, 12 Jun 2014 03:22:24 -0300 > Eduardo Habkost wrote: > > > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > > definitions to corresponding class registration code. > > > > Having the PC code converted to p

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 03:22:24AM -0300, Eduardo Habkost wrote: > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > definitions to corresponding class registration code. > > Having the PC code converted to pure QOM registration code will help us > move PC-specific machine

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 11:12:01AM +0300, Marcel Apfelbaum wrote: > On Thu, 2014-06-12 at 10:02 +0200, Igor Mammedov wrote: > > On Thu, 12 Jun 2014 03:22:24 -0300 > > Eduardo Habkost wrote: > > > > > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > > > definitions to cor

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Igor Mammedov
On Thu, 12 Jun 2014 11:12:01 +0300 Marcel Apfelbaum wrote: > On Thu, 2014-06-12 at 10:02 +0200, Igor Mammedov wrote: > > On Thu, 12 Jun 2014 03:22:24 -0300 > > Eduardo Habkost wrote: > > > > > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > > > definitions to correspo

Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name

2014-06-12 Thread Markus Armbruster
"Michael S. Tsirkin" writes: > Names with spaces in them are nasty, let's not go there. Yes, they are, but please use '-' instead of '_'. I can see just a few devices with '_' in their name, but more than a hundred with '-'.

Re: [Qemu-devel] [PATCH applied] ich: get rid of spaces in type name

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 10:27:53AM +0200, Markus Armbruster wrote: > "Michael S. Tsirkin" writes: > > > Names with spaces in them are nasty, let's not go there. > > Yes, they are, but please use '-' instead of '_'. I can see just a few > devices with '_' in their name, but more than a hundred w

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Alexey Kardashevskiy
On 06/12/2014 05:42 PM, Paolo Bonzini wrote: > Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto: >>> > I would use the /machine object itself, not an extra object. Otherwise >>> > this looks good. >> >> "/machine" object is "machine" parameter from s390_init()? How do I add an >> interface to

Re: [Qemu-devel] [PATCH v2 12/22] target-mips: add ALIGN, DALIGN, BITSWAP and DBITSWAP instructions

2014-06-12 Thread Leon Alrae
On 11/06/2014 17:39, Richard Henderson wrote: > On 06/11/2014 08:19 AM, Leon Alrae wrote: >> * add missing zero register case > > What missing zero register case? > >> +if (rd == 0) { >> +/* Treat as NOP. */ >> +break; >> +} > > This is normally handled by

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Igor Mammedov
On Thu, 12 Jun 2014 11:13:49 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 12, 2014 at 03:22:24AM -0300, Eduardo Habkost wrote: > > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > > definitions to corresponding class registration code. > > > > Having the PC code conv

[Qemu-devel] [PULL 1/4] gtk: factor out keycode mapping

2014-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index b908936..01d48cc 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -877,22 +877,18 @@ static gboolean gd_scroll_event(GtkWidget *widget, GdkEvent

[Qemu-devel] [PULL 0/4] gtk patch queue

2014-06-12 Thread Gerd Hoffmann
Hi, This pull brings minor bugfixes and cleanups for gtk. For now I've left out the terminals-without-vte patch as it reportly causes problems on windows. cheers, Gerd The following changes since commit b780bf8eff43fc49b071795292dea5d05990fff3: Merge remote-tracking branch 'remotes/mjt/t

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Igor Mammedov
On Thu, 12 Jun 2014 11:20:05 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 12, 2014 at 11:12:01AM +0300, Marcel Apfelbaum wrote: > > On Thu, 2014-06-12 at 10:02 +0200, Igor Mammedov wrote: > > > On Thu, 12 Jun 2014 03:22:24 -0300 > > > Eduardo Habkost wrote: > > > > > > > This is a (mostly) b

[Qemu-devel] [PULL 3/4] gtk: factor out gtk3 grab into the new gd_grab_devices function

2014-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 100 +++ 1 file changed, 36 insertions(+), 64 deletions(-) diff --git a/ui/gtk.c b/ui/gtk.c index d201190..544126c 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1162,28 +1162,39 @@ static void gd_m

[Qemu-devel] [PULL 2/4] gtk: cleanup backend dependencies

2014-06-12 Thread Gerd Hoffmann
Make configure detect gtk x11 backend and link libX11 then. Make gtk backend specific code properly #ifdef'ed on the GTK_WINDOWING_* backends at runtime). Our gtk ui code should build and run fine on any platform now. This also fixes the linker failute due to the new XkbGetKeyboard call added by

[Qemu-devel] [PULL 4/4] gtk: update window size after showing/hiding tabs

2014-06-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- ui/gtk.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 544126c..b02fcd6 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -1005,12 +1005,14 @@ static void gd_menu_switch_vc(GtkMenuItem *item, void *opaque) static void gd_menu_show_tabs(Gt

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 10:35, Alexey Kardashevskiy ha scritto: On 06/12/2014 05:42 PM, Paolo Bonzini wrote: Il 12/06/2014 02:08, Alexey Kardashevskiy ha scritto: I would use the /machine object itself, not an extra object. Otherwise this looks good. "/machine" object is "machine" parameter from s390_

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 10:54:48 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: > > On Thu, 29 May 2014 12:16:26 +0200 > > Paolo Bonzini wrote: > > > Il 29/05/2014 11:12, Greg Kurz ha scritto: > > > > int virtio_load(VirtIODevice *vdev, QEMUFile *f) > >

Re: [Qemu-devel] [RFC] pc: Register machine classes directly instead of using QEMUMachine

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 10:37:29AM +0200, Igor Mammedov wrote: > On Thu, 12 Jun 2014 11:13:49 +0300 > "Michael S. Tsirkin" wrote: > > > On Thu, Jun 12, 2014 at 03:22:24AM -0300, Eduardo Habkost wrote: > > > This is a (mostly) blind and mechanical conversion of the PC QEMUMachine > > > definitions

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
On 12.06.14 09:54, Michael S. Tsirkin wrote: On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini wrote: Il 29/05/2014 11:12, Greg Kurz ha scritto: int virtio_load(VirtIODevice *vdev, QEMUFile *f) { [...] nheads = vring_avai

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 09:43, Greg Kurz ha scritto: Since we know that 0 < max_nr_ports < 32, is it acceptable to guess the correct endianness with a heuristic ? if (max_nr_ports > tswap32(s->config.max_nr_ports)) { max_nr_ports = bswap32(max_nr_ports); } if (max_nr_ports > tswap32(s->config.ma

[Qemu-devel] USB passthrough in qemu

2014-06-12 Thread Michal Suchanek
Hello, I hit bug https://bugs.launchpad.net/qemu/+bug/685096 and found the usb2.txt file in the source which is sadly not installed by the distribution. What I would like is an -usb2 option which instantiates both uhci/ohci and ehci root hubs. I don't particularly care if the buses appear as comp

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
On 12.06.14 10:55, Paolo Bonzini wrote: Il 12/06/2014 09:43, Greg Kurz ha scritto: Since we know that 0 < max_nr_ports < 32, is it acceptable to guess the correct endianness with a heuristic ? if (max_nr_ports > tswap32(s->config.max_nr_ports)) { max_nr_ports = bswap32(max_nr_ports); } i

Re: [Qemu-devel] Are -cdrom/-hda (or -drive if=ide) supposed to work in q35?

2014-06-12 Thread Markus Armbruster
Michael Tokarev writes: > 10.06.2014 10:34, Paolo Bonzini wrote: >> Il 10/06/2014 08:30, Michael Tokarev ha scritto: >>> Hello. >>> >>> The question is: are the drive shortcuts - -cdrom, -hda, -hdb etc - >>> supposed to work in -machine q35 too? Or are they merely ignored? >>> >>> qemu-system-

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 10:47:17AM +0200, Greg Kurz wrote: > On Thu, 12 Jun 2014 10:54:48 +0300 > "Michael S. Tsirkin" wrote: > > On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: > > > On Thu, 29 May 2014 12:16:26 +0200 > > > Paolo Bonzini wrote: > > > > Il 29/05/2014 11:12, Greg Kurz h

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
On 12.06.14 10:47, Greg Kurz wrote: On Thu, 12 Jun 2014 10:54:48 +0300 "Michael S. Tsirkin" wrote: On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini wrote: Il 29/05/2014 11:12, Greg Kurz ha scritto: int virtio_load(VirtIODevice *vde

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 10:55:42 +0200 Paolo Bonzini wrote: > Il 12/06/2014 09:43, Greg Kurz ha scritto: > > Since we know that 0 < max_nr_ports < 32, is it acceptable to guess > > the correct endianness with a heuristic ? > > > > if (max_nr_ports > tswap32(s->config.max_nr_ports)) { > > max_nr_

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 10:55:40AM +0200, Alexander Graf wrote: > > On 12.06.14 09:54, Michael S. Tsirkin wrote: > >On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: > >>On Thu, 29 May 2014 12:16:26 +0200 > >>Paolo Bonzini wrote: > >>>Il 29/05/2014 11:12, Greg Kurz ha scritto: > int

Re: [Qemu-devel] USB passthrough in qemu

2014-06-12 Thread Gerd Hoffmann
On Do, 2014-06-12 at 10:53 +0200, Michal Suchanek wrote: > Hello, > > I hit bug https://bugs.launchpad.net/qemu/+bug/685096 and found the > usb2.txt file in the source which is sadly not installed by the > distribution. > > What I would like is an -usb2 option which instantiates both uhci/ohci >

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
On 12.06.14 11:07, Michael S. Tsirkin wrote: On Thu, Jun 12, 2014 at 10:55:40AM +0200, Alexander Graf wrote: On 12.06.14 09:54, Michael S. Tsirkin wrote: On Thu, Jun 12, 2014 at 09:43:51AM +0200, Greg Kurz wrote: On Thu, 29 May 2014 12:16:26 +0200 Paolo Bonzini wrote: Il 29/05/2014 11:12, G

Re: [Qemu-devel] [PATCH v2] char: fix avail_connections init in qemu_chr_open_eventfd()

2014-06-12 Thread Gerd Hoffmann
On Mi, 2014-06-11 at 17:25 +0200, David Marchand wrote: > When trying to use a ivshmem server with qemu, ivshmem init code tries to > create a CharDriverState object for each eventfd retrieved from the server. > To create this object, a call to qemu_chr_open_eventfd() is done. > Right after this, b

Re: [Qemu-devel] [PATCH] rdma: bug fixes

2014-06-12 Thread Michael R. Hines
On 02/18/2014 10:34 AM, mrhi...@linux.vnet.ibm.com wrote: From: "Michael R. Hines" 1. Fix small memory leak in parsing inet address from command line in data_init() 2. Fix ibv_post_send() return value check and pass error code back up correctly. 3. Fix rdma_destroy_qp() segfault after failure

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 11:06, Greg Kurz ha scritto: On Thu, 12 Jun 2014 10:55:42 +0200 Paolo Bonzini wrote: Il 12/06/2014 09:43, Greg Kurz ha scritto: Since we know that 0 < max_nr_ports < 32, is it acceptable to guess the correct endianness with a heuristic ? if (max_nr_ports > tswap32(s->config.ma

[Qemu-devel] [PATCH] virtio-serial: remove useless set_config function

2014-06-12 Thread Paolo Bonzini
Its only contents are a dead memcpy. Since it is optional, drop the function altogether. Signed-off-by: Paolo Bonzini --- hw/char/virtio-serial-bus.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index 2b647b6..a2958ff 10064

Re: [Qemu-devel] [PATCH] scsi: Print command name in debug

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 07:41, Alexey Kardashevskiy ha scritto: This makes scsi_command_name() public. This makes use of scsi_command_name() in debug output for scsi-disk and spapr-vscsi host bus adapter. Before this, SCSI used to print hex numbers instead of human-friendly strings. This adds GET_EVENT_S

Re: [Qemu-devel] USB passthrough in qemu

2014-06-12 Thread Michal Suchanek
On 12 June 2014 11:08, Gerd Hoffmann wrote: > On Do, 2014-06-12 at 10:53 +0200, Michal Suchanek wrote: >> Hello, >> >> I hit bug https://bugs.launchpad.net/qemu/+bug/685096 and found the >> usb2.txt file in the source which is sadly not installed by the >> distribution. >> >> What I would like is

Re: [Qemu-devel] Using virtio for inter-VM communication

2014-06-12 Thread Vincent JARDIN
On 12/06/2014 09:44, Henning Schild wrote: It may be used, but that doesn't mean it's maintained, or robust >against abuse. My advice is to steer clear of it. Could you elaborate on why you advice against it? +1 elaborate please. beside the DPDK source code, some other common use cases: -

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 11:19:47AM +0200, Paolo Bonzini wrote: > Il 12/06/2014 11:06, Greg Kurz ha scritto: > >On Thu, 12 Jun 2014 10:55:42 +0200 > >Paolo Bonzini wrote: > > > >>Il 12/06/2014 09:43, Greg Kurz ha scritto: > >>>Since we know that 0 < max_nr_ports < 32, is it acceptable to guess > >

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Alexey Kardashevskiy
On 06/12/2014 04:31 PM, Cornelia Huck wrote: > On Thu, 12 Jun 2014 03:03:01 +1000 > Alexey Kardashevskiy wrote: > >> This implements an NMI interface for s390 machine. >> >> This removes #ifdef s390 branch in qmp_inject_nmi so new s390's >> nmi_monitor_handler() callback is going to be used for N

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Alexander Graf
On 12.06.14 11:38, Alexey Kardashevskiy wrote: On 06/12/2014 04:31 PM, Cornelia Huck wrote: On Thu, 12 Jun 2014 03:03:01 +1000 Alexey Kardashevskiy wrote: This implements an NMI interface for s390 machine. This removes #ifdef s390 branch in qmp_inject_nmi so new s390's nmi_monitor_handler()

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: Maybe just drop unnecessary stuff for new machine types? Then we won't need hacks to migrate it. For any machine type it's trivial to migrate it. All machine types including old ones can disregard the migrated values. Paolo

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
On 12.06.14 11:39, Paolo Bonzini wrote: Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: Maybe just drop unnecessary stuff for new machine types? Then we won't need hacks to migrate it. For any machine type it's trivial to migrate it. All machine types including old ones can disregard th

Re: [Qemu-devel] [PULL 0/4] gtk patch queue

2014-06-12 Thread Peter Maydell
On 12 June 2014 09:38, Gerd Hoffmann wrote: > Hi, > > This pull brings minor bugfixes and cleanups for gtk. > > For now I've left out the terminals-without-vte patch > as it reportly causes problems on windows. > > cheers, > Gerd > > The following changes since commit b780bf8eff43fc49b07179529

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Alexey Kardashevskiy
On 06/12/2014 07:39 PM, Alexander Graf wrote: > > On 12.06.14 11:38, Alexey Kardashevskiy wrote: >> On 06/12/2014 04:31 PM, Cornelia Huck wrote: >>> On Thu, 12 Jun 2014 03:03:01 +1000 >>> Alexey Kardashevskiy wrote: >>> This implements an NMI interface for s390 machine. This remove

Re: [Qemu-devel] [RFC PATCH V2 1/2] xen: pass kernel initrd to qemu

2014-06-12 Thread Ian Campbell
On Wed, 2014-06-04 at 15:34 +0800, Chunyan Liu wrote: > xen side patch to support xen HVM direct kernel boot: > support 'kernel', 'ramdisk', 'root', 'extra' in HVM config file, > parse config file, pass -kernel, -initrd, -append parameters to qemu. > It's working with seabios and non-stubdom. Rombi

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 11:43:20 +0200 Alexander Graf wrote: > > On 12.06.14 11:39, Paolo Bonzini wrote: > > Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: > >> Maybe just drop unnecessary stuff for new machine types? > >> Then we won't need hacks to migrate it. > > > > For any machine type it'

Re: [Qemu-devel] USB passthrough in qemu

2014-06-12 Thread Gerd Hoffmann
Hi, > However, for the piix4 which is the default platform and is desirable > due to driver issues in many cases no simple way to instantiate the > companion setup and have qemu automagically attach the devices > correctly exists. We havn't added shortcuts like this to qemu for a while. There

Re: [Qemu-devel] [PATCH v3 3/4] audio: Fix using freed pointer in wav_fini_out()

2014-06-12 Thread Gerd Hoffmann
Hi, > > doclose: > > if (fclose (wav->f)) { > > -dolog ("wav_fini_out: fclose %p failed\nReason: %s\n", > > - wav->f, strerror (errno)); > > +dolog ("wav_fini_out: fclose 'wav->f' failed\nReason: %s\n", > > + strerror (errno)); > > I would just

[Qemu-devel] [PATCH v3 1/7] enable sharing of the function between migration and bitmap dump

2014-06-12 Thread Sanidhya Kashyap
Added prefix qemu_ to the function as pointed out by Juan. Signed-off-by: Sanidhya Kashyap --- arch_init.c | 19 +++ include/exec/ram_addr.h | 4 2 files changed, 15 insertions(+), 8 deletions(-) diff --git a/arch_init.c b/arch_init.c index 23044c1..2fec98b 100

[Qemu-devel] [PATCH v3 3/7] bitmap dump code via QAPI framework with runstates

2014-06-12 Thread Sanidhya Kashyap
Reformatted the code and added the functionality of dumping the blocks' info which can be read by the user when required. I have also made the block name length global. Signed-off-by: Sanidhya Kashyap --- include/exec/cpu-all.h | 3 +- migration.c| 7 ++ qapi-schema.json |

[Qemu-devel] [PATCH v3 2/7] RunState: added two new flags for bitmap dump and migration process

2014-06-12 Thread Sanidhya Kashyap
Changed those files that were directly using the RUN_STATE_RUNNING flag. Now, they have been replaced by the runstate_is_running() function. Signed-off-by: Sanidhya Kashyap --- hw/usb/hcd-ehci.c | 2 +- hw/usb/redirect.c | 6 +++--- qapi-schema.json | 7 ++- vl.c | 29 ++

[Qemu-devel] [PATCH v3 0/7] Obtain dirty bitmap via VM logging

2014-06-12 Thread Sanidhya Kashyap
Hi, The following patches introduce the support of the dirty bitmap logging and dumping to a specified file. This patch addresses the issues raised by David and Juan. Since, I have not received any comments on the runstates, I'll keep them in the patch series. v2 --> v3 * Reformatted the code and

[Qemu-devel] [PATCH v3 4/7] hmp interface for dirty bitmap dump

2014-06-12 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 16 hmp.c | 16 hmp.h | 1 + 3 files changed, 33 insertions(+) diff --git a/hmp-commands.hx b/hmp-commands.hx index 5f1a677..cccd53e 100644 --- a/hmp-commands.hx +++ b/hmp-commands.hx @@

[Qemu-devel] [PATCH v3 7/7] python script for extracting bitmap from a binary file

2014-06-12 Thread Sanidhya Kashyap
The script has been modified to store the blocks' information in dictionary format that can be used by the user. Besides, that there was some issue with the script which I have rectified and it is working perfectly. For every iteration, the bitmap is followed by a character - 'M' which acts as a m

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
> Am 12.06.2014 um 12:14 schrieb Greg Kurz : > > On Thu, 12 Jun 2014 11:43:20 +0200 > Alexander Graf wrote: > >> >>> On 12.06.14 11:39, Paolo Bonzini wrote: >>> Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: Maybe just drop unnecessary stuff for new machine types? Then we won't

[Qemu-devel] [PATCH v3 5/7] cancel mechanism for an already running dump bitmap process

2014-06-12 Thread Sanidhya Kashyap
Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 14 ++ hmp.c| 5 + hmp.h| 1 + qapi-schema.json | 8 qmp-commands.hx | 20 savevm.c | 19 +++ 6 files changed, 67 insertions(+) diff --git a/hm

[Qemu-devel] [PATCH v3 6/7] set the frequency of the dump bitmap process

2014-06-12 Thread Sanidhya Kashyap
No, particular change except the function name changed - value_in_range(). Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 15 +++ hmp.c| 12 hmp.h| 1 + qapi-schema.json | 11 +++ qmp-commands.hx | 24 sa

Re: [Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text

2014-06-12 Thread Gerd Hoffmann
Hi, > 2097if (cursor_visible && cursor_offset < size && cursor_offset >= 0) > (23) Event divide_by_zero: In expression "cursor_offset / width", > division by expression "width" which may be zero has undefined behavior. > -if (cursor_visible && cursor_offset < size && cursor_off

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 12:39:27 +0200 Alexander Graf wrote: > > > > Am 12.06.2014 um 12:14 schrieb Greg Kurz : > > > > On Thu, 12 Jun 2014 11:43:20 +0200 > > Alexander Graf wrote: > > > >> > >>> On 12.06.14 11:39, Paolo Bonzini wrote: > >>> Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: >

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 11:39:42AM +0200, Paolo Bonzini wrote: > Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: > >Maybe just drop unnecessary stuff for new machine types? > >Then we won't need hacks to migrate it. > > For any machine type it's trivial to migrate it. All machine types > incl

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 11:43:20AM +0200, Alexander Graf wrote: > > On 12.06.14 11:39, Paolo Bonzini wrote: > >Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: > >>Maybe just drop unnecessary stuff for new machine types? > >>Then we won't need hacks to migrate it. > > > >For any machine type it

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 12:14:40PM +0200, Greg Kurz wrote: > On Thu, 12 Jun 2014 11:43:20 +0200 > Alexander Graf wrote: > > > > > On 12.06.14 11:39, Paolo Bonzini wrote: > > > Il 12/06/2014 11:37, Michael S. Tsirkin ha scritto: > > >> Maybe just drop unnecessary stuff for new machine types? > >

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Alexander Graf
> Am 12.06.2014 um 12:50 schrieb Greg Kurz : > > On Thu, 12 Jun 2014 12:39:27 +0200 > Alexander Graf wrote: > >> >> >>> Am 12.06.2014 um 12:14 schrieb Greg Kurz : >>> >>> On Thu, 12 Jun 2014 11:43:20 +0200 >>> Alexander Graf wrote: >>> >> On 12.06.14 11:39, Paolo Bonzini wrote:

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 12:50:56PM +0200, Greg Kurz wrote: > On Thu, 12 Jun 2014 12:39:27 +0200 > Alexander Graf wrote: > > > > > > > > Am 12.06.2014 um 12:14 schrieb Greg Kurz : > > > > > > On Thu, 12 Jun 2014 11:43:20 +0200 > > > Alexander Graf wrote: > > > > > >> > > >>> On 12.06.14 11:3

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Cornelia Huck
On Thu, 12 Jun 2014 19:38:40 +1000 Alexey Kardashevskiy wrote: > On 06/12/2014 04:31 PM, Cornelia Huck wrote: > > On Thu, 12 Jun 2014 03:03:01 +1000 > > Alexey Kardashevskiy wrote: > > > >> This implements an NMI interface for s390 machine. > >> > >> This removes #ifdef s390 branch in qmp_injec

Re: [Qemu-devel] [PATCH v3 4/4] vga: Fix divide-by-zero in vga_update_text

2014-06-12 Thread Paolo Bonzini
Il 12/06/2014 12:43, Gerd Hoffmann ha scritto: That doesn't fix the reported issue. It's "width" which Coverity thinks might be zero, not cursor_offset. And cursor_offset being zero is perfectly fine, happens when the cursor is in the upper left corner. I have no idea why Coverity thinks width

Re: [Qemu-devel] [PATCH RFC 8/8] virtio: add endian-ambivalent support to VirtIODevice

2014-06-12 Thread Greg Kurz
On Thu, 12 Jun 2014 13:59:59 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 12, 2014 at 12:50:56PM +0200, Greg Kurz wrote: > > On Thu, 12 Jun 2014 12:39:27 +0200 > > Alexander Graf wrote: > > > > > > > > > > > > Am 12.06.2014 um 12:14 schrieb Greg Kurz : > > > > > > > > On Thu, 12 Jun 2014

Re: [Qemu-devel] [PATCH v3 2/7] RunState: added two new flags for bitmap dump and migration process

2014-06-12 Thread Sanidhya Kashyap
> int runstate_is_running(void) > { > -return runstate_check(RUN_STATE_RUNNING); > +return (runstate_check(RUN_STATE_RUNNING) || > +runstate_check(RUN_STATE_MIGRATE) || > +runstate_check(RUN_STATE_DUMP_BITMAP)); > } Forgot to apply the checkpatch script. The retu

Re: [Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-12 Thread Gerd Hoffmann
On Mi, 2014-06-11 at 09:23 +, Gonglei (Arei) wrote: > Hi, > > Gerd, do you plan to apply and pull the patch serials? Thanks! Series looks sane, I want run some stress tests on them before committing though. Havn't found yet the time to do that. > I have finished some qtest cases for usb hos

Re: [Qemu-devel] [PATCH v2 0/2] vnc: Drop some superfluous conditionals

2014-06-12 Thread Gerd Hoffmann
On Fr, 2014-06-06 at 18:47 +0200, Markus Armbruster wrote: > Markus Armbruster (2): > vnc: Drop superfluous conditionals around g_free() > vnc: Drop superfluous conditionals around g_strdup() > > ui/vnc-tls.c | 6 ++ > ui/vnc.c | 15 --- > 2 files changed, 6 insertions(+)

Re: [Qemu-devel] [PATCH] audio: Drop superfluous conditionals around g_free()

2014-06-12 Thread Gerd Hoffmann
On Fr, 2014-06-06 at 18:35 +0200, Markus Armbruster wrote: > Signed-off-by: Markus Armbruster > --- > audio/alsaaudio.c | 12 > audio/audio_template.h | 15 --- > audio/ossaudio.c | 6 ++ > hw/audio/adlib.c | 4 +--- > 4 files changed, 11 insertions

[Qemu-devel] [PATCH v3 3/7][RESEND PATCH] bitmap dump code via QAPI framework with runstates

2014-06-12 Thread Sanidhya Kashyap
Reformatted the code and added the functionality of dumping the blocks' info which can be read by the user when required. I have also made the block name length global. Signed-off-by: Sanidhya Kashyap --- include/exec/cpu-all.h | 3 +- migration.c| 7 ++ qapi-schema.json |

Re: [Qemu-devel] [PATCH 1/9] block: Create bdrv_fill_options()

2014-06-12 Thread Benoît Canet
The Wednesday 11 Jun 2014 à 16:04:55 (+0200), Kevin Wolf wrote : > The idea of bdrv_fill_options() is to convert every parameter for > opening images, in particular the filename and flags, to entries in the > options QDict. > > This patch starts with moving the filename parsing and driver probing

[Qemu-devel] [PATCH 2/7] virtio-scsi: start preparing for any_layout

2014-06-12 Thread Paolo Bonzini
- Introduce virtio_scsi_init_req and virtio_scsi_free_req - rename qemu_sgl_init_external to qemu_sgl_concat - move virtio_scsi_parse_req from virtio_scsi_pop_req to callers and add header length checks to virtio_scsi_parse_req. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 121 ++

[Qemu-devel] [PATCH 1/7] util: add return value to qemu_iovec_concat_iov

2014-06-12 Thread Paolo Bonzini
This will be necessary later to recognize the case where a request has both dataout and datain. Signed-off-by: Paolo Bonzini --- include/qemu-common.h | 6 +++--- util/iov.c| 10 ++ 2 files changed, 9 insertions(+), 7 deletions(-) diff --git a/include/qemu-common.h b/includ

[Qemu-devel] [PATCH 0/7] virtio-scsi: do not rely on iov boundaries

2014-06-12 Thread Paolo Bonzini
The upcoming virtio 1.0 standard requires virtio devices not to rely on iov boundaries when parsing requests or sending responses. This series converts virtio-scsi. Please review. Patch 3 is a free bugfix that is easier after the previous patch. Paolo Paolo Bonzini (7): util: add return value

[Qemu-devel] [PATCH 6/7] virtio-scsi: introduce virtio_scsi_complete_cmd_req

2014-06-12 Thread Paolo Bonzini
This is also related to sense handling, and will be used by anylayout. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index 60f77cd..107e9cb 100644 --- a/hw/scsi/

[Qemu-devel] [PATCH 5/7] virtio-scsi: prepare sense data handling for any_layout

2014-06-12 Thread Paolo Bonzini
Retrieve sense and copy it to guest memory, to prepare for when we will use qemu_iovec_from_buf. Swap response and request, since we'll use the tail of VirtIOSCSIReq for the CDB. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 22 -- 1 file changed, 12 insertions(+)

[Qemu-devel] [PATCH 4/7] virtio-scsi: add extra argument and return type to qemu_sgl_concat

2014-06-12 Thread Paolo Bonzini
Will be used for anylayout support. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 27 --- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index c32c99b..7337dbf 100644 --- a/hw/scsi/virtio-scsi.c +++

[Qemu-devel] [PATCH 3/7] virtio-scsi: add target swap for VirtIOSCSICtrlTMFReq fields

2014-06-12 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index e548ad3..c32c99b 100644 --- a/hw/scsi/virtio-scsi.c +++ b/hw/scsi/virtio-scsi.c @@ -207,6 +207,7 @@ static void virti

[Qemu-devel] [PATCH v2] spapr: add uuid/host details to device tree

2014-06-12 Thread Nikunj A Dadhania
Useful for identifying the guest/host uniquely within the guest. Adding following properties to the guest root node. vm,uuid - uuid of the guest host-model - Host model number host-serial - Host machine serial number hypervisor type - Tells its "kvm" Signed-off-by: Nikunj A Dadhania --- v2: ind

[Qemu-devel] [PATCH 7/7] virtio-scsi: add support for the any_layout feature

2014-06-12 Thread Paolo Bonzini
Store the request and response headers by value, and let virtio_scsi_parse_req check that there is only one of datain and dataout. Signed-off-by: Paolo Bonzini --- hw/scsi/virtio-scsi.c | 161 ++-- include/hw/i386/pc.h| 4 + include/hw/

Re: [Qemu-devel] [PULL 0/4] migration queue

2014-06-12 Thread Juan Quintela
Peter Maydell wrote: > On 10 June 2014 17:31, Juan Quintela wrote: >> Hi >> >> This includes: >> >> - last two patches that remove version_minimum_id_old. >> >> - refactor of opening of files was already tested (this is test-vmstate only) >> - v4 of flags in ram_load from Peter. >> >> Please, app

[Qemu-devel] [PATCH v2] ppc: spapr-rtas - implement os-term rtas call

2014-06-12 Thread Nikunj A Dadhania
PAPR compliant guest calls this in absence of kdump. After receiving this call qemu could trigger a guest dump. This guest dump can be used to analyse using crash tool. Signed-off-by: Nikunj A Dadhania --- v2: indentation fixes hw/ppc/spapr_rtas.c | 32 1 file

Re: [Qemu-devel] [PATCH 2/9] block: Move bdrv_fill_options() call to bdrv_open()

2014-06-12 Thread Benoît Canet
The Wednesday 11 Jun 2014 à 16:04:56 (+0200), Kevin Wolf wrote : > bs->options now contains the modified version of the options. > > Signed-off-by: Kevin Wolf > --- > block.c | 26 -- > 1 file changed, 16 insertions(+), 10 deletions(-) > > diff --git a/block.c b/block.c

Re: [Qemu-devel] [PATCH 3/9] block: Move json: parsing to bdrv_fill_options()

2014-06-12 Thread Benoît Canet
The Wednesday 11 Jun 2014 à 16:04:57 (+0200), Kevin Wolf wrote : > Signed-off-by: Kevin Wolf > --- > block.c | 88 > + > 1 file changed, 45 insertions(+), 43 deletions(-) > > diff --git a/block.c b/block.c > index effb3e6..b9c2b41

Re: [Qemu-devel] [PATCH v3 00/10] usb: usb host adapter hotplug

2014-06-12 Thread Gonglei (Arei)
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: Thursday, June 12, 2014 7:33 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; Luonengjun; Huangweidong (C); Huangpeng > (Peter) > Subject: Re: [PATCH v3 00/10] usb: usb host adapter hotplug > > On Mi, 2014-06

Re: [Qemu-devel] [PATCH 7/7] virtio-scsi: add support for the any_layout feature

2014-06-12 Thread Michael S. Tsirkin
On Thu, Jun 12, 2014 at 02:09:08PM +0200, Paolo Bonzini wrote: > Store the request and response headers by value, and let > virtio_scsi_parse_req check that there is only one of datain > and dataout. > > Signed-off-by: Paolo Bonzini > --- > hw/scsi/virtio-scsi.c | 161 > ++

Re: [Qemu-devel] [PATCH v6 2/4] target-s390x: Migrate to new NMI interface

2014-06-12 Thread Alexey Kardashevskiy
On 06/12/2014 09:02 PM, Cornelia Huck wrote: > On Thu, 12 Jun 2014 19:38:40 +1000 > Alexey Kardashevskiy wrote: > >> On 06/12/2014 04:31 PM, Cornelia Huck wrote: >>> On Thu, 12 Jun 2014 03:03:01 +1000 >>> Alexey Kardashevskiy wrote: >>> This implements an NMI interface for s390 machine. >>>

  1   2   >