Re: [Qemu-devel] [PULL 2/7] input: use kbd delays for send_key monitor command

2014-09-26 Thread Amos Kong
On Wed, Jun 04, 2014 at 09:44:06AM +0200, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/input-legacy.c | 45 ++--- 1 file changed, 6 insertions(+), 39 deletions(-) diff --git a/ui/input-legacy.c b/ui/input-legacy.c index

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-26 Thread Gonglei (Arei)
Subject: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn v2: rebase Signed-off-by: Jan Vesely jano.ves...@gmail.com --- hw/usb/dev-hid.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH v3 13/18] spapr_pci: Enable DDW

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:17PM +1000, Alexey Kardashevskiy wrote: This implements DDW for emulated PHB. This advertises the query/create/remove RTAS tokens in device tree. This does not advertise the reset RTAS token though, will be added later. The ddw property is enabled by default

Re: [Qemu-devel] [RFC PATCH v3 14/18] spapr_pci_vfio: Call spapr_pci::reset on reset

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:18PM +1000, Alexey Kardashevskiy wrote: This enables use of the parent class rest() callback in VFIO. This effectively enables reset of PHBs TCE IOMMU object(s) which are not bus devices and do not get reset by qemu_devices_reset() called from a machine reset

Re: [Qemu-devel] [RFC PATCH v3 16/18] spapr_pci_vfio: Enable DDW

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:20PM +1000, Alexey Kardashevskiy wrote: This implements DDW for VFIO. Host kernel support is required for this. After this patch DDW will be enabled on all machines but pseries-2.1. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru --- Changes: v2: *

Re: [Qemu-devel] [RFC PATCH v3 17/18] vfio: Enable DDW ioctls to VFIO IOMMU driver

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:21PM +1000, Alexey Kardashevskiy wrote: This enables DDW RTAS-related ioctls in VFIO. Signed-off-by: Alexey Kardashevskiy a...@ozlabs.ru Reviewed-by: David Gibson da...@gibson.dropbear.id.au -- David Gibson| I'll have my music baroque, and

Re: [Qemu-devel] [RFC PATCH v3 12/18] spapr_rtas: Add Dynamic DMA windows (DDW) RTAS calls support

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:16PM +1000, Alexey Kardashevskiy wrote: NO RESET This adds support for Dynamic DMA Windows (DDW) option defined by the SPAPR specification which allows to have additional DMA window(s) which can support page sizes other than 4K. The existing implementation of

Re: [Qemu-devel] [RFC PATCH v3 15/18] linux headers update for SPAPR (DDW + EEH)

2014-09-26 Thread David Gibson
On Fri, Aug 29, 2014 at 08:12:19PM +1000, Alexey Kardashevskiy wrote: Since the changes are not in upstream yet, no tag or branch is specified here. EEH is included to have a chance of catching problems with some shifted IOCTL number or other random stuff like that. Signed-off-by: Alexey

[Qemu-devel] [Bug 1373362] Re: qemu-2.1.1 i386-softmmu compile error: q35_dsdt_applesmc_sta undeclared

2014-09-26 Thread Thomas Eschenbacher
I retried it on another machine, running Kubuntu 14.10 (x86_64) - fails at exactly the same point ! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1373362 Title: qemu-2.1.1 i386-softmmu compile

Re: [Qemu-devel] [RFC patch 0/6] vfio based pci pass-through for qemu/KVM on s390

2014-09-26 Thread Frank Blaschka
On Wed, Sep 24, 2014 at 10:05:57AM -0600, Alex Williamson wrote: On Wed, 2014-09-24 at 10:47 +0200, Frank Blaschka wrote: On Mon, Sep 22, 2014 at 02:47:31PM -0600, Alex Williamson wrote: On Fri, 2014-09-19 at 13:54 +0200, frank.blasc...@de.ibm.com wrote: This set of patches implements a

Re: [Qemu-devel] [PATCH v2 1/3] usb-hid: Move descriptor decision to usb-hid initfn

2014-09-26 Thread Gerd Hoffmann
Hi, -static void usb_hid_initfn(USBDevice *dev, int kind) +static void usb_hid_initfn(USBDevice *dev, int kind, + const USBDesc *usb1, const USBDesc *usb2, + Error **errp) I don't think it is a good idea that adding usb version as

Re: [Qemu-devel] [RFC PATCH v3 15/18] linux headers update for SPAPR (DDW + EEH)

2014-09-26 Thread Alexey Kardashevskiy
On 09/26/2014 03:40 PM, David Gibson wrote: On Fri, Aug 29, 2014 at 08:12:19PM +1000, Alexey Kardashevskiy wrote: Since the changes are not in upstream yet, no tag or branch is specified here. EEH is included to have a chance of catching problems with some shifted IOCTL number or other

[Qemu-devel] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com The patches mainly improve the error message printing. And adjust coding style of os-posix.c. Daemonize the QEMU process after initialization, QEMU will not detach from standard IO until it is ready to receive connections on any of its devices. So, using

[Qemu-devel] [PATCH v7 09/11] target-arm: A64: Emulate the SMC insn

2014-09-26 Thread Edgar E. Iglesias
From: Edgar E. Iglesias edgar.igles...@xilinx.com Signed-off-by: Edgar E. Iglesias edgar.igles...@xilinx.com --- target-arm/cpu.h | 1 + target-arm/helper-a64.c| 1 + target-arm/helper.c| 3 +++ target-arm/helper.h| 1 + target-arm/internals.h | 6 ++

Re: [Qemu-devel] [PATCH v6 08/10] target-arm: A64: Emulate the SMC insn

2014-09-26 Thread Edgar E. Iglesias
On Fri, Sep 26, 2014 at 12:43:40AM +0100, Peter Maydell wrote: On 26 September 2014 00:31, Edgar E. Iglesias edgar.igles...@gmail.com wrote: On Fri, Sep 26, 2014 at 12:17:59AM +0100, Peter Maydell wrote: Oh, yes, that's the trap enable bit. In that case we shouldn't be using EXCP_SMC:

Re: [Qemu-devel] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread Paolo Bonzini
Il 26/09/2014 10:14, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com The patches mainly improve the error message printing. And adjust coding style of os-posix.c. Daemonize the QEMU process after initialization, QEMU will not detach from standard IO until it is

Re: [Qemu-devel] [PATCH] qemu-ga: added windows support for 'guest-network-get-interfaces'

2014-09-26 Thread Markus Armbruster
Kenth Andersson ke...@eastmark.net writes: This is my first patch so I hope I got everything right. Here, this sentence is part of the commit message. It should go... Signed-off-by: Kenth Andersson ke...@eastmark.net --- ... here, below the '---' divider. As a happy Windows ignoramus, I

Re: [Qemu-devel] [PATCH 0/3] os-posix: improve the error message printing

2014-09-26 Thread Gonglei (Arei)
From: Paolo Bonzini [mailto:pbonz...@redhat.com] Subject: Re: [PATCH 0/3] os-posix: improve the error message printing Il 26/09/2014 10:14, arei.gong...@huawei.com ha scritto: From: Gonglei arei.gong...@huawei.com The patches mainly improve the error message printing. And adjust

Re: [Qemu-devel] [PATCH v2] qga: Rewrite code where using readdir_r

2014-09-26 Thread zhanghailiang
Hi, Ping...,plus;) This is a bug fix. Thanks, zhanghailiang On 2014/9/19 11:09, zhanghailiang wrote: If readdir_r fails, error_setg_errno will reference the freed pointer *dirpath*. Moreover, readdir_r may cause a buffer overflow, using readdir instead. Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v2] vl: Adjust the place of calling mlockall to speedup VM's startup

2014-09-26 Thread zhanghailiang
Hi, This has been reviewed, Will anyone pick this up?;) Thanks, zhanghailiang On 2014/9/23 18:42, zhanghailiang wrote: If we configure mlock=on and memory policy=bind at the same time, It will consume lots of time for system to treat with memory, especially when call mbind behind mlockall.

[Qemu-devel] [PATCH] ui/input: fix event emitting of repeated combined keys

2014-09-26 Thread Amos Kong
Currently we emit press events of combined keys first, then emit release events by reverse order. But it doesn't match with physical keyboard if the keys contain continued repeated keys. For example, (qemu) sendkey a-b-b Current emited events: (actually the second 'presse b' and 'release b'

[Qemu-devel] [PATCH RESEND 5/9] virtio-serial: use aliases instead of duplicate qdev properties

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com virtio-serial-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSerial child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to

[Qemu-devel] [PATCH RESEND 2/9] virtio: fix virtio-net child refcount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-net

[Qemu-devel] [PATCH RESEND 9/9] virtio-balloon: fix virtio-balloon child refcount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-balloon

[Qemu-devel] [PATCH] target-xtensa: avoid duplicate timer interrupt delivery

2014-09-26 Thread Max Filippov
Timer interrupt should be raised at the same cycle when CCOUNT equals CCOMPARE. As cycles are counted in batches, timer interrupt is sent every time CCOMPARE lies in the interval [old CCOUNT, new CCOUNT]. This is wrong, because when new CCOUNT equals CCOMPARE interrupt is sent twice, once for the

[Qemu-devel] [PATCH RESEND 3/9] virtio/vhost scsi: use aliases instead of duplicate qdev properties

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com {virtio, vhost}-scsi-{pci, s390, ccw} all duplicate the qdev properties of their VirtIOSCSI/VHostSCSI child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias

[Qemu-devel] [PATCH RESEND 0/9] virtio: fix virtio child recount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com virtio-$device-{pci, s390, ccw} all duplicate the qdev properties of their virtio child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward

[Qemu-devel] [PATCH RESEND 7/9] virtio-rng: use aliases instead of duplicate qdev properties

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com virtio-rng-{pci, s390, ccw} all duplicate the qdev properties of their VirtIORNG child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM alias property to forward

[Qemu-devel] [PATCH RESEND 4/9] virtio/vhost-scsi: fix virtio-scsi/vhost-scsi child refcount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the

[Qemu-devel] [PATCH RESEND 1/9] virtio-net: use aliases instead of duplicate qdev properties

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com virtio-net-pci, virtio-net-s390, and virtio-net-ccw all duplicate the qdev properties of their VirtIONet child. This approach does not work well with string or pointer properties since we must be careful about leaking or double-freeing them. Use the QOM

[Qemu-devel] [PATCH RESEND 8/9] virtio-rng: fix virtio-rng child refcount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-rng

[Qemu-devel] [PATCH RESEND 6/9] virtio-serial: fix virtio-serial child refcount in transports

2014-09-26 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com object_initialize() leaves the object with a refcount of 1. object_property_add_child() adds its own reference which is dropped again when the property is deleted. The upshot of this is that we always have a refcount = 1. Upon hot unplug the virtio-serial

[Qemu-devel] [RFC PATCH v0 2/2] target-ppc: Fix an invalid free in opcode table handling code.

2014-09-26 Thread Bharata B Rao
Opcode table has direct, indirect and double indirect handlers, but ppc_cpu_unrealizefn() frees direct handlers which are never allocated and never frees double indirect handlers. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- target-ppc/translate_init.c | 19 --- 1

[Qemu-devel] [RFC PATCH v0 1/2] target-ppc: Use macros in opcodes table handling code

2014-09-26 Thread Bharata B Rao
Define and use macros instead of direct numbers wherever possible in ppc opcodes table handling code. This doesn't change any code functionality. Signed-off-by: Bharata B Rao bhar...@linux.vnet.ibm.com --- target-ppc/cpu.h| 3 ++- target-ppc/translate_init.c | 24

[Qemu-devel] [RFC PATCH v0 0/2] target-ppc: Fix an invalid free

2014-09-26 Thread Bharata B Rao
g_free() in target-ppc/translate_init.c:ppc_cpu_unrealizefn() can fail due to invalid pointer being passed to it. Fix this along with a cleanup. I have never seen ppc_cpu_unrealizefn() getting called for sPAPR guests, but I ran into this issue when I was adding unrealize call from the CPU hot

Re: [Qemu-devel] [PACTH v4 5/6] target-arm: add emulation of PSCI calls for system emulation

2014-09-26 Thread Peter Maydell
On 10 September 2014 08:02, Ard Biesheuvel ard.biesheu...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org Add support for handling PSCI calls in system emulation. Both version 0.1 and 0.2 of the PSCI spec are supported. Platforms can enable support by setting the psci-conduit QOM

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-26 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 09/23/2014 08:56 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: Add check_keys to cover these situations, and update testcases to

[Qemu-devel] [PATCH v2] pc-dimm: Don't check dimm-node when there is non-NUMA config

2014-09-26 Thread zhanghailiang
It should not break memory hotplug feature if there is non-NUMA option. This patch would also allow to use pc-dimm as replacement for initial memory for non-NUMA configs. Note: After this patch, the memory hotplug can work normally for Linux guest OS when there is non-NUMA option and NUMA

Re: [Qemu-devel] [PULL v3 14/15] virtio-pci: fix migration for pci bus master

2014-09-26 Thread Nikunj A Dadhania
Hi Alex/Peter, The below patch is already been picked in master and ppc-next and has broken pseries booting from virtio-blk device Greg Kurz gk...@linux.vnet.ibm.com writes: On Tue, 23 Sep 2014 07:26:32 +0300 Michael S. Tsirkin m...@redhat.com wrote: This commit prevents pseries to

Re: [Qemu-devel] [PATCH v4 08/19] qapi: Better error messages for bad expressions

2014-09-26 Thread Kevin Wolf
Am 26.09.2014 um 11:15 hat Markus Armbruster geschrieben: Kevin Wolf kw...@redhat.com writes: Am 24.09.2014 um 09:34 hat Markus Armbruster geschrieben: Eric Blake ebl...@redhat.com writes: On 09/23/2014 08:56 AM, Markus Armbruster wrote: Eric Blake ebl...@redhat.com writes: Add

Re: [Qemu-devel] [PATCH v4 13/19] qapi: More rigourous checking of types

2014-09-26 Thread Markus Armbruster
Eric Blake ebl...@redhat.com writes: Now that we know every expression is valid with regards to its keys, we can add further tests that those keys refer to valid types. With this patch, all references to a type (the 'data': of command, type, union, and event, and the 'returns': of command)

[Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API

2014-09-26 Thread Igor Mammedov
Changes since v1: * added usb-uas test * drop hotplug check in bus_add_child() * make SCSI USB bus as default HotplugHandler * fixed dummy HBA hot(un)plug * fixed hotunplug on s390x * prevent hotplug of non hotpluggable devices -- Series unifies different hotplug mechanisms to a

[Qemu-devel] [PATCH v2 04/36] test: virtio-rng: check if hot-plug/unplug works

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: moved code duplication into library --- tests/Makefile | 2 +- tests/virtio-rng-test.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index f5de29c..e72c78c 100644

[Qemu-devel] [PATCH v2 10/36] test: usb: usb-storage hotplug test

2014-09-26 Thread Igor Mammedov
usb-storage is different from usual usb devices in that it uses child SCSI bus for underlying storage. That patch verifies that SCSI bus is hotpluggable for hotplug operation wouldn't succeed without it. Signed-off-by: Igor Mammedov imamm...@redhat.com --- tests/usb-hcd-uhci-test.c | 31

[Qemu-devel] [PATCH v2 01/36] test: virtio-scsi: check if hot-plug/unplug works

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- tests/virtio-scsi-test.c | 29 + 1 file changed, 29 insertions(+) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 3230908..41f9602 100644 ---

[Qemu-devel] [PATCH v2 02/36] test: virtio-serial: check if hot-plug/unplug works

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- tests/virtio-serial-test.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/tests/virtio-serial-test.c b/tests/virtio-serial-test.c index e743875..bf030a6 100644 ---

[Qemu-devel] [PATCH v2 13/36] qdev: do not allow to instantiate non hotpluggable device with device_add

2014-09-26 Thread Igor Mammedov
It will allow explicitly mark device as not hotpluggable and avoid its creation with following error at realize time and destroying it afterwards anyway. Instead of it will error out even before instance of device is created. Signed-off-by: Igor Mammedov imamm...@redhat.com --- qdev-monitor.c |

[Qemu-devel] [PATCH v2 03/36] test: libqos: add qpci_plug_device_test() and qpci_unplug_acpi_device_test()

2014-09-26 Thread Igor Mammedov
functions will be used for testing hot(un)plug of PCI devices. Signed-off-by: Igor Mammedov imamm...@redhat.com --- tests/libqos/pci-pc.c | 49 + tests/libqos/pci.h| 3 +++ 2 files changed, 52 insertions(+) diff --git a/tests/libqos/pci-pc.c

[Qemu-devel] [PATCH v2 05/36] test: virtio-net: check if hot-plug/unplug works

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: moved code duplication into library --- tests/Makefile | 2 +- tests/virtio-net-test.c | 10 ++ 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/tests/Makefile b/tests/Makefile index e72c78c..f2ee9d8 100644

[Qemu-devel] [PATCH v2 06/36] test: virtio-blk: check if hot-plug/unplug works

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: moved code duplication into library --- tests/virtio-blk-test.c | 49 ++--- 1 file changed, 38 insertions(+), 11 deletions(-) diff --git a/tests/virtio-blk-test.c b/tests/virtio-blk-test.c

[Qemu-devel] [PATCH v2 09/36] test: usb: generic usb device hotplug

2014-09-26 Thread Igor Mammedov
use usb-tablet as a hotplugged usb device. Signed-off-by: Igor Mammedov imamm...@redhat.com --- Since I'm not familiar with internals of USB, for OHCI/XHCI test doesn't verify that usb device has been hotplugged except of checking for error after hotplug. So port checks similar to that of

[Qemu-devel] [PATCH v2 18/36] qdev: drop hotplug check from bus_add_child()

2014-09-26 Thread Igor Mammedov
check is too restrictive and does not allow to add childs to just created bus during hotplug when the bus is part of composite device. Removing check from bus_add_child() doesn't affect devices creatable with device_add/del commands since they have a similar builtin checks and patch will allow to

[Qemu-devel] [PATCH v2 14/36] qdev: HotplugHandler: rename unplug callback to unplug_request

2014-09-26 Thread Igor Mammedov
'HotplugHandler.unplug' callback is currently used as async call to issue unplug request for device that implements it. Renaming 'unplug' callback to 'unplug_request' should help to avoid confusion about what callback does and would allow to introduce 'unplug' callback that would perform actual

[Qemu-devel] [PATCH v2 07/36] test: usb: move uhci port test code to libqos/usb.c

2014-09-26 Thread Igor Mammedov
Move code necessary for testing uhci port into library so it could be used by other USB tests. Signed-off-by: Igor Mammedov imamm...@redhat.com --- tests/Makefile| 3 ++- tests/libqos/usb.c| 37 + tests/libqos/usb.h| 14

Re: [Qemu-devel] [PATCH v1 3/3] monitor: add del completion for peripheral device

2014-09-26 Thread Andreas Färber
Hi, Am 18.09.2014 um 09:53 schrieb Zhu Guihua: Add peripheral_device_del_completion() to let peripheral device del completion be possible. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- monitor.c | 24 1 file changed, 24 insertions(+) diff --git

[Qemu-devel] [PATCH v2 12/36] access BusState.allow_hotplug using wraper qbus_is_hotpluggable()

2014-09-26 Thread Igor Mammedov
it would allow transparently switch detection if Bus is hotpluggable from allow_hotplug field to hotplug_handler link and drop allow_hotplug field once all users are converted to hotplug handler API. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com

[Qemu-devel] [PATCH v2 15/36] qdev: HotplugHandler: provide unplug callback

2014-09-26 Thread Igor Mammedov
it to be called for actual device removal and will allow to separate request and removal handling phases of x86-CPU devices and also it's a handler to be called for synchronously removable devices. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PATCH v2 08/36] test: usb: add port test to uhci unit test

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: split patch from code movment for ehci test --- tests/Makefile| 2 +- tests/usb-hcd-uhci-test.c | 18 -- 2 files changed, 17 insertions(+), 3 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index

[Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility

2014-09-26 Thread Igor Mammedov
s390-sclp-event-facility creates s390-sclp-events-bus and immeadiatly sets its allow_hotplug field to 0, which is NOP since it's already 0 by default. Also since BUS is not hotpluggable, it's not possible to call SCLP_EVENT{ DeviceClass.unplug } callback from qdev_unplug() making this unreachable

[Qemu-devel] [PATCH v2 20/36] virtio-pci: drop BusState.allow_hotplug

2014-09-26 Thread Igor Mammedov
virtio-pci-bus is an internal object of composite virtio-pci device and it doesn't participate in -device/device_add hotplug flow, and since it's not required by bus_add_child() that BUS must be hotpluggable to be able to add child at runtime, it's possible to drop not needed 'allow_hotplug'

[Qemu-devel] [PATCH v2 16/36] qdev: add simple/generic unplug callback for HotplugHandler

2014-09-26 Thread Igor Mammedov
it will be used in shallow conversion from legacy hotplug mechanism and eventually replace all the uses of old mechanism DeviceClass-unplug = qdev_simple_unplug_cb() Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 5

[Qemu-devel] [PATCH v2 25/36] s390x: convert virtio-ccw to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: fix not working unplug --- hw/s390x/virtio-ccw.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c index 33a1d86..09d9500 100644 --- a/hw/s390x/virtio-ccw.c

[Qemu-devel] [PATCH v2 24/36] s390x: convert s390-virtio to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: fix not working unplug --- hw/s390x/s390-virtio-bus.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/hw/s390x/s390-virtio-bus.c b/hw/s390x/s390-virtio-bus.c index 6b6fb61..b575d6c 100644 ---

[Qemu-devel] [PATCH v2 22/36] virtio-mmio: drop useless bus-allow_hotplug = 0

2014-09-26 Thread Igor Mammedov
Bus by default is not hotpluggable. virtio-mmio-bus and its parent types do not set allow_hotplug anywhere explicitly, so remove not needed field access and wrapper along with it. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PATCH v2 17/36] qdev: add wrapper to set BUS as HotplugHandler

2014-09-26 Thread Igor Mammedov
to be used for conversion of SCSI and USB devices, and would allow to make every HBA/USB host switch to HotplugHandler API without touching each controller explicitly. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/core/qdev.c | 19 +++ include/hw/qdev-core.h |

[Qemu-devel] [PATCH v2 11/36] test: usb: usb-uas hotplug test

2014-09-26 Thread Igor Mammedov
checks that it's possible to hotplug usb-uas HBA and then if it's possible to hot(un)plug scsi-disk to it. Thest basically covers hot(un)plug on dummy HBAs without means of hot(un)plug notification of the guest. Signed-off-by: Igor Mammedov imamm...@redhat.com --- tests/usb-hcd-xhci-test.c | 61

[Qemu-devel] [PATCH v2 26/36] scsi: set SCSI BUS itself as default HotplugHandler

2014-09-26 Thread Igor Mammedov
That would allow to handle SCSI device unplug on HBAs without dedicated hot(un)plug handlers and avoid making such HBAs explicitly hotpluggable. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/scsi/scsi-bus.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 21/36] virtio-serial: convert to hotplug-handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/char/virtio-serial-bus.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/hw/char/virtio-serial-bus.c b/hw/char/virtio-serial-bus.c index

[Qemu-devel] [PATCH v2 35/36] qdev: drop legacy hotplug fields/methods

2014-09-26 Thread Igor Mammedov
It removes not needed anymore BusState.allow_hotplug field and DeviceClass.unplug callback. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/core/qdev.c | 16 +++- include/hw/qdev-core.h | 5 + 2 files changed, 4

[Qemu-devel] [PATCH v2 32/36] usb-storage: drop not needed allow_hotplug = 0

2014-09-26 Thread Igor Mammedov
Drop useless hack that disables hotplug on bus, after backend storage was added to it, by setting allow_hotplug = 0. Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realize will fail early with error no free target in scsi_qdev_realize() method.

Re: [Qemu-devel] [PATCH v1 2/3] qom: export object_property_is_child()

2014-09-26 Thread Andreas Färber
Am 18.09.2014 um 09:53 schrieb Zhu Guihua: Export object_property_is_child() to let it be invoked in other places. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- include/qom/object.h | 1 + qom/object.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git

[Qemu-devel] [PATCH v2 31/36] usb-bot: drop not needed allow_hotplug = 0

2014-09-26 Thread Igor Mammedov
Drop useless hack that disables hotplug on bus by setting allow_hotplug = 0. Even if bus is hotpluggable, It won't be possible to add another SCSI device to bus since its realize will fail early with error no free target in scsi_qdev_realize() method. Signed-off-by: Igor Mammedov

[Qemu-devel] [PATCH v2 30/36] usb-bot: mark device as non hotpluggable

2014-09-26 Thread Igor Mammedov
usb-bot creates SCSI bus and immediately makes it non hotpluggable which was making not possible to hotplug usb-bot since QEMU would abort at bus_add_child(scsi-hd) time when usb-bot is realized. Mark usb-bot as not hotpluggable so that attempt to hotplug it would error out even before it gets to

[Qemu-devel] [PATCH v2 34/36] usb: convert usb devices to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: replace making each host as HotplugHandler with making USB BUS a HotplugHandler. That greatly reduces LOC needed for convertion. --- hw/usb/bus.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git

[Qemu-devel] [PATCH v2 33/36] usb: convert usb-ccid to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/usb/dev-smartcard-reader.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index d37ed02..78ce681 100644 --- a/hw/usb/dev-smartcard-reader.c +++

[Qemu-devel] [PATCH v2 36/36] qdev: HotplugHandler: add support for unplugging BUS-less devices

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: merged in Paolo's suggestion to reduce indentation in patch --- hw/core/qdev.c | 61 -- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/hw/core/qdev.c

[Qemu-devel] [PATCH v2 19/36] target-i386: ICC bus: drop BusState.allow_hotplug

2014-09-26 Thread Igor Mammedov
since bus_add_child() no longer cares if BUS is hotpluggable or not, there is no need in setting allow_hotplug field. Signed-off-by: Igor Mammedov imamm...@redhat.com --- hw/cpu/icc_bus.c | 8 1 file changed, 8 deletions(-) diff --git a/hw/cpu/icc_bus.c b/hw/cpu/icc_bus.c index

[Qemu-devel] [PATCH v2 28/36] scsi: convert virtio-scsi HBA to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- v2: * enforce virtio-scsi specific hotplug-handler --- hw/scsi/virtio-scsi.c | 30 -- 1 file changed, 20 insertions(+), 10 deletions(-) diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c index

[Qemu-devel] [PATCH v2 27/36] scsi: convert pvscsi HBA to hotplug handler API

2014-09-26 Thread Igor Mammedov
Signed-off-by: Igor Mammedov imamm...@redhat.com --- not tested since it's broken, i.e. QEMU hangs in BIOS with pvscsi device present on CLI v2: * enforce pvscsi specific hotplug-handler --- hw/scsi/vmw_pvscsi.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH v2 29/36] scsi: cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields

2014-09-26 Thread Igor Mammedov
SCSI subsytem was converted to hotplug handler API and doesn't use SCSIBusInfo{hotplug, hot_unplug} fields and related callbacks anymore. Signed-off-by: Igor Mammedov imamm...@redhat.com Reviewed-by: Paolo Bonzini pbonz...@redhat.com --- hw/scsi/scsi-bus.c | 16

Re: [Qemu-devel] [PACTH v4 3/6] target-arm: add hvc and smc exception emulation handling infrastructure

2014-09-26 Thread Peter Maydell
On 10 September 2014 08:02, Ard Biesheuvel ard.biesheu...@linaro.org wrote: From: Rob Herring rob.herr...@linaro.org Add the infrastructure to handle and emulate hvc and smc exceptions. This will enable emulation of things such as PSCI calls. This commit does not change the behavior and will

Re: [Qemu-devel] [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation

2014-09-26 Thread Owen Smith
-Original Message- From: David Vrabel Sent: 22 September 2014 11:16 To: Owen Smith; xen-de...@lists.xen.org Cc: Stefano Stabellini; qemu-devel@nongnu.org; Ian Campbell Subject: Re: [Xen-devel] [PATCH 2/2] xenfb: Add comment documentation On 22/09/14 10:04, Owen smith wrote: Add

[Qemu-devel] [PATCH v2] ui/input: fix event emitting of repeated combined keys

2014-09-26 Thread Amos Kong
Currently we emit press events of combined keys first, then emit release events by reverse order. But it doesn't match with physical keyboard if the keys contain continued repeated keys. For example, (qemu) sendkey a-b-b Current emited events: (actually the second 'presse b' and 'release b'

Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors

2014-09-26 Thread Andreas Färber
Christian, Conny, Am 23.09.2014 um 14:14 schrieb Christian Borntraeger: From: Cornelia Huck cornelia.h...@de.ibm.com We must not allow chains of more than 255 ccws without data transfer. Reviewed-by: David Hildenbrand d...@linux.vnet.ibm.com Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH] main-loop.c: Handle SIGINT, SIGHUP and SIGTERM synchronously

2014-09-26 Thread Alex Bennée
Peter Maydell peter.mayd...@linaro.org writes: Add the termination signals SIGINT, SIGHUP and SIGTERM to the list of signals which we handle synchronously via a signalfd. This avoids a race condition where if we took the SIGTERM in the middle of qemu_shutdown_requested: int r =

Re: [Qemu-devel] [PATCH v2] ui/input: fix event emitting of repeated combined keys

2014-09-26 Thread Gerd Hoffmann
On Fr, 2014-09-26 at 18:23 +0800, Amos Kong wrote: Currently we emit press events of combined keys first, then emit release events by reverse order. But it doesn't match with physical keyboard if the keys contain continued repeated keys. For example, (qemu) sendkey a-b-b Hmm, somehow I

[Qemu-devel] [Bug 1307225] Re: Running a virtual machine on a Haswell system produces machine check events

2014-09-26 Thread Tobias-leupold
So, at least, this does not seem to be something to worry about. But anyways, why does it only happen if a virtual machine is executed? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1307225 Title:

Re: [Qemu-devel] [PULL 2/3] s390x/css: support format-0 ccws

2014-09-26 Thread Andreas Färber
Am 23.09.2014 um 14:14 schrieb Christian Borntraeger: From: Cornelia Huck cornelia.h...@de.ibm.com Add support for format-0 ccws in channel programs. As a format-1 ccw contains the same information as format-0 ccws, only supporting larger addresses, simply convert every ccw to format-1 as we

Re: [Qemu-devel] [PATCH 00/23] qom hooks to clean up cpu_exec

2014-09-26 Thread Peter Maydell
On 13 September 2014 17:45, Richard Henderson r...@twiddle.net wrote: Prompted by trying to review Martin's ARM exception vs gdb problems, let's clean up cpu_exec so that it's almost readable. After the 23 patches, there's one (interesting) ifdef left. That is, i386 redefining

Re: [Qemu-devel] [PATCH v2 00/36] complete conversion to hotplug-handler API

2014-09-26 Thread Cornelia Huck
On Fri, 26 Sep 2014 09:28:05 + Igor Mammedov imamm...@redhat.com wrote: Changes since v1: * added usb-uas test * drop hotplug check in bus_add_child() * make SCSI USB bus as default HotplugHandler * fixed dummy HBA hot(un)plug * fixed hotunplug on s390x * prevent hotplug

Re: [Qemu-devel] [PULL 3/3] s390x/css: catch ccw sequence errors

2014-09-26 Thread Christian Borntraeger
On 09/26/2014 12:36 PM, Andreas Färber wrote: @@ -1414,6 +1423,7 @@ int subch_device_load(SubchDev *s, QEMUFile *f) s-id.ciw[i].count = qemu_get_be16(f); } s-ccw_fmt_1 = qemu_get_byte(f); +s-ccw_no_data_cnt = qemu_get_byte(f); return 0; } You need to bump

Re: [Qemu-devel] [PATCH v2] ui/input: fix event emitting of repeated combined keys

2014-09-26 Thread Amos Kong
On Fri, Sep 26, 2014 at 12:36:50PM +0200, Gerd Hoffmann wrote: On Fr, 2014-09-26 at 18:23 +0800, Amos Kong wrote: Currently we emit press events of combined keys first, then emit release events by reverse order. But it doesn't match with physical keyboard if the keys contain continued

Re: [Qemu-devel] [PATCH v2 23/36] s390x: drop not used allow_hotplug in event-facility

2014-09-26 Thread Cornelia Huck
On Fri, 26 Sep 2014 09:28:28 + Igor Mammedov imamm...@redhat.com wrote: s390-sclp-event-facility creates s390-sclp-events-bus and immeadiatly sets its allow_hotplug field to 0, which is NOP since it's already 0 by default. Also since BUS is not hotpluggable, it's not possible to call

Re: [Qemu-devel] [PATCH] input: fix send-key monitor command release event ordering

2014-09-26 Thread Amos Kong
On Fri, Sep 26, 2014 at 10:08:50AM +0200, Gerd Hoffmann wrote: commit 2e377f1730d06deafb3e3ef6cf88792de4a6f4df changed the ordering of the release events as side effect. Some guests are not happy with that and don't recognise ctrl-alt-del any more. This patch restores the old last-pressed

Re: [Qemu-devel] [PATCH] ohci: drop computed flags from trace events

2014-09-26 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:38:44AM +0100, Alex Bennée wrote: This exceeded the trace argument limit for LTTNG UST and wasn't really needed as the flags value is stored anyway. Dropping this fixes the compile failure for UST. It can probably be merged with the previous trace shortening patch.

Re: [Qemu-devel] [PATCH] ohci: Split long traces to smaller ones

2014-09-26 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:16:59AM +1000, Alexey Kardashevskiy wrote: Recent traces rework introduced 2 tracepoints with 13 and 20 arguments. When dtrace backend is selected (--enable-trace-backend=dtrace), compile fails as sys/sdt.h defines DTRACE_PROBE up to DTRACE_PROBE12 only. This

Re: [Qemu-devel] [PATCH] ohci: Fix compile errors without --enable-trace-backend

2014-09-26 Thread Stefan Hajnoczi
On Thu, Sep 25, 2014 at 10:19:32AM +1000, Alexey Kardashevskiy wrote: On 09/24/2014 07:47 PM, Stefan Hajnoczi wrote: On Tue, Sep 23, 2014 at 08:19:41PM +1000, Alexey Kardashevskiy wrote: This adds a stub for ohci_td_pkt() function (which traces packets) when configured without

[Qemu-devel] [PULL 01/16] trace: [ust] Fix format string computation in tcg-enabled events

2014-09-26 Thread Stefan Hajnoczi
From: Lluís Vilanova vilan...@ac.upc.edu TCG-enabled events start with two format strings. Delay per-argument format computation until requested ('Event.formats'). Signed-off-by: Lluís Vilanova vilan...@ac.upc.edu Signed-off-by: Stefan Hajnoczi stefa...@redhat.com ---

[Qemu-devel] [PULL 00/16] Tracing patches

2014-09-26 Thread Stefan Hajnoczi
The following changes since commit 1ba50f4ea01b26abe9dac95ba531533e17109826: Merge remote-tracking branch 'remotes/mcayland/tags/qemu-openbios-signed' into staging (2014-09-25 16:58:04 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git

[Qemu-devel] [PULL 09/16] cleanup-trace-events.pl: Tighten search for trace event call

2014-09-26 Thread Stefan Hajnoczi
From: Markus Armbruster arm...@redhat.com The script can get fooled too easily. For instance, it finds trace_megasas_io_read_start when looking for trace_megasas_io_read, and incorrectly concludes that event megasas_io_read is used. Supply -w to git-grep to tighten the search. Signed-off-by:

  1   2   3   4   >