Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

2015-03-10 Thread Michael Tokarev
Applied all 7 to -trivial. Is it intentional that there's no cover letter for the series? Thanks, /mjt

Re: [Qemu-devel] [PATCH v2] error: Replace error_report() error_free() with error_report_err()

2015-03-10 Thread zhanghailiang
Hi Michael, This patch has been reviewed, Please consider for merging. Thanks, zhanghailiang On 2015/3/5 0:50, Markus Armbruster wrote: zhanghailiang zhang.zhanghaili...@huawei.com writes: This is a continuation of the work started in commit 565f65d27: error: Use error_report_err() where

Re: [Qemu-devel] [PATCH] block/qapi: Fix Sparse warning

2015-03-10 Thread Michael Tokarev
08.03.2015 01:16, Stefan Weil wrote: Sparse reports this warning: block/qapi.c:417:47: warning: too long initializer-string for array of char(no space for nul char) Replacing the string by an array of characters fixes this warning. -static const char suffixes[NB_SUFFIXES] = KMGT; +

Re: [Qemu-devel] [PATCH 5/8] ioport: Remove unused functions

2015-03-10 Thread Thomas Huth
On Mon, 09 Mar 2015 20:23:24 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 09/03/2015 18:30, Thomas Huth wrote: The functions portio_list_destroy() and portio_list_del() are not used anywhere, so let's remove them. Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com Cc: Paolo

Re: [Qemu-devel] [PATCH 0/2] monitor: Fix and clean up around .user_print

2015-03-10 Thread Michael Tokarev
06.03.2015 12:09, Markus Armbruster wrote: A more thorough cleanup of the area is in the works, but I want to get this out quickly, so it makes 2.3. I think it can go via -trivial, if Luiz doesn't mind. Applied to -trivial for now, thank you! /mjt

Re: [Qemu-devel] [PATCH v5 12/45] Return path: Source handling of return path

2015-03-10 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:35PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert dgilb...@redhat.com --- include/migration/migration.h |

Re: [Qemu-devel] [PATCH v5 13/45] ram_debug_dump_bitmap: Dump a migration bitmap as text

2015-03-10 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:36PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Misses out lines that are all the expected value so the output can be quite compact depending on the circumstance. Signed-off-by: Dr. David Alan Gilbert

Re: [Qemu-devel] [PATCH v2] arm: fix memory leak

2015-03-10 Thread Michael Tokarev
This one appears to work better. Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH] 9pfs-local: simplify/optimize local_mapped_attr_path()

2015-03-10 Thread Michael Tokarev
05.03.2015 04:13, Fam Zheng wrote: On Thu, 03/05 00:03, Michael Tokarev wrote: +const char *name = basename((char*)path); checkpatch.pl complained this, s/char*/char */ I've fixed it in git. Thank you for spotting this. /mjt

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-10 Thread Alexey Kardashevskiy
On 03/10/2015 06:21 AM, Marcel Apfelbaum wrote: On 03/09/2015 06:55 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit 09d219a. Try please on top of this commit. Ok, that

Re: [Qemu-devel] [PATCH v2] error: Replace error_report() error_free() with error_report_err()

2015-03-10 Thread Michael Tokarev
04.03.2015 13:25, zhanghailiang wrote: This is a continuation of the work started in commit 565f65d27: error: Use error_report_err() where appropriate Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH 1/7] backends: Fix warning from Sparse

2015-03-10 Thread Stefan Weil
Am 10.03.2015 um 07:04 schrieb Michael Tokarev: Applied all 7 to -trivial. Is it intentional that there's no cover letter for the series? Thanks, /mjt No, that was my mistake. Please excuse also the cris patch which I sent twice. I did not notice that it already had caused trouble, nor did

Re: [Qemu-devel] [PATCH] target-moxie: Fix warnings from Sparse (one-bit signed bitfield)

2015-03-10 Thread Michael Tokarev
Applied to -trivial, thank you! /mjt

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-10 Thread Shlomo Pongratz
On 10 آذار, 2015 ص 03:18, Shannon Zhao wrote: On 2015/3/9 22:41, shlomo.pongr...@toganetworks.com wrote: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the largest

Re: [Qemu-devel] Crash when using -daemonize

2015-03-10 Thread Paolo Bonzini
On 09/03/2015 22:34, Christian Borntraeger wrote: I think it is. Paolo has posted a quick fix in the thread of vl: take iothread lock very early. Can you verify? Paolo, what is the status of this fix? Sending a pull request today with the proper fix. Paolo

Re: [Qemu-devel] [PATCH] tpm: Move memory initialization into realize function

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 00:51, Stefan Berger wrote: From: Stefan Berger stef...@us.ibm.com Move the memory initialization into the DeviceClass realize function due to isa_address_space crashing if called in the instance init function. A recent change must have changed the order in which structures

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-10 Thread Shlomo Pongratz
On 10 آذار, 2015 ص 09:06, Pei XiaoYong wrote: 于 2015/3/9 22:41, shlomo.pongr...@toganetworks.com 写道: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the largest integer

Re: [Qemu-devel] [PATCH 0/4] ucb: Convert remaining PCI HCDs to realize

2015-03-10 Thread Gerd Hoffmann
On Di, 2015-02-17 at 14:28 +0100, Markus Armbruster wrote: This series requires my [PATCH 00/10] pci: Partial conversion to realize and my [PATCH 0/9] Clean up around error_get_pretty(), qerror_report_err(). Markus Armbruster (4): usb: Propagate errors through usb_register_companion()

Re: [Qemu-devel] [PULL 0/7] X86 patches

2015-03-10 Thread Peter Maydell
On 9 March 2015 at 20:40, Eduardo Habkost ehabk...@redhat.com wrote: The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2015-03-09 14:04:14 +) are available in the git

Re: [Qemu-devel] [Qemu-ppc] [PATCH v4 for-2.3 00/25] hw/pc: implement multiple primary busses for pc machines

2015-03-10 Thread Marcel Apfelbaum
On 03/10/2015 08:23 AM, Alexey Kardashevskiy wrote: On 03/10/2015 06:21 AM, Marcel Apfelbaum wrote: On 03/09/2015 06:55 PM, Gerd Hoffmann wrote: On Mo, 2015-03-09 at 18:26 +0200, Marcel Apfelbaum wrote: On 03/09/2015 04:19 PM, Gerd Hoffmann wrote: Hi, My series is based on commit

[Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-10 Thread Tiejun Chen
Although we already have 'gfx_passthru' in b_info, this doesn' suffice after we want to handle IGD specifically. Now we define a new field of type, gfx_passthru_kind, to indicate we're trying to pass IGD. Actually this means we can benefit this to support other specific devices just by extending

[Qemu-devel] [v2][PATCH 0/2] libxl: try to support IGD passthrough for qemu upstream

2015-03-10 Thread Tiejun Chen
v2: * Refine patch #2's head description * Improve codes quality inside patch #1 based on Wei's comments * Refill the summary inside patch #0 based on Konrad and Wei's suggestion When we're working to support IGD GFX passthrough with qemu upstream, instead of -gfx_passthru we'd like to make

[Qemu-devel] [v2][PATCH 1/2] libxl: introduce libxl__is_igd_vga_passthru

2015-03-10 Thread Tiejun Chen
While working with qemu, IGD is a specific device in the case of pass through so we need to identify that to handle more later. Here we define a table to record all IGD types currently we can support. Also we need to introduce two helper functions to get vendor and device ids to lookup that table.

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-10 Thread Claudio Fontana
On 10.03.2015 10:50, Shannon Zhao wrote: On 2015/3/10 17:34, Shlomo Pongratz wrote: On 10 آذار, 2015 ص 03:18, Shannon Zhao wrote: On 2015/3/9 22:41, shlomo.pongr...@toganetworks.com wrote: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Kevin Wolf
Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: On Tue, 03/10 09:50, Kevin Wolf wrote: Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: block/dmg can use additional library (libbz2) to read bzip2-compressed files. Make the block driver to be a module if libbz2 support is

Re: [Qemu-devel] [PATCH] target-arm: Add missing compatible property to A57

2015-03-10 Thread Peter Maydell
On 16 February 2015 at 14:43, Ryota Ozaki ozaki.ry...@gmail.com wrote: Signed-off-by: Ryota Ozaki ozaki.ry...@gmail.com Reviewed-by: Alistair Francis alistair.fran...@xilinx.com --- target-arm/cpu64.c | 1 + 1 file changed, 1 insertion(+) Applied to target-arm.next, thanks. -- PMM

[Qemu-devel] [PATCH 1/2] configure: handle clang -nopie argument warning

2015-03-10 Thread Stefan Hajnoczi
gcc 4.9.2 treats -nopie as an error: cc: error: unrecognized command line option ‘-nopie’ clang 3.5.0 treats -nopie as a warning: clang: warning: argument unused during compilation: '-nopie' The causes ./configure to fail with clang: ERROR: configure test passed without -Werror but

[Qemu-devel] [PATCH 0/2] configure: clang 3.5.0 build fixes

2015-03-10 Thread Stefan Hajnoczi
QEMU does not compile cleanly under clang 3.5.0. These patches eliminate the avalanche of warnings and make the build usable. Stefan Hajnoczi (2): configure: handle clang -nopie argument warning configure: silence glib unknown attribute __alloc_size__ configure | 12 +++- 1 file

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-10 Thread Shannon Zhao
On 2015/3/10 17:34, Shlomo Pongratz wrote: On 10 آذار, 2015 ص 03:18, Shannon Zhao wrote: On 2015/3/9 22:41, shlomo.pongr...@toganetworks.com wrote: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are

Re: [Qemu-devel] [PATCH v5 14/45] Move loadvm_handlers into MigrationIncomingState

2015-03-10 Thread David Gibson
On Tue, Mar 10, 2015 at 10:12:14AM +, Dr. David Alan Gilbert wrote: * David Gibson (da...@gibson.dropbear.id.au) wrote: On Wed, Feb 25, 2015 at 04:51:37PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com In postcopy we need the

[Qemu-devel] [PULL 2/3] vnc: -readconfig fix

2015-03-10 Thread Gerd Hoffmann
Now that -vnc goes through QemuOpts we can get vnc configuration via -readconfig too. So setting display_remote in the command line parsing code doesn't cut it any more, we must check QemuOpts instead to see whenever any vnc display is configured. Reported-by: Markus Armbruster arm...@redhat.com

[Qemu-devel] [PULL 0/3] vnc patch queue

2015-03-10 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-vnc-20150310-1 for you to fetch changes up to b57489cfe48f9fedc10205c0494f144085733f30: Fix crash when connecting to VNC through websocket (2015-03-10 11:33:42 +0100

Re: [Qemu-devel] [PATCH] Revert timer: replace time() with QEMU_CLOCK_HOST

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 12:49, Alexey Kardashevskiy wrote: Sure! Who/how? :) s/qemu_time/tcg_time/, but if Peter is not using it and Fabrice broke it, might as well remove it. Paolo

Re: [Qemu-devel] Fix for incorrect SYSRET instruction implementation -- anyone looked at this yet?

2015-03-10 Thread Paolo Bonzini
On 09/03/2015 23:48, Bill Paul wrote: I'm certain I'm sending this in plain text mode this time. According to my reading of the Intel documentation, the SYSRET instruction is supposed to force the RPL bits of the %ss register to 3 when returning to user mode. The actual sequence is:

[Qemu-devel] [PULL 03/11] kvm_stat: add kvm_stat.1 man page

2015-03-10 Thread Paolo Bonzini
From: Stefan Hajnoczi stefa...@redhat.com Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Ademar Reis ar...@redhat.com Reviewed-by: Wei Huang w...@redhat.com Message-Id: 1425338947-10296-3-git-send-email-stefa...@redhat.com Signed-off-by: Paolo Bonzini pbonz...@redhat.com ---

[Qemu-devel] [PULL 04/11] qemu-thread: do not use PTHREAD_MUTEX_ERRORCHECK

2015-03-10 Thread Paolo Bonzini
PTHREAD_MUTEX_ERRORCHECK is completely broken with respect to fork. The way to safely do fork is to bring all threads to a quiescent state by acquiring locks (either in callers---as we do for the iothread mutex---or using pthread_atfork's prepare callbacks) and then release them in the child. The

[Qemu-devel] [PULL 00/11] scsi, RCU, KVM, x86 changes for 2015-03-10

2015-03-10 Thread Paolo Bonzini
The following changes since commit 277263e1b320d759a760ba6c5ea75ec268f929e5: Merge remote-tracking branch 'remotes/agraf/tags/signed-ppc-for-upstream' into staging (2015-03-09 14:04:14 +) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream for

[Qemu-devel] [PULL 08/11] hw: Propagate errors through qdev_prop_set_drive()

2015-03-10 Thread Paolo Bonzini
From: Markus Armbruster arm...@redhat.com Three kinds of callers: 1. On failure, report the error and abort Passing error_abort does the job. No functional change. 2. On failure, report the error and exit() This is qdev_prop_set_drive_nofail(). Error reporting moves from

Re: [Qemu-devel] [PULL 00/73] Block patches

2015-03-10 Thread Fam Zheng
On Tue, 03/10 10:49, Peter Maydell wrote: Build failure, Win32: /home/petmay01/linaro/qemu-for-merges/hw/block/virtio-blk.c: In function 'virtio_blk_handle_scsi_req': /home/petmay01/linaro/qemu-for-merges/hw/block/virtio-blk.c:200: warning: unused variable 'acb' The variable definition

[Qemu-devel] [PULL 1/3] vnc: set id at parse time not init time

2015-03-10 Thread Gerd Hoffmann
This way the generated id will be stored in -writeconfig cfg files. Also we can make vnc_auto_assign_id() local to vnc.c. Tested-by: Markus Armbruster arm...@redhat.com Signed-off-by: Gerd Hoffmann kra...@redhat.com --- include/ui/console.h | 1 - qmp.c| 1 - ui/vnc.c

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-10 Thread Wei Liu
On Tue, Mar 10, 2015 at 11:16:40AM +0100, Paolo Bonzini wrote: On 09/03/2015 15:54, Wei Liu wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so

Re: [Qemu-devel] [PATCH 3/3] s390x: Replace unchecked qdev_init() by qdev_init_nofail()

2015-03-10 Thread Cornelia Huck
On Wed, 18 Feb 2015 16:31:28 +0100 Cornelia Huck cornelia.h...@de.ibm.com wrote: Markus Armbruster arm...@redhat.com writes: s390_flic_init() is a helper to create and realize either s390-flic-kvm or s390-flic-qemu. When qdev_init() fails, it complains to stderr and succeeds.

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 12:57, Wei Liu wrote: Because there are pending changes to OpenGL detection, I'll keep this patch queued in my tree and will probably submit it only for 2.4. I don't quite follow. Do you want me to carry your patch in my own tree, wait for you to submit your patch (and get

[Qemu-devel] [PATCH] hmp: Fix texinfo documentation

2015-03-10 Thread Markus Armbruster
Several issues: * Commands i and o lack @item. Their one-liner documentation gets squashed into the preceding command print. Add the obvious @item. * Commands i, o and cpu-add lack @findex. The function index doesn't have them. Add the obvious @findex. * Commit 727f005 put

[Qemu-devel] [PATCH] pc-dimm: Add description for device list.

2015-03-10 Thread Paulo Vital
The pc-dimm option presented on device list (by argument -device \?) is the unique option that don't have any information about it. This patch adds a description for the pc-dimm device to help users to identify it. Signed-off-by: Paulo Vital paulo.vi...@profitbricks.com --- hw/mem/pc-dimm.c | 1

Re: [Qemu-devel] [PATCH] Revert timer: replace time() with QEMU_CLOCK_HOST

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 03:43, Alexey Kardashevskiy wrote: This reverts commit 2ed1ebcf65edf6757d8904000889ce52cc0a9d1b as it breaks compile when configured with --enable-profiler: /home/alexey/p/qemu/vl.c:710:15: error: 'qemu_time' redeclared as different kind of symbol static time_t

Re: [Qemu-devel] [PATCH v5 09/45] Migration commands

2015-03-10 Thread David Gibson
On Tue, Mar 10, 2015 at 11:04:14AM +, Dr. David Alan Gilbert wrote: * David Gibson (da...@gibson.dropbear.id.au) wrote: On Wed, Feb 25, 2015 at 04:51:32PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Create QEMU_VM_COMMAND section

Re: [Qemu-devel] [PATCH] pc-dimm: Add description for device list.

2015-03-10 Thread Igor Mammedov
On Tue, 10 Mar 2015 11:42:57 +0100 Paulo Vital paulo.vi...@profitbricks.com wrote: The pc-dimm option presented on device list (by argument -device \?) is the unique option that don't have any information about it. This patch adds a description for the pc-dimm device to help users to identify

Re: [Qemu-devel] [PATCH v11 0/5] Netduino 2 Machine Model

2015-03-10 Thread Peter Maydell
On 17 February 2015 at 12:38, Alistair Francis alistai...@gmail.com wrote: This patch series adds the Netduino 2 Machine to QEMU Information on the board is avalible at: http://www.netduino.com/netduino2/specs.htm The git tree can be found at:

Re: [Qemu-devel] [PATCH RFC] Implement GIC-500 from GICv3 family for arm64

2015-03-10 Thread Shlomo Pongratz
On 09 آذار, 2015 م 05:13, Peter Maydell wrote: On 9 March 2015 at 23:41, shlomo.pongr...@toganetworks.com wrote: From: Shlomo Pongratz shlomo.pongr...@huawei.com This patch is a first step toward 128 cores support for arm64. At first only 64 cores are supported for two reasons: First the

Re: [Qemu-devel] [PULL 0/5] sdl patch queue.

2015-03-10 Thread Gerd Hoffmann
be --cflags. Fixed, updated pull here: git://git.kraxel.org/qemu tags/pull-sdl-20150310-1 cheers, Gerd

[Qemu-devel] [PULL 05/11] rcu: handle forks safely

2015-03-10 Thread Paolo Bonzini
After forking, only the calling thread is duplicated in the child process. The call_rcu thread has to be recreated in the child. Exploit the fact that only one thread exists (same as when constructors run), and just redo the entire initialization to ensure the threads are in the proper state.

[Qemu-devel] [PULL 02/11] kvm_stat: add column headers to text UI

2015-03-10 Thread Paolo Bonzini
From: Stefan Hajnoczi stefa...@redhat.com The curses user interface shows both the accumulated total and the current event counts. Add column headers so it's clear what the numbers mean. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com Reviewed-by: Ademar Reis ar...@redhat.com Reviewed-by:

[Qemu-devel] [PULL 01/11] iscsi: Fix check for username

2015-03-10 Thread Paolo Bonzini
From: Stefan Weil s...@weilnetz.de The variable user in struct iscsi_url is a character array, not a pointer. Therefore its address will never be NULL. clang reports this error: block/iscsi.c:1329:20: warning: comparison of array 'iscsi_url-user' not equal to a null pointer is always true

Re: [Qemu-devel] [PATCH v5 09/45] Migration commands

2015-03-10 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: On Wed, Feb 25, 2015 at 04:51:32PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com Create QEMU_VM_COMMAND section type for sending commands from source to destination. These commands are not

Re: [Qemu-devel] [PATCH 1/2] exec: Convert bounce buffer to a set

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 08:50, Fam Zheng wrote: +QLIST_ENTRY(BounceBuffer) next; Where is this used? -if (buffer != bounce.buffer) { +BounceBuffer *bounce; + +bounce = bounce_buffer_find_and_remove(buffer); +if (!bounce) { I'm afraid that this adds a mutex lock/unlock pair and

[Qemu-devel] [PATCH 0/3] vnc: some code cleanups.

2015-03-10 Thread Gerd Hoffmann
Hi, This series carries a few cleanups for the vnc code, mostly the display initialization. please review, Gerd Gerd Hoffmann (3): vnc: drop display+ws_display from VncDisplay vnc: remove dead code vnc: switch to inet_listen_opts ui/vnc-auth-sasl.c | 2 +- ui/vnc.c | 110

[Qemu-devel] [PATCH 2/3] vnc: remove dead code

2015-03-10 Thread Gerd Hoffmann
If vs-ws_enabled is set ws_display is non-NULL. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 65ba1c0..bac44ce 100644 --- a/ui/vnc.c +++ b/ui/vnc.c @@ -3627,13 +3627,8 @@ void

[Qemu-devel] [PATCH 1/3] vnc: drop display+ws_display from VncDisplay

2015-03-10 Thread Gerd Hoffmann
Nobody cares about those strings, they are only used to check whenever the vnc server / websocket support is enabled or not. Add bools for this and drop the strings. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc-auth-sasl.c | 2 +- ui/vnc.c | 54

[Qemu-devel] [PATCH 3/3] vnc: switch to inet_listen_opts

2015-03-10 Thread Gerd Hoffmann
Use inet_listen_opts instead of inet_listen. Allows us to drop some pointless indirection: Format strings just to parse them again later on. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- ui/vnc.c | 75 +++- 1 file changed, 41

[Qemu-devel] [PATCH V2] pc-dimm: Add description for device list.

2015-03-10 Thread Paulo Vital
The pc-dimm option presented on device list (by argument -device \?) is the unique option that don't have any information about it. This patch adds a description for the pc-dimm device to help users to identify it. Signed-off-by: Paulo Vital paulo.vi...@profitbricks.com Reviewed-by: Igor Mammedov

[Qemu-devel] [PATCH] tcg/monitor: remove info profile

2015-03-10 Thread Paolo Bonzini
info profile is not great in several ways: 1) half of it only works for TCG, but doesn't say this anywhere. 2) the division by get_ticks_per_sec() doesn't work since the unit of measurement is clock cycles rather than nanoseconds. (Broken since 2006 by Fabrice). 3) you really can get the same

Re: [Qemu-devel] [PATCH] hw/arm/virt: fix cmdline parsing bug with CPU options and smp 1

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 09:13, Ard Biesheuvel ard.biesheu...@linaro.org wrote: Ping? Applied this one to target-arm.next, thanks. (I've been on holiday and not doing patch review or target-arm subtree handling, but am back at work now...) -- PMM

[Qemu-devel] [PATCH 2/2] configure: silence glib unknown attribute __alloc_size__

2015-03-10 Thread Stefan Hajnoczi
The glib headers use GCC attributes. Unfortunately the __GNUC__ and __GNUC_MINOR__ version macros are also defined by clang, but clang doesn't support the same attributes as GCC. clang 3.5.0 does not support the __alloc_size__ attribute:

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-10 Thread Paolo Bonzini
On 09/03/2015 15:54, Wei Liu wrote: I discovered a problem when trying to build QEMU statically with gcc. libm is an element of LIBS while libpixman-1 is an element in libs_softmmu. Libpixman references functions in libm, so the original ordering makes linking fail. This fix is to reorder

Re: [Qemu-devel] qemu crash in coroutine bdrv_co_do_rw

2015-03-10 Thread Paolo Bonzini
On 10/03/2015 08:54, Christian Borntraeger wrote: Am 09.03.2015 um 21:37 schrieb Christian Borntraeger: Am 06.03.2015 um 18:23 schrieb Stefan Hajnoczi: On Thu, Feb 26, 2015 at 10:29:57AM +0100, Christian Borntraeger wrote: is this some know issue? Under heavy load with lots of dataplane

[Qemu-devel] [PULL 11/11] x86: fix SS selector in SYSRET

2015-03-10 Thread Paolo Bonzini
From: Bill Paul wp...@windriver.com According to my reading of the Intel documentation, the SYSRET instruction is supposed to force the RPL bits of the %ss register to 3 when returning to user mode. The actual sequence is: SS.Selector -- (IA32_STAR[63:48]+8) OR 3; (* RPL forced to 3 *) However,

[Qemu-devel] [PULL 07/11] scsi: Clean up duplicated error in legacy if=scsi code

2015-03-10 Thread Paolo Bonzini
From: Markus Armbruster arm...@redhat.com Commit a818a4b changed scsi_bus_legacy_handle_cmdline() to report errors from scsi_bus_legacy_add_drive() with error_report() in addition to returning them. That's inappropriate. Two kinds of callers: 1. realize methods (devices esp, virtio-scsi-device

[Qemu-devel] [PULL 06/11] cpus: initialize cpu-memory_dispatch

2015-03-10 Thread Paolo Bonzini
This fixes a NULL pointer dereference in s390x-softmmu. On pretty much all other architectures, creating an MMIO region calls cpu_reload_memory_map. On s390, however, there are no MMIO regions and everything is done via hypercalls. Fixes: 9d82b5a792236db31a75b9db5c93af69ac07c7c5 Reported-by:

[Qemu-devel] [PULL 10/11] scsi: Convert remaining PCI HBAs to realize()

2015-03-10 Thread Paolo Bonzini
From: Markus Armbruster arm...@redhat.com These are am53c974, dc390, lsi53c895a, lsi53c810, megasas, megasas-gen2. Signed-off-by: Markus Armbruster arm...@redhat.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Message-Id: 1425925048-15482-5-git-send-email-arm...@redhat.com

[Qemu-devel] [PULL 3/3] Fix crash when connecting to VNC through websocket

2015-03-10 Thread Gerd Hoffmann
From: Jorge Acereda Maciá jacer...@gmail.com Connecting to VNC through websocket crashes in vnc_flush() when trying to acquire a mutex that hasn't been initialized (vnc_init_state(vs) hasn't been called at this point). Signed-off-by: Jorge Acereda Macia jacer...@gmail.com Signed-off-by: Gerd

Re: [Qemu-devel] qemu crash in coroutine bdrv_co_do_rw

2015-03-10 Thread Christian Borntraeger
Am 10.03.2015 um 11:33 schrieb Paolo Bonzini: On 10/03/2015 08:54, Christian Borntraeger wrote: Am 09.03.2015 um 21:37 schrieb Christian Borntraeger: Am 06.03.2015 um 18:23 schrieb Stefan Hajnoczi: On Thu, Feb 26, 2015 at 10:29:57AM +0100, Christian Borntraeger wrote: is this some know

Re: [Qemu-devel] [PATCH RFC] Makefile.target: prepend $libs_softmmu to $LIBS

2015-03-10 Thread Wei Liu
On Tue, Mar 10, 2015 at 01:00:15PM +0100, Paolo Bonzini wrote: On 10/03/2015 12:57, Wei Liu wrote: Because there are pending changes to OpenGL detection, I'll keep this patch queued in my tree and will probably submit it only for 2.4. I don't quite follow. Do you want me to carry

Re: [Qemu-devel] [PULL 0/5] sdl patch queue.

2015-03-10 Thread Peter Maydell
On 10 March 2015 at 09:19, Gerd Hoffmann kra...@redhat.com wrote: Hi, hw/display/milkymist-tmu2.o -MF hw/display/milkymist-tmu2.d -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -g -lGL -c -o

Re: [Qemu-devel] [PATCH v5 14/45] Move loadvm_handlers into MigrationIncomingState

2015-03-10 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: On Wed, Feb 25, 2015 at 04:51:37PM +, Dr. David Alan Gilbert (git) wrote: From: Dr. David Alan Gilbert dgilb...@redhat.com In postcopy we need the loadvm_handlers to be used in a couple of different instances of the loadvm

Re: [Qemu-devel] clang warnings too noisy

2015-03-10 Thread Stefan Hajnoczi
On Fri, Mar 6, 2015 at 11:47 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 7 March 2015 at 04:06, Stefan Hajnoczi stefa...@gmail.com wrote: Is anyone working on making QEMU build cleanly under clang? Under gcc people regularly submit patches to keep the build clean (e.g. recent gcc 5

[Qemu-devel] [PATCH v2] tpm: Move memory subregion function into realize function

2015-03-10 Thread Stefan Berger
From: Stefan Berger stef...@us.ibm.com Move the memory subregion function into the DeviceClass realize function due to isa_address_space (now) crashing if called in the instance init function. Signed-off-by: Stefan Berger stef...@linux.vnet.ibm.com --- hw/tpm/tpm_tis.c | 6 +++--- 1 file

Re: [Qemu-devel] [PATCH] Revert timer: replace time() with QEMU_CLOCK_HOST

2015-03-10 Thread Alexey Kardashevskiy
On 03/10/2015 10:05 PM, Paolo Bonzini wrote: On 10/03/2015 03:43, Alexey Kardashevskiy wrote: This reverts commit 2ed1ebcf65edf6757d8904000889ce52cc0a9d1b as it breaks compile when configured with --enable-profiler: /home/alexey/p/qemu/vl.c:710:15: error: 'qemu_time' redeclared as different

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is that icc_bridge attachment will now be done after

[Qemu-devel] [PULL 09/11] scsi: Improve error reporting for invalid drive property

2015-03-10 Thread Paolo Bonzini
From: Markus Armbruster arm...@redhat.com When setting realized fails, scsi_bus_legacy_add_drive() passes the error to qerror_report_err(), then returns an unspecific Setting drive property failed error, which is reported further up the call chain. Example: $ qemu-system-x86_64 -nodefaults

Re: [Qemu-devel] [PULL 00/73] Block patches

2015-03-10 Thread Peter Maydell
On 9 March 2015 at 15:41, Kevin Wolf kw...@redhat.com wrote: Hi Peter, I hope this fixes the build problems in Stefan's pull request. I'm only posting those patches that are new compared to Stefan's version, or that have actual differences (the fixed build errors; not reposting for my added

Re: [Qemu-devel] [PATCH 0/3] fix pci related code typos

2015-03-10 Thread Michael S. Tsirkin
On Tue, Mar 10, 2015 at 09:49:47AM +0800, Chen Fan wrote: Chen Fan (3): pcie_aer: fix typos in pcie_aer_inject_error comment aer: fix a wrong init PCI_ERR_COR_STATUS w1cmask type register pci: fix several trivial typos in comment Reviewed-by: Michael S. Tsirkin m...@redhat.com

[Qemu-devel] [PATCH] virtio: avoid leading underscores for helpers

2015-03-10 Thread Cornelia Huck
Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 (virtio: add feature checking helpers) introduced a helper __virtio_has_feature. We don't want to use reserved identifiers, though, so let's rename __virtio_has_feature to virtio_has_feature and virtio_has_feature to virtio_vdev_has_feature.

Re: [Qemu-devel] balloon stats not working if qemu is started with -machine option

2015-03-10 Thread Alexandre DERUMIER
But you do have to set the polling interval to use the feature. Ok thanks Luiz. The problem was that we didn't set polling interval on migration only (on target qemu). Thanks again ! Alexandre - Mail original - De: Luiz Capitulino lcapitul...@redhat.com À: aderumier

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Eduardo Habkost
On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Eduardo Habkost
On Tue, Mar 10, 2015 at 02:30:34PM +0100, Andreas Färber wrote: Am 10.03.2015 um 14:24 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 01:51:26PM +0100, Andreas Färber wrote: Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote:

[Qemu-devel] [PULL v2 00/73] Block patches

2015-03-10 Thread Kevin Wolf
The following changes since commit 6608c7e9eb65727524f6f590b1e716ec6e7877d4: Merge remote-tracking branch 'remotes/xtensa/tags/20150307-xtensa' into staging (2015-03-08 14:32:38 +) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Markus Armbruster
Kevin Wolf kw...@redhat.com writes: Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: On Tue, 03/10 09:50, Kevin Wolf wrote: Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: block/dmg can use additional library (libbz2) to read bzip2-compressed files. Make the block driver to be

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 14:24 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 01:51:26PM +0100, Andreas Färber wrote: Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing

Re: [Qemu-devel] balloon stats not working if qemu is started with -machine option

2015-03-10 Thread Luiz Capitulino
On Mon, 9 Mar 2015 08:04:54 +0100 (CET) Alexandre DERUMIER aderum...@odiso.com wrote: I have forgot to said that we don't setup pooling interval manually. (which seem to works fine without -machine) Now,if I setup guest-stats-polling-interval with qom-set, it seem to works fine with

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-10 Thread Kevin Wolf
Am 10.03.2015 um 14:28 hat Stefan Hajnoczi geschrieben: On Mon, Mar 09, 2015 at 09:32:47PM +0800, Yi Wang wrote: This will trigger the problem: vda has snapshot s1 with id 1, vdb doesn't have s1 but has snapshot s2 with id 1。When we want to run command virsh create s1,

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Eduardo Habkost
On Tue, Mar 10, 2015 at 02:22:01PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is

Re: [Qemu-devel] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Michael Tokarev
10.03.2015 16:24, Markus Armbruster wrote: [] For me, avoiding bothersome dependencies is a strong practical argument for making a something a loadable module. Other benefits of loadable modules presented so far seem pretty negligible to me. If you want them, no objection from me, as long as

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to icc_bridge. The only difference here is that icc_bridge attachment will now be done after

Re: [Qemu-devel] [Qemu-block] [PATCH] block/dmg: make it modular if using additional library

2015-03-10 Thread Stefan Hajnoczi
On Tue, Mar 10, 2015 at 10:09 AM, Kevin Wolf kw...@redhat.com wrote: Am 10.03.2015 um 10:17 hat Fam Zheng geschrieben: On Tue, 03/10 09:50, Kevin Wolf wrote: Am 10.03.2015 um 08:06 hat Michael Tokarev geschrieben: Also, should we consider making some more rarely used image formats modules

Re: [Qemu-devel] [PATCH 15/27] block/parallels: keep BAT bitmap data in little endian in memory

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:09AM +0300, Denis V. Lunev wrote: This will allow to use this data as buffer to BAT update directly without any intermediate buffers. Signed-off-by: Denis V. Lunev d...@openvz.org CC: Roman Kagan rka...@parallels.com CC: Kevin Wolf kw...@redhat.com CC: Stefan

Re: [Qemu-devel] [PATCH 14/27] block/parallels: create bat2sect helper

2015-03-10 Thread Roman Kagan
On Tue, Mar 10, 2015 at 11:51:08AM +0300, Denis V. Lunev wrote: deduplicate copy/paste arithmetcs Signed-off-by: Denis V. Lunev d...@openvz.org CC: Roman Kagan rka...@parallels.com CC: Kevin Wolf kw...@redhat.com CC: Stefan Hajnoczi stefa...@redhat.com --- block/parallels.c | 12

Re: [Qemu-devel] [PATCH] savevm: create snapshot failed when id_str already exits

2015-03-10 Thread Stefan Hajnoczi
On Mon, Mar 09, 2015 at 09:32:47PM +0800, Yi Wang wrote: This will trigger the problem: vda has snapshot s1 with id 1, vdb doesn't have s1 but has snapshot s2 with id 1。When we want to run command virsh create s1, del_existing_snapshots() only deletes s1 in vda, and bdrv_snapshot_create()

Re: [Qemu-devel] [PATCH] target-arm: Add missing compatible property to A57

2015-03-10 Thread Ryota Ozaki
2015/03/10 21:08 Peter Maydell peter.mayd...@linaro.org: On 16 February 2015 at 14:43, Ryota Ozaki ozaki.ry...@gmail.com wrote: Signed-off-by: Ryota Ozaki ozaki.ry...@gmail.com Reviewed-by: Alistair Francis alistair.fran...@xilinx.com --- target-arm/cpu64.c | 1 + 1 file changed, 1

Re: [Qemu-devel] [PATCH 1/1] target-i386: Remove icc_bridge parameter from cpu_x86_create()

2015-03-10 Thread Andreas Färber
Am 10.03.2015 um 13:42 schrieb Eduardo Habkost: On Tue, Mar 10, 2015 at 12:50:07PM +0100, Andreas Färber wrote: Am 05.03.2015 um 18:26 schrieb Eduardo Habkost: Instead of passing icc_bridge from the PC initialization code to cpu_x86_create(), make the PC initialization code attach the CPU to

  1   2   3   4   5   >