On 03/12/2015 09:29 AM, Richard Henderson wrote:
On 02/25/2015 02:45 AM, Markus Armbruster wrote:
return 0x8000u (clz64(value - 1) - 1);
I realize this was weeks ago, but it would certainly be preferable to shift a
small constant left than a large constant right.
Most RISC
Reimplement it based on qmp_qom_get() to avoid converting QObjects back
to strings.
Inspired-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
hmp-commands.hx | 13 +
hmp.c | 22 ++
hmp.h | 1 +
3 files
On 10/03/2015 19:13, Daniel P. Berrange wrote:
FWIW, I could see an improved interaction scheme working as follows
First, introduce a new monitor command for setting named passwords,
add_key mykey1 SECRETDATA
Or reuse object_add:
object_add secret,id=mykey1,secret=SECRETDATA
On 12/03/2015 13:53, Jens Freimann wrote:
From: Dominik Dingel din...@linux.vnet.ibm.com
More and more virtual machine specifics between kvm and qemu will be
transferred with vm attributes.
So we encapsulate the common logic in a generic function.
Additionally we need only to check
This cleans up the official /machine namespace. In particular
/machine/system and /machine/io as well as entries with non-sanitized
node names.
Cc: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
On 03/12/2015 08:57 AM, Paolo Bonzini wrote:
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
command add_fd). Free it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
vl.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Reviewed-by: Eric Blake
NACK. Patchew caught a problem with how I was generating the QEMU_IMG
path. Not important for 2.3, anyway.
Will re-spin with a 2.4 subject.
--js
On 03/10/2015 01:29 PM, John Snow wrote:
This is a re-send of patches 7 8 from an earlier series,
[PATCH v2 0/8] ahci: add more IO tests which
On 02/26/2015 12:13 AM, Jordan Hargrave wrote:
Referencing this old thread:
https://lists.nongnu.org/archive/html/qemu-devel/2014-07/msg00606.html
I've run into an issue recently with testing q35 DMAR/intel iommu with
ahci driver. My ahci driver writes the upper-32 bits (PORT_FIS_ADDR_HI)
jacob jacob opstk...@gmail.com writes:
Hi,
Seeing failures when trying to do PCI passthrough of Intel XL710 40G
interface to KVM vm.
0a:00.1 Ethernet controller: Intel Corporation Ethernet
Controller XL710 for 40GbE QSFP+ (rev 01)
You are assigning the PF right ? Does assigning VFs
On 03/09/2015 12:45 AM, zhanghailiang wrote:
Rename all macros MIG_STATE_* to MIGRATION_STATUS_* except MIG_STATE_ERROR,
we rename it to MIGRATION_STATUS_FAILED which will match the migration
status
string 'failed'.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
Hi all
I have tried now for two days to get qemu 2.2.0 or 2.2.1 working with
vde and just seem to get absolutely nowhere. On my old server (Ubuntu
12.04.5 LTS (GNU/Linux 3.2.0-77-generic x86_64)) it is working
flawlessly, having a self compiled 2.2.0 version with the distros vde
packages:
Am 12.03.2015 um 15:08 schrieb Paolo Bonzini:
On 11/03/2015 20:59, Stefan Weil wrote:
Am 11.03.2015 um 18:10 schrieb Joseph Hindin:
When building qga-bss.dll with 64-bit mingw toolchain v. 4.9.2, the
Typo: qga-vss.dll
qga-vss.dll linking fails with unresolved symbols from libssp,
stack
On 12/03/2015 20:58, Stefan Hajnoczi wrote:
David, Jiri, Scott: The minimum required glib version is 2.12 so
glib APIs that were added later cannot be used. Also note the
Windows integer constant warning above.
My build environments didn't hit these issues so we need to go
around one
On 02/25/2015 02:45 AM, Markus Armbruster wrote:
return 0x8000u (clz64(value - 1) - 1);
I realize this was weeks ago, but it would certainly be preferable to shift a
small constant left than a large constant right.
Most RISC machines can't form 0x8000ull without loading
Paolo Bonzini pbonz...@redhat.com writes:
On 12/03/2015 16:10, Peter Maydell wrote:
So is the non-deprecated approach to have the board call
object_property_set_bool(OBJECT(dev), true, realized, err);
directly itself (handling errors however it feels like) rather
than calling
On Thu, Mar 12, 2015 at 04:42:25PM +0100, Laszlo Ersek wrote:
On 03/12/15 15:17, Paolo Bonzini wrote:
Let's nuke it. :)
Okay... Gabriel, do you want to include such a patch in your upcoming
series, or should I do the nuking sooner?
I was working on it (good for practice :) and so far I
On 11/03/2015 15:22, James Hogan wrote:
The KVM_REG_MIPS_COUNT_* definitions are now included in
linux-headers/asm-mips/kvm.h since commit b061808d39fa (linux-headers:
update linux headers to kvm/next), therefore the duplicate definitions
in target-mips/kvm.c can now be dropped.
On 12 March 2015 at 15:51, Peter Maydell peter.mayd...@linaro.org wrote:
On 4 March 2015 at 14:35, Alex Bennée alex.ben...@linaro.org wrote:
While observing KVM traces I can see additional IRQ calls on pretty much
every MMIO access which is just plain inefficient. Only update the QEMU
IRQ
On 03/09/2015 12:45 AM, zhanghailiang wrote:
The original 'status' is an open-coded 'str' type, convert it to use an
enum type.
This conversion is backwards compatible, better documented and
more convenient for future extensibility.
In addition, Fix a typo for qapi-schema.json (just remove
On Thu, Mar 12, 2015 at 03:03:45PM +, Peter Maydell wrote:
On 12 March 2015 at 14:43, Peter Maydell peter.mayd...@linaro.org wrote:
On 12 March 2015 at 14:33, Stefan Hajnoczi stefa...@redhat.com wrote:
v4:
* Drop clang 3.5.0 fixes since they break with older clang and w32 [Peter]
From: Paolo Bonzini pbonz...@redhat.com
Using net_host_check_device is unnecessary. qemu_del_net_client asserts
for the non-peer case that it can only process NIC type NetClientStates,
and that assertion is valid for the peered case as well, so move it and
use the same check in
format string specifiers [Peter]
* Squash in Windows build fix [Peter]
* Both build fixes are described in rocker: add new rocker switch device
The following changes since commit 2a5b58e2405e9fe42ba356b5a1b78146a4e9a659:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150312-1
From: Frediano Ziglio fredd...@gmail.com
Test behaviour of timers and interrupts related to timeouts.
Signed-off-by: Frediano Ziglio fredd...@gmail.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Message-id: 1420742303-3030-1-git-send-email-fredd...@gmail.com
Signed-off-by: Stefan Hajnoczi
On 12 March 2015 at 17:50, Stefan Hajnoczi stefa...@gmail.com wrote:
This pull request contains patches that fail mingw compilation and
glib version requirements. They passed in patchew:
http://qemu.patchew.org/testing/log/%3c1426170808-6343-1-git-send-email-stefa...@redhat.com%3E
Peter's
On 03/12/2015 10:26 AM, Markus Armbruster wrote:
Fixes for encrypted images is of course a fool's errand. My actual
motivation is killing a few more qerror_report() calls.
Markus Armbruster (5):
monitor: Drop dead QMP check from monitor_read_password()
monitor: Plug memory leak in
From: Wen Congyang we...@cn.fujitsu.com
QCOW_MAX_L1_SIZE's unit is byte, and l1_size's unit
is l1 table entry size(8 bytes).
Signed-off-by: Wen Congyang we...@cn.fujitsu.com
Message-id: 54ffb0f1.5010...@cn.fujitsu.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
block/qcow2-snapshot.c
Am 12.03.2015 um 19:05 schrieb Paolo Bonzini:
On 12/03/2015 17:43, Andreas Färber wrote:
This cleans up the official /machine namespace. In particular
/machine/system and /machine/io as well as entries with non-sanitized
node names.
Just a question: isn't it /machine/system[0] and
On 12/03/2015 17:43, Andreas Färber wrote:
This cleans up the official /machine namespace. In particular
/machine/system and /machine/io as well as entries with non-sanitized
node names.
Just a question: isn't it /machine/system[0] and /machine/io[0]?
Cc: Paolo Bonzini
The following changes since commit 2a5b58e2405e9fe42ba356b5a1b78146a4e9a659:
Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150312-1' into
staging (2015-03-12 10:35:54 +)
are available in the git repository at:
git://github.com/stefanha/qemu.git tags/block-pull-request
From: Paolo Bonzini pbonz...@redhat.com
There is a not-so-subtle race in QSLIST_INSERT_HEAD_ATOMIC.
Because atomic_cmpxchg returns the old value instead of a success flag,
QSLIST_INSERT_HEAD_ATOMIC was checking for success by comparing against
the second argument to atomic_cmpxchg.
Michael Tokarev m...@tls.msk.ru writes:
Omit one unnecessary memory allocation for components
of the path and create the resulting path directly given
lengths of the components.
Do not use basename(3) because there are 2 versions of
this function which differs when argument ends with
slash
On 03/11/2015 07:06 PM, zhanghailiang wrote:
ping...
Should this series be merged in 2.3 version? I noticed that 3.17 is
hardfreeze time.
Yes, I'd be in favor of including it in 2.3; it's up to the maintainer
to make final decision, though.
--
Eric Blake eblake redhat com
From: Dominik Dingel din...@linux.vnet.ibm.com
By using the new introduced generic interface we
can remove redundancies and clean up.
Reviewed-by: Thomas Huth th...@linux.vnet.ibm.com
Suggested-by: Thomas Huth th...@linux.vnet.ibm.com
Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com
From: Dominik Dingel din...@linux.vnet.ibm.com
More and more virtual machine specifics between kvm and qemu will be
transferred with vm attributes.
So we encapsulate the common logic in a generic function.
Additionally we need only to check during initialization if kvm supports
virtual machine
Conny, Alex, Christian,
a few more s390 patches:
Patch 1: encapsulates the HAS_DEVICE check into a generic function
Patch 2: use the function introduced in Patch 1
Patch 3: introduces two new machine options for indicating the state of
AES/DEA key wrapping functions
Patch 4 and 5:
From: Dominik Dingel din...@linux.vnet.ibm.com
load_image_targphys already checks the max size and will return
an error code. So the follow-on check will never trigger.
Signed-off-by: Dominik Dingel din...@linux.vnet.ibm.com
Reviewed-by: Cornelia Huck cornelia.h...@de.ibm.com
Reviewed-by: Thomas
From: Tony Krowiak akrow...@linux.vnet.ibm.com
Check for the aes_key_wrap and dea_key_wrap machine options and set the
appropriate KVM device attribute(s) to tell the kernel to enable or disable
the AES/DEA protected key functions for the guest domain.
This patch introduces two new machine
From: Frank Blaschka blasc...@linux.vnet.ibm.com
The sei_nt2 event must contain the length of the event.
Signed-off-by: Frank Blaschka blasc...@linux.vnet.ibm.com
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
---
hw/s390x/s390-pci-bus.c | 1 +
1 file changed, 1 insertion(+)
diff --git
From: Thomas Huth th...@linux.vnet.ibm.com
The function s390_virtio_bus_console() is completely unused and thus
can be removed safely.
Signed-off-by: Thomas Huth th...@linux.vnet.ibm.com
Reviewed-by: Jens Freimann jf...@linux.vnet.ibm.com
Signed-off-by: Jens Freimann jf...@linux.vnet.ibm.com
---
jacob jacob opstk...@gmail.com writes:
On Thu, Mar 12, 2015 at 3:07 PM, Bandan Das b...@redhat.com wrote:
jacob jacob opstk...@gmail.com writes:
Hi,
Seeing failures when trying to do PCI passthrough of Intel XL710 40G
interface to KVM vm.
0a:00.1 Ethernet controller: Intel
On Wed, Feb 25, 2015 at 04:51:43PM +, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
Modify save_live_pending to return separate postcopiable and
non-postcopiable counts.
Add 'can_postcopy' to allow a device to state if it can postcopy
What's the
On Wed, Feb 25, 2015 at 04:51:41PM +, Dr. David Alan Gilbert (git) wrote:
From: Dr. David Alan Gilbert dgilb...@redhat.com
MIG_CMD_PACKAGED is a migration command that allows a chunk
of migration stream to be sent in one go, and be received by
a separate instance of the loadvm loop while
Thank you Chris!
Your suggestion is really working!!! Awesome!!!
I find in this way if I input ^C in stdio I'm gonna kill the qemu
process. But I think it's fine to me ;-).
Did you managed to make serial communication between host (which holds QEMU
client) and guest (QEMU client)?
I tried to use
On 12 March 2015 at 10:16, Michael S. Tsirkin m...@redhat.com wrote:
So thinking about this more, by the time kdump tries to reset device,
linux has probably already disabled the IRQ at the APIC level.
Isn't that the case? If so, the patch won't help, will it?
Trying to deassert (or worse,
On 12/03/15 08:41, Mark Cave-Ayland wrote:
Hi all,
Whilst testing git master in preparation for some OpenBIOS updates, I'm
seeing the following TCG assert in one of my older test images:
$ gdb --args ./qemu-system-ppc -cdrom
/home/build/src/qemu/image/ppc/ubuntu-5.10-live-powerpc.iso
For vfio pcie device, we could expose the extended capability on
PCIE bus. in order to avoid config space broken, we introduce
a copy config for parsing extended caps. and rebuild the pcie
extended config space.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
hw/vfio/pci.c | 73
For vfio device, we need to propagate the aer error to
Guest OS. we use the pcie_aer_msg() to send aer error
to guest.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
hw/pci/pcie_aer.c | 2 +-
include/hw/pci/pcie_aer.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
Copying Eric for additional QAPI design expertise.
I'm going to review just the QAPI schema changes.
Liang Li liang.z...@intel.com writes:
Add the qmp and hmp commands to tune and query the parameters used in
live migration.
Signed-off-by: Liang Li liang.z...@intel.com
Signed-off-by: Yang
when the vfio device encounters an uncorrectable error in host,
the vfio_pci driver will signal the eventfd registered by this
vfio device, the results in the qemu eventfd handler getting
invoked.
this patch is to pass the error to guest and have the guest driver
recover from the error.
* Jason J. Herne (jjhe...@linux.vnet.ibm.com) wrote:
We have a test case that dirties memory very very quickly. When we run this
test case in a guest and attempt a migration, that migration never converges
even when done with auto-converge on.
The auto converge behavior of Qemu functions
.../qga/vss-win32/install.cpp:52: undefined reference to `__stack_chk_fail'
The patch fixes the problem by adding -fstack-protector-all option to the
linker options' list.
Signed-off-by: Joseph Hindin jhin...@daynix.com
---
qga/vss-win32/Makefile.objs | 2 +-
1 file changed, 1 insertion(+), 1
d598911b6f5e7bf7bafb63b8e1d074729e94aca7:
Merge remote-tracking branch
'remotes/pmaydell/tags/pull-target-arm-20150311' into staging (2015-03-11
16:30:33 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-sdl-20150312-1
for you to fetch changes up
Make info iothreads available on the HMP monitor.
The results are as follows:
id1: thread_id=thread_id1
id2: thread_id=thread_id2
Signed-off-by: Ting Wang kathy.wangt...@huawei.com
---
v3: fix comment and the trailing whitespace
v2: add braces for if
---
hmp-commands.hx | 2 ++
hmp.c
Jan Kiszka jan.kis...@web.de writes:
Hi Markus,
due to a lack of publicly available documentation on the Coverity
modeling language (or my blindness to find it), I was about to steal
some patterns from QEMU (to improve the kmalloc model for the kernel). I
think I stumbled over some
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
There is already a helper function ram_bytes_total(), we can use it to
help counting the total number of pages used by ram blocks.
Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com
---
arch_init.c | 8 +---
1 file
From: Scott Feldman sfel...@gmail.com
Add some basic test for rocker to test L2/L3/L4 functionality. Requires an
external test environment, simp, located here:
https://github.com/scottfeldman/simp
To run tests, simp environment must be installed and a suitable VM image built
and installed with
From: Scott Feldman sfel...@gmail.com
Rocker is an ethernet switch device, so add 'other' network device class as
defined by PCI to cover these types of devices.
Signed-off-by: Scott Feldman sfel...@gmail.com
Signed-off-by: Jiri Pirko j...@resnulli.us
Message-id:
For the ARM M-profile cores, exception return pops various registers
including the PC from the stack. The architecture defines that if the
lowest bit in the new PC value is set (ie the PC is not halfword
aligned) then behaviour is UNPREDICTABLE. In practice hardware
implementations seem to simply
The glib headers use GCC attributes. Unfortunately the __GNUC__ and
__GNUC_MINOR__ version macros are also defined by clang, but clang
doesn't support the same attributes as GCC.
clang 3.5.0 does not support the __alloc_size__ attribute:
From: Paolo Bonzini pbonz...@redhat.com
Using net_host_check_device is unnecessary. qemu_del_net_client asserts
for the non-peer case that it can only process NIC type NetClientStates,
and that assertion is valid for the peered case as well, so move it and
use the same check in
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Reviewed-by: Eric Blake ebl...@redhat.com
Message-id: 1424123271-7656-3-git-send-email-sfel...@gmail.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
hw/net/virtio-net.c | 12 +++-
1 file
From: Scott Feldman sfel...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Signed-off-by: Jiri Pirko j...@resnulli.us
Message-id: 1424123271-7656-5-git-send-email-sfel...@gmail.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
docs/specs/pci-ids.txt | 1 +
include/hw/pci/pci.h
v3:
* Add clang 3.5.0 warning fixes
* Squash David Ahern's clang struct definition warnings fix
v2:
* Squash in Jiri's fix for rocker format string specifiers [Peter]
* Squash in Windows build fix [Peter]
* Both build fixes are described in rocker: add new rocker switch device
The following
From: David Ahern dsah...@gmail.com
Signed-off-by: David Ahern dsah...@gmail.com
Signed-off-by: Scott Feldman sfel...@gmail.com
Signed-off-by: Jiri Pirko j...@resnulli.us
Message-id: 1424123271-7656-11-git-send-email-sfel...@gmail.com
Signed-off-by: Stefan Hajnoczi stefa...@redhat.com
---
gcc 4.9.2 treats -nopie as an error:
cc: error: unrecognized command line option ‘-nopie’
clang 3.5.0 treats -nopie as a warning:
clang: warning: argument unused during compilation: '-nopie'
The causes ./configure to fail with clang:
ERROR: configure test passed without -Werror but
From: Scott Feldman sfel...@gmail.com
We can use this in virtio-net code as well as new Rocker driver code, so
up-level this.
Signed-off-by: Scott Feldman sfel...@gmail.com
Reviewed-by: Eric Blake ebl...@redhat.com
Message-id: 1424123271-7656-2-git-send-email-sfel...@gmail.com
Signed-off-by:
From: Frediano Ziglio fredd...@gmail.com
Test behaviour of timers and interrupts related to timeouts.
Signed-off-by: Frediano Ziglio fredd...@gmail.com
Reviewed-by: Paolo Bonzini pbonz...@redhat.com
Message-id: 1420742303-3030-1-git-send-email-fredd...@gmail.com
Signed-off-by: Stefan Hajnoczi
From: Scott Feldman sfel...@gmail.com
This is the register programming guide for the Rocker device. It's intended
for driver writers and device writers. It covers the device's PCI space,
the register set, DMA interface, and interrupts.
Signed-off-by: Scott Feldman sfel...@gmail.com
On Thu, 2015-03-12 at 11:18 +0800, Chen, Tiejun wrote:
+
+if (b_info-u.hvm.gfx_passthru_kind ==
+LIBXL_GFX_PASSTHRU_KIND_DEFAULT) {
+if (libxl__is_igd_vga_passthru(gc, guest_config))
+machinearg = GCSPRINTF(%s,igd-passthru=on,
Allocate the calculated overall size, not only the size of a single
element.
Signed-off-by: Jan Kiszka jan.kis...@siemens.com
---
scripts/coverity-model.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/coverity-model.c b/scripts/coverity-model.c
index
2015年3月11日 16:55于 Philipp Hahn h...@univention.de写道：
Hello,
On 11.03.2015 07:22, Xiaodong Gong wrote:
Hope that clarified things.
...
first，your patch is very clear，a good sample.
store ascii code in kernel that I said before is a mistake，I mean the
glibc need the input of arguments
-for-2.3-1' into
staging (2015-03-11 14:27:13 +)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-vnc-20150312-1
for you to fetch changes up to 81607cbfa433272d1f09bd0f0ae6c3b14f818972:
vnc: fix segmentation fault when invalid vnc parameters are specified
On 11 March 2015 at 18:38, Andrew Jones drjo...@redhat.com wrote:
This series fixes and extends the determination of whether or
not an address is executable for LPAE translations. The main
patch is 3/3, and describes the details in its commit message.
Patch 1/3 prepares for patch 2/3, which is
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
On 2015/3/12 3:08, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
We only need to flush RAM that is both dirty on PVM and SVM since
last checkpoint. Besides, we must ensure flush RAM cache before
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
On 2015/3/12 4:07, Dr. David Alan Gilbert wrote:
* zhanghailiang (zhang.zhanghaili...@huawei.com) wrote:
We only need to flush RAM that is both dirty on PVM and SVM since
last checkpoint. Besides, we must ensure flush RAM cache before
We don't validate the existence of handle_output which may let a buggy
guest to trigger a SIGSEV easily. E.g:
1) write 10 to queue_sel to a virtio net device with only 1 queue
2) setup an arbitrary pfn
3) then notify queue 10
Fixing this by validating the existence of handle_output before.
Cc:
On Thu, 03/12 10:41, Michael S. Tsirkin wrote:
On Thu, Mar 12, 2015 at 02:40:55PM +0800, Fam Zheng wrote:
Currently we could leave PCI IRQ asserted even after reset, it is safer
to clear it.
In the case that a buggy driver has disabled MSI-X unintentially, we may
have already injected
On Thu, Mar 12, 2015 at 10:54:24AM +0100, Frank Blaschka wrote:
On Wed, Mar 11, 2015 at 06:42:34PM +0100, Michael S. Tsirkin wrote:
On Wed, Mar 11, 2015 at 03:38:44PM +0100, Frank Blaschka wrote:
On Tue, Mar 10, 2015 at 03:26:23PM +0100, Michael S. Tsirkin wrote:
On Tue, Mar 10, 2015 at
Michael Tokarev m...@tls.msk.ru writes:
Don't compare syscall return with -1, use 0 condition.
Don't introduce useless local variables when we already
have similar variable
Rename local variable to be consistent with other usages
Finally make the two methods, read and write, to be similar to
I am submitting the revised patch for linking qga-vss.dll with 64-bit MinGW
toolchain.
Regards,
Joseph Hindin
Calling pcie_aer_init to initilize aer related registers for
vfio device, then reload physical related registers to expose
device capability.
Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com
---
hw/vfio/pci.c | 45 -
1 file changed, 44
Hi,
Still fails to build on OSX:
manooth$ make -C build/all
CClm32-softmmu/hw/lm32/milkymist.o
In file included from /Users/pm215/src/qemu/hw/lm32/milkymist.c:30:
/Users/pm215/src/qemu/hw/lm32/milkymist-hw.h:90:10: fatal error:
'X11/Xlib.h' file not found
#include X11/Xlib.h
On 12 March 2015 at 10:57, Michael S. Tsirkin m...@redhat.com wrote:
This isn't a device reset though.
The function that Fam is touching is called
when a special virtio reset register to
poked by the driver.
It only resets part of the device, not all of it,
and it seems reasonable to ask
On 12/03/15 16:51, Bastian Koppelmann wrote:
Hi Bastian,
On 03/12/2015 03:41 PM, Richard Henderson wrote:
On 03/12/2015 01:41 AM, Mark Cave-Ayland wrote:
Whilst testing git master in preparation for some OpenBIOS updates, I'm
seeing the following TCG assert in one of my older test images:
On Thu, Mar 12, 2015 at 3:07 PM, Bandan Das b...@redhat.com wrote:
jacob jacob opstk...@gmail.com writes:
Hi,
Seeing failures when trying to do PCI passthrough of Intel XL710 40G
interface to KVM vm.
0a:00.1 Ethernet controller: Intel Corporation Ethernet
Controller XL710 for 40GbE
On 12/03/15 14:55, Bastian Koppelmann wrote:
Hi Bastian,
Hi Mark, sorry I forgot to cc qemu-devel :/
On 03/12/2015 08:41 AM, Mark Cave-Ayland wrote:
Hi all,
Whilst testing git master in preparation for some OpenBIOS updates, I'm
seeing the following TCG assert in one of my older test
On Thu, 03/12 15:57, Paolo Bonzini wrote:
monitor_fdset_add_fd returns an AddfdInfo struct (used by the QMP
command add_fd). Free it.
Signed-off-by: Paolo Bonzini pbonz...@redhat.com
---
vl.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index
On Mar 12, 2015 4:34 PM, Mark Cave-Ayland mark.cave-ayl...@ilande.co.uk wrote:
Yes indeed, this fixes the issue in my tests here. But from what you're
saying this is more of a workaround rather than a fix?
Correct. It simply shows a bug in tcg/optimize.c. At least we have a
workaround if a
Michael S. Tsirkin m...@redhat.com writes:
On Thu, Mar 12, 2015 at 11:34:35AM +1030, Rusty Russell wrote:
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Mar 11, 2015 at 10:06:40PM +1030, Rusty Russell wrote:
Each entry in the ring is a pair: \field{id} indicates the head
Michael S. Tsirkin m...@redhat.com writes:
On Wed, Mar 11, 2015 at 02:19:03PM +0100, Michael S. Tsirkin wrote:
QEMU wants to use virtio scsi structures with
a different VIRTIO_SCSI_CDB_SIZE/VIRTIO_SCSI_SENSE_SIZE,
let's add ifdefs to allow overriding them.
Keep the old defines under new
On 2015/3/13 0:43, Andreas Färber wrote:
Hello,
The main patch of this series is an HMP command info qom-tree,
which displays the machine composition tree. This names all objects,
including those missing in info qtree for lack of bus or for not being a
device.
Properties can be listed
On 2015-3-12 22:03, Stefan Hajnoczi wrote:
On Thu, Mar 12, 2015 at 04:35:24PM +0800, Ting Wang wrote:
+void hmp_info_iothreads(Monitor *mon, const QDict *qdict)
+{
+IOThreadInfoList *head = NULL, *elem = NULL;
+
+head = qmp_query_iothreads(NULL);
+if (!head) {
+
On 2015/3/13 0:43, Andreas Färber wrote:
Implement it as a wrapper for QMP qom-list, but mimic the behavior of
scripts/qmp/qom-list in making the path argument optional and listing
the root if absent, to hint users what kind of path to pass.
Signed-off-by: Andreas Färber afaer...@suse.de
On 2015/3/13 0:43, Andreas Färber wrote:
Re-implemented based on qmp_qom_set() to facilitate argument parsing.
Warn about ambiguous path arguments.
Signed-off-by: Andreas Färber afaer...@suse.de
---
hmp-commands.hx | 13 +
hmp.c | 21 +
hmp.h
On 2015/3/13 0:43, Andreas Färber wrote:
Reimplement it based on qmp_qom_get() to avoid converting QObjects back
to strings.
Inspired-by: Paolo Bonzini pbonz...@redhat.com
Signed-off-by: Andreas Färber afaer...@suse.de
---
hmp-commands.hx | 13 +
hmp.c | 22
The caller's workflow is like
if (!address_space_map()) {
...
cpu_register_map_client();
}
If bounce buffer became available after address_space_map() but before
cpu_register_map_client(), the caller could miss it and has to wait for the
next bounce buffer uesr to
There could be a race condition when two processes call
address_space_map concurrently and both want to use the bounce buffer.
Add an in_use flag in BounceBuffer to sync it.
Signed-off-by: Fam Zheng f...@redhat.com
---
exec.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git
The global bounce buffer used for non-direct memory access is not thread-safe:
1) Access to bounce is not atomic.
2) Access to map_client_list is not atomic.
3) In dma_blk_cb, there is a race condition between:
mem = dma_memory_map(dbs-sg-as, cur_addr, cur_len, dbs-dir);
/*
That if the dbs' owner is an iothread, dma should be resumed on the right
thread. In this case it is the AioContext of the block device.
Signed-off-by: Fam Zheng f...@redhat.com
---
dma-helpers.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/dma-helpers.c b/dma-helpers.c
Change map_client_list to QSLIST which supports atomic operations.
There are two access points to map_client_list. One is
cpu_register_map_client, the other is cpu_notify_map_clients called
after releasing the global bounce buffer in address_space_unmap. Each
is now converted to a single atomic
201 - 300 of 333 matches
Mail list logo
