Re: [Qemu-devel] [2.4 PATCH v3 16/19] hbitmap: truncate tests

2015-03-17 Thread Max Reitz
On 2015-03-13 at 14:30, John Snow wrote: The general approach is to set bits close to the boundaries of where we are truncating and ensure that everything appears to have gone OK. We test growing and shrinking by different amounts: - Less than the granularity - Less than the granularity, but

Re: [Qemu-devel] [PATCH 1/7] bt-sdp: fix broken uuids power-of-2 calculation

2015-03-17 Thread Eric Blake
On 03/17/2015 05:56 AM, Stefan Hajnoczi wrote: The binary search in sdp_uuid_match() only works when the number of elements to search is a power of two. lo = record-uuid; hi = record-uuids; while (hi = 1) if (lo[hi] = val) lo += hi; return *lo == val; I

[Qemu-devel] [PULL 3/7] qom: Implement qom-list HMP command

2015-03-17 Thread Andreas Färber
Implement it as a wrapper for QMP qom-list, but mimic the behavior of scripts/qmp/qom-list in making the path argument optional and listing the root if absent, to hint users what kind of path to pass. Reviewed-by: Gonglei arei.gong...@huawei.com Tested-by: Alistair Francis

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-03-17 Thread Alberto Garcia
On Thu, Mar 12, 2015 at 04:45:17PM +0100, Kevin Wolf wrote: One issue that I'm finding is that when we move the block-stream job to an intermediate node, where the device name is empty, we get messages like Device '' is busy. I can use node names instead, but they are also not

[Qemu-devel] [PULL 5/7] qom: Implement info qom-tree HMP command

2015-03-17 Thread Andreas Färber
To complement qdev's bus-oriented info qtree, info qom-tree prints a hierarchical view of the QOM composition tree. By default, the machine composition tree is shown. This can be overriden by supplying a path argument, such as info qom-tree /. Tested-by: Alistair Francis

[Qemu-devel] [PULL 4/7] qom: Implement qom-set HMP command

2015-03-17 Thread Andreas Färber
Re-implemented based on qmp_qom_set() to facilitate argument parsing. Warn about ambiguous path arguments. Reviewed-by: Gonglei arei.gong...@huawei.com Tested-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de --- hmp-commands.hx | 13 +

[Qemu-devel] [PATCH v2 3/9] uninorth: convert ffs(3) to ctz32()

2015-03-17 Thread Stefan Hajnoczi
It is not clear from the code how a 0 parameter should be handled by the hardware. Keep the same behavior as ffs(0) - 1 == -1. Cc: Alexander Graf ag...@suse.de Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/pci-host/uninorth.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[Qemu-devel] [PATCH v2 4/9] Convert (ffs(val) - 1) to ctz32(val)

2015-03-17 Thread Stefan Hajnoczi
This commit was generated mechanically by coccinelle from the following semantic patch: @@ expression val; @@ - (ffs(val) - 1) + ctz32(val) The call sites have been audited to ensure the ffs(0) - 1 == -1 case never occurs (due to input validation, asserts, etc). Therefore we don't need to worry

[Qemu-devel] [PATCH v2 7/9] omap_intc: convert ffs(3) to ctz32() in omap_inth_sir_update()

2015-03-17 Thread Stefan Hajnoczi
The loop previously terminated on ffs(0) == 0, now it terminates on ctz32(0) + 1 == 33. Other than this change, ffs() is simply replaced with ctz32() + 1. Cc: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/intc/omap_intc.c | 7 --- 1 file

[Qemu-devel] [PATCH v2 8/9] os-win32: drop ffs(3) prototype

2015-03-17 Thread Stefan Hajnoczi
The lack of ffs(3) in the MinGW headers is a hint that we shouldn't rely on it. MinGW 4.9.2 does not make it available for linking when QEMU's ./configure --enable-debug is used (release builds are fine though). Now that all QEMU code has been switched to ctz32() there is no need for ffs(3).

Re: [Qemu-devel] [PATCH 01/11] qapi: Add transaction support to block-dirty-bitmap operations

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if

[Qemu-devel] [PULL 01/13] migration: Avoid qerror_report_err() outside QMP command handlers

2015-03-17 Thread Juan Quintela
From: Markus Armbruster arm...@redhat.com qerror_report_err() is a transitional interface to help with converting existing monitor commands to QMP. It should not be used elsewhere. Replace by error_report_err() in process_incoming_migration_co(). Signed-off-by: Markus Armbruster

[Qemu-devel] [PULL 11/13] hmp: Rename 'MigrationStatus' to 'HMPMigrationStatus'

2015-03-17 Thread Juan Quintela
From: zhanghailiang zhang.zhanghaili...@huawei.com We will use the typename 'MigrationStatus' for publicly exported typename, So here we rename the internal-only 'MigrationStatus' to 'HMPMigrationStatus'. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Reviewed-by: Eric Blake

[Qemu-devel] [PULL 08/13] arch_init: Count the total number of pages by using helper function

2015-03-17 Thread Juan Quintela
From: zhanghailiang zhang.zhanghaili...@huawei.com There is already a helper function ram_bytes_total(), we can use it to help counting the total number of pages used by ram blocks. Signed-off-by: zhanghailiang zhang.zhanghaili...@huawei.com Reviewed-by: Dr. David Alan Gilbert

[Qemu-devel] [PULL 2/7] scripts: Add qom-tree script

2015-03-17 Thread Andreas Färber
Functionally it is a recursive qom-list with qom-get per non-child property. Some failures needed to be handled, such as trying to read a pointer property, which is not representable in QMP. Those print a literal EXCEPTION. Tested-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by:

[Qemu-devel] [PULL 7/7] qdev: Move owner-less IRQs to /machine/unattached

2015-03-17 Thread Andreas Färber
Move non-qdev-gpio[*] from /machine into /machine/unattached. For the PC this moves 25 nodes from the stable namespace into the unstable. Cc: Peter Crosthwaite peter.crosthwa...@xilinx.com Tested-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Andreas Färber afaer...@suse.de ---

[Qemu-devel] [PULL 0/7] QOM devices patch queue 2015-03-17

2015-03-17 Thread Andreas Färber
Hello Peter, This is my QOM (devices) patch queue. Please pull. Regards, Andreas Cc: Peter Maydell peter.mayd...@linaro.org Cc: Alistair Francis alistair.fran...@xilinx.com The following changes since commit 5a4992834daec85c3913654903fb9f4f954e585a: Merge remote-tracking branch

[Qemu-devel] [PULL 1/7] cadence_uart: Convert to QOM realize()

2015-03-17 Thread Andreas Färber
From: Alistair Francis alistair.fran...@xilinx.com Use DeviceClass::realize() and TypeInfo::instance_init() instead of the deprecated SysBusDevice::init(). Signed-off-by: Alistair Francis alistair.fran...@xilinx.com Reviewed-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Signed-off-by:

Re: [Qemu-devel] [2.4 PATCH] target-mips: add Config5.FRE support allowing Status.FR=0 emulation

2015-03-17 Thread James Hogan
On 17/03/15 13:08, Leon Alrae wrote: Hi James, On 17/03/2015 10:55, James Hogan wrote: Hi Leon, On 17/03/15 09:56, Leon Alrae wrote: +case 5: +/* FRE Support - clear Config5.FRE bit */ +if (!((env-active_fpu.fcr0 (1 FCR0_FREP)) (rt == 0))) { +return;

[Qemu-devel] [PATCH v2 0/9] Convert ffs(3) to ctz32()

2015-03-17 Thread Stefan Hajnoczi
v2: * Audit coccinelle patch and split out two cases where ctz32(0) == 32 must be handled [Peter] * Cc qemu-sta...@nongnu.org on first patch [Eric] MinGW does not always provide ffs(3). My MinGW 4.9.2 cannot link QEMU when ./configure --enable-debug was used due to the missing ffs(3)

[Qemu-devel] [PATCH v2] Fix typos in comments

2015-03-17 Thread Viswesh
The commit message is changed per review comments of Peter Maydell. This should be good now. Reviewed-by: Peter Maydell peter.mayd...@linaro.org Signed-off-by: Viswesh viswesh...@gmail.com --- fsdev/virtfs-proxy-helper.c | 2 +- target-tricore/translate.c | 22 +++--- 2 files

[Qemu-devel] [PULL 6/7] memory: Move owner-less MemoryRegions to /machine/unattached

2015-03-17 Thread Andreas Färber
This cleans up the official /machine namespace. In particular /machine/system[0] and /machine/io[0], as well as entries with non-sanitized node names such as /machine/qemu extended regs[0]. The actual MemoryRegion names remain unchanged. Acked-by: Paolo Bonzini pbonz...@redhat.com Tested-by:

[Qemu-devel] [PATCH v2 1/9] bt-sdp: fix broken uuids power-of-2 calculation

2015-03-17 Thread Stefan Hajnoczi
The binary search in sdp_uuid_match() only works when the number of elements to search is a power of two. lo = record-uuid; hi = record-uuids; while (hi = 1) if (lo[hi] = val) lo += hi; return *lo == val; I noticed that the record-uuids calculation in

[Qemu-devel] [PATCH v2 6/9] sd: convert sd_normal_command() ffs(3) call to ctz32()

2015-03-17 Thread Stefan Hajnoczi
ffs() cannot be replaced with ctz32() when the argument might be zero, because ffs(0) returns 0 while ctz32(0) returns 32. The ffs(3) call in sd_normal_command() is a special case though. It can be converted to ctz32() + 1 because the argument is never zero: if (!(req.arg 8) || (req.arg

[Qemu-devel] [PATCH v2 2/9] hw/arm/nseries: convert ffs(3) to ctz32()

2015-03-17 Thread Stefan Hajnoczi
It is not clear from the code how a 0 parameter should be handled by the hardware. Keep the same behavior as ffs(0) - 1 == -1. Cc: Andrzej Zaborowski bal...@zabor.org Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- hw/arm/nseries.c | 5 - 1 file changed, 4 insertions(+), 1

[Qemu-devel] [PATCH v2 5/9] Convert ffs() != 0 callers to ctz32()

2015-03-17 Thread Stefan Hajnoczi
There are a number of ffs(3) callers that do roughly: bit = ffs(val); if (bit) { do_something(bit - 1); } This pattern can be converted to ctz32() like this: zeroes = ctz32(val); if (zeroes != 32) { do_something(zeroes); } Signed-off-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH v4 1/5] target-arm: kvm: save/restore mp state

2015-03-17 Thread Peter Maydell
On 16 March 2015 at 11:01, Alex Bennée alex.ben...@linaro.org wrote: This adds the saving and restore of the current Multi-Processing state of the machine. While the KVM_GET/SET_MP_STATE API exposes a number of potential states for x86 we only use two for ARM. Either the process is running or

[Qemu-devel] [PATCH v2 9/9] checkpatch: complain about ffs(3) calls

2015-03-17 Thread Stefan Hajnoczi
The ffs(3) family of functions is not portable. MinGW doesn't always provide the function. Use ctz32() or ctz64() instead. Signed-off-by: Stefan Hajnoczi stefa...@redhat.com --- scripts/checkpatch.pl | 11 +++ 1 file changed, 11 insertions(+) diff --git a/scripts/checkpatch.pl

[Qemu-devel] [PULL 07/13] migrate_incoming: Cleanup/clarify error messages

2015-03-17 Thread Juan Quintela
From: Dr. David Alan Gilbert dgilb...@redhat.com Create a separate error for the case where migrate_incoming is used after a succesful migrate_incoming. Reword the error in the case where '-incoming defer' is missing to omit the command name so it's right for both hmp and qmp. Signed-off-by:

Re: [Qemu-devel] [PATCH 2/3] block: Add QMP support for streaming to an intermediate layer

2015-03-17 Thread Alberto Garcia
On Tue, Mar 17, 2015 at 09:22:55AM -0600, Eric Blake wrote: The BlockJobInfo object returned by query-block-jobs identifies the owner of the job using the 'device' field. If jobs can be in any intermediate node then we cannot simply rely on the device name. We also cannot simply replace

[Qemu-devel] [PULL 02/13] migration/rdma: clean up qemu_rdma_dest_init a bit

2015-03-17 Thread Juan Quintela
From: Michael Tokarev m...@tls.msk.ru Do not check for rdma-host being empty twice. This removes a large if block, so code indentation is changed. While at it, remove an ugly goto from the loop, replacing it with a cleaner if logic. And finally, there's no need to initialize `ret' variable

[Qemu-devel] [PULL 04/13] migration: Fix remaining 32 bit compiler errors

2015-03-17 Thread Juan Quintela
From: Stefan Weil s...@weilnetz.de Fix type casts between pointers and 64 bit integers. Now 32 bit builds are possible again. Signed-off-by: Stefan Weil s...@weilnetz.de Signed-off-by: Juan Quintela quint...@redhat.com --- migration/rdma.c | 53

[Qemu-devel] [PATCH] target-arm: rename c1_coproc to cpacr_el1

2015-03-17 Thread Sergey Fedorov
Rename the field holding CPACR_EL1 system register state in AArch64 naming style. Signed-off-by: Sergey Fedorov serge.f...@gmail.com --- hw/arm/pxa2xx.c | 2 +- target-arm/cpu.h| 4 ++-- target-arm/helper.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [Qemu-devel] [PATCH target-arm v3 04/15] arm: xlnx-zynqmp: Add GIC

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: And connect IRQ outputs to the CPUs. Reviewed-by: Alistair Francis alistair.fran...@xilinx.com Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- hw/arm/xlnx-zynqmp.c | 19

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 2/3] VFIO: Disable INTx interrupt on EEH reset

2015-03-17 Thread Gavin Shan
On Tue, Mar 17, 2015 at 03:16:46PM -0600, Alex Williamson wrote: On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: When Linux guest recovers from EEH error on the following Emulex adapter, the MSIx interrupts are disabled and the INTx emulation is enabled. One INTx interrupt is injected to

Re: [Qemu-devel] [PATCH target-arm v3 15/15] arm: xlnx-zynqmp: Add PSCI setup

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Use SMC PSCI, with the standard policy of secondaries starting in power-off. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com Looks good, Reviewed-by: Alistair Francis

Re: [Qemu-devel] [PATCH v5 0/2] Introduce default ram size in MachineClass

2015-03-17 Thread Nikunj A Dadhania
Nikunj A Dadhania nik...@linux.vnet.ibm.com writes: Current DEFAULT_RAM_SIZE(128MB) enforced by QEMU would not work for all machines. Introduce a default_ram_size as part of MachineClass. The below patches has following behaviour: 1) If the user does not provide -m option, machine's default

Re: [Qemu-devel] [PATCH target-arm v3 12/15] arm: Add xlnx-ep108 machine

2015-03-17 Thread Alistair Francis
On Mon, Mar 16, 2015 at 10:12 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Add a machine model for the Xilinx ZynqMP SoC EP108 board. Signed-off-by: Peter Crosthwaite peter.crosthwa...@xilinx.com --- Chaned since v1: Change board name to ep108 hw/arm/Makefile.objs | 2 +-

Re: [Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
I should mention that I hunted down all new instances of funky error classes since 2.2. This is the last one. The other two are: [PATCH] vnc: Fix QMP change not to use funky error class [PATCH] block: Fix block-set-write-threshold not to use funky error class

Re: [Qemu-devel] [PATCH 1/9] virtio-gpu/2d: add hardware spec include file

2015-03-17 Thread Gerd Hoffmann
Hi, There are some conflicts with the latest specification I was able to obtain (https://www.kraxel.org/virtio/virtio-v1.0-csprd03-virtio-gpu.pdf); for instance, the ordering of the fields in virtio_gpu_resp_display_info is different there, some GPU formats are different (but no

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Bharata B Rao
On Tue, Mar 17, 2015 at 07:56:41AM +0100, Alexander Graf wrote: On 13.03.15 12:56, Bharata B Rao wrote: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Alexander Graf
On 13.03.15 12:56, Bharata B Rao wrote: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available index is calculated by counting the existing number of CPUs. This is

Re: [Qemu-devel] KVM emulation failure with recent kernel and QEMU Seabios

2015-03-17 Thread Gerd Hoffmann
On Mo, 2015-03-16 at 14:16 -0400, Bandan Das wrote: Jan Kiszka jan.kis...@siemens.com writes: Am 2015-03-12 um 09:11 schrieb Gerd Hoffmann: On Do, 2015-03-12 at 09:09 +0100, Jan Kiszka wrote: Hi, apparently since the latest QEMU updates I'm getting this once in a while:

Re: [Qemu-devel] lsi53c895a lsi_do_dma assertion failure

2015-03-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 16/03/2015 16:59, Chris Takemura wrote: Hi everyone, We're using qemu as a device model for xen 4.4. Lately we've been having qemu crashes with this output: lsi_scsi: error: Unhandled writeb 0xff = 0x0 lsi_scsi: error: Unhandled writeb

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-17 Thread Gerd Hoffmann
Hi, - Separate VNC auth scheme is tracked for websockets server, since it makes no sense to try to use VeNCrypt over a TLS enabled websockets connection. Hmm. That is a problem for the QAPI, the auth scheme is linked to the vnc server not the socket. What is the point in having

Re: [Qemu-devel] [PATCH] hmp: Fix texinfo documentation

2015-03-17 Thread Markus Armbruster
Ping for 2.3 Markus Armbruster arm...@redhat.com writes: Several issues: * Commands i and o lack @item. Their one-liner documentation gets squashed into the preceding command print. Add the obvious @item. * Commands i, o and cpu-add lack @findex. The function index doesn't have

Re: [Qemu-devel] [PATCH] fdc: remove sparc sun4m mutations

2015-03-17 Thread Hervé Poussineau
Hi, Le 16/03/2015 22:48, John Snow a écrit : On 03/14/2015 12:50 PM, Hervé Poussineau wrote: They were introduced in 6f7e9aec5eb5bdfa57a9e458e391b785c283a007 and 82407d1a4035e5bfefb53ffdcb270872f813b34c and lots of bug fixes were done after that. This fixes (at least) the detection of the

[Qemu-devel] [Bug 1432861] Re: configure can't find opengl

2015-03-17 Thread Stefan Weil
Confirmed for Debian Jessie, too. The package mesa-common-dev includes /usr/include/GL/glx.h, but only a /usr/lib/x86_64-linux-gnu/pkgconfig/dri.pc. There is no glx.pc for Debian. ** Changed in: qemu Status: New = Confirmed -- You received this bug notification because you are a member

Re: [Qemu-devel] [Bug 1432861] Re: configure can't find opengl

2015-03-17 Thread Gonglei
On 2015/3/17 14:29, Stefan Weil wrote: Confirmed for Debian Jessie, too. The package mesa-common-dev includes /usr/include/GL/glx.h, but only a /usr/lib/x86_64-linux-gnu/pkgconfig/dri.pc. There is no glx.pc for Debian. Does this patch fix ?

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-03-17 Thread Markus Armbruster
Alexander Graf ag...@suse.de writes: On 09.03.15 19:30, Markus Armbruster wrote: Alexander Graf ag...@suse.de writes: On 27.02.15 13:43, Markus Armbruster wrote: Convert device models macio-oldworld and macio-newworld. Signed-off-by: Markus Armbruster arm...@redhat.com --- Depends on my

Re: [Qemu-devel] [PATCH] kvm: fix ioeventfd endianness on bi-endian architectures

2015-03-17 Thread Greg Kurz
On Sun, 15 Mar 2015 10:14:18 +0100 Paolo Bonzini pbonz...@redhat.com wrote: On 13/03/2015 22:30, Patchew Tool wrote: This series passed Patchew automatic testing, but there are some warnings. Find the log fragments below, or open the following URL to see the full log:

Re: [Qemu-devel] [PATCH] coverity: Fix g_malloc_n-like models

2015-03-17 Thread Paolo Bonzini
On 17/03/2015 09:34, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Allocate the calculated overall size, not only the size of a single element. Signed-off-by: Jan Kiszka jan.kis...@siemens.com I'm feeding this to Coverity locally to gauge its impact. I got no

Re: [Qemu-devel] [RFC 0/2] macio: split out unaligned DMA access into separate functions

2015-03-17 Thread Alexander Graf
On 09.03.15 23:24, Mark Cave-Ayland wrote: This patchset attempts to separate out the IDE/ATAPI logic from the unaligned DMA access logic for macio which provides the following benefits: 1) Reduced code complexity The existing macio IDE/ATAPI functions were becoming extremely difficult

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-03-17 Thread Alexander Graf
On 17.03.15 08:46, Markus Armbruster wrote: Alexander Graf ag...@suse.de writes: On 09.03.15 19:30, Markus Armbruster wrote: Alexander Graf ag...@suse.de writes: On 27.02.15 13:43, Markus Armbruster wrote: Convert device models macio-oldworld and macio-newworld. Signed-off-by: Markus

Re: [Qemu-devel] [PATCH 2/2 RFC] s390x/pci: rework pci infrastructure modeling

2015-03-17 Thread Alexander Graf
On 12.03.15 16:22, Michael S. Tsirkin wrote: On Thu, Mar 12, 2015 at 09:59:59AM -0500, Alexander Graf wrote: On 12.03.15 08:16, Frank Blaschka wrote: On Thu, Mar 12, 2015 at 11:50:02AM +0100, Frank Blaschka wrote: On Thu, Mar 12, 2015 at 11:03:50AM +0100, Michael S. Tsirkin wrote: On Thu,

Re: [Qemu-devel] IO port 0x61 is multiple used

2015-03-17 Thread Gonglei
On 2015/3/15 20:49, Weidong Huang wrote: Hi ALL: IO port 0x61 is used by pc speaker and NMI reason port. This is ambiguous. How to distinguish in QEMU? I see that NMI reason port is not realized in QEMU. But linux guest will access this port to determine what the NMI reason code

Re: [Qemu-devel] [PATCH v2 0/9] qom: HMP commands to supersede info qtree

2015-03-17 Thread Markus Armbruster
Andreas Färber afaer...@suse.de writes: Hello, The main patch of this series is an HMP command info qom-tree, which displays the machine composition tree. This names all objects, including those missing in info qtree for lack of bus or for not being a device. Properties can be listed

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-17 Thread Chen, Tiejun
If I remember the context correctly this is in the autodetect case, so I think shouldn't mention IGD. Something like Unable to detect graphics passthru kind, please set gfx_passthru_kind. See xl.cfg(5) for more s/gfx_passthru_kind/gfx_passthru, right? Because actually we always get

Re: [Qemu-devel] [PATCH 2/6] fw_cfg: remove support for guest-side data writes

2015-03-17 Thread Gerd Hoffmann
Hi, Another possibility is to leave the write_ops in there, but turn them into no-ops. That is the safe choice. Just have a write function with /* nothing, write support removed in qemu 2.4+ */. That is basically the same we have today (writes are ignored), but a bit more efficient because

Re: [Qemu-devel] [PATCH] vnc: Fix QMP change not to use funky error class

2015-03-17 Thread Markus Armbruster
Markus Armbruster arm...@redhat.com writes: Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit 1d0d59f added a use of ERROR_CLASS_DEVICE_NOT_FOUND. Replace it. Forgot to spell it out: this needs to go into 2.3,

Re: [Qemu-devel] [PATCH 8/9] virtio-gpu: add to display-vga test

2015-03-17 Thread Gerd Hoffmann
Hi, +#ifdef CONFIG_VIRTIO_GPU +qtest_add_func(/display/pci/virtio-gpu, pci_virtio_gpu); +qtest_add_func(/display/pci/virtio-vga, pci_virtio_vga); +#endif ret = g_test_run(); return ret; Which config file is defining this? Ahem, good point,

Re: [Qemu-devel] [PATCH] qdev: Make -device FOO, help help again when FOO is not pluggable

2015-03-17 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Mon, Mar 16, 2015 at 06:33:52PM +0100, Markus Armbruster wrote: Doesn't work since commit 31bed55 changed qdev_device_help() to reject abstract devices and devices that have cannot_instantiate_with_device_add_yet set. The former makes sense:

Re: [Qemu-devel] [PATCH] add pci-bridge-seat

2015-03-17 Thread Gerd Hoffmann
On Mo, 2015-03-16 at 13:20 +0100, Michael S. Tsirkin wrote: On Mon, Mar 16, 2015 at 11:36:43AM +0100, Gerd Hoffmann wrote: Simplifies multiseat configuration, see docs/multiseat.txt update for details. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- docs/multiseat.txt

Re: [Qemu-devel] [PATCH v2] microblaze: fix memory leak

2015-03-17 Thread Gonglei
On 2015/3/5 11:05, arei.gong...@huawei.com wrote: From: Gonglei arei.gong...@huawei.com When not assign a -dtb argument, the variable dtb_filename storage returned from qemu_find_file(), which should be freed after use. Alternatively we define a local variable filename, with 'char *' type,

Re: [Qemu-devel] [PATCH] macio: Convert to realize()

2015-03-17 Thread Alexander Graf
On 09.03.15 19:30, Markus Armbruster wrote: Alexander Graf ag...@suse.de writes: On 27.02.15 13:43, Markus Armbruster wrote: Convert device models macio-oldworld and macio-newworld. Signed-off-by: Markus Armbruster arm...@redhat.com --- Depends on my [PATCH 00/10] pci: Partial

[Qemu-devel] [PATCH] block: Fix blockdev-backup not to use funky error class

2015-03-17 Thread Markus Armbruster
Error classes are a leftover from the days of rich error objects. New code should always use ERROR_CLASS_GENERIC_ERROR. Commit b7b9d39..7c6a4ab added uses of ERROR_CLASS_DEVICE_NOT_FOUND. Replace them. Signed-off-by: Markus Armbruster arm...@redhat.com --- blockdev.c | 8

Re: [Qemu-devel] [PATCH 2/9] virtio-gpu/2d: add virtio gpu core code

2015-03-17 Thread Gerd Hoffmann
Hi, +for (i = 0; i g-conf.max_outputs; i++) { +g-scanout[i].con = +graphic_console_init(DEVICE(g), i, virtio_gpu_ops, g); +if (i 0) { +dpy_gfx_replace_surface(g-scanout[i].con, NULL); GTK can't cope very well with NULL surfaces (read:

Re: [Qemu-devel] [PATCH] coverity: Fix g_malloc_n-like models

2015-03-17 Thread Markus Armbruster
Jan Kiszka jan.kis...@siemens.com writes: Allocate the calculated overall size, not only the size of a single element. Signed-off-by: Jan Kiszka jan.kis...@siemens.com I'm feeding this to Coverity locally to gauge its impact.

Re: [Qemu-devel] [PATCH 10/11] iotests: 124 - backup_prepare refactoring

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: Allow tests to call just the backup preparation routine without invoking a backup. Useful for transactions where we want to prepare, but don't wish to issue the QMP command. Signed-off-by: John Snow js...@redhat.com --- tests/qemu-iotests/124 | 17

[Qemu-devel] [PATCH] qtest/ahci: Fix clang 3.5.0 error

2015-03-17 Thread John Snow
A thinko that clang 3.5.0 caught. Thankfully does not introduce any new failures. Signed-off-by: John Snow js...@redhat.com --- tests/ahci-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/ahci-test.c b/tests/ahci-test.c index cf0b98b..169e83b 100644 ---

Re: [Qemu-devel] [PATCH 11/11] iotests: 124 - transactional failure test

2015-03-17 Thread John Snow
On 03/17/2015 04:59 PM, Max Reitz wrote: On 2015-03-04 at 23:15, John Snow wrote: Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure.

Re: [Qemu-devel] [PATCH v2 0/5] block/vpc optimizations

2015-03-17 Thread Max Reitz
On 2015-03-03 at 16:03, Max Reitz wrote: On 2015-03-03 at 05:41, Peter Lieven wrote: This series covers VPC format changes discussed during the last weeks. Peter v1-v2: Patch 1: added comment why we can exit after the first allocated sector [Max] Patch 2: Fixed gemotry in commit msg

Re: [Qemu-devel] [PATCH v4 4/5] target-arm: kvm64 fix save/restore of SPSR regs

2015-03-17 Thread Peter Maydell
On 17 March 2015 at 19:04, Christoffer Dall christoffer.d...@linaro.org wrote: On Tue, Mar 17, 2015 at 04:18:16PM +, Peter Maydell wrote: Note that this code is implicitly relying on the ordering of register banks defined by the bank_number() function, which is a bit icky. right, I

[Qemu-devel] RFC: -object vs -chardev creation order

2015-03-17 Thread Daniel P. Berrange
The current QEMU startup code will create -chardev backends first, then create -object backends, then -fsdev backends and so on, in some pretty arbitrary order of types. There is already a dependancy from the rng-egd object type, which has a link to a chardev, which requires -chardev options be

Re: [Qemu-devel] [PATCH v2 2/3] VFIO: Disable INTx interrupt on EEH reset

2015-03-17 Thread Alex Williamson
On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: When Linux guest recovers from EEH error on the following Emulex adapter, the MSIx interrupts are disabled and the INTx emulation is enabled. One INTx interrupt is injected to the guest by host because of detected pending INTx interrupts on

Re: [Qemu-devel] [PATCH 11/11] iotests: 124 - transactional failure test

2015-03-17 Thread Max Reitz
On 2015-03-04 at 23:15, John Snow wrote: Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. Signed-off-by: John Snow js...@redhat.com

Re: [Qemu-devel] [PATCH v2 1/3] VFIO: Clear stale MSIx table during EEH reset

2015-03-17 Thread Alex Williamson
On Tue, 2015-03-17 at 03:31 +1100, Gavin Shan wrote: The PCI device MSIx table is cleaned out in hardware after EEH PE reset. However, we still hold the stale MSIx entries in QEMU, which should be cleared accordingly. Otherwise, we will run into another (recursive) EEH error and the PCI

[Qemu-devel] Am I too late for GCoS? I want to participate

2015-03-17 Thread Jose enrique Ruiz navarro
Sorry but I am new to this. Is it too late to talk to some mentor for Google summer? I am a bachelor student of University of Seville. I want to participate on this project. I used this virtualitazion and I would like giving my knowledge Sorry for being late

[Qemu-devel] [PULL 1/1] opengl: fix configure test

2015-03-17 Thread Gerd Hoffmann
Re-add the glx compile test to configure. We can't use pkg-config to probe for glx, and as long as milkymist-tmu2 privately uses glx (due to opengl infrastructure in qemu not being ready yet) we must continue to test for glx to avoid build failures. Reported-by: Juan Quintela quint...@redhat.com

Re: [Qemu-devel] [PULL 00/17] Block patches for 2.3.0-rc0

2015-03-17 Thread Peter Maydell
On 16 March 2015 at 16:57, Kevin Wolf kw...@redhat.com wrote: The following changes since commit dcf848c478dd8765bd4f746fc4e80eaad44cf87d: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150316' into staging (2015-03-16 13:56:10 +) are available in the git

[Qemu-devel] [PULL 0/1] coverity: Fix g_malloc_n-like models

2015-03-17 Thread Markus Armbruster
This can safely go into 2.3. I can also wait for 2.4. Your choice. The following changes since commit 17b11a1406fdc43b5022f32a6fbfcb005a353b38: Merge remote-tracking branch 'remotes/bkoppelmann/tags/pull-tricore-20150316' into staging (2015-03-16 18:27:13 +) are available in the git

[Qemu-devel] [PULL 1/1] coverity: Fix g_malloc_n-like models

2015-03-17 Thread Markus Armbruster
From: Jan Kiszka jan.kis...@siemens.com Allocate the calculated overall size, not only the size of a single element. Signed-off-by: Jan Kiszka jan.kis...@siemens.com Signed-off-by: Markus Armbruster arm...@redhat.com --- scripts/coverity-model.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [Qemu-devel] [PATCH 00/10] spapr: Small patches to prepare for Dynamic DMA windows

2015-03-17 Thread Alexey Kardashevskiy
On 03/10/2015 02:51 PM, Alexey Kardashevskiy wrote: On 02/23/2015 07:33 PM, Alexey Kardashevskiy wrote: These I have in my DDW working tree for quite a while, while I am polishing others, there could go to some tree already. Please comment. Thanks! Alex, ping. spapr_pci: Make

Re: [Qemu-devel] [v2][PATCH 2/2] libxl: introduce gfx_passthru_kind

2015-03-17 Thread Ian Campbell
On Tue, 2015-03-17 at 15:46 +0800, Chen, Tiejun wrote: If I remember the context correctly this is in the autodetect case, so I think shouldn't mention IGD. Something like Unable to detect graphics passthru kind, please set gfx_passthru_kind. See xl.cfg(5) for more

[Qemu-devel] [PULL for-2.3 0/1] opengl: fix configure test

2015-03-17 Thread Gerd Hoffmann
in the git repository at: git://git.kraxel.org/qemu tags/pull-gl-20150317-1 for you to fetch changes up to b1546f3210d89662dca3e88e1021a0089f003551: opengl: fix configure test (2015-03-17 11:10:48 +0100) opengl: fix configure test

Re: [Qemu-devel] [PATCH] coverity: Fix g_malloc_n-like models

2015-03-17 Thread Markus Armbruster
Paolo Bonzini pbonz...@redhat.com writes: On 17/03/2015 09:34, Markus Armbruster wrote: Jan Kiszka jan.kis...@siemens.com writes: Allocate the calculated overall size, not only the size of a single element. Signed-off-by: Jan Kiszka jan.kis...@siemens.com I'm feeding this to Coverity

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 09:39 schrieb Bharata B Rao: On Tue, Mar 17, 2015 at 07:56:41AM +0100, Alexander Graf wrote: On 13.03.15 12:56, Bharata B Rao wrote: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the

Re: [Qemu-devel] [2.4 PATCH] target-mips: add Config5.FRE support allowing Status.FR=0 emulation

2015-03-17 Thread James Hogan
Hi Leon, On 17/03/15 09:56, Leon Alrae wrote: This relatively small architectural feature adds the following: FIR.FREP: Read-only. If FREP=1, then Config5.FRE and Config5.UFE are available. Config5.FRE: When enabled all single-precision FP arithmetic instructions,

Re: [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-17 Thread Matt Fleming
On Mon, 2015-03-16 at 10:15 -0400, Gabriel L. Somlo wrote: Allow user supplied files to be inserted into the fw_cfg device before starting the guest. Since fw_cfg_add_file() already disallows duplicate fw_cfg file names, qemu will exit with an error message if the user supplies multiple blobs

[Qemu-devel] [2.4 PATCH] target-mips: add Config5.FRE support allowing Status.FR=0 emulation

2015-03-17 Thread Leon Alrae
This relatively small architectural feature adds the following: FIR.FREP: Read-only. If FREP=1, then Config5.FRE and Config5.UFE are available. Config5.FRE: When enabled all single-precision FP arithmetic instructions, LWC1/LWXC1/MTC1, SWC1/SWXC1/MFC1 cause a Reserved Instructions

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-17 Thread Daniel P. Berrange
On Tue, Mar 17, 2015 at 08:36:40AM +0100, Gerd Hoffmann wrote: Hi, - Separate VNC auth scheme is tracked for websockets server, since it makes no sense to try to use VeNCrypt over a TLS enabled websockets connection. Hmm. That is a problem for the QAPI, the auth scheme is

Re: [Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

2015-03-17 Thread Andreas Färber
Am 17.03.2015 um 10:08 schrieb Chen Fan: ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bus-less CPU+APIC hotplug, handling them in

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-17 Thread Gerd Hoffmann
On Di, 2015-03-17 at 10:33 +, Daniel P. Berrange wrote: On Tue, Mar 17, 2015 at 08:36:40AM +0100, Gerd Hoffmann wrote: Hi, - Separate VNC auth scheme is tracked for websockets server, since it makes no sense to try to use VeNCrypt over a TLS enabled websockets

[Qemu-devel] [PATCH 1/2] cpu/apic: drop icc bus/bridge/

2015-03-17 Thread Chen Fan
ICC bus was invented only to provide hotplug capability to CPU and APIC because at the time being hotplug was available only for BUS attached devices. Now this patch is to drop ICC bus impl, and switch to bus-less CPU+APIC hotplug, handling them in the same manner as pc-dimm. Signed-off-by: Chen

[Qemu-devel] [PATCH 2/2] icc_bus: remove icc related files

2015-03-17 Thread Chen Fan
ICC bus impl has been droped, so all icc related files are not useful any more; delete them. Signed-off-by: Chen Fan chen.fan.f...@cn.fujitsu.com --- default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/cpu/Makefile.objs | 2 -

Re: [Qemu-devel] [PATCH 5/6] fw_cfg: insert fw_cfg file blobs via qemu cmdline

2015-03-17 Thread Gerd Hoffmann
Hi, +static struct FWCfgOption { +const char *name; +const char *file; +} *fw_cfg_options; +static int fw_cfg_num_options; +void fw_cfg_option_add(QemuOpts *opts) +static void fw_cfg_options_insert(FWCfgState *s) Hmm, when looking at this (and the existing fw_cfg init order

Re: [Qemu-devel] [PATCH 3/3] ui: fix VNC websockets TLS integration

2015-03-17 Thread Daniel P. Berrange
On Tue, Mar 17, 2015 at 08:36:40AM +0100, Gerd Hoffmann wrote: Hi, - Separate VNC auth scheme is tracked for websockets server, since it makes no sense to try to use VeNCrypt over a TLS enabled websockets connection. Hmm. That is a problem for the QAPI, the auth scheme is

[Qemu-devel] [PATCH v2] acpi: add acpi_send_gpe_event() to rise sci for hotplug

2015-03-17 Thread Zhu Guihua
Add a new API named acpi_send_gpe_event() to send hotplug SCI. This API can be used by pci, cpu and memory hotplug. Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com --- v2: -fix the coding style --- hw/acpi/core.c | 7 +++ hw/acpi/cpu_hotplug.c| 3 +--

[Qemu-devel] [PATCH] migration: flush the bdrv before stopping VM

2015-03-17 Thread Liang Li
If there are file write operations in the guest when doing live migration, the VM downtime will be much longer than the max_downtime, this is caused by bdrv_flush_all(), this function is a time consuming operation if there a lot of data have to be flushed to disk. By adding bdrv_flush_all()

Re: [Qemu-devel] [RFC v0 PATCH] cpus: Convert cpu_index into a bitmap

2015-03-17 Thread Andreas Färber
Am 13.03.2015 um 12:56 schrieb Bharata B Rao: From: Bharata B Rao bharata@gmail.com Currently CPUState.cpu_index is monotonically increasing and a newly created CPU always gets the next higher index. The next available index is calculated by counting the existing number of CPUs. This is

  1   2   3   >