[Qemu-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-14 Thread Gerd Hoffmann
Denis Kirjanov is busy getting spice run on ppc64 and trapped into this one. Spice wire format is little endian, so we have to explicitly say we want little endian when letting pixman convert the data for us. Reported-by: Denis Kirjanov Signed-off-by: Gerd Hoffmann --- include/ui/qemu-pixman.h

Re: [Qemu-devel] [RFC PATCH v2 21/23] spapr: Initialize hotplug memory address space

2015-04-14 Thread David Gibson
On Mon, Apr 13, 2015 at 04:55:52PM +0200, Igor Mammedov wrote: > On Mon, 13 Apr 2015 19:57:05 +0530 > Bharata B Rao wrote: > > > On Mon, Apr 13, 2015 at 04:04:24PM +0200, Igor Mammedov wrote: > > > On Mon, 13 Apr 2015 08:29:33 +0530 > > > Bharata B Rao wrote: > > > > > > > On Wed, Mar 25, 2015

Re: [Qemu-devel] [PATCH 3/7] ipxe: add local patches

2015-04-14 Thread Gerd Hoffmann
Hi, > > > > +ipxe/qemu-patches: > > Looks like this is only ever removed by clean? Should depend on the > patch files, in case they change with an update. Indeed. > But why are you adding patch files in the first place? Can't we just > push the commits to a branch on git.qemu-project.org an

[Qemu-devel] [PATCH] block/iscsi: do not forget to logout from target

2015-04-14 Thread Peter Lieven
We actually were always impolitely dropping the connection and not cleanly logging out. Cc: qemu-sta...@nongnu.org Signed-off-by: Peter Lieven --- block/iscsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/iscsi.c b/block/iscsi.c index ab20e4d..0b6d3dd 100644 --- a/block/iscsi

Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

2015-04-14 Thread Juan Quintela
"Li, Liang Z" wrote: > >> Eric, can you review this and the following patch? I think they are >> correct, but >> I preffer someone more versed on QMP to review them. >> >> Thanks, Juan. > > Hi Juan & Eric, > > Since the latest QEMU is 2.3.0-rc2, is it possible to merge this > serial of pa

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-14 Thread Peter Maydell
On 14 April 2015 at 02:10, Shannon Zhao wrote: > On 2015/4/13 23:58, Alex Bennée wrote: >> >> Shannon Zhao writes: >>> +UUID = aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657, >>> 0x7441C03DD766); >> >> This looks like a fairly unreadable uuid already. What are these magic >> numbers? >> > > Y

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-14 Thread Shannon Zhao
On 2015/4/14 17:30, Peter Maydell wrote: > On 14 April 2015 at 02:10, Shannon Zhao wrote: >> On 2015/4/13 23:58, Alex Bennée wrote: >>> >>> Shannon Zhao writes: +UUID = aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657, 0x7441C03DD766); >>> >>> This looks like a fairly unreadable uuid a

Re: [Qemu-devel] Failing iotests in v2.3.0-rc2 / master

2015-04-14 Thread Kevin Wolf
Am 11.04.2015 um 05:41 hat Andreas Färber geschrieben: > Hi, > > 001 seems to hang for -qcow (or is not reasonably "quick": >5 min). > > 033 is failing for -vhdx. > > (Note that `make check-block` only tests -qcow2, so didn't uncover > either of them.) > > Given a failing test, am I seeing corr

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-14 Thread Michael S. Tsirkin
On Tue, Apr 14, 2015 at 05:55:39PM +0800, Shannon Zhao wrote: > On 2015/4/14 17:30, Peter Maydell wrote: > > On 14 April 2015 at 02:10, Shannon Zhao wrote: > >> On 2015/4/13 23:58, Alex Bennée wrote: > >>> > >>> Shannon Zhao writes: > +UUID = aml_touuid(0x33DB4D5B, 0x1FF7, 0x401C, 0x9657

Re: [Qemu-devel] [PATCH v4 19/20] hw/arm/virt-acpi-build: Add PCIe controller in ACPI DSDT table

2015-04-14 Thread Shannon Zhao
On 2015/4/14 17:59, Michael S. Tsirkin wrote: > On Tue, Apr 14, 2015 at 05:55:39PM +0800, Shannon Zhao wrote: >> On 2015/4/14 17:30, Peter Maydell wrote: >>> On 14 April 2015 at 02:10, Shannon Zhao wrote: On 2015/4/13 23:58, Alex Bennée wrote: > > Shannon Zhao writes: >> +UUI

Re: [Qemu-devel] [PATCH v4 16/20] hw/acpi/aml-build: Add aml_else() term

2015-04-14 Thread Igor Mammedov
On Tue, 14 Apr 2015 14:38:18 +0800 Shannon Zhao wrote: > On 2015/4/14 13:56, Michael S. Tsirkin wrote: > > On Mon, Apr 13, 2015 at 04:55:13PM +0100, Alex Bennée wrote: > >> > >> Shannon Zhao writes: > >> > >>> From: Shannon Zhao > >>> > >>> Signed-off-by: Shannon Zhao > >>> Signed-off-by: Shan

Re: [Qemu-devel] [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-14 Thread Christophe Fergeau
Hey, On Tue, Apr 14, 2015 at 09:14:53AM +0200, Gerd Hoffmann wrote: > Denis Kirjanov is busy getting spice run on ppc64 and trapped into this > one. Spice wire format is little endian, so we have to explicitly say > we want little endian when letting pixman convert the data for us. This patch lo

Re: [Qemu-devel] Very poor IO performance which looks like some design problem.

2015-04-14 Thread Kevin Wolf
Am 13.04.2015 um 14:28 hat ein geschrieben: > Dear Fam, > > Check out my update please: > http://lists.nongnu.org/archive/html/qemu-devel/2015-04/msg01318.html > > Using aio=native,cache=none results in 500%-2000% performance drop comparing > to > bare metal and 300%-1000% comparing to aio=threa

[Qemu-devel] [PULL for-2.3 0/1] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-04-14 Thread Gerd Hoffmann
release (2015-04-13 17:35:44 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-fwcfg-20150414-1 for you to fetch changes up to 6cec43e178cde38a3eac43a2cd741ce741b10f36: fw_cfg: add documentation file (docs/specs/fw_cfg.txt) (2015-04-14 13:21:08 +0200

[Qemu-devel] [PULL 1/1] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-04-14 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" This document covers the guest-side hardware interface, as well as the host-side programming API of QEMU's firmware configuration (fw_cfg) device. Signed-off-by: Jordan Justen Signed-off-by: Gabriel Somlo Reviewed-by: Laszlo Ersek Signed-off-by: Gerd Hoffmann --- do

Re: [Qemu-devel] [PULL for-2.3 0/1] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-04-14 Thread Peter Maydell
On 14 April 2015 at 12:27, Gerd Hoffmann wrote: > Hi, > > Damn, wanted to sent this out last week, then forgot, so it missed -rc3. > But it is a documentation-only change, so it should still be fine for > 2.3, right? My inclination is to only put this in if something else turns up that we must

Re: [Qemu-devel] [PATCH v4] target-i386: Register QOM properties for feature flags

2015-04-14 Thread Igor Mammedov
On Fri, 10 Apr 2015 17:02:29 -0300 Eduardo Habkost wrote: > This uses the feature name arrays to register QOM properties for feature > flags. This simply adds properties that can be configured using -global, > but doesn't change x86_cpu_parse_featurestr() to use them yet. > > Signed-off-by: Edua

Re: [Qemu-devel] [v7 11/14] migration: Add interface to control compression

2015-04-14 Thread Eric Blake
On 04/08/2015 12:20 AM, Liang Li wrote: > The multiple compression threads can be turned on/off through > qmp and hmp interface before doing live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > Reviewed-by: Dr.David Alan Gilbert > Reviewed-by: Eric Blake > --- > migration

Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters

2015-04-14 Thread Eric Blake
On 04/08/2015 05:37 AM, Juan Quintela wrote: > Liang Li wrote: >> Put the three parameters related to multiple thread (de)compression >> into an int array, and use an enum type to index the parameter. >> >> Signed-off-by: Liang Li >> Signed-off-by: Yang Zhang > > Reviewed-by: Juan Quintela >

Re: [Qemu-devel] [v7 12/14] migration: Use an array instead of 3 parameters

2015-04-14 Thread Eric Blake
On 04/08/2015 12:20 AM, Liang Li wrote: > Put the three parameters related to multiple thread (de)compression > into an int array, and use an enum type to index the parameter. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > include/migration/migration.h | 4 +--- > migration/mi

Re: [Qemu-devel] [PATCH] target-i386: Remove AMD feature flag aliases from CPU model table

2015-04-14 Thread Igor Mammedov
On Fri, 10 Apr 2015 15:02:45 -0300 Eduardo Habkost wrote: > When CPU vendor is AMD, the AMD feature alias bits on > CPUID[0x8001].EDX are already automatically copied from CPUID[1].EDX > on x86_cpu_realizefn(). When CPU vendor is Intel, those bits are > reserved and should be zero. On either

Re: [Qemu-devel] [PATCH v5 15/45] Rework loadvm path for subloops

2015-04-14 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:38PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Postcopy needs to have two migration streams loading concurrently; > > one from memory (with the device state) and the oth

Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

2015-04-14 Thread Eric Blake
On 04/08/2015 12:20 AM, Liang Li wrote: > Add the qmp commands to tune and query the parameters used in live > migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > migration/migration.c | 56 ++ > qapi-schema.json | 45 +

Re: [Qemu-devel] [v7 13/14] migration: Add qmp commands to set and query parameters

2015-04-14 Thread Eric Blake
On 04/14/2015 06:09 AM, Eric Blake wrote: > On 04/08/2015 12:20 AM, Liang Li wrote: >> Add the qmp commands to tune and query the parameters used in live >> migration. >> >> Signed-off-by: Liang Li >> Signed-off-by: Yang Zhang >> --- >> migration/migration.c | 56 >>

Re: [Qemu-devel] [v7 14/14] migration: Add hmp interface to set and query parameters

2015-04-14 Thread Eric Blake
On 04/08/2015 12:20 AM, Liang Li wrote: > Add the hmp interface to tune and query the parameters used in > live migration. > > Signed-off-by: Liang Li > Signed-off-by: Yang Zhang > --- > hmp-commands.hx | 17 +++ > hmp.c | 65 >

Re: [Qemu-devel] KVM call agenda for 2015-04-14

2015-04-14 Thread Juan Quintela
Juan Quintela wrote: > Hi > > Please, send any topic that you are interested in covering. > As there are no agenda, call get cancelled. Later, Juan. > > Call details: > > By popular demand, a google calendar public entry with it > > > https://www.google.com/calendar/embed?src=dG9iMXRqcXAz

Re: [Qemu-devel] [PULL 1/1] fw_cfg: add documentation file (docs/specs/fw_cfg.txt)

2015-04-14 Thread Eric Blake
On 04/14/2015 05:27 AM, Gerd Hoffmann wrote: > From: "Gabriel L. Somlo" > > This document covers the guest-side hardware interface, as > well as the host-side programming API of QEMU's firmware > configuration (fw_cfg) device. > > Signed-off-by: Jordan Justen > Signed-off-by: Gabriel Somlo > R

Re: [Qemu-devel] [PATCH v3 1/2] apic: move apic mmio register to each apic realizefn

2015-04-14 Thread Igor Mammedov
On Fri, 10 Apr 2015 16:18:05 +0800 Chen Fan wrote: > Due to local apic address is in view of CPU's address space, > so able to move apic mapping to each apic realizefn. > > Signed-off-by: Chen Fan > --- > hw/i386/pc.c | 7 --- > hw/intc/apic_common.c | 11 +-- > 2 files c

Re: [Qemu-devel] [PATCH v3 1/2] apic: move apic mmio register to each apic realizefn

2015-04-14 Thread Andreas Färber
Am 14.04.2015 um 14:41 schrieb Igor Mammedov: > On Fri, 10 Apr 2015 16:18:05 +0800 > Chen Fan wrote: > >> Due to local apic address is in view of CPU's address space, >> so able to move apic mapping to each apic realizefn. >> >> Signed-off-by: Chen Fan >> --- >> hw/i386/pc.c | 7 -

Re: [Qemu-devel] [PATCH 3/7] ipxe: add local patches

2015-04-14 Thread Andreas Färber
Hi Gerd, + Stefan, - ipxe-devel Am 14.04.2015 um 09:36 schrieb Gerd Hoffmann: >> But why are you adding patch files in the first place? Can't we just >> push the commits to a branch on git.qemu-project.org and update the >> submodule config accordingly? > > I hope this is just temporary, so I di

[Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-14 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/pci-host/q35.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c index 79bab15..9227489 100644 --- a/hw/pci-host/q35.c +++ b/hw/pci-host/q35.c @@ -268,6 +268,20 @@ static void mch_update_

[Qemu-devel] [PATCH 2/2] q35: add test for SMRAM.D_LCK

2015-04-14 Thread Gerd Hoffmann
--- tests/Makefile | 2 ++ tests/smram-test.c | 80 ++ 2 files changed, 82 insertions(+) create mode 100644 tests/smram-test.c diff --git a/tests/Makefile b/tests/Makefile index 55aa745..cf2bd87 100644 --- a/tests/Makefile +++ b/tests/Make

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Thomas Huth
Am Wed, 8 Apr 2015 21:02:49 +0100 schrieb Peter Maydell : > The second argument of g_base64_decode() is a 'gsize *', not a > 'size_t *'. Some compilation environments (like building 32-bit PPC > binaries on a PPC64 system) will complain about the mismatch: > > CCqga/commands-posix.o > qga/

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Peter Maydell
On 14 April 2015 at 14:42, Paolo Bonzini wrote: > > > On 08/04/2015 22:02, Peter Maydell wrote: >> The second argument of g_base64_decode() is a 'gsize *', not a >> 'size_t *'. Some compilation environments (like building 32-bit PPC >> binaries on a PPC64 system) will complain about the mismatch:

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Paolo Bonzini
On 08/04/2015 22:02, Peter Maydell wrote: > The second argument of g_base64_decode() is a 'gsize *', not a > 'size_t *'. Some compilation environments (like building 32-bit PPC > binaries on a PPC64 system) will complain about the mismatch: > > CCqga/commands-posix.o > qga/commands-posix.c

Re: [Qemu-devel] [PATCH v3 2/2] cpu/apic: drop icc bus/bridge/

2015-04-14 Thread Igor Mammedov
On Fri, 10 Apr 2015 16:18:06 +0800 Chen Fan wrote: > ICC bus was invented only to provide hotplug capability to > CPU and APIC because at the time being hotplug was available only for > BUS attached devices. > > Now this patch is to drop ICC bus impl, and switch to bus-less > CPU+APIC hotplug, h

Re: [Qemu-devel] [PATCH v3 2/2] cpu/apic: drop icc bus/bridge/

2015-04-14 Thread Andreas Färber
Am 14.04.2015 um 15:27 schrieb Igor Mammedov: > On Fri, 10 Apr 2015 16:18:06 +0800 > Chen Fan wrote: > >> ICC bus was invented only to provide hotplug capability to >> CPU and APIC because at the time being hotplug was available only for >> BUS attached devices. >> >> Now this patch is to drop IC

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Peter Maydell
On 14 April 2015 at 14:38, Thomas Huth wrote: > Am Wed, 8 Apr 2015 21:02:49 +0100 > schrieb Peter Maydell : > >> The second argument of g_base64_decode() is a 'gsize *', not a >> 'size_t *'. Some compilation environments (like building 32-bit PPC >> binaries on a PPC64 system) will complain about

Re: [Qemu-devel] [PATCH v4] target-i386: Register QOM properties for feature flags

2015-04-14 Thread Eduardo Habkost
On Tue, Apr 14, 2015 at 01:49:19PM +0200, Igor Mammedov wrote: > On Fri, 10 Apr 2015 17:02:29 -0300 > Eduardo Habkost wrote: > > > This uses the feature name arrays to register QOM properties for feature > > flags. This simply adds properties that can be configured using -global, > > but doesn't

Re: [Qemu-devel] [PATCH v4] target-i386: Register QOM properties for feature flags

2015-04-14 Thread Igor Mammedov
On Tue, 14 Apr 2015 11:08:39 -0300 Eduardo Habkost wrote: [...] > > > +/* Register a boolean feature-bits property. > > > + * If mask has multiple bits, all must be set for the property to return > > > true. > > > + * The same property name can be registered multiple times to make it > > > affe

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 15:45, Peter Maydell wrote: > On 14 April 2015 at 14:42, Paolo Bonzini wrote: >> >> >> On 08/04/2015 22:02, Peter Maydell wrote: >>> The second argument of g_base64_decode() is a 'gsize *', not a >>> 'size_t *'. Some compilation environments (like building 32-bit PPC >>> binaries o

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 15:41, Peter Maydell wrote: > No, this is not-for-2.3. I think that the issue here is that > merely adding -m32 isn't sufficient, because pkg-config when > run by configure will end up pointing at a bunch of incorrect > glib includes (for x86-64, not i386). So the actual solution >

Re: [Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 15:12, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/q35.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c > index 79bab15..9227489 100644 > --- a/hw/pci-host/q35.c > +++ b/

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Eric Blake
On 04/14/2015 08:29 AM, Paolo Bonzini wrote: > But you can: gsize is defined to be "An unsigned integer type of the > result of the sizeof operator, corresponding to the size_t type defined > in C99. Good so far. > This type is wide enough to hold the numeric value of a pointer, Not true on plat

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Peter Maydell
On 14 April 2015 at 15:29, Paolo Bonzini wrote: > If anything, I would add a QEMU_BUILD_BUG_ON(sizeof(gsize) != > sizeof(size_t)) to catch the problem, since we've had many experienced > developers caught unprepared. ...put it in configure, since it's a configuration error? -- PMM

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 16:35, Eric Blake wrote: > On 04/14/2015 08:29 AM, Paolo Bonzini wrote: >> But you can: gsize is defined to be "An unsigned integer type of >> the result of the sizeof operator, corresponding to the size_t >> type defined in C99. > > Good so far. > >> This type is wide enough to h

Re: [Qemu-devel] [PATCH] qga/commands-posix.c: Use correct types with g_base64_decode()

2015-04-14 Thread Eric Blake
On 04/14/2015 08:50 AM, Paolo Bonzini wrote: > > > On 14/04/2015 16:35, Eric Blake wrote: >> On 04/14/2015 08:29 AM, Paolo Bonzini wrote: >>> But you can: gsize is defined to be "An unsigned integer type of >>> the result of the sizeof operator, corresponding to the size_t >>> type defined in C99

[Qemu-devel] [PATCH] linux-user: Allocate thunk size dynamically

2015-04-14 Thread Alexander Graf
We store all struct types in an array of static size without ever checking whether we overrun it. Of course some day someone (like me in another, ancient ALSA enabling patch set) will run into the limit without realizing it. So let's make the allocation dynamic. We already know the number of struc

[Qemu-devel] [ANNOUNCE] QEMU 2.3.0-rc3 is now available

2015-04-14 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.3 release. This release is meant for testing purposes and should not be used in a production environment. http://wiki.qemu.org/download/qemu-2.3.0-rc3.tar.bz2 This releases

[Qemu-devel] [PATCH v5] target-i386: Register QOM properties for feature flags

2015-04-14 Thread Eduardo Habkost
This uses the feature name arrays to register QOM properties for feature flags. This simply adds properties that can be configured using -global, but doesn't change x86_cpu_parse_featurestr() to use them yet. Signed-off-by: Eduardo Habkost --- Changes v1 -> v2: * Use "cpuid-" prefix instead of "f

[Qemu-devel] [PATCH] m25p80: add missing blk_attach_dev_nofail

2015-04-14 Thread Paolo Bonzini
Of the block devices that poked into -drive options via drive_get_next, m25p80 was the only one who also did not attach itself to the BlockBackend. Since sd does it, and all other devices go through a "drive" property, with this change all block backends attached to the guest will have a non-NULL

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-14 Thread Corey Minyard
On 04/14/2015 01:31 AM, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: >> >> On 13/04/2015 18:34, Corey Minyard wrote: > I made this the same as the ACPI code, which you have to have as a > callback if you are adding it to a common SSDT. Not

Re: [Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-14 Thread Michael S. Tsirkin
On Tue, Apr 14, 2015 at 03:12:39PM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > hw/pci-host/q35.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.c > index 79bab15..9227489 100644 > --- a/hw/pci-

Re: [Qemu-devel] [PATCH 1/2] q35: implement SMRAM.D_LCK

2015-04-14 Thread Michael S. Tsirkin
On Tue, Apr 14, 2015 at 05:41:14PM +0200, Michael S. Tsirkin wrote: > On Tue, Apr 14, 2015 at 03:12:39PM +0200, Gerd Hoffmann wrote: > > Signed-off-by: Gerd Hoffmann > > --- > > hw/pci-host/q35.c | 17 - > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/hw/

Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT

2015-04-14 Thread Eric Blake
[adding qemu] On 04/14/2015 09:58 AM, Marc-André Lureau wrote: > Hi > > On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander > wrote: > >> Is this not exposed in any way in QEMU? Do we really need to use this >> (what we're trying to avoid)? >> > > That works with the following change: > > dif

Re: [Qemu-devel] [V9fs-developer] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2015-04-14 Thread Al Viro
On Mon, Apr 13, 2015 at 04:05:28PM +, Eric Van Hensbergen wrote: > Well, technically fid 3 isn't 'open', only fid 2 is open - at least > according to the protocol. fid 3 and fid 2 are both clones of fid 1. > However, thanks for the alternative workaround. If you get a chance, can > you check

Re: [Qemu-devel] [V9fs-developer] [Bug 1336794] Re: 9pfs does not honor open file handles on unlinked files

2015-04-14 Thread Eric Van Hensbergen
That patch looks fine by me. Happy to put it in the queue. Thanks Al. On Tue, Apr 14, 2015 at 11:07 AM Al Viro wrote: > On Mon, Apr 13, 2015 at 04:05:28PM +, Eric Van Hensbergen wrote: > > Well, technically fid 3 isn't 'open', only fid 2 is open - at least > > according to the protocol. f

Re: [Qemu-devel] [libvirt] [PATCH 3/5] qemu: add QEMU_CAPS_MACHINE_VMPORT_OPT

2015-04-14 Thread Martin Kletzander
On Tue, Apr 14, 2015 at 10:07:00AM -0600, Eric Blake wrote: [adding qemu] On 04/14/2015 09:58 AM, Marc-André Lureau wrote: Hi On Tue, Apr 14, 2015 at 4:25 PM, Martin Kletzander wrote: Is this not exposed in any way in QEMU? Do we really need to use this (what we're trying to avoid)? Tha

Re: [Qemu-devel] [PATCH 10/15] smbios: Add a function to directly add an entry

2015-04-14 Thread Paolo Bonzini
On 14/04/2015 08:31, Michael S. Tsirkin wrote: > On Mon, Apr 13, 2015 at 06:40:46PM +0200, Paolo Bonzini wrote: >> >> >> On 13/04/2015 18:34, Corey Minyard wrote: > I made this the same as the ACPI code, which you have to have as a > callback if you are adding it to a common SSDT. >>

[Qemu-devel] feature proposal: checkpoint-assisted migration

2015-04-14 Thread Thomas Knauth
Dear list, my research revolves around cloud computing, virtual machines and migration. In this context I came across the following: a recent study by IBM indicates that a typical VM only migrates between a small set of physical servers; often just two. The potential for optimization is clear. By

[Qemu-devel] QUESTION:use tlb with alignment address

2015-04-14 Thread pandayt
hi all, When translate a read/write instruction, qemu will check tlb first, but why alignment is needed when read/write data is 2/4/8 bytes? For example, if there's a instruction which read a double word(such as mov ebx, [eax]), and the source address(i.e. eax) is 0x00401003, not aligns by

Re: [Qemu-devel] [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-14 Thread Denis Kirjanov
On 4/14/15, Denis Kirjanov wrote: > On 4/14/15, Gerd Hoffmann wrote: >> Denis Kirjanov is busy getting spice run on ppc64 and trapped into this >> one. Spice wire format is little endian, so we have to explicitly say >> we want little endian when letting pixman convert the data for us. >> >> Rep

Re: [Qemu-devel] [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-14 Thread Denis Kirjanov
On 4/14/15, Gerd Hoffmann wrote: > Denis Kirjanov is busy getting spice run on ppc64 and trapped into this > one. Spice wire format is little endian, so we have to explicitly say > we want little endian when letting pixman convert the data for us. > > Reported-by: Denis Kirjanov > Signed-off-by:

Re: [Qemu-devel] [Spice-devel] [PATCH] spice: fix simple display on bigendian hosts

2015-04-14 Thread Denis Kirjanov
On 4/14/15, Denis Kirjanov wrote: > On 4/14/15, Denis Kirjanov wrote: >> On 4/14/15, Gerd Hoffmann wrote: >>> Denis Kirjanov is busy getting spice run on ppc64 and trapped into this >>> one. Spice wire format is little endian, so we have to explicitly say >>> we want little endian when letting

[Qemu-devel] [PATCH v6 00/47] Postcopy implementation

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" This is the 6th cut of my version of postcopy; it is designed for use with the Linux kernel additions posted by Andrea Arcangeli here: git clone --reference linux -b userfault18 git://git.kernel.org/pub/scm/linux/kernel/git/andrea/aa.git (Note this is a differe

[Qemu-devel] [PATCH v6 02/47] Split header writing out of qemu_savevm_state_begin

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Split qemu_savevm_state_begin to: qemu_savevm_state_header That writes the initial file header. qemu_savevm_state_beginThat sets up devices and does the first device pass. Used later in postcopy. Signed-off-by: Dr. David Alan

[Qemu-devel] [PATCH v6 04/47] Add qemu_get_counted_string to read a string prefixed by a count byte

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" and use it in loadvm_state and ram_load. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 5 + include/migration/qemu-file.h | 3 +++ migration/qemu-file.c | 16 savevm.c | 11 ++

[Qemu-devel] [PATCH v6 01/47] Start documenting how postcopy works.

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert --- docs/migration.txt | 167 + 1 file changed, 167 insertions(+) diff --git a/docs/migration.txt b/docs/migration.txt index 0492a45..f975c75 100644 --- a/docs/migration.txt

[Qemu-devel] [PATCH v6 06/47] Provide runtime Target page information

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The migration code generally is built target-independent, however there are a few places where knowing the target page size would avoid artificially moving stuff into arch_init. Provide 'qemu_target_page_bits()' that returns TARGET_PAGE_BITS to other bits of code s

[Qemu-devel] [PATCH v6 03/47] qemu_ram_foreach_block: pass up error value, and down the ramblock name

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" check the return value of the function it calls and error if it's non-0 Fixup qemu_rdma_init_one_block that is the only current caller, and rdma_add_block the only function it calls using it. Pass the name of the ramblock to the function; helps in debugging. Sig

[Qemu-devel] [PATCH v6 13/47] Migration commands

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Create QEMU_VM_COMMAND section type for sending commands from source to destination. These commands are not intended to convey guest state but to control the migration process. For use in postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/mig

[Qemu-devel] [PATCH v6 05/47] Create MigrationIncomingState

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" There are currently lots of pieces of incoming migration state scattered around, and postcopy is adding more, and it seems better to try and keep it together. allocate MIS in process_incoming_migration_co Signed-off-by: Dr. David Alan Gilbert --- include/migrati

[Qemu-devel] [PATCH v6 11/47] Return path: Open a return path on QEMUFile for sockets

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy needs a method to send messages from the destination back to the source, this is the 'return path'. Wire it up for 'socket' QEMUFile's using a dup'd fd. Signed-off-by: Dr. David Alan Gilbert --- include/migration/qemu-file.h | 7 + migration/qemu-f

[Qemu-devel] [PATCH v6 09/47] Add wrapper for setting blocking status on a QEMUFile

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add a wrapper to change the blocking status on a QEMUFile rather than having to use qemu_set_block(qemu_get_fd(f)); it seems best to avoid exposing the fd since not all QEMUFile's really have one. With this wrapper we could move the implementation down to be differ

[Qemu-devel] [PATCH v6 07/47] Move copy out of qemu_peek_buffer

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" qemu_peek_buffer currently copies the data it reads into a buffer, however the next patch wants access to the buffer without the copy, hence rework to remove the copy to the layer above. Signed-off-by: Dr. David Alan Gilbert --- include/migration/qemu-file.h | 2

[Qemu-devel] [PATCH v6 08/47] Add qemu_get_buffer_less_copy to avoid copies some of the time

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" qemu_get_buffer always copies the data it reads to a users buffer, however in many cases the file buffer inside qemu_file could be given back to the caller, avoiding the copy. This isn't always possible depending on the size and alignment of the data. Thus 'qemu_g

[Qemu-devel] [PATCH v6 14/47] Return path: Control commands

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add two src->dest commands: * OPEN_RETURN_PATH - To request that the destination open the return path * PING - Request an acknowledge from the destination Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- include/migration/migration.h |

[Qemu-devel] [PATCH v6 15/47] Return path: Send responses from destination to source

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add migrate_send_rp_message to send a message from destination to source along the return path. (It uses a mutex to let it be called from multiple threads) Add migrate_send_rp_shut to send a 'shut' message to indicate the destination is finished with the RP. Ad

[Qemu-devel] [PATCH v6 10/47] Rename save_live_complete to save_live_complete_precopy

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In postcopy we're going to need to perform the complete phase for postcopiable devices at a different point, start out by renaming all of the 'complete's to make the difference obvious. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 2 +-

[Qemu-devel] [PATCH v6 16/47] Return path: Source handling of return path

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Open a return path, and handle messages that are received upon it. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 8 ++ migration/migration.c | 177 +- trace-events | 1

[Qemu-devel] [PATCH v6 19/47] Rework loadvm path for subloops

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions. Split the core of qemu_loadvm_state out so we can use it for both. Allow the inner loadvm loop to qui

[Qemu-devel] [PATCH v6 20/47] Add migration-capability boolean for postcopy-ram.

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The 'postcopy ram' capability allows postcopy migration of RAM; note that the migration starts off in precopy mode until postcopy mode is triggered (see the migrate_start_postcopy patch later in the series). Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Eric

[Qemu-devel] [PATCH v6 12/47] Return path: socket_writev_buffer: Block even on non-blocking fd's

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The destination sets the fd to non-blocking on incoming migrations; this also affects the return path from the destination, and thus we need to make sure we can safely write to the return path. Signed-off-by: Dr. David Alan Gilbert --- migration/qemu-file-unix.c

[Qemu-devel] [PATCH v6 27/47] MIGRATION_STATUS_POSTCOPY_ACTIVE: Add new migration state

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" 'MIGRATION_STATUS_POSTCOPY_ACTIVE' is entered after migrate_start_postcopy 'migration_postcopy_phase' is provided for other sections to know if they're in postcopy. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- include/migration/migration.

[Qemu-devel] [PATCH v6 23/47] migrate_init: Call from savevm

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Suspend to file is very much like a migrate, and it makes life easier if we have the Migration state available, so initialise it in the savevm.c code for suspending. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- include/migration/migration.

[Qemu-devel] [PATCH v6 17/47] ram_debug_dump_bitmap: Dump a migration bitmap as text

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Misses out lines that are all the expected value so the output can be quite compact depending on the circumstance. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 40 +++- include/migration/migration.h

[Qemu-devel] [PATCH v6 22/47] MIG_CMD_PACKAGED: Send a packaged chunk of migration stream

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" MIG_CMD_PACKAGED is a migration command that wraps a chunk of migration stream inside a package whose length can be determined purely by reading its header. The destination guarantees that the whole MIG_CMD_PACKAGED is read off the stream prior to parsing the conte

[Qemu-devel] [PATCH v6 32/47] Postcopy: Postcopy startup in migration thread

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rework the migration thread to setup and start postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 3 + migration/migration.c | 163 -- trace-events | 4 ++ 3 fil

[Qemu-devel] [PATCH v6 26/47] migrate_start_postcopy: Command to trigger transition to postcopy

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Once postcopy is enabled (with migrate_set_capability), the migration will still start on precopy mode. To cause a transition into postcopy the: migrate_start_postcopy command must be issued. Postcopy will start sometime after this (when it's next checked in t

[Qemu-devel] [PATCH v6 18/47] Move loadvm_handlers into MigrationIncomingState

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" In postcopy we need the loadvm_handlers to be used in a couple of different instances of the loadvm loop/routine, and thus it can't be local any more. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- include/migration/migration.h | 5 + i

[Qemu-devel] [PATCH v6 24/47] Modify save_live_pending for postcopy

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Modify save_live_pending to return separate postcopiable and non-postcopiable counts. Signed-off-by: Dr. David Alan Gilbert --- arch_init.c | 8 ++-- include/migration/vmstate.h | 5 +++-- include/sysemu/sysemu.h | 4 +++- migration/blo

[Qemu-devel] [PATCH v6 30/47] postcopy: Incoming initialisation

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- arch_init.c | 11 include/migration/migration.h| 3 + include/migration/postcopy-ram.h | 12 migration/postcopy-ram.c | 116

[Qemu-devel] [PATCH v6 28/47] Add qemu_savevm_state_complete_postcopy

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add qemu_savevm_state_complete_postcopy to complement qemu_savevm_state_complete_precopy together with a new save_live_complete_postcopy method on devices. The save_live_complete_precopy method is called on all devices during a precopy migration, and all non-postco

[Qemu-devel] [PATCH v6 21/47] Add wrappers and handlers for sending/receiving the postcopy-ram migration messages.

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The state of the postcopy process is managed via a series of messages; * Add wrappers and handlers for sending/receiving these messages * Add state variable that track the current state of postcopy Signed-off-by: Dr. David Alan Gilbert --- include/migration

[Qemu-devel] [PATCH v6 25/47] postcopy: OS support test

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Provide a check to see if the OS we're running on has all the bits needed for postcopy. Creates postcopy-ram.c which will get most of the other helpers we need. Signed-off-by: Dr. David Alan Gilbert --- include/migration/postcopy-ram.h | 19 + migration/Mak

[Qemu-devel] [PATCH v6 36/47] Page request: Consume pages off the post-copy queue

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When transmitting RAM pages, consume pages that have been queued by MIG_RPCOMM_REQPAGE commands and send them ahead of normal page scanning. Note: a) After a queued page the linear walk carries on from after the unqueued page; there is a reasonable chance that th

[Qemu-devel] [PATCH v6 33/47] Postcopy end in migration_thread

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The end of migration in postcopy is a bit different since some of the things normally done at the end of migration have already been done on the transition to postcopy. The end of migration code is getting a bit complciated now, so move out into its own function.

[Qemu-devel] [PATCH v6 39/47] qemu_ram_block_from_host

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Postcopy sends RAMBlock names and offsets over the wire (since it can't rely on the order of ramaddr being the same), and it starts out with HVA fault addresses from the kernel. qemu_ram_block_from_host translates a HVA into a RAMBlock, an offset in the RAMBlock an

[Qemu-devel] [PATCH v6 29/47] Postcopy: Maintain sentmap and calculate discard

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Where postcopy is preceeded by a period of precopy, the destination will have received pages that may have been dirtied on the source after the page was sent. The destination must throw these pages away before starting it's CPUs. Maintain a 'sentmap' of pages that

[Qemu-devel] [PATCH v6 31/47] postcopy: ram_enable_notify to switch on userfault

2015-04-14 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Mark the area of RAM as 'userfault' Start up a fault-thread to handle any userfaults we might receive from it (to be filled in later) Signed-off-by: Dr. David Alan Gilbert Reviewed-by: David Gibson --- include/migration/migration.h| 3 ++ include/migration/

  1   2   >