[Qemu-devel] [PATCH v6 1/3] Revert block: Fix unaligned zero write

2015-05-12 Thread Fam Zheng
This reverts commit fc3959e4669a1c2149b91ccb05101cfc7ae1fc05. The core write code already handles the case, so remove this duplication. Because commit 61007b316 moved the touched code from block.c to block/io.c, the change is manually reverted. Signed-off-by: Fam Zheng f...@redhat.com

[Qemu-devel] [PATCH v6 0/3] block: Fix unaligned bdrv_aio_write_zeroes

2015-05-12 Thread Fam Zheng
An unaligned zero write causes NULL deferencing in bdrv_co_do_pwritev. That path is reachable from bdrv_co_write_zeroes and bdrv_aio_write_zeroes. You can easily trigger through the former with qemu-io, as the test case added by 61815d6e0aa. For bdrv_aio_write_zeroes, in common cases there's

[Qemu-devel] [PATCH v6 2/3] block: Fix NULL deference for unaligned write if qiov is NULL

2015-05-12 Thread Fam Zheng
For zero write, callers pass in NULL qiov (qemu-io write -z or scsi-disk write same). Commit fc3959e466 fixed bdrv_co_write_zeroes which is the common case for this bug, but it still exists in bdrv_aio_write_zeroes. A simpler fix would be in bdrv_co_do_pwritev which is the NULL dereference point

[Qemu-devel] [PATCH v6 3/3] qemu-iotests: Test unaligned sub-block zero write

2015-05-12 Thread Fam Zheng
Test zero write in byte range 512~1024 for 4k alignment. Signed-off-by: Fam Zheng f...@redhat.com Reviewed-by: Stefan Hajnoczi stefa...@redhat.com --- tests/qemu-iotests/033 | 13 + tests/qemu-iotests/033.out | 30 ++ 2 files changed, 43 insertions(+)

Re: [Qemu-devel] [PATCH v2 2/6] block: Fix dirty bitmap in bdrv_co_discard

2015-05-12 Thread Fam Zheng
On Mon, 05/11 15:22, John Snow wrote: On 05/06/2015 12:52 AM, Fam Zheng wrote: Unsetting dirty globally with discard is not very correct. The discard may zero out sectors (depending on can_write_zeroes_with_unmap), we should replicate this change to destinition side to make sure that

[Qemu-devel] [PATCHv3 0/2] parallel: Allow to disable CONFIG_PARALLEL

2015-05-12 Thread mrezanin
From: Miroslav Rezanina mreza...@redhat.com There's few uncoditional calls to functions in hw/char/parallel.c so disabling CONFIG_PARALLEL can cause build failure. This series allow building with CONFIG_PARALLEL disabled. In addition, it changes behavior so the run of qemu -parallel will abort in

[Qemu-devel] [PATCHv3 1/2] Move parallel_hds_isa_init to hw/isa/isa-bus.c

2015-05-12 Thread mrezanin
From: Miroslav Rezanina mreza...@redhat.com Disabling CONFIG_PARALLEL cause removing parallel_hds_isa_init defined in parallel.c. This function is called during initialization of some boards so disabling CONFIG_PARALLEL cause build failure. This patch moves parallel_hds_isa_init to

[Qemu-devel] [PATCHv3 2/2] stubs: Provide parallel_mm_init stub version

2015-05-12 Thread mrezanin
From: Miroslav Rezanina mreza...@redhat.com mips build fail with link error in case PARALLEL_CONFIG is disabled as hw/mips/mips_jazz.c calls parallel_mm_init. Due to dependecies to content of parallel.c we can't simply move it to hw/isa/isa-devices.c. This patch adds stubs/parallel.c file that

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-12 Thread Michael Tokarev
12.05.2015 04:05, Peter Crosthwaite wrote: On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev m...@tls.msk.ru wrote: ... Ok, I can reproduce this, winXP BSODs on boot in tcg mode. Git bisect points to this: commit 23820dbfc79d1c9dce090b4c555994f2bb6a69b3 Author: Peter Crosthwaite

Re: [Qemu-devel] [PULL 00/28] pc, virtio enhancements

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 13:46, Michael S. Tsirkin m...@redhat.com wrote: The following changes since commit 0d81cdddaa40a1988b24657aeac19959cfad0fde: Merge remote-tracking branch 'remotes/qmp-unstable/tags/for-upstream' into staging (2015-04-27 17:28:41 +0100) are available in the git

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Shannon Zhao
On 2015/5/12 15:52, Peter Maydell wrote: On 12 May 2015 at 03:25, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- hw/s390x/s390-virtio-bus.c | 15

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
On 11 May 2015 at 14:40, Peter Maydell peter.mayd...@linaro.org wrote: This is mostly the GIC TZ changes, with a couple of other minor bugfixes. -- PMM The following changes since commit b951cda21d6b232f138ccf008e12bce8ddc95465: Merge remote-tracking branch

[Qemu-devel] [PATCH v3 2/3] virtio-mmio: introduce set_guest_notifiers

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan yingshiuan@gmail.com Same as host notifier of virtio-mmio, most of codes came from virtio-pci. The kvm-arm does not yet support irqfd, need to fix the hard-coded part after kvm-arm gets irqfd support. Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com

[Qemu-devel] [PATCH v3 3/3] virtio-mmio: start ioeventfd when status gets DRIVER_OK

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Pavel Fedin p.fe...@samsung.com --- hw/virtio/virtio-mmio.c | 47 +++ 1 file changed, 47 insertions(+) diff --git

Re: [Qemu-devel] [PATCH v2] Fixes key mapping so all keys work

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 05:11, Programmingkid programmingk...@gmail.com wrote: On May 10, 2015, at 2:45 PM, Peter Maydell wrote: This is two conceptually separate fixes: (1) better handle key input to the ADB keyboard (2) output the right keycodes on the OSX cocoa UI which should be in separate

Re: [Qemu-devel] [PATCH 18/31] q35: fix ESMRAMC default

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: From: Gerd Hoffmann kra...@redhat.com [ more verbose commit message for squashing in ] The cache bits in ESMRAMC are hardcoded to 1 (=disabled) according to the q35 mch specs. Add and use a define with this default. While being at it also

Re: [Qemu-devel] [PATCH 23/31] ich9: implement SMI_LOCK

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: From: Gerd Hoffmann kra...@redhat.com [ more verbose commit message for squashing in ] Add write mask for the smi enable register, so we can disable write access to certain bits. Open all bits on reset. Disable write access to GBL_SMI_EN

Re: [Qemu-devel] [PATCH 0/6] ui/cocoa: Fix OSX 10.10 warnings (and drop 10.4 support)

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 00:45, Programmingkid programmingk...@gmail.com wrote: On May 10, 2015, at 6:19 PM, Peter Maydell wrote: I've chosen to implement some of them by simply dropping the backward-compatibility support for OSX 10.4. This is basically a pragmatic decision since I don't think we can

Re: [Qemu-devel] [PATCH 19/31] q35: add config space wmask for SMRAM and ESMRAMC

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: From: Gerd Hoffmann kra...@redhat.com [ more verbose commit message for squashing in ] Not all bits in SMRAM and ESMRAMC can be changed by the guest. Add wmask defines accordingly and set them in mch_reset(). Signed-off-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-05-12 Thread Shannon Zhao
On 2015/5/12 14:59, Peter Maydell wrote: On 12 May 2015 at 03:25, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- diff --git a/hw/audio/intel-hda.c

Re: [Qemu-devel] [PATCH 20/31] q35: implement SMRAM.D_LCK

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 15:49 +0200, Paolo Bonzini wrote: From: Gerd Hoffmann kra...@redhat.com [ more verbose commit message for squashing in ] Once the SMRAM.D_LCK bit has been set by the guest several bits in SMRAM and ESMRAMC become readonly until the next machine reset. Implement this by

Re: [Qemu-devel] [PATCH 6/6] Add comma after DEFINE_PROP_END_OF_LIST()

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 03:25, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 433463e..d2b3f37

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-12 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 1:18 PM, Richard Henderson r...@twiddle.net wrote: On 05/11/2015 03:24 AM, Paolo Bonzini wrote: On 11/05/2015 12:18, Andreas Färber wrote: +int (*cpu_mmu_index)(CPUState *cpu); +void (*cpu_get_tb_cpu_state)(CPUState *cpu, +

[Qemu-devel] [PATCH v3 1/3] virtio-mmio: introduce set_host_notifier()

2015-05-12 Thread Pavel Fedin
From: Ying-Shiuan Pan yingshiuan@gmail.com set_host_notifier() is introduced into virtio-mmio now. Most of codes came from virtio-pci. Signed-off-by: Ying-Shiuan Pan yingshiuan@gmail.com Signed-off-by: Pavel Fedin p.fe...@samsung.com --- hw/virtio/virtio-mmio.c | 73

Re: [Qemu-devel] [PULL 3/6] console-gl: add opengl rendering helper functions

2015-05-12 Thread Gerd Hoffmann
On Mo, 2015-05-11 at 22:32 +0200, Alexander Graf wrote: But I see the same error on openSUSE 12.3 x86_64 now: Ah, cool, I have an iso for that laying around. /me goes install. thanks, Gerd

[Qemu-devel] [PATCH v3 0/3] virtio-mmio: introduce eventfd support

2015-05-12 Thread Pavel Fedin
This patch set introduces eventfd support for virio-mmio. It was originally published by Ying-Shiuan Pan but never got it to upstream: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg00715.html I have updated and successfully tested it with vhost-net. I confirm that this solution

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Cornelia Huck
On Tue, 12 May 2015 10:25:16 +0800 shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- hw/s390x/s390-virtio-bus.c | 15 --- 1 file changed, 15

Re: [Qemu-devel] [RFC PATCH v5 00/14] data-driven device registers

2015-05-12 Thread Peter Crosthwaite
Ping! On Mon, Apr 27, 2015 at 2:57 PM, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: Hi All. This is a new scheme I've come up with handling device registers in a data driven way. My motivation for this is to factor out a lot of the access checking that seems to be replicated in every

Re: [Qemu-devel] [RFC PATCH 02/34] tcg+qom: QOMify core CPU defintions

2015-05-12 Thread Peter Crosthwaite
On Mon, May 11, 2015 at 3:39 AM, Paolo Bonzini pbonz...@redhat.com wrote: On 11/05/2015 12:36, Andreas Färber wrote: Right. My point was that these functions are not polymorphic. Each call to these should know exactly which function to call. cputlb.c, cpu-exec.c and parts of

Re: [Qemu-devel] [PATCH 1/6] hw/s390x/s390-virtio-bus: Remove meaningless blank Property

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 03:25, shannon.z...@linaro.org wrote: From: Shannon Zhao shannon.z...@linaro.org Signed-off-by: Shannon Zhao zhaoshengl...@huawei.com Signed-off-by: Shannon Zhao shannon.z...@linaro.org --- hw/s390x/s390-virtio-bus.c | 15 --- 1 file changed, 15 deletions(-)

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Crosthwaite
On Tue, May 12, 2015 at 1:01 AM, Peter Maydell peter.mayd...@linaro.org wrote: On 11 May 2015 at 14:40, Peter Maydell peter.mayd...@linaro.org wrote: This is mostly the GIC TZ changes, with a couple of other minor bugfixes. -- PMM The following changes since commit

Re: [Qemu-devel] [PULL 00/19] target-arm queue

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 09:10, Peter Crosthwaite peter.crosthwa...@xilinx.com wrote: On Tue, May 12, 2015 at 1:01 AM, Peter Maydell peter.mayd...@linaro.org wrote: I could have sworn I'd tested that. Will fix respin... Feel like grabbing the new Zynq series (v9) with it? :) Maybe. I was going

Re: [Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-12 Thread Michael S. Tsirkin
On Tue, May 12, 2015 at 06:25:32PM +0200, Cornelia Huck wrote: On Tue, 12 May 2015 17:15:53 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 12, 2015 at 03:25:30PM +0200, Cornelia Huck wrote: On Wed, 06 May 2015 14:08:02 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote:

Re: [Qemu-devel] [PATCH v3 3/7] qom: create objects in two phases

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 04:40:51PM +0200, Paolo Bonzini wrote: On 08/05/2015 16:37, Andreas Färber wrote: Hi, Can we *please* find a better subject for this? To me, creating QOM objects in two phases is about instance_init vs. realize, and thus I was pretty upset that Paolo dared

Re: [Qemu-devel] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib

2015-05-12 Thread Eric Blake
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu-img.c file has a read_password() method impl that is used to prompt for passwords on the console, with impls for POSIX and Windows. This will be needed by qemu-io.c too, so move it into the QEMU osdep/oslib files where it can be shared

[Qemu-devel] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread Daniel P. Berrange
Add a simple test case for qemu-iotests that covers read/write with encrypted qcow2 files. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++

[Qemu-devel] [PATCH 0/5] Misc fixes and testing of qcow[2] encryption

2015-05-12 Thread Daniel P. Berrange
I realize that qcow[2] encryption is a feature we have deprecated and will remove support for running it with the QEMU system emulators in this cycle. We do still need to make sure it continues to work for the sake of letting people run qemu-img convert to retrieve their data though. Some of the

[Qemu-devel] [PATCH 4/5] qemu-io: prompt for encryption keys when required

2015-05-12 Thread Daniel P. Berrange
The qemu-io tool does not check if the image is encrypted so historically would silently corrupt the sectors by writing plain text data into them instead of cipher text. The earlier commit turns this mistake into a fatal abort, so check for encryption and prompt for key when required. This

[Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key

2015-05-12 Thread Daniel P. Berrange
When a qcow[2] file is opened, if the header reports an encryption method, this is used to set the 'crypt_method_header' field on the BDRVQcow[2]State struct, and the 'encrypted' flag in the BDRVState struct. When doing I/O operations, the 'crypt_method' field on the BDRVQcow[2]State struct is

Re: [Qemu-devel] [PULL 00/16] KVM, QOM, NBD, build fixes for 2015-05-08

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 02:29:01PM +0200, Andreas Färber wrote: Am 08.05.2015 um 14:07 schrieb Paolo Bonzini: The following changes since commit 498147529d1f8e902e6528a0115143b53475791e: Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20150430' into staging (2015-04-30

[Qemu-devel] [PATCH v2 11/17] target-alpha: Fix integer overflow checking insns

2015-05-12 Thread Richard Henderson
We need to write the result to the destination register before raising any exception. Thus inline the code for each insn, and check for any exception after we're done. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.h |

[Qemu-devel] [PATCH v2 10/17] target-alpha: Fix cvttq vs inf

2015-05-12 Thread Richard Henderson
We should raise INV for infinities as well, not OVR+INE. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-alpha/fpu_helper.c

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-12 Thread Paolo Bonzini
On 12/05/2015 17:32, Peter Maydell wrote: In order for -icount to work, it's important for the target translate.c code to correctly bracket any generated code which can do I/O with gen_io_start()/gen_io_end() calls. But does anybody know exactly what the criteria are here for this? It would

[Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input

2015-05-12 Thread Daniel P. Berrange
The qemu_read_password() method looks for \r to terminate the reading of the a password. This is what will be seen when reading the password from a TTY. When scripting though, it is useful to be able to send the password via a pipe, in which case we must look for \n to terminate password input.

[Qemu-devel] [PATCH 2/5] util: move read_password method out of qemu-img into osdep/oslib

2015-05-12 Thread Daniel P. Berrange
The qemu-img.c file has a read_password() method impl that is used to prompt for passwords on the console, with impls for POSIX and Windows. This will be needed by qemu-io.c too, so move it into the QEMU osdep/oslib files where it can be shared without code duplication Signed-off-by: Daniel P.

[Qemu-devel] [PATCH v2 16/17] target-alpha: Raise IOV from CVTQL

2015-05-12 Thread Richard Henderson
Even if an exception isn't taken, the status flags need updating and the result should be written to the destination. Move the body of cvtql out of line, since we now always need a call. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net ---

[Qemu-devel] [PATCH v2 13/17] target-alpha: Disallow literal operand to 1C.30 to 1C.37

2015-05-12 Thread Richard Henderson
Before 64f45e49 we used to have literal checks for 4 of these 8 opcodes. Confirmed that real hardware doesn't allow them. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 19 +-- 1 file changed, 17

[Qemu-devel] [PATCH v2 15/17] target-alpha: Suppress underflow from CVTTQ if DNZ

2015-05-12 Thread Richard Henderson
I.e. respect flush_inputs_to_zero. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-alpha/fpu_helper.c b/target-alpha/fpu_helper.c index

Re: [Qemu-devel] [PATCH v3 4/7] qom: add object_new_propv / object_new_proplist constructors

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 07:10:49PM +0200, Andreas Färber wrote: Hi Daniel/Paolo, Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange: It is reasonably common to want to create an object, set a number of properties, register it in the hierarchy and then mark it as complete (if a user

[Qemu-devel] [PATCH v2 00/17] target-alpha fpu improvments

2015-05-12 Thread Richard Henderson
This is v2 of the work that Al Viro helped with nearly a year ago. At the time, I obsconded with an unused bit in the softfloat exception flags. Which was a bit of a wart, and rightly pointed out as such by someone at the time. After 11 months on the shelf, I've finally found enough time to work

[Qemu-devel] [PATCH v2 04/17] target-alpha: Set PC correctly for floating-point exceptions

2015-05-12 Thread Richard Henderson
PC should be one past the faulting insn. Add better commentary for the machine-check exception path. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/helper.c | 2 ++ target-alpha/mem_helper.c | 9 - 2 files changed, 10

[Qemu-devel] [PATCH v2 01/17] target-alpha: Move VAX helpers to a new file

2015-05-12 Thread Richard Henderson
Keep the IEEE and VAX floating point emulation separate. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/Makefile.objs | 2 +- target-alpha/fpu_helper.c | 328 - target-alpha/vax_helper.c | 353

[Qemu-devel] [PATCH v2 09/17] target-alpha: Fix cvttq vs large integers

2015-05-12 Thread Richard Henderson
The range +- 2**63 - 2**64 was returning the wrong truncated result. We also incorrectly signaled overflow for -2**63. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 10 +- 1 file changed, 5 insertions(+), 5

Re: [Qemu-devel] Bug report - Windows XP guest failure

2015-05-12 Thread John Snow
On 05/12/2015 03:22 AM, Michael Tokarev wrote: 12.05.2015 04:05, Peter Crosthwaite wrote: On Thu, May 7, 2015 at 2:34 AM, Michael Tokarev m...@tls.msk.ru wrote: ... Ok, I can reproduce this, winXP BSODs on boot in tcg mode. Git bisect points to this: commit

Re: [Qemu-devel] [PATCH RFC 1/7] virtio: relax feature check

2015-05-12 Thread Cornelia Huck
On Tue, 12 May 2015 17:30:21 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 12, 2015 at 04:46:11PM +0200, Cornelia Huck wrote: On Tue, 12 May 2015 15:44:46 +0200 Cornelia Huck cornelia.h...@de.ibm.com wrote: On Tue, 12 May 2015 15:34:47 +0200 Michael S. Tsirkin

Re: [Qemu-devel] [PATCH v2] qmp: Add qom_path field to query-cpus command

2015-05-12 Thread Markus Armbruster
Eduardo Habkost ehabk...@redhat.com writes: On Tue, May 12, 2015 at 05:38:37PM +0200, Markus Armbruster wrote: [...] @@ -699,8 +701,9 @@ #data is sent to the client, the guest may no longer be halted. ## { 'struct': 'CpuInfo', - 'data': {'CPU': 'int', 'current': 'bool',

Re: [Qemu-devel] [PATCH v3 6/7] qom: add a object_property_add_enum helper method

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 07:45:10PM +0200, Andreas Färber wrote: Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange: Looks good in general. Some minor nits below, and one limitation possibly worth mentioning in the second paragraph of the commit message: It assumes a 1:1 mapping. I do guess

[Qemu-devel] [PATCH v2 02/17] target-alpha: Rename floating-point subroutines

2015-05-12 Thread Richard Henderson
... to match the instructions, which have no leading f. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 2 +- target-alpha/helper.h | 2 +- target-alpha/translate.c | 68 +++ 3 files changed, 36 insertions(+),

[Qemu-devel] [PATCH v2 14/17] target-alpha: Raise EXC_M_INV properly for fp inputs

2015-05-12 Thread Richard Henderson
Ignore DNZ if software completion isn't used. Raise INV for denormals in system mode so the OS completion handler sees them. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 32 ++--

[Qemu-devel] [PATCH v2 03/17] target-alpha: Forget installed round mode after MT_FPCR

2015-05-12 Thread Richard Henderson
When we use QUAL_RM_D, we copy fpcr_dyn_round to float_status. When we install a new FPCR value, we update fpcr_dyn_round. Reset the status of the cache so that we re-copy for the next fp insn that requires dynamic rounding. Signed-off-by: Richard Henderson r...@twiddle.net ---

Re: [Qemu-devel] [PATCH RFC 4/7] vhost: set vring endianness for legacy virtio

2015-05-12 Thread Cornelia Huck
On Tue, 12 May 2015 17:15:53 +0200 Michael S. Tsirkin m...@redhat.com wrote: On Tue, May 12, 2015 at 03:25:30PM +0200, Cornelia Huck wrote: On Wed, 06 May 2015 14:08:02 +0200 Greg Kurz gk...@linux.vnet.ibm.com wrote: Legacy virtio is native endian: if the guest and host endianness

Re: [Qemu-devel] [PATCH v3 7/7] qom: don't pass string table to object_get_enum method

2015-05-12 Thread Daniel P. Berrange
On Fri, May 08, 2015 at 07:54:48PM +0200, Andreas Färber wrote: Am 01.05.2015 um 12:30 schrieb Daniel P. Berrange: Now that properties can be explicitly registered as an enum type, there is no need to pass the string table to the object_get_enum method. The object property registration

[Qemu-devel] [PATCH v2 06/17] target-alpha: Set fpcr_exc_status even for disabled exceptions

2015-05-12 Thread Richard Henderson
The qualifiers can suppress the raising of exceptions, but real hardware still records that the exceptions occurred. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 35 +--

[Qemu-devel] [PATCH v2 12/17] target-alpha: Implement WH64EN

2015-05-12 Thread Richard Henderson
Backward compatible cache insn introduced for EV7. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/translate.c | 4 1 file changed, 4 insertions(+) diff --git a/target-alpha/translate.c b/target-alpha/translate.c index

[Qemu-devel] [PATCH v2 05/17] target-alpha: Tidy FPCR representation

2015-05-12 Thread Richard Henderson
Store the fpcr as the hardware represents it. Convert the softfpu representation of exceptions into the fpcr representation. Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/cpu.h| 95 + target-alpha/fpu_helper.c | 130

[Qemu-devel] [PATCH v2 08/17] target-alpha: Raise IOV from CVTTQ

2015-05-12 Thread Richard Henderson
Floating-point overflow is a different bit from integer overflow. Reported-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Richard Henderson r...@twiddle.net --- target-alpha/fpu_helper.c | 25 + target-alpha/helper.h | 1 - target-alpha/translate.c | 17

Re: [Qemu-devel] [PATCH 1/5] qcow2/qcow: protect against uninitialized encryption key

2015-05-12 Thread Eric Blake
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: When a qcow[2] file is opened, if the header reports an encryption method, this is used to set the 'crypt_method_header' field on the BDRVQcow[2]State struct, and the 'encrypted' flag in the BDRVState struct. When doing I/O operations, the

[Qemu-devel] [PULL v2 13/14] libqos/ahci: Swap memread/write with bufread/write

2015-05-12 Thread John Snow
Where it makes sense, use the new faster primitives. For generally small reads/writes such as for the PRDT and FIS packets, stick with the more wasteful but easier to debug memread/memwrite. For ahci-test (before migration tests): With this patch: real0m3.675s user0m2.582s sys

[Qemu-devel] [PULL v2 10/14] qtest: allow arbitrarily long sends

2015-05-12 Thread John Snow
qtest currently has a static buffer of size 1024 that if we overflow, ignores the additional data silently which leads to hangs or stream failures. Use glib's string facilities to allow arbitrarily long data, but split this off into a new function, qtest_sendf. Static data can still be sent

[Qemu-devel] [PULL v2 03/14] libqos: Add migration helpers

2015-05-12 Thread John Snow
libqos.c: -set_context for addressing which commands go where -migrate performs the actual migration malloc.c: - Structure of the allocator is adjusted slightly with a second-tier malloc to make swapping around the allocators easy when we migrate the lists from the source

Re: [Qemu-devel] [PULL 00/14] Ide patches

2015-05-12 Thread John Snow
On 05/12/2015 11:25 AM, Peter Maydell wrote: On 12 May 2015 at 16:22, John Snow js...@redhat.com wrote: On 05/12/2015 06:44 AM, Peter Maydell wrote: Doesn't build on 32-bit: /root/qemu/qtest.c: In function ‘qtest_process_command’: /root/qemu/qtest.c:519:28: error: format ‘%zu’ expects

[Qemu-devel] [PATCH v6 2/7] vmport_rpc: Add the object vmport_rpc

2015-05-12 Thread Don Slutz
This is the 1st part of Add limited support of VMware's hyper-call rpc. This patch uses existing infrastructure used by vmmouse.c (provided by vmport.c) to handle the VMware backdoor command 30. One of the better on-line references is: https://sites.google.com/site/chitchatvmback/backdoor More

[Qemu-devel] [PATCH v6 0/7] Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
Changes v5 to v6: Rebase to master Eric Blake Returning a non-dictionary is not extensible. Added new type VmportGuestInfoValue. s/VmportGuestInfo/VmportGuestInfoKey/ s/type/struct/ Issues with examples Fixed. Changes v4 to v5: Paolo Bonzini What is

[Qemu-devel] [PATCH v6 1/7] vmport.c: Fix vmport_cmd_ram_size

2015-05-12 Thread Don Slutz
Based on https://sites.google.com/site/chitchatvmback/backdoor and testing on ESXi, this should be in MB not bytes. Signed-off-by: Don Slutz dsl...@verizon.com --- hw/misc/vmport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/vmport.c b/hw/misc/vmport.c index

Re: [Qemu-devel] [Qemu-block] [PATCH 05/34] block: Use macro for cache option names

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:37PM +0200, Kevin Wolf wrote: Signed-off-by: Kevin Wolf kw...@redhat.com --- blockdev.c| 24 include/block/block.h | 8 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/blockdev.c b/blockdev.c

[Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-12 Thread John Snow
Bitmaps can be in a handful of different states with potentially more to come as we tool around with migration and persistence patches. Instead of having a bunch of boolean fields, it was suggested that we just have an enum status field that will help expose the reason to management APIs why

Re: [Qemu-devel] [Qemu-block] [PATCH 04/34] vmdk: Use bdrv_open_image()

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:36PM +0200, Kevin Wolf wrote: Besides standardising on a single interface for opening child nodes, this patch allows the user to specify options to individual extent nodes. Overriding file names isn't possible with this yet, so it's of limited usefulness, but

Re: [Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Eric Blake
On 05/12/2015 01:03 PM, Don Slutz wrote: This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz dsl...@verizon.com --- +/*

Re: [Qemu-devel] [PULL v2 00/14] Ide patches

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 19:46, John Snow js...@redhat.com wrote: The following changes since commit 968bb75c348a401b85e08d5eb1887a3e6c3185f5: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150512' into staging (2015-05-12 12:11:32 +0100) are available in the git

Re: [Qemu-devel] [PATCH] qapi: add dirty bitmap status

2015-05-12 Thread Eric Blake
On 05/12/2015 01:53 PM, John Snow wrote: Bitmaps can be in a handful of different states with potentially more to come as we tool around with migration and persistence patches. Instead of having a bunch of boolean fields, it was suggested that we just have an enum status field that will help

[Qemu-devel] [PULL v2 14/14] qtest: pre-buffer hex nibs

2015-05-12 Thread John Snow
Instead of converting each byte one-at-a-time and then sending each byte over the wire, use sprintf() to pre-compute all of the hex nibs into a single buffer, then send the entire buffer all at once. This gives a moderate speed boost to memread() and memwrite() functions. Signed-off-by: John

[Qemu-devel] [PATCH v6 3/7] vmport_rpc: Add limited support of VMware's hyper-call rpc

2015-05-12 Thread Don Slutz
The support included is enough to allow VMware tools to install in a guest and provide guestinfo support. guestinfo support is provided by what is known as VMware RPC support. If the guest is running VMware tools, then the build version of the tools is also available via the property

[Qemu-devel] [PATCH v6 4/7] vmport_rpc: Add QMP access to vmport_rpc object.

2015-05-12 Thread Don Slutz
This adds one new inject command: inject-vmport-action And three guest info commands: vmport-guestinfo-set vmport-guestinfo-get query-vmport-guestinfo More details in qmp-commands.hx Signed-off-by: Don Slutz dsl...@verizon.com --- hw/misc/vmport_rpc.c | 268

Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread John Snow
On 05/12/2015 02:35 PM, Eric Blake wrote: On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: Add a simple test case for qemu-iotests that covers read/write with encrypted qcow2 files. Signed-off-by: Daniel P. Berrange berra...@redhat.com --- tests/qemu-iotests/131 | 69

[Qemu-devel] [PATCH v6 7/7] MAINTAINERS: add VMware port

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz dsl...@verizon.com --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b3552b2..6945d30d 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -766,6 +766,13 @@ M: Jiri Pirko j...@resnulli.us S: Maintained F: hw/net/rocker/

Re: [Qemu-devel] when does a target frontend need to use gen_io_start()/gen_io_end() ?

2015-05-12 Thread Peter Maydell
On 12 May 2015 at 19:17, Paolo Bonzini pbonz...@redhat.com wrote: On 12/05/2015 17:32, Peter Maydell wrote: In order for -icount to work, it's important for the target translate.c code to correctly bracket any generated code which can do I/O with gen_io_start()/gen_io_end() calls. But does

Re: [Qemu-devel] [PATCH 3/5] util: allow \n to terminate password input

2015-05-12 Thread Eric Blake
On 05/12/2015 10:09 AM, Daniel P. Berrange wrote: The qemu_read_password() method looks for \r to terminate the reading of the a password. This is what will be seen when reading the password from a TTY. When scripting though, it is useful to be able to send the password via a pipe, in which

[Qemu-devel] [PULL v2 08/14] qtest/ahci: add halted dma test

2015-05-12 Thread John Snow
If we're going to test the migration of halted DMA jobs, we should probably check to make sure we can resume them locally as a first step. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Message-id: 1430417242-11859-9-git-send-email-js...@redhat.com ---

[Qemu-devel] [PULL v2 06/14] qtest/ahci: add migrate dma test

2015-05-12 Thread John Snow
Write to one guest, migrate, and then read from the other. adjust ahci_io to clear any buffers it creates, so that we can use ahci_io safely on both guests knowing we are using empty buffers and not accidentally re-using data. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Kevin Wolf

[Qemu-devel] [PULL v2 12/14] qtest: add memset to qtest protocol

2015-05-12 Thread John Snow
Previously, memset was just a frontend to write() and only stupidly sent the pattern many times across the wire. Let's not discuss who stupidly wrote it like that in the first place. (Hint: It was me.) Signed-off-by: John Snow js...@redhat.com Message-id:

[Qemu-devel] [PULL v2 00/14] Ide patches

2015-05-12 Thread John Snow
The following changes since commit 968bb75c348a401b85e08d5eb1887a3e6c3185f5: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20150512' into staging (2015-05-12 12:11:32 +0100) are available in the git repository at: https://github.com/jnsnow/qemu.git tags/ide-pull

Re: [Qemu-devel] [PATCH 2/2] s390x: Add laa and laag instructions

2015-05-12 Thread Alexander Graf
On 05/12/2015 05:53 AM, Richard Henderson wrote: On 05/07/2015 06:12 PM, Alexander Graf wrote: +static ExitStatus op_laa(DisasContext *s, DisasOps *o) +{ +TCGv_i64 m2 = tcg_temp_new_i64(); + +/* XXX should be atomic */ +tcg_gen_qemu_ld32s(m2, o-in2, get_mem_index(s)); + +/* Set

Re: [Qemu-devel] [Qemu-block] [PATCH 5/5] tests: add test case for encrypted qcow2 read/write

2015-05-12 Thread Eric Blake
On 05/12/2015 01:06 PM, John Snow wrote: tests/qemu-iotests/131 | 69 ++ tests/qemu-iotests/131.out | 46 +++ Fam Zheng already has a patch on-list that uses test 131, and I think his patch was submitted first.

[Qemu-devel] [PULL v2 01/14] libqos/ahci: Add halted command helpers

2015-05-12 Thread John Snow
Sometimes we want a command to halt the VM instead of complete successfully, so it'd be nice to let the libqos/ahci functions cope with such scenarios. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Message-id: 1430417242-11859-2-git-send-email-js...@redhat.com

[Qemu-devel] [PULL v2 04/14] ich9/ahci: Enable Migration

2015-05-12 Thread John Snow
Lift the flag preventing the migration of the ICH9/AHCI devices. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Message-id: 1430417242-11859-5-git-send-email-js...@redhat.com --- hw/ide/ahci.c | 1 - hw/ide/ich.c | 1 - 2 files changed, 2 deletions(-) diff

[Qemu-devel] [PULL v2 05/14] qtest/ahci: Add migration test

2015-05-12 Thread John Snow
Notes: * The migration is performed on QOSState objects. * The migration is performed in such a way that it does not assume consistency between the allocators attached to each. That is to say, you can use each QOSState object completely independently and then at an arbitrary point

[Qemu-devel] [PULL v2 09/14] qtest/ahci: add migrate halted dma test

2015-05-12 Thread John Snow
Test migrating a halted DMA transaction. Resume, then test data integrity. Signed-off-by: John Snow js...@redhat.com Reviewed-by: Kevin Wolf kw...@redhat.com Message-id: 1430417242-11859-10-git-send-email-js...@redhat.com --- tests/ahci-test.c | 75

Re: [Qemu-devel] Help with deadlock when using sound

2015-05-12 Thread Programmingkid
On May 12, 2015, at 3:45 AM, Paolo Bonzini wrote: On 12/05/2015 00:43, Programmingkid wrote: On May 10, 2015, at 10:54 AM, Paolo Bonzini wrote: On 06/05/2015 18:40, Programmingkid wrote: When I try to use the pcspk sound hardware, QEMU freezes and uses 100% of the cpu time. This is

[Qemu-devel] [PATCH v6 5/7] vmport_rpc: Add migration

2015-05-12 Thread Don Slutz
Signed-off-by: Don Slutz dsl...@verizon.com --- hw/misc/vmport_rpc.c | 250 +++ trace-events | 8 +- 2 files changed, 255 insertions(+), 3 deletions(-) diff --git a/hw/misc/vmport_rpc.c b/hw/misc/vmport_rpc.c index 9a32c6f..fe9cfc5 100644

Re: [Qemu-devel] [Qemu-block] [PATCH 03/34] quorum: Use bdrv_open_image()

2015-05-12 Thread Jeff Cody
On Fri, May 08, 2015 at 07:21:35PM +0200, Kevin Wolf wrote: Besides standardising on a single interface for opening child nodes, this simplifies the .bdrv_open() implementation of the quorum block driver by using block layer functionality for handling BlockdevRefs. Signed-off-by: Kevin Wolf

  1   2   3   >