On 08/26/2015 09:17 AM, Markus Armbruster wrote:
Only reviewing QAPI/QMP and HMP interface parts for now.
I apologize for not having reviewed this series earlier. v8 is awfully
late for the kind of review comments I have.
And I've also been behind the curve, intending to review this since
On Wed, 26 Aug 2015 15:21:59 +0100
Peter Maydell peter.mayd...@linaro.org wrote:
On 26 August 2015 at 11:04, Jason Wang jasow...@redhat.com wrote:
Wildcard mmio eventfd use zero size, but it will lead abort() since it
was illegal in adjust_endianness(). Fix this by allowing zero size.
On Wed, Aug 26, 2015 at 09:25:39AM -0600, Eric Blake wrote:
On 08/26/2015 09:05 AM, Daniel P. Berrange wrote:
The libqemuutil.a archive may contain QOM objects which are
only indirectly referenced via __attribute__((constructor))
annotations. Despite the constructor annotation the linker
On Thu, Aug 20, 2015 at 12:46:47PM +0200, Peter Lieven wrote:
st.st_blocks is always counted in 512 byte units. Do not
use st.st_blksize as multiplicator which may be larger.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven p...@kamp.de
---
block/nfs.c | 2 +-
1 file changed, 1
With the upcoming dumping-via-netfilter patch, the DumpState
should not be related to NetClientState anymore, so move the
related information to a new struct called DumpNetClient.
Signed-off-by: Thomas Huth th...@redhat.com
---
net/dump.c | 73
On 08/26/2015 10:04 PM, Markus Armbruster wrote:
Missed a bunch of revisions of this series, please excuse gaps in my
understanding.
Thank you for the review.
Yang Hongyang yan...@cn.fujitsu.com writes:
Add the framework for a new netfilter object and a new
-netfilter CLI option as a
Add a short description for the command line options.
Signed-off-by: Thomas Huth th...@redhat.com
---
qemu-options.hx | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 390e055..21cf129 100644
--- a/qemu-options.hx
+++
On 08/26/2015 11:11 PM, Eduardo Habkost wrote:
On Mon, Aug 24, 2015 at 05:42:09PM +0800, Zhu Guihua wrote:
Update cpu_model in MachineState for i386, so that the field can be used
for cpu hotplug, instead of using a static variable.
Signed-off-by: Zhu Guihua zhugh.f...@cn.fujitsu.com
[...]
On 08/27/2015 10:33 AM, Thomas Huth wrote:
The -net dump option only works with the -net option. So far, it
is not possible to dump network traffic with the -netdev option yet.
This patch series now fixes this ugliness by enabling dumping for the
netdev devices via the new netfilter
On 2015年08月19日 16:01, gchen gchen wrote:
On 2015年08月15日 04:45, Chen Gang wrote:
On 8/14/15 22:44, Richard Henderson wrote:
On 08/14/2015 02:37 AM, gchen gchen wrote:
- If I implement SW64 tcg backend, I guess, I cann't get help from qemu
upstream: I don't think SW64 is valuable enough for
On 08/27/2015 09:05 AM, Thomas Huth wrote:
On 26/08/15 11:59, Yang Hongyang wrote:
This patch add a new object netfilter, capture all network packets.
Also implement a netbuffer based on this object.
the buffer netfilter could be used by VM FT solutions like
MicroCheckpointing, to
On 08/26/2015 11:58 PM, Markus Armbruster wrote:
Yang Hongyang yan...@cn.fujitsu.com writes:
This patch add a new object netfilter, capture all network packets.
Also implement a netbuffer based on this object.
the buffer netfilter could be used by VM FT solutions like
MicroCheckpointing, to
On 08/26/2015 11:55 PM, Markus Armbruster wrote:
Yang Hongyang yan...@cn.fujitsu.com writes:
now that we have a buffer netfilter, update the command
description and help.
Signed-off-by: Yang Hongyang yan...@cn.fujitsu.com
CC: Luiz Capitulino lcapitul...@redhat.com
CC: Markus Armbruster
From: Liu Yuan liuy...@cmss.chinamobile.com
With reopen supported, block-commit (and offline commit) is now supported for
image files whose base image uses the Sheepdog protocol driver.
Cc: qemu-devel@nongnu.org
Cc: Jeff Cody jc...@redhat.com
Cc: Kevin Wolf kw...@redhat.com
Cc: Stefan Hajnoczi
On Aug 26, 2015, at 6:01 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote:
On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote:
On Aug 26, 2015, at 1:25 PM, Jeff Cody wrote:
On Wed, Aug 26,
Move the creation of the dump client from net_dump_init() into
net_init_dump(), so we can later use the former function for
dump via netfilter, too. Also rename net_dump_init() to
net_dump_state_init() to make it easier distinguishable from
net_init_dump().
Signed-off-by: Thomas Huth
Adding a proper receive_iov function to the net dump module.
This will make it easier to support the dump filter feature for
the -netdev option in later patches.
Signed-off-by: Thomas Huth th...@redhat.com
---
net/dump.c | 24 +---
1 file changed, 21 insertions(+), 3
Add glue code to use the dumping functions as a netdev
filter, too.
Signed-off-by: Thomas Huth th...@redhat.com
---
net/dump.c | 54 ++
net/filter.c | 1 +
net/filters.h| 2 ++
qapi-schema.json | 20 +++-
4 files
The -net dump option only works with the -net option. So far, it
is not possible to dump network traffic with the -netdev option yet.
This patch series now fixes this ugliness by enabling dumping for the
netdev devices via the new netfilter infrastructure. It can be used
like this for example:
On 08/27/2015 10:33 AM, Thomas Huth wrote:
Add glue code to use the dumping functions as a netdev
filter, too.
Overall looks good to me, thanks.
Note that the QAPI part might change later, so there might be some rebase
work later, thanks again!
Signed-off-by: Thomas Huth th...@redhat.com
On 08/26/2015 05:59 PM, Yang Hongyang wrote:
This patch add a new object netfilter, capture all network packets.
Also implement a netbuffer based on this object.
the buffer netfilter could be used by VM FT solutions like
MicroCheckpointing, to buffer/release packets. Or to simulate
packet
On Aug 26, 2015, at 6:04 PM, John Snow wrote:
On 08/26/2015 06:01 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 02:17:17PM -0400, Programmingkid wrote:
On Aug 26, 2015, at 2:08 PM, Jeff Cody wrote:
On Wed, Aug 26, 2015 at 01:29:04PM -0400, Programmingkid wrote:
On Aug 26, 2015, at
On Aug 26, 2015, at 6:08 PM, John Snow wrote:
On 08/26/2015 05:48 PM, Programmingkid wrote:
On Aug 26, 2015, at 2:45 PM, Peter Maydell wrote:
On 26 August 2015 at 18:16, Programmingkid programmingk...@gmail.com
wrote:
That is assuming they have the time and/or the interest in
On 08/26/2015 10:51 PM, Greg Kurz wrote:
On Wed, 26 Aug 2015 15:21:59 +0100
Peter Maydell peter.mayd...@linaro.org wrote:
On 26 August 2015 at 11:04, Jason Wang jasow...@redhat.com wrote:
Wildcard mmio eventfd use zero size, but it will lead abort() since it
was illegal in
301 - 324 of 324 matches
Mail list logo
