Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Chen, Tiejun
On 9/15/2015 7:00 PM, Paolo Bonzini wrote: On 15/09/2015 11:55, Stefano Stabellini wrote: On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { >

[Qemu-devel] [PATCH] MAINTAINERS: Stefan will not maintain net subsystem

2015-09-15 Thread Jason Wang
Talked with Stefan, he will not maintain net subsystem. Cc: Stefan Hajnoczi Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS

Re: [Qemu-devel] [PATCH] spapr_pci: fix device tree props for MSI/MSI-X

2015-09-15 Thread David Gibson
On Tue, Sep 15, 2015 at 04:34:59PM -0500, Michael Roth wrote: > PAPR requires ibm,req#msi and ibm,req#msi-x to be present in the > device node to define the number of msi/msi-x interrupts the device > supports, respectively. > > Currently we have ibm,req#msi-x hardcoded to a non-sensical constant

Re: [Qemu-devel] [PATCH] ppc/spapr: Fix buffer overflow in spapr_populate_drconf_memory()

2015-09-15 Thread David Gibson
On Tue, Sep 15, 2015 at 09:34:20PM +0200, Thomas Huth wrote: > The buffer that is allocated in spapr_populate_drconf_memory() > is used for setting both, the "ibm,dynamic-memory" and the > "ibm,associativity-lookup-arrays" property. However, only the > size of the first one is taken into account

Re: [Qemu-devel] [RFCv2 2/2] spapr: Don't use QOM [*] syntax for DR connectors.

2015-09-15 Thread David Gibson
On Mon, Sep 14, 2015 at 11:03:00PM -0500, Michael Roth wrote: > Quoting David Gibson (2015-09-13 20:41:53) > > The dynamic reconfiguration (hotplug) code for the pseries machine type > > uses a "DR connector" QOM object for each resource it will be possible > > to hotplug. Each of these is added

Re: [Qemu-devel] [PATCH 0/2] target-mips: minor clean up in mtc0 and mfc0

2015-09-15 Thread Aurelien Jarno
On 2015-09-14 13:45, Leon Alrae wrote: > This patchset removes the gen_mtc0_store64() which is actually incorrect > as MTC0 instruction in MIPS64 is supposed to move entire content (if > dst CP0 register is 64-bit) without sign extending. It also removes the > gen_mfc0_load64() and replaces the

Re: [Qemu-devel] [PATCH 11/12] qapi: add md5 checksum of last dirty bitmap level to query-block

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 12:29 PM, Eric Blake wrote: >> On 08/07/2015 03:32 AM, Vladimir Sementsov-Ogievskiy wrote: >>> From: Vladimir Sementsov-Ogievskiy >>> >>> Reviewed-by: John Snow >>> Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH 1/2] target-i386: disable LINT0 after reset

2015-09-15 Thread Jan Kiszka
On 2015-09-15 23:19, Alex Williamson wrote: > On Mon, 2015-04-13 at 02:32 +0300, Nadav Amit wrote: >> Due to old Seabios bug, QEMU reenable LINT0 after reset. This bug is long >> gone >> and therefore this hack is no longer needed. Since it violates the >> specifications, it is removed. >> >>

Re: [Qemu-devel] [PATCH V1] sdhci: Fix hostctl2 write logic.

2015-09-15 Thread Alistair Francis
On Sun, Sep 13, 2015 at 1:36 PM, Peter Crosthwaite wrote: > On Fri, Sep 11, 2015 at 3:30 AM, Sai Pavan Boddu > wrote: >> From: Peter Crosthwaite >> >> This should be a shifted MASKED_WRITE like all other

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > This patch is initially based a patch from Nikolay Nikolaev. > > > > Here is the latest version for adding vhost-user multiple

Re: [Qemu-devel] [PATCH 1/2] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Tue, Sep 15, 2015 at 08:56:05AM -0600, Eric Blake wrote: > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > From: Changchun Ouyang > > > > This patch is initially based a patch from Nikolay Nikolaev. > > Subject line confusion - this is titled 1/2, but in reply to a

Re: [Qemu-devel] [RFCv2 1/2] spapr: Remove unnecessary owner field from sPAPRDRConnector

2015-09-15 Thread David Gibson
On Mon, Sep 14, 2015 at 04:24:23PM +0200, Paolo Bonzini wrote: > > > On 14/09/2015 16:06, Alexey Kardashevskiy wrote: > > > > === * There is no way for a child to determine what its parent > > is. It is not * a bidirectional relationship. This is by > > design. === > > >

[Qemu-devel] [PATCH v2 2/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked. Signed-off-by: Cao jin --- hw/pci/pcie.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/hw/pci/pcie.c b/hw/pci/pcie.c

Re: [Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
On Wed, Sep 16, 2015 at 10:06:56AM +0800, Yuanhan Liu wrote: > On Tue, Sep 15, 2015 at 09:02:07AM -0600, Eric Blake wrote: > > On 09/15/2015 01:10 AM, Yuanhan Liu wrote: > > > From: Changchun Ouyang > > > > > > This patch is initially based a patch from Nikolay

[Qemu-devel] [PATCH v2 0/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Support PCI-e device hot-add multi-function via device_add, just ensure add the function 0 is added last. While allow user to roll back in the middle via device_del, in case user regret. According to Alex`s comment, v2 has following update: 1. patch 1/2 remove if() which seems breaks the

Re: [Qemu-devel] [PATCH 2/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Hi Igor, sorry I missed you mail. On 09/11/2015 10:35 PM, Igor Mammedov wrote: On Thu, 10 Sep 2015 20:12:23 +0800 Cao jin wrote: In case user regret when hot-add multi-function, we should roll back, device_del the function added but still not worked.

[Qemu-devel] [PATCH v2 1/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Enable pcie device multifunction hot, just ensure the function 0 added last, then driver will got the notification to scan all the function in the slot. Signed-off-by: Cao jin --- hw/pci/pcie.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-)

[Qemu-devel] [PATCH] hw/ide/ahci: advance IO buffer offset in multi-sector PIO transfer

2015-09-15 Thread Laszlo Ersek
The "MdeModulePkg/Bus/Ata/AtaAtapiPassThru" driver in edk2 submits a three sector long PIO read, when booting off various Fedora installer ISOs in UEFI mode. With DEBUG_IDE, DEBUG_IDE_ATAPI, DEBUG_AIO and DEBUG_AHCI enabled, plus a DPRINTF(ad->port_no, "offset=%d\n", offset); at the beginning

Re: [Qemu-devel] [RFC PATCH] libcacard: move it to a standalone project

2015-09-15 Thread Dave Airlie
On 15 September 2015 at 23:37, Paolo Bonzini wrote: > On 15/09/2015 15:28, Daniel P. Berrange wrote: >> I have looked through the new libcacard git repository you created >> from QEMU history, and reviewed the extra patches you added on top >> for the build system and it all

[Qemu-devel] [PATCH v6 05/14] blockjob: Introduce reference count

2015-09-15 Thread Fam Zheng
So that block_job_complete_sync can be simplified. Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- block/mirror.c | 2 +- blockjob.c | 22 ++ include/block/blockjob.h | 18 +++--- 3 files changed,

[Qemu-devel] [PATCH v6 03/14] block: rename BlkTransactionState and BdrvActionOps

2015-09-15 Thread Fam Zheng
From: John Snow These structures are misnomers, somewhat. (1) BlockTransactionState is not state for a transaction, but is rather state for a single transaction action. Rename it "BlkActionState" to be more accurate. (2) The BdrvActionOps describes operations for the

[Qemu-devel] [PATCH v6 02/14] iotests: add transactional incremental backup test

2015-09-15 Thread Fam Zheng
From: John Snow Test simple usage cases for using transactions to create and synchronize incremental backups. Signed-off-by: John Snow Reviewed-by: Max Reitz Reviewed-by: Stefan Hajnoczi Signed-off-by: Stefan

[Qemu-devel] [PATCH v6 14/14] tests: add BlockJobTxn unit test

2015-09-15 Thread Fam Zheng
From: Stefan Hajnoczi The BlockJobTxn unit test verifies that both single jobs and pairs of jobs behave as a transaction group. Either all jobs complete successfully or the group is cancelled. Signed-off-by: Stefan Hajnoczi Signed-off-by: Fam Zheng

[Qemu-devel] [PATCH v6 11/14] block/backup: support block job transactions

2015-09-15 Thread Fam Zheng
From: Stefan Hajnoczi Join the transaction when the 'transactional-cancel' QMP argument is true. This ensures that the sync bitmap is not thrown away if another block job in the transaction is cancelled or fails. This is critical so incremental backup with multiple disks

[Qemu-devel] [PATCH v6 09/14] block: Add block job transactions

2015-09-15 Thread Fam Zheng
Sometimes block jobs must execute as a transaction group. Finishing jobs wait until all other jobs are ready to complete successfully. Failure or cancellation of one job cancels the other jobs in the group. Signed-off-by: Stefan Hajnoczi [Rewrite the implementation which is

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:49 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 10:36 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > We're a little too lenient with what we'll let an ATAPI drive handle. > Clamp down on the IDE command execution table to remove CD_OK permissions > from commands that are not and have never been ATAPI commands. > > For ATAPI command validity, please see: > -

Re: [Qemu-devel] [Qemu-stable] About qemu-kvm branch

2015-09-15 Thread Fam Zheng
On Tue, 09/15 14:51, tseng gogo wrote: > Hi , > > Sorry in advance that I am not sure that if I ask this question here is > appropriate. I am new to use KVM and want to do some research in qemu-kvm > live migration. > > In my environment, I install centos 7.0 with rpm install qemu-kvm >

Re: [Qemu-devel] [PATCH RFC 2/4] arm64: kvm: enable trapping of read access to regs in TID3 group

2015-09-15 Thread Tushar Jagad
Hi Shannon, On Tue, Sep 15, 2015 at 12:23:57PM +0800, Shannon Zhao wrote: > > > On 2015/9/9 16:38, Tushar Jagad wrote: > > This patch modifies the HCR_GUEST_FLAGS to enable trapping of > > non secure read to registers under the HCR_EL2.TID3 group to EL2. > > > > We emulate the accesses to

Re: [Qemu-devel] [PATCH v4 2/4] block: support passing 'backing': '' to 'blockdev-add'

2015-09-15 Thread Alberto Garcia
On Tue 15 Sep 2015 04:27:21 AM CEST, Fam Zheng wrote: >> +backing = qdict_get_try_str(options, "backing"); >> +if (backing && *backing == '\0') { >> +flags |= BDRV_O_NO_BACKING; >> +} >> +qdict_del(options, "backing"); >> + > Specifying a non-empty

[Qemu-devel] [PATCH 4/7] vhost-user: add VHOST_USER_GET_QUEUE_NUM message

2015-09-15 Thread Yuanhan Liu
This is for querying how many queues the backend supports if it has mq support(when VHOST_USER_PROTOCOL_F_MQ flag is set from the quried protocol features). vhost_net_get_max_queues() is the interface to export that value, and to tell if the backend supports # of queues user requested, which is

[Qemu-devel] [PATCH 6/7] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang This patch is initially based a patch from Nikolay Nikolaev. Here is the latest version for adding vhost-user multiple queue support, by creating a nc and vhost_net pair for each queue. Qemu exits if find that the backend can't support number

Re: [Qemu-devel] [PATCH 12/17] target-openrisc: Enable m[tf]spr from user mode

2015-09-15 Thread Bastian Koppelmann
On 09/14/2015 07:11 PM, Richard Henderson wrote: On 09/13/2015 01:34 AM, Bastian Koppelmann wrote: Looking at the article, user mode seems to be optional, so I'm not against it, but it does look weird. How does ork1sim do it? It's haphazard. There are checks for supervisor in the l_mtspr

Re: [Qemu-devel] [PATCH 5/9] virtio-gpu: add 3d mode and virgl rendering support.

2015-09-15 Thread Gerd Hoffmann
Hi, > > +virtio_gpu_cleanup_mapping_iov(res_iovs, num_iovs); > > Is res_iovs leaked here? Oops, yes. Moving the iov release to virtio_gpu_cleanup_mapping_iov (so things is symmetrical to virtio_gpu_create_mapping_iov which allocates it), that'll fix it. > > +pixels =

Re: [Qemu-devel] [PATCH v3 1/1] atapi: abort transfers with 0 byte limits

2015-09-15 Thread Markus Armbruster
John Snow writes: > We're supposed to abort on transfers like this, unless we fill > Word 125 of our IDENTIFY data with a default transfer size, which > we don't currently do. > > This is an ATA error, not a SCSI/ATAPI one. > See ATA8-ACS3 sections 7.17.6.49 or 7.21.5.

[Qemu-devel] [PATCH v6 01/14] qapi: Add transaction support to block-dirty-bitmap operations

2015-09-15 Thread Fam Zheng
From: John Snow This adds two qmp commands to transactions. block-dirty-bitmap-add allows you to create a bitmap simultaneously alongside a new full backup to accomplish a clean synchronization point. block-dirty-bitmap-clear allows you to reset a bitmap back to as-if it were

[Qemu-devel] [PATCH v6 04/14] backup: Extract dirty bitmap handling as a separate function

2015-09-15 Thread Fam Zheng
This will be reused by the coming new transactional completion code. Signed-off-by: Fam Zheng Reviewed-by: John Snow --- block/backup.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/block/backup.c

[Qemu-devel] [PATCH v6 00/14] block: incremental backup transactions using BlockJobTxn

2015-09-15 Thread Fam Zheng
v6: Address comments from Max and Eric (many thanks for reviewing!): Add Max's reviews. Don't leak txn. [Max] Unusual comment ending "**/" -> "*/". [Eric] Fix the stale block_job_txn_prepare_to_complete comment. [Max] Move "block_job_txn_unref" to below FOREACH block. [Max]

Re: [Qemu-devel] [PATCH v8 0/7] sPAPR: Support EEH Error Injection

2015-09-15 Thread Thomas Huth
On 14/09/15 06:14, David Gibson wrote: > On Mon, Sep 14, 2015 at 11:36:08AM +1000, Gavin Shan wrote: >> The patchset depends on below Linux upstream commits: >> >> commit ed3e81f ("powerpc/eeh: Move PE state constants around") >> commit ec33d36 ("powerpc/eeh: Introduce eeh_pe_inject_err()") >>

[Qemu-devel] [PATCH v6 06/14] blockjob: Add .commit and .abort block job actions

2015-09-15 Thread Fam Zheng
Reviewed-by: Max Reitz Signed-off-by: Fam Zheng --- include/block/blockjob.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/block/blockjob.h b/include/block/blockjob.h index 3e7ad21..a7b497c 100644 ---

Re: [Qemu-devel] [PATCH] q35: Remove old machine versions

2015-09-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Mon, Sep 14, 2015 at 09:09:12AM -0600, Eric Blake wrote: >> On 09/13/2015 03:28 AM, Michael S. Tsirkin wrote: >> > On Fri, Sep 11, 2015 at 03:44:47PM -0300, Eduardo Habkost wrote: >> >> Ping? >> >> >> >> So, what's the reason we are still keeping

[Qemu-devel] iotests failure of 128

2015-09-15 Thread Fam Zheng
Since commit 934659c460d46c948cf348822fda1d38556ed9a4 (iotests: Do not suppress segfaults in bash tests), sudo in 128 complains about unknown command "_qemu_io_wrapper", but I don't know how to fix that. Any idea? 128 - output mismatch (see 128.out.bad) ---

[Qemu-devel] [PATCH v6 07/14] blockjob: Add "completed" and "ret" in BlockJob

2015-09-15 Thread Fam Zheng
They are set when block_job_completed is called. Signed-off-by: Fam Zheng Reviewed-by: John Snow Reviewed-by: Max Reitz --- blockjob.c | 3 +++ include/block/blockjob.h | 9 + 2 files changed, 12 insertions(+) diff

[Qemu-devel] [PATCH v6 08/14] blockjob: Simplify block_job_finish_sync

2015-09-15 Thread Fam Zheng
With job->completed and job->ret to replace BlockFinishData. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz --- blockjob.c | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/blockjob.c b/blockjob.c index

[Qemu-devel] [PATCH v6 13/14] qmp-commands.hx: Update the supported 'transaction' operations

2015-09-15 Thread Fam Zheng
From: Kashyap Chamarthy Although the canonical source of reference for QMP commands is qapi-schema.json, for consistency's sake, update qmp-commands.hx to state the list of supported transactionable operations, namely: drive-backup blockdev-backup

[Qemu-devel] [PATCH v6 10/14] blockdev: make BlockJobTxn available to qmp 'transaction'

2015-09-15 Thread Fam Zheng
From: Stefan Hajnoczi Provide a BlockJobTxn to actions executed in a qmp 'transaction' command. This allows actions to make their block jobs either complete as a group or fail/cancel together. The next patch adds the first user. Signed-off-by: Stefan Hajnoczi

[Qemu-devel] [PATCH 1/7] vhost-user: use VHOST_USER_XXX macro for switch statement

2015-09-15 Thread Yuanhan Liu
So that we could let vhost_user_call to handle extented requests, such as VHOST_USER_GET/SET_PROTOCOL_FEATURES, instead of invoking vhost_user_read/write and constructing the msg again by ourself. Signed-off-by: Yuanhan Liu --- hw/virtio/vhost-user.c | 38

[Qemu-devel] [PATCH 0/7 v9] vhost-user multiple queue support

2015-09-15 Thread Yuanhan Liu
Hi, Here is the updated patch set for enabling vhost-user multiple queue. This patch set introduces 2 more vhost user messages: VHOST_USER_GET_QUEUE_NUM, for querying how many queues the backend supports, and VHOST_USER_SET_VRING_ENABLE, for enabling/disabling a specific virt queue. Both of

[Qemu-devel] [PATCH 3/7] vhost: rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE

2015-09-15 Thread Yuanhan Liu
Quote from Michael: We really should rename VHOST_RESET_OWNER to VHOST_RESET_DEVICE. Suggested-by: Michael S. Tsirkin Signed-off-by: Yuanhan Liu --- docs/specs/vhost-user.txt | 4 ++-- hw/net/vhost_net.c | 2 +-

Re: [Qemu-devel] [PATCH 6/9] sdl2/opengl: add opengl context and scanout support

2015-09-15 Thread Gerd Hoffmann
Hi, > > +scon->scanout_mode = scanout; > > +if (!scon->scanout_mode) { > > +if (scon->fbo_id) { > > +glFramebufferTexture2DEXT(GL_FRAMEBUFFER_EXT, > > + GL_COLOR_ATTACHMENT0_EXT, > > +

[Qemu-devel] [PATCH 1/2] vhost-user: add multiple queue support

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang This patch is initially based a patch from Nikolay Nikolaev. Here is the latest version for adding vhost-user multiple queue support, by creating a nc and vhost_net pair for each queue. What differs from last version is that this patch

[Qemu-devel] [PATCH 7/7] vhost-user: add a new message to disable/enable a specific virt queue.

2015-09-15 Thread Yuanhan Liu
From: Changchun Ouyang Add a new message, VHOST_USER_SET_VRING_ENABLE, to enable or disable a specific virt queue, which is similar to attach/detach queue for tap device. virtio driver on guest doesn't have to use max virt queue pair, it could enable any number of

Re: [Qemu-devel] [PATCH 1/9] shaders: initialize vertexes once

2015-09-15 Thread Gerd Hoffmann
> > Therefore, I'm not sure whether deleting the buffer is right here. Maybe > > OpenGL uses reference counting here, too, so it remembers that the > > buffer is still in use by the VAO, and so the glDeleteBuffers() > > operation will only decrease its refcount, but not actually end up > >

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 10:36 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:37 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 11:47 PM, Eric Blake wrote: >>> On 09/14/2015 08:27 AM, Markus Armbruster wrote: Wen Congyang writes: > The NBD driver needs: filename, path or

[Qemu-devel] [PATCH v6 12/14] iotests: 124 - transactional failure test

2015-09-15 Thread Fam Zheng
From: John Snow Use a transaction to request an incremental backup across two drives. Coerce one of the jobs to fail, and then re-run the transaction. Verify that no bitmap data was lost due to the partial transaction failure. To support the 'transactional-cancel' QMP

Re: [Qemu-devel] [PATCH 1/2] PCI-e device multi-function hot-add support

2015-09-15 Thread Cao jin
Hi, Alex, Thanks very much for your quick review and I am sorry for my late response. On 09/10/2015 11:29 PM, Alex Williamson wrote: On Thu, 2015-09-10 at 20:12 +0800, Cao jin wrote: Enable PCI-e device multifunction hot, just ensure the function 0 added last, then driver will got the

Re: [Qemu-devel] virtio-gpu: cursor update not in sync with resource update

2015-09-15 Thread Gerd Hoffmann
Hi, > >> if (!ret) { > >> reservation_object_add_excl_fence(qobj->tbo.resv, > >> >f); > >> virtio_gpu_object_wait(qobj, false); > >> } > >> > >> before moving the cursor, shouldn't that suffice? >

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == _mem_unassigned' failed

2015-09-15 Thread Gonglei
On 2015/9/15 9:16, Gonglei wrote: > On 2015/9/14 17:28, Paolo Bonzini wrote: >> >> >> On 14/09/2015 10:01, Gonglei (Arei) wrote: >>> [2015-09-11 13:42:44] domain is rebooting >>> qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188: >>> register_subpage: Assertion

[Qemu-devel] [PATCH 5/7] vhost: introduce vhost_backend_get_vq_index method

2015-09-15 Thread Yuanhan Liu
Minusing the idx with the base(dev->vq_index) for vhost-kernel, and then adding it back for vhost-user doesn't seem right. Here introduces a new method vhost_backend_get_vq_index() for getting the right vq index for following vhost messages calls. Suggested-by: Jason Wang

[Qemu-devel] [PATCH 2/7] vhost-user: add protocol feature negotiation

2015-09-15 Thread Yuanhan Liu
From: "Michael S. Tsirkin" Support a separate bitmask for vhost-user protocol features, and messages to get/set protocol features. Invoke them at init. No features are defined yet. v2: leverage vhost_user_call for request handling -- Yuanhan Liu Signed-off-by: Michael S.

Re: [Qemu-devel] [PATCH v3 1/5] support nbd driver in blockdev-add

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 11:47 PM, Eric Blake wrote: >> On 09/14/2015 08:27 AM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> The NBD driver needs: filename, path or (host, port, exportname). It checks which key exists

Re: [Qemu-devel] [PATCH RFC 2/4] arm64: kvm: enable trapping of read access to regs in TID3 group

2015-09-15 Thread Shannon Zhao
On 2015/9/15 15:18, Tushar Jagad wrote: > > Hi Shannon, > > On Tue, Sep 15, 2015 at 12:23:57PM +0800, Shannon Zhao wrote: >> >> >> On 2015/9/9 16:38, Tushar Jagad wrote: >>> This patch modifies the HCR_GUEST_FLAGS to enable trapping of >>> non secure read to registers under the HCR_EL2.TID3

Re: [Qemu-devel] [PATCH v3 0/6] qemu: guest agent: implement guest-exec command

2015-09-15 Thread Vasiliy Tolstov
2015-06-15 10:07 GMT+03:00 Denis V. Lunev : > _PING_ Any news about this feature? I'm need to run inside guest some scripts and want non blocking exec, so this feature very useful for me. -- Vasiliy Tolstov, e-mail: v.tols...@selfip.ru

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:53 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> We're a little too lenient with what we'll let an ATAPI drive handle. >>> Clamp down on the IDE command execution table to remove CD_OK permissions >>> from

Re: [Qemu-devel] [PATCH RFC v5 00/32] qapi: QMP introspection

2015-09-15 Thread Markus Armbruster
Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH v7 00/26] qapi: QMP introspection

2015-09-15 Thread Markus Armbruster
Commit 351d36e "qapi: allow override of default enum prefix naming" got in first. The rebase is non-trivial, so a full respin is necessary. Clock for pull request will be reset...

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:11 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:53 AM, Markus Armbruster wrote: >>> John Snow writes: >>> We're a little too lenient with what we'll let an ATAPI drive handle. Clamp down on the IDE

[Qemu-devel] [PATCH 2/8] target-i386: Make check_hw_breakpoints static

2015-09-15 Thread Richard Henderson
The function is now only used from within a single file. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 2 +- target-i386/cpu.h| 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/target-i386/bpt_helper.c b/target-i386/bpt_helper.c

Re: [Qemu-devel] [PATCH v2 09/18] nvdimm: build ACPI NFIT table

2015-09-15 Thread Igor Mammedov
On Tue, 15 Sep 2015 18:12:43 +0200 Paolo Bonzini wrote: > > > On 14/08/2015 16:52, Xiao Guangrong wrote: > > NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) > > > > Currently, we only support PMEM mode. Each device has 3 tables: > > - SPA table,

[Qemu-devel] [PATCH 0/8] target-i386: Implement debug extensions

2015-09-15 Thread Richard Henderson
Best guess, since I can't find any code that actually uses them. Linux actively turns them off at boot... r~ Richard Henderson (8): target-i386: Move breakpoint related functions to new file target-i386: Make check_hw_breakpoints static target-i386: Introduce cpu_x86_update_dr7

[Qemu-devel] [PATCH 3/8] target-i386: Introduce cpu_x86_update_dr7

2015-09-15 Thread Richard Henderson
This moves the last of the iteration over breakpoints into the bpt_helper.c file. This also allows us to make several breakpoint functions static. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 ++--- target-i386/cpu.h| 4

[Qemu-devel] [PATCH 1/8] target-i386: Move breakpoint related functions to new file

2015-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/Makefile.objs | 2 +- target-i386/bpt_helper.c | 182 ++ target-i386/helper.c | 128 target-i386/misc_helper.c | 34 - 4 files changed,

[Qemu-devel] [PATCH 8/8] target-i386: Check CR4[DE] for processing DR4/DR5

2015-09-15 Thread Richard Henderson
Introduce helper_get_dr so that we don't have to put CR4[DE] into the scarce HFLAGS resource. At the same time, rename helper_movl_drN_T0 to helper_set_dr and set the helper flags. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 46

Re: [Qemu-devel] [PATCH v2 3/5] acpi: pc: add fw_cfg device node to ssdt

2015-09-15 Thread Eduardo Habkost
On Mon, Sep 14, 2015 at 04:54:25PM -0400, Gabriel L. Somlo wrote: > On Mon, Sep 14, 2015 at 04:34:02PM -0400, Gabriel L. Somlo wrote: > > > > So I'll replace the "if (guest_info->fw_cfg)" check with > > > > "if machine-type >= (pc-q35-2.5 or pc-i440fx-2.5))", in v3, > > > > as soon as the patches

[Qemu-devel] Canceled Event: Dr Velano @ Wed Sep 16, 2015 17:50 - 18:50 (shlomopongr...@gmail.com)

2015-09-15 Thread shlomopongratz
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:CANCEL BEGIN:VEVENT DTSTART:20150916T145000Z DTEND:20150916T155000Z DTSTAMP:20150915T184155Z ORGANIZER;CN=Shlomo Pongratz:mailto:shlomopongr...@gmail.com

[Qemu-devel] [PATCH 6/8] target-i386: Optimize setting dr[0-3]

2015-09-15 Thread Richard Henderson
If the debug register is not enabled, we need do nothing besides update the register. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/target-i386/bpt_helper.c

[Qemu-devel] [PATCH 5/8] target-i386: Move hw_*breakpoint_* functions

2015-09-15 Thread Richard Henderson
They're only used from bpt_helper.c now. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 29 - target-i386/cpu.h| 27 --- 2 files changed, 28 insertions(+), 28 deletions(-) diff --git

[Qemu-devel] [PATCH 4/8] target-i386: Re-introduce optimal breakpoint removal

2015-09-15 Thread Richard Henderson
Before the last patch, we had an efficient loop that disabled local breakpoints on task switch. Re-add that, but in a more general way that handles changes to the global enable bits too. Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 34

[Qemu-devel] [PATCH 7/8] target-i386: Handle I/O breakpoints

2015-09-15 Thread Richard Henderson
Signed-off-by: Richard Henderson --- target-i386/bpt_helper.c | 99 +++- target-i386/cpu.h| 2 + target-i386/helper.h | 1 + target-i386/translate.c | 20 +- 4 files changed, 94 insertions(+), 28 deletions(-)

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread Markus Armbruster
John Snow writes: > On 09/15/2015 02:11 PM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: John Snow writes: > We're a little too lenient with what we'll let an ATAPI

Re: [Qemu-devel] [PATCH] ide: fix ATAPI command permissions

2015-09-15 Thread John Snow
On 09/15/2015 02:50 PM, Markus Armbruster wrote: > John Snow writes: > >> On 09/15/2015 02:11 PM, Markus Armbruster wrote: >>> John Snow writes: >>> On 09/15/2015 02:53 AM, Markus Armbruster wrote: > John Snow writes: >

Re: [Qemu-devel] [PATCH 3/9] ui/console: add opengl context and scanout support interfaces.

2015-09-15 Thread Paolo Bonzini
On 09/09/2015 13:20, Gerd Hoffmann wrote: > +typedef void *qemu_gl_context; > + > +struct qemu_gl_params { > +int major_ver; > +int minor_ver; > +}; > + Please use QEMUGLContext and QEMUGLParams (with a typedef for the latter). Paolo

[Qemu-devel] [PATCH] pci-assign: do not include sys/io.h

2015-09-15 Thread Paolo Bonzini
This file does not exist on bionic libc and the functions it defines are in fact not used by pci-assign.c. Remove it. Reported-by: Houcheng Lin Signed-off-by: Paolo Bonzini --- hw/i386/kvm/pci-assign.c | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Alberto Garcia
On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: >> +{ 'command': 'x-child-add', >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > This is probably not future-proof and only made for the special case > of quorum. Specifically, one thing I'm missing is some way to

Re: [Qemu-devel] [Question] QEMU 2.3 Assertion with `existing->mr->subpage || existing->mr == _mem_unassigned' failed

2015-09-15 Thread Gonglei
On 2015/9/15 14:33, Gonglei wrote: > On 2015/9/15 9:16, Gonglei wrote: >> On 2015/9/14 17:28, Paolo Bonzini wrote: >>> >>> >>> On 14/09/2015 10:01, Gonglei (Arei) wrote: [2015-09-11 13:42:44] domain is rebooting qemu-kvm: /home/abuild/rpmbuild/BUILD/qemu-kvm-2.3.0/exec.c:1188:

Re: [Qemu-devel] [PATCH] ppc/spapr: Allow VIRTIO_VGA

2015-09-15 Thread Gerd Hoffmann
On Di, 2015-09-15 at 15:51 +1000, Benjamin Herrenschmidt wrote: > It works fine with the Linux driver out of the box Do you actually want the vga compatibility bits on pseries? There also is virtio-gpu-pci (same thing as virtio-vga but without vga compatibility), which should already be enabled

[Qemu-devel] [PATCH 5/9] monitor: make monitor_fprintf and mon_get_cpu externally visible

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin monitor_fprintf and mon_get_cpu will be used in the target-specific monitor, so it is advisable to make it external. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber

[Qemu-devel] [PATCH v2 0/9] hmp command IO- and Local APIC dump state

2015-09-15 Thread Denis V. Lunev
Added the hmp command to query IO- and Local APIC registers state, it can be very useful to identify problems related to the emulation devices. (qemu) info apic-local apic.lvt00-timer 000300fd int=fd .H.EMP delmod=0:Fixed apic.lvt00-thermal 0001 int=00 .H.EM. delmod=0:Fixed apic.lvt

Re: [Qemu-devel] [Qemu-block] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Kevin Wolf
Am 15.09.2015 um 11:20 hat Kevin Wolf geschrieben: > Am 15.09.2015 um 10:56 hat Alberto Garcia geschrieben: > > On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: > > > > >> +{ 'command': 'x-child-add', > > >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > > > > >

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix issue for checking ptr in different address spaces in TARGET_CMSG_NXTHDR

2015-09-15 Thread Chen Gang
yes, foe me, they are the same. :-) Thanks. > From: peter.mayd...@linaro.org > Date: Tue, 15 Sep 2015 09:10:40 +0100 > Subject: Re: [PATCH] linux-user/syscall.c: Fix issue for checking ptr in > different address spaces in TARGET_CMSG_NXTHDR > To: gang.chen.5...@gmail.com > CC:

Re: [Qemu-devel] [PULL 0/19] xen-2015-09-08-tag

2015-09-15 Thread Stefano Stabellini
On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 12:29, Stefano Stabellini wrote: > > +if (lseek(config_fd, pos, SEEK_SET) != pos) { > > +return -errno; > > +} > > do { > > -rc = pread(config_fd, (uint8_t *), len, pos); > > +rc = read(config_fd,

Re: [Qemu-devel] [PULL 21/29] xen/pt: Sync up the dev.config and data values.

2015-09-15 Thread Stefano Stabellini
CC Konrad On Mon, 14 Sep 2015, Paolo Bonzini wrote: > On 10/09/2015 19:15, Stefano Stabellini wrote: > > + > > +switch (reg->size) { > > +case 1: rc = xen_host_pci_get_byte(>real_device, offset, > > (uint8_t *)); > > A bit ugly, and it relies on the host being little endian. >

Re: [Qemu-devel] [PATCH] linux-user/syscall.c: Fix issue for checking ptr in different address spaces in TARGET_CMSG_NXTHDR

2015-09-15 Thread Peter Maydell
On 15 September 2015 at 04:01, wrote: > From: Chen Gang > > After fix this issue, qemu can run i386 wine notepad.exe successfully. > But the initialization performance is not quite well. > > Signed-off-by: Chen Gang

[Qemu-devel] [PATCH 6/9] hmp: added local apic dump state

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added the hmp command to query local apic registers state, may be usefull after guest crashes to understand IRQ routing in guest. For command name uses "apic-local" because it has to be grouped with command "apic-io". (qemu) info apic-local

[Qemu-devel] [PATCH 4/9] apic_internal.h: fix formatting and drop unused consts

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Fix formatting of local apic definitions and drop unused constant APIC_INPUT_POLARITY, APIC_SEND_PENDING. Magic numbers in shifts are replaced with constants defined just above. Signed-off-by: Pavel Butsykin Signed-off-by:

[Qemu-devel] [PATCH 7/9] ioapic_internal.h: added more constants

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added the masks for easy access to fields of the redirection table entry Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini

[Qemu-devel] [PATCH 1/9] apic_internal.h: move apic_get_bit(), apic_set_bit() to apic_internal.h

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin It's necessary to work with bitmap isr, tmr, irr outside hw/intc/apic.c Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini

[Qemu-devel] [PATCH 2/9] apic_internal.h: rename ESR_ILLEGAL_ADDRESS to APIC_ESR_ILLEGAL_ADDRESS

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added prefix APIC_ for determining the constant of a particular subsystem, improve the overall readability and match other constant names. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC:

[Qemu-devel] [PATCH 9/9] hmp: implemented io apic dump state for TCG

2015-09-15 Thread Denis V. Lunev
From: Pavel Butsykin Added support emulator for the hmp command "info apic-io" Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev CC: Andreas Färber CC: Paolo Bonzini ---

  1   2   3   4   >